Do we need to put out a new alpha image with a recompileAll?
On Sun, Apr 28, 2013 at 12:44 PM, commits@source.squeak.org wrote:
Colin Putney uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cwp.526.mcz
==================== Summary ====================
Name: System-cwp.526 Author: cwp Time: 28 April 2013, 10:43:06.298 am UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c Ancestors: System-ul.525
Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.
=============== Diff against System-ul.525 ===============
Item was changed: ----- Method: Behavior>>allCallsOn (in category '*System-Support') ----- allCallsOn "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict."
| theClass | theClass := self theNonMetaClass.
^(self systemNavigation allCallsOn: (self environment bindingOf: theClass name)),
^(self systemNavigation allCallsOn: (self environment associationAt: theClass name)), (Preferences thoroughSenders ifTrue: [OrderedCollection new] ifFalse: [self systemNavigation allCallsOn: theClass name]), (self systemNavigation allClasses select: [:c| c sharedPools includes: theClass] thenCollect: [:c| ClassReference new setClassSymbol: c name classIsMeta: false stringVersion: c name])!
As in publish one to ftp.squeak.org? I don't see how it could hurt. Tobias would also like to publish a Seaside-on-4.5 image too, IIRC. (Apologies for my lack of response there, Tobias.)
frank
On 29 April 2013 01:34, Chris Muller asqueaker@gmail.com wrote:
Do we need to put out a new alpha image with a recompileAll?
On Sun, Apr 28, 2013 at 12:44 PM, commits@source.squeak.org wrote:
Colin Putney uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cwp.526.mcz
==================== Summary ====================
Name: System-cwp.526 Author: cwp Time: 28 April 2013, 10:43:06.298 am UUID: d0a7abd6-1556-4900-b5ca-640d1aed4d7c Ancestors: System-ul.525
Update Behavior>>allCallsOn to search for references using #bindingOf: rather than #associationAt:. This matches the binding created by the compiler.
=============== Diff against System-ul.525 ===============
Item was changed: ----- Method: Behavior>>allCallsOn (in category '*System-Support') ----- allCallsOn "Answer a SortedCollection of all the methods that refer to me by name or as part of an association in a global dict."
| theClass | theClass := self theNonMetaClass.
^(self systemNavigation allCallsOn: (self environment bindingOf: theClass name)),
^(self systemNavigation allCallsOn: (self environment associationAt: theClass name)), (Preferences thoroughSenders ifTrue: [OrderedCollection new] ifFalse: [self systemNavigation allCallsOn: theClass name]), (self systemNavigation allClasses select: [:c| c sharedPools includes: theClass] thenCollect: [:c| ClassReference new setClassSymbol: c name classIsMeta: false stringVersion: c name])!
On Sun, Apr 28, 2013 at 5:34 PM, Chris Muller asqueaker@gmail.com wrote:
Do we need to put out a new alpha image with a recompileAll?
Yeah, that would be good.
But it won't work at the moment, because Encoder>>litIndex: has a halt in it. Eliot, the method has your initials. Do you remember what that was for?
Colin
On 29 April 2013 08:17, Colin Putney colin@wiresong.com wrote:
On Sun, Apr 28, 2013 at 5:34 PM, Chris Muller asqueaker@gmail.com wrote:
Do we need to put out a new alpha image with a recompileAll?
Yeah, that would be good.
But it won't work at the moment, because Encoder>>litIndex: has a halt in it. Eliot, the method has your initials. Do you remember what that was for?
Why won't it work? In practice, I mean, not in theory. ReleaseSqueakTrunk's artifact has had a recompileAll, as part of ReleaseBuilderFor4dot5 prepareNewBuild.
(But don't bother checking Squeak4.5-12475 or earlier; SOMEONE left the ToolSet set to CommandLineToolSet, which means the image will quit very quickly with a stacktrace on stdout. *ahem*. I've fixed the problem and the next build should work.
frank
Colin
On 2013-04-29, at 2:52 AM, Frank Shearar frank.shearar@gmail.com wrote:
Why won't it work? In practice, I mean, not in theory.
Oh, just 'cause that method is part of the compiler, and recompileAll will eventually trigger the halt.
On 29 April 2013 15:40, Colin Putney colin@wiresong.com wrote:
On 2013-04-29, at 2:52 AM, Frank Shearar frank.shearar@gmail.com wrote:
Why won't it work? In practice, I mean, not in theory.
Oh, just 'cause that method is part of the compiler, and recompileAll will eventually trigger the halt.
OK, so happenstance that it hadn't yet happened.
frank
On 2013-04-29, at 7:47 AM, Frank Shearar frank.shearar@gmail.com wrote:
On 29 April 2013 15:40, Colin Putney colin@wiresong.com wrote:
On 2013-04-29, at 2:52 AM, Frank Shearar frank.shearar@gmail.com wrote:
Why won't it work? In practice, I mean, not in theory.
Oh, just 'cause that method is part of the compiler, and recompileAll will eventually trigger the halt.
OK, so happenstance that it hadn't yet happened.
Well, it happened when I tried to recompile my image. I admit I may have over-generalized from that experience. :-)
I've reverted the halt - it's probably only for debugging purpose.
2013/4/29 Colin Putney colin@wiresong.com
On Sun, Apr 28, 2013 at 5:34 PM, Chris Muller asqueaker@gmail.com wrote:
Do we need to put out a new alpha image with a recompileAll?
Yeah, that would be good.
But it won't work at the moment, because Encoder>>litIndex: has a halt in it. Eliot, the method has your initials. Do you remember what that was for?
Colin
squeak-dev@lists.squeakfoundation.org