Diego Gomez Deck wrote:

Hi Mike,

I'm not sure of this is the final wanted shape for Semaphore>>critical (From 6755SemaCritical):

...

See http://tech.groups.yahoo.com/group/squeak/message/123504 for an explanation from Andreas.

I wasn't quite sure what the final conclusion of that discussion was and went with the change sets that are on Mantis. But, that might not have been the latest version? Andreas?

Michael

Diego Gomez Deck wrote:

I'm not sure of this is the final wanted shape for Semaphore>>critical (From 6755SemaCritical):

The update contains the correct version. The tests at

http://bugs.squeak.org/view.php?id=6588

will confirm it (they cover all the "interesting" situations). Also, if you look at the update in question, you'll find that the "other half" of the fix is in Process>>terminate (which ain't nice but works for now).

Cheers, - Andreas

critical: mutuallyExcludedBlock

"Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished."

| blockValue caught |

caught := false. [ caught := true. self wait. blockValue := mutuallyExcludedBlock value ] ensure: [caught ifTrue: [self signal]].

^blockValue

There was a bit of discussion about putting the "caught" flag AFTER the wait. Something like:

self wait.
caught := true. "signal the flag just after we got the semaphore"

See http://tech.groups.yahoo.com/group/squeak/message/123504 for an explanation from Andreas.

Cheers,

-- Diego

...

Hi all,

I put up an updated set of updates for 3.8.2 here: http://impara.de/~michael/proposed-3.8.2.zip

If no major problems turn up I would like to push those tomorrow or so.

Michael

On Nov 15, 2007, at 10:20 AM, Edgar J. De Cleene wrote:

We have only two yellow test for Mac in last Squeak3.10.1beta. 7155.image.

And we test on three major OS (Windows XP, OS X, Linux) all we do.

Edgar

So what would the failing "two yellow test " be?

-- = = = ======================================================================== John M. McIntosh johnmci@smalltalkconsulting.com Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================