A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.929.mcz
==================== Summary ====================
Name: Tools-jr.929 Author: jr Time: 30 December 2019, 3:20:08.513977 pm UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466 Ancestors: Tools-cmm.928
Show browsed environment in Browser title if it is not the default environment.
=============== Diff against Tools-cmm.928 ===============
Item was changed: ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle + | title | + title := 'System Browser'. + ^ environment = self class environment + ifTrue: [title] + ifFalse: [title, ' on environment ', environment asString]! - ^ 'System Browser'!
Good idea! Maybe add some #translated stuff?
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Montag, 30. Dezember 2019 15:20:09 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: Tools-jr.929.mcz
A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.929.mcz
==================== Summary ====================
Name: Tools-jr.929 Author: jr Time: 30 December 2019, 3:20:08.513977 pm UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466 Ancestors: Tools-cmm.928
Show browsed environment in Browser title if it is not the default environment.
=============== Diff against Tools-cmm.928 ===============
Item was changed: ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle + | title | + title := 'System Browser'. + ^ environment = self class environment + ifTrue: [title] + ifFalse: [title, ' on environment ', environment asString]! - ^ 'System Browser'!
Not until the general idea meets approval ;-) after that, sure why not.
Am Mo., 30. Dez. 2019 um 15:25 Uhr schrieb Thiede, Christoph < Christoph.Thiede@student.hpi.uni-potsdam.de>:
Good idea! Maybe add some #translated stuff?
*Von:* Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org *Gesendet:* Montag, 30. Dezember 2019 15:20:09 *An:* squeak-dev@lists.squeakfoundation.org *Betreff:* [squeak-dev] The Inbox: Tools-jr.929.mcz
A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.929.mcz
==================== Summary ====================
Name: Tools-jr.929 Author: jr Time: 30 December 2019, 3:20:08.513977 pm UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466 Ancestors: Tools-cmm.928
Show browsed environment in Browser title if it is not the default environment.
=============== Diff against Tools-cmm.928 ===============
Item was changed: ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle
| title |title := 'System Browser'.^ environment = self class environmentifTrue: [title]ifFalse: [title, ' on environment ', environmentasString]!
^ 'System Browser'!
+1
On 30.12.2019, at 15:20, commits@source.squeak.org wrote:
A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.929.mcz
==================== Summary ====================
Name: Tools-jr.929 Author: jr Time: 30 December 2019, 3:20:08.513977 pm UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466 Ancestors: Tools-cmm.928
Show browsed environment in Browser title if it is not the default environment.
=============== Diff against Tools-cmm.928 ===============
Item was changed: ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle
- | title |
- title := 'System Browser'.
- ^ environment = self class environment
ifTrue: [title]ifFalse: [title, ' on environment ', environment asString]!
- ^ 'System Browser'!
+1 Dave
On Wed, Jan 01, 2020 at 09:35:34PM +0100, Tobias Pape wrote:
+1
On 30.12.2019, at 15:20, commits@source.squeak.org wrote:
A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.929.mcz
==================== Summary ====================
Name: Tools-jr.929 Author: jr Time: 30 December 2019, 3:20:08.513977 pm UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466 Ancestors: Tools-cmm.928
Show browsed environment in Browser title if it is not the default environment.
=============== Diff against Tools-cmm.928 ===============
Item was changed: ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle
- | title |
- title := 'System Browser'.
- ^ environment = self class environment
ifTrue: [title]ifFalse: [title, ' on environment ', environment asString]!
- ^ 'System Browser'!
I also tried it like this:
Browser>>defaultBrowserTitle ^ 'System Browser on environment ', self class environment asString
And it seems quite acceptable to me. It serves as a reminder that environments exist :-)
I'm not proposing that as a change, just making note of it.
Dave
On Thu, Jan 02, 2020 at 11:32:08AM -0500, David T. Lewis wrote:
+1 Dave
On Wed, Jan 01, 2020 at 09:35:34PM +0100, Tobias Pape wrote:
+1
On 30.12.2019, at 15:20, commits@source.squeak.org wrote:
A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-jr.929.mcz
==================== Summary ====================
Name: Tools-jr.929 Author: jr Time: 30 December 2019, 3:20:08.513977 pm UUID: 0a4d62fd-022e-1844-b6bc-db1502ab2466 Ancestors: Tools-cmm.928
Show browsed environment in Browser title if it is not the default environment.
=============== Diff against Tools-cmm.928 ===============
Item was changed: ----- Method: Browser>>defaultBrowserTitle (in category 'initialize-release') ----- defaultBrowserTitle
- | title |
- title := 'System Browser'.
- ^ environment = self class environment
ifTrue: [title]ifFalse: [title, ' on environment ', environment asString]!
- ^ 'System Browser'!
Am Do., 2. Jan. 2020 um 17:45 Uhr schrieb David T. Lewis < lewis@mail.msen.com>:
I also tried it like this:
Browser>>defaultBrowserTitle ^ 'System Browser on environment ', self class environment asString
And it seems quite acceptable to me. It serves as a reminder that environments exist :-)
I'm not proposing that as a change, just making note of it.
Please note the difference between self class environment and self environment here: self class environment is the environment in which the class "Browser" was defined. self environment is the environment that "a Browser" browses.
On Thu, Jan 02, 2020 at 10:14:56PM +0100, Jakob Reschke wrote:
Am Do., 2. Jan. 2020 um 17:45 Uhr schrieb David T. Lewis < lewis@mail.msen.com>:
I also tried it like this:
Browser>>defaultBrowserTitle ^ 'System Browser on environment ', self class environment asString
And it seems quite acceptable to me. It serves as a reminder that environments exist :-)
I'm not proposing that as a change, just making note of it.
Please note the difference between self class environment and self environment here: self class environment is the environment in which the class "Browser" was defined. self environment is the environment that "a Browser" browses.
Yes, so it should be this instead:
Browser>>defaultBrowserTitle ^ 'System Browser on environment ', self environment asString
Or perhaps to save some space on the window label:
Browser>>defaultBrowserTitle ^ 'System Browser on ', self environment asString
Dave
squeak-dev@lists.squeakfoundation.org
-
commits＠source.squeak.org -
David T. Lewis -
Jakob Reschke -
Thiede, Christoph -
Tobias Pape