tim Rowledge uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-tpr.49.mcz
==================== Summary ====================
Name: Nebraska-tpr.49 Author: tpr Time: 7 August 2017, 4:42:46.935605 pm UUID: 867ebd6a-962c-4bee-be61-21636ad6c4b4 Ancestors: Nebraska-ul.48
Correct an ancient underscore assignment
=============== Diff against Nebraska-ul.48 ===============
Item was changed: ----- Method: NebraskaCommunicatorMorph>>textEntryFieldNamed:with:help: (in category 'as yet unclassified') ----- textEntryFieldNamed: aSymbol with: aString help: helpString
| f col | + f := (StringMorph new contents: aString; font: Preferences standardEToysFont; yourself) - f _ (StringMorph new contents: aString; font: Preferences standardEToysFont; yourself) setBalloonText: helpString; on: #mouseUp send: #editEvent:for: to: self. self field: aSymbol is: f. col _ (self inAColumn: {f}) color: Color white; hResizing: #shrinkWrap. ^col!
Item was changed: ----- Method: NebraskaListenerMorph class>>removeAllFromGlobalIncomingQueue (in category 'as yet unclassified') ----- removeAllFromGlobalIncomingQueue
self critical: [ + GlobalIncomingQueue := OrderedCollection new. - GlobalIncomingQueue _ OrderedCollection new. self bumpUpdateCounter. ].!
Hi Tim,
Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Thanks.
On Mon, Aug 7, 2017 at 6:42 PM, commits@source.squeak.org wrote:
tim Rowledge uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-tpr.49.mcz
==================== Summary ====================
Name: Nebraska-tpr.49 Author: tpr Time: 7 August 2017, 4:42:46.935605 pm UUID: 867ebd6a-962c-4bee-be61-21636ad6c4b4 Ancestors: Nebraska-ul.48
Correct an ancient underscore assignment
=============== Diff against Nebraska-ul.48 ===============
Item was changed: ----- Method: NebraskaCommunicatorMorph>>textEntryFieldNamed:with:help: (in category 'as yet unclassified') ----- textEntryFieldNamed: aSymbol with: aString help: helpString
| f col |
f := (StringMorph new contents: aString; font: Preferences standardEToysFont; yourself)
f _ (StringMorph new contents: aString; font: Preferences standardEToysFont; yourself) setBalloonText: helpString; on: #mouseUp send: #editEvent:for: to: self. self field: aSymbol is: f. col _ (self inAColumn: {f}) color: Color white; hResizing: #shrinkWrap. ^col!Item was changed: ----- Method: NebraskaListenerMorph class>>removeAllFromGlobalIncomingQueue (in category 'as yet unclassified') ----- removeAllFromGlobalIncomingQueue
self critical: [
GlobalIncomingQueue := OrderedCollection new.
GlobalIncomingQueue _ OrderedCollection new. self bumpUpdateCounter. ].!
On 07-08-2017, at 7:09 PM, Chris Muller asqueaker@gmail.com wrote: Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Huh. Never heard of that one before. Should be useful.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Foolproof operation: All parameters are hard coded.
The epic underscore debate occurred during the period when you were in hiatus.
On Mon, Aug 7, 2017 at 11:07 PM, tim Rowledge tim@rowledge.org wrote:
On 07-08-2017, at 7:09 PM, Chris Muller asqueaker@gmail.com wrote: Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Huh. Never heard of that one before. Should be useful.
tim
tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Foolproof operation: All parameters are hard coded.
On 07-08-2017, at 9:16 PM, Chris Muller ma.chris.m@gmail.com wrote:
The epic underscore debate occurred during the period when you were in hiatus.
That’s just across the straits from Haiti.
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim To steal ideas from one person is plagiarism; to steal from many is research.
The FixUnderscores package was known to break stuff in some cases, because it didn't parse the code but just replaced strings in methods. I don't know if that's still the case or not, but a few years ago, I wrote a better tool: http://smalltalkhub.com/#!/~ul/SourceCodeFixer
Levente
On Mon, 7 Aug 2017, Chris Muller wrote:
Hi Tim,
Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Thanks.
On Mon, Aug 7, 2017 at 6:42 PM, commits@source.squeak.org wrote:
tim Rowledge uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-tpr.49.mcz
==================== Summary ====================
Name: Nebraska-tpr.49 Author: tpr Time: 7 August 2017, 4:42:46.935605 pm UUID: 867ebd6a-962c-4bee-be61-21636ad6c4b4 Ancestors: Nebraska-ul.48
Correct an ancient underscore assignment
=============== Diff against Nebraska-ul.48 ===============
Item was changed: ----- Method: NebraskaCommunicatorMorph>>textEntryFieldNamed:with:help: (in category 'as yet unclassified') ----- textEntryFieldNamed: aSymbol with: aString help: helpString
| f col |
f := (StringMorph new contents: aString; font: Preferences standardEToysFont; yourself)
f _ (StringMorph new contents: aString; font: Preferences standardEToysFont; yourself) setBalloonText: helpString; on: #mouseUp send: #editEvent:for: to: self. self field: aSymbol is: f. col _ (self inAColumn: {f}) color: Color white; hResizing: #shrinkWrap. ^col!Item was changed: ----- Method: NebraskaListenerMorph class>>removeAllFromGlobalIncomingQueue (in category 'as yet unclassified') ----- removeAllFromGlobalIncomingQueue
self critical: [
GlobalIncomingQueue := OrderedCollection new.
GlobalIncomingQueue _ OrderedCollection new. self bumpUpdateCounter. ].!
It replaces strings, but also detects when inside a String literal, and presents those to the user for manual update decision, which is the best and only course of action it can do, IMO.
In any case, what it does is more important than how it does it, FixUnderscores preserves the author and timestamp information, does yours as well?
On Tue, Aug 8, 2017 at 4:23 PM, Levente Uzonyi leves@caesar.elte.hu wrote:
The FixUnderscores package was known to break stuff in some cases, because it didn't parse the code but just replaced strings in methods. I don't know if that's still the case or not, but a few years ago, I wrote a better tool: http://smalltalkhub.com/#!/~ul/SourceCodeFixer
Levente
On Mon, 7 Aug 2017, Chris Muller wrote:
Hi Tim,
Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Thanks.
On Mon, Aug 7, 2017 at 6:42 PM, commits@source.squeak.org wrote:
tim Rowledge uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-tpr.49.mcz
==================== Summary ====================
Name: Nebraska-tpr.49 Author: tpr Time: 7 August 2017, 4:42:46.935605 pm UUID: 867ebd6a-962c-4bee-be61-21636ad6c4b4 Ancestors: Nebraska-ul.48
Correct an ancient underscore assignment
=============== Diff against Nebraska-ul.48 ===============
Item was changed: ----- Method: NebraskaCommunicatorMorph>>textEntryFieldNamed:with:help: (in category 'as yet unclassified') ----- textEntryFieldNamed: aSymbol with: aString help: helpString
| f col |
f := (StringMorph new contents: aString; font: PreferencesstandardEToysFont; yourself)
f _ (StringMorph new contents: aString; font: PreferencesstandardEToysFont; yourself) setBalloonText: helpString; on: #mouseUp send: #editEvent:for: to: self. self field: aSymbol is: f. col _ (self inAColumn: {f}) color: Color white; hResizing: #shrinkWrap. ^col!
Item was changed: ----- Method: NebraskaListenerMorph class>>removeAllFromGlobalIncomingQueue (in category 'as yet unclassified')
removeAllFromGlobalIncomingQueue
self critical: [
GlobalIncomingQueue := OrderedCollection new.
GlobalIncomingQueue _ OrderedCollection new. self bumpUpdateCounter. ].!
On Tue, 8 Aug 2017, Chris Muller wrote:
It replaces strings, but also detects when inside a String literal,
IIRC it messes up code with underscores in variable names, comments, selectors, symbols or characters.
and presents those to the user for manual update decision, which is the best and only course of action it can do, IMO.
In any case, what it does is more important than how it does it, FixUnderscores preserves the author and timestamp information, does yours as well?
Of course it does. It's pretty well documented and has tests too. It'll also convert LF line endings to CR without messing up literals in your code.
Levente
On Tue, Aug 8, 2017 at 4:23 PM, Levente Uzonyi leves@caesar.elte.hu wrote:
The FixUnderscores package was known to break stuff in some cases, because it didn't parse the code but just replaced strings in methods. I don't know if that's still the case or not, but a few years ago, I wrote a better tool: http://smalltalkhub.com/#!/~ul/SourceCodeFixer
Levente
On Mon, 7 Aug 2017, Chris Muller wrote:
Hi Tim,
Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Thanks.
On Mon, Aug 7, 2017 at 6:42 PM, commits@source.squeak.org wrote:
tim Rowledge uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-tpr.49.mcz
==================== Summary ====================
Name: Nebraska-tpr.49 Author: tpr Time: 7 August 2017, 4:42:46.935605 pm UUID: 867ebd6a-962c-4bee-be61-21636ad6c4b4 Ancestors: Nebraska-ul.48
Correct an ancient underscore assignment
=============== Diff against Nebraska-ul.48 ===============
Item was changed: ----- Method: NebraskaCommunicatorMorph>>textEntryFieldNamed:with:help: (in category 'as yet unclassified') ----- textEntryFieldNamed: aSymbol with: aString help: helpString
| f col |
f := (StringMorph new contents: aString; font: PreferencesstandardEToysFont; yourself)
f _ (StringMorph new contents: aString; font: PreferencesstandardEToysFont; yourself) setBalloonText: helpString; on: #mouseUp send: #editEvent:for: to: self. self field: aSymbol is: f. col _ (self inAColumn: {f}) color: Color white; hResizing: #shrinkWrap. ^col!
Item was changed: ----- Method: NebraskaListenerMorph class>>removeAllFromGlobalIncomingQueue (in category 'as yet unclassified')
removeAllFromGlobalIncomingQueue
self critical: [
GlobalIncomingQueue := OrderedCollection new.
GlobalIncomingQueue _ OrderedCollection new. self bumpUpdateCounter. ].!
Cool!
On Mon, Aug 14, 2017 at 9:40 AM, Levente Uzonyi leves@caesar.elte.hu wrote:
On Tue, 8 Aug 2017, Chris Muller wrote:
It replaces strings, but also detects when inside a String literal,
IIRC it messes up code with underscores in variable names, comments, selectors, symbols or characters.
and presents those to the user for manual update decision, which is the best and only course of action it can do, IMO.
In any case, what it does is more important than how it does it, FixUnderscores preserves the author and timestamp information, does yours as well?
Of course it does. It's pretty well documented and has tests too. It'll also convert LF line endings to CR without messing up literals in your code.
Levente
On Tue, Aug 8, 2017 at 4:23 PM, Levente Uzonyi leves@caesar.elte.hu wrote:
The FixUnderscores package was known to break stuff in some cases, because it didn't parse the code but just replaced strings in methods. I don't know if that's still the case or not, but a few years ago, I wrote a better tool: http://smalltalkhub.com/#!/~ul/SourceCodeFixer
Levente
On Mon, 7 Aug 2017, Chris Muller wrote:
Hi Tim,
Please use the FixUnderscores package (on SqueakMap) to fix underscores. It takes care of an entire package at a time, and preserves the original author and timestamp information of the changed methods.
Thanks.
On Mon, Aug 7, 2017 at 6:42 PM, commits@source.squeak.org wrote:
tim Rowledge uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-tpr.49.mcz
==================== Summary ====================
Name: Nebraska-tpr.49 Author: tpr Time: 7 August 2017, 4:42:46.935605 pm UUID: 867ebd6a-962c-4bee-be61-21636ad6c4b4 Ancestors: Nebraska-ul.48
Correct an ancient underscore assignment
=============== Diff against Nebraska-ul.48 ===============
Item was changed: ----- Method: NebraskaCommunicatorMorph>>textEntryFieldNamed:with:help: (in category 'as yet unclassified') ----- textEntryFieldNamed: aSymbol with: aString help: helpString
| f col |
f := (StringMorph new contents: aString; font: PreferencesstandardEToysFont; yourself)
f _ (StringMorph new contents: aString; font: PreferencesstandardEToysFont; yourself) setBalloonText: helpString; on: #mouseUp send: #editEvent:for: to: self. self field: aSymbol is: f. col _ (self inAColumn: {f}) color: Color white; hResizing: #shrinkWrap. ^col!
Item was changed: ----- Method: NebraskaListenerMorph class>>removeAllFromGlobalIncomingQueue (in category 'as yet unclassified')
removeAllFromGlobalIncomingQueue
self critical: [
GlobalIncomingQueue := OrderedCollection new.
GlobalIncomingQueue _ OrderedCollection new. self bumpUpdateCounter. ].!
squeak-dev@lists.squeakfoundation.org
-
Chris Muller -
Chris Muller -
commits＠source.squeak.org -
Levente Uzonyi -
tim Rowledge