A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-mt.734.mcz
==================== Summary ====================
Name: Monticello-mt.734 Author: mt Time: 5 January 2021, 1:09:08.981865 pm UUID: 93fdf435-68a1-4ace-a7a9-d9d86fb3118f Ancestors: Monticello-mt.733
Alternative fix for the problem addressed in Monticello-nice.734
=============== Diff against Monticello-mt.733 ===============
Item was added: + ----- Method: MCAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ false!
Item was added: + ----- Method: MCVersionHistoryBrowser>>package (in category 'accessing') ----- + package + ^ package!
Item was changed: ----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') ----- selectedSnapshot + ^ self selectedInfo isWorkingAncestry + ifTrue: [self package snapshot] + ifFalse: [self snapshotForInfo: self selectedInfo]! - ^ self snapshotForInfo: self selectedInfo!
Item was added: + ----- Method: MCWorkingAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ true!
+1, that works. However, some other (sub)instance may pretend being a working copy ancestry, see MCVersionInfo>>name... A great source of head scratching ;)
Le mar. 5 janv. 2021 à 13:09, commits@source.squeak.org a écrit :
A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-mt.734.mcz
==================== Summary ====================
Name: Monticello-mt.734 Author: mt Time: 5 January 2021, 1:09:08.981865 pm UUID: 93fdf435-68a1-4ace-a7a9-d9d86fb3118f Ancestors: Monticello-mt.733
Alternative fix for the problem addressed in Monticello-nice.734
=============== Diff against Monticello-mt.733 ===============
Item was added:
- ----- Method: MCAncestry>>isWorkingAncestry (in category 'testing') -----
- isWorkingAncestry
^ false!
Item was added:
- ----- Method: MCVersionHistoryBrowser>>package (in category 'accessing')
- package
^ package!
Item was changed: ----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') ----- selectedSnapshot
^ self selectedInfo isWorkingAncestry
ifTrue: [self package snapshot]
ifFalse: [self snapshotForInfo: self selectedInfo]!
^ self snapshotForInfo: self selectedInfo!
Item was added:
- ----- Method: MCWorkingAncestry>>isWorkingAncestry (in category
'testing') -----
- isWorkingAncestry
^ true!
Hi Nicolas.
See Monticello-mt.735 :-)
I think that this is just old code. Maybe MCVersionInfo was reused in that way before MCWorkingAncestry got added.
Best, Marcel Am 05.01.2021 13:17:33 schrieb Nicolas Cellier nicolas.cellier.aka.nice@gmail.com: +1, that works. However, some other (sub)instance may pretend being a working copy ancestry, see MCVersionInfo>>name... A great source of head scratching ;)
Le mar. 5 janv. 2021 à 13:09, <commits@source.squeak.org [mailto:commits@source.squeak.org]> a écrit :
A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-mt.734.mcz [http://source.squeak.org/inbox/Monticello-mt.734.mcz]
==================== Summary ====================
Name: Monticello-mt.734 Author: mt Time: 5 January 2021, 1:09:08.981865 pm UUID: 93fdf435-68a1-4ace-a7a9-d9d86fb3118f Ancestors: Monticello-mt.733
Alternative fix for the problem addressed in Monticello-nice.734
=============== Diff against Monticello-mt.733 ===============
Item was added: + ----- Method: MCAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ false!
Item was added: + ----- Method: MCVersionHistoryBrowser>>package (in category 'accessing') ----- + package + ^ package!
Item was changed: ----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') ----- selectedSnapshot + ^ self selectedInfo isWorkingAncestry + ifTrue: [self package snapshot] + ifFalse: [self snapshotForInfo: self selectedInfo]! - ^ self snapshotForInfo: self selectedInfo!
Item was added: + ----- Method: MCWorkingAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ true!
MCVersionInfo >> #name originated in 7/11/2003 MCWorkingAncestry >> #name origintaed in 2/13/2004
Best, Marcel Am 05.01.2021 13:24:11 schrieb Marcel Taeumel marcel.taeumel@hpi.de: Hi Nicolas.
See Monticello-mt.735 :-)
I think that this is just old code. Maybe MCVersionInfo was reused in that way before MCWorkingAncestry got added.
Best, Marcel Am 05.01.2021 13:17:33 schrieb Nicolas Cellier nicolas.cellier.aka.nice@gmail.com: +1, that works. However, some other (sub)instance may pretend being a working copy ancestry, see MCVersionInfo>>name... A great source of head scratching ;)
Le mar. 5 janv. 2021 à 13:09, <commits@source.squeak.org [mailto:commits@source.squeak.org]> a écrit :
A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-mt.734.mcz [http://source.squeak.org/inbox/Monticello-mt.734.mcz]
==================== Summary ====================
Name: Monticello-mt.734 Author: mt Time: 5 January 2021, 1:09:08.981865 pm UUID: 93fdf435-68a1-4ace-a7a9-d9d86fb3118f Ancestors: Monticello-mt.733
Alternative fix for the problem addressed in Monticello-nice.734
=============== Diff against Monticello-mt.733 ===============
Item was added: + ----- Method: MCAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ false!
Item was added: + ----- Method: MCVersionHistoryBrowser>>package (in category 'accessing') ----- + package + ^ package!
Item was changed: ----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') ----- selectedSnapshot + ^ self selectedInfo isWorkingAncestry + ifTrue: [self package snapshot] + ifFalse: [self snapshotForInfo: self selectedInfo]! - ^ self snapshotForInfo: self selectedInfo!
Item was added: + ----- Method: MCWorkingAncestry>>isWorkingAncestry (in category 'testing') ----- + isWorkingAncestry + ^ true!
squeak-dev@lists.squeakfoundation.org