On Tue, Apr 01, 2014 at 02:36:02AM +0000, commits@source.squeak.org wrote:
Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.295.mcz
==================== Summary ====================
Name: Tests-cwp.295 Author: cwp Time: 31 March 2014, 9:35:49.208 pm UUID: fcac78df-a827-4247-8945-d29aa1da1155 Ancestors: Tests-cwp.294
Add comments to EnvironmentTest.
Thanks for adding these comments, they are very helpful. The method comments in EnvironmentTest give a nice overview of the functionality. I especially appreciate comments like "It seems reasonable for .... Reasonable but wrong" (#testAtDoesntFindUndeclared) that explain why things work as they do.
Dave
Heh, that particular quirk was what prompted me to start commenting. I'd forgotten about it for the eighth or tenth time, and was considering deleting this obviously-bogus test that was failing because of some obviously-good changes I had just made. When I finally figured out what was going on, I realized that the test by its self didn't explain why it was needed.
Some of the other tests are more straight-forward, and the comments perfunctory, but that one is crucial. ;-)
- Colin
On Apr 5, 2014, at 7:35 AM, "David T. Lewis" lewis@mail.msen.com wrote:
On Tue, Apr 01, 2014 at 02:36:02AM +0000, commits@source.squeak.org wrote: Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.295.mcz
==================== Summary ====================
Name: Tests-cwp.295 Author: cwp Time: 31 March 2014, 9:35:49.208 pm UUID: fcac78df-a827-4247-8945-d29aa1da1155 Ancestors: Tests-cwp.294
Add comments to EnvironmentTest.
Thanks for adding these comments, they are very helpful. The method comments in EnvironmentTest give a nice overview of the functionality. I especially appreciate comments like "It seems reasonable for .... Reasonable but wrong" (#testAtDoesntFindUndeclared) that explain why things work as they do.
Dave
squeak-dev@lists.squeakfoundation.org