Hello,
In 6.0, if you type a long text in a workspace, then select a word at the bottom and attempt to set it in bold emphasis, you will see that the halo to do so is not accessible anymore.
To be precise:
once the cursor is on the selected text - the first alt-click brings the Workspace halo - the second one yield the PluggableTextMorphPlus halo - the third one yield the TextMorphForEditView halo
It is the later halo that is scrolled with the text display, making it out of sight if we scroll too much.
Stef
In 6.0, if you type a long text in a workspace, then select a word at the bottom and attempt to set it in bold emphasis, you will see that the halo to do so is not accessible anymore.
To be precise:
once the cursor is on the selected text
- the first alt-click brings the Workspace halo
- the second one yield the PluggableTextMorphPlus halo
- the third one yield the TextMorphForEditView halo
It is the later halo that is scrolled with the text display, making it out of sight if we scroll too much.
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step
Commenting it out fixes the bug. Any side-effect?
Stef
Hi Stef --
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step Commenting it out fixes the bug. Any side-effect?
Yes, #renderedMorph is part of making TransformMorph transparent for the user. Not sure why the bounds are incorrect. I will take a look at it.
Best, Marcel Am 08.08.2022 00:47:08 schrieb Stéphane Rollandin lecteur@zogotounga.net:
In 6.0, if you type a long text in a workspace, then select a word at the bottom and attempt to set it in bold emphasis, you will see that the halo to do so is not accessible anymore.
To be precise:
once the cursor is on the selected text
- the first alt-click brings the Workspace halo
- the second one yield the PluggableTextMorphPlus halo
- the third one yield the TextMorphForEditView halo
It is the later halo that is scrolled with the text display, making it out of sight if we scroll too much.
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step
Commenting it out fixes the bug. Any side-effect?
Stef
The halo box seems correct. Just the halo buttons at the bottom edge are off, including the label. Hmm...
The expected behavior is that the box and buttons cover the entire (hidden) area. Not just the visible portion. That's why removing "renderedMorph" is not the correct fix here.
Best, Marcel Am 08.08.2022 11:32:30 schrieb Marcel Taeumel marcel.taeumel@hpi.de: Hi Stef --
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step Commenting it out fixes the bug. Any side-effect?
Yes, #renderedMorph is part of making TransformMorph transparent for the user. Not sure why the bounds are incorrect. I will take a look at it.
Best, Marcel Am 08.08.2022 00:47:08 schrieb Stéphane Rollandin lecteur@zogotounga.net:
In 6.0, if you type a long text in a workspace, then select a word at the bottom and attempt to set it in bold emphasis, you will see that the halo to do so is not accessible anymore.
To be precise:
once the cursor is on the selected text
- the first alt-click brings the Workspace halo
- the second one yield the PluggableTextMorphPlus halo
- the third one yield the TextMorphForEditView halo
It is the later halo that is scrolled with the text display, making it out of sight if we scroll too much.
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step
Commenting it out fixes the bug. Any side-effect?
Stef
Regression fixed in both 6.0 and 6.1alpha.
Apologies, in case the current behavior is still not what you were expecting. Halo buttons are clipped to the visible portion of the screen. Halo box still shows the entire morph, even if way larger that what is visible on the screen.
Best, Marcel Am 08.08.2022 11:55:11 schrieb Marcel Taeumel marcel.taeumel@hpi.de: The halo box seems correct. Just the halo buttons at the bottom edge are off, including the label. Hmm...
The expected behavior is that the box and buttons cover the entire (hidden) area. Not just the visible portion. That's why removing "renderedMorph" is not the correct fix here.
Best, Marcel Am 08.08.2022 11:32:30 schrieb Marcel Taeumel marcel.taeumel@hpi.de: Hi Stef --
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step Commenting it out fixes the bug. Any side-effect?
Yes, #renderedMorph is part of making TransformMorph transparent for the user. Not sure why the bounds are incorrect. I will take a look at it.
Best, Marcel Am 08.08.2022 00:47:08 schrieb Stéphane Rollandin lecteur@zogotounga.net:
In 6.0, if you type a long text in a workspace, then select a word at the bottom and attempt to set it in bold emphasis, you will see that the halo to do so is not accessible anymore.
To be precise:
once the cursor is on the selected text
- the first alt-click brings the Workspace halo
- the second one yield the PluggableTextMorphPlus halo
- the third one yield the TextMorphForEditView halo
It is the later halo that is scrolled with the text display, making it out of sight if we scroll too much.
After investigation, the problem seems to come from the #renderedMorph in HaloMorph>>#step
Commenting it out fixes the bug. Any side-effect?
Stef
Apologies, in case the current behavior is still not what you were expecting. Halo buttons are clipped to the visible portion of the screen. Halo box still shows the entire morph, even if way larger that what is visible on the screen.
Yes, this is how it has always been - so, problem fixed. Thanks!
Stef
squeak-dev@lists.squeakfoundation.org