A new version of ToolBuilder-Morphic was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Morphic-jr.225.mcz
==================== Summary ====================
Name: ToolBuilder-Morphic-jr.225 Author: jr Time: 3 February 2019, 12:02:36.955839 am UUID: f93f39b3-2e20-ea44-b023-1ec44691e5e1 Ancestors: ToolBuilder-Morphic-mt.224
Fix: FileSaverDialog would answer 'nil' instead of nil when nothing was done except for accepting the dialog
=============== Diff against ToolBuilder-Morphic-mt.224 ===============
Item was changed: ----- Method: FileSaverDialog>>inputText: (in category 'filename') ----- inputText: aText "Initialize the filename entry field to aString. If a file with that name already exists, set up to highlight it." + aText ifNil: [^ self]. fileName := aText asString. self selectExistingFilename!
...or rather, it would answer '/path/to/opened/folder/nil' instead of nil. With this change, nil is answered from getUserResponse when nothing was actually selected. That means clicking accept without having selected anything is the same as clicking cancel, at least concerning the return value of FileSaverDialog class>>openOn:.
Am So., 3. Feb. 2019 um 00:03 Uhr schrieb commits@source.squeak.org:
A new version of ToolBuilder-Morphic was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Morphic-jr.225.mcz
==================== Summary ====================
Name: ToolBuilder-Morphic-jr.225 Author: jr Time: 3 February 2019, 12:02:36.955839 am UUID: f93f39b3-2e20-ea44-b023-1ec44691e5e1 Ancestors: ToolBuilder-Morphic-mt.224
Fix: FileSaverDialog would answer 'nil' instead of nil when nothing was done except for accepting the dialog
=============== Diff against ToolBuilder-Morphic-mt.224 ===============
Item was changed: ----- Method: FileSaverDialog>>inputText: (in category 'filename') ----- inputText: aText "Initialize the filename entry field to aString. If a file with that name already exists, set up to highlight it."
aText ifNil: [^ self]. fileName := aText asString. self selectExistingFilename!
On 2019-02-02, at 3:10 PM, Jakob Reschke forums.jakob@resfarm.de wrote:
...or rather, it would answer '/path/to/opened/folder/nil' instead of nil. With this change, nil is answered from getUserResponse when nothing was actually selected. That means clicking accept without having selected anything is the same as clicking cancel, at least concerning the return value of FileSaverDialog class>>openOn:.
Good catch!
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim ...now touch these wires to your tongue!
squeak-dev@lists.squeakfoundation.org