Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.1563.mcz
==================== Summary ====================
Name: Kernel-cmm.1563 Author: cmm Time: 25 March 2024, 7:38:47.237222 pm UUID: 6986b006-23f1-4c46-b47a-7417539e6902 Ancestors: Kernel-cmm.1562
- Preserve "Map CONTROL keys to COMMAND keys" preference across image restarts. - With Tim's permission, removed LargePositiveInteger>>#asByteArray.
=============== Diff against Kernel-cmm.1562 ===============
Item was changed: ----- Method: EventSensor class>>startUp: (in category 'system startup') ----- startUp: resuming
+ resuming ifTrue: + [ Smalltalk platformName ~= Smalltalk previousPlatformName + ifTrue: + [Smalltalk platformName = 'Mac OS' + ifTrue: [ + self mapAltKeysToOptionKeys: false. + self mapControlKeysToCommandKeys: false] + ifFalse: [ + self mapAltKeysToOptionKeys: true. + self mapControlKeysToCommandKeys: true]. + self installVirtualKeyTable] ]. - resuming ifTrue: [ - Smalltalk platformName = 'Mac OS' - ifTrue: [ - self mapAltKeysToOptionKeys: false. - self mapControlKeysToCommandKeys: false] - ifFalse: [ - self mapAltKeysToOptionKeys: true. - self mapControlKeysToCommandKeys: true]. - self installVirtualKeyTable ].
+ self default startUp! - self default startUp.!
Item was removed: - ----- Method: LargePositiveInteger>>asByteArray (in category 'converting') ----- - asByteArray - - ^self as: ByteArray!
Hi Chris --
It is still good practice to preserve the indentation style if you just add a single extra check to existing code. Now we have a mixed style in this method. :-)
Best, Marcel
Am 26.03.2024 01:39:19 schrieb commits@source.squeak.org commits@source.squeak.org:
Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.1563.mcz
==================== Summary ====================
Name: Kernel-cmm.1563 Author: cmm Time: 25 March 2024, 7:38:47.237222 pm UUID: 6986b006-23f1-4c46-b47a-7417539e6902 Ancestors: Kernel-cmm.1562
- Preserve "Map CONTROL keys to COMMAND keys" preference across image restarts. - With Tim's permission, removed LargePositiveInteger>>#asByteArray.
=============== Diff against Kernel-cmm.1562 ===============
Item was changed: ----- Method: EventSensor class>>startUp: (in category 'system startup') ----- startUp: resuming
+ resuming ifTrue: + [ Smalltalk platformName ~= Smalltalk previousPlatformName + ifTrue: + [Smalltalk platformName = 'Mac OS' + ifTrue: [ + self mapAltKeysToOptionKeys: false. + self mapControlKeysToCommandKeys: false] + ifFalse: [ + self mapAltKeysToOptionKeys: true. + self mapControlKeysToCommandKeys: true]. + self installVirtualKeyTable] ]. - resuming ifTrue: [ - Smalltalk platformName = 'Mac OS' - ifTrue: [ - self mapAltKeysToOptionKeys: false. - self mapControlKeysToCommandKeys: false] - ifFalse: [ - self mapAltKeysToOptionKeys: true. - self mapControlKeysToCommandKeys: true]. - self installVirtualKeyTable ].
+ self default startUp! - self default startUp.!
Item was removed: - ----- Method: LargePositiveInteger>>asByteArray (in category 'converting') ----- - asByteArray - - ^self as: ByteArray!
squeak-dev@lists.squeakfoundation.org