Hi,
With this change set, we get an error when doing the following:
In the workspace do a "debug it" on this code:
Transcript show: Class name
then two times "step over" --> Subscript out of bounds error. Without the change it works.
On Wed, Nov 16, 2011 at 8:58 PM, Eliot Miranda eliot.miranda@gmail.com wrote:
Hi All,
I've found a bug in ContextPart>>#runUntilErrorOrReturnFrom: that in a certain rare circumstance causes the method to peel back too much of the stack. This method is used in the debugger (e.g. completeStep: et al) but also in Process termination. So it is right at the heart of the system. I'm loath to simply commit it I'd really appreciate y'all testing with the fix and reporting any changes you see. It does not affect the trunk test suite (there is a test, WeakSetInspectorTest, which is unreliable, but apart form that no observed effects). So, brave souls, please try with the attached and see if you come to grief or not. -- thanks, Eliot
Hi Marcus,
On Mon, Dec 5, 2011 at 5:58 AM, Marcus Denker marcus.denker@inria.frwrote:
Hi,
With this change set, we get an error when doing the following:
In the workspace do a "debug it" on this code:
Transcript show: Class name
Thanks very much for this simple test case :) OK, the attached is an improvement. Please as many people test it as possible.
then two times "step over" --> Subscript out of bounds error. Without the change it works.
On Wed, Nov 16, 2011 at 8:58 PM, Eliot Miranda eliot.miranda@gmail.com wrote:
Hi All,
I've found a bug in ContextPart>>#runUntilErrorOrReturnFrom: that in
a
certain rare circumstance causes the method to peel back too much of the stack. This method is used in the debugger (e.g. completeStep: et al)
but
also in Process termination. So it is right at the heart of the system. I'm loath to simply commit it I'd really appreciate y'all testing with
the
fix and reporting any changes you see. It does not affect the trunk test suite (there is a test, WeakSetInspectorTest, which is unreliable, but
apart
form that no observed effects). So, brave souls, please try with the attached and see if you come to grief or not. -- thanks, Eliot
--
Marcus Denker -- denker@acm.org http://www.marcusdenker.de
I added this patch to the Inbox to make it easier to load it. Evaluate the following to load it into your updated trunk image:
Installer squeak project: 'inbox'; install: 'Kernel-ul.656'
Levente
On Mon, 5 Dec 2011, Eliot Miranda wrote:
Hi Marcus,
On Mon, Dec 5, 2011 at 5:58 AM, Marcus Denker marcus.denker@inria.frwrote:
Hi,
With this change set, we get an error when doing the following:
In the workspace do a "debug it" on this code:
Transcript show: Class name
Thanks very much for this simple test case :) OK, the attached is an improvement. Please as many people test it as possible.
then two times "step over" --> Subscript out of bounds error. Without the change it works.
On Wed, Nov 16, 2011 at 8:58 PM, Eliot Miranda eliot.miranda@gmail.com wrote:
Hi All,
I've found a bug in ContextPart>>#runUntilErrorOrReturnFrom: that in
a
certain rare circumstance causes the method to peel back too much of the stack. This method is used in the debugger (e.g. completeStep: et al)
but
also in Process termination. So it is right at the heart of the system. I'm loath to simply commit it I'd really appreciate y'all testing with
the
fix and reporting any changes you see. It does not affect the trunk test suite (there is a test, WeakSetInspectorTest, which is unreliable, but
apart
form that no observed effects). So, brave souls, please try with the attached and see if you come to grief or not. -- thanks, Eliot
--
Marcus Denker -- denker@acm.org http://www.marcusdenker.de
-- best, Eliot
squeak-dev@lists.squeakfoundation.org