Squeak-dev March 2024

squeak-dev@lists.squeakfoundation.org

27 participants
58 discussions

The Trunk: Monticello-codefrau.809.mcz
by commits＠source.squeak.org 04 Mar '24

04 Mar '24

Vanessa Freudenberg uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-codefrau.809.mcz ==================== Summary ==================== Name: Monticello-codefrau.809 Author: codefrau Time: 3 March 2024, 10:01:22.170575 pm UUID: 1bde7068-beb0-491d-b3ab-bd81918960f0 Ancestors: Monticello-ct.808 Show author's full name in MC browser =============== Diff against Monticello-ct.808 =============== Item was changed: ----- Method: MCVersionInfo>>summaryHeader (in category 'accessing') ----- summaryHeader ^ String streamContents: [:s | s nextPutAll: 'Name: '; nextPutAll: self name; cr. date ifNotNil: + [ | fullname | + fullname := SystemNavigation authorsInverted at: author + ifPresent: [:names | names asArray joinSeparatedBy: ' or '] + ifAbsent: ['unregistered author']. + s + nextPutAll: 'Author: '; nextPutAll: author, ' (', fullname, ')'; cr; - [s - nextPutAll: 'Author: '; nextPutAll: author; cr; nextPutAll: 'Time: '; nextPutAll: date asString, ', ', time asString; cr]. id ifNotNil: [s nextPutAll: 'UUID: '; nextPutAll: id asString; cr]. s nextPutAll: 'Ancestors: '; nextPutAll: self ancestorString. self stepChildren isEmpty ifFalse: [s cr; nextPutAll: 'Backported From: '; nextPutAll: self stepChildrenString]. ]!

1 0

The Trunk: Compiler-ct.497.mcz
by commits＠source.squeak.org 04 Mar '24

04 Mar '24

Christoph Thiede uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.497.mcz ==================== Summary ==================== Name: Compiler-ct.497 Author: ct Time: 3 March 2024, 7:35:18.153958 pm UUID: 7ee52c4b-be72-c64f-bcb5-0607b502b9b5 Ancestors: Compiler-ct.496 Merges SimulationSideEffectWarning.5.cs (step 1/2): In Context>>doPrimitive:method:receiver:args:, replaces generic "simulation guard" warnings for undebuggable methods by new specific, suppressable SimulationSideEffectWarnings. Also warns when primitive 87 (primitiveResume) is hit. Refactors <primitive: 19> simulation guards into a named alias pragma <simulationGuard>. Revision: Revise documentation and document emergence and usage of SimulationSideEffectWarning in Context>>runSimulated:.... Fix resumption value of SimulationSideEffectWarning when proceeding from a debugger. Avoid infinite recursion due to process-faithful debugging when debugging a SimulationSideEffectWarning from a debugger. Improves tests. Step 1/2: Prepare the parser to handle the new <simulationGuard> pragma (as well as unary pragma parsers in general). Thanks to Marcel (mt) for the advice! See: https://lists.squeakfoundation.org/archives/list/squeak-dev%40lists.squeakf… =============== Diff against Compiler-ct.496 =============== Item was changed: ----- Method: Parser>>pragmaStatement (in category 'pragmas') ----- pragmaStatement "Parse a pragma statement. The leading '<' has already been consumed. The 'here' token is the first one in the pragma. Use that token to dispatch to a custom pragma-parsing method if one can be found with a selector that matches it. Note that custom pragma parsers need to fulfill two requirements: - method selector must match the current token as simple getter, e.g., <apicall: ...> matches #apicall or <primitive: ...> matches #primitive - method must have pragma <pragmaParser> to be called." "0) Early exit" (hereType = #keyword or: [ hereType = #word or: [ hereType = #binary ] ]) ifFalse: [ ^ self expected: 'pragma declaration' ]. + - "1) Do not consider one-word pragmas such as <primitive> and <foobar>. Only keyword pragmas." + "2) Avoid interning new symbols for made-up pragmas such as #my for <my: 1 pragma: 2>." + (Symbol lookup: (here last == $: ifTrue: [here allButLast] ifFalse: [here])) + ifNotNil: [:parserSelector | - here last == $: ifTrue: [ - "2) Avoid interning new symbols for made-up pragmas such as #my for <my: 1 pragma: 2>." - (Symbol lookup: here allButLast) ifNotNil: [:parserSelector | Parser methodDict at: parserSelector ifPresent: [:parserMethod | "3) Only call methods that claim to be a custom pragma parser via <pragmaParser>." (parserMethod hasPragma: #pragmaParser) + ifTrue: [^ self executeMethod: parserMethod]]]. + - ifTrue: [^ self executeMethod: parserMethod]]]]. - "X) No custom pragma parser found. Use the default one." ^ self pragmaStatementKeywords! Item was added: + ----- Method: Parser>>simulationGuard (in category 'primitives') ----- + simulationGuard + "primitive 19 is a null primitive that always fails. Just a marker for the simulator for methods that are typically undebuggable and could lock your image when simulated." + <pragmaParser> + + self addPragma: (Pragma keyword: #primitive: arguments: #(19)). + + self advance. + ^ true!

3 2

The Trunk: MonticelloConfigurations-codefrau.186.mcz
by commits＠source.squeak.org 04 Mar '24

04 Mar '24

Vanessa Freudenberg uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-codefrau.186.mcz ==================== Summary ==================== Name: MonticelloConfigurations-codefrau.186 Author: codefrau Time: 3 March 2024, 5:32:49.979052 pm UUID: 0ff03970-4857-424f-ad42-9e7e60777e9c Ancestors: MonticelloConfigurations-mt.185 Show config metadata in MC browser =============== Diff against MonticelloConfigurations-mt.185 =============== Item was changed: ----- Method: MCConfiguration>>summary (in category 'accessing') ----- summary ^String streamContents: [:stream | + self summaryOn: stream]! - self dependencies - do: [:ea | stream nextPutAll: ea versionInfo name; cr ]]! Item was added: + ----- Method: MCConfiguration>>summaryOn: (in category 'testing') ----- + summaryOn: aStream + self dependencies + do: [:ea | aStream nextPutAll: ea versionInfo name; cr ]! Item was added: + ----- Method: MCConfigurationExtended>>summaryOn: (in category 'printing') ----- + summaryOn: aStream + name ifNotNil: [aStream nextPutAll: 'Name: '; nextPutAll: name; cr]. + authorInitials ifNotNil: [aStream nextPutAll: 'Author: '; nextPutAll: authorInitials; cr]. + timeStamp ifNotNil: [aStream nextPutAll: 'Time: '; nextPutAll: timeStamp; cr]. + id ifNotNil: [aStream nextPutAll: 'UUID: '; nextPutAll: id; cr]. + priorVersions ifNotEmpty: [aStream nextPutAll: 'Prior: '; nextPutAll: priorVersions first name; cr]. + comment ifNotNil: [aStream cr; nextPutAll: comment; cr]. + aStream cr. + super summaryOn: aStream. + + + !

1 0

The Trunk: Kernel-ct.1301.mcz
by commits＠source.squeak.org 03 Mar '24

03 Mar '24

Christoph Thiede uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1301.mcz ==================== Summary ==================== Name: Kernel-ct.1301 Author: ct Time: 16 February 2020, 11:36:54.104878 pm UUID: e766ce27-fd99-2c4b-ac94-408d4bde8d4f Ancestors: Kernel-tonyg.1293 Documents the small but essential difference between #sendTo: and #sentTo: Refactored against Kent's Type Suggesting Parameter Name idiom. Thanks to Chris for the reminder! Committed again due to broken ancestry. =============== Diff against Kernel-tonyg.1293 =============== Item was changed: ----- Method: Message>>sendTo: (in category 'sending') ----- + sendTo: receiverObject + "Answer the result of sending this message to receiverObject" - sendTo: receiver - "answer the result of sending this message to receiver" + ^ receiverObject perform: selector withArguments: args! - ^ receiver perform: selector withArguments: args! Item was changed: ----- Method: Message>>sentTo: (in category 'sending') ----- + sentTo: receiverObject + "Answer the result of sending this message to receiver. Kind of private!! To send the message to a different receiver (for example, via #doesNotUnderstand:), use #sendTo: instead." - sentTo: receiver - "answer the result of sending this message to receiver" + ^ lookupClass == nil + ifTrue: [receiverObject perform: selector withArguments: args] + ifFalse: [receiverObject perform: selector withArguments: args inSuperclass: lookupClass]! - lookupClass == nil - ifTrue: [^ receiver perform: selector withArguments: args] - ifFalse: [^ receiver perform: selector withArguments: args inSuperclass: lookupClass]!

1 0

The Trunk: Kernel-ct.1385.mcz
by commits＠source.squeak.org 03 Mar '24

03 Mar '24

Christoph Thiede uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1385.mcz ==================== Summary ==================== Name: Kernel-ct.1385 Author: ct Time: 12 April 2021, 10:15:07.18369 pm UUID: e2817a6e-1a1f-e246-aa66-2fa9289a7703 Ancestors: Kernel-nice.1384 Improves multilingual support for basic errors on Object. =============== Diff against Kernel-nice.1384 =============== Item was changed: ----- Method: Object>>error (in category 'error handling') ----- error "Throw a generic Error exception." + ^ self error: 'Error!!' translated! - ^self error: 'Error!!'.! Item was changed: ----- Method: Object>>errorImproperStore (in category 'private') ----- errorImproperStore "Create an error notification that an improper store was attempted." + ^ self error: 'Improper store into indexable object' translated! - self error: 'Improper store into indexable object'! Item was changed: ----- Method: Object>>errorNonIntegerIndex (in category 'private') ----- errorNonIntegerIndex "Create an error notification that an improper object was used as an index." + ^ self error: 'Only integers should be used as indices' translated! - self error: 'only integers should be used as indices'! Item was changed: ----- Method: Object>>errorSubscriptBounds: (in category 'private') ----- errorSubscriptBounds: index "Create an error notification that an improper integer was used as an index." + ^ self error: ('Subscript is out of bounds: {1}' translated format: {index})! - self error: 'subscript is out of bounds: ' , index printString!

1 0

The Inbox: Kernel-ct.1560.mcz
by commits＠source.squeak.org 03 Mar '24

03 Mar '24

Christoph Thiede uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1560.mcz ==================== Summary ==================== Name: Kernel-ct.1560 Author: ct Time: 3 March 2024, 9:39:29.169954 pm UUID: 2ace0bc3-2d52-2740-b47e-c53db96278b1 Ancestors: Kernel-ct.1559 Proposal: Adds MessageSend>>asContext[WithSender:]. =============== Diff against Kernel-ct.1559 =============== Item was added: + ----- Method: MessageSend>>asContext (in category 'converting') ----- + asContext + + ^ self asContextWithSender: nil! Item was added: + ----- Method: MessageSend>>asContextWithSender: (in category 'converting') ----- + asContextWithSender: aContext + + ^ [self value] asContextWithSender: aContext!

1 0

[squeak-smalltalk/squeak-object-memory] Debugger returnValue through unwind context unwinds too far (Issue #119)
by Christoph Thiede 03 Mar '24

03 Mar '24

**Steps to reproduce** Do it/print it: ```smalltalk [self error] ensure: [self halt] ``` In the debugger, yellow-click `UndefinedObject>>DoIt` (home), choose "return entered value", and enter any value. **Expected:** Should land in `UndefinedObject(Object)>>halt`. **Actual:** Land in `Compiler>>evaluateCue:ifFail:logged:` (but the process suspendedContext is not actually yet there). **Patch:** ```diff Debugger>>returnValue "Force a return of a given value to the previous context!" - | previous selectedContext expression value | + | previous selectedContext expression value newContext | contextStackIndex = 0 ifTrue: [^Beeper beep]. selectedContext := self selectedContext. expression := UIManager default request: 'Enter expression for return value:'. value := Compiler new evaluate: expression in: selectedContext to: selectedContext receiver. previous := selectedContext sender. - self resetContext: previous. - interruptedProcess popTo: previous value: value + newContext := self + handleLabelUpdatesIn: [interruptedProcess popTo: previous value: value] + whenExecuting: previous. + self resetContext: newContext. "might differ from previous in case of error during unwinding" ``` With that change, let's continue and step out of `[] in UndefinedObject>>DoIt`. Whether you use step over or step through from `UndefinedObject>>DoIt` or step into all the details of the unwind stack, in any case the process ends up completely terminated before the debugger halts in `Compiler>>evaluateCue:ifFail:logged:` as expected, and you get anything like disabled stepping buttons in the debugger, a cannotReturn: error, or a nil DNU from the debugger. Something seems to be wrong with the unwinding logic here. I checked: This is **not** a regression and already failed in 6.0 and 5.3. @isCzech FYIO, just in case you're up for another round of unwinding fun. Otherwise, I might myself address this one day. :-) -- Reply to this email directly or view it on GitHub: https://github.com/squeak-smalltalk/squeak-object-memory/issues/119 You are receiving this because you are subscribed to this thread. Message ID: <squeak-smalltalk/squeak-object-memory/issues/119(a)github.com>

1 0

The Trunk: Kernel-nice.1386.mcz
by commits＠source.squeak.org 03 Mar '24

03 Mar '24

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1386.mcz ==================== Summary ==================== Name: Kernel-nice.1386 Author: nice Time: 14 April 2021, 2:56:48.575456 pm UUID: e7612c01-14d8-0940-87fe-45e2fb4d2719 Ancestors: Kernel-mt.1385, Kernel-ct.1383, Kernel-ct.1364 Merge commit. Note that Kernel-ct.1383 supersedes Kernel-ct.1382 and removes the annoying warning. Kernel-mt.1385: Clean up and comment on the idiom #perform:orSendTo:. Kernel-ct.1383: Fixes simulation of the #perform:... primitives 83, 84, and 100 for all edge cases. If the primitive is called with the wrong arguments, the primitive must fail but not the simulator. Kernel-ct.1364: Fixes primitive comments in BlockClosure >> (cull:){3,4}. =============== Diff against Kernel-mt.1385 =============== Item was changed: ----- Method: BlockClosure>>cull:cull:cull: (in category 'evaluating') ----- cull: firstArg cull: secondArg cull: thirdArg "Activate the receiver, with three or less arguments." + <primitive: 204> "Handle the three argument case primitively" - <primitive: 204> "Handle the two argument case primitively" numArgs >= 2 ifTrue: [ numArgs >= 3 ifTrue: [ ^self value: firstArg value: secondArg value: thirdArg ]. ^self value: firstArg value: secondArg ]. numArgs = 1 ifTrue: [ ^self value: firstArg ]. ^self value! Item was changed: ----- Method: BlockClosure>>cull:cull:cull:cull: (in category 'evaluating') ----- cull: firstArg cull: secondArg cull: thirdArg cull: fourthArg "Activate the receiver, with four or less arguments." + <primitive: 205> "Handle the four argument case primitively" - <primitive: 205> "Handle the two argument case primitively" numArgs >= 3 ifTrue: [ numArgs >= 4 ifTrue: [ ^self value: firstArg value: secondArg value: thirdArg value: fourthArg ]. ^self value: firstArg value: secondArg value: thirdArg ]. numArgs = 2 ifTrue: [ ^self value: firstArg value: secondArg ]. numArgs = 1 ifTrue: [ ^self value: firstArg ]. ^self value! Item was changed: ----- Method: Context>>doPrimitive:method:receiver:args: (in category 'private') ----- doPrimitive: primitiveIndex method: meth receiver: receiver args: arguments "Simulate a primitive method whose index is primitiveIndex. The simulated receiver and arguments are given as arguments to this message. If successful, push result and return resuming context, else ^ {errCode, PrimitiveFailToken}. Any primitive which provokes execution needs to be intercepted and simulated to avoid execution running away." | value | "Judicious use of primitive 19 (a null primitive that doesn't do anything) prevents the debugger from entering various run-away activities such as spawning a new process, etc. Injudicious use results in the debugger not being able to debug interesting code, such as the debugger itself. Hence use primitive 19 with care :-)" "SystemNavigation new browseAllSelect: [:m| m primitive = 19]" + primitiveIndex = 19 ifTrue: [ - (primitiveIndex = 19 or: [primitiveIndex >= 85 and: [primitiveIndex <= 88] "control primitives"]) ifTrue: [ [self notify: ('The code being simulated is trying to control a process ({1}). Process controlling cannot be simulated. If you proceed, things may happen outside the observable area of the simulator.' translated format: {meth reference})] ifCurtailed: [self push: nil "Cheap fix of the context's internal state"]]. ((primitiveIndex between: 201 and: 222) and: [(self objectClass: receiver) includesBehavior: BlockClosure]) ifTrue: [(primitiveIndex = 206 or: [primitiveIndex = 208]) ifTrue: "[Full]BlockClosure>>valueWithArguments:" [^receiver simulateValueWithArguments: arguments first caller: self]. ((primitiveIndex between: 201 and: 209) "[Full]BlockClosure>>value[:value:...]" or: [primitiveIndex between: 221 and: 222]) ifTrue: "[Full]BlockClosure>>valueNoContextSwitch[:]" [^receiver simulateValueWithArguments: arguments caller: self]]. primitiveIndex = 83 ifTrue: "afr 9/11/1998 19:50" "Object>>perform:[with:...]" + [| selector | + selector := arguments at: 1 ifAbsent: + [^ self class primitiveFailTokenFor: #'bad argument']. + arguments size - 1 = selector numArgs ifFalse: + [^ self class primitiveFailTokenFor: #'bad number of arguments']. + ^self send: selector to: receiver with: arguments allButFirst]. - [^self send: arguments first to: receiver with: arguments allButFirst]. primitiveIndex = 84 ifTrue: "afr 9/11/1998 19:50 & eem 8/18/2009 17:04" "Object>>perform:withArguments:" + [| selector args | + arguments size = 2 ifFalse: + [^ self class primitiveFailTokenFor: #'bad argument']. + selector := arguments first. + args := arguments second. + args isArray ifFalse: + [^ self class primitiveFailTokenFor: #'bad argument']. + args size = selector numArgs ifFalse: + [^ self class primitiveFailTokenFor: #'bad number of arguments']. + ^self send: selector to: receiver with: args]. - [^self send: arguments first to: receiver with: (arguments at: 2) lookupIn: (self objectClass: receiver)]. primitiveIndex = 100 ifTrue: "eem 8/18/2009 16:57" "Object>>perform:withArguments:inSuperclass:" + [| rcvr selector args superclass | + arguments size + caseOf: { + [3] -> [ + rcvr := receiver. + selector := arguments first. + args := arguments second. + superclass := arguments third]. + [4] -> ["mirror primitive" + rcvr := arguments first. + selector := arguments second. + args := arguments third. + superclass := arguments fourth] } + otherwise: [^ self class primitiveFailTokenFor: #'bad argument']. + args isArray ifFalse: + [^ self class primitiveFailTokenFor: #'bad argument']. + args size = selector numArgs ifFalse: + [^ self class primitiveFailTokenFor: #'bad number of arguments']. + ((self objectClass: rcvr) includesBehavior: superclass) ifFalse: + [^ self class primitiveFailTokenFor: #'bad argument']. + ^self send: selector to: rcvr with: args lookupIn: superclass]. - [^self send: arguments first to: receiver with: (arguments at: 2) lookupIn: (arguments at: 3)]. "Mutex>>primitiveEnterCriticalSection Mutex>>primitiveTestAndSetOwnershipOfCriticalSection" (primitiveIndex = 186 or: [primitiveIndex = 187]) ifTrue: + [| effective | + effective := Processor activeProcess effectiveProcess. + "active == effective" + value := primitiveIndex = 186 + ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: effective] + ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effective]. - [value := primitiveIndex = 186 - ifTrue: [receiver primitiveEnterCriticalSectionOnBehalfOf: Processor activeProcess] - ifFalse: [receiver primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: Processor activeProcess]. ^(self isPrimFailToken: value) ifTrue: [value] ifFalse: [self push: value]]. primitiveIndex = 188 ifTrue: "Object>>withArgs:executeMethod: CompiledMethod class>>receiver:withArguments:executeMethod: VMMirror>>ifFail:object:with:executeMethod: et al" [| n args methodArg thisReceiver | ((n := arguments size) between: 2 and: 4) ifFalse: [^self class primitiveFailTokenFor: #'unsupported operation']. ((self objectClass: (args := arguments at: n - 1)) == Array and: [(self objectClass: (methodArg := arguments at: n)) includesBehavior: CompiledMethod]) ifFalse: [^self class primitiveFailTokenFor: #'bad argument']. methodArg numArgs = args size ifFalse: [^self class primitiveFailTokenFor: #'bad number of arguments']. thisReceiver := arguments at: n - 2 ifAbsent: [receiver]. methodArg primitive > 0 ifTrue: [methodArg isQuick ifTrue: [^self push: (methodArg valueWithReceiver: thisReceiver arguments: args)]. ^self doPrimitive: methodArg primitive method: meth receiver: thisReceiver args: args]. ^Context sender: self receiver: thisReceiver method: methodArg arguments: args]. primitiveIndex = 118 ifTrue: "[receiver:]tryPrimitive:withArgs:; avoid recursing in the VM" [(arguments size = 3 and: [(self objectClass: arguments second) == SmallInteger and: [(self objectClass: arguments last) == Array]]) ifTrue: [^self doPrimitive: arguments second method: meth receiver: arguments first args: arguments last]. (arguments size = 2 and: [(self objectClass: arguments first) == SmallInteger and: [(self objectClass: arguments last) == Array]]) ifFalse: [^self class primitiveFailTokenFor: nil]. ^self doPrimitive: arguments first method: meth receiver: receiver args: arguments last]. value := primitiveIndex = 120 "FFI method" ifTrue: [(meth literalAt: 1) tryInvokeWithArguments: arguments] ifFalse: [primitiveIndex = 117 "named primitives" ifTrue: [self tryNamedPrimitiveIn: meth for: receiver withArgs: arguments] ifFalse: "should use self receiver: receiver tryPrimitive: primitiveIndex withArgs: arguments but this is only in later VMs (and appears to be broken)" [receiver tryPrimitive: primitiveIndex withArgs: arguments]]. ^(self isPrimFailToken: value) ifTrue: [value] ifFalse: [self push: value]!

6 13

The Trunk: Tools-ct.1249.mcz
by commits＠source.squeak.org 03 Mar '24

03 Mar '24

Christoph Thiede uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ct.1249.mcz ==================== Summary ==================== Name: Tools-ct.1249 Author: ct Time: 3 March 2024, 8:10:31.669958 pm UUID: d9867cc9-cad5-0a41-8b64-86f1fbb54fe3 Ancestors: Tools-ct.1248 Complements Kernel-ct.1559 (merges SimulationSideEffectWarning.5.cs, step 2/2). Revision: Also handle label updates in debugger when resuming from a method with a possible primitive. =============== Diff against Tools-ct.1248 =============== Item was changed: ----- Method: Debugger>>handleLabelUpdatesIn:whenExecuting: (in category 'context stack menu') ----- handleLabelUpdatesIn: aBlock whenExecuting: aContext "Send the selected message in the accessed method, and regain control after the invoked method returns." + + | originalProcess | + originalProcess := Processor activeProcess. ^aBlock on: Notification do: [:ex| (ex tag isArray and: [ex tag size = 2 and: [(ex tag first == aContext or: [ex tag first hasSender: aContext])]]) ifTrue: [self labelString: ex tag second description. ex resume] ifFalse: + [ex pass]] + + on: SimulationSideEffectWarning + do: [:ex | + ex isControlPrimitive ifTrue: [ex unsuppress]. + ex resume: + "Avoid infinite recursion in Process>>effectiveProcess when debugging this warning, because the warning while the simulator was evaluating on behalf of the interrupted process." + (originalProcess + evaluate: [ex defaultAction] + onBehalfOf: nil)]! - [ex pass]]! Item was changed: ----- Method: Debugger>>tryRestartFrom: (in category 'context stack menu') ----- tryRestartFrom: context "Try to restart from the initial state of the context. Return whether an unwind error occurred." + | currentContext unwindError | + currentContext := self selectedContext. + currentContext := self + handleLabelUpdatesIn: [interruptedProcess popTo: context] + whenExecuting: currentContext. + unwindError := currentContext ~= context. - | actualContext unwindError | - actualContext := interruptedProcess popTo: context. - unwindError := actualContext ~= context. unwindError ifFalse: [ + currentContext := self + handleLabelUpdatesIn: [interruptedProcess restartTop; stepToSendOrReturn] + whenExecuting: currentContext]. + self resetContext: currentContext. - actualContext := interruptedProcess restartTop; stepToSendOrReturn]. - self resetContext: actualContext. ^ unwindError!

1 0

The Trunk: ST80-ct.298.mcz
by commits＠source.squeak.org 03 Mar '24

03 Mar '24

Christoph Thiede uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-ct.298.mcz ==================== Summary ==================== Name: ST80-ct.298 Author: ct Time: 3 March 2024, 7:56:11.711958 pm UUID: fcb9f599-f766-3143-98b0-634c455acf9c Ancestors: ST80-dtl.297 Complements Kernel-ct.1559 (merges SimulationSideEffectWarning.5.cs, step 2/2). =============== Diff against ST80-dtl.297 =============== Item was changed: ----- Method: ControlManager>>activeController: (in category 'accessing') ----- activeController: aController + "Set aController to be the currently active controller. Give the user control in it." + <simulationGuard> + - "Set aController to be the currently active controller. Give the user - control in it." - <primitive: 19> "Simulation guard" activeController := aController. (activeController == screenController) ifFalse: [self promote: activeController]. activeControllerProcess := [activeController startUp. self searchForActiveController] newProcess. activeControllerProcess priority: Processor userSchedulingPriority. activeControllerProcess resume! Item was changed: ----- Method: ControlManager>>scheduleActive: (in category 'scheduling') ----- scheduleActive: aController + "Make aController be scheduled as the active controller. Presumably the active scheduling process asked to schedule this controller and that a new process associated this controller takes control. So this is the last act of the active scheduling process." + <simulationGuard> + - "Make aController be scheduled as the active controller. Presumably the - active scheduling process asked to schedule this controller and that a - new process associated this controller takes control. So this is the last act - of the active scheduling process." - <primitive: 19> "Simulation guard" self scheduleActiveNoTerminate: aController. Processor terminateActive!

1 0