Squeak-dev February 2024

squeak-dev@lists.squeakfoundation.org

32 participants
107 discussions

The Trunk: CollectionsTests-cmm.405.mcz
by commits＠source.squeak.org 19 Feb '24

19 Feb '24

Chris Muller uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-cmm.405.mcz ==================== Summary ==================== Name: CollectionsTests-cmm.405 Author: cmm Time: 18 February 2024, 5:22:35.213846 pm UUID: fa6e9709-7f5a-4781-b197-45bd9a9e1414 Ancestors: CollectionsTests-cmm.404 Include, in #testPeeks, the cases where the argument overshoots the bounds of the underlying stream, in either direction. =============== Diff against CollectionsTests-cmm.404 =============== Item was changed: ----- Method: ReadStreamTest>>testPeeks (in category 'tests - accessing') ----- testPeeks | stream | stream := self streamOnArray. self assert: (stream peek: 0) = #(). self assert: (stream peek: 1) = #(1). self assert: (stream peek: 3) = #(1 (a b c) false). self assert: (stream peek: 4) = #(1 (a b c) false). stream next. self assert: (stream peek: -1) = #(1). + self assert: (stream peek: -99) = #(1). self assert: (stream peek: 0) = #(). self assert: (stream peek: 1) = #((a b c)). + self assert: (stream peek: 3) = #((a b c) false). + self assert: (stream peek: 99) = #((a b c) false)! - self assert: (stream peek: 3) = #((a b c) false).!

1 0

The Trunk: CollectionsTests-cmm.404.mcz
by commits＠source.squeak.org 19 Feb '24

19 Feb '24

Chris Muller uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-cmm.404.mcz ==================== Summary ==================== Name: CollectionsTests-cmm.404 Author: cmm Time: 18 February 2024, 5:18:33.048788 pm UUID: 1a56870d-c708-4750-bf4b-165435161a68 Ancestors: CollectionsTests-mt.403 Test #peek: with a negative argument. =============== Diff against CollectionsTests-mt.403 =============== Item was changed: ----- Method: ReadStreamTest>>testPeeks (in category 'tests - accessing') ----- testPeeks | stream | stream := self streamOnArray. self assert: (stream peek: 0) = #(). self assert: (stream peek: 1) = #(1). self assert: (stream peek: 3) = #(1 (a b c) false). self assert: (stream peek: 4) = #(1 (a b c) false). stream next. + + self assert: (stream peek: -1) = #(1). - self assert: (stream peek: 0) = #(). self assert: (stream peek: 1) = #((a b c)). self assert: (stream peek: 3) = #((a b c) false).!

1 0

The Inbox: System-dtl.1447.mcz
by commits＠source.squeak.org 18 Feb '24

18 Feb '24

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-dtl.1447.mcz ==================== Summary ==================== Name: System-dtl.1447 Author: dtl Time: 18 February 2024, 10:30:07.309835 am UUID: 532176ff-7a46-4306-a373-252ca1cc09f2 Ancestors: System-codefrau.1446 Move the low space watcher from SmalltalkImage to new class LowSpaceWatcher having a singleton with responsibility for the low space semaphore and low space watcher process. Add class and method comments and split lowSpaceWatcher into smaller methods to clarify steps in the process. Add #registerCleaner for adding savvy memory hogs to the memory hog registry. For organization and documentation only, no functional change to the low space watcher or memory policies. =============== Diff against System-codefrau.1446 =============== Item was added: + Object subclass: #LowSpaceWatcher + instanceVariableNames: 'lowSpaceProcess lowSpaceSemaphore' + classVariableNames: 'Default MemoryHogs' + poolDictionaries: '' + category: 'System-Support'! + + !LowSpaceWatcher commentStamp: 'dtl 1/28/2024 17:56' prior: 0! + LowSpaceWatcher is responsible for responding to a notification from the virtual machine that memory is low and that it (the VM) may soon be unable to support additional object memory allocations. A single default instance for the image manages both the low space semaphore and the process that waits on the semaphore to handle low space conditions. When the low space watcher is notified that memory is low, it attempts to identify the process likely associated with the low space condition and to provide a notifier to allow the problem condition to be corrected. + + If a low space condition is detected in the virtual machine, the low space semaphore is signalled either directly by the VM or indirectly through an OutOfMemory error following a failed primitive invocation. The VM is responsible for identifying low space conditions, and its behavior will vary depending on both the VM implementation and the memory system of the underlying platform operating system. In particular, on a virtual machine operating system the VM may continue to receive memory allocations from the operating system while the operating system attempts to support the memory requests by increased swapping to disk. Under these conditions, the low space semaphore may not be signalled because system memory still appears to be available, even though performance is severely degraded due to swapping. + + The VM may provide control of its memory usage, typically through command line parameters or VM parameters that can be set from the image. These parameters will affect when and if the low space watcher is signalled by the VM. + + A registry is maintained in class variable MemoryHogs to identify objects (classes) know how to release unneeded memory when sent the message #freeSomeSpace. The low space watcher process will send this message when a low spaced condition is encountered. + + To signal the low space watcher and simulate a low space condition, evaluate "LowSpaceWatcher default signalLowSpace".! Item was added: + ----- Method: LowSpaceWatcher class>>default (in category 'instance creation') ----- + default + "The singleton low space watcher." + + ^ Default ifNil: [ Default := self new start ] + ! Item was added: + ----- Method: LowSpaceWatcher class>>install (in category 'instance creation') ----- + install + "Start a process to watch for low-space conditions." + "Smalltalk installLowSpaceWatcher" + + self default stop; start + + ! Item was added: + ----- Method: LowSpaceWatcher class>>registerCleaner: (in category 'memory hog registry') ----- + registerCleaner: memoryCleaner + "Add memoryCleaner to the MemoryHog list where memoryCleaner is an object or class that responds to #freeSomeSpace." + + (memoryCleaner respondsTo: #freeSomeSpace) + ifFalse: [ ^ self error: memoryCleaner asString, ' does not understand #freeSomeSpace' ]. + (self default memoryHogs includes: memoryCleaner) + ifFalse: [ MemoryHogs add: memoryCleaner ].! Item was added: + ----- Method: LowSpaceWatcher class>>signalLowSpace (in category 'signal low space') ----- + signalLowSpace + "Signal the low-space semaphore to alert the user that space is running low." + + ^ self default signalLowSpace.! Item was added: + ----- Method: LowSpaceWatcher>>disableVirtualMachineNotifications (in category 'process steps') ----- + disableVirtualMachineNotifications + "Ask the virtual machine to stop sending low space interrupts, and forget the current semaphore and watcher process." + + self primSignalAtBytesLeft: 0. "disable low space interrupts" + self primLowSpaceSemaphore: nil. + lowSpaceProcess := nil. + ! Item was added: + ----- Method: LowSpaceWatcher>>findPreemptedProcess (in category 'process steps') ----- + findPreemptedProcess + "Find the process that was active at the time of the low space interrupt. Check + first if the virtual machine has recorded the process that was active at the time + that it detected the low space detection, otherwise answer the process that was + most recently preempted when the semaphore was signalled." + + | preemptedProcess | + preemptedProcess := (Smalltalk specialObjectsArray at: 23) + ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. + Smalltalk specialObjectsArray at: 23 put: nil. + ^ preemptedProcess + + ! Item was added: + ----- Method: LowSpaceWatcher>>handleLowSpaceCondition (in category 'process') ----- + handleLowSpaceCondition + "A low space condition has been detected. Do whatever may be necessary to free + some memory in the image before proceeding." + + | preemptedProcess | + preemptedProcess := self findPreemptedProcess. + self notifyMemoryHogs ifFalse: [ + self logError: preemptedProcess. + self notifyUser: preemptedProcess ]. + + ! Item was added: + ----- Method: LowSpaceWatcher>>initializeVirtualMachineNotifications (in category 'process steps') ----- + initializeVirtualMachineNotifications + "Let the virtual machine know how to notify the image of low space conditions." + + Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" + lowSpaceSemaphore := Semaphore new. + self primLowSpaceSemaphore: lowSpaceSemaphore. + self primSignalAtBytesLeft: Smalltalk lowSpaceThreshold. "enable low space interrupts" + ! Item was added: + ----- Method: LowSpaceWatcher>>logError: (in category 'process steps') ----- + logError: preemptedProcess + + Preferences logDebuggerStackToFile ifTrue: [ + Smalltalk + logError: 'Space is low' + inContext: preemptedProcess suspendedContext + to: 'LowSpaceDebug.log' ]. + ! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceChoices (in category 'memory space') ----- + lowSpaceChoices + "Return a notifier message string to be presented when space is running low." + + ^ 'Warning!! Squeak is almost out of memory!! + + Low space detection is now disabled. It will be restored when you close or proceed from this error notifier. Don''t panic, but do proceed with caution. + + Here are some suggestions: + + If you suspect an infinite recursion (the same methods calling each other again and again), then close this debugger, and fix the problem. + + If you want this computation to finish, then make more space available (read on) and choose "proceed" in this debugger. Here are some ways to make more space available... + > Close any windows that are not needed. + > Get rid of some large objects (e.g., images). + > Leave this window on the screen, choose "save as..." from the screen menu, quit, restart the Squeak VM with a larger memory allocation, then restart the image you just saved, and choose "proceed" in this window. + + If you want to investigate further, choose "debug" in this window. Do not use the debugger "fullStack" command unless you are certain that the stack is not very deep. (Trying to show the full stack will definitely use up all remaining memory if the low-space problem is caused by an infinite recursion!!). + + ' + ! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceWatcher (in category 'process') ----- + lowSpaceWatcher + "Wait until the low space semaphore is signalled, then take appropriate actions. This + method is run once in the low space watcher process. Before terminating, it schedules + a new process to handle the next low space condition." + + self safeToInstall ifFalse: [ ^ Beeper beep]. + self initializeVirtualMachineNotifications. + lowSpaceSemaphore wait. + self disableVirtualMachineNotifications; handleLowSpaceCondition. + self start. "schedule a new process to handle the next low space condition" + + ! Item was added: + ----- Method: LowSpaceWatcher>>lowSpaceWatcherProcess (in category 'process') ----- + lowSpaceWatcherProcess + "Answer the process in which lowSpaceWatcher is running. A process browser + can use this to identify and label the system wide low space watcher process." + ^lowSpaceProcess! Item was added: + ----- Method: LowSpaceWatcher>>memoryHogs (in category 'memory space') ----- + memoryHogs + "Answer the list of objects to notify with #freeSomeSpace if memory gets full." + + ^ MemoryHogs ifNil: [MemoryHogs := OrderedCollection new]! Item was added: + ----- Method: LowSpaceWatcher>>notifyMemoryHogs (in category 'process steps') ----- + notifyMemoryHogs + "Try to clean up memory hogs. Answer true if sufficient memory was released." + + | free | + self memoryHogs isEmpty + ifTrue: [ ^ false ] + ifFalse: [ free := Smalltalk bytesLeft. + self memoryHogs + do: [ :hog | hog freeSomeSpace ]. + ^ Smalltalk bytesLeft > free ] + + ! Item was added: + ----- Method: LowSpaceWatcher>>notifyUser: (in category 'process steps') ----- + notifyUser: preemptedProcess + "Interrupt the user to allow the low space condition to be corrected. The user + is now unprotected until the low space watcher is re-installed." + + Project current + interruptName: 'Space is low' + message: self lowSpaceChoices + preemptedProcess: preemptedProcess. + ! Item was added: + ----- Method: LowSpaceWatcher>>primLowSpaceSemaphore: (in category 'primitive access') ----- + primLowSpaceSemaphore: aSemaphore + "Primitive. Register the given Semaphore to be signalled when the + number of free bytes drops below some threshold. Disable low-space + interrupts if the argument is nil." + + <primitive: 124> + self primitiveFailed! Item was added: + ----- Method: LowSpaceWatcher>>primSignalAtBytesLeft: (in category 'primitive access') ----- + primSignalAtBytesLeft: numBytes + "Tell the interpreter the low-space threshold in bytes. When the free + space falls below this threshold, the interpreter will signal the low-space + semaphore, if one has been registered. Disable low-space interrupts if the + argument is zero. Fail if numBytes is not an Integer." + + <primitive: 125> + self primitiveFailed! Item was added: + ----- Method: LowSpaceWatcher>>safeToInstall (in category 'process steps') ----- + safeToInstall + "Free space must be above threshold before starting low space watcher" + + ^Smalltalk garbageCollectMost > Smalltalk lowSpaceThreshold + or: [Smalltalk garbageCollect > Smalltalk lowSpaceThreshold] + + ! Item was added: + ----- Method: LowSpaceWatcher>>signalLowSpace (in category 'memory space') ----- + signalLowSpace + "Signal the low-space semaphore to alert the user that space is running low." + + lowSpaceSemaphore signal.! Item was added: + ----- Method: LowSpaceWatcher>>start (in category 'initialize-release') ----- + start + "Start a new low space watcher process that will register a semaphore with the + virtual machine and wait for the semaphore to be signalled if a low space condition + is detected." + + lowSpaceProcess := [self lowSpaceWatcher] forkAt: Processor lowIOPriority. + ! Item was added: + ----- Method: LowSpaceWatcher>>stop (in category 'initialize-release') ----- + stop. + "Ask the virtual machine to disable low space interrupts, then terminate the watcher process." + + self primSignalAtBytesLeft: 0. "disable low-space interrupts" + lowSpaceProcess == nil ifFalse: [lowSpaceProcess terminate]. + lowSpaceProcess := lowSpaceSemaphore := nil. + ! Item was changed: Object subclass: #SmalltalkImage instanceVariableNames: 'globals' + classVariableNames: 'EndianCache LastImageName LastQuitLogPosition LastStats PlatformNameCache ShutDownList SourceFileVersionString StartUpList StartupStamp VMMakerVersion WordSize' - classVariableNames: 'EndianCache LastImageName LastQuitLogPosition LastStats LowSpaceProcess LowSpaceSemaphore MemoryHogs PlatformNameCache ShutDownList SourceFileVersionString StartUpList StartupStamp VMMakerVersion WordSize' poolDictionaries: '' category: 'System-Support'! !SmalltalkImage commentStamp: 'dtl 3/6/2010 14:00' prior: 0! I represent the current image and runtime environment, including system organization, the virtual machine, object memory, plugins and source files. My instance variable #globals is a reference to the system dictionary of global variables and class names. My singleton instance is called Smalltalk.! Item was changed: ----- Method: SmalltalkImage>>installLowSpaceWatcher (in category 'memory space') ----- installLowSpaceWatcher "Start a process to watch for low-space conditions." "Smalltalk installLowSpaceWatcher" + LowSpaceWatcher install - self primSignalAtBytesLeft: 0. "disable low-space interrupts" - LowSpaceProcess == nil ifFalse: [LowSpaceProcess terminate]. - LowSpaceProcess := [self lowSpaceWatcher] newProcess. - LowSpaceProcess priority: Processor lowIOPriority. - LowSpaceProcess resume. ! Item was removed: - ----- Method: SmalltalkImage>>lowSpaceChoices (in category 'memory space') ----- - lowSpaceChoices - "Return a notifier message string to be presented when space is running low." - - ^ 'Warning!! Squeak is almost out of memory!! - - Low space detection is now disabled. It will be restored when you close or proceed from this error notifier. Don''t panic, but do proceed with caution. - - Here are some suggestions: - - If you suspect an infinite recursion (the same methods calling each other again and again), then close this debugger, and fix the problem. - - If you want this computation to finish, then make more space available (read on) and choose "proceed" in this debugger. Here are some ways to make more space available... - > Close any windows that are not needed. - > Get rid of some large objects (e.g., images). - > Leave this window on the screen, choose "save as..." from the screen menu, quit, restart the Squeak VM with a larger memory allocation, then restart the image you just saved, and choose "proceed" in this window. - - If you want to investigate further, choose "debug" in this window. Do not use the debugger "fullStack" command unless you are certain that the stack is not very deep. (Trying to show the full stack will definitely use up all remaining memory if the low-space problem is caused by an infinite recursion!!). - - ' - ! Item was removed: - ----- Method: SmalltalkImage>>lowSpaceWatcher (in category 'memory space') ----- - lowSpaceWatcher - "Wait until the low space semaphore is signalled, then take appropriate actions." - - | free preemptedProcess | - self garbageCollectMost <= self lowSpaceThreshold - ifTrue: [self garbageCollect <= self lowSpaceThreshold - ifTrue: ["free space must be above threshold before - starting low space watcher" - ^ Beeper beep]]. - - Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" - LowSpaceSemaphore := Semaphore new. - self primLowSpaceSemaphore: LowSpaceSemaphore. - self primSignalAtBytesLeft: self lowSpaceThreshold. "enable low space interrupts" - - LowSpaceSemaphore wait. "wait for a low space condition..." - - self primSignalAtBytesLeft: 0. "disable low space interrupts" - self primLowSpaceSemaphore: nil. - LowSpaceProcess := nil. - - "The process that was active at the time of the low space interrupt." - preemptedProcess := (Smalltalk specialObjectsArray at: 23) - ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. - Smalltalk specialObjectsArray at: 23 put: nil. - - "Note: user now unprotected until the low space watcher is re-installed" - - self memoryHogs isEmpty - ifFalse: [free := self bytesLeft. - self memoryHogs - do: [ :hog | hog freeSomeSpace ]. - self bytesLeft > free - ifTrue: [ ^ self installLowSpaceWatcher ]]. - - Preferences logDebuggerStackToFile ifTrue: [ - self - logError: 'Space is low' - inContext: preemptedProcess suspendedContext - to: 'LowSpaceDebug.log']. - - Project current - interruptName: 'Space is low' - message: self lowSpaceChoices - preemptedProcess: preemptedProcess - ! Item was changed: ----- Method: SmalltalkImage>>lowSpaceWatcherProcess (in category 'memory space') ----- lowSpaceWatcherProcess + ^LowSpaceWatcher default ifNotNil: [ :watcher | watcher lowSpaceWatcherProcess ]! - ^LowSpaceProcess! Item was removed: - ----- Method: SmalltalkImage>>memoryHogs (in category 'memory space') ----- - memoryHogs - "Answer the list of objects to notify with #freeSomeSpace if memory gets full." - - ^ MemoryHogs ifNil: [MemoryHogs := OrderedCollection new]! Item was removed: - ----- Method: SmalltalkImage>>primLowSpaceSemaphore: (in category 'memory space') ----- - primLowSpaceSemaphore: aSemaphore - "Primitive. Register the given Semaphore to be signalled when the - number of free bytes drops below some threshold. Disable low-space - interrupts if the argument is nil." - - <primitive: 124> - self primitiveFailed! Item was removed: - ----- Method: SmalltalkImage>>primSignalAtBytesLeft: (in category 'memory space') ----- - primSignalAtBytesLeft: numBytes - "Tell the interpreter the low-space threshold in bytes. When the free - space falls below this threshold, the interpreter will signal the low-space - semaphore, if one has been registered. Disable low-space interrupts if the - argument is zero. Fail if numBytes is not an Integer." - - <primitive: 125> - self primitiveFailed! Item was removed: - ----- Method: SmalltalkImage>>signalLowSpace (in category 'memory space') ----- - signalLowSpace - "Signal the low-space semaphore to alert the user that space is running low." - - LowSpaceSemaphore signal.!

3 3

Re: Low space watcher and memory policy
by lewis＠mail.msen.com 18 Feb '24

18 Feb '24

Hi Eliot, When you get a chance, please take a look at System-dtl.1446 in the inbox (especially the comments). I don't think you have seen it yet. The VM I am using is 5.0-202311211431-64bit. Dave On 2024-02-03 03:12, Eliot Miranda wrote: > Hi Dave, > >> On Feb 2, 2024, at 3:12 PM, lewis(a)mail.msen.com wrote: > >> Hi Eliot, >> >> MemoryPolicy deserves its own class (and comments). LowSpaceWatcher is >> the mechanism of reacting to a low space condition and implements no >> policy. > > Of course it implements a policy. It decides to interrupt the current > running process. And it does so based on examining parameters after the > mechanism of signaling the low space semaphore has fired, itself > controlled by a parameter. These parameters can happily live inside a > MemoryPolicy object, as experience shows (c.f. VisualWorks). > >> I'm basically just trying to clarify the existing and/or prior >> mechanism, and potentially to get some ancient cruft out of >> SmalltalkImage. Anything related to policy is still sitting in >> SmalltalkImage. > > Si why not avoid the sad pitfall of a one method class, something Pharo > did hilariously and pathetically with Smalltalk endianness, and start > on the right track implementing MemoryPolicy, something seriously > lacking on n Squeak atm? > >> But I have to note for the record that the low space watcher does not >> actually do anything for any configuration I can come up with on my >> Linux PC. The mechanism works (signal the semaphore and the process >> reacts with notifier etc), but I can't get the semaphore to be >> signalled either directly from the VM or as a result of an allocation >> primitive failure. > > That may just be an out-of-date VM. I had to fix something recently to > get the mechanics working. > > Dave > > On 2024-02-02 15:24, Eliot Miranda wrote: > > David, all, > > please do not extract lowSpaceWatcher to a class called > LowSpaceWatcher. This would be a *serious* mistake. Instead, extract it > to a class called MemoryPolicy. There is low space, growing & > shrinking the heap, and soon enough rate control of the incremental old > space collector to manage. > > _,,,^..^,,,_ (phone) > > On Jan 28, 2024, at 5:19 PM, lewis(a)mail.msen.com wrote: > > I decided to give this idea a try, and I think that it does help with > the documentation. Please try loading System-dtl.1445 from the inbox, > then evaluate "HelpBrowser openOn: LowSpaceWatcher". Let me know what > you think of it :-) > > Dave > > On 2024-01-27 18:51, Jaromir Matas wrote: > Hi Dave, > > Interesting, I wondered why the low space watcher doesn't have its > class :) > > best, > Jaromir > > On 27-Jan-24 4:53:59 AM, lewis(a)mail.msen.com wrote: > > On 2024-01-26 08:32, Taeumel, Marcel via Squeak-dev wrote: Hi Jaromir > -- > > What would be a good place to document the current state and intentions > about low-space watcher? I mean, what would have helped you in this > case? > > Best, > Marcel > > One way to document the low space watcher might be to turn it into a > proper object with > a good class comment. > > The low space watcher process is currently attached to a class variable > in class > SmalltalkImage. This is reasonable and appropriate, but it would be > just as reasonable > to have a LowSpaceWatcher object attached to the class variable, and > let the LowSpaceWatcher > own the process and implement methods related for that process. The > semaphore and > primitive calls could also move from SmalltalkImage to LowSpaceWatcher. > > Class SmalltalkImage has a lot of responsibilities already, so moving > the responsibility > for managing low space handling to a new class called LowSpaceWatcher > might be a reasonable > thing to do. A happy side effect would be to let this new class serve > as documentation for > the intended behavior of the low-space watcher process. > > Dave

2 2

The Inbox: Kernel-cmm.1552.mcz
by commits＠source.squeak.org 18 Feb '24

18 Feb '24

Chris Muller uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-cmm.1552.mcz ==================== Summary ==================== Name: Kernel-cmm.1552 Author: cmm Time: 17 February 2024, 6:51:41.305415 pm UUID: 4be9b419-9949-4c40-a0c3-1059124e34c8 Ancestors: Kernel-mt.1551 Adopt mutually compatible ByteArray-->Integer and Integer-->ByteArray conversoins that respect classic Network Byte Order (big-endian) and have been used in Squeak since 2002. =============== Diff against Kernel-mt.1551 =============== Item was added: + ----- Method: ByteArray>>asInteger (in category '*kernel-converting') ----- + asInteger + ^ self inject: 0 into: [ :sum :each | sum * 256 + each]! Item was added: + ----- Method: Integer>>asByteArray (in category 'converting') ----- + asByteArray + + | stream | + stream := WriteStream on: ByteArray new. + self digitLength to: 1 by: -1 do: [:digitIndex | + stream nextPut: (self digitAt: digitIndex)]. + ^ stream contents + ! Item was removed: - ----- Method: LargePositiveInteger>>asByteArray (in category 'converting') ----- - asByteArray - - ^self as: ByteArray!

1 0

#asByteArray needed for more classes, maybe
by Tim Rowledge 18 Feb '24

18 Feb '24

Whilst testing out Seaside in the 6.1 trunk image we discovered that LargePositiveInteger needs an #asByteArray method to enable the entity tag method to provide all that nice formatting stuff. For the specific case of LPI it's trivial "self as: ByteArray" works fine and sure, maybe it could be optimised. However, there is actual usage of #asByteArray in the main image that appears to be unsatisfied. For example, Magnitude>>#putOn: for binary streams. It appears no subclass of Magnitude implements #asByteArray, which seems unfortunate.#putOn: is used a fair bit in writing to streams. There's also some clashing with potentially important behaviour where collections of (very)smallintegers can be converted to ByteArrays so long as all the numeric values are <255. If we were to make an #asByteArray for SmallInteger that produced up to 8 bytes, how might that affect some of these usages? And what is a good byte array representation of a LargeNegativeInteger? And should every conversion be reversible? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: EF: Emulate Fireworks

11 33

The Inbox: System-cmm.1447.mcz
by commits＠source.squeak.org 18 Feb '24

18 Feb '24

Chris Muller uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-cmm.1447.mcz ==================== Summary ==================== Name: System-cmm.1447 Author: cmm Time: 12 February 2024, 3:06:16.671515 pm UUID: 03b7d234-da01-4b78-94c0-f78c01d4afe0 Ancestors: System-codefrau.1446 FileStream's stdout and stderr are for Linux, so use Linux line-endings when writing to them. =============== Diff against System-codefrau.1446 =============== Item was changed: ----- Method: CodeLoader>>installSourceFile: (in category 'installing') ----- installSourceFile: aStream "Install the previously loaded source file" | contents trusted | aStream ifNil:[^self error:'No content to install']. trusted := SecurityManager default positionToSecureContentsOf: aStream. trusted ifFalse:[(SecurityManager default enterRestrictedMode) ifFalse:[ aStream close. ^ self error:'Insecure content encountered']]. contents := self allButShebangLine: aStream upToEnd unzipped asString. (aStream respondsTo: #close) ifTrue:[aStream close]. ^[contents readStream fileIn] on: SyntaxErrorNotification do: [ : err | Smalltalk isHeadless ifTrue: + [FileStream stdout nextPutAll: err errorCode; lf; flush. - [FileStream stdout nextPutAll: err errorCode; cr; flush. Smalltalk snapshot: false andQuit: true ] ifFalse: [err pass] ]! Item was changed: ----- Method: Exception>>printVerboseOn: (in category '*system') ----- printVerboseOn: aStream aStream nextPutAll: 'vvvvvvvvvvvvvvvvvv ' , self description , ' vvvvvvvvvvvvvvvvvv' ; + lf ; - cr ; nextPutAll: 'The time is ', DateAndTime now asString ; + lf. - cr. "Allow applications to optionally print extra details without overriding a base package." self printDetailsOn: aStream. aStream nextPutAll: self signalerContext longStack ; + lf ; - cr ; nextPutAll: '^^^^^^^^^^^^^^^^^^ ' , self description , ' ^^^^^^^^^^^^^^^^^^' ; + lf ; - cr ; flush! Item was changed: ----- Method: SmalltalkImage>>run: (in category 'command line') ----- run: aBlock [ [ self patchSystem. (aBlock numArgs = 1 and: [ self arguments size > 1 ]) ifTrue: [ "Allow a large, variable number of arguments to be passed as an Array to aBlock." aBlock value: self arguments ] ifFalse: [ aBlock valueWithEnoughArguments: self arguments ] ] on: SyntaxErrorNotification do: [ : err | FileStream stdout nextPutAll: err errorCode ; + lf; flush. - cr; flush. self isHeadless ifTrue: [ self snapshot: false andQuit: true ] ifFalse: [ err pass ] ] on: Error , ProvideAnswerNotification do: [ : err | err printVerboseOn: FileStream stderr. FileStream stderr flush. self isHeadless ifTrue: [ self snapshot: false andQuit: true ] ifFalse: [ err pass ] ] on: ProgressInitiationException do: [ : pie | "Don't want to log this Notification." pie defaultAction ] ] on: Notification , Warning do: [ : noti | FileStream stdout nextPutAll: DateAndTime now asString ; space ; nextPutAll: noti description ; + lf. - cr. noti resume ] !

6 8

The Trunk: Graphics-mt.550.mcz
by commits＠source.squeak.org 14 Feb '24

14 Feb '24

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.550.mcz ==================== Summary ==================== Name: Graphics-mt.550 Author: mt Time: 14 February 2024, 2:43:57.021709 pm UUID: e7ee4cb8-e57d-0a4e-bf06-ab05629b9bb6 Ancestors: Graphics-mt.549 Remove unused x-width data for "DejaVu Sans Bold 13". We do not have the form data because size 13 is not supported. Only 12, 14, 17, ... and others. Thanks to Levente (ul) for the hint! =============== Diff against Graphics-mt.549 =============== Item was removed: - ----- Method: StrikeFont class>>dejaVuSansBold13Data (in category 'dejaVu font data') ----- (excessive size, no diff calculated)

1 0

The Trunk: ToolBuilder-Morphic-mt.349.mcz
by commits＠source.squeak.org 14 Feb '24

14 Feb '24

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.349.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.349 Author: mt Time: 14 February 2024, 1:41:47.973344 pm UUID: 62ccb225-9c52-7f48-ac71-1f16e95c83b5 Ancestors: ToolBuilder-Morphic-mt.348 Complement Morphic-mt.2152 =============== Diff against ToolBuilder-Morphic-mt.348 =============== Item was added: + ----- Method: PluggableButtonMorphPlus>>spyOnAction (in category 'debug menu') ----- + spyOnAction + + action ifNil: [^ super spyOnAction]. + TimeProfileBrowser spyOn: [self performAction].!

1 0

The Trunk: Morphic-mt.2152.mcz
by commits＠source.squeak.org 14 Feb '24

14 Feb '24

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2152.mcz ==================== Summary ==================== Name: Morphic-mt.2152 Author: mt Time: 14 February 2024, 1:41:08.155344 pm UUID: 2437b99d-d4cc-2647-b5f1-efbc85d16c89 Ancestors: Morphic-dtl.2151 In a button's debug menu (via halo), add spy-on shortcut besides debug-it and browse-it. Useful for profiling the effects of a button click. =============== Diff against Morphic-dtl.2151 =============== Item was changed: ----- Method: MenuItemMorph>>buildDebugMenu: (in category 'browse') ----- buildDebugMenu: aHandMorph | aMenu | aMenu := super buildDebugMenu: aHandMorph. aMenu addLine. aMenu add: 'browse action code' translated target: self action: #browseImplementationOfActionSelector. aMenu lastItem isEnabled: self selector notNil. aMenu add: 'debug action invocation' translated target: self action: #debugAction. aMenu lastItem isEnabled: self selector notNil. + aMenu add: 'spy on action invocation' translated target: self action: #spyOnAction. + aMenu lastItem isEnabled: self selector notNil. ^ aMenu! Item was added: + ----- Method: MenuItemMorph>>spyOnAction (in category 'browse') ----- + spyOnAction + + TimeProfileBrowser spyOn: [self doButtonAction].! Item was changed: ----- Method: PluggableButtonMorph>>buildDebugMenu: (in category 'debug menu') ----- buildDebugMenu: aHandMorph | aMenu | aMenu := super buildDebugMenu: aHandMorph. aMenu addLine. aMenu add: 'browse action code' translated target: self action: #browseImplementationOfActionSelector. aMenu add: 'debug action invocation' translated target: self action: #debugAction. + aMenu add: 'spy on action invocation' translated target: self action: #spyOnAction. ^ aMenu! Item was added: + ----- Method: PluggableButtonMorph>>spyOnAction (in category 'debug menu') ----- + spyOnAction + + self updateArguments. + TimeProfileBrowser spyOn: [self doButtonAction].! Item was changed: ----- Method: SimpleButtonMorph>>buildDebugMenu: (in category 'debug menu') ----- buildDebugMenu: aHandMorph | aMenu | aMenu := super buildDebugMenu: aHandMorph. aMenu addLine. aMenu add: 'browse action code' translated target: self action: #browseImplementationOfActionSelector. aMenu add: 'debug action invocation' translated target: self action: #debugAction. + aMenu add: 'spy on action invocation' translated target: self action: #spyOnAction. ^ aMenu! Item was added: + ----- Method: SimpleButtonMorph>>spyOnAction (in category 'debug menu') ----- + spyOnAction + + TimeProfileBrowser spyOn: [self doButtonAction].!

1 0

← Newer
1
...
5
6
7
8
9
10
11
Older →