Squeak-dev February 2024

squeak-dev@lists.squeakfoundation.org

32 participants
107 discussions

The Inbox: Kernel-ct.1405.mcz
by commits＠source.squeak.org 02 Mar '24

02 Mar '24

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1405.mcz ==================== Summary ==================== Name: Kernel-ct.1405 Author: ct Time: 15 May 2021, 3:56:24.713389 pm UUID: 9a92be9b-d778-b54f-b659-713451a2ddb2 Ancestors: Kernel-nice.1402 Counterproposal to Kernel-jar.1404 for fixing VM crashes when resuming from a BlockCannotReturn. Instead of enforcing retrial, repair the context stack if the receiver has ended. There are two reasons for that: 1. Not in all situations, the receiver of #cannotReturn: is actually unable to resume. Consider this example for a disproof: a := [true ifTrue: [^ 1]. 2]. "Both statements need to be executed separately in a Workspace so that [a outerContext sender] becomes nil!" a value. In this situation, it is valid to resume from BlockCannotReturn and currently also possible in the Trunk. Note that BlockCannotReturn even overrides #isResumable to answer true, though the class comment discrecommends resuming it. 2. The pattern proposed by Jaromir reminds me of the current implementation of Object >> #doesNotUnderstand: or Object >> #at:, that is, when the error was resumed, just try it again in the manner of a (potentially) infinite recursion. While the issue with infinite debuggers (which was eventually tripped by exactly this pattern) has been solved some time ago [1], I do not really agree with the pattern in general - it makes it unnecessarily hard for ToolSet implementors to consciously resume from an error instead of retrying it (which we have an extra selector on Exception for). [1] http://forum.world.st/Please-try-out-Fixes-for-debugger-invocation-during-c… =============== Diff against Kernel-nice.1402 =============== Item was added: + ----- Method: BlockCannotReturn>>defaultResumeValue (in category 'defaults') ----- + defaultResumeValue + + ^ self result! Item was changed: ----- Method: Context>>cannotReturn: (in category 'private-exceptions') ----- cannotReturn: result + closureOrNil ifNotNil: [ + | resumptionValue | + resumptionValue := self cannotReturn: result to: self home sender. + self pc > self endPC ifTrue: [ + "This block has ended, continue with sender" + thisContext privSender: self sender]. + ^ resumptionValue]. - closureOrNil ifNotNil: [^ self cannotReturn: result to: self home sender]. Processor debugWithTitle: 'Computation has been terminated!!' translated full: false.!

8 16

The Trunk: JSON-cmm.62.mcz
by commits＠source.squeak.org 28 Feb '24

28 Feb '24

Chris Muller uploaded a new version of JSON to project The Trunk: http://source.squeak.org/trunk/JSON-cmm.62.mcz ==================== Summary ==================== Name: JSON-cmm.62 Author: cmm Time: 24 February 2024, 1:21:44.121899 am UUID: 8a043f53-c158-4a2a-b29a-0fb20d53d6a9 Ancestors: JSON-cmm.61 - Prefix json extension methods to indicate they're intended for Json outputs. - Better comments, implementations and tests for new path accessing functions. - Fix and a test an Array of Associations to be a Json object. =============== Diff against JSON-cmm.61 =============== Item was removed: - ----- Method: Collection>>atPath: (in category '*json') ----- - atPath: anArray - "Assume I'm a set of nested HashedCollections and/or SequenceableCollections. Answer the object at the path of indices and/or keys identified in anArray." - ^ self - atPath: anArray - ifLost: [ : last | self error: 'path lost after' , last asString ]! Item was removed: - ----- Method: Collection>>atPath:ifLost: (in category '*json') ----- - atPath: anArray ifLost: aBlock - "Assume I'm a set of nested HashedCollections and/or SequenceableCollections. Answer the object at the path of indices and/or keys identified in anArray. If the full path specified by anArray isn't present, cull aBlock with the last element present along the path." - | last | - ^ (self - path: anArray - do: [ : elem : node | last := node ]) - ifNil: [ aBlock cull: last ] - ifNotNil: [ last ]! Item was added: + ----- Method: Collection>>jsonAtPath: (in category '*json') ----- + jsonAtPath: anArray + "Assume I'm Json output. Answer the object at the path of indices and/or keys identified in anArray. If the full path specified by anArray isn't found, signal an Error." + ^ self + jsonAtPath: anArray + ifLost: [ : last | self error: 'path lost after index ' , last asString ]! Item was added: + ----- Method: Collection>>jsonAtPath:ifLost: (in category '*json') ----- + jsonAtPath: anArray ifLost: aBlock + "Assume I'm a Json object. Answer the sub-object at the path of indices and/or keys identified in anArray. If the full path specified by anArray isn't present, stop, and answer the value of aBlock culled with the index of the element within anArray that isn't found." + | last index | + index := 0. + ^ (self + jsonPath: anArray + do: + [ : elem : node | index := index + 1. + last := node ]) + ifNil: [ aBlock cull: index+1] + ifNotNil: [ last ]! Item was added: + ----- Method: Collection>>jsonPath:do: (in category '*json') ----- + jsonPath: anArray do: aBlock + "Assume I'm a Json output. Value aBlock with each object along the path of keys and/or indices identified in anArray. If a path element isn't found, stop, and return nil, otherwise, return self." + | current | + current := self. + anArray do: + [ : eachKey | "Json doesn't have Characters, allow pathing into Json objects only." + (current isArray or: [ current isDictionary ]) + ifTrue: + [ current + at: eachKey + ifPresent: + [ : eachValue | aBlock + value: eachKey + value: eachValue. + current := eachValue ] + ifAbsent: [ ^ nil ] ] + ifFalse: [ ^ nil ] ]. + ^ self! Item was added: + ----- Method: Collection>>jsonWriteListOn: (in category '*json') ----- + jsonWriteListOn: aStream + "By default, use array braces " + aStream nextPut: $[. + + self do: [:each | + each jsonWriteOn: aStream + ] separatedBy: [ aStream nextPut: $, ]. + + aStream nextPut: $]! Item was added: + ----- Method: Collection>>jsonWriteObjectOn: (in category '*json') ----- + jsonWriteObjectOn: aStream + + | needComma | + needComma := false. + aStream nextPut: ${. + self associationsDo: [ :assoc | + needComma + ifTrue: [ aStream nextPut: $, ] + ifFalse: [ needComma := true ]. + assoc key jsonWriteOn: aStream. + aStream nextPut: $:. + assoc value jsonWriteOn: aStream ]. + aStream nextPut: $}.! Item was changed: ----- Method: Collection>>jsonWriteOn: (in category '*json') ----- jsonWriteOn: aStream + (self notEmpty and: [self anyOne isVariableBinding]) + ifTrue: [ self jsonWriteObjectOn: aStream ] + ifFalse: [ self jsonWriteListOn: aStream ]! - "By default, use array braces " - aStream nextPut: $[. - - self do: [:each | - each jsonWriteOn: aStream - ] separatedBy: [ aStream nextPut: $, ]. - - aStream nextPut: $]! Item was removed: - ----- Method: Collection>>path:do: (in category '*json') ----- - path: anArray do: aBlock - "Assume I'm a set of nested HashedCollections and/or SequenceableCollections. Value aBlock with each object along the path of indices and/or keys identified in anArray. If a path element isn't found, stop, and return nil, otherwise, return self." - anArray - inject: self - into: - [ : dictOrArray : pathElem | dictOrArray - at: pathElem - ifPresent: [ : node | aBlock value: pathElem value: node ] - ifAbsent: [ ^ nil ] ]. - ^ self! Item was added: + ----- Method: JsonTests>>testNonDictionaryJsonObject (in category 'tests') ----- + testNonDictionaryJsonObject + self + render: {'a' -> 1. 'b' -> 2} + equals: '{"a":1,"b":2}'! Item was added: + ----- Method: JsonTests>>testPathAccess (in category 'tests') ----- + testPathAccess + | json lost | json := Json readFrom: '{ + "smalltalk" : { + "platformName":"unix", + "classes" : [ + { "id" : 3557, "name":"Integer" }, + { "id" : 3558, "name":"Float" }, + { "id" : 3559, "name":"Fraction" } + ] + } + }' readStream. + self assert: (json jsonAtPath: #('smalltalk' 'platformName')) = 'unix'. + "With array in the path." + self assert: (json jsonAtPath: #('smalltalk' 'classes' 1 'id')) = 3557. + self assert: (json jsonAtPath: #('smalltalk' 'classes' 2 'name')) = 'Float'. + "No pathing into byte objects, only Json objects." + self + should: [json jsonAtPath: #('smalltalk' 'classes' 2 'name' "Not allowed --->" 1)] + raise: Error. + "Key not found." + self + should: [ json jsonAtPath: #('smalltalk' 'wordSize') ] + raise: Error. + lost := false. + json + jsonAtPath: #('smalltalk' 'wordSize') + ifLost: [ : lostPosition | lost := true. self assert: lostPosition = 2 ]. + self assert: lost. + "Index OOB" + self + should: [ json jsonAtPath: #('smalltalk' 'classes' 99) ] + raise: Error. + lost := false. + json + jsonAtPath: #('smalltalk' 'classes' 99) + ifLost: [ : lostPosition | lost := true. self assert: lostPosition = 3 ]. + self assert: lost!

5 6

The Trunk: KernelTests-ct.456.mcz
by commits＠source.squeak.org 28 Feb '24

28 Feb '24

Christoph Thiede uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.456.mcz ==================== Summary ==================== Name: KernelTests-ct.456 Author: ct Time: 28 February 2024, 1:00:51.34405 am UUID: 18cac4fa-153a-1646-9b47-98fb20a52258 Ancestors: KernelTests-ct.455 Actually fixes OaM fixture for primitive 83/primitive 84 and adds the same fixture to testPrimitive100. Sorry for the noise. =============== Diff against KernelTests-ct.455 =============== Item was changed: ----- Method: ContextTest>>testPrimitive100 (in category 'tests - simulation') ----- testPrimitive100 "Test simulation of primitive 100." { {#isNil. {}. Object}. "valid 0-arg message" {#=. {true}. UndefinedObject}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}. Object}. "valid binary message" {{}. #=. {true}. SequenceableCollection}. "mirror primitive" {'not a selector'. {}. Object}. "invalid selector" {#isNil. 'not an array'. Object}. "invalid arguments" {#isNil. {'excess arg'}. Object}. "too many arguments" {#=. {}. UndefinedObject}. "missing argument" {#isNil. {}. 'not a class'}. "invalid lookupClass" {#isNil. {}. Boolean}. "lookupClass not in inheritance chain" + {#in:. + {[:it | + [self class addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod). + (self perform: #plonk:with: withArguments: #(2 3)) allButFirst "OaM selector is undefined behavior"] + ensure: [self class removeSelectorSilently: #plonk:with:]]}. + UndefinedObject}. } do: [:args | | block | block := [[nil perform: args first withArguments: args second inSuperclass: args third] on: Error do: [:ex | ex description]]. self assert: block value equals: (Context runSimulated: block). block := [[thisContext object: nil perform: args first withArguments: args second inClass: args third] on: Error do: [:ex | ex description]]. self assert: block value equals: (Context runSimulated: block)].! Item was changed: ----- Method: ContextTest>>testPrimitive83 (in category 'tests - simulation') ----- testPrimitive83 "Test simulation of primitive 83." self flag: #bug. "Known bug: Primitive 83 SPORADICALLY does NOT fail in the OSVM for missing argument!!" { [nil perform: #isNil]. "valid 0-arg message" [nil perform: #= with: true]. "valid unary message" [nil perform: #ifNil:ifNotNil: with: [2] with: [:x | x]]. "valid binary message" [nil perform: #isNil with: 'excess arg']. "too many arguments" [nil perform: #=]. "missing argument" [nil perform: Object]. "invalid selector" + [[self class addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod). + (self perform: #plonk:with: with: 2 with: 3) allButFirst "OaM selector is undefined behavior"] + ensure: [self class removeSelectorSilently: #plonk:with:]]. - [[(self class - addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod); - perform: #plonk:with: with: 2 with: 3) allButFirst "OaM selector is undefined behavior"] - ensure: [self class removeSelectorSilently: #plonk:with:]]. } do: [:block | self assert: (block on: Error do: [:ex | ex description]) equals: (Context runSimulated: [block on: Error do: [:ex | ex description]])].! Item was changed: ----- Method: ContextTest>>testPrimitive84 (in category 'tests - simulation') ----- testPrimitive84 "Test simulation of primitive 84." { {#isNil. {}}. "valid 0-arg message" {#=. {true}}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}}. "valid binary message" {#isNil. 'not an array'}. "invalid arguments" {#isNil. {'excess arg'}}. "too many arguments" {#=. {}}. "missing argument" {Object. {}}. "invalid selector" {#in:. {[:it | + [self class addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod). + (self perform: #plonk:with: withArguments: #(2 3)) allButFirst "OaM selector is undefined behavior"] + ensure: [self class removeSelectorSilently: #plonk:with:]]}}. - [(self class - addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod); - perform: #plonk:with: withArguments: #(2 3)) allButFirst "OaM selector is undefined behavior"] - ensure: [self class removeSelectorSilently: #plonk:with:]]}}. } do: [:args | self assert: ([nil perform: args first withArguments: args second] on: Error do: [:ex | ex description]) equals: (Context runSimulated: [[nil perform: args first withArguments: args second] on: Error do: [:ex | ex description]])].!

1 0

The Trunk: Collections-nice.1060.mcz
by commits＠source.squeak.org 27 Feb '24

27 Feb '24

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.1060.mcz ==================== Summary ==================== Name: Collections-nice.1060 Author: nice Time: 27 February 2024, 11:08:13.826491 pm UUID: 335742d4-2ba3-4c02-8019-86ff466a5772 Ancestors: Collections-cmm.1059, Collections-nice.1059 Merge Collections-cmm.1059, Collections-nice.1059 =============== Diff against Collections-cmm.1059 =============== Item was added: + ----- Method: RawBitsArray>>byteAt: (in category 'accessing') ----- + byteAt: anIndex + "Access a byte of the receiver, considered as a raw sequence of bytes. + This is a memory efficient implementation of: + ((self copy changeClassTo: ByteArray) at: anIndex)" + | int mask stride index shift | + self class isBytes + ifTrue: [^ self basicAt: anIndex]. + mask := 16rFF. + stride := self bytesPerBasicElement. + index := anIndex - 1 // stride + 1. + shift := anIndex - 1 \\ stride * -8. + Smalltalk isLittleEndian ifFalse: [shift := stride - 1 * 8 - shift]. + int := self basicAt: index. + int := int bitShift: shift. + int := int bitAnd: mask. + ^int! Item was added: + ----- Method: RawBitsArray>>byteAt:put: (in category 'accessing') ----- + byteAt: anIndex put: aByte + "Modify a byte of the receiver, considered as a raw sequence of bytes. + This is a less scary implementation than: + ([:class | ((self changeClassTo: ByteArray) at: anIndex put: aByte) changeClassTo: class] value: self class)" + | int stride index shift mask | + self class isBytes + ifTrue: [^ self basicAt: anIndex put: aByte]. + mask := 16rFF. + stride := self bytesPerBasicElement. + index := anIndex - 1 // stride + 1. + shift := anIndex - 1 \\ stride * 8. + Smalltalk isLittleEndian ifFalse: [shift := stride - 1 * 8 - shift]. + int := self basicAt: index. + int := int bitClear: (mask bitShift: shift). + int := int bitOr: (aByte bitShift: shift). + self basicAt: index put: int. + ^aByte! Item was added: + ----- Method: RawBitsArray>>reverseEndianness (in category 'converting') ----- + reverseEndianness + "reverse the endianness for each element" + + self class isBytes ifTrue: [^self]. + self class isWords ifTrue: [^self swapWords]. + self class isLongs ifTrue: [^self swapDoubleWords]. + self class isShorts ifTrue: [^self swapDoubleBytes]. + self error: 'this is not a collection of 1,2,4 or 8 bytes elements'! Item was added: + ----- Method: RawBitsArray>>swap16pairs (in category 'private') ----- + swap16pairs + "Swap every pair of double-bytes + Example: #[ 1 2 3 4 5 6 7 8 ] copy swap16pairs => #[ 3 4 1 2 7 8 5 6] + Implementation notes: this is the same as swapHalves, except that swapHalves only work for WordArray" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//4; width: 2. + blt sourceX: 0; destX: 2; copyBits. "Exchange double-bytes 0 and 1" + blt sourceX: 2; destX: 0; copyBits. + blt sourceX: 0; destX: 2; copyBits.! Item was added: + ----- Method: RawBitsArray>>swap32pairs (in category 'private') ----- + swap32pairs + "Swap every pair of words + Example: #[ 1 2 3 4 5 6 7 8 ] copy swap32pairs => #[ 5 6 7 8 1 2 3 4 ]" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self width: 8. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//8; width: 4. + blt sourceX: 0; destX: 4; copyBits. "Exchange words 0 and 1" + blt sourceX: 4; destX: 0; copyBits. + blt sourceX: 0; destX: 4; copyBits.! Item was added: + ----- Method: RawBitsArray>>swap8pairs (in category 'private') ----- + swap8pairs + "Swap every pair of bytes + Example: #[ 1 2 3 4 5 6 ] copy swap8pairs => #[ 2 1 4 3 6 5 ]" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//4; width: 1. + blt sourceX: 0; destX: 1; copyBits. "Exchange bytes 0 and 1" + blt sourceX: 1; destX: 0; copyBits. + blt sourceX: 0; destX: 1; copyBits. + blt sourceX: 2; destX: 3; copyBits. "Exchange bytes 2 and 3" + blt sourceX: 3; destX: 2; copyBits. + blt sourceX: 2; destX: 3; copyBits. + self byteSize\\4 >= 2 + ifTrue: + ["The lines in a From must fit on a Word boundary. + Handle the excess bytes" + | n tmp | + n := self byteSize // 4 * 4. + tmp := self byteAt: n + 1. + self byteAt: n + 1 put: (self byteAt: n + 2). + self byteAt: n + 2 put: tmp.]! Item was added: + ----- Method: RawBitsArray>>swapDoubleBytes (in category 'private') ----- + swapDoubleBytes + "Perform a bigEndian/littleEndian byte reversal of my double bytes. + Assume that our byte size is a multiple of souble byte size (2) + If it's not the case, trailing bytes would be left unchanged" + + self swap8pairs! Item was added: + ----- Method: RawBitsArray>>swapDoubleWords (in category 'private') ----- + swapDoubleWords + "Perform a bigEndian/littleEndian byte reversal of my double words. + Assume that our byte size is a multiple of double word size (8) + If it's not the case, 4 trailing bytes might be altered" + + self swap32pairs. "#[1 2 3 4 5 6 7 8] copy swap32pairs => #[5 6 7 8 1 2 3 4]" + self swapWords "#[5 6 7 8 1 2 3 4] copy swapWords => #[8 7 6 5 4 3 2 1]"! Item was added: + ----- Method: RawBitsArray>>swapWords (in category 'private') ----- + swapWords + "Perform a bigEndian/littleEndian byte reversal of my words. + Assume that our byte size is a multiple of word size (4) + If it's not the case, trailing bytes will remain unchanged" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//4; width: 1. + blt sourceX: 0; destX: 3; copyBits. "Exchange bytes 0 and 3" + blt sourceX: 3; destX: 0; copyBits. + blt sourceX: 0; destX: 3; copyBits. + blt sourceX: 2; destX: 1; copyBits. "Exchange bytes 1 and 2" + blt sourceX: 1; destX: 2; copyBits. + blt sourceX: 2; destX: 1; copyBits.!

1 0

The Trunk: Collections-nice.1059.mcz
by commits＠source.squeak.org 27 Feb '24

27 Feb '24

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.1059.mcz ==================== Summary ==================== Name: Collections-nice.1059 Author: nice Time: 8 February 2024, 12:57:43.861987 am UUID: a61087ae-f9ac-4e43-89d1-837d3edb7493 Ancestors: Collections-mt.1058 Provide the ability to reverse the endianness of a RawBitsArray. Spur platforms are all little-endian so far, so this is for the case when we would want to exchange such an array in a big-endian format. Example: | w | w := WordArray with: 16r01020304. w reverseEndianness. w first hex Also provide the ability to access the underlying bytes of any collection of raw bits thru byteAt: and byteAt:put:, whatever the number of bytesPerBasicElement. Examples: | w b | w := WordArray with: 16r01020304. b := w copy changeClassTo: ByteArray. 1 to: 4 do: [:index | self assert: (w byteAt: index) = (b byteAt: index)]. | w b | w := WordArray with: 16r01020304. b := w copy changeClassTo: ByteArray. w byteAt: 3 put: 5. b byteAt: 3 put: 5. {w first hex. b} This might be usefull for low level operations, like simulating a VM for example. =============== Diff against Collections-mt.1058 =============== Item was added: + ----- Method: RawBitsArray>>byteAt: (in category 'accessing') ----- + byteAt: anIndex + "Access a byte of the receiver, considered as a raw sequence of bytes. + This is a memory efficient implementation of: + ((self copy changeClassTo: ByteArray) at: anIndex)" + | int mask stride index shift | + self class isBytes + ifTrue: [^ self basicAt: anIndex]. + mask := 16rFF. + stride := self bytesPerBasicElement. + index := anIndex - 1 // stride + 1. + shift := anIndex - 1 \\ stride * -8. + Smalltalk isLittleEndian ifFalse: [shift := stride - 1 * 8 - shift]. + int := self basicAt: index. + int := int bitShift: shift. + int := int bitAnd: mask. + ^int! Item was added: + ----- Method: RawBitsArray>>byteAt:put: (in category 'accessing') ----- + byteAt: anIndex put: aByte + "Modify a byte of the receiver, considered as a raw sequence of bytes. + This is a less scary implementation than: + ([:class | ((self changeClassTo: ByteArray) at: anIndex put: aByte) changeClassTo: class] value: self class)" + | int stride index shift mask | + self class isBytes + ifTrue: [^ self basicAt: anIndex put: aByte]. + mask := 16rFF. + stride := self bytesPerBasicElement. + index := anIndex - 1 // stride + 1. + shift := anIndex - 1 \\ stride * 8. + Smalltalk isLittleEndian ifFalse: [shift := stride - 1 * 8 - shift]. + int := self basicAt: index. + int := int bitClear: (mask bitShift: shift). + int := int bitOr: (aByte bitShift: shift). + self basicAt: index put: int. + ^aByte! Item was added: + ----- Method: RawBitsArray>>reverseEndianness (in category 'converting') ----- + reverseEndianness + "reverse the endianness for each element" + + self class isBytes ifTrue: [^self]. + self class isWords ifTrue: [^self swapWords]. + self class isLongs ifTrue: [^self swapDoubleWords]. + self class isShorts ifTrue: [^self swapDoubleBytes]. + self error: 'this is not a collection of 1,2,4 or 8 bytes elements'! Item was added: + ----- Method: RawBitsArray>>swap16pairs (in category 'private') ----- + swap16pairs + "Swap every pair of double-bytes + Example: #[ 1 2 3 4 5 6 7 8 ] copy swap16pairs => #[ 3 4 1 2 7 8 5 6] + Implementation notes: this is the same as swapHalves, except that swapHalves only work for WordArray" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//4; width: 2. + blt sourceX: 0; destX: 2; copyBits. "Exchange double-bytes 0 and 1" + blt sourceX: 2; destX: 0; copyBits. + blt sourceX: 0; destX: 2; copyBits.! Item was added: + ----- Method: RawBitsArray>>swap32pairs (in category 'private') ----- + swap32pairs + "Swap every pair of words + Example: #[ 1 2 3 4 5 6 7 8 ] copy swap32pairs => #[ 5 6 7 8 1 2 3 4 ]" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self width: 8. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//8; width: 4. + blt sourceX: 0; destX: 4; copyBits. "Exchange words 0 and 1" + blt sourceX: 4; destX: 0; copyBits. + blt sourceX: 0; destX: 4; copyBits.! Item was added: + ----- Method: RawBitsArray>>swap8pairs (in category 'private') ----- + swap8pairs + "Swap every pair of bytes + Example: #[ 1 2 3 4 5 6 ] copy swap8pairs => #[ 2 1 4 3 6 5 ]" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//4; width: 1. + blt sourceX: 0; destX: 1; copyBits. "Exchange bytes 0 and 1" + blt sourceX: 1; destX: 0; copyBits. + blt sourceX: 0; destX: 1; copyBits. + blt sourceX: 2; destX: 3; copyBits. "Exchange bytes 2 and 3" + blt sourceX: 3; destX: 2; copyBits. + blt sourceX: 2; destX: 3; copyBits. + self byteSize\\4 >= 2 + ifTrue: + ["The lines in a From must fit on a Word boundary. + Handle the excess bytes" + | n tmp | + n := self byteSize // 4 * 4. + tmp := self byteAt: n + 1. + self byteAt: n + 1 put: (self byteAt: n + 2). + self byteAt: n + 2 put: tmp.]! Item was added: + ----- Method: RawBitsArray>>swapDoubleBytes (in category 'private') ----- + swapDoubleBytes + "Perform a bigEndian/littleEndian byte reversal of my double bytes. + Assume that our byte size is a multiple of souble byte size (2) + If it's not the case, trailing bytes would be left unchanged" + + self swap8pairs! Item was added: + ----- Method: RawBitsArray>>swapDoubleWords (in category 'private') ----- + swapDoubleWords + "Perform a bigEndian/littleEndian byte reversal of my double words. + Assume that our byte size is a multiple of double word size (8) + If it's not the case, 4 trailing bytes might be altered" + + self swap32pairs. "#[1 2 3 4 5 6 7 8] copy swap32pairs => #[5 6 7 8 1 2 3 4]" + self swapWords "#[5 6 7 8 1 2 3 4] copy swapWords => #[8 7 6 5 4 3 2 1]"! Item was added: + ----- Method: RawBitsArray>>swapWords (in category 'private') ----- + swapWords + "Perform a bigEndian/littleEndian byte reversal of my words. + Assume that our byte size is a multiple of word size (4) + If it's not the case, trailing bytes will remain unchanged" + + | hack blt | + "The implementation is a hack, but fast for large ranges" + hack := Form new hackBits: self. + blt := (BitBlt toForm: hack) sourceForm: hack. + blt combinationRule: Form reverse. "XOR" + blt sourceY: 0; destY: 0; height: self byteSize//4; width: 1. + blt sourceX: 0; destX: 3; copyBits. "Exchange bytes 0 and 3" + blt sourceX: 3; destX: 0; copyBits. + blt sourceX: 0; destX: 3; copyBits. + blt sourceX: 2; destX: 1; copyBits. "Exchange bytes 1 and 2" + blt sourceX: 1; destX: 2; copyBits. + blt sourceX: 2; destX: 1; copyBits.!

1 0

The Trunk: Graphics-nice.551.mcz
by commits＠source.squeak.org 27 Feb '24

27 Feb '24

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.551.mcz ==================== Summary ==================== Name: Graphics-nice.551 Author: nice Time: 27 February 2024, 11:04:54.187486 pm UUID: 6687a9e4-2fa7-4981-8548-fa272b631eda Ancestors: Graphics-mt.550, Graphics-nice.550 Merge Graphics-mt.550 & Graphics-nice.550 =============== Diff against Graphics-mt.550 =============== Item was added: + ----- Method: Form>>hackBits:width: (in category 'private') ----- + hackBits: bitThing width: anInteger + "This method provides an initialization so that BitBlt may be used, eg, to + copy ByteArrays and other non-pointer objects efficiently. + The resulting form looks anInteger wide, 8 bits deep, and height is adjusted to fit the bitThing size. + anInteger shall be a multiple of 4, because lines in a Form always fall on a Word boundary. + If not, some dead bytes will remain unaccessible to the BitBlt operations on each line. + That's also the case of trailing excess bytes" + width := anInteger. + depth := 8. + bitThing class isBits ifFalse: [self error: 'bitThing must be a non-pointer object']. + height := bitThing basicSize * bitThing bytesPerBasicElement // (width + 3 // 4 * 4). + bits := bitThing!

1 0

The Trunk: Graphics-nice.550.mcz
by commits＠source.squeak.org 27 Feb '24

27 Feb '24

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.550.mcz ==================== Summary ==================== Name: Graphics-nice.550 Author: nice Time: 7 February 2024, 11:08:47.366987 pm UUID: 9a845f0a-b60c-a740-93f9-d705b5b9b840 Ancestors: Graphics-mt.549 Provide a new Form hack of arbitrary width for bulk transfer of bytes. This may be used for example for reversing the endianness of a DoubleWordArray. =============== Diff against Graphics-mt.549 =============== Item was added: + ----- Method: Form>>hackBits:width: (in category 'private') ----- + hackBits: bitThing width: anInteger + "This method provides an initialization so that BitBlt may be used, eg, to + copy ByteArrays and other non-pointer objects efficiently. + The resulting form looks anInteger wide, 8 bits deep, and height is adjusted to fit the bitThing size. + anInteger shall be a multiple of 4, because lines in a Form always fall on a Word boundary. + If not, some dead bytes will remain unaccessible to the BitBlt operations on each line. + That's also the case of trailing excess bytes" + width := anInteger. + depth := 8. + bitThing class isBits ifFalse: [self error: 'bitThing must be a non-pointer object']. + height := bitThing basicSize * bitThing bytesPerBasicElement // (width + 3 // 4 * 4). + bits := bitThing!

1 0

The Trunk: KernelTests-ct.455.mcz
by commits＠source.squeak.org 27 Feb '24

27 Feb '24

Christoph Thiede uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ct.455.mcz ==================== Summary ==================== Name: KernelTests-ct.455 Author: ct Time: 27 February 2024, 9:52:34.84305 pm UUID: f7671116-2057-d648-983a-a3754b1f80e1 Ancestors: KernelTests-ct.454 Fixes further slips in primitive simulation tests (silent temporary method dict changes, fix comment, add missing array brackets). =============== Diff against KernelTests-ct.454 =============== Item was changed: ----- Method: ContextTest>>testPrimitive118: (in category 'tests - simulation') ----- testPrimitive118: primitiveBlock | input1 input2 | { {#isNil. 62. {}}. "valid 0-arg primitive" {6. 9. {7}}. "valid unary primitive" {6. 62. {7}}. "failing primitive" {6. 'not a primitive'. {7}}. "invalid primitive" {6. 9. 'not an array'}. "invalid arguments" {#isNil. 62. {1}}. "too many arguments" {6. 9. {}}. "missing argument" {6. 83. {#=. 6.0}}. "primitivePerform" {6. 83. {#isNil. 'excess arg'}}. "primitivePerform - too many arguments" {6. 84. {#=. {6.0}}}. "primitivePerformWithArgs" {6. 84. {#isNil. 'excess arg'}}. "primitivePerformWithArgs - invalid arguments" + {6. 100. {#=. {6.0}. Object}}. "primitivePerformInSuperclass" - {6. 100. {#=. 6.0. Object}}. "primitivePerformInSuperclass" {6. 100. {#isNil. {'excess arg'}. Object}}. "primitivePerformInSuperclass - too many arguments" {6. 118. {9. {7}}}. "primitiveDoPrimitiveWithArgs" {6. 118. {9. {7. 13}}}. "primitiveDoPrimitiveWithArgs - superfluous arguments" {6. 118. {118. {9. {7}}}}. "primitiveDoPrimitiveWithArgs - nested invocation" {thisContext. 218. {Float32Array >> #sum. Float32Array withAll: {2.0. 3.0}. {}}}. "primitiveDoNamedPrimitiveWithArgs" {thisContext. 218. {Float32Array >> #sum. Float32Array withAll: {2.0. 3.0}. {4.0}}}. "primitiveDoNamedPrimitiveWithArgs - superfluous arguments" } do: [:args | | block | block := [primitiveBlock valueWithArguments: args]. self assert: block value equals: (Context runSimulated: block)]. self assert: (primitiveBlock value: (input1 := {1. 2. 3}) value: 61 value: {2. 4}) equals: (Context runSimulated: [primitiveBlock value: (input2 := {1. 2. 3}) value: 61 value: {2. 4}]); assert: input1 equals: input2.! Item was changed: ----- Method: ContextTest>>testPrimitive189 (in category 'tests - simulation') ----- testPrimitive189 + "Test simulation of primitive 189." - "Test simulation of primitive 118." { [2 executeMethod: SmallInteger >> #even]. "valid 0-arg message" [2 with: 1 executeMethod: Integer >> #<<]. "valid unary message" [2 with: 3 with: 4 executeMethod: Integer >> #raisedTo:modulo:]. "valid binary message" [2 with: 1 executeMethod: Integer >> #even]. "too many arguments" [2 executeMethod: Integer >> #<<]. "missing argument" [2 with: 1 executeMethod: 'not a method']. "invalid method" [(2 with: 3 with: 4 executeMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod)) allButFirst "OaM selector is undefined behavior"] "object as method" } do: [:block | self assert: (block on: Error do: [:ex | ex description]) equals: (Context runSimulated: [block on: Error do: [:ex | ex description]])].! Item was changed: ----- Method: ContextTest>>testPrimitive83 (in category 'tests - simulation') ----- testPrimitive83 "Test simulation of primitive 83." self flag: #bug. "Known bug: Primitive 83 SPORADICALLY does NOT fail in the OSVM for missing argument!!" { [nil perform: #isNil]. "valid 0-arg message" [nil perform: #= with: true]. "valid unary message" [nil perform: #ifNil:ifNotNil: with: [2] with: [:x | x]]. "valid binary message" [nil perform: #isNil with: 'excess arg']. "too many arguments" [nil perform: #=]. "missing argument" [nil perform: Object]. "invalid selector" [[(self class + addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod); - addSelector: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod); perform: #plonk:with: with: 2 with: 3) allButFirst "OaM selector is undefined behavior"] + ensure: [self class removeSelectorSilently: #plonk:with:]]. - ensure: [self class removeSelector: #plonk:with:]]. } do: [:block | self assert: (block on: Error do: [:ex | ex description]) equals: (Context runSimulated: [block on: Error do: [:ex | ex description]])].! Item was changed: ----- Method: ContextTest>>testPrimitive84 (in category 'tests - simulation') ----- testPrimitive84 "Test simulation of primitive 84." { {#isNil. {}}. "valid 0-arg message" {#=. {true}}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}}. "valid binary message" {#isNil. 'not an array'}. "invalid arguments" {#isNil. {'excess arg'}}. "too many arguments" {#=. {}}. "missing argument" {Object. {}}. "invalid selector" {#in:. {[:it | [(self class + addSelectorSilently: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod); - addSelector: #plonk:with: withMethod: (TestObjectForMethod new xxxMethod: thisContext homeMethod); perform: #plonk:with: withArguments: #(2 3)) allButFirst "OaM selector is undefined behavior"] + ensure: [self class removeSelectorSilently: #plonk:with:]]}}. - ensure: [self class removeSelector: #plonk:with:]]}}. } do: [:args | self assert: ([nil perform: args first withArguments: args second] on: Error do: [:ex | ex description]) equals: (Context runSimulated: [[nil perform: args first withArguments: args second] on: Error do: [:ex | ex description]])].!

1 0

The Inbox: Kernel-ct.1385.mcz
by commits＠source.squeak.org 27 Feb '24

27 Feb '24

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1385.mcz ==================== Summary ==================== Name: Kernel-ct.1385 Author: ct Time: 12 April 2021, 10:15:07.18369 pm UUID: e2817a6e-1a1f-e246-aa66-2fa9289a7703 Ancestors: Kernel-nice.1384 Improves multilingual support for basic errors on Object. =============== Diff against Kernel-nice.1384 =============== Item was changed: ----- Method: Object>>error (in category 'error handling') ----- error "Throw a generic Error exception." + ^ self error: 'Error!!' translated! - ^self error: 'Error!!'.! Item was changed: ----- Method: Object>>errorImproperStore (in category 'private') ----- errorImproperStore "Create an error notification that an improper store was attempted." + ^ self error: 'Improper store into indexable object' translated! - self error: 'Improper store into indexable object'! Item was changed: ----- Method: Object>>errorNonIntegerIndex (in category 'private') ----- errorNonIntegerIndex "Create an error notification that an improper object was used as an index." + ^ self error: 'Only integers should be used as indices' translated! - self error: 'only integers should be used as indices'! Item was changed: ----- Method: Object>>errorSubscriptBounds: (in category 'private') ----- errorSubscriptBounds: index "Create an error notification that an improper integer was used as an index." + ^ self error: ('Subscript is out of bounds: {1}' translated format: {index})! - self error: 'subscript is out of bounds: ' , index printString!

3 2

(no subject)
by Jaromir Matas 27 Feb '24

27 Feb '24

Hi all, I find quite convenient to see the state of a process right away in the Debugger/Inspector (or even Process Browser) rather than having to check it manually (p isBlocked ? etc). See the enclosed changeset and the screenshot - what do you think? Worth merging? best, Jaromir

3 2