Squeak-dev August 2023

squeak-dev@lists.squeakfoundation.org

30 participants
163 discussions

The Trunk: Morphic-mt.2121.mcz
by commits＠source.squeak.org 11 Aug '23

11 Aug '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2121.mcz ==================== Summary ==================== Name: Morphic-mt.2121 Author: mt Time: 11 August 2023, 12:43:21.630243 pm UUID: 74380a65-c494-2e44-b617-9491b2cbfde3 Ancestors: Morphic-mt.2120 Add scale-factor support for soft (and hard) shadows. Note that we might want to add a fast-path for hard shadows as those could be implemented with one or two simple #fillRectangle: calls and no cache. If translucent morph colors should not be supported anymore, this would even work for morphs with #roundedCorners... If memory is an issue, disable shadows via: Morph useSoftDropShadow: false. Preferences disable: #menuAppearance3d. =============== Diff against Morphic-mt.2120 =============== Item was changed: ----- Method: Morph>>drawDropShadowOn: (in category 'drawing') ----- drawDropShadowOn: aCanvas "Rectangular shadow with support for rounded corners." + | shadowOffset shadowBounds | + shadowBounds := (shadowOffset := self shadowOffsetDisplayScaled) isRectangle + ifTrue: [self bounds outsetBy: shadowOffset] + ifFalse: [self bounds translateBy: (shadowOffset negated max: 0@0)]. - | shadowBounds | - shadowBounds := self shadowOffset isRectangle - ifTrue: [self bounds outsetBy: self shadowOffset] - ifFalse: [self bounds translateBy: (self shadowOffset negated max: 0@0)]. "Only redraw the shadow if the shadow area is affected." + ((aCanvas clipRect intersects: shadowBounds) + and: [((self bounds insetBy: (self wantsRoundedCorners ifFalse: [0] ifTrue: [self cornerRadius])) containsRect: aCanvas clipRect) not]) + ifTrue: [ + (self hasProperty: #dropShadow) + ifFalse: [self updateDropShadowCache]. + aCanvas + translucentImage: (self valueOfProperty: #dropShadow) + at: shadowBounds topLeft].! - ((aCanvas clipRect intersects: shadowBounds) and: [((self bounds insetBy: (self wantsRoundedCorners ifFalse: [0] ifTrue: [self cornerRadius])) containsRect: aCanvas clipRect) not]) - ifTrue: [ - (self hasProperty: #dropShadow) - ifFalse: [self updateDropShadowCache]. - aCanvas - translucentImage: (self valueOfProperty: #dropShadow) - at: shadowBounds topLeft].! Item was changed: ----- Method: Morph>>expandFullBoundsForDropShadow: (in category 'drawing') ----- expandFullBoundsForDropShadow: aRectangle "Return an expanded rectangle for an eventual drop shadow" - | delta box | + | shadowOffset delta box | + (shadowOffset := self shadowOffsetDisplayScaled) isRectangle + ifTrue: [^ aRectangle outsetBy: shadowOffset]. - self shadowOffset isRectangle - ifTrue: [^ aRectangle outsetBy: self shadowOffset]. box := aRectangle. + delta := shadowOffset. - delta := self shadowOffset. box := delta x >= 0 ifTrue:[box right: aRectangle right + delta x] ifFalse:[box left: aRectangle left + delta x]. box := delta y >= 0 ifTrue:[box bottom: aRectangle bottom + delta y] ifFalse:[box top: aRectangle top + delta y]. ^box! Item was added: + ----- Method: Morph>>shadowOffsetDisplayScaled (in category 'drop shadows') ----- + shadowOffsetDisplayScaled + + | scale shadowOffset | + scale := RealEstateAgent scaleFactor. + ^ (shadowOffset := self shadowOffset) isRectangle + ifTrue: [(shadowOffset topLeft * scale) truncated corner: (shadowOffset bottomRight * scale) truncated] + ifFalse: [(shadowOffset * scale) truncated]! Item was changed: ----- Method: Morph>>updateDropShadowCache (in category 'drawing') ----- updateDropShadowCache "Draws the receiver's drop shadow into a separate form (or cache) to be used repeatedly in #drawDropShadowOn:, which is itself guarded via #hasDropShadow (see #fullDrawOn:). Note that this cache is not so much about performance as it is about visual aesthetics. While the shadow itself is just one or more repeated calls to fill/frame a (rounded rectangle), we finally cut out (or mask or erase) the inner portion so that translucent receiver's wont look awkward. This is not possible with direct drawing calls to BitBlt onto Display. Also note that with the advent of the Spur object memory (http://www.mirandabanda.org/cogblog/category/spur/) in the OpenSmalltalk VM, we got a different garbage collector (GC) that does not yet have the most efficient incremental collection strategies. As an effect, repeated invalidation of the drop-shadow cache now entails frequent full-GC pauses and thus noticeable lags (or stuttering) in the environment. This has been the case since the release of Squeak 5.0, where we started to use the Spur object memory and hence the new GC. To make the full-GC pauses less noticeable, we started to temporarily disable the drop shadow in situations where responsiveness is importent. For example, we do this for frequently used morphs such as all system windows when being resized using their corner (or edge) grips. You can get an overview of thus points by browsing senders of #targetHadDropShadow and #hasDropShadow: (or actually the code 'hasDropShadow: false', which typically starts the temporary disabling of the shadow). + February 2022: We are currently working on improving the incremental compaction in the OpenSmalltalk VM. Once that issue has been solved, we can remove that source code that disables the drop shadow temporarily. + + March 2023: We might want to #hibernate unused shadows. Also, #scaleFactor support was added." - February 2022: We are currently working on improving the incremental compaction in the OpenSmalltalk VM. Once that issue has been solved, we can remove that source code that disables the drop shadow temporarily." + | shadowOffset shadowBounds shadowColor shadowRadius offset form canvas drawBlock localBounds mask maskCanvas | - | shadowOffset shadowBounds offset form canvas drawBlock localBounds mask maskCanvas | self flag: #hasDropShadow. "Marker for senders browsing." self flag: #targetHadDropShadow. "Marker for senders browsing." + (shadowOffset := self shadowOffsetDisplayScaled) isRectangle - (shadowOffset := self shadowOffset) isRectangle ifTrue: [ shadowBounds := 0@0 corner: (self bounds outsetBy: shadowOffset) extent. offset := 0@0. localBounds := shadowOffset topLeft extent: self extent ] ifFalse: [ | extent | extent := self extent. shadowBounds := 0@0 corner: extent + shadowOffset abs. offset := shadowOffset max: 0@0. localBounds := (shadowOffset negated max: 0@0) extent: extent ]. form := Form extent: shadowBounds extent depth: Display depth. canvas := form getCanvas. + shadowColor := self shadowColor. + shadowRadius := self wantsRoundedCorners ifTrue: [self cornerRadius max: 20 px] ifFalse: [20 px]. drawBlock := self useSoftDropShadow + ifFalse: [self wantsRoundedCorners + ifTrue: [ [:c | c fillRoundRect: localBounds radius: shadowRadius fillStyle: shadowColor] ] + ifFalse: [ [:c | c fillRectangle: localBounds fillStyle: shadowColor] ]] - ifFalse: [ - [:c | self wantsRoundedCorners - ifTrue: [c fillRoundRect: localBounds radius: self cornerRadius fillStyle: self shadowColor] - ifFalse: [c fillRectangle: localBounds fillStyle: self shadowColor]]] ifTrue: [ + [:c | | a ad o od r rd | + a := shadowColor alpha. + ad := a. + o := -1. + od := RealEstateAgent scaleFactor. + r := shadowRadius. + rd := od. + 10 timesRepeat: [ | offsetHere alphaHere radiusHere | + offsetHere := (o := + o + od) truncated. + alphaHere := (a := a + ad). + radiusHere := (r := r - rd) truncated. + c + fillRoundRect: (shadowBounds insetBy: offsetHere) + radius: radiusHere + fillStyle: (shadowColor alpha: alphaHere)]] ]. - [:c | self wantsRoundedCorners - ifTrue: [0 to: 9 do: [:i | - c - fillRoundRect: (shadowBounds insetBy: i) - radius: (self cornerRadius max: 20) -i - fillStyle: (self shadowColor alpha: self shadowColor alpha * (i+1))]] - ifFalse: [0 to: 9 do: [:i | - c - fillRoundRect: (shadowBounds insetBy: i) radius: 20-i - fillStyle: (self shadowColor alpha: self shadowColor alpha * (i+1))]]]]. canvas translateBy: offset during: [ :shadowCanvas | drawBlock value: shadowCanvas]. "Support transparent morph colors without having the shadow to shine through.." mask := Form extent: shadowBounds extent depth: Display depth. maskCanvas := mask getCanvas. self wantsRoundedCorners ifTrue: [maskCanvas fillRoundRect: (localBounds insetBy: self borderWidth) radius: self cornerRadius fillStyle: Color black] ifFalse: [maskCanvas fillRectangle: (localBounds insetBy: self borderWidth) fillStyle: Color black]. mask displayOn: form at: 0@0 rule: Form erase. self setProperty: #dropShadow toValue: form.!

1 0

The Trunk: System-mt.1421.mcz
by commits＠source.squeak.org 11 Aug '23

11 Aug '23

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1421.mcz ==================== Summary ==================== Name: System-mt.1421 Author: mt Time: 11 August 2023, 12:37:11.021243 pm UUID: d0effb9a-4bd4-ba49-91b6-ec52e8ab437d Ancestors: System-mt.1420 ... I forgot to commit the postscript ... =============== Diff against System-mt.1420 =============== Item was changed: + (PackageInfo named: 'System') postscript: 'Smalltalk installLowSpaceWatcher.'! - (PackageInfo named: 'System') postscript: 'ExtendedClipboardWinInterface initialize..'!

1 0

large space cost associated with drop shadows
by Eliot Miranda 11 Aug '23

11 Aug '23

Hi All, in looking into the low space issue raised by Vanessa in recent days I ran the space analysis in a normal trunk image of mine which has a few open windows. The largest consumption was in Bitmap instances and when I looked at (Bitmap allInstances select: [:bm| bm size >= 1000000]) and chased pointers all but the DIsplay's bitmap itself was a window's drop shadow. e.g. PluggableSystemWindow allInstances collect: [:psw| (psw extension valueOfProperty: #dropShadow) ifNotNil: [:form|form bits size]]. #(716095 nil 1662221 nil nil 1050354 nil nil nil 1479114 776912 241081 241148 241081 241081 352242 241081 716896 1478728) Seems to me some variation on InfiniteForm could save a *lot* of memory: (((PluggableSystemWindow allInstances collect: [:psw| (psw extension valueOfProperty: #dropShadow) ifNotNil: [:form|form bits]]) select: [:bits| bits notNil]) collect: [:bits| bits byteSize]) sum 40,994,900 Even using an 8-bit bitmap would save 3/4 opf the space usage here. _,,,^..^,,,_ best, Eliot

4 8

[DOC REFRESH] HymnParrotTalk-v.3.9 documentation, hosted on GitBook
by Stumpy Rabbit 10 Aug '23

10 Aug '23

I finally made some time for Squeak, as all my other projects are moving forwards, coasting. I took the time to translate some of what I have written into the Hymn documentation. All advice welcome. > https://projects.callistohouse.org/parrottalk/ ••• stumpy rabbit ❤️‍🔥🐰 >

1 0

The Trunk: System-mt.1420.mcz
by commits＠source.squeak.org 10 Aug '23

10 Aug '23

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1420.mcz ==================== Summary ==================== Name: System-mt.1420 Author: mt Time: 10 August 2023, 10:29:48.325968 am UUID: b9808160-125f-0241-9b23-b20b33273bf2 Ancestors: System-mt.1419 For low-space warnings, make preference #logDebuggerStackToFile work again. =============== Diff against System-mt.1419 =============== Item was changed: ----- Method: SmalltalkImage>>lowSpaceWatcher (in category 'memory space') ----- lowSpaceWatcher "Wait until the low space semaphore is signalled, then take appropriate actions." | free preemptedProcess | self garbageCollectMost <= self lowSpaceThreshold ifTrue: [self garbageCollect <= self lowSpaceThreshold ifTrue: ["free space must be above threshold before starting low space watcher" ^ Beeper beep]]. Smalltalk specialObjectsArray at: 23 put: nil. "process causing low space will be saved here" LowSpaceSemaphore := Semaphore new. self primLowSpaceSemaphore: LowSpaceSemaphore. self primSignalAtBytesLeft: self lowSpaceThreshold. "enable low space interrupts" LowSpaceSemaphore wait. "wait for a low space condition..." self primSignalAtBytesLeft: 0. "disable low space interrupts" self primLowSpaceSemaphore: nil. LowSpaceProcess := nil. "The process that was active at the time of the low space interrupt." + preemptedProcess := (Smalltalk specialObjectsArray at: 23) + ifNil: [Processor preemptedProcess "if in-image signal of OutOfMemory"]. - preemptedProcess := Smalltalk specialObjectsArray at: 23. Smalltalk specialObjectsArray at: 23 put: nil. "Note: user now unprotected until the low space watcher is re-installed" self memoryHogs isEmpty ifFalse: [free := self bytesLeft. self memoryHogs do: [ :hog | hog freeSomeSpace ]. self bytesLeft > free ifTrue: [ ^ self installLowSpaceWatcher ]]. Preferences logDebuggerStackToFile ifTrue: [ self logError: 'Space is low' inContext: preemptedProcess suspendedContext to: 'LowSpaceDebug.log']. Project current interruptName: 'Space is low' message: self lowSpaceChoices preemptedProcess: preemptedProcess !

1 0

The Trunk: Collections-mt.1048.mcz
by commits＠source.squeak.org 10 Aug '23

10 Aug '23

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.1048.mcz ==================== Summary ==================== Name: Collections-mt.1048 Author: mt Time: 2 August 2023, 10:47:45.179314 am UUID: 87f828cf-6d3f-414e-82b7-a53244f9d19c Ancestors: Collections-dtl.1047 Makes #withoutDuplicates available to more kinds of collections. Offer #copyWithoutDuplicates as an alias matching the more explicit #copyWithout* protocol as we are always creating copies, even if the receiver does not contain any duplicates. Do not allow duplicate removal for Bitset, CharacterSet, Heap, Matrix. =============== Diff against Collections-dtl.1047 =============== Item was added: + ----- Method: Bag>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + "Overwritten for better performance. We already know about the unique items in the receiver." + + ^ self species basicNew + setContents: (contents collect: [:count | 1]); + yourself! Item was added: + ----- Method: Bitset>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + + self shouldNotImplement.! Item was added: + ----- Method: CharacterSet>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + + self shouldNotImplement.! Item was added: + ----- Method: Collection>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + "Convenience for the original #withoutDuplicates matching the copy-without protocol." + + ^ self withoutDuplicates! Item was added: + ----- Method: Collection>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + "Answer a copy of the receiver that preserves order but eliminates any duplicates." + + | seen | + seen := Set new: self size. + ^ self select: [:each | seen ifAbsentAdd: each]! Item was added: + ----- Method: Heap>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + + self shouldNotImplement.! Item was added: + ----- Method: Matrix>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + + self shouldNotImplement.! Item was removed: - ----- Method: SequenceableCollection>>withoutDuplicates (in category 'copying') ----- - withoutDuplicates - "Answer a copy of the receiver that preserves order but eliminates any duplicates." - | seen | - seen := Set new: self size. - ^self select: [:each| seen ifAbsentAdd: each]! Item was added: + ----- Method: Set>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + "Overwritten for better performance. We already know about the unique items in the receiver." + + ^ self copy!

1 0

The Trunk: System-mt.1419.mcz
by commits＠source.squeak.org 10 Aug '23

10 Aug '23

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1419.mcz ==================== Summary ==================== Name: System-mt.1419 Author: mt Time: 10 August 2023, 10:00:12.66062 am UUID: f31524e9-118a-6241-bdf7-71b8ff3a7e30 Ancestors: System-dtl.1418 Complements Collections-mt.1049 =============== Diff against System-dtl.1418 =============== Item was added: + ----- Method: WeakRegistry>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + + self shouldNotImplement.!

1 0

The Trunk: Kernel-mt.1519.mcz
by commits＠source.squeak.org 10 Aug '23

10 Aug '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1519.mcz ==================== Summary ==================== Name: Kernel-mt.1519 Author: mt Time: 10 August 2023, 9:59:32.01762 am UUID: b33a4757-113b-6542-b28f-08991dd78522 Ancestors: Kernel-mt.1518 Complements Collections-mt.1049 =============== Diff against Kernel-mt.1518 =============== Item was added: + ----- Method: DependentsArray>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + + self shouldNotImplement.!

1 0

The Trunk: CollectionsTests-mt.399.mcz
by commits＠source.squeak.org 10 Aug '23

10 Aug '23

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-mt.399.mcz ==================== Summary ==================== Name: CollectionsTests-mt.399 Author: mt Time: 10 August 2023, 9:59:07.68462 am UUID: ad413358-1194-fc41-b9f4-277c27e50588 Ancestors: CollectionsTests-ct.398 Tests for Collections-mt.1049 =============== Diff against CollectionsTests-ct.398 =============== Item was added: + ----- Method: BagTest>>testWithoutDuplicates (in category 'tests') ----- + testWithoutDuplicates + + | in out | + in := Bag new + addAll: #(1 3 5 7 9 1 3 5 7 9 2 4 6 8 10 2 4 6 8 10); + yourself. + out := Bag new + addAll: #(1 3 5 7 9 2 4 6 8 10); + yourself. + self assert: out equals: in withoutDuplicates.! Item was added: + ----- Method: DictionaryTest>>testWithoutDuplicateValues (in category 'tests') ----- + testWithoutDuplicateValues + + | in | + in := Dictionary withAll: {#a->1 . #b->3 . #c->5 . #d->7 . #e->9 . #f->1 . #g->3 . #h->5 . #i->7 . #j->9 . #k->2 . #l->4 . #m->6 . #n->8 . #o->10 . #p->2 . #q->4 . #r->6 . #s->8 . #t->10}. + self "ignore which keys where dropped" + assert: #(1 2 3 4 5 6 7 8 9 10) + equals: in withoutDuplicateValues values sorted.! Item was added: + ----- Method: DictionaryTest>>testWithoutDuplicates (in category 'tests') ----- + testWithoutDuplicates + + | in | + in := Dictionary withAll: {#a->1 . #b->3 . #c->5 . #d->7 . #e->9 . #f->1 . #g->3 . #h->5 . #i->7 . #j->9 . #k->2 . #l->4 . #m->6 . #n->8 . #o->10 . #p->2 . #q->4 . #r->6 . #s->8 . #t->10}. + + self assert: in equals: in withoutDuplicates. + self assert: in identical: in withoutDuplicates. + + self assert: in equals: in copyWithoutDuplicates. + self deny: in identical: in copyWithoutDuplicates.! Item was added: + ----- Method: OrderedDictionaryTest>>testWithoutDuplicateValues (in category 'tests - copying') ----- + testWithoutDuplicateValues + + | in out | + in := OrderedDictionary withAll: {#a->1 . #b->3 . #c->5 . #d->7 . #e->9 . #f->1 . #g->3 . #h->5 . #i->7 . #j->9 . #k->2 . #l->4 . #m->6 . #n->8 . #o->10 . #p->2 . #q->4 . #r->6 . #s->8 . #t->10}. + out := OrderedDictionary withAll: {#a->1 . #b->3 . #c->5 . #d->7 . #e->9 . #k->2 . #l->4 . #m->6 . #n->8 . #o->10}. + self assert: out equals: in withoutDuplicateValues.! Item was added: + ----- Method: OrderedDictionaryTest>>testWithoutDuplicates (in category 'tests - copying') ----- + testWithoutDuplicates + + | in | + in := OrderedDictionary withAll: {#a->1 . #b->3 . #c->5 . #d->7 . #e->9 . #f->1 . #g->3 . #h->5 . #i->7 . #j->9 . #k->2 . #l->4 . #m->6 . #n->8 . #o->10 . #p->2 . #q->4 . #r->6 . #s->8 . #t->10}. + + self assert: in equals: in withoutDuplicates. + self assert: in identical: in withoutDuplicates. + + self assert: in equals: in copyWithoutDuplicates. + self deny: in identical: in copyWithoutDuplicates.! Item was added: + ----- Method: SetTest>>testWithoutDuplicates (in category 'tests') ----- + testWithoutDuplicates + + | in out | + in := Set new + addAll: #(1 3 5 7 9 1 3 5 7 9 2 4 6 8 10 2 4 6 8 10); + yourself. + out := Set new + addAll: #(1 3 5 7 9 2 4 6 8 10); + yourself. + + self assert: out equals: in withoutDuplicates. + self assert: in equals: in withoutDuplicates. + self assert: in equals: in copyWithoutDuplicates. + + self assert: in identical: in withoutDuplicates. + self deny: in identical: in copyWithoutDuplicates. !

1 0

The Trunk: Collections-mt.1049.mcz
by commits＠source.squeak.org 10 Aug '23

10 Aug '23

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.1049.mcz ==================== Summary ==================== Name: Collections-mt.1049 Author: mt Time: 10 August 2023, 9:58:43.81662 am UUID: 7a94c086-e179-1148-899a-139ecbc19f5b Ancestors: Collections-mt.1048 Make #withoutDuplicates available to more kinds of collections. Thanks to Christoph (ct) for the idea. Here is the discussion: http://lists.squeakfoundation.org/archives/list/squeak-dev@lists.squeakfoun… =============== Diff against Collections-dtl.1047 =============== Item was added: + ----- Method: Bag>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + "Overwritten for better performance. We already know about the unique items in the receiver." + + ^ self species basicNew + setContents: (contents collect: [:count | 1]); + yourself! Item was added: + ----- Method: Bitset>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + + self shouldNotImplement.! Item was added: + ----- Method: CharacterSet>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + + self shouldNotImplement.! Item was added: + ----- Method: Collection>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + "Answer a copy of the receiver that preserves order, if any, but eliminates any duplicates." + + | seen | + seen := Set new: self size. + ^ self select: [:each | seen ifAbsentAdd: each]! Item was added: + ----- Method: Collection>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + "Answer a variant of the receiver that has no duplicate elements. Might be the receiver itself if it already contains no duplicates. See subclass implementations. If you want to modify the result, use #copyWithoutDuplicates to make it explicit." + + ^ self copyWithoutDuplicates! Item was added: + ----- Method: Dictionary>>copyWithoutDuplicateValues (in category 'copying') ----- + copyWithoutDuplicateValues + + ^ super copyWithoutDuplicates! Item was added: + ----- Method: Dictionary>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + "Behaves like a set because keys are already unique. Note that if you want to remove duplicate values, use #values first, then #copyWithoutDuplicates. Or see #copyWithoutDuplicateValues." + + ^ self copy! Item was added: + ----- Method: Dictionary>>withoutDuplicateValues (in category 'copying') ----- + withoutDuplicateValues + + ^ self copyWithoutDuplicateValues! Item was added: + ----- Method: Dictionary>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + "Behaves like a set because keys are already unique. Note that if you want to remove duplicate values, use #values first, then #withoutDuplicates. Or see #withoutDuplicateValues." + + ^ self! Item was added: + ----- Method: Heap>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + + self shouldNotImplement.! Item was added: + ----- Method: Matrix>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + + self shouldNotImplement.! Item was removed: - ----- Method: SequenceableCollection>>withoutDuplicates (in category 'copying') ----- - withoutDuplicates - "Answer a copy of the receiver that preserves order but eliminates any duplicates." - | seen | - seen := Set new: self size. - ^self select: [:each| seen ifAbsentAdd: each]! Item was added: + ----- Method: Set>>copyWithoutDuplicates (in category 'copying') ----- + copyWithoutDuplicates + "Overwritten for better performance. We already know about the unique items in the receiver." + + ^ self copy! Item was added: + ----- Method: Set>>withoutDuplicates (in category 'copying') ----- + withoutDuplicates + "Overwritten for better performance. We already know about the unique items in the receiver." + + ^ self!

1 0

Jump to page: