Squeak-dev April 2023

squeak-dev@lists.squeakfoundation.org

17 participants
87 discussions

Review Request: mcSlips
by christoph.thiede＠student.hpi.uni-potsdam.de 21 May '23

21 May '23

Any fundamental objections before I would merge this into the Trunk? :-) =============== Summary =============== Change Set: mcSlips Date: 16 January 2022 Author: Christoph Thiede This changeset integrates the slip detection mechanism, previously only known from the domain of changesets, into the Monticello system. When users save a new version, it will automatically notify them about any possible slips and let them decide whether to browse them first or proceed the saving. Users can also scan their patch for slips manually by invocating the item from the patch list menu. The value of the preference #checkForSlips is still honored for the automatic detection, and the description of that preference is updated to mention the new usage. =============== Postscript =============== "Postscript:" (Preferences preferenceAt: #checkForSlips) helpString: 'If true, then whenever you file out a change set or save a Monticello version, it is checked for ''slips'' and if any are found, you are so informed and given a chance to open a browser on them.'. =============== Diff =============== CompiledMethod>>hasReportableSlip {testing} · ct 1/15/2022 22:32 (changed) hasReportableSlip "Answer whether the receiver contains anything that should be brought to the attention of the author when filing out. Customize the lists here to suit your preferences. If slips do not get reported in spite of your best efforts here, make certain that the Preference 'checkForSlips' is set to true." - #(#doOnlyOnce: #halt #halt: #hottest #printDirectlyToDisplay #toRemove #personal #urgent #haltOnce #haltOnce: #haltIf: ) + #(#doOnlyOnce: #halt #halt: #hottest #printDirectlyToDisplay #toRemove #personal #urgent #haltOnce #haltOnce: #haltIf: #haltIfNil #haltOnCount: #halt:onCount: #break ) do: [:aLit | (self hasLiteral: aLit) ifTrue: [^ true]]. #(#Transcript #AA #BB #CC #DD #EE ) do: [:aSymbol | | assoc | (assoc := Smalltalk globals associationAt: aSymbol ifAbsent: []) ifNotNil: [(self hasLiteral: assoc) ifTrue: [^ true]]]. ^ false MCChangeSelector>>select {actions} · ct 1/15/2022 22:46 (changed) select + + (Preferences checkForSlips ==> [self lookForSlips]) ifFalse: [^ self]. + self answer: (MCPatch operations: kept) MCDefinition>>hasReportableSlip {testing} · ct 1/15/2022 22:49 + hasReportableSlip + + ^ false MCMethodDefinition (changed) MCDefinition subclass: #MCMethodDefinition - instanceVariableNames: 'classIsMeta source category selector className timeStamp' + instanceVariableNames: 'classIsMeta source category selector className timeStamp hasReportableSlip' classVariableNames: '' poolDictionaries: '' category: 'Monticello-Modeling' MCMethodDefinition class instanceVariableNames: 'definitions' "" MCMethodDefinition class>>forMethodReference: {create} · ct 1/15/2022 22:53 (changed) forMethodReference: aMethodReference | definition | definition := self cachedDefinitions at: aMethodReference compiledMethod ifAbsent: []. (definition isNil or: [definition selector ~= aMethodReference methodSymbol or: [definition className ~= aMethodReference classSymbol or: [definition classIsMeta ~= aMethodReference classIsMeta or: [definition category ~= aMethodReference category]]]]) ifTrue: [definition := self className: aMethodReference classSymbol classIsMeta: aMethodReference classIsMeta selector: aMethodReference methodSymbol category: aMethodReference category timeStamp: aMethodReference timeStamp source: aMethodReference source. + definition hasReportableSlip: aMethodReference compiledMethod hasReportableSlip. self cachedDefinitions at: aMethodReference compiledMethod put: definition]. ^ definition MCMethodDefinition>>hasReportableSlip {accessing} · ct 1/15/2022 22:54 + hasReportableSlip + + ^ hasReportableSlip ifNil: [false] MCMethodDefinition>>hasReportableSlip: {accessing} · ct 1/15/2022 22:53 + hasReportableSlip: aBoolean + + hasReportableSlip := aBoolean. MCPatchBrowser>>checkForSlips {actions} · ct 1/15/2022 23:12 + checkForSlips + + ^ self checkForSlipsIn: self items MCPatchBrowser>>checkForSlipsIn: {actions} · ct 1/15/2022 23:07 + checkForSlipsIn: patchItems + + ^ patchItems select: [:ea | ea hasReportableSlip] MCPatchBrowser>>lookForSlips {actions} · ct 1/15/2022 23:11 + lookForSlips + "Look for slips in all changes. If there are any, ask the user how to treat them. Answer true if the operation should go on, or false if it should be canceled." + + | slips | + slips := self checkForSlips ifEmpty: [^ true]. + (Project uiManager + chooseFromLabeledValues: (OrderedDictionary new + at: 'Browse slips' translated put: [self systemNavigation + browseMessageList: (slips collect: [:ea | ea definition asMethodReference]) + name: 'Possible slips in new version' translated]; + at: 'Ignore slips and continue' translated put: [^ true]; + at: 'Cancel' translated put: [^ false]; + yourself) + title: ('This patch contains {1} halts, Transcript sends, or other possible slips.\\Save the new version anyway?' withCRs translated format: {slips size})) value. + ^ false MCPatchBrowser>>methodListMenu: {menus} · ct 1/15/2022 23:01 + methodListMenu: aMenu + + super methodListMenu: aMenu. + + aMenu add: 'check for slips' translated help: 'Check all changes for possible slips such as forgotten breakpoints or logging statements.' translated action: #reportSlips. + + ^ aMenu MCPatchBrowser>>reportSlips {actions} · ct 1/15/2022 23:05 + reportSlips + "Look for slips in all changes and report to the user what was found." + + | slips | + slips := self checkForSlips ifEmpty: [^ self inform: 'There were no obvious slips in this patch' translated]. + self systemNavigation + browseMessageList: (slips collect: [:ea | ea definition asMethodReference]) + name: 'Possible slips in new version' translated. MCPatchOperation>>hasReportableSlip {testing} · ct 1/15/2022 22:49 + hasReportableSlip + + ^ self targetDefinition + ifNil: [false] + ifNotNil: [:def | def hasReportableSlip] MCSaveVersionDialog>>accept {actions} · ct 1/15/2022 23:06 (changed) accept | logMessage logMessageWidget | self updateItems. + + (Preferences checkForSlips ==> [self lookForSlips]) ifFalse: [^ self]. + logMessage := (logMessageWidget := self findTextMorph: #logMessage) text asString. (logMessage isEmpty or: [logMessage beginsWith: 'empty log message']) ifTrue: - [(UIManager confirm: 'the log message is empty; are you sure you want to commit') ifFalse: [^ self]] + [(self confirm: 'The log message is empty; are you sure you want to commit?' translated) ifFalse: [^ self]] ifFalse: [logMessageWidget accept]. + self answer: { (self findTextMorph: #versionName) text asString. logMessage. ignore } MCSaveVersionDialog>>checkForSlips {actions} · ct 1/15/2022 23:12 + checkForSlips + + ^ super checkForSlipsIn: (self items copyWithoutAll: self ignore) Preference>>helpString: {menu} · ct 1/16/2022 01:31 + helpString: aString + + helpString := aString --- Sent from Squeak Inbox Talk ["mcSlips.1.cs"] ["mcSlips.png"]

4 10

The Inbox: Morphic-ct.1641.mcz
by commits＠source.squeak.org 20 May '23

20 May '23

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1641.mcz ==================== Summary ==================== Name: Morphic-ct.1641 Author: ct Time: 7 June 2020, 2:45:17.536284 pm UUID: b90e23e1-ce70-3d49-a8e4-f09af148ef97 Ancestors: Morphic-ct.1638 Refine #isHighFrequentEvent implementation for further event types. Fixes one possible cause of the "color depth = 0" bug. See http://forum.world.st/Image-not-startable-after-save-td5117084.html. Depends indeed on Morphic-ct.1638. =============== Diff against Morphic-ct.1638 =============== Item was added: + ----- Method: DropEvent>>isHighFrequentEvent (in category 'testing') ----- + isHighFrequentEvent + + ^ false! Item was added: + ----- Method: WindowEvent>>isHighFrequentEvent (in category 'testing') ----- + isHighFrequentEvent + + ^ (#(windowClose) includes: self type) not! Item was changed: ----- Method: WorldState>>doSafely:onErrorThat:setErrorFlag:ifFatal:afterErrorDo: (in category 'update cycle') ----- doSafely: aBlock onErrorThat: errorPredicate setErrorFlag: errorFlag ifFatal: fatalErrorBlock afterErrorDo: postErrorBlock "Evaluate aBlock and keep track of errors during morph invocations." | finished classesWithErrors | finished := false. classesWithErrors := IdentitySet new. [finished] whileFalse: [ [aBlock value. finished := true] on: Error, Halt, Warning do: [:ex | | err rcvr errCtxt errMorph | (errorPredicate cull: ex) ifFalse: [ex pass]. err := ex description. rcvr := ex receiver. errCtxt := thisContext. [ errCtxt := errCtxt sender. "Search the sender chain to find the morph causing the problem" [errCtxt notNil and: [(errCtxt receiver isMorph) not]] whileTrue: [errCtxt := errCtxt sender]. "If we're at the root of the context chain then we have a fatal problem" errCtxt ifNil: [^ fatalErrorBlock cull: err]. + errMorph := errCtxt receiver + ] doWhileTrue: [ - errMorph := errCtxt receiver. "If the morph causing the problem has already the error flag set, then search for the next morph above in the caller chain." errMorph hasProperty: errorFlag + ]. - ] whileTrue. errMorph setProperty: errorFlag toValue: true; changed. "Catch all errors, one for each receiver class." (classesWithErrors includes: rcvr class) ifFalse: [ classesWithErrors add: rcvr class. ToolSet debugException: ex]. postErrorBlock cull: err. ]].! Item was changed: ----- Method: WorldState>>processEventsSafely: (in category 'update cycle') ----- processEventsSafely: aHandMorph ^ self doSafely: [aHandMorph processEvents] + onErrorThat: [:error | self currentEvent ifNil: [true] ifNotNil: [:evt | evt isHighFrequentEvent]] - onErrorThat: [:error | ActiveEvent isNil or: [ActiveEvent isHighFrequentEvent]] setErrorFlag: #errorOnEvent ifFatal: [:error | Project current fatalEventHandlingError: error] afterErrorDo: []!

5 6

Review Request: stylePackageScripts.2.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 18 May '23

18 May '23

Please give me a short feedback on whether you agree with the idea of this change (PackageInfo scripts are no longer instances of StringHolder). If there is no objection, I will try to merge this into the Trunk after a week or so. :-) ["stylePackageScripts.png"] Best, Christoph =============== Summary =============== Change Set: stylePackageScripts Date: 22 November 2021 Author: Christoph Thiede This change set enables syntax highlighting for package scripts ({preamble,postscript}{, of removal}). To achieve this, the instance variables in PackageInfo are converted to hold plain strings or texts rather than StringHolders, and the client (Monticello) is reponsible itself for displaying them to the user and storing them back into the package. Note the postscript which converts all PackageInfo instances in the image. =============== Postscript =============== "Postscript: Eliminate StringHolder script in PackageInfos" PackageInfo allSubInstancesDo: [:packageInfo | #(preamble postscript preambleOfRemoval postscriptOfRemoval) do: [:sel | (packageInfo instVarNamed: sel) ifNotNil: [:stringHolder | packageInfo instVarNamed: sel put: stringHolder contents]]]. =============== Diff =============== MCWorkingCopyBrowser>>editLoadScripts {morphic ui} · ct 11/22/2021 16:05 (changed) editLoadScripts | arg | self hasWorkingCopy ifFalse: [^self]. arg := UIManager default - chooseFrom: #('edit preamble' 'edit postscript' 'edit preambleOfRemoval' 'edit postscriptOfRemoval') + chooseFrom: {'edit preamble' translated. 'edit postscript' translated. 'edit preambleOfRemoval' translated. 'edit postscriptOfRemoval' translated} values: #(#preamble #postscript #preambleOfRemoval #postscriptOfRemoval). arg ifNotNil: [ self editScript: arg]. MCWorkingCopyBrowser>>editScript: {morphic ui} · ct 11/22/2021 15:59 (changed) editScript: scriptSymbol - | script | - script := workingCopy packageInfo perform: scriptSymbol. - script openLabel: scriptSymbol asString, ' of the Package ', workingCopy package name. + | script | + script := workingCopy packageInfo perform: scriptSymbol. + Project uiManager + edit: script + label: ('{1} of the Package {2}' translated format: {scriptSymbol asString capitalized. workingCopy package name}) + shouldStyle: true + accept: [:result | workingCopy packageInfo + perform: scriptSymbol asSimpleSetter + with: result] PackageInfo>>isScript:not: {preamble/postscript} · ct 11/22/2021 15:53 (changed) isScript: script not: default ^ script notNil and: [ | contents | - contents := script contents asString withBlanksTrimmed. + contents := script asString withBlanksTrimmed. contents notEmpty and: [contents ~= default and: [contents ~= 'nil']]] PackageInfo>>postscript {preamble/postscript} · ct 11/22/2021 15:53 (changed) postscript + ^ postscript ifNil: [ - postscript := StringHolder new contents: self postscriptDefault] + postscript := self postscriptDefault] PackageInfo>>postscript: {preamble/postscript} · ct 11/22/2021 15:57 (changed) postscript: aString - postscript := StringHolder new contents: aString + postscript := aString PackageInfo>>postscriptOfRemoval {preamble/postscript} · ct 11/22/2021 15:53 (changed) postscriptOfRemoval ^ postscriptOfRemoval ifNil: [ - postscriptOfRemoval := StringHolder new contents: self postscriptOfRemovalDefault] + postscriptOfRemoval := self postscriptOfRemovalDefault] PackageInfo>>postscriptOfRemoval: {preamble/postscript} · ct 11/22/2021 15:57 (changed) postscriptOfRemoval: aString - postscriptOfRemoval := StringHolder new contents: aString + postscriptOfRemoval := aString PackageInfo>>preamble {preamble/postscript} · ct 11/22/2021 15:54 (changed) preamble ^ preamble ifNil: [ - preamble := StringHolder new contents: self preambleDefault] + preamble := self preambleDefault] PackageInfo>>preamble: {preamble/postscript} · ct 11/22/2021 15:56 (changed) preamble: aString - preamble := StringHolder new contents: aString + preamble := aString PackageInfo>>preambleOfRemoval {preamble/postscript} · ct 11/22/2021 15:54 (changed) preambleOfRemoval ^ preambleOfRemoval ifNil: [ - preambleOfRemoval := StringHolder new contents: self preambleOfRemovalDefault] + preambleOfRemoval := self preambleOfRemovalDefault] PackageInfo>>preambleOfRemoval: {preamble/postscript} · ct 11/22/2021 15:56 (changed) preambleOfRemoval: aString - preambleOfRemoval := StringHolder new contents: aString + preambleOfRemoval := aString ["stylePackageScripts.2.cs"]

2 5

The Trunk: WebClient-Core-ul.132.mcz
by commits＠source.squeak.org 12 May '23

12 May '23

tim Rowledge uploaded a new version of WebClient-Core to project The Trunk: http://source.squeak.org/trunk/WebClient-Core-ul.132.mcz ==================== Summary ==================== Name: WebClient-Core-ul.132 Author: ul Time: 11 April 2023, 6:05:30.414442 pm UUID: 7d14b070-76e7-47d2-a31d-9a2b283cefc6 Ancestors: WebClient-Core-mt.130 Speed up MD5 computation in WebUtils: - deprecated #md5HashStream: in favor of #md5HashStreamAsBytes:, which does the same, but returns the bytes in the correct order (not reversed). - avoid reading and writing words from and to ByteArrays (buffer) by changing the class of buffer between WordArray and ByteArray as needed. Hopefully endianness will be fine on all platforms (tests will fail if not). - use #readInto:startingAt:count: instead of #nextInto: to read from the stream into the buffer. This avoids a few sends and potential reallocation of the buffer. - do not convert the ByteString to ByteArray in #md5Digest:. ByteArray >> #replaceFrom:to:with:startingAt: can copy from a ByteString into the buffer. Throughput increases by ~6x for 16k inputs. =============== Diff against WebClient-Core-mt.130 =============== Item was changed: ----- Method: WebUtils class>>md5Digest: (in category 'md5') ----- md5Digest: aStringOrByteArray "This creates a little endian hex string to be used with various auth methods + This is the same as htdigest (apache) uses for its md5 digest auth db. + + self md5Digest: 'foo' " - This is the same as htdigest (apache) uses for its md5 digest auth db" + ^(self md5HashStreamAsBytes: aStringOrByteArray readStream) hex! - ^(self md5HashStream: (ReadStream on: aStringOrByteArray asByteArray)) reversed hex! Item was changed: ----- Method: WebUtils class>>md5HashStream: (in category 'md5') ----- md5HashStream: aStream + "This method returns the bytes of the md5 hash in revese order for backwards compatibility. Consider updating your implementation to avoid unnecessary reversal. - "self md5HashStream: (ReadStream on: 'foo')" - - | start buffer chunkSize n words hash | - hash := WordArray - with: 16r67452301 - with: 16rEFCDAB89 - with: 16r98BADCFE - with: 16r10325476. - words := WordArray new: 16. - buffer := ByteArray new: 64. - start := aStream position. - [ - chunkSize := (aStream nextInto: buffer) size. - chunkSize < 64 or: [ aStream atEnd ] ] - whileFalse: [ - 1 to: 16 do:[:i| words at: i put: (buffer unsignedLongAt: i*4-3 bigEndian: false)]. - self md5Transform: words hash: hash ]. - buffer from: chunkSize +1 to: buffer size put: 0. - chunkSize < 56 ifTrue: [ - buffer at: chunkSize + 1 put: 128. "trailing bit" - ] ifFalse:[ - "not enough room for the length, so just pad this one, then..." - chunkSize < 64 ifTrue:[buffer at: chunkSize + 1 put: 128]. - 1 to: 16 do:[:i| words at: i put: (buffer unsignedLongAt: i*4-3 bigEndian: false)]. - self md5Transform: words hash: hash. - "process one additional block of padding ending with the length" - buffer atAllPut: 0. - chunkSize = 64 ifTrue: [buffer at: 1 put: 128]. - ]. - "Fill in the final 8 bytes with the 64-bit length in bits." - n := (aStream position - start) * 8. - 7 to: 0 by: -1 do:[:i| buffer at: (buffer size - i) put: ((n bitShift: 7 - i * -8) bitAnd: 255)]. - "Final round" - 1 to: 16 do:[:i| words at: i put: (buffer unsignedLongAt: i*4-3 bigEndian: false)]. - self md5Transform: words hash: hash. + self md5HashStream: 'foo' readStream " + + self deprecated: 'Use #md5HashStreamAsBytes: and reverse the bytes in your code.'. + ^(self md5HashStreamAsBytes: aStream) reverseInPlace! - ^(ByteArray new: 16) - unsignedLongAt: 1 put: (hash at: 4) bigEndian: true; - unsignedLongAt: 5 put: (hash at: 3) bigEndian: true; - unsignedLongAt: 9 put: (hash at: 2) bigEndian: true; - unsignedLongAt: 13 put: (hash at: 1) bigEndian: true; - yourself! Item was added: + ----- Method: WebUtils class>>md5HashStreamAsBytes: (in category 'md5') ----- + md5HashStreamAsBytes: aStream + "Return a ByteArray containing the md5 hash of aStream. + + self md5HashStreamAsBytes: 'foo' readStream " + + | start buffer chunkSize n hash | + hash := WordArray + with: 16r67452301 + with: 16rEFCDAB89 + with: 16r98BADCFE + with: 16r10325476. + buffer := ByteArray new: 64. + start := aStream position. + [ + chunkSize := aStream readInto: buffer startingAt: 1 count: 64. + chunkSize < 64 or: [ aStream atEnd ] ] + whileFalse: [ + WordArray adoptInstance: buffer. + self md5Transform: buffer hash: hash. + ByteArray adoptInstance: buffer ]. + buffer from: chunkSize +1 to: buffer size put: 0. + chunkSize < 56 ifTrue: [ + buffer at: chunkSize + 1 put: 128. "trailing bit" + ] ifFalse:[ + "not enough room for the length, so just pad this one, then..." + chunkSize < 64 ifTrue:[buffer at: chunkSize + 1 put: 128]. + WordArray adoptInstance: buffer. + self md5Transform: buffer hash: hash. + ByteArray adoptInstance: buffer. + "process one additional block of padding ending with the length" + buffer atAllPut: 0. + chunkSize = 64 ifTrue: [buffer at: 1 put: 128]. + ]. + "Fill in the final 8 bytes with the 64-bit length in bits." + n := (aStream position - start) * 8. + 7 to: 0 by: -1 do:[:i| buffer at: (buffer size - i) put: ((n bitShift: 7 - i * -8) bitAnd: 255)]. + "Final round" + WordArray adoptInstance: buffer. + self md5Transform: buffer hash: hash. + ByteArray adoptInstance: hash. "Trick to avoid reallocation." + ^hash! Item was changed: ----- Method: WebUtils class>>webSocketHandshake:with:with: (in category 'websockets') ----- webSocketHandshake: key1 with: key2 with: data "Do the actual WebSocket handshake computation" | bytes | bytes := ByteArray new: 16. bytes longAt: 1 put: key1 bigEndian: true. bytes longAt: 5 put: key2 bigEndian: true. bytes replaceFrom: 9 to: 16 with: data. + ^self md5HashStreamAsBytes: bytes readStream! - ^(self md5HashStream: bytes readStream) reversed!

4 3

Parsing large json file *occasionally* results in an Integer
by tim Rowledge 05 May '23

05 May '23

I have some large json files that get parsed; we're talking 15Mb or so. They *should* result in large arrays of arrays of dictionaries of... you get the picture. Almost always, they do. Again and again, parse fileA and it works perfectly. Except just every now and then - maybe 3 times out of several hundred, on disparate dates, in different working images - the result is 58. Not 58 items in the root array, just 58, the SmallInteger. I can't see a code path that can result in that, which certainly makes it more interesting than usual. To make it bit more intriguing the subsequent code raises a dNU when this happens and so I get a debugger to look at. I can see the 58 that has been returned and put into the temp. I can retry the "open file, read as json" and it works perfectly. Fortunately that means I can proceed from there but the mystery remains. Whilst typing this my Pi has happily read & parsed that file 100 times without error. I *think* this has only actually happened on my Big! Scary! Xeon! server and never on the Pi, Mac, or little x64 xubuntu server. So maybe it's some strange bug courtesy of those nice people that brought us the Pentium Divide Error etc. So this is a shout into the void in hope of hearing an echo back that tells me somebody else has seen this and trapped an actual error. Or whatever. Oh, should probably point out I'm using the JSON-ul.56 from http://www.squeaksource.com/PostgresV3in a 5.3 image tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim M$ are grinning pigs in a sea of buggy code - The Inquirer

5 11

Monticello Update from the world menu bar
by Eliot Miranda 02 May '23

02 May '23

Hi Marcel, Hi All, minor chaos ensues if one uses the menu update when a commit dialogue for a package covered by the update has been opened but not completed. I guess the update should check for commits in progress and refuse to update until the commit has been closed. The issue is that there is an in-progress versioned working copy that doesn't inherit from the top of the update but from the tip of the imag''s pre-update version. So afterwards one has a damaged history. When I tripped over this today it didn't upload the broken verison to the repository so all I had to do was quit the image, delete the version in my package cache, repeat the update, and then repeat the commit. But it would have been nicer if the update had refused to go ahead while the uncommitted versioned working copy existed. _,,,^..^,,,_ best, Eliot

2 1

The Trunk: System-eem.1412.mcz
by commits＠source.squeak.org 25 Apr '23

25 Apr '23

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.1412.mcz ==================== Summary ==================== Name: System-eem.1412 Author: eem Time: 25 April 2023, 12:36:56.240776 pm UUID: f7aec916-53ca-476c-ab83-2bfdbaed529c Ancestors: System-tpr.1411 SystemNavigation>>allPragmaSelectorsLocalToPackage: to accompany SystemNavigation>>allPragmaSelectors =============== Diff against System-tpr.1411 =============== Item was added: + ----- Method: SystemNavigation>>allPragmaSelectorsLocalToPackage: (in category 'query') ----- + allPragmaSelectorsLocalToPackage: packageNameOrInfo + "Answer the set of all pragma selectors in the given package." + | result | + result := Set new. + (self packageInfoFor: packageNameOrInfo) actualMethodsDo: + [:method | + method pragmas do: + [:pragma| + result add: pragma keyword]]. + ^result sorted + + "self systemNavigation allPragmaSelectorsLocalToPackage: (UIManager default request: 'package')"!

1 0

The Trunk: Kernel-eem.1512.mcz
by commits＠source.squeak.org 25 Apr '23

25 Apr '23

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1512.mcz ==================== Summary ==================== Name: Kernel-eem.1512 Author: eem Time: 25 April 2023, 12:35:40.798521 pm UUID: 8b933427-a783-4e69-baf8-4cfd522fccd7 Ancestors: Kernel-dtl.1511 fix spelling error in class comment =============== Diff against Kernel-dtl.1511 =============== Item was changed: Object subclass: #Delay instanceVariableNames: 'delayDuration resumptionTime delaySemaphore beingWaitedOn' classVariableNames: 'AccessProtect ActiveDelay DelaySuspended FinishedDelay RunTimerEventLoop ScheduledDelay SuspendedDelays TimerEventLoop TimingSemaphore' poolDictionaries: '' category: 'Kernel-Processes'! + !Delay commentStamp: 'eem 2/13/2023 19:49' prior: 0! - !Delay commentStamp: 'eem 1/5/2016 11:58' prior: 0! I am the main way that a process may pause for some amount of time. The simplest usage is like this: (Delay forSeconds: 5) wait. An instance of Delay responds to the message 'wait' by suspending the caller's process for a certain amount of time. The duration of the pause is specified when the Delay is created with the message forMilliseconds: or forSeconds:. A Delay can be used again when the current wait has finished. For example, a clock process might repeatedly wait on a one-second Delay. A delay in progress when an image snapshot is saved is resumed when the snapshot is re-started. For a more complex example, see #testDelayOf:for:rect: . A word of advice: This is THE highest priority code which is run in Squeak, in other words it is time-critical. The speed of this code is critical for accurate responses, it is critical for network services, it affects every last part of the system. In short: Don't fix it if it ain't broken!! This code isn't supposed to be beautiful, it's supposed to be fast!! The reason for duplicating code is to make it fast. The reason for not using ifNil:[]ifNotNil:[] is that the compiler may not inline those. Since the effect of changes are VERY hard to predict it is best to leave things as they are for now unless there is an actual need to change anything Instance Variables beingWaitedOn: <UndefinedObject|Boolean> delayDuration: <Integer> delaySemaphore: <Semaphore> resumptionTime: <Integer> beingWaitedOn - this is set when the delay is being waited on or is unscheduled. delayDuration - the duration of the delay in milliseconds delaySemaphore - the semaphore used to suspend process(es) waiting on this delay resumptionTime + - the value of the UTC microsecond clock at which the delay should resume processes waiting on it'! - - the value of the UTC miscrosecond clock at which the delay should resume processes waiting on it'!

1 0

Please Try | New TreeBrowser
by Marcel Taeumel 24 Apr '23

24 Apr '23

Hi all -- Here is a slightly alternative version of Squeak's default browser. It uses tree widgets for the first three panes, that is, system/class categories, classes, message categories. Menus, filters, drag/drop, updates etc. should all work as in the traditional "Browser" browser. SystemBrowser default: TreeBrowser. SystemBrowser default: Browser. Please report issues. I plan to merge this soon. Note that there are 3 preferences: TreeBrowser showAllClassesInPackage TreeBrowser showBlankClassIcons TreeBrowser showEmptyPackages Yes, there is a slim integration with PackageInfo and Monticello packages. Best, Marcel

7 18

The Trunk: Monticello-tpr.788.mcz
by commits＠source.squeak.org 23 Apr '23

23 Apr '23

tim Rowledge uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-tpr.788.mcz ==================== Summary ==================== Name: Monticello-tpr.788 Author: tpr Time: 23 April 2023, 11:47:45.749737 am UUID: 54452883-7b3a-45d0-863b-5d47dfb1e2a4 Ancestors: Monticello-tpr.787 Attempt to ensure loading a package doesn't mess with source files when the log compilations to changes file preference is disabled. This is intended for use in headless/sourceless server type usages. =============== Diff against Monticello-tpr.787 =============== Item was changed: ----- Method: MCMethodDefinition>>asMethodAddition (in category 'converting') ----- asMethodAddition ^MethodAddition new compile: source classified: category withStamp: timeStamp notifying: nil + logSource: (SystemChangeNotifier uniqueInstance isBroadcasting and: [self actualClass acceptsLoggingOfCompilation]) - logSource: SystemChangeNotifier uniqueInstance isBroadcasting inClass: self actualClass.!

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →