Squeak-dev March 2023

squeak-dev@lists.squeakfoundation.org

32 participants
124 discussions

The Trunk: Kernel-mt.1506.mcz
by commits＠source.squeak.org 08 Mar '23

08 Mar '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1506.mcz ==================== Summary ==================== Name: Kernel-mt.1506 Author: mt Time: 8 March 2023, 9:27:37.752447 am UUID: 9693770e-3cbf-9d4e-96e2-8e6a99eaa4fa Ancestors: Kernel-mt.1505 Moves still-used #peekPosition method from ST80 to Kernel. See senders. Adds commentary. =============== Diff against Kernel-mt.1505 =============== Item was changed: ----- Method: EventSensor>>peekButtons (in category 'private') ----- peekButtons + self flag: #toRename. "mt: peek-api is ST80. Find a better name or remove usage by using something like HandMorph >> #lastEvent." self fetchMoreEvents. self eventQueue ifNotNil: [:queue | queue flush]. ^ mouseButtons! Item was added: + ----- Method: EventSensor>>peekPosition (in category 'private') ----- + peekPosition + + self flag: #toRename. "mt: peek-api is ST80. Find a better name or remove usage by using something like HandMorph >> #position." + self fetchMoreEvents. + self eventQueue ifNotNil: [:queue | queue flush]. + ^ mousePosition!

1 0

raised bordered ellipse
by Lauren Pullen 07 Mar '23

07 Mar '23

Hi List, After much pulling of my hair out on how to make GradientFillStyle work, I managed to get an EllipseMorph with a raised border. I've brute forced it by calling fillOval: twice; first call for the border, then again for the innards. FormCanvas and BalloonCanvas do not draw the same ellipse, scaled; the difference at a small radius is quite noticeable. Here is the code I've got. It only works with opaque filling, but that's all I need it to work with. (I mean, it doesn't crash... but it's certainly wrong.) I think I got the border width math correct? How would List tackle this? drawOn: aCanvas "manual drawing of RaisedBorder oval" aCanvas isShadowDrawing ifTrue: [^ super drawOn: aCanvas]. aCanvas "draw the border" fillOval: self bounds fillStyle: ((GradientFillStyle ramp: { 0.2 -> (self color mixed: 0.65 with: Color white). 0.5 -> (self color). 0.8 -> (self color mixed: 0.7 with: Color black)}) origin: self bounds origin; direction: self extent; radial: true); "fill the inside" balloonFillOval: ((self bounds origin + (self borderWidth)) corner: self bounds corner - (self borderWidth)) fillStyle: self color borderWidth: 0 borderColor: Color transparent

3 4

The Trunk: EToys-mt.494.mcz
by commits＠source.squeak.org 07 Mar '23

07 Mar '23

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.494.mcz ==================== Summary ==================== Name: EToys-mt.494 Author: mt Time: 7 March 2023, 2:04:29.260373 pm UUID: c7166e0f-85d6-df46-bfe7-1fe13c021c00 Ancestors: EToys-mt.493 Complement Compiler-mt.490 =============== Diff against EToys-mt.493 =============== Item was removed: - ----- Method: LeafNode>>key: (in category '*Etoys-Squeakland-Tweak-Kedama') ----- - key: anObject - - key := anObject. - !

1 0

The Trunk: Compiler-mt.490.mcz
by commits＠source.squeak.org 07 Mar '23

07 Mar '23

Marcel Taeumel uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-mt.490.mcz ==================== Summary ==================== Name: Compiler-mt.490 Author: mt Time: 7 March 2023, 2:03:58.835373 pm UUID: 45ccbf0e-f297-dc4c-bdd4-f38e89b0141a Ancestors: Compiler-eem.489 Move cricital accessor from EToys to here. =============== Diff against Compiler-eem.489 =============== Item was added: + ----- Method: LeafNode>>key: (in category 'accessing') ----- + key: anObject + + key := anObject. + !

1 0

The Trunk: ST80-mt.290.mcz
by commits＠source.squeak.org 07 Mar '23

07 Mar '23

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-mt.290.mcz ==================== Summary ==================== Name: ST80-mt.290 Author: mt Time: 7 March 2023, 1:01:37.417373 pm UUID: 5080c3f1-fd8f-ad4c-90e3-f55bc1b59669 Ancestors: ST80-mt.289 Complement Kernel-mt.1505 =============== Diff against ST80-mt.289 =============== Item was removed: - ----- Method: EventSensor>>peekButtons (in category '*ST80-Support-mouse') ----- - peekButtons - - self fetchMoreEvents. - self eventQueue ifNotNil: [:queue | queue flush]. - ^ mouseButtons!

1 0

The Trunk: Kernel-mt.1505.mcz
by commits＠source.squeak.org 07 Mar '23

07 Mar '23

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1505.mcz ==================== Summary ==================== Name: Kernel-mt.1505 Author: mt Time: 7 March 2023, 1:01:13.283373 pm UUID: 516874b9-040f-5642-97e8-e037503b3834 Ancestors: Kernel-mt.1504 Move important #peekButtons method from ST80 to Kernel. See senders. =============== Diff against Kernel-mt.1504 =============== Item was added: + ----- Method: EventSensor>>peekButtons (in category 'private') ----- + peekButtons + + self fetchMoreEvents. + self eventQueue ifNotNil: [:queue | queue flush]. + ^ mouseButtons!

1 0

The Inbox: EToys-kfr.495.mcz
by commits＠source.squeak.org 06 Mar '23

06 Mar '23

A new version of EToys was added to project The Inbox: http://source.squeak.org/inbox/EToys-kfr.495.mcz ==================== Summary ==================== Name: EToys-kfr.495 Author: kfr Time: 6 March 2023, 8:39:33.579068 pm UUID: b90257f1-0b79-254b-8ea1-1d77b41688d9 Ancestors: EToys-mt.493 MinesBoard cached a MinesTile in variable protoTile. But this was very slow on older machines because it copied the protoTile. Also in theory you could set protoTile to any morph, but in practice it not possible because the protoTile must implement certain methods. =============== Diff against EToys-mt.493 =============== Item was changed: AlignmentMorph subclass: #MinesBoard + instanceVariableNames: 'rows columns flashCount tileCount target actionSelector arguments gameStart gameOver boardSize' - instanceVariableNames: 'protoTile rows columns flashCount tileCount target actionSelector arguments gameStart gameOver boardSize' classVariableNames: 'BoardSizes' poolDictionaries: '' category: 'Etoys-Squeakland-Morphic-Games'! Item was changed: ----- Method: MinesBoard>>adjustTiles (in category 'accessing') ----- adjustTiles "reset tiles" | newSubmorphs count r c | submorphs do: "clear out all of the tiles." [:m | m privateOwner: nil]. newSubmorphs := OrderedCollection new. r := 0. c := 0. count := columns * rows. 1 to: count do: [:m | newSubmorphs add: + (MinesTile new + position: self position + (MinesTile new extent * (c @ r)); - (protoTile copy - position: self position + (self protoTile extent * (c @ r)); actionSelector: #tileClickedAt:newSelection:modifier:; arguments: (Array with: (c+1) @ (r+1)); target: self; privateOwner: self). c := c + 1. c >= columns ifTrue: [c := 0. r := r + 1]]. submorphs := newSubmorphs asArray. ! Item was changed: ----- Method: MinesBoard>>extent: (in category 'geometry') ----- extent: aPoint "constrain the extent to be a multiple of the protoTile size during resizing" + super extent: (aPoint truncateTo: MinesTile new extent).! - super extent: (aPoint truncateTo: protoTile extent).! Item was changed: ----- Method: MinesBoard>>initialize (in category 'initialization') ----- initialize "initialize the state of the receiver" super initialize. "" target := nil. actionSelector := #selection. arguments := #(). "" self layoutPolicy: nil; hResizing: #rigid; vResizing: #rigid. "" boardSize := BoardSizes at: 1. columns := self preferredColumns. rows := self preferredRows. flashCount := 0. "" + self extent: MinesTile new extent * (columns @ rows). - self extent: self protoTile extent * (columns @ rows). self adjustTiles. self resetBoard: 1.! Item was removed: - ----- Method: MinesBoard>>protoTile (in category 'accessing') ----- - protoTile - - protoTile ifNil: [protoTile := MinesTile new]. - ^ protoTile! Item was removed: - ----- Method: MinesBoard>>protoTile: (in category 'accessing') ----- - protoTile: aTile - - protoTile := aTile! Item was changed: ----- Method: MinesBoard>>resetBoard: (in category 'initialization') ----- resetBoard: aLevel boardSize := BoardSizes at: aLevel. columns := self preferredColumns. rows := self preferredRows. flashCount := 0. "" + self extent: MinesTile new extent * (columns @ rows). - self extent: self protoTile extent * (columns @ rows). self adjustTiles. gameStart := false. gameOver := false. flashCount := 0. tileCount := 0. Collection initialize. "randomize the Collection class" self purgeAllCommands. self submorphsDo: "set tiles to original state." [:m | m privateOwner: nil. "Don't propagate all these changes..." m mineFlag: false. m disabled: false. m switchState: false. m isMine: false. m privateOwner: self]. self changed "Now note the change in bulk"!

1 0

How do I "sleep 5"?
by Eduardo Ochs 05 Mar '23

05 Mar '23

Hi list, a few days ago I asked for help on how to send a "synthetic" keyboard event to a morph, and Karl Ramberg gave me exactly the right hints in this thread: http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-February/223473… My code is ready except for documentation and comments - I'll work on that in the next few days and then post the result here and on the wiki... ...but there's a feature that I want to add to it that - again =( - needs something that I'm not being able to discover by myself. How do I write a line of code that waits for 5 seconds, sort of like running "sleep 5" in a shell, and that doesn't block the rest of the system? If I have that I'll be able to run these two lines in a workspace, self mySleep: 5000. kf := self currentHand keyboardFocus. switch the keyboard focus to something else by clicking on it, and then the variable kf will be set to this "something else"... Thanks in advance! Eduardo Ochs http://anggtwu.net/eev-squeak.html

15 42

TheWorldMenu>>newMorphOfClass:event: - a bug and a fix
by Eduardo Ochs 05 Mar '23

05 Mar '23

Hi all, this is my first bug report, and my proposal for how to fix it is probably too naive... please discuss and rewrite. Take a menu item - for example, this one, World -> new morph... -> from alphabetical list -> L-N -> LineMorph and put it in the variable itemLineMorph. Then run: itemLineMorph debugAction. On the debugger, click "proceed". You will get an error a few steps ahead, in this method: TheWorldMenu >> #newMorphOfClass:event: the "evt hand" will fail because evt is nil. One fix is to replace the "evt hand" in TheWorldMenu>>#newMorphOfClass:event: by: (evt ifNotNil: [evt hand] ifNil: [nil currentHand]) Note that that bug is also triggered when we run debugAction from the halo. See these two messages: http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-March/223616.ht… http://lists.squeakfoundation.org/pipermail/squeak-dev/2023-March/223617.ht… Cheers, Eduardo Ochs http://anggtwu.net/eev-squeak.html

2 1

#deepCopy seems broken for IdentitySet
by Stéphane Rollandin 04 Mar '23

04 Mar '23

Hello all, After spending way too long on a bug in my code, I found the culprit to be that deep-copying an IdentitySet is not reliable. The copy may need a #rehash. To see this, do iset := {1@1} asIdentitySet. results := Set new. 100 timesRepeat: [ dcset := iset deepCopy. results add: (dcset includes: dcset anyOne)]. results "explore it" This should show both true and false in results. The proportion is about 2/3 false, which seems to correspond to the probability that #scanFor: will return a wrong index for a set of one element that needs a rehash, since {1@1} asIdentitySet array may be either one of {nil . nil . 1@1} {nil . 1@1 . nil} {1@1 . nil . nil} This behavior has been there for ages though - so, am I missing something? Stef

2 1