Squeak-dev October 2023

squeak-dev@lists.squeakfoundation.org

24 participants
148 discussions

The Trunk: Kernel-eem.1523.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1523.mcz ==================== Summary ==================== Name: Kernel-eem.1523 Author: eem Time: 22 August 2023, 12:55:52.155147 pm UUID: a4d61d2f-cc75-4b8c-9615-cef127a2b3fd Ancestors: Kernel-ct.1522 Rename Process's threadId inst var to threadAffinity while we still can. This is in response to Leon Matthes correctly pointing out that the variable is an affinity, not an id. Thanks! =============== Diff against Kernel-ct.1522 =============== Item was changed: Link subclass: #Process + instanceVariableNames: 'suspendedContext priority myList threadAffinity effectiveProcess name island env' - instanceVariableNames: 'suspendedContext priority myList threadId effectiveProcess name island env' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Processes'! + !Process commentStamp: 'eem 8/22/2023 12:52' prior: 0! - !Process commentStamp: 'eem 10/9/2021 15:34' prior: 0! I represent an independent path of control in the system. This path of control may be stopped (by sending the message suspend) in such a way that it can later be restarted (by sending the message resume). When any one of several paths of control can be advanced, the single instance of ProcessorScheduler named Processor determines which one will actually be advanced, partly using the value of priority. Instance Variables: N.B. The first four are used by the virtual machine. They must be defined, and defined in this order, suspendedContext: <Context|nil> priority: <Integer> myList: <LinkedList|nil> + threadAffinity: <Integer|nil> - threadId: <Integer|nil> effectiveProcess: <Process|nil> name: <String|nil> island: <Island|nil> env: <Dictionary|nil> effectiveProcess - if not nil effectiveProcess is a process I am running on behalf of. Used by the execution simulation machinery (used by the debugger) to ensure that Processor activeProcess et al answer the expected result when simulating execution (e.g. when debugging). See evaluate:onBehalfOf: and senders. env - if not nil this is a Dictionary providing process-specific variables. See e.g. environmentAt:*, DynamicVariable and ProcessSpecificVariable. island - used by Tweak and Croquet to partition the image into multiple address spaces myList - if nil, I am either suspended or the active process. If not nil it is either some condition variable (Semaphore, Mutex) that I am blocked waiting on, or it is the LinkedList in ProcessorScheduler quiescentProcesses that holds the processes for my priority that are not the current active process but still runnable. name - if not nil this is my name, used for information, see e.g. the names of processes displayed in the ProcessBrowser priority - my scheduling priority, which corresponds to the index in ProcessorScheduler quiescentProcesses that holds the LinkedList of processes at this priority. If I am running but quiescent, changing priority involves changing priority and myList. suspendedContext - if nil, then I am either the active process or I have been terminated. If not nil it is the Context at the hot end of my stack + threadAffinity + - if not nil then it is an integer value set by the VM that controls how I interact with underlying native threads. If positive, the threadAffinity is that of some native thread known to the VM, and the VM will ensure that when I am running, I will be running on that native thread. If negative, the absolute value of threadAffinity is that of some thread known to the VM, and the VM will ensure that when I am running, I will *not* be running on that native thread. Set by the VM. Not to be set manually. Meaningful only on threaded VMs (which do not mean VMs with a threaded heartbeat). It is required to be my fourth instance variable. See SmalltalkImage >> #processHasThreadAffinityInstVar: for further information.! - threadId - - if not nil then it is an integer value set by the VM that controls how I interact with underlying native threads. If positive, the threadId is that of some native thread known to the VM, and the VM will ensure that when I am running, I will be running on that native thread. If negative, the absolute value of threadId is that of some thread known to the VM, and the VM will ensure that when I am running, I will *not* be running on that native thread. Set by the VM. Not to be set manually. Meaningful only on threaded VMs (which do not mean VMs with a threaded heartbeat). It is required to be my fourth instance variable. See SmalltalkImage >> #processHasThreadIdInstVar: for further information.! Item was changed: + (PackageInfo named: 'Kernel') postscript: '"Make sure the 4th inst var of Process is threadAffinity, not threadId" - (PackageInfo named: 'Kernel') postscript: '"Turn on the enableIPv6 preference for trunk." + (Process instVarNames at: 4) = ''threadId'' ifTrue: + [Process instVarNames at: 4 put: ''threadAffinity'' copy]'! - NetNameResolver enableIPv6: true. - '!

2 1

Review Request: Clean up background styling of PluggableTextMorphPlus
by christoph.thiede＠student.hpi.uni-potsdam.de 12 Oct '23

12 Oct '23

Context: At the moment, PluggableTextMorph runs the text styler immediately (#updateStyleNow) or in the background (#updateStyle) depending on the trigger: * Immediately: The user accepts a text; we change the text programmatically (e.g., when opening a browser or selecting a different method). However, the text must be shorter than 4096 characters for this. * In the background: All other triggers: the user types or cancels; we change the style programmatically (e.g., after a preference change); accepting or changing a text longer than 4095 characters.* So, this strategy tries to balance maintaining a responsive UI for longer texts (especially during typing) and minimizing flickering. Problem: There are situations where we still have too much flickering. You may have a chance to observe this when you cancel (cmd+l) in a method in a browser. (It is best observable when keeping cmd+l pressed for a while.) Much more critical than for code editing, however, this effect is in other applications that employ frequent text updates and use a faster styler than Shout. Proposal: Give either the styler control over when to run in the background. Move the hard-coded 4096 to this check from PluggableTextMorphPlus>>#setText:. Introduce a second test hook with a smaller threshold for running all style requests (#updateStyle) immediately. E.g.: PluggableTextMorphPlus>>setText: aText self okToStyle ifFalse:[^super setText: aText]. super setText: (styler format: aText asText). (styler willItBeVeryExpensiveToStyle: aText) ifFalse: [self updateStyleNow] ifTrue: [self updateStyle] PluggableTextMorphPlus>>updateStyle | text | self okToStyle ifFalse: [^ self]. text := textMorph contents. (styler willItBeExpensiveToStyle: text) ifFalse: [self updateStyleNow] ifTrue: [styler styleInBackgroundProcess: textMorph contents]. Open to better names, of course. We can add a #respondsTo: check before sending these messages to the styler to keep the required styler interface minimal and fall back to "expensive, but not very expensive". In Shout, we could implement these selector like this: SHTextStylerST80>>willItBeExpensiveToStyle: aText ^ aText size >= 4096 SHTextStylerST80>>willItBeVeryExpensiveToStyle: aText ^ aText size >= 16384 Optionally, either PluggableTextMorphPlus or the styler could also check Smalltalk isLowerPerformance. Workaround: Until now, I will manually invoke the styler from the getText selector in my application in addition to registering it to the text morph to avoid any flickering. Looking forward to your opinions! Best, Christoph *NB: If we edit huge text, there can still be a larger delay but this comes from text layouting not from styling. --- Sent from Squeak Inbox Talk

3 6

The Trunk: Morphic-ct.2126.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2126.mcz ==================== Summary ==================== Name: Morphic-ct.2126 Author: ct Time: 26 August 2023, 10:47:41.051023 pm UUID: fd9b4398-075b-8c40-b1a8-8997341cf46a Ancestors: Morphic-mt.2125 Fixes invalid state in text morphs when selecting text while something (e.g., a transcript) is updating the text. E.g., you could trigger a nil errorNotIndexable from SmalltalkEditor(TextEditor)>>isDisjointFrom:) by doing this: [[1 second wait. Transcript showln: DateAndTime now] repeat] forkAt: Processor userBackgroundPriority. "Drag to select text, wait for the next update, and release the cursor outside the window" Make sure not to have any stepping morphs (such as browsers) in the world to reproduce this. #forceScreen does not need to be enabled. Note that this is not a concurrency issue but also occurs when writing to the transcript from the UI process only. In general, you should not manipulate (or even access?) morphic UI state from other processes. =============== Diff against Morphic-mt.2125 =============== Item was changed: ----- Method: TextEditor>>mouseUp: (in category 'events') ----- mouseUp: evt "An attempt to break up the old processRedButton code into threee phases" "0) Click on text actions." (self mouseUpOnTextAction: evt) ifTrue: [^ self]. "1) A 'double-click' will result in selecting the whole word." (self hasCaret and: [oldInterval = self selectionInterval]) ifTrue: [self selectWord]. "2) For the next type-in, configure emphasis. We don't want to do this on every key-press for performance reasons." self setEmphasisHere. "3) Notice selection changes." + (oldInterval notNil "happens if the editor has been replaced since mouseDown: (e.g., by a programmatic text change such as #appendEntry)" + and: [self isDisjointFrom: oldInterval]) + ifTrue: [otherInterval := oldInterval]. - (self isDisjointFrom: oldInterval) - ifTrue: [otherInterval := oldInterval]. self storeSelectionInParagraph. "4) Reset mouse cursor to account for selection changes." self updateCursorForEvent: evt. morph removeProperty: #waitingForTextDrag.!

1 0

The Trunk: Morphic-ct.2128.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2128.mcz ==================== Summary ==================== Name: Morphic-ct.2128 Author: ct Time: 29 August 2023, 7:45:00.722934 pm UUID: a9707281-add6-094c-a018-2cd2e39be9b8 Ancestors: Morphic-mt.2127 Proposal: Adds "collapse all like this" and "collapse all but this" items to windows's menu in docking bar. =============== Diff against Morphic-mt.2127 =============== Item was added: + ----- Method: TheWorldMainDockingBar>>collapseAllWindowsBut: (in category 'submenu - windows') ----- + collapseAllWindowsBut: window + (self allOtherWindowsLike: window) do: [:each | + each collapse]! Item was added: + ----- Method: TheWorldMainDockingBar>>collapseAllWindowsLike: (in category 'submenu - windows') ----- + collapseAllWindowsLike: window + self collapseAllWindowsBut: window. + window collapse! Item was changed: ----- Method: TheWorldMainDockingBar>>windowMenuFor:on: (in category 'submenu - windows') ----- windowMenuFor: window on: menu menu addItem: [ :item | item contents: 'Close' translated ; target: window; selector: #delete ]; addItem: [ :item | item contents: 'Close all like this' translated ; target: self; selector: #closeAllWindowsLike:; arguments: { window } ]; addItem: [ :item | item contents: 'Close all but this' translated ; target: self; selector: #closeAllWindowsBut:; arguments: { window } ]; + addLine; addItem: [ :item | + item + contents: 'Collapse all like this' translated ; + target: self; + selector: #collapseAllWindowsLike:; + arguments: { window } ]; + addItem: [ :item | + item + contents: 'Collapse all but this' translated ; + target: self; + selector: #collapseAllWindowsBut:; + arguments: { window } ]; + addLine; + addItem: [ :item | item contents: 'Expand or Contract' translated ; target: window; selector: #expandBoxHit ]!

1 0

The Trunk: Morphic-ct.2129.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2129.mcz ==================== Summary ==================== Name: Morphic-ct.2129 Author: ct Time: 29 August 2023, 7:48:39.322934 pm UUID: 85e43810-9270-5b4a-bdd4-0734c01a405d Ancestors: Morphic-mt.2127 Proposal: Expand selected window from "find windows". Just highlighting the collapsed window may not provide enough visibility if there are many windows. =============== Diff against Morphic-mt.2127 =============== Item was changed: ----- Method: TheWorldMainDockingBar>>selectWorkspace:window:inProject:contents: (in category 'submenu - windows') ----- selectWorkspace: aWorkspace window: aSystemWindow inProject: aMorphicProject contents: contents aMorphicProject + addDeferredUIMessage: [aSystemWindow expand; comeToFront]; - addDeferredUIMessage: [aSystemWindow comeToFront]; enter "Does nothing if already the current project..." !

1 0

The Trunk: Morphic-ct.2134.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.2134.mcz ==================== Summary ==================== Name: Morphic-ct.2134 Author: ct Time: 12 October 2023, 8:29:39.245009 pm UUID: 49daba16-98e1-a545-bf9a-e0bcb5500ddb Ancestors: Morphic-eem.2133, Morphic-ct.2129, Morphic-ct.2128, Morphic-ct.2126 Merge. Morphic-ct.2129: Expand selected window from "find windows". Morphic-ct.2128: Adds "collapse all like this" and "collapse all but this" items to windows's menu in docking bar. Morphic-ct.2126: Fixes invalid state in text morphs when selecting text while something (e.g., a transcript) is updating the text. =============== Diff against Morphic-eem.2133 =============== Item was changed: ----- Method: TextEditor>>mouseUp: (in category 'events') ----- mouseUp: evt "An attempt to break up the old processRedButton code into threee phases" "0) Click on text actions." (self mouseUpOnTextAction: evt) ifTrue: [^ self]. "1) A 'double-click' will result in selecting the whole word." (self hasCaret and: [oldInterval = self selectionInterval]) ifTrue: [self selectWord]. "2) For the next type-in, configure emphasis. We don't want to do this on every key-press for performance reasons." self setEmphasisHere. "3) Notice selection changes." + (oldInterval notNil "happens if the editor has been replaced since mouseDown: (e.g., by a programmatic text change such as #appendEntry)" + and: [self isDisjointFrom: oldInterval]) + ifTrue: [otherInterval := oldInterval]. - (self isDisjointFrom: oldInterval) - ifTrue: [otherInterval := oldInterval]. self storeSelectionInParagraph. "4) Reset mouse cursor to account for selection changes." self updateCursorForEvent: evt. morph removeProperty: #waitingForTextDrag.! Item was added: + ----- Method: TheWorldMainDockingBar>>collapseAllWindowsBut: (in category 'submenu - windows') ----- + collapseAllWindowsBut: window + (self allOtherWindowsLike: window) do: [:each | + each collapse]! Item was added: + ----- Method: TheWorldMainDockingBar>>collapseAllWindowsLike: (in category 'submenu - windows') ----- + collapseAllWindowsLike: window + self collapseAllWindowsBut: window. + window collapse! Item was changed: ----- Method: TheWorldMainDockingBar>>selectWorkspace:window:inProject:contents: (in category 'submenu - windows') ----- selectWorkspace: aWorkspace window: aSystemWindow inProject: aMorphicProject contents: contents aMorphicProject + addDeferredUIMessage: [aSystemWindow expand; comeToFront]; - addDeferredUIMessage: [aSystemWindow comeToFront]; enter "Does nothing if already the current project..." ! Item was changed: ----- Method: TheWorldMainDockingBar>>windowMenuFor:on: (in category 'submenu - windows') ----- windowMenuFor: window on: menu menu addItem: [ :item | item contents: 'Close' translated ; target: window; selector: #delete ]; addItem: [ :item | item contents: 'Close all like this' translated ; target: self; selector: #closeAllWindowsLike:; arguments: { window } ]; addItem: [ :item | item contents: 'Close all but this' translated ; target: self; selector: #closeAllWindowsBut:; arguments: { window } ]; + addLine; addItem: [ :item | + item + contents: 'Collapse all like this' translated ; + target: self; + selector: #collapseAllWindowsLike:; + arguments: { window } ]; + addItem: [ :item | + item + contents: 'Collapse all but this' translated ; + target: self; + selector: #collapseAllWindowsBut:; + arguments: { window } ]; + addLine; + addItem: [ :item | item contents: 'Expand or Contract' translated ; target: window; selector: #expandBoxHit ]!

1 0

The Trunk: System-ct.1424.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1424.mcz ==================== Summary ==================== Name: System-ct.1424 Author: ct Time: 29 August 2023, 7:41:28.345934 pm UUID: 9af4e7bf-a99d-8a43-9de5-87c8ed70ce94 Ancestors: System-mt.1423 Revises RealEstateAgent logic for placing collapsed windows to deal with more windows than fit in one column by arranging them next to each other. Speeds up the logic for high-DPI displays by honoring the current scaleFactor. =============== Diff against System-mt.1423 =============== Item was changed: ----- Method: RealEstateAgent class>>assignCollapseFrameFor: (in category 'utilities') ----- assignCollapseFrameFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid verticalBorderDistance horizontalBorderDistance otherFrames viewBox collapsedFrame extent top column countInColumn topLeft newFrame row rowLeft rowFrame | + grid := 8 px. + verticalBorderDistance := 8 px. + horizontalBorderDistance := 8 px. + - | grid otherFrames topLeft viewBox collapsedFrame extent newFrame verticalBorderDistance top | - grid := 8. - verticalBorderDistance := 8. aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | w ~= aSSView]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view ~= aSSView ifTrue: [aController view collapsedFrame]] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. collapsedFrame := aSSView collapsedFrame. extent := collapsedFrame notNil ifTrue: [collapsedFrame extent] ifFalse: [aSSView isMorph + ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2 px)] + ifFalse: [(aSSView labelText extent x + 70 px) @ aSSView labelHeight - ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2)] - ifFalse: [(aSSView labelText extent x + 70) @ aSSView labelHeight min: aSSView labelDisplayBox extent]]. collapsedFrame notNil ifTrue: [(otherFrames anySatisfy: [:f | collapsedFrame intersects: f]) ifFalse: ["non overlapping" ^ collapsedFrame]]. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [top := viewBox top + verticalBorderDistance. + countInColumn := 0. + [topLeft := viewBox left @ top. + newFrame := topLeft extent: extent. + newFrame bottom <= (viewBox height - verticalBorderDistance)] + whileTrue: + [row := otherFrames select: [:w | newFrame intersects: w]. + column > 0 ifFalse: [rowFrame := newFrame] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + horizontalBorderDistance. + rowFrame := newFrame translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | rowFrame intersects: w]]. + (viewBox containsRect: rowFrame) ifTrue: [ + row ifEmpty: ["no overlap" + ^ rowFrame]. + countInColumn := countInColumn + 1]. + top := top + grid]. + column := column + 1]. + + "If all else fails... (really too many wins here)" - top := viewBox top + verticalBorderDistance. - [topLeft := viewBox left @ top. - newFrame := topLeft extent: extent. - newFrame bottom <= (viewBox height - verticalBorderDistance)] - whileTrue: - [(otherFrames anySatisfy: [:w | newFrame intersects: w]) - ifFalse: ["no overlap" - ^ newFrame]. - top := top + grid]. - "If all else fails... (really to many wins here)" aSSView isMorph ifTrue:[ Project current showWorldMainDockingBar ifTrue:[^ (0 @ Project current world mainDockingBars first height) extent: extent]]. ^ 0 @ 0 extent: extent! Item was changed: ----- Method: RealEstateAgent class>>assignCollapsePointFor: (in category 'utilities') ----- assignCollapsePointFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid otherFrames viewBox column countInColumn y row topLeft currentRowLeft rowLeft | + grid := 24 px. "should be mult of 8, since manual move is gridded by 8 px" - | grid otherFrames y free topLeft viewBox | - grid := 24. "should be mult of 8, since manual move is gridded by 8" aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | true]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [y := viewBox top. + countInColumn := 0. + [(y := y + grid) <= (viewBox height - grid)] + whileTrue: + [topLeft := viewBox left@y. + row := otherFrames select: [:w | topLeft = w topLeft]. + column > 0 ifFalse: [currentRowLeft := topLeft] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + grid. + currentRowLeft := topLeft translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | currentRowLeft = w topLeft]]. + (viewBox containsPoint: topLeft) ifTrue: [ + row ifEmpty: ["no overlap" + ^ topLeft]. + countInColumn := countInColumn + 1]]. + column := column + 1]. + - y := viewBox top. - [(y := y + grid) <= (viewBox height - grid)] - whileTrue: - [topLeft := viewBox left@y. - free := true. - otherFrames do: [:w | free := free & (topLeft ~= w topLeft)]. - free ifTrue: [^ topLeft]]. "If all else fails..." ^ 0 @ 0!

1 0

The Trunk: System-ct.1428.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ct.1428.mcz ==================== Summary ==================== Name: System-ct.1428 Author: ct Time: 12 October 2023, 8:21:45.324009 pm UUID: f64b78ad-e590-5244-a502-69ac93d54093 Ancestors: System-ct.1427, System-ct.1424 Merges System-ct.1424: Revises RealEstateAgent logic for placing collapsed windows to deal with more windows than fit in one column by arranging them next to each other. Speeds up the logic for high-DPI displays by honoring the current scaleFactor. =============== Diff against System-ct.1427 =============== Item was changed: ----- Method: RealEstateAgent class>>assignCollapseFrameFor: (in category 'utilities') ----- assignCollapseFrameFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid verticalBorderDistance horizontalBorderDistance otherFrames viewBox collapsedFrame extent top column countInColumn topLeft newFrame row rowLeft rowFrame | + grid := 8 px. + verticalBorderDistance := 8 px. + horizontalBorderDistance := 8 px. + - | grid otherFrames topLeft viewBox collapsedFrame extent newFrame verticalBorderDistance top | - grid := 8. - verticalBorderDistance := 8. aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | w ~= aSSView]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view ~= aSSView ifTrue: [aController view collapsedFrame]] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. collapsedFrame := aSSView collapsedFrame. extent := collapsedFrame notNil ifTrue: [collapsedFrame extent] ifFalse: [aSSView isMorph + ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2 px)] + ifFalse: [(aSSView labelText extent x + 70 px) @ aSSView labelHeight - ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2)] - ifFalse: [(aSSView labelText extent x + 70) @ aSSView labelHeight min: aSSView labelDisplayBox extent]]. collapsedFrame notNil ifTrue: [(otherFrames anySatisfy: [:f | collapsedFrame intersects: f]) ifFalse: ["non overlapping" ^ collapsedFrame]]. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [top := viewBox top + verticalBorderDistance. + countInColumn := 0. + [topLeft := viewBox left @ top. + newFrame := topLeft extent: extent. + newFrame bottom <= (viewBox height - verticalBorderDistance)] + whileTrue: + [row := otherFrames select: [:w | newFrame intersects: w]. + column > 0 ifFalse: [rowFrame := newFrame] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + horizontalBorderDistance. + rowFrame := newFrame translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | rowFrame intersects: w]]. + (viewBox containsRect: rowFrame) ifTrue: [ + row ifEmpty: ["no overlap" + ^ rowFrame]. + countInColumn := countInColumn + 1]. + top := top + grid]. + column := column + 1]. + + "If all else fails... (really too many wins here)" - top := viewBox top + verticalBorderDistance. - [topLeft := viewBox left @ top. - newFrame := topLeft extent: extent. - newFrame bottom <= (viewBox height - verticalBorderDistance)] - whileTrue: - [(otherFrames anySatisfy: [:w | newFrame intersects: w]) - ifFalse: ["no overlap" - ^ newFrame]. - top := top + grid]. - "If all else fails... (really to many wins here)" aSSView isMorph ifTrue:[ Project current showWorldMainDockingBar ifTrue:[^ (0 @ Project current world mainDockingBars first height) extent: extent]]. ^ 0 @ 0 extent: extent! Item was changed: ----- Method: RealEstateAgent class>>assignCollapsePointFor: (in category 'utilities') ----- assignCollapsePointFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid otherFrames viewBox column countInColumn y row topLeft currentRowLeft rowLeft | + grid := 24 px. "should be mult of 8, since manual move is gridded by 8 px" - | grid otherFrames y free topLeft viewBox | - grid := 24. "should be mult of 8, since manual move is gridded by 8" aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | true]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [y := viewBox top. + countInColumn := 0. + [(y := y + grid) <= (viewBox height - grid)] + whileTrue: + [topLeft := viewBox left@y. + row := otherFrames select: [:w | topLeft = w topLeft]. + column > 0 ifFalse: [currentRowLeft := topLeft] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + grid. + currentRowLeft := topLeft translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | currentRowLeft = w topLeft]]. + (viewBox containsPoint: topLeft) ifTrue: [ + row ifEmpty: ["no overlap" + ^ topLeft]. + countInColumn := countInColumn + 1]]. + column := column + 1]. + - y := viewBox top. - [(y := y + grid) <= (viewBox height - grid)] - whileTrue: - [topLeft := viewBox left@y. - free := true. - otherFrames do: [:w | free := free & (topLeft ~= w topLeft)]. - free ifTrue: [^ topLeft]]. "If all else fails..." ^ 0 @ 0!

1 0

The Inbox: Morphic-ct.2130.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2130.mcz ==================== Summary ==================== Name: Morphic-ct.2130 Author: ct Time: 11 September 2023, 6:18:59.713063 pm UUID: 3f9268df-f04d-4d4c-bfee-7651b41c1443 Ancestors: Morphic-mt.2122 Avoids installing a new editor in TextMorph when receiving #textStyle:. Regression from Morphic-ct.2060. An editor is not expected before the TextMorph has been added to a world/owner. For instance, #fillsOwner: before #openInWorld was previously broken, and thus the BannerMorph required for Objectland. Please review. I'm not entirely sure whether I identified the correct invariant or whether TextContainer>>#bounds should instead check for a nil owner. Do BannerMorph example openInWorld to reproduce. =============== Diff against Morphic-mt.2122 =============== Item was changed: ----- Method: TextMorph>>textStyle: (in category 'accessing') ----- textStyle: aTextStyle "Change the receiver's set of fonts to aTextStyle. You can access those fonts via the TextFontChange text attribute. If you want to enfore a specific font face or point size, use #font: instead. NOTE THAT you must provide either a freshly created instance of TextStyle or a copy of an existing one. NEVER use, for example, TextStyle class >> #default directly. Also see senders and implementors of #asNewTextStyle." | previousSelection | textStyle := aTextStyle. + previousSelection := editor ifNotNil: [editor selectionInterval]. - previousSelection := self selectionInterval. self releaseParagraph; changed. previousSelection ifNotNil: [self selectionInterval: previousSelection].!

3 2

The Inbox: OcompletionSqueakCompatibility-mad.4.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

A new version of OcompletionSqueakCompatibility was added to project The Inbox: http://source.squeak.org/inbox/OcompletionSqueakCompatibility-mad.4.mcz ==================== Summary ==================== Name: OcompletionSqueakCompatibility-mad.4 Author: mad Time: 22 September 2023, 4:41:48.24935 pm UUID: b361db4b-3e6f-48b0-bdd2-3527680ea77c Ancestors: OcompletionSqueakCompatibility-JohnMcKeon.3 Fixes the position of the OMenuMorph for (Pluggable)TextMorphs inside TransformMorphs. I know this doesn't belong to trunk, could someone please merge this into OCompletion? Thank you. ==================== Snapshot ==================== SystemOrganization addCategory: #OcompletionSqueakCompatibility! StandardToolSet subclass: #ECToolSet instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'OcompletionSqueakCompatibility'! ----- Method: ECToolSet class>>codeCompletionAround:textMorph:keyStroke: (in category 'completion') ----- codeCompletionAround: aBlock textMorph: aTextMorph keyStroke: evt | completionAllowed editor stringHolder | editor := aTextMorph editor. stringHolder := editor ifNotNil: [editor model]. completionAllowed := ECPreferences enabled and:[ ECController allowModel: stringHolder ]. completionAllowed ifTrue: [(stringHolder completionController handleKeystrokeBefore: evt editor: editor) ifTrue: [^ self]]. aBlock value. "sends to keyStroke event handler, if any" "Narrow the completion with any of the keys" completionAllowed ifTrue: [stringHolder completionController handleKeystrokeAfter: evt editor: editor]! ----- Method: ECToolSet class>>register (in category 'initialization') ----- register "Asks the system to use me when launching completion" ToolSet register: self! ----- Method: SmalltalkEditor>>isCaretBehindChar (in category '*OcompletionSqueakCompatibility') ----- isCaretBehindChar "Return true if the cursor position is after an alphanumeric character, otherwise false." | cursorPosition | ^(cursorPosition := self startIndex) >= 2 and: [ (self text at: cursorPosition - 1) isAlphaNumeric ]! ----- Method: SmalltalkEditor>>selectionPosition: (in category '*OcompletionSqueakCompatibility') ----- selectionPosition: aString | startIndex | startIndex := self startIndex. ^[ | bottomLeft topLeft index | index := startIndex - aString size. self selectInvisiblyFrom: index to: index - 1. bottomLeft := paragraph selectionRects first bottomLeft. topLeft := self morph boundsInWorld topLeft. topLeft + bottomLeft ] ensure: [ self selectInvisiblyFrom: startIndex to: startIndex - 1 ]! ----- Method: SmalltalkEditor>>wordAtCaret (in category '*OcompletionSqueakCompatibility') ----- wordAtCaret ^paragraph text asString wordBefore: self startIndex - 1 ! ----- Method: ParagraphEditor>>isCaretBehindChar (in category '*OcompletionSqueakCompatibility') ----- isCaretBehindChar "Return true if the cursor position is after an alphanumeric character, otherwise false." | cursorPosition | ^(cursorPosition := self startIndex) >= 2 and: [ (self text at: cursorPosition - 1) isAlphaNumeric ]! ----- Method: ParagraphEditor>>selectionPosition: (in category '*OcompletionSqueakCompatibility') ----- selectionPosition: aString | startIndex | startIndex := self startIndex. ^[ | bottomLeft topLeft index | index := startIndex - aString size. self selectInvisiblyFrom: index to: index - 1. bottomLeft := paragraph selectionRects first bottomLeft. topLeft := self morph boundsInWorld topLeft. topLeft + bottomLeft ] ensure: [ self selectInvisiblyFrom: startIndex to: startIndex - 1 ]! ----- Method: ParagraphEditor>>wordAtCaret (in category '*OcompletionSqueakCompatibility') ----- wordAtCaret ^paragraph text asString wordBefore: self startIndex - 1 !

2 1

← Newer
1
...
4
5
6
7
8
9
10
...
15
Older →

Jump to page: