Squeak-dev August 2022

squeak-dev@lists.squeakfoundation.org

30 participants
157 discussions

The Trunk: Graphics-nice.535.mcz
by commits＠source.squeak.org 19 Aug '22

19 Aug '22

Nicolas Cellier uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-nice.535.mcz ==================== Summary ==================== Name: Graphics-nice.535 Author: nice Time: 19 August 2022, 3:55:21.336121 pm UUID: 51ad8137-3d54-2a4e-b30b-c30462a833ed Ancestors: Graphics-mt.534 Fix Color mercury (scaled components missing a range spec), provide an accelerated constructor for Color, and use it for some named colors. Comparing these: { [Color r: 16r04/255 g: 16r02/255 b: 16rFF/255] bench. [Color r: 16r04 g: 16r02 b: 16rFF range: 255] bench. } I get near 9x acceleration on Spur64 =============== Diff against Graphics-mt.534 =============== Item was changed: ----- Method: Color class>>aluminum (in category 'named colors - crayons') ----- aluminum + ^ Color r: 153 g: 153 b: 153 range: 255! - ^ Color r: 153/255 g: 153/255 b: 153/255! Item was changed: ----- Method: Color class>>aqua (in category 'named colors - crayons') ----- aqua + ^ Color r: 0 g: 128 b: 255 range: 255! - ^ Color r: 0.0 g: 128/255 b: 1.0! Item was changed: ----- Method: Color class>>asparagus (in category 'named colors - crayons') ----- asparagus + ^ Color r: 128 g: 128 b: 0 range: 255! - ^ Color r: 128/255 g: 128/255 b: 0.0! Item was changed: ----- Method: Color class>>banana (in category 'named colors - crayons') ----- banana + ^ Color r: 255 g: 255 b: 102 range: 255! - ^ Color r: 1.0 g: 1.0 b: 102/255! Item was changed: ----- Method: Color class>>bubblegum (in category 'named colors - crayons') ----- bubblegum + ^ Color r: 255 g: 102 b: 255 range: 255! - ^ Color r: 1.0 g: 102/255 b: 1.0! Item was changed: ----- Method: Color class>>carnation (in category 'named colors - crayons') ----- carnation + ^ Color r: 255 g: 111 b: 207 range: 255! - ^ Color r: 1.0 g: 111/255 b: 207/255! Item was changed: ----- Method: Color class>>cayenne (in category 'named colors - crayons') ----- cayenne + ^ Color r: 128 g: 0 b: 0 range: 255! - ^ Color r: 128/255 g: 0.0 b: 0.0! Item was changed: ----- Method: Color class>>clover (in category 'named colors - crayons') ----- clover + ^ Color r: 0 g: 128 b: 0 range: 255! - ^ Color r: 0.0 g: 128/255 b: 0.0! Item was changed: ----- Method: Color class>>eggplant (in category 'named colors - crayons') ----- eggplant + ^ Color r: 64 g: 0 b: 128 range: 255! - ^ Color r: 64/255 g: 0.0 b: 128/255! Item was changed: ----- Method: Color class>>fern (in category 'named colors - crayons') ----- fern + ^ Color r: 64 g: 128 b: 0 range: 255! - ^ Color r: 64/255 g: 128/255 b: 0.0! Item was changed: ----- Method: Color class>>flora (in category 'named colors - crayons') ----- flora + ^ Color r: 102 g: 255 b: 102 range: 255! - ^ Color r: 102/255 g: 1.0 b: 102/255! Item was changed: ----- Method: Color class>>grape (in category 'named colors - crayons') ----- grape + ^ Color r: 128 g: 0 b: 255 range: 255! - ^ Color r: 128/255 g: 0.0 b: 1.0! Item was changed: ----- Method: Color class>>honeydew (in category 'named colors - crayons') ----- honeydew + ^ Color r: 204 g: 255 b: 102 range: 255! - ^ Color r: 204/255 g: 1.0 b: 102/255! Item was changed: ----- Method: Color class>>ice (in category 'named colors - crayons') ----- ice + ^Color r: 16r99 g: 16rFF b: 16rFF range: 255! - - ^ Color r: 102/255 g: 1.0 b: 1.0! Item was changed: ----- Method: Color class>>iron (in category 'named colors - crayons') ----- iron + ^ Color r: 76 g: 76 b: 76 range: 255! - ^ Color r: 76/255 g: 76/255 b: 76/255! Item was changed: ----- Method: Color class>>lavender (in category 'named colors - crayons') ----- lavender + ^ Color r: 204 g: 102 b: 255 range: 255! - ^ Color r: 204/255 g: 102/255 b: 1.0! Item was changed: ----- Method: Color class>>lead (in category 'named colors - crayons') ----- lead + ^ Color r: 25 g: 25 b: 25 range: 255! - ^ Color r: 25/255 g: 25/255 b: 25/255! Item was changed: ----- Method: Color class>>lime (in category 'named colors - crayons') ----- lime + ^ Color r: 128 g: 255 b: 0 range: 255! - ^ Color r: 128/255 g: 1.0 b: 0.0! Item was changed: ----- Method: Color class>>magnesium (in category 'named colors - crayons') ----- magnesium + ^ Color r: 179 g: 179 b: 179 range: 255! - ^ Color r: 179/255 g: 179/255 b: 179/255! Item was changed: ----- Method: Color class>>maroon (in category 'named colors - crayons') ----- maroon + ^ Color r: 128 g: 0 b: 64 range: 255! - ^ Color r: 128/255 g: 0.0 b: 64/255! Item was changed: ----- Method: Color class>>mercury (in category 'named colors - crayons') ----- mercury + ^ Color r: 230 g: 230 b: 230 range: 255! - ^ Color r: 230.0 g: 230.0 b: 230.0! Item was changed: ----- Method: Color class>>midnight (in category 'named colors - crayons') ----- midnight + ^ Color r: 0 g: 0 b: 128 range: 255! - ^ Color r: 0.0 g: 0.0 b: 128/255! Item was changed: ----- Method: Color class>>mocha (in category 'named colors - crayons') ----- mocha + ^ Color r: 128 g: 64 b: 0 range: 255! - ^ Color r: 128/255 g: 64/255 b: 0.0! Item was changed: ----- Method: Color class>>moss (in category 'named colors - crayons') ----- moss + ^ Color r: 0 g: 128 b: 64 range: 255! - ^ Color r: 0.0 g: 128/255 b: 64/255! Item was changed: ----- Method: Color class>>nickel (in category 'named colors - crayons') ----- nickel + ^ Color r: 128 g: 128 b: 128 range: 255! - ^ Color r: 128/255 g: 128/255 b: 128/255! Item was changed: ----- Method: Color class>>ocean (in category 'named colors - crayons') ----- ocean + ^ Color r: 0 g: 64 b: 128 range: 255! - ^ Color r: 0.0 g: 64/255 b: 128/255! Item was changed: ----- Method: Color class>>orchid (in category 'named colors - crayons') ----- orchid + ^ Color r: 102 g: 102 b: 255 range: 255! - ^ Color r: 102/255 g: 102/255 b: 1.0! Item was changed: ----- Method: Color class>>plum (in category 'named colors - crayons') ----- plum + ^ Color r: 128 g: 0 b: 128 range: 255! - ^ Color r: 128/255 g: 0.0 b: 128/255! Item was changed: ----- Method: Color class>>salmon (in category 'named colors - crayons') ----- salmon + ^ Color r: 255 g: 102 b: 102 range: 255! - ^ Color r: 1.0 g: 102/255 b: 102/255! Item was changed: ----- Method: Color class>>seaFoam (in category 'named colors - crayons') ----- seaFoam + ^ Color r: 0 g: 1 b: 128 range: 255! - ^ Color r: 0.0 g: 1.0 b: 128/255! Item was changed: ----- Method: Color class>>silver (in category 'named colors - crayons') ----- silver + ^ Color r: 204 g: 204 b: 204 range: 255! - ^ Color r: 204/255 g: 204/255 b: 204/255! Item was changed: ----- Method: Color class>>sky (in category 'named colors - crayons') ----- sky + ^ Color r: 102 g: 204 b: 255 range: 255! - ^ Color r: 102/255 g: 204/255 b: 1.0! Item was changed: ----- Method: Color class>>spindrift (in category 'named colors - crayons') ----- spindrift + ^ Color r: 102 g: 255 b: 204 range: 255! - ^ Color r: 102/255 g: 1.0 b: 204/255! Item was changed: ----- Method: Color class>>steel (in category 'named colors - crayons') ----- steel + ^ Color r: 102 g: 102 b: 102 range: 255! - ^ Color r: 102/255 g: 102/255 b: 102/255! Item was changed: ----- Method: Color class>>strawberry (in category 'named colors - crayons') ----- strawberry + ^ Color r: 255 g: 0 b: 128 range: 255! - ^ Color r: 1.0 g: 0.0 b: 128/255! Item was changed: ----- Method: Color class>>tangerine (in category 'named colors - crayons') ----- tangerine + ^ Color r: 255 g: 128 b: 0 range: 255! - ^ Color r: 1.0 g: 128/255 b: 0.0! Item was changed: ----- Method: Color class>>teal (in category 'named colors - crayons') ----- teal + ^ Color r: 0 g: 128 b: 128 range: 255! - ^ Color r: 0.0 g: 128/255 b: 128/255! Item was changed: ----- Method: Color class>>tin (in category 'named colors - crayons') ----- tin + ^ Color r: 127 g: 127 b: 127 range: 255! - ^ Color r: 127/255 g: 127/255 b: 127/255! Item was changed: ----- Method: Color class>>tungsten (in category 'named colors - crayons') ----- tungsten + ^ Color r: 51 g: 51 b: 51 range: 255! - ^ Color r: 51/255 g: 51/255 b: 51/255! Item was changed: ----- Method: Color>>asColorref (in category 'conversions') ----- asColorref + "Convert the receiver into a colorref + See https://docs.microsoft.com/en-us/windows/win32/gdi/colorref" - "Convert the receiver into a colorref" ^ (self red * 255) rounded + ((self green * 255) rounded << 8) + ((self blue * 255) rounded << 16)! Item was added: + ----- Method: Color>>setRed8:green8:blue8: (in category 'private') ----- + setRed8: r green8: g blue8: b + "Initialize this color's r, g, and b components to the given values in the range [0..255]. + Use an optimized operation rather than a slow division" + + " + self assert: ((0 to: 255) allSatisfy: [:e | (e*1023/255) rounded = (e * 16r403 + 16r81 >> 8)]). + " + + ComponentMax = 1023 ifFalse: [^self setRed: r / 255 green: g / 255 blue: b / 255]. + rgb == nil ifFalse: [self attemptToMutateError]. + rgb := ((r* 16r403 + 16r81 >> 8) bitShift: RedShift) + + ((g* 16r403 + 16r81 >> 8) bitShift: GreenShift) + + ((b* 16r403 + 16r81 >> 8)). + cachedDepth := nil. + cachedBitPattern := nil.! Item was changed: ----- Method: Color>>setRed:green:blue:range: (in category 'private') ----- setRed: r green: g blue: b range: range "Initialize this color's r, g, and b components to the given values in the range [0..r]." + range = 255 ifTrue: [^self setRed8: r green8: g blue8: b]. ^ self setRed: r / range green: g / range blue: b / range!

1 0

The Inbox: Graphics-kfr.535.mcz
by commits＠source.squeak.org 19 Aug '22

19 Aug '22

A new version of Graphics was added to project The Inbox: http://source.squeak.org/inbox/Graphics-kfr.535.mcz ==================== Summary ==================== Name: Graphics-kfr.535 Author: kfr Time: 19 August 2022, 8:38:55.19914 am UUID: 937968c4-4662-7349-8606-37501aa10fa6 Ancestors: Graphics-mt.534 Update comment on Form>>fillAlpha: =============== Diff against Graphics-mt.534 =============== Item was changed: ----- Method: Form>>fillAlpha: (in category 'other') ----- fillAlpha: alphaValue "Fill a 32bit form with a constant alpha value" + "alphaValue: 0 to 255" | bb | self depth = 32 ifFalse:[^self error: 'Only valid for 32 bit forms']. bb := BitBlt toForm: self. bb combinationRule: 7. "bitOr:with:". bb fillColor: (Bitmap with: alphaValue << 24). bb copyBits. !

1 0

WebClient version tracking
by tim Rowledge 17 Aug '22

17 Aug '22

After an email on the Seaside list from Johan, I had reason to look at the WebClient page on http://ss3.gemtalksystems.com where I discovered what looks like a fairly separate development path of the WebClient code. I downloaded the latest WebClient-Core mcz to compare with what is in trunk and for 5.3 there is a single method that differs (WebUtils class>>#jsonNumberFrom:) for 6.0 there is quite a long list, though many are simply correcting block argument decls to have the '|' in place. I don't know if anyone is tracking this and maybe it doesn't even matter since Pharos seems to use 'Zinc' instead of WebClient. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Oscar Wilde: “Only the shallow truly know themselves.”

2 2

The Trunk: Collections-nice.1021.mcz
by commits＠source.squeak.org 17 Aug '22

17 Aug '22

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.1021.mcz ==================== Summary ==================== Name: Collections-nice.1021 Author: nice Time: 17 August 2022, 3:55:41.813169 pm UUID: cae7a6c2-091f-6f4a-a1f6-6acc3e5fa59c Ancestors: Collections-cmm.1020 Align WeakIdentityDictionary comment with current implementation. Since Collections-ul.897, the slots corresponding to reclaimed associations (those nilled out) are no longer recycled when scanning for a key. They are recycled only when the dictionary grows, or possibly when we fix some collision after an explicit removal of a key (via removeKey:). =============== Diff against Collections-cmm.1020 =============== Item was changed: IdentityDictionary subclass: #WeakIdentityDictionary instanceVariableNames: 'vacuum' classVariableNames: '' poolDictionaries: '' category: 'Collections-Weak'! + !WeakIdentityDictionary commentStamp: 'nice 8/17/2022 15:45' prior: 0! - !WeakIdentityDictionary commentStamp: 'nice 10/27/2016 20:00' prior: 0! I am a WeakIdentityDictionary, that is a dictionary pointing weakly to its associations of key->value pairs. I am especially usefull for handling undeclared bindings that will be naturally garbage collected without having to scan all the CompiledMethods. Instance variables: vacuum <Object> a unique object used for marking empty slots Due to usage of WeakArray for my own storage, reclaimed slots will be nilled out. + I cannot consider a nil slot as empty because garbage collection does not fix collisions. - I cannot consider a nil slot as empty because of garbage collection does not fix collisions. Thus I need to differentiate empty slots (vacuum) from garbaged collected slots (nil). If I did not reclaim the nil slots and make them vacuum again, then my capacity would grow indefinitely. + I skip those nil slots when growing in order to avoid such unbounded growth (see #growTo:). - My strategy to avoid such growth is to randomly cleanup the garbage collected slot encountered when scanning for a key. - It should mitigate the growth since this method is used when adding a new entry. + Due to those not yet cleaned-up nil slots I might over-estimate my size. See #slowSize to get a more relevant but slower answer.! - Due to those not yet cleaned-up nil slots I might over-estimate my size. Don't take it too literally.!

1 0

[FIX]Etoys pen glitch
by karl ramberg 16 Aug '22

16 Aug '22

When a player rotates it gets added to a TranformationMorph. This causes a glitch when the player's pen is down. The players x and y coordinates briefly get set to 0@0 and a pen stroke is drawn to the top right corner. When turning the player, lift the pen, and lower after turning is done. PS: Something is wrong with Etoys in the Inbox, so all Etoys classes are added to the version when I try to save. Best, Karl

3 7

Problem creating MVCProject in Mac
by Javier Diaz-Reinoso 15 Aug '22

15 Aug '22

I download Squeak6.0-22104-64bit.dmg, extract app, run, skip configuration, menu Create MVCProject, enter, click but the main menu don't open, I need to Force Quit to exit the image. Tested Squeak6.0-22104-64bit-202206021410-Windows-x64 in VirtualBox Win10 and that works OK, so is probably a VM bug. Mac is in Mojave 10.14.6.

5 13

The Inbox: Network-vd.263.mcz
by commits＠source.squeak.org 15 Aug '22

15 Aug '22

A new version of Network was added to project The Inbox: http://source.squeak.org/inbox/Network-vd.263.mcz ==================== Summary ==================== Name: Network-vd.263 Author: vd Time: 15 August 2022, 10:10:53.94751 pm UUID: 94aff6fb-cd1c-ed11-9140-f0def1d1df96 Ancestors: Network-tonyg.262 ServerDirectory class>>parseFTPEntry: call to deprecated DirectoryEntry class>>#name:creationTime:modificationTime:isDirectory:fileSize: removed =============== Diff against Network-tonyg.262 =============== Item was changed: ----- Method: ServerDirectory class>>parseFTPEntry: (in category 'misc') ----- parseFTPEntry: ftpEntry + | tokens longy dateInSeconds thisYear thisMonth isDirectory directoryOrFileEntryClass| - | tokens longy dateInSeconds thisYear thisMonth | thisYear := Date today year. thisMonth := Date today monthIndex. tokens := ftpEntry findTokens: ' '. tokens size = 8 ifTrue: [((tokens at: 6) size ~= 3 and: [(tokens at: 5) size = 3]) ifTrue: ["Fix for case that group is blank (relies on month being 3 chars)" tokens := tokens copyReplaceFrom: 4 to: 3 with: {'blank'}]]. tokens size >= 9 ifFalse:[^nil]. ((tokens at: 6) size ~= 3 and: [(tokens at: 5) size = 3]) ifTrue: ["Fix for case that group is blank (relies on month being 3 chars)" tokens := tokens copyReplaceFrom: 4 to: 3 with: {'blank'}]. tokens size > 9 ifTrue: [ "cmm: this approach fails for filenames containing two spaces in a row." longy := tokens at: 9. 10 to: tokens size do: [:i | longy := longy , ' ' , (tokens at: i)]. tokens at: 9 put: longy]. dateInSeconds := self secondsForDay: (tokens at: 7) month: (tokens at: 6) yearOrTime: (tokens at: 8) thisMonth: thisMonth thisYear: thisYear. + isDirectory:=((tokens first first) = $d or: [tokens first first =$l]) "is-a-directory flag". + directoryOrFileEntryClass:=isDirectory ifTrue: [ DirectoryEntryDirectory ] ifFalse: [ DirectoryEntryFile ]. + + ^ directoryOrFileEntryClass + directory: nil + name: (tokens at: 9) "file name" + creationTime: dateInSeconds + modificationTime: dateInSeconds + fileSize: tokens fifth asNumber "file size". + ! - ^DirectoryEntry name: (tokens at: 9) "file name" - creationTime: dateInSeconds "creation date" - modificationTime: dateInSeconds "modification time" - isDirectory: ((tokens first first) = $d or: [tokens first first =$l]) "is-a-directory flag" - fileSize: tokens fifth asNumber "file size" - !

1 0

TextMorph minimal width
by Stéphane Rollandin 15 Aug '22

15 Aug '22

Hello, In 6.0 (TextMorph new contents: 'B'; backgroundColor: Color green) openInHand yields a Morph that is wider than needed by an extra character changing #minCompositionWidth in TextMorph by removing the * 2 fixes that problem, but introduces another one (bad layout of modal window titles) that can itself be fixed by reintroducing the same * 2 in #minWidth as follow: minWidth | result | result := self minCompositionWidth * 2 + (self borderWidth*2). margins ifNil: [^ result]. ^ margins isRectangle ifTrue: [result + margins left + margins right] ifFalse: [margins isPoint ifTrue: [result + margins x + margins x] ifFalse: [result + (2*margins)]] Is that correct? Stef

2 5

The Trunk: Morphic-mt.2025.mcz
by commits＠source.squeak.org 15 Aug '22

15 Aug '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2025.mcz ==================== Summary ==================== Name: Morphic-mt.2025 Author: mt Time: 15 August 2022, 12:50:46.840306 pm UUID: a5e3954c-4e93-fd41-b800-7a3f105682ea Ancestors: Morphic-mt.2024 Minor tweak of previous commit to ensure visibility of empty text morphs. =============== Diff against Morphic-mt.2024 =============== Item was changed: ----- Method: TextMorph>>createParagraph (in category 'private') ----- createParagraph self setProperty: #CreatingParagraph toValue: true. [ self setDefaultContentsIfNil. "...Code here to recreate the paragraph..." paragraph := (self paragraphClass new textOwner: self owner). paragraph wantsColumnBreaks: successor notNil. paragraph compose: text style: textStyle from: self startingIndex in: self container. wrapFlag ifFalse: ["Was given huge container at first... now adjust" + paragraph adjustRightXDownTo: paragraph caretWidth]. - paragraph adjustRightX]. paragraph focused: (self currentHand keyboardFocus == self). paragraph caretColor: self caretColor; selectionColor: self selectionColor; unfocusedSelectionColor: self unfocusedSelectionColor. self fit. ] ensure: [self removeProperty: #CreatingParagraph]. ^ paragraph!

1 0

The Trunk: Morphic-mt.2024.mcz
by commits＠source.squeak.org 15 Aug '22

15 Aug '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2024.mcz ==================== Summary ==================== Name: Morphic-mt.2024 Author: mt Time: 15 August 2022, 12:46:58.334306 pm UUID: 2fd9a707-6be5-514a-8003-d9575eb99687 Ancestors: Morphic-mt.2023 Fixes minimal width of TextMorph. Adds more commentary to the relevant methods. Thanks to Stef (spfa) for pointing this out! I will backport this to Squeak 6.0. =============== Diff against Morphic-mt.2023 =============== Item was changed: ----- Method: TextMorph>>createParagraph (in category 'private') ----- createParagraph self setProperty: #CreatingParagraph toValue: true. [ self setDefaultContentsIfNil. "...Code here to recreate the paragraph..." paragraph := (self paragraphClass new textOwner: self owner). paragraph wantsColumnBreaks: successor notNil. paragraph compose: text style: textStyle from: self startingIndex in: self container. wrapFlag ifFalse: ["Was given huge container at first... now adjust" + paragraph adjustRightX]. - paragraph adjustRightXDownTo: self minCompositionWidth]. paragraph focused: (self currentHand keyboardFocus == self). paragraph caretColor: self caretColor; selectionColor: self selectionColor; unfocusedSelectionColor: self unfocusedSelectionColor. self fit. ] ensure: [self removeProperty: #CreatingParagraph]. ^ paragraph! Item was changed: ----- Method: TextMorph>>minCompositionHeight (in category 'layout') ----- minCompositionHeight + "Answer the minimal height for the receiver's composited contents. Without linebreaks, this height matches the default font's line grid. Note that we cannot use information from paragraph here, as it would require the text composition to have already happened." ^ (textStyle ifNil: [TextStyle default]) lineGrid! Item was changed: ----- Method: TextMorph>>minCompositionWidth (in category 'layout') ----- minCompositionWidth + "Answer the minimal width for the receiver's composited contents. Without specific content, this width could be zero but matches the default font's example text to avoid composition issues. Note that we cannot use information from paragraph here, as it would require the text composition to have already happened." + self flag: #todo. "mt: Fix issues in CompositionScanner to allow for 0 or at least fit a specific character to match the single-line metric in #minCompositionHeight." ^ ((textStyle ifNil: [TextStyle default]) defaultFont widthOf: $x) * 2! Item was changed: ----- Method: TextMorph>>minHeight (in category 'layout') ----- minHeight + "Answer the minimal height of the receiver to be used in Morphic layout policies. Avoid text composition if there is no paragraph yet to speed up overall layouting and avoid cyclic algorithmic dependencies. The minimal height is basically computed from text-composition metrics and extra decoration such as borders and margins." | result | result := (paragraph ifNil: [self minCompositionHeight] ifNotNil: [:para| para lines first lineHeight]) + (self borderWidth*2). margins ifNil: [^ result]. ^ margins isRectangle ifTrue: [result + margins top + margins bottom] ifFalse: [margins isPoint ifTrue: [result + margins y + margins y] ifFalse: [result + (2*margins)]]! Item was changed: ----- Method: TextMorph>>minWidth (in category 'layout') ----- minWidth + "Answer the minimal width of the receiver to be used in Morphic layout policies. Avoid text composition if there is no paragraph yet to speed up overall layouting and avoid cyclic algorithmic dependencies. The minimal width is basically computed from text-composition metrics and extra decoration such as borders and margins." + - | result | result := self minCompositionWidth + (self borderWidth*2). margins ifNil: [^ result]. ^ margins isRectangle ifTrue: [result + margins left + margins right] ifFalse: [margins isPoint ifTrue: [result + margins x + margins x] ifFalse: [result + (2*margins)]]!

1 0

← Newer
1
...
9
10
11
12
13
14
15
16
Older →

Jump to page: