Squeak-dev May 2022

squeak-dev@lists.squeakfoundation.org

37 participants
316 discussions

The Inbox: PreferenceBrowser-ct.150.mcz
by commits＠source.squeak.org 07 Jul '22

07 Jul '22

A new version of PreferenceBrowser was added to project The Inbox: http://source.squeak.org/inbox/PreferenceBrowser-ct.150.mcz ==================== Summary ==================== Name: PreferenceBrowser-ct.150 Author: ct Time: 20 May 2022, 6:48:44.518499 pm UUID: 3d8cf55a-3022-9643-8df9-fd41f5577848 Ancestors: PreferenceBrowser-mt.149 Proposal: Also search the category list of preferences via the search field. I was so confused that some 'halo' preferences did not appear in the search results. =============== Diff against PreferenceBrowser-mt.149 =============== Item was changed: ----- Method: PreferenceBrowser>>searchPreferencesFor: (in category 'preferences search') ----- searchPreferencesFor: pattern | result | result := pattern asString asLowercase withBlanksTrimmed. result ifEmpty: [^self]. searchResults := self allPreferences select: [:aPreference | ((aPreference name includesSubstring: result caseSensitive: false) or: [aPreference helpString includesSubstring: result caseSensitive: false]) + or: [aPreference codeString includesSubstring: result caseSensitive: false] + or: [aPreference categoryList anySatisfy: [:category | + category includesSubstring: result caseSensitive: false]] ]. - or: [aPreference codeString includesSubstring: result caseSensitive: false] ]. self updateSearchResultsLabel. self selectSearchResultsCategory. self lastExecutedSearch: pattern. !

2 1

Fuel 5.0.5 for Squeak 6
by Max Leske 07 Jul '22

07 Jul '22

Hi all, It's great that you are finally approaching a release. I just checked my repository history and I've had a "SqueakPlatform06" class since February 18, 2018 :). I just updated Fuel to 5.0.5 with some cleanup for Squeak 6 so it should good to go, otherwise, let me know. Cheers, Max

2 1

Modification: do not show Object's methods in protocol browser by default
by Jakob Reschke 07 Jul '22

07 Jul '22

Dear Squeakers, When using the protocol browser, I often exclude the methods inherited from Object because its methods are not interesting to me. On the contrary, they make it harder to find the unique messages of the browsed class's hierarchy. Find attached a patched method that excludes Object automatically. If you think this should enter the Trunk after the release, with or without a preference, let me know. Then I shall post it to the Inbox eventually. Kind regards, Jakob

2 1

Note sharing inside Squeak?
by Jaromir Matas 02 Jul '22

02 Jul '22

Hi all, In your experience, what would be a good place to *share* more detailed information about e.g. a method: like why I had to include this line and that check, which situations must be taken into account, alternative approaches, examples, references to tests etc etc. Ideally reachable from the image. Would such "notesharing" be welcome or rather confusing or even conterproductive? Often I forget why I did this and that and have to check my notes (if I'm lucky to have made them AND find them). I'm aware method comments are definitely not the place; they are meant to be rather terse and polished. Squeak wiki? Squeak Help? They’d have to be linked somehow to the methods, I imagine, to be useful in this regard… Any suggestion welcome :) Best, Jaromir -- Jaromír Matas mail(a)jaromir.net

9 38

Review Request: fix-busyWait-precision.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 02 Jul '22

02 Jul '22

=============== Summary =============== Change Set: fix-busyWait-precision Date: 28 March 2022 Author: Christoph Thiede Fixes #busyWait for durations < 1 milliSecond. Since the original proposal (Chronology-Core-ct.67), the implementation had been moved from Duration to Delay (Chronology-Core-mt.71). However, Delay has only milliseconds precision, causing shorter durations to be handled as a delayDuration of 0 milliSeconds and leading to this erroneous output: [1 microSeconds busyWait] bench '6,240,000 per second. 160 nanoseconds per run. 0.67973 % GC time.' Moves #busyWait implementation back to Duration and invokes it from Delay. Not sure whether we need the latter hook, though. =============== Diff =============== Delay>>busyWait {delaying} · ct 3/28/2022 22:36 (changed) busyWait - "BEWARE! This method is more precise than #wait, but it sacrifices many CPU cycles for that precision. Also note that the GC runs more often. Also note that only processes with a higher priority can run while waiting. - - The following lists the precision (in milliseconds) of #wait on a Microsoft Surface Pro 6, Windows 10 21H1, OSVM 202104182333: - 100 -> 100 - 50 -> 51.1 ... 102.2% - 10 -> 11.6 ... 105.5% ... maybe use #busyWait - 5 -> 5.93 ... 118.6% ... use #busyWait but check process priorities - 1 -> 1.41 ... 141.0% ... use #busyWait but check process priorities - - As of July 2021, the shortest delay that we can guarantee on all platforms is still 1 millisecond as the value of #utcMicrosecondClock might not change any faster than that. For more information, see http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-July/215928.html" - - "[5 milliSeconds busyWait] bench" + "BEWARE! This method is more precise than #wait, but it sacrifices many CPU cycles for that precision. Also note that the GC runs more often. Also note that only processes with a higher priority can run while waiting. See more detailed commentary in Duration >> #busyWait." - | proceedTime | - proceedTime := Time utcMicrosecondClock + (delayDuration "milliseconds" * 1000). - [Time utcMicrosecondClock >= proceedTime] whileFalse. + ^ self delayDuration microSeconds busyWait Duration>>busyWait {squeak protocol} · ct 3/28/2022 22:39 (changed) busyWait - "BEWARE! This method is more precise than #wait, but it sacrifices many CPU cycles for that precision. Also note that only processes with a higher priority can run while waiting. See more detailed commentary in Delay >> #busyWait." + "BEWARE! This method is more precise than #wait, but it sacrifices many CPU cycles for that precision. Also note that the GC runs more often. Also note that only processes with a higher priority can run while waiting. + + The following lists the precision (in milliseconds) of #wait on a Microsoft Surface Pro 6, Windows 10 21H1, OSVM 202104182333: + 100 -> 100 + 50 -> 51.1 ... 102.2% + 10 -> 11.6 ... 105.5% ... maybe use #busyWait + 5 -> 5.93 ... 118.6% ... use #busyWait but check process priorities + 1 -> 1.41 ... 141.0% ... use #busyWait but check process priorities + + As of July 2021, the shortest delay that we can guarantee on all platforms is still 1 millisecond as the value of #utcMicrosecondClock might not change any faster than that. For more information, see http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-July/215928.html" + + "[5 milliSeconds busyWait] bench" - ^ self asDelay busyWait + | proceedTime | + proceedTime := Time utcMicrosecondClock + self asMicroSeconds. + [Time utcMicrosecondClock >= proceedTime] whileFalse. ["fix-busyWait-precision.1.cs"] --- Sent from Squeak Inbox Talk ["fix-busyWait-precision.1.cs"]

7 16

[PSA] Squeak 6.0 | The Dates
by Marcel Taeumel 02 Jul '22

02 Jul '22

Hi all! -- Let's do this. - Feature Freeze on May 6, 23:59 AOE -> 11 days to go - Beta testing until May 15, 23:59 AOE -> 20 days to go - Picking a release candidate until May 18, 23:59 AOE -> 23 days to go The current state of tests can be found here: - https://github.com/squeak-smalltalk/squeak-app/actions - https://github.com/marceltaeumel/squeak-ffi/actions Download the latest squeak-app bundles from here: - http://files.squeak.org/6.0alpha/ - http://files.squeak.org/6.0beta/ (after May 6) - http://files.squeak.org/6.0rc1/ (after May 15) - http://files.squeak.org/6.0rc2/ - ... Please report bugs here on squeak-dev or on GitHub: - https://github.com/squeak-smalltalk/squeak-object-memory/issues After the Feature Freeze, this will happen in the Trunk Update Stream: - Unload 60Deprecated via postload-script - Adapt "SqueakVersion" to keep build number stable - Add "Load deprecated methods" to preference wizard - Update update map to not include 60Deprecated anymore After the release, this will happen in the Trunk Update Stream: - Add new 61Deprecated package - Trunk open for the features again ! Discuss the critical ones via Inbox as usual Meanwhile, the release versions of all packages will be copied over to source.squeak.org/squeak60. Best, Marcel P.S.: Here is the previous info on the release planning: http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-March/219520.ht…

9 37

Older VM's won't start the latest beta images
by Jaromir Matas 25 Jun '22

25 Jun '22

Hi, I wonder what’s changed that the images starting from Squeak6.0beta-21772-64bit on won’t start with the previous release VM (squeak.cog.spur_win64x64_202003021730) or even with pre-release new VMs (e.g. version 3154). I’m on Win10, the process explorer (windows) shortly runs WerFault.exe and than the Squeak process is closed/disappears. Thanks, -- Jaromír Matas mail(a)jaromir.net

4 12

The Inbox: Tools-ct.1147.mcz
by commits＠source.squeak.org 24 Jun '22

24 Jun '22

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1147.mcz ==================== Summary ==================== Name: Tools-ct.1147 Author: ct Time: 26 April 2022, 12:12:36.942702 pm UUID: 11944f29-f575-7b41-824d-71e945afa0d2 Ancestors: Tools-tpr.1146 Updates workspace styles after toggling #shouldStyle preference. This also improves the liveness in the preference wizard. =============== Diff against Tools-tpr.1146 =============== Item was changed: ----- Method: Workspace class>>shouldStyle: (in category 'preferences') ----- shouldStyle: aBoolean + ShouldStyle := aBoolean. + + self allSubInstancesDo: [:workspace | workspace changed: #style].! - ShouldStyle := aBoolean!

4 3

The Trunk: Tools-tpr.1008.mcz
by commits＠source.squeak.org 22 Jun '22

22 Jun '22

tim Rowledge uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tpr.1008.mcz ==================== Summary ==================== Name: Tools-tpr.1008 Author: tpr Time: 25 October 2020, 5:52:09.007789 pm UUID: 2ebe15ce-0c25-4b8d-b993-f1c51203dee5 Ancestors: Tools-tpr.1003, Tools-mt.1007 Rework the window label handing of MessageSet/Trace to be a bit more accurate, and to work within the normal style of labels. Instead of assuming the size of the list passed to the MessageSet/Trace is correct, derive it from the post-processing list. We process the list to remove duplicates, which e.g. the #allUnimplementedCalls method produces. This required adding an instvar to M-Set, removing one from M-Trace, setting the new one properly, dumping some dodgy code that used to half-assedly derive the old one, use the proper #changed: #windowTitle to, y'know, change the title, and some faffing with the messageList. As a result we are better placed to make further improvements if/when we develop a way to correctly hightlight multi-part keywords (or indeed, multiple messages) within a single method, which would greatly improve many browsers. This benefits from being accompanied by the single-method change in the System-tpr.1181 package =============== Diff against Tools-mt.1007 =============== Item was changed: CodeHolder subclass: #MessageSet + instanceVariableNames: 'growable messageList messageListFormatted autoSelectString messageListIndex editSelection windowLabel' - instanceVariableNames: 'growable messageList messageListFormatted autoSelectString messageListIndex editSelection' classVariableNames: 'UseUnifiedMessageLabels' poolDictionaries: '' category: 'Tools-Browser'! !MessageSet commentStamp: '<historical>' prior: 0! I represent a query path of the retrieval result of making a query about methods in the system. The result is a set of methods, denoted by a message selector and the class in which the method was found. As a StringHolder, the string I represent is the source code of the currently selected method. I am typically viewed in a Message Set Browser consisting of a MessageListView and a BrowserCodeView.! Item was changed: ----- Method: MessageSet class>>openMessageList:name:autoSelect: (in category 'instance creation') ----- openMessageList: messageList name: labelString autoSelect: autoSelectString "Open a system view for a MessageSet on messageList. + The labelString is passed to the model to use as a base label, depending on the selection state" - 1/24/96 sw: the there-are-no msg now supplied by my sender" | messageSet | messageSet := self messageList: messageList. + messageSet + autoSelectString: autoSelectString; + setInitialLabel: labelString. + ^ToolBuilder open: messageSet! - messageSet autoSelectString: autoSelectString. - ^ToolBuilder open: messageSet label: labelString! Item was changed: ----- Method: MessageSet>>adjustWindowTitleAfterFiltering (in category 'private') ----- adjustWindowTitleAfterFiltering + "Set the title of the receiver's window, if any, to reflect the just-completed filtering. Avoid re-doing it if fitering is re-done" - "Set the title of the receiver's window, if any, to reflect the just-completed filtering" + (windowLabel endsWith: 'Filtered') + ifFalse: [windowLabel := windowLabel , ' Filtered'. + self changed: #windowTitle]! - | aWindow existingLabel newLabel | - - (aWindow := self containingWindow) ifNil: [^ self]. - (existingLabel := aWindow label) isEmptyOrNil ifTrue: [^ self]. - (((existingLabel size < 3) or: [existingLabel last ~~ $]]) or: [(existingLabel at: (existingLabel size - 1)) isDigit not]) ifTrue: [^ self]. - existingLabel size to: 1 by: -1 do: - [:anIndex | ((existingLabel at: anIndex) == $[) ifTrue: - [newLabel := (existingLabel copyFrom: 1 to: anIndex), - 'Filtered: ', - messageList size printString, - ']'. - ^ aWindow setLabel: newLabel]] - - - ! Item was changed: ----- Method: MessageSet>>initializeMessageList: (in category 'private') ----- initializeMessageList: anArray "Initialize my messageList from the given list of MethodReference or string objects. NB: special handling for uniclasses. Do /not/ replace the elements of anArray if they are already MethodReferences, so as to allow users to construct richer systems, such as differencers between existing and edited versions of code." + messageList := Set new. - messageList := OrderedCollection new. anArray do: [:each | each isMethodReference + ifTrue: [messageList add: each] - ifTrue: [messageList addLast: each] ifFalse: [ MessageSet parse: each toClassAndSelector: + [ : class : sel | class ifNotNil: [ messageList add: (MethodReference class: class selector: sel) ] ] ] ]. + messageList := messageList asOrderedCollection sort. - [ : class : sel | class ifNotNil: [ messageList addLast: (MethodReference class: class selector: sel) ] ] ] ]. "Unify labels if wanted." self class useUnifiedMessageLabels ifTrue: [ messageList withIndexDo: [ : each : index | | cls | cls := each actualClass. each stringVersion: (self indentionPrefixOfSize: (self indentionsIn: each stringVersion)) , (cls ifNil: [each asString] ifNotNil: [cls isUniClass ifTrue: [cls typicalInstanceName, ' ', each selector] ifFalse: [ cls name , ' ' , each selector , ' {' , ((cls organization categoryOfElement: each selector) ifNil: ['']) , '}' , ' {', cls category, '}' ] ]) ] ]. messageListIndex := messageList isEmpty ifTrue: [0] ifFalse: [1]. contents := String empty! Item was changed: ----- Method: MessageSet>>messageListIndex: (in category 'message list') ----- messageListIndex: anInteger + "Set the index of the selected item to be anInteger. + Update the message list morph, the text edit morph and the assorted buttons" - "Set the index of the selected item to be anInteger." messageListIndex := anInteger. contents := messageListIndex ~= 0 ifTrue: [self selectedMessage] ifFalse: ['']. self changed: #messageListIndex. "update my selection" self editSelection: #editMessage. self contentsChanged. (messageListIndex ~= 0 and: [ autoSelectString notNil and: [ self contents notEmpty ] ]) ifTrue: [ self changed: #autoSelect ]. self decorateButtons ! Item was added: + ----- Method: MessageSet>>setInitialLabel: (in category 'accessing') ----- + setInitialLabel: aString + "set the base label for the window, as returned by #windowTitle" + + windowLabel := aString! Item was added: + ----- Method: MessageSet>>windowTitle (in category 'user interface') ----- + windowTitle + "just return the basic label for now" + + ^windowLabel! Item was changed: MessageSet subclass: #MessageTrace + instanceVariableNames: 'autoSelectStrings messageSelections anchorIndex' - instanceVariableNames: 'autoSelectStrings messageSelections anchorIndex defaultSelectString' classVariableNames: '' poolDictionaries: '' category: 'Tools-Browser'! !MessageTrace commentStamp: 'cmm 3/2/2010 20:26' prior: 0! A MessageTrace is a MessageSet allowing efficient sender/implementor message following. With implementors indented below, and senders outdended above, message flow is succinctly expressed, hierarchically. My autoSelectStrings and messageSelections are Arrays of Booleans, parallel to my messageList. Each boolean indicates whether that message is selected. Each autoSelectStrings indicates which string should be highlighted in the code for each method in my messageList.! Item was changed: ----- Method: MessageTrace>>browseAllImplementorsOf: (in category 'actions') ----- browseAllImplementorsOf: selectorSymbol | selectorToBrowse | selectorToBrowse := self selection ifNil: [ selectorSymbol ] + ifNotNil: [ self getImplementorNamed: selectorSymbol asSymbol "since we can get passed literals"]. - ifNotNil: [ self getImplementorNamed: selectorSymbol ]. (self hasUnacceptedEdits or: [ Preferences traceMessages not ]) ifTrue: [ super browseAllImplementorsOf: selectorToBrowse ] ifFalse: [ self addChildMethodsNamed: selectorToBrowse ] ! Item was changed: ----- Method: MessageTrace>>initializeMessageList: (in category 'private initializing') ----- initializeMessageList: anArray - messageSelections := (Array new: anArray size withAll: false) asOrderedCollection. super initializeMessageList: anArray. + messageSelections := (Array new: messageList size withAll: false) asOrderedCollection. self messageAt: messageListIndex beSelected: true. "autoSelectStrings is initialized right after this method, in autoSelectString:" ! Item was changed: ----- Method: MessageTrace>>messageListIndex: (in category 'actions') ----- messageListIndex: anInteger + "Set the index of the selected item to be anInteger. + Find the relevant auto select string to use, do my superclass' work and update the window title" + autoSelectStrings ifNotEmpty: [ autoSelectString := anInteger = 0 + ifTrue: [ "clear the autoSelectString" + String empty ] + ifFalse: [autoSelectStrings at: anInteger] + ]. + + anInteger > 0 ifTrue: [ self + messageAt: anInteger + beSelected: true + ]. + super messageListIndex: anInteger. + self changed: #windowTitle - ifTrue: - [ defaultSelectString ifNotNil: [:default| self containingWindow setLabel: default]. - "clear the autoSelectString" - '' ] - ifFalse: - [ messageListIndex := anInteger. - "setting the window label, below, can't wait for this.." - self containingWindow setLabel: (self windowLabelAt: anInteger). - "work out the string to ask the text view to pre-select. We should do better than this; after all the debugger does" - (autoSelectStrings at: anInteger)] ]. - anInteger > 0 ifTrue: - [ self - messageAt: anInteger - beSelected: true ]. - super messageListIndex: anInteger ! Item was changed: ----- Method: MessageTrace>>windowLabelAt: (in category 'private accessing') ----- windowLabelAt: anInteger + "return a suitable window label when there is an actual list item selected; work out what it should be based upon the array of autoSelectStrings or the current selection" + ^(autoSelectStrings at: anInteger) + ifNil: [ 'Implementors of ', - | str | - defaultSelectString ifNil: - [defaultSelectString := self containingWindow label]. - ^(str := autoSelectStrings at: anInteger) - ifNil: - [ 'Implementors of ', (self class parse: self selection + toClassAndSelector: [ :class :selector | selector ]) + ] + ifNotNil: [:str| 'Senders of ', str ] - toClassAndSelector: [ :class :selector | selector ]) ] - ifNotNil: - [ 'Senders of ', str ] ! Item was added: + ----- Method: MessageTrace>>windowTitle (in category 'building') ----- + windowTitle + "set the window label to suit the selection state; + if no selection, use saved widow label and add the number of items in the messageList + if something is selected, use the relevant string provided by windowLabelAt: which considers the index" + + ^messageListIndex = 0 + ifTrue:[String streamContents: [:str| str nextPutAll: windowLabel; + space; + nextPut: $[; + nextPutAll: messageList size asString; + nextPut: $] + ] + ] + ifFalse: [self windowLabelAt: messageListIndex]!

3 5

The Trunk: Tools-tpr.1155.mcz
by commits＠source.squeak.org 16 Jun '22

16 Jun '22

tim Rowledge uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tpr.1155.mcz ==================== Summary ==================== Name: Tools-tpr.1155 Author: tpr Time: 12 May 2022, 12:49:24.759381 pm UUID: a73844bb-c34b-4398-863e-dc806a623f72 Ancestors: Tools-ct.1153 This allows the 'find class...' dialog to add the recently browser-viewed classes at the top of the list of all classes. =============== Diff against Tools-ct.1153 =============== Item was changed: ----- Method: Browser>>findClass (in category 'system category functions') ----- findClass "Search for a class by name." | foundClass | (self multiWindowState notNil or: [self okToChange]) ifFalse: [^self classNotFound]. + foundClass := Project uiManager chooseClassOrTraitFrom: self environment withRecentList: self recentClassList. - foundClass := UIManager default chooseClassOrTraitFrom: self environment. foundClass ifNil: [^self classNotFound]. (self selectedClass notNil and: [self multiWindowState notNil "Can only support multi-window if original window has all the right panes." and: [self multiWindowState prototype isHierarchy not]]) ifTrue: [(self classList includes: foundClass name) ifTrue: [self multiWindowState copyWindow] ifFalse: [self multiWindowState addNewWindow]]. self selectCategoryForClass: foundClass. self selectClass: foundClass! Item was changed: ----- Method: Browser>>recent (in category 'class list') ----- recent + "Let the user select from a list of recently visited classes" - "Let the user select from a list of recently visited classes. 11/96 stp. - 12/96 di: use class name, not classes themselves. - : dont fall into debugger in empty case" | className class recentList | + recentList := self recentClassList. - recentList := (RecentClasses reject: [:s | s = self selectedClassName]) select: [:n | Smalltalk hasClassNamed: n]. recentList size = 0 ifTrue: [^ Beeper beep]. className := UIManager default chooseFrom: recentList values: recentList. className == nil ifTrue: [^ self]. self okToChange ifFalse: [^ self]. class := Smalltalk at: className. self selectCategoryForClass: class. self classListIndex: (self classListIndexOf: class name)! Item was added: + ----- Method: Browser>>recentClassList (in category 'class list') ----- + recentClassList + + + ^(RecentClasses reject: [:s | s = self selectedClassName]) select: [:n | Smalltalk hasClassNamed: n]!

5 4

← Newer
1
2
3
4
5
6
7
8
9
...
32
Older →

Jump to page: