Squeak-dev May 2022

squeak-dev@lists.squeakfoundation.org

37 participants
316 discussions

The Trunk: CollectionsTests-EG.342.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-EG.342.mcz ==================== Summary ==================== Name: CollectionsTests-EG.342 Author: EG Time: 7 August 2020, 8:18:24.376363 pm UUID: cd08c4bb-0a50-4a33-9fd1-96876f07f3e0 Ancestors: CollectionsTests-ul.341 Adding tests for the updated #peekBack behavior =============== Diff against CollectionsTests-ul.341 =============== Item was added: + ----- Method: ReadStreamTest>>testPeekBack (in category 'tests - back') ----- + testPeekBack + "Test the ability to peek backwards on the stream" + | stream | + stream := ReadStream on: 'abcd'. + stream skip: 2. + self assert: $b equals: stream peekBack! Item was added: + ----- Method: ReadStreamTest>>testPeekBackOnPosition1 (in category 'tests - back') ----- + testPeekBackOnPosition1 + "Ensure that #peekBack works from position 1, + giving us the first element in the stream" + | stream | + stream := ReadStream on: 'abcde'. + stream skip: 1. + self assert: $a equals: stream peekBack! Item was added: + ----- Method: ReadStreamTest>>testPeekBackOnPositionZero (in category 'tests - back') ----- + testPeekBackOnPositionZero + "Ensure that we *cannot* peekBack on a stream + that is currently at the start (zero) position" + | stream | + stream := ReadStream on: 'abcd'. + self + should: [ stream peekBack ] + raise: Error!

1 0

The Trunk: Collections-EG.908.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-EG.908.mcz ==================== Summary ==================== Name: Collections-EG.908 Author: EG Time: 7 August 2020, 8:17:30.343164 pm UUID: d02855a8-a339-4f1d-bede-89a50f07892e Ancestors: Collections-eem.907 Changing behavior of #peekBack to (correctly) return first element of underlying collection when stream position is 1. =============== Diff against Collections-eem.907 =============== Item was changed: ----- Method: PositionableStream>>peekBack (in category 'accessing') ----- peekBack "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." - | element | self position = 0 ifTrue: [self errorCantGoBack]. + element := self back. - self position = 1 ifTrue: [self position: 0. ^ nil]. - self skip: -2. - element := self next. self skip: 1. ^ element!

1 0

The Trunk: System-mt.1348.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1348.mcz ==================== Summary ==================== Name: System-mt.1348 Author: mt Time: 4 May 2022, 10:38:49.758961 am UUID: 55519e3a-266a-8746-be8c-fbabe08dd240 Ancestors: System-mt.1347 Adds Eric Gade (EG) to the list of known contributors. =============== Diff against System-mt.1347 =============== Item was changed: ----- Method: SystemNavigation class>>privateAuthorsRaw (in category 'class initialization') ----- (excessive size, no diff calculated) Item was changed: + (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors.. "Adds Eric Gade"'! - (PackageInfo named: 'System') postscript: 'SystemNavigation initializeAuthors. "Adds Xin Wang"'!

1 0

The Trunk: CollectionsTests-mt.376.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-mt.376.mcz ==================== Summary ==================== Name: CollectionsTests-mt.376 Author: mt Time: 4 May 2022, 10:36:57.297961 am UUID: 73d28e6f-cfbf-484d-baf0-661d3bb3e8e7 Ancestors: CollectionsTests-dtl.375, CollectionsTests-EG.342 Complements Collections-mt.1009 =============== Diff against CollectionsTests-dtl.375 =============== Item was changed: ----- Method: RWBinaryOrTextStreamTest>>testPeekBack (in category 'tests') ----- testPeekBack | stream | stream := RWBinaryOrTextStream on: String new. stream nextPutAll: 'world'. + self assert: $d equals: stream peekBack. - self assert: $l equals: stream peekBack. stream binary. + stream nextPutAll: #[98 105 110 97 114 121]. + self assert: 121 equals: stream peekBack.! - stream nextPutAll: #[98 105 110 97 114 121].. - self assert: 114 equals: stream peekBack.! Item was added: + ----- Method: ReadStreamTest>>testOldPeekBack (in category 'tests - back') ----- + testOldPeekBack + "Test the ability to peek backwards on the stream" + | stream | + stream := ReadStream on: 'abcd'. + stream skip: 2. + self assert: $a equals: stream oldPeekBack! Item was added: + ----- Method: ReadStreamTest>>testOldPeekBackOnPosition1 (in category 'tests - back') ----- + testOldPeekBackOnPosition1 + "Ensure that #peekBack works from position 1, + giving us the first element in the stream" + | stream | + stream := ReadStream on: 'abcde'. + stream skip: 1. + self assert: nil equals: stream oldPeekBack! Item was added: + ----- Method: ReadStreamTest>>testOldPeekBackOnPositionZero (in category 'tests - back') ----- + testOldPeekBackOnPositionZero + "Ensure that we *cannot* peekBack on a stream + that is currently at the start (zero) position" + | stream | + stream := ReadStream on: 'abcd'. + self + should: [ stream oldPeekBack ] + raise: Error! Item was added: + ----- Method: ReadStreamTest>>testPeekBack (in category 'tests - back') ----- + testPeekBack + "Test the ability to peek backwards on the stream" + | stream | + stream := ReadStream on: 'abcd'. + stream skip: 2. + self assert: $b equals: stream peekBack! Item was added: + ----- Method: ReadStreamTest>>testPeekBackOnPosition1 (in category 'tests - back') ----- + testPeekBackOnPosition1 + "Ensure that #peekBack works from position 1, + giving us the first element in the stream" + | stream | + stream := ReadStream on: 'abcde'. + stream skip: 1. + self assert: $a equals: stream peekBack! Item was added: + ----- Method: ReadStreamTest>>testPeekBackOnPositionZero (in category 'tests - back') ----- + testPeekBackOnPositionZero + "Ensure that we *cannot* peekBack on a stream + that is currently at the start (zero) position" + | stream | + stream := ReadStream on: 'abcd'. + self + should: [ stream peekBack ] + raise: Error!

1 0

The Trunk: Collections-mt.1009.mcz
by commits＠source.squeak.org 04 May '22

04 May '22

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.1009.mcz ==================== Summary ==================== Name: Collections-mt.1009 Author: mt Time: 4 May 2022, 10:32:30.135961 am UUID: ef5d326a-a140-794f-b3f4-62097eb357fe Ancestors: Collections-eem.1008, Collections-EG.908 Merges Collections-EG.908. Changing behavior of #peekBack to (correctly) return first element of underlying collection when stream position is 1. The behavior is now on par with Cuis. Also see: http://lists.squeakfoundation.org/pipermail/squeak-dev/2020-August/210935.h… =============== Diff against Collections-eem.1008 =============== Item was added: + ----- Method: PositionableStream>>oldBack (in category 'accessing') ----- + oldBack + "Go back one element and return it. Use indirect messages in case I am a StandardFileStream" + "The method is a misconception about what a stream is. A stream contains a pointer *between* elements with past and future elements. This method considers that the pointer is *on* an element. Please consider unit tests which verifies #back and #oldBack behavior. (Damien Cassou - 1 August 2007)" + self position = 0 ifTrue: [self errorCantGoBack]. + self position = 1 ifTrue: [self position: 0. ^ nil]. + self skip: -2. + ^ self next + ! Item was added: + ----- Method: PositionableStream>>oldPeekBack (in category 'accessing') ----- + oldPeekBack + "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." + + | element | + element := self oldBack. + self skip: 1. + ^ element! Item was changed: ----- Method: PositionableStream>>peekBack (in category 'accessing') ----- peekBack "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." - | element | self position = 0 ifTrue: [self errorCantGoBack]. + element := self back. - self position = 1 ifTrue: [self position: 0. ^ nil]. - self skip: -2. - element := self next. self skip: 1. ^ element!

1 0

The Trunk: Morphic-mt.1974.mcz
by commits＠source.squeak.org 03 May '22

03 May '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1974.mcz ==================== Summary ==================== Name: Morphic-mt.1974 Author: mt Time: 27 April 2022, 4:57:27.371228 pm UUID: bbf92ccb-7fe1-7f4b-9ab6-955f0f2ba601 Ancestors: Morphic-mt.1973 For by-word jumping in text fields, adds LF to the literal array of boundary characters. Thanks to Nicolas (nice) for the hint! =============== Diff against Morphic-mt.1973 =============== Item was changed: ----- Method: SmalltalkEditor>>nextWord: (in category 'private') ----- nextWord: position | string index boundaryCharacters | string := self string. index := position - 1. [ (index between: 1 and: string size) and: [ (string at: index) isSeparator ] ] whileTrue: [ index := index + 1 ]. boundaryCharacters := ')]}''"|^. '. + ((index between: 1 and: string size) and: [ boundaryCharacters includes: (string at: index) ]) ifTrue: [ index := index + 1 ] ifFalse: [ [ (index between: 1 and: string size) and: [ (boundaryCharacters includes: (string at: index)) not ] ] whileTrue: [ index := index + 1 ] ]. ^ index! Item was changed: ----- Method: SmalltalkEditor>>previousWord: (in category 'private') ----- previousWord: position | string index boundaryCharacters | string := self string. index := position. "First, get out of whitespace." [ (index between: 2 and: string size) and: [ (string at: index) isSeparator ] ] whileTrue: [ index := index - 1 ]. boundaryCharacters := '([{''"|^. '. + "Are we at a boundary character?" ((index between: 2 and: string size) and: [ boundaryCharacters includes: (string at: index) ]) ifTrue: [ "yes, select it and any following whitespace of this line." index := index - 1 ] ifFalse: [ "no, select to the next boundary character" [ (index between: 1 and: string size) and: [ (boundaryCharacters includes: (string at: index)) not ] ] whileTrue: [ index := index - 1 ] ]. ^ index + 1!

4 3

The Trunk: Morphic-mt.1981.mcz
by commits＠source.squeak.org 03 May '22

03 May '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1981.mcz ==================== Summary ==================== Name: Morphic-mt.1981 Author: mt Time: 3 May 2022, 4:26:34.106894 pm UUID: 5038458d-6bf5-2649-bcc8-afcd2468c9b2 Ancestors: Morphic-mt.1980 Makes having LF as a word-by-word boundary more robust. Thanks to Nicolas (nice) and Tobias (topa) for pointing this out! =============== Diff against Morphic-mt.1980 =============== Item was changed: TextEditor subclass: #SmalltalkEditor instanceVariableNames: '' + classVariableNames: 'WordBoundariesBackward WordBoundariesForward' - classVariableNames: '' poolDictionaries: '' category: 'Morphic-Text Support'! !SmalltalkEditor commentStamp: 'jmv 8/8/2009 15:10' prior: 0! The editor built specifically for Smalltalk code! Item was changed: + ----- Method: SmalltalkEditor class>>initialize (in category 'class initialization') ----- - ----- Method: SmalltalkEditor class>>initialize (in category 'keyboard shortcut tables') ----- initialize "SmalltalkEditor initialize" + self initializeCmdKeyShortcuts. self initializeShiftCmdKeyShortcuts. self initializeYellowButtonMenu. self initializeShiftedYellowButtonMenu. + + self initializeWordBoundaries.! - ! Item was added: + ----- Method: SmalltalkEditor class>>initializeWordBoundaries (in category 'class initialization') ----- + initializeWordBoundaries + " + self initializeWordBoundaries. + " + + WordBoundariesBackward := '([{''"|^.', + String space, + Character nbsp asString, + String tab, + String cr, + String lf. + + WordBoundariesForward := ')]}''"|^.', + String space, + Character nbsp asString, + String tab, + String cr, + String lf.! Item was changed: ----- Method: SmalltalkEditor>>nextWord: (in category 'private') ----- nextWord: position | string index boundaryCharacters | string := self string. index := position - 1. [ (index between: 1 and: string size) and: [ (string at: index) isSeparator ] ] whileTrue: [ index := index + 1 ]. + boundaryCharacters := WordBoundariesForward. + - boundaryCharacters := ')]}''"|^. - '. - ((index between: 1 and: string size) and: [ boundaryCharacters includes: (string at: index) ]) ifTrue: [ index := index + 1 ] ifFalse: [ [ (index between: 1 and: string size) and: [ (boundaryCharacters includes: (string at: index)) not ] ] whileTrue: [ index := index + 1 ] ]. ^ index! Item was changed: ----- Method: SmalltalkEditor>>previousWord: (in category 'private') ----- previousWord: position | string index boundaryCharacters | string := self string. index := position. "First, get out of whitespace." [ (index between: 2 and: string size) and: [ (string at: index) isSeparator ] ] whileTrue: [ index := index - 1 ]. + boundaryCharacters := WordBoundariesBackward. + - boundaryCharacters := '([{''"|^. - '. - "Are we at a boundary character?" ((index between: 2 and: string size) and: [ boundaryCharacters includes: (string at: index) ]) ifTrue: [ "yes, select it and any following whitespace of this line." index := index - 1 ] ifFalse: [ "no, select to the next boundary character" [ (index between: 1 and: string size) and: [ (boundaryCharacters includes: (string at: index)) not ] ] whileTrue: [ index := index - 1 ] ]. ^ index + 1!

1 0

The Trunk: Multilingual-mt.284.mcz
by commits＠source.squeak.org 03 May '22

03 May '22

Marcel Taeumel uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-mt.284.mcz ==================== Summary ==================== Name: Multilingual-mt.284 Author: mt Time: 3 May 2022, 3:57:44.440894 pm UUID: d99bad9a-22dd-8047-8d7f-fdee9bb937d4 Ancestors: Multilingual-xw.283 More cache clean-up during release building (and squeak-app bundling). =============== Diff against Multilingual-xw.283 =============== Item was added: + ----- Method: LanguageEnvironment class>>cleanUp: (in category 'class initialization') ----- + cleanUp: aggressive + + aggressive ifTrue: [ + KnownEnvironments := nil].!

1 0

Re: [squeak-dev] [Cuis-dev] Bug in Class>>#removeClassVarName:
by Luciano Notarfrancesco 03 May '22

03 May '22

Thanks for taking a look. I cannot reproduce it now, but this is what happened to me: I had a class with two class variables like Object subclass: #X instanceVariableNames: ‘’ classVariableNames: 'A B' poolDictionaries: '' category: 'Test' Then I created class Y with two class variables with the same names A and B. Then I tried to move X to be a subclass of Y removing A and B from the definition of X like: Y subclass: #X instanceVariableNames: ‘’ classVariableNames: '' poolDictionaries: '' category: 'Test' And at this point I would get the dialog asking if I wanted to move them to Undeclared, but no matter what I responded the class variables where not removed from X. So I had to inspect and remove them manually and then recompile all the methods in X. I wish I could reproduce it, I should have saved a copy of the image. Thanks, Luciano On Tue, 3 May 2022 at 7:45 PM Hernan Wilkinson <hernan.wilkinson(a)10pines.com> wrote: > Hi Luciano, (cc'ing Squeak) > it makes sense what you say but I looked at Squeak and Pharo and the > behavior is the same... > I do not know why it does that... there must be a reason. > > Does anybody know why it is implemented that way? (look at Luciano's > email below) > > Cheers! > Hernan. > > On Sat, Apr 30, 2022 at 3:55 AM Luciano Notarfrancesco via Cuis-dev < > cuis-dev(a)lists.cuis.st> wrote: > >> Class>>#removeClassVarName: asks a user for confirmation if the variable >> is still used in some method, and depending on the user answer it moves it >> to Undeclared or leaves it alone. However, it stops there and returns, >> without removing it from the classPool. Shouldn’t it go ahead and continue >> independently of the user response? -- >> Cuis-dev mailing list >> Cuis-dev(a)lists.cuis.st >> https://lists.cuis.st/mailman/listinfo/cuis-dev > > >> > > -- > <https://10pines.com/>Hernán WilkinsonSoftware Developer & Coach > > Alem 896, Floor 6, Buenos Aires, Argentina > > +54 11 6091 3125 > > @HernanWilkinson >

1 0

proposal: MessageSend understands #homeMethod
by Lauren Pullen 03 May '22

03 May '22

Hi List, I think it makes sense that MessageSend understands #homeMethod (used in the debug halo 'browse action code' command). What I'm not sure about is what sorts of things might occur as a MessageSend. Obviously, SimpleServiceEntry uses it for buttons, but I'm not sure how to best handle the dispatch in Smalltalk. Obviously, this included patch only works for services, so it seems of limited use. How would the list handle this?

2 1

Jump to page: