Squeak-dev April 2022

squeak-dev@lists.squeakfoundation.org

29 participants
332 discussions

The Trunk: ToolBuilder-Morphic-tpr.312.mcz
by commits＠source.squeak.org 06 May '22

06 May '22

tim Rowledge uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-tpr.312.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-tpr.312 Author: tpr Time: 19 April 2022, 11:59:19.483381 am UUID: 3b32b25c-7cdf-4307-85af-84b0dfd08f1d Ancestors: ToolBuilder-Morphic-mt.311 Add a ToolBuilder ability to show a list of options - typically a small number, maybe with a cancel button etc - as opposed to an arbitrary list of values. This separates it out from the chooseFrom:... protocol =============== Diff against ToolBuilder-Morphic-mt.311 =============== Item was changed: ----- Method: MorphicUIManager>>chooseFrom:lines:title: (in category 'ui requests') ----- chooseFrom: aList lines: linesArray title: aString "Choose an item from the given list. Answer the index of the selected item. Cancel value is 0. + If you are choosing an option from a short list (see for example ZipArchiveMember>>#extractInDirectory:overwrite:) use MorphicUIManager>>#chooseOptionFrom:lines:title: instead." + self + askForProvidedAnswerTo: aString + ifSupplied: + [:answer | + (answer = #cancel or: [answer isNil]) ifTrue: [^ 0]. + ^ aList indexOf: answer]. - There are several (historical) reasons for building a button dialog instead of a list chooser for small lists: - 1) Unfortunately, there is existing code that uses this call to create simple confirmation dialogs with a list of #(yes no cancel). - 2) Unfortunately, there is existing code that uses this call to mimick a drop-down menu with a (compact) pop-up menu." - self askForProvidedAnswerTo: aString ifSupplied: [:answer | - (answer = #cancel or: [answer isNil]) ifTrue: [^ 0]. - ^ aList indexOf: answer]. - aList ifEmpty: [^ 0]. - aList size <= 7 ifTrue: [ - | dialog | - dialog := DialogWindow new - title: ListChooser defaultTitle; - message: aString; - filterEnabled: true; - autoCancel: true; "Like a pop-up menu, click anywhere to dismiss." - yourself. - aList withIndexDo: [:ea :index | - dialog createButton: ea value: index]. - dialog selectedButtonIndex: 1. - ^ dialog getUserResponseAtHand ifNil: [0]]. - ^ ListChooser chooseFrom: aList title: aString! Item was changed: ----- Method: MorphicUIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString "Choose an item from the given list. Answer the selected item." | index | + self + askForProvidedAnswerTo: aString + ifSupplied: + [:answer | + (answer = #cancel or: [answer isNil]) ifTrue: [^ nil]. + ^ valueList at: (labelList indexOf: answer) ifAbsent: + [answer isNumber + ifTrue: [valueList at: answer ifAbsent: [nil]] + ifFalse: [nil]]]. - self askForProvidedAnswerTo: aString ifSupplied: [:answer | - (answer = #cancel or: [answer isNil]) ifTrue: [^ nil]. - ^ valueList at: (labelList indexOf: answer) ifAbsent: [ - answer isNumber - ifTrue: [valueList at: answer ifAbsent: [nil]] - ifFalse: [nil]]]. index := self chooseFrom: labelList lines: linesArray title: aString. ^ index = 0 ifTrue: [ nil ] ifFalse: [ valueList at: index ]! Item was added: + ----- Method: MorphicUIManager>>chooseOptionFrom:lines:title: (in category 'ui requests') ----- + chooseOptionFrom: aList lines: linesArray title: aString + | dialog | + "Choose an option from the given list. Answer the index of the selected item. Cancel value is 0. + + There are several (historical) reasons for needing a button dialog instead of a list chooser for small lists: + 1) Unfortunately, there is existing code that uses this call to create simple confirmation dialogs with a list of #(yes no cancel). + 2) Unfortunately, there is existing code that uses this call to mimic a drop-down menu with a (compact) pop-up menu. + This method *only* provides the short list UI" + self + askForProvidedAnswerTo: aString + ifSupplied: + [:answer | + (answer = #cancel or: [answer isNil]) ifTrue: [^ 0]. + ^ aList indexOf: answer]. + + aList ifEmpty: [^ 0]. + dialog := DialogWindow new + title: ListChooser defaultTitle; + message: aString; + filterEnabled: true; + autoCancel: true; "Like a pop-up menu, click anywhere to dismiss." + yourself. + aList withIndexDo: + [:ea :index | + dialog createButton: ea value: index]. + dialog selectedButtonIndex: 1. + ^ dialog getUserResponseAtHand ifNil: [0]!

3 5

The Inbox: Compiler-ct.452.mcz
by commits＠source.squeak.org 05 May '22

05 May '22

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-ct.452.mcz ==================== Summary ==================== Name: Compiler-ct.452 Author: ct Time: 13 November 2020, 7:07:30.464415 pm UUID: a40e8327-95c2-f448-8edd-0aa087a5c930 Ancestors: Compiler-eem.451 Reworks public Compiler interface and documentation: - Parser: Do not use #fail in the event of an internal error unless compilation is interactive. This was a single precedent case. - Correct description of compilation error handling: failBlock is *not* evaluated any longer if the requestor is nil since I eliminated the above precedent (I validated that twice). Mention SyntaxErrorNotification explicitly instead of referring to the ToolSet-specific SyntaxError tool. - Provide new convenience selectors #compileNoPattern: and #compileNoPattern:in: on Compiler instance side. - Unify method comment format and phrases. - Ban ST80-specific term "controller" from the argument names. =============== Diff against Compiler-eem.451 =============== Item was changed: ----- Method: Compiler class>>evaluate: (in category 'evaluating') ----- evaluate: textOrString + "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor. + Compilation is carried out with respect to nil, i.e., no object, and the invocation is not logged." - "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. - Compilation is carried out with respect to nil, i.e., no object, and the - invocation is not logged." ^self evaluate: textOrString for: nil! Item was changed: ----- Method: Compiler class>>evaluate:for: (in category 'evaluating') ----- evaluate: textOrString for: anObject + "See Compiler|evaluate:for:notifying:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor." - "See Compiler|evaluate:for:notifying:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil! Item was changed: ----- Method: Compiler class>>evaluate:for:logged: (in category 'evaluating logged') ----- evaluate: textOrString for: anObject logged: logFlag + "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor." - "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil logged: logFlag! Item was changed: ----- Method: Compiler class>>evaluate:for:notifying: (in category 'evaluating') ----- + evaluate: textOrString for: anObject notifying: requestor + "Compile and execute the argument, textOrString with respect to the class of anObject. If a compilation error occurs, use requestor for interactive error correction." - evaluate: textOrString for: anObject notifying: aController - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController." ^ self new evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil]! Item was changed: ----- Method: Compiler class>>evaluate:for:notifying:logged: (in category 'evaluating logged') ----- + evaluate: textOrString for: anObject notifying: requestor logged: logFlag + "Compile and execute the argument, textOrString with respect to the class of anObject. + If a compilation error occurs, use requestor for interactive error correction. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - evaluate: textOrString for: anObject notifying: aController logged: logFlag - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^ self new evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil] logged: logFlag.! Item was changed: ----- Method: Compiler class>>evaluate:in:notifying:logged: (in category 'evaluating logged') ----- + evaluate: textOrString in: anEnvironment notifying: requestor logged: logFlag - evaluate: textOrString in: anEnvironment notifying: aController logged: logFlag "Compile and execute the argument, textOrString in anEnvironment. + If a compilation error occurs, use requestor for interactive error correction. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^ self new evaluate: textOrString in: anEnvironment + notifying: requestor - notifying: aController logged: logFlag.! Item was changed: ----- Method: Compiler class>>evaluate:logged: (in category 'evaluating logged') ----- evaluate: textOrString logged: logFlag + "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is raised rather than notifying any requestor. - "See Compiler|evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. Compilation is carried out with respect to nil, i.e., no object." ^self evaluate: textOrString for: nil logged: logFlag! Item was changed: ----- Method: Compiler class>>evaluate:notifying: (in category 'evaluating') ----- + evaluate: textOrString notifying: requestor + "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController - "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor! - ^self evaluate: textOrString for: nil notifying: aController! Item was changed: ----- Method: Compiler class>>evaluate:notifying:logged: (in category 'evaluating logged') ----- + evaluate: textOrString notifying: requestor logged: logFlag + "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController logged: logFlag - "See Compiler|evaluate:for:notifying:logged:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor logged: logFlag! - ^self evaluate: textOrString for: nil notifying: aController logged: logFlag! Item was changed: ----- Method: Compiler class>>format:in:notifying: (in category 'evaluating') ----- + format: textOrStream in: aClass notifying: requestor + ^self new format: textOrStream in: aClass notifying: requestor! - format: textOrStream in: aClass notifying: aRequestor - ^self new format: textOrStream in: aClass notifying: aRequestor! Item was changed: ----- Method: Compiler class>>format:in:notifying:decorated: (in category 'evaluating') ----- + format: textOrStream in: aClass notifying: requestor decorated: aBoolean + ^self new format: textOrStream in: aClass notifying: requestor decorated: aBoolean! - format: textOrStream in: aClass notifying: aRequestor decorated: aBoolean - ^self new format: textOrStream in: aClass notifying: aRequestor decorated: aBoolean! Item was changed: ----- Method: Compiler>>compile:ifFail: (in category 'public access') ----- compile: aCue ifFail: failBlock + "Answer a MethodNode. + If the cue requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod to be installed in the method dictionary of the class specified by the context." - "Answer a MethodNode. If the MethodNode can not be created, notify - the requestor in the contxt. If the requestor is nil, evaluate failBlock - instead. The MethodNode is the root of a parse tree. It can be told - to generate a CompiledMethod to be installed in the method dictionary - of the class specified by the context." ^self compileCue: aCue noPattern: false + ifFail: failBlock! - ifFail: failBlock ! Item was changed: ----- Method: Compiler>>compile:in:environment:notifying:ifFail: (in category 'public access') ----- + compile: textOrStream in: aClass environment: anEnvironment notifying: requestor ifFail: failBlock + "Answer a MethodNode for the argument, textOrStream. + If requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod to be installed in the method dictionary of the argument, aClass." - compile: textOrStream in: aClass environment: anEnvironment notifying: aRequestor ifFail: failBlock - "Answer a MethodNode for the argument, textOrStream. If the - MethodNode can not be created, notify the argument, aRequestor; if - aRequestor is nil, evaluate failBlock instead. The MethodNode is the root - of a parse tree. It can be told to generate a CompiledMethod to be - installed in the method dictionary of the argument, aClass." ^self compileCue: (CompilationCue source: textOrStream class: aClass environment: anEnvironment + requestor: requestor) - requestor: aRequestor) noPattern: false + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compile:in:notifying:ifFail: (in category 'public access') ----- + compile: textOrStream in: aClass notifying: requestor ifFail: failBlock + "Answer a MethodNode for the argument, textOrStream. + If requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod to be installed in the method dictionary of the argument, aClass." - compile: textOrStream in: aClass notifying: aRequestor ifFail: failBlock - "Answer a MethodNode for the argument, textOrStream. If the - MethodNode can not be created, notify the argument, aRequestor; if - aRequestor is nil, evaluate failBlock instead. The MethodNode is the root - of a parse tree. It can be told to generate a CompiledMethod to be - installed in the method dictionary of the argument, aClass." ^self compileCue: (CompilationCue source: textOrStream class: aClass + requestor: requestor) - requestor: aRequestor) noPattern: false + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compileCue:noPattern:ifFail: (in category 'private') ----- compileCue: aCue noPattern: aBoolean ifFail: failBlock "Answer a MethodNode corresponding to cue source. + If the cue requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted. + The MethodNode is the root of a parse tree. It can be told to generate a CompiledMethod: - If the MethodNode can not be created, notify the cue requestor. - If the cue requestor is nil, evaluate failBlock instead. - The MethodNode is the root of a parse tree. - It can be told to generate a CompiledMethod - either to be evaluated in cue context if aBoolean is true, with cue receiver as method receiver, - or to be installed in the method dictionary of the target class specified by the cue if aBoolean is false." + - self setCue: aCue. ^self translateNoPattern: aBoolean ifFail: failBlock! Item was added: + ----- Method: Compiler>>compileNoPattern: (in category 'public access') ----- + compileNoPattern: textOrStream + + ^ self + compileNoPattern: textOrStream + in: nil class! Item was added: + ----- Method: Compiler>>compileNoPattern:in: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass + + ^ self + compileNoPattern: textOrStream + in: aClass + notifying: nil + ifFail: [^ nil]! Item was changed: ----- Method: Compiler>>compileNoPattern:in:context:environment:notifying:ifFail: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass context: aContext environment: anEnvironment notifying: requestor ifFail: failBlock - compileNoPattern: textOrStream in: aClass context: aContext environment: anEnvironment notifying: aRequestor ifFail: failBlock "Similar to #compile:in:notifying:ifFail:, but the compiled code is expected to be a do-it expression, with no message pattern, and it will be in an explicit environment." ^self compileCue: (CompilationCue source: textOrStream context: aContext class: aClass environment: anEnvironment + requestor: requestor) - requestor: aRequestor) noPattern: true + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compileNoPattern:in:context:notifying:ifFail: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass context: aContext notifying: requestor ifFail: failBlock - compileNoPattern: textOrStream in: aClass context: aContext notifying: aRequestor ifFail: failBlock "Similar to #compile:in:notifying:ifFail:, but the compiled code is expected to be a do-it expression, with no message pattern." ^self compileCue: (CompilationCue source: textOrStream context: aContext class: aClass + requestor: requestor) - requestor: aRequestor) noPattern: true + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compileNoPattern:in:notifying:ifFail: (in category 'public access') ----- + compileNoPattern: textOrStream in: aClass notifying: requestor ifFail: failBlock - compileNoPattern: textOrStream in: aClass notifying: aRequestor ifFail: failBlock "Similar to #compile:in:notifying:ifFail:, but the compiled code is expected to be a do-it expression, with no message pattern." ^self compileCue: (CompilationCue source: textOrStream class: aClass + requestor: requestor) - requestor: aRequestor) noPattern: true + ifFail: failBlock! - ifFail: failBlock - ! Item was changed: ----- Method: Compiler>>compiledMethodFor:in:to:notifying:ifFail: (in category 'public access') ----- + compiledMethodFor: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock + "Compiles the sourceStream into a parse tree, then generates code into a method, and answers it. + If receiver is not nil, then the text can refer to instance variables of that receiver (the Inspector uses this). + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive error correction, and evaluate failBlock after the compilation has been aborted." - compiledMethodFor: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock - "Compiles the sourceStream into a parse tree, then generates code - into a method, and answers it. If receiver is not nil, then the text can - refer to instance variables of that receiver (the Inspector uses this). - If aContext is not nil, the text can refer to temporaries in that context - (the Debugger uses this). If aRequestor is not nil, then it will receive a - notify:at: message before the attempt to evaluate is aborted." | methodNode method | methodNode := self compileNoPattern: textOrStream in: (self classForReceiver: receiver context: aContext) context: aContext + notifying: requestor - notifying: aRequestor ifFail: [^failBlock value]. method := self interactive ifTrue: [ methodNode generateWithTempNames ] ifFalse: [ methodNode generate ]. ^method! Item was changed: ----- Method: Compiler>>compiledMethodFor:in:to:notifying:ifFail:logged: (in category 'public access logging') ----- + compiledMethodFor: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock logged: logFlag + "Compiles the sourceStream into a parse tree, then generates code into a method, and answers it. + If receiver is not nil, then the text can refer to instance variables of that receiver (the Inspector uses this). + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive compilation, and evaluate failBlock after the compilation has been aborted." - compiledMethodFor: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock logged: logFlag - "Compiles the sourceStream into a parse tree, then generates code - into a method, and answers it. If receiver is not nil, then the text can - refer to instance variables of that receiver (the Inspector uses this). - If aContext is not nil, the text can refer to temporaries in that context - (the Debugger uses this). If aRequestor is not nil, then it will receive a - notify:at: message before the attempt to evaluate is aborted." | method | method := self compiledMethodFor: textOrStream in: aContext to: receiver + notifying: requestor - notifying: aRequestor ifFail: [^failBlock value]. logFlag ifTrue: [SystemChangeNotifier uniqueInstance evaluated: cue stringToLog context: aContext]. ^method! Item was changed: ----- Method: Compiler>>evaluate: (in category 'public access') ----- evaluate: textOrString + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor. + Compilation is carried out with respect to nil, i.e., no object, and the invocation is not logged." - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. - Compilation is carried out with respect to nil, i.e., no object, and the - invocation is not logged." ^self evaluate: textOrString for: nil! Item was changed: ----- Method: Compiler>>evaluate:for: (in category 'public access') ----- evaluate: textOrString for: anObject + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor." - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil! Item was changed: ----- Method: Compiler>>evaluate:for:logged: (in category 'public access logging') ----- evaluate: textOrString for: anObject logged: logFlag + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxError is signaled rather than notifying any requestor." - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor." ^self evaluate: textOrString for: anObject notifying: nil logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:for:notifying: (in category 'public access') ----- + evaluate: textOrString for: anObject notifying: requestor + "Compile and execute the argument, textOrString with respect to the class of anObject. If a compilation error occurs, use requestor for interactive compilation." - evaluate: textOrString for: anObject notifying: aController - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController." ^ self evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil]! Item was changed: ----- Method: Compiler>>evaluate:for:notifying:logged: (in category 'public access logging') ----- + evaluate: textOrString for: anObject notifying: requestor logged: logFlag + "Compile and execute the argument, textOrString with respect to the class of anObject. + If a compilation error occurs, use requestor for interactive compilation. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - evaluate: textOrString for: anObject notifying: aController logged: logFlag - "Compile and execute the argument, textOrString with respect to the class - of anObject. If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^ self evaluate: textOrString in: nil to: anObject + notifying: requestor - notifying: aController ifFail: [^nil] logged: logFlag.! Item was changed: ----- Method: Compiler>>evaluate:in:environment:notifying:ifFail:logged: (in category 'public access logging') ----- + evaluate: textOrStream in: aContext environment: anEnvironment notifying: requestor ifFail: failBlock logged: logFlag + "Compiles the sourceStream into a parse tree, then generates code into a method. + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive compilation, and evaluate failBlock after the compilation has been aborted. + Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." - evaluate: textOrStream in: aContext environment: anEnvironment notifying: aRequestor ifFail: failBlock logged: logFlag - "Compiles the sourceStream into a parse tree, then generates code into - a method. If aContext is not nil, the text can refer to temporaries in that - context (the Debugger uses this). If aRequestor is not nil, then it will receive - a notify:at: message before the attempt to evaluate is aborted. Finally, the - compiled method is invoked from here via withArgs:executeMethod:, hence - the system no longer creates Doit method litter on errors." ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: nil class: UndefinedObject environment: anEnvironment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:in:notifying:logged: (in category 'public access logging') ----- + evaluate: textOrString in: anEnvironment notifying: requestor logged: logFlag - evaluate: textOrString in: anEnvironment notifying: aController logged: logFlag "Compile and execute the argument, textOrString in anEnvironment. + If a compilation error occurs, use requestor for interactive compilation. + If both compilation and execution are successful then, if logFlag is true, log (write) the text onto a system changes file so that it can be replayed if necessary." - If a compilation error occurs, notify aController. If both - compilation and execution are successful then, if logFlag is true, log - (write) the text onto a system changes file so that it can be replayed if - necessary." ^self evaluate: textOrString in: nil environment: anEnvironment + notifying: requestor - notifying: aController ifFail: [^nil] logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:in:to:environment:notifying:ifFail:logged: (in category 'public access logging') ----- + evaluate: textOrStream in: aContext to: receiver environment: anEnvironment notifying: requestor ifFail: failBlock logged: logFlag - evaluate: textOrStream in: aContext to: receiver environment: anEnvironment notifying: aRequestor ifFail: failBlock logged: logFlag "Same as #evaluate:in:to:notifying:ifFail:logged: but with an explicit environment" ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: receiver class: (self classForReceiver: receiver context: aContext) environment: anEnvironment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:in:to:notifying:ifFail: (in category 'public access') ----- + evaluate: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock + "Compiles the sourceStream into a parse tree, then generates code into a method. + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive error correction, and evaluate failBlock if the compilation fails. + Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." + - evaluate: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock - "Compiles the sourceStream into a parse tree, then generates code into - a method. If aContext is not nil, the text can refer to temporaries in that - context (the Debugger uses this). If aRequestor is not nil, then it will receive - a notify:at: message before the attempt to evaluate is aborted. Finally, the - compiled method is invoked from here via withArgs:executeMethod:, hence - the system no longer creates Doit method litter on errors." - | theClass | theClass := self classForReceiver: receiver context: aContext. ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: receiver class: theClass environment: theClass environment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock! Item was changed: ----- Method: Compiler>>evaluate:in:to:notifying:ifFail:logged: (in category 'public access logging') ----- + evaluate: textOrStream in: aContext to: receiver notifying: requestor ifFail: failBlock logged: logFlag + "Compiles the sourceStream into a parse tree, then generates code into a method. + If aContext is not nil, the text can refer to temporaries in that context (the Debugger uses this). + If requestor is not nil, use it for interactive compilation, and evaluate failBlock if the compilation fails. + Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." + - evaluate: textOrStream in: aContext to: receiver notifying: aRequestor ifFail: failBlock logged: logFlag - "Compiles the sourceStream into a parse tree, then generates code into - a method. If aContext is not nil, the text can refer to temporaries in that - context (the Debugger uses this). If aRequestor is not nil, then it will receive - a notify:at: message before the attempt to evaluate is aborted. Finally, the - compiled method is invoked from here via withArgs:executeMethod:, hence - the system no longer creates Doit method litter on errors." | theClass | theClass := self classForReceiver: receiver context: aContext. ^self evaluateCue: (CompilationCue source: textOrStream context: aContext receiver: receiver class: theClass environment: theClass environment + requestor: requestor) - requestor: aRequestor) ifFail: failBlock logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:logged: (in category 'public access logging') ----- evaluate: textOrString logged: logFlag + "See evaluate:for:notifying:logged:. If a compilation error occurs, a SyntaxErrorNotification is signaled rather than notifying any requestor. - "See evaluate:for:notifying:logged:. If a compilation error occurs, - a Syntax Error view is created rather than notifying any requestor. Compilation is carried out with respect to nil, i.e., no object." ^self evaluate: textOrString for: nil logged: logFlag! Item was changed: ----- Method: Compiler>>evaluate:notifying: (in category 'public access') ----- + evaluate: textOrString notifying: requestor + "See evaluate:for:notifying:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController - "See evaluate:for:notifying:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor! - ^self evaluate: textOrString for: nil notifying: aController! Item was changed: ----- Method: Compiler>>evaluate:notifying:logged: (in category 'public access logging') ----- + evaluate: textOrString notifying: requestor logged: logFlag + "See evaluate:for:notifying:logged:. Compilation is carried out with respect to nil, i.e., no object." - evaluate: textOrString notifying: aController logged: logFlag - "See evaluate:for:notifying:logged:. Compilation is carried out - with respect to nil, i.e., no object." + ^self evaluate: textOrString for: nil notifying: requestor logged: logFlag! - ^self evaluate: textOrString for: nil notifying: aController logged: logFlag! Item was changed: ----- Method: Compiler>>format:in:notifying: (in category 'public access') ----- + format: textOrStream in: aClass notifying: requestor + "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions." - format: textOrStream in: aClass notifying: aRequestor - "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions" | aNode | self from: textOrStream class: aClass + notifying: requestor. - notifying: aRequestor. aNode := self formatNoPattern: false ifFail: [^ nil]. - - "aSymbol == #colorPrint ifTrue: - [^aNode asColorizedSmalltalk80Text]." "deprecating #colorPrint in favor of Shout --Ron Spengler" - ^aNode decompileString! Item was changed: ----- Method: Compiler>>format:in:notifying:decorated: (in category 'public access') ----- + format: textOrStream in: aClass notifying: requestor decorated: aBoolean + "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions." + - format: textOrStream in: aClass notifying: aRequestor decorated: aBoolean - "Compile a parse tree from the argument, textOrStream. Answer a string containing the original code, formatted nicely. If aBoolean is true, then decorate the resulting text with color and hypertext actions" | aNode | self from: textOrStream class: aClass + notifying: requestor. - notifying: aRequestor. aNode := self formatNoPattern: false ifFail: [^ nil]. ^ aBoolean ifTrue: [aNode decompileText] ifFalse: [aNode decompileString]! Item was changed: ----- Method: Compiler>>parse:in:notifying: (in category 'public access') ----- parse: textOrStream in: aClass notifying: req + "Compile the argument, textOrStream, with respect to the class, aClass, and answer the MethodNode that is the root of the resulting parse tree. If an error occurs, use requestor for interactive error handling." - "Compile the argument, textOrStream, with respect to the class, aClass, and - answer the MethodNode that is the root of the resulting parse tree. Notify the - argument, req, if an error occurs. The failBlock is defaulted to an empty block." self from: textOrStream class: aClass notifying: req. ^self parser parseCue: cue noPattern: false ifFail: []! Item was changed: ----- Method: Parser>>notify:at: (in category 'error handling') ----- notify: string at: location | messageText | messageText := '"' , string , ' ->"'. cue requestor isNil ifTrue: [ | notification | (encoder == self or: [encoder isNil]) + ifTrue: [^ self interactive + ifTrue: [self fail] + ifFalse: [self error: 'failure setting up syntax error']]. - ifTrue: [^ self fail "failure setting up syntax error"]. (notification := SyntaxErrorNotification cue: (cue copy source: (source contents asText copyReplaceFrom: location to: location - 1 with: messageText); yourself) doitFlag: doitFlag errorMessage: string location: location) signal. notification tryNewSourceIfAvailable] ifFalse: [cue requestor notify: messageText at: location in: source]. ^ self fail!

4 3

The Inbox: Morphic-ct.1957.mcz
by commits＠source.squeak.org 05 May '22

05 May '22

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1957.mcz ==================== Summary ==================== Name: Morphic-ct.1957 Author: ct Time: 1 April 2022, 3:58:43.713617 pm UUID: 73b0c9b3-ca79-9945-b668-d92a3548ae44 Ancestors: Morphic-ul.1956 While running step methods, have the world become active. Before, any step methods/deferred UI message would have triggered the #default case in ActiveEventVariable only. =============== Diff against Morphic-ul.1956 =============== Item was changed: ----- Method: PasteUpMorph>>runStepMethods (in category 'stepping') ----- runStepMethods + self becomeActiveDuring: [ + worldState runStepMethodsIn: self].! - worldState runStepMethodsIn: self - !

3 2

The Inbox: Tools-ct.1146.mcz
by commits＠source.squeak.org 05 May '22

05 May '22

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1146.mcz ==================== Summary ==================== Name: Tools-ct.1146 Author: ct Time: 2 April 2022, 6:43:17.222896 pm UUID: 2dd18343-a81d-a142-a2b8-382364160052 Ancestors: Tools-ul.1145 Makes it possible to debug the inactive Morphic UI process from the process browser. Adds #selectedProcess convenience. =============== Diff against Tools-ul.1145 =============== Item was changed: ----- Method: ProcessBrowser class>>registerWellKnownProcesses (in category 'class initialization') ----- registerWellKnownProcesses "Associate each well-known process with a nickname and two flags: allow-stop, and allow-debug. Additional processes may be added to this list as required" WellKnownProcesses := OrderedCollection new. self registerWellKnownProcess: [] label: 'no process' allowStop: false allowDebug: false. self registerWellKnownProcess: [Smalltalk lowSpaceWatcherProcess] label: 'the low space watcher' allowStop: false allowDebug: false. self registerWellKnownProcess: [WeakArray runningFinalizationProcess] label: 'the WeakArray finalization process' allowStop: false allowDebug: false. self registerWellKnownProcess: [Processor activeProcess] label: 'the UI process' allowStop: true allowDebug: true. self registerWellKnownProcess: [Processor backgroundProcess] label: 'the idle process' allowStop: false allowDebug: false. self registerWellKnownProcess: [Sensor interruptWatcherProcess] label: 'the user interrupt watcher' allowStop: false allowDebug: false. self registerWellKnownProcess: [Sensor eventTicklerProcess] label: 'the event tickler' allowStop: false allowDebug: false. self registerWellKnownProcess: [Project uiProcess] label: 'the inactive Morphic UI process' allowStop: true + allowDebug: true. - allowDebug: false. " self registerWellKnownProcess: [Smalltalk at: #SoundPlayer ifPresent: [:sp | sp playerProcess]] label: 'the Sound Player' allowStop: false allowDebug: false." self registerWellKnownProcess: [ScheduledControllers ifNotNil: [ScheduledControllers activeControllerProcess]] label: 'the inactive MVC controller process' allowStop: false allowDebug: true. self registerWellKnownProcess: [Smalltalk at: #CPUWatcher ifPresent: [:cw | cw currentWatcherProcess]] label: 'the CPUWatcher' allowStop: false allowDebug: false ! Item was added: + ----- Method: ProcessBrowser>>selectedProcess (in category 'accessing') ----- + selectedProcess + + self processListIndex = 0 ifTrue: [^ nil]. + ^ self processList at: self processListIndex!

3 2

bad MessageTrace regression (was: The Trunk: Morphic-mt.1652.mcz)
by Chris Muller 05 May '22

05 May '22

Hi Marcel, I'm doing some testing in trunk and just noticed this. When selecting a message in the code pane and browsing senders, **it must always spawn a new MessageTrace** instead of mangling the to the list at the top. The trace at the top is supposed to represent execution flow between the messages in the list, and NOT different random messages that derail the trace and make it a complete mess. I also noticed this has been backported to 5.3. - Chris On Mon, Apr 27, 2020 at 2:32 AM <commits(a)source.squeak.org> wrote: > Marcel Taeumel uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-mt.1652.mcz > > ==================== Summary ==================== > > Name: Morphic-mt.1652 > Author: mt > Time: 27 April 2020, 9:31:57.493264 am > UUID: d23bbde5-4e42-3547-960d-39994fc21f56 > Ancestors: Morphic-ct.1651 > > Fixes regression #browseIt in TraceMessages, too. Now all recent hick-ups > with TraceMessages are gone. There are still some hooks missing such as > #browseAllAccessTo:from:. > > However, I think we should push down those backstops from Object to Model. > > Note that I already backported this fix to Squeak 5.3. > > =============== Diff against Morphic-ct.1651 =============== > > Item was changed: > ----- Method: TextEditor>>browseIt (in category 'menu messages') ----- > browseIt > "Launch a browser for the current selection, if appropriate." > > Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt]. > > self lineSelectAndEmptyCheck: [^ morph flash]. > > "First, try to show all accesses to instance or class variables." > self selectedInstanceVariable ifNotNil: > [:nameToClass | self systemNavigation > browseAllAccessesTo: nameToClass key > from: nameToClass value]. > self selectedClassVariable ifNotNil: > + [:binding | self model browseAllCallsOn: binding]. > - [:binding | self systemNavigation browseAllCallsOn: > binding]. > > "Then, either browse the class (from a binding) or all > implementors of a selector." > self selectedBinding ifNotNil: > [:binding | ^ self systemNavigation browseClass: binding]. > self selectedSelector ifNotNil: > + [:selector | ^ self model browseAllImplementorsOf: > selector]. > - [:selector | ^ self systemNavigation > browseAllImplementorsOf: selector]. > > morph flash! > > >

8 45

[FIX] cleanUpChangeSorterSetMenu
by christoph.thiede＠student.hpi.uni-potsdam.de 05 May '22

05 May '22

Send from MVC. :-) =============== Summary =============== Change Set: cleanUpChangeSorterSetMenu Date: 5 April 2022 Author: Christoph Thiede Cleans up change set menu of change sorter. Remove Morphic-specific hack for controlling the position of Monticello item and split up the main menu to user pragma priorities instead. In particular, this fixes the menuBuilder failure in MVC. =============== Diff =============== ChangeSorter>>monticelloChangeSetMenu: {*Monticello-changeSet menu} · ct 4/5/2022 19:26 (changed) monticelloChangeSetMenu: aMenu <changeSetMenuShifted: false> <menuPriority: 600> - "Sigh, when implementing menu pragmas this is not what I had in mind..." - aMenu add: 'delete Monticello load change sets' action: #deleteMonticelloChangeSets. - (aMenu submorphs - detect: [:m| m isMenuItemMorph and: [m contents beginsWith: 'destroy change set']] - ifNone: []) ifNotNil: - [:destroyItem| | item | - aMenu removeMorph: (item := aMenu submorphs last). - aMenu addMorph: item after: destroyItem]. + aMenu add: 'delete Monticello load change sets' translated action: #deleteMonticelloChangeSets. ^aMenu ChangeSorter>>shiftedChangeSetMenu: {changeSet menu} · ct 4/5/2022 20:26 (changed) shiftedChangeSetMenu: aMenu "Set up aMenu to hold items relating to the change-set-list pane when the shift key is down" <changeSetMenuShifted: true> aMenu title: 'Change set (shifted)' translated. aMenu addStayUpItemSpecial. "CONFLICTS SECTION" aMenu add: 'conflicts with other change sets' translated action: #browseMethodConflicts. aMenu balloonTextForLastItem: 'Browse all methods that occur both in this change set and in at least one other change set.' translated. self changeSetMenuForOpposite: aMenu. aMenu addLine. "CHECKS SECTION" aMenu add: 'check for slips' translated action: #lookForSlips. aMenu balloonTextForLastItem: 'Check this change set for halts and references to Transcript.' translated. aMenu add: 'check for unsent messages' translated action: #checkForUnsentMessages. aMenu balloonTextForLastItem: 'Check this change set for messages that are not sent anywhere in the system' translated. aMenu add: 'check for uncommented methods' translated action: #checkForUncommentedMethods. aMenu balloonTextForLastItem: 'Check this change set for methods that do not have comments' translated. aMenu add: 'check for uncommented classes' translated action: #checkForUncommentedClasses. aMenu balloonTextForLastItem: 'Check for classes with code in this changeset which lack class comments' translated. Utilities authorInitialsPerSe isEmptyOrNil ifFalse: [aMenu add: 'check for other authors' translated action: #checkForAlienAuthorship. aMenu balloonTextForLastItem: ('Check this change set for methods whose current authoring stamp does not start with "{1}"' translated format: {Utilities authorInitials}). aMenu add: 'check for any other authors' translated action: #checkForAnyAlienAuthorship. aMenu balloonTextForLastItem: ('Check this change set for methods any of whose authoring stamps do not start with "{1}"' translated format: {Utilities authorInitials})]. aMenu add: 'check for uncategorized methods' translated action: #checkForUnclassifiedMethods. aMenu balloonTextForLastItem: 'Check to see if any methods in the selected change set have not yet been assigned to a category. If any are found, open a browser on them.' translated. aMenu addLine. aMenu add: 'inspect change set' translated action: #inspectChangeSet. aMenu balloonTextForLastItem: 'Open an inspector on this change set. (There are some details in a change set which you don''t see in a change sorter.)' translated. aMenu add: 'update' translated action: #update. aMenu balloonTextForLastItem: 'Update the display for this change set. (This is done automatically when you activate this window, so is seldom needed.)' translated. aMenu add: 'go to change set''s project' translated action: #goToChangeSetsProject. aMenu balloonTextForLastItem: 'If this change set is currently associated with a Project, go to that project right now.' translated. self changeSetMenuForPromote: aMenu. aMenu add: 'trim history' translated action: #trimHistory. aMenu balloonTextForLastItem: ' Drops any methods added and then removed, as well as renaming and reorganization of newly-added classes. NOTE: can cause confusion if later filed in over an earlier version of these changes' translated. self changeSetMenuForDropInClassCats: aMenu. aMenu add: 'clear this change set' translated action: #clearChangeSet. aMenu balloonTextForLastItem: 'Reset this change set to a pristine state where it holds no information. CAUTION: this is destructive and irreversible!' translated. aMenu add: 'expunge uniclasses' translated action: #expungeUniclasses. aMenu balloonTextForLastItem: 'Remove from the change set all memory of uniclasses, e.g. classes added on behalf of etoys, fabrik, etc., whose classnames end with a digit.' translated. aMenu add: 'uninstall this change set' translated action: #uninstallChangeSet. aMenu balloonTextForLastItem: 'Attempt to uninstall this change set. CAUTION: this may not work completely and is irreversible!' translated. self changeSetMenuForModification: aMenu. - - aMenu addLine. - - aMenu add: 'more...' translated action: #offerUnshiftedChangeSetMenu. - aMenu balloonTextForLastItem: - 'Takes you back to the primary change-set menu.' translated. - + ^ aMenu ChangeSorter>>shiftedChangeSetMore: {changeSet menu} · ct 4/5/2022 20:11 + shiftedChangeSetMore: aMenu + <changeSetMenuShifted: false> + <menuPriority: 1000> + ^ aMenu addTranslatedList: #( + - + ('more...' offerShiftedChangeSetMenu)); + yourself ChangeSorter>>unshiftedChangeSetMenu: {changeSet menu} · ct 4/5/2022 19:24 (changed) unshiftedChangeSetMenu: aMenu "Set up aMenu to hold commands for the change-set-list pane. This could be for a single or double changeSorter" <changeSetMenuShifted: false> Smalltalk isMorphic ifTrue: [aMenu title: 'Change Set' translated] ifFalse: [aMenu title: 'Change Set: ' translated , myChangeSet name]. aMenu addStayUpItemSpecial. aMenu add: 'make changes go to me (m)' translated action: #newCurrent. aMenu addLine. aMenu add: 'new change set... (n)' translated action: #newSet. aMenu add: 'find...(f)' translated action: #findCngSet. aMenu add: 'select change set...' translated action: #chooseCngSet. aMenu addLine. aMenu add: 'rename change set (r)' translated action: #rename. aMenu add: 'file out (o)' translated action: #fileOut. aMenu add: 'mail to list' translated action: #mailOut. aMenu add: 'browse methods (b)' translated action: #browseChangeSet. aMenu add: 'browse change set (B)' translated action: #openChangeSetBrowser. aMenu addLine. parent ifNotNil: [aMenu add: 'copy all to other side (c)' translated action: #copyAllToOther. aMenu add: 'submerge into other side' translated action: #submergeIntoOtherSide. aMenu add: 'subtract other side (-)' translated action: #subtractOtherSide. aMenu addLine]. myChangeSet hasPreamble ifTrue: [aMenu add: 'edit preamble... (p)' translated action: #editPreamble. aMenu add: 'remove preamble' translated action: #removePreamble] ifFalse: [aMenu add: 'add preamble... (p)' translated action: #editPreamble]. myChangeSet hasPostscript ifTrue: [aMenu add: 'edit postscript...' translated action: #editPostscript. aMenu add: 'remove postscript' translated action: #removePostscript] ifFalse: [aMenu add: 'add postscript...' translated action: #editPostscript]. aMenu addLine. aMenu add: 'destroy change set (x)' translated action: #remove. - aMenu addLine. - aMenu add: 'more...' translated action: #offerShiftedChangeSetMenu. ^ aMenu ChangeSorter>>unshiftedChangeSetMore: {changeSet menu} · ct 4/5/2022 20:25 + unshiftedChangeSetMore: aMenu + <changeSetMenuShifted: true> + <menuPriority: 1000> + ^ aMenu addTranslatedList: #( + - + ('more...' offerUnshiftedChangeSetMenu 'Takes you back to the primary change-set menu.')); + yourself ["cleanUpChangeSorterSetMenu.cs.gz"]

2 2

Review Request: toolCodePane.2.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 05 May '22

05 May '22

=============== Summary =============== Change Set: toolCodePane Date: 5 April 2022 Author: Christoph Thiede Improves MVC compatibility for view accesses from model. * Moves up #someTextPaneWithSelector: & friends from StringHolder to Model and improves documentation on the antiidiomatic pattern they represent. * Fixes 'run to selection' & 'tally it' button in MVC debugger. * Improves MVC compatibility in Monticello save version dialog (still, showModally does not yet work, though.) =============== Diff =============== CodeHolder>>searchPane {categories & search pane} · ct 4/5/2022 20:19 (changed) searchPane "Answer the search pane associated with the receiver in its window, or nil if none. Morphic only" - ^ self textPaneWithSelector: #lastSearchString + | pane | + pane := self someTextPaneWithSelector: #lastSearchString. + ^ pane isMorph ifTrue: [pane] Debugger>>codePaneSelectionInterval {code pane} · ct 4/5/2022 19:50 (changed) codePaneSelectionInterval - ^ self codeTextMorph + ^ self codeTextPane ifNotNil: [:cp | cp selectionInterval] ifNil: [Interval from: 0 to: 0] Debugger>>getSelectedText {tally support} · ct 4/5/2022 19:50 (changed) getSelectedText | m interval text | - m := self codeTextMorph ifNil: [^ '']. + m := self codeTextPane ifNil: [^ '']. interval := m selectionInterval. text := m text. ^ text copyFrom: interval first to: interval last Debugger>>tally {tally support} · ct 4/5/2022 19:46 (changed) tally - self codeTextMorph ifNotNil: [:o| o tallyIt] ifNil: [Beeper beep] + self codeTextPane ifNotNil: [:o | o tallyIt] ifNil: [Beeper beep] MCSaveVersionDialog>>accept {actions} · ct 4/5/2022 19:57 (changed) accept | logMessage logMessageWidget | self updateItems. - logMessage := (logMessageWidget := self findTextMorph: #logMessage) text asString. + logMessage := (logMessageWidget := self someTextPaneWithSelector: #logMessage) text asString. (logMessage isEmpty or: [logMessage beginsWith: 'empty log message']) ifTrue: - [(UIManager confirm: 'the log message is empty; are you sure you want to commit') ifFalse: [^ self]] + [(Project uiManager confirm: 'the log message is empty; are you sure you want to commit') ifFalse: [^ self]] ifFalse: [logMessageWidget accept]. self answer: { - (self findTextMorph: #versionName) text asString. + (self someTextPaneWithSelector: #versionName) text asString. logMessage. ignore } MCSaveVersionDialog>>okToClose {actions} · ct 4/5/2022 19:57 (changed) okToClose - ^ (self findTextMorph: #logMessage) + ^ (self someTextPaneWithSelector: #logMessage) ifNil: [true] ifNotNil: [:widget | widget canDiscardEdits or: [self confirm: 'Version notes are not saved. Is it OK to discard those notes?' translated]] Model>>dependentTextPaneWithSelector: {*Tools-private} · ct 4/5/2022 19:42 + dependentTextPaneWithSelector: selector + + ^ self dependents detect: + [:dependent | dependent isTextView and: + [dependent getTextSelector == selector]] + ifNone: [nil] Model>>someTextPaneWithSelector: {*Tools} · ct 4/5/2022 20:17 + someTextPaneWithSelector: aSelector + "Try to find the text pane for aSelector in my dependents or my window. Note that this is a hack only and violates the original idea of the model-view pattern. Usually, the communication should come from the view instead, e.g., via a pluggable selector." + ^ (self dependentTextPaneWithSelector: aSelector) + ifNil: [self textPaneWithSelector: aSelector] Model>>textPaneWithSelector: {*Tools-private} · mt 4/12/2015 19:45 + textPaneWithSelector: aSelector + "If, among my window's paneMorphs, there is a text pane defined with aSelector as its retriever, answer it, else answer nil" + + | aWindow | + Smalltalk isMorphic ifFalse: [^ nil]. + ^ (aWindow := self containingWindow) ifNotNil: + [aWindow paneMorphSatisfying: + [:aMorph | (aMorph isKindOf: PluggableTextMorph) and: + [aMorph getTextSelector == aSelector]]] PluggableTextView>>tallyIt {as yet unclassified} · ct 4/5/2022 19:50 + tallyIt + + self controller tallyIt. StringHolder>>codeTextMorph {*Tools} · ct 4/5/2022 20:16 (changed) codeTextMorph - - ^ self someTextPaneWithSelector: #contents + "Find a Morphic text pane that displays the contents of the receiver. Note that this is a hack only and violates the original idea of the model-view pattern. Using this selector in your model will likely break compatibility with other UI frameworks such as MVC. Usually, the communication should come from the view instead, e.g., via a pluggable selector." + + | textPane | + textPane := self codeTextPane. + ^ textPane isMorph ifTrue: [textPane] StringHolder>>codeTextPane {*Tools} · ct 4/5/2022 20:16 + codeTextPane + "Find a text pane that displays the contents of the receiver. Note that this is a hack only and violates the original idea of the model-view pattern. Usually, the communication should come from the view instead, e.g., via a pluggable selector." + + ^ self someTextPaneWithSelector: #contents StringHolder>>selectedInterval {*services-base} · ct 4/5/2022 19:46 (changed) selectedInterval - ^self codeTextMorph selectionInterval + ^self codeTextPane selectionInterval StringHolderView>>accept {controller access} · ct 4/5/2022 19:59 + accept + + ^ self controller accept StringHolderView>>text {controller access} · ct 4/5/2022 19:56 + text + + ^ self displayContents text ["toolCodePane.2.cs"] --- Sent from Squeak Inbox Talk

2 2

Review Request: mvcLineLengthDialogs.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 05 May '22

05 May '22

=============== Summary =============== Change Set: mvcLineLengthDialogs Date: 5 April 2022 Author: Christoph Thiede Adds a line-length limit to MVC dialogs. Complements Morphic-mt.1935. Due to the recent elimination of #withCRs in many places, this change has been overdue for an even longer time. Example (to be run in an MVC project): self inform: Object comment =============== Diff =============== MVCUIManager>>informUser:during: {ui requests} · ct 4/5/2022 19:14 (changed) - informUser: aString during: aBlock + informUser: aStringOrText during: aBlock "Display a message above (or below if insufficient room) the cursor during execution of the given block. - UIManager default informUser: 'Just a sec!' during: [(Delay forSeconds: 1) wait]. + Project uiManager informUser: 'Just a sec!' during: [1 second wait]. " (SelectionMenu labels: '') displayAt: Sensor cursorPoint - withCaption: aString + withCaption: (aStringOrText ifNotNil: [aStringOrText withNoLineLongerThan: 100]) during: aBlock PopUpMenu>>mvcStartUpWithCaption:icon:at:allowKeyboard: {*ST80-Menus} · ct 4/5/2022 19:10 (changed) mvcStartUpWithCaption: captionOrNil icon: aForm at: location allowKeyboard: aBoolean "Display the menu, with caption if supplied. Wait for the mouse button to go down, then track the selection as long as the button is pressed. When the button is released, Answer the index of the current selection, or zero if the mouse is not released over any menu item. Location specifies the desired topLeft of the menu body rectangle. The final argument indicates whether the menu should seize the keyboard focus in order to allow the user to navigate it via the keyboard." frame ifNil: [self computeForm]. Cursor normal showWhile: [self displayAt: location - withCaption: captionOrNil + withCaption: (captionOrNil ifNotNil: [captionOrNil withNoLineLongerThan: 100]) during: [self controlActivity]]. ^ selection --- Sent from Squeak Inbox Talk ["mvcLineLengthDialogs.1.cs"] ["mvcLineLengthDialogs.png"]

3 3

The Inbox: ToolBuilder-Morphic-ct.286.mcz
by commits＠source.squeak.org 05 May '22

05 May '22

A new version of ToolBuilder-Morphic was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.286.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.286 Author: ct Time: 15 January 2022, 10:19:51.009373 pm UUID: 3c0068e7-ce8e-5f45-8782-34c92bc6ab5f Ancestors: ToolBuilder-Morphic-ct.285 Fixes a nil MNU when interrupting a pluggable dialog. Steps to reproduce (before): 1. Do it: Project uiManager chooseFrom: ((1 to: 10) collect: #asWords). 2. Interrupt/Debug invocation 3. Close/cancel the dialog 4. Abandon the debugger During the unwinding logic, the dialog window would attempt to close itself a second time, neglecting the fact that the model had already been released. Inbox because only 90% sure that this is the right fix. :-) =============== Diff against ToolBuilder-Morphic-ct.285 =============== Item was changed: ----- Method: PluggableDialogWindow>>delete (in category 'submorphs - add/remove') ----- delete + self model ifNil: [^ super delete]. self model okToClose ifFalse: [^ self]. self closeDialogSelector ifNotNil: [:sel | self model perform: sel]. self model windowIsClosing; release. self model: nil. super delete.!

3 7

The Trunk: KernelTests-nice.422.mcz
by commits＠source.squeak.org 05 May '22

05 May '22

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.422.mcz ==================== Summary ==================== Name: KernelTests-nice.422 Author: nice Time: 26 April 2022, 1:03:31.73252 pm UUID: e963a1d7-702a-904d-8b40-8dbf96032f0d Ancestors: KernelTests-nice.421 Complex tests associated with that suggestion: complex arithmetic should detect case of overflow in intermediate computations and fallback to securedely scaled operations if it's the case. =============== Diff against KernelTests-nice.421 =============== Item was changed: ----- Method: ComplexTest>>testDivision1 (in category 'tests') ----- testDivision1 "self run: #testDivision1" "self debug: #testDivision1" | c1 c2 quotient | c1 := 2.0e252 + 3.0e70 i. c2 := c1. quotient := c1 / c2. - self deny: (quotient - 1) isZero. + "This used to fail when / was not protected against floating point overflow in intermediate computations + but it should now work correctly if divideSecureBy: is correctly used as fallback case" + self assert: (quotient - 1) isZero - "This test fails due to the wonders of floating point arithmetic. - Please have a look at Complex>>divideSecureBy: and #divideFastAndSecureBy: - how this can be avoided." ! Item was added: + ----- Method: ComplexTest>>testMultiplyDoesNotOverflow (in category 'tests') ----- + testMultiplyDoesNotOverflow + + | c1 c2 product smallProduct scale | + c1 := (1 + 1 i) sqrt * Float fmax sqrt. + product := c1 squared. + self assert: product real isFinite. + self assert: product imaginary isFinite. + self assert: (product real - Float fmax) / Float fmax ulp < 3. + self assert: (product imaginary - Float fmax) / Float fmax ulp < 3. + + "a more tricky case" + c1 := 1.0 + 0.25 i. + c2 := 1.125+ 0.5 i. + smallProduct := c1 * c2. + "check that we will not overflow in precondition" + self assert: smallProduct real abs <= 1. + self assert: smallProduct imaginary abs <= 1. + "now retry with a large scale" + scale := Float fmax. + product := c1 * scale * c2. + self assert: product real isFinite. + self assert: product imaginary isFinite. + self assert: (scale * smallProduct real - product real) / (scale * smallProduct real) ulp < 3. + self assert: (scale * smallProduct imaginary - product imaginary) / (scale * smallProduct imaginary) ulp < 3.! Item was added: + ----- Method: ComplexTest>>testReciprocalDoesNotOverflow (in category 'tests') ----- + testReciprocalDoesNotOverflow + "Note: intermediate overflow might cause the answer to be zero in careless implementation" + + | c scale cScaled cScaledInv expected | + c := (1 + 1i). + scale := Float fmax. + cScaled := c * scale. + cScaledInv := cScaled reciprocal. + expected := c reciprocal real / scale + (c reciprocal imaginary / scale) i. + self assert: (expected real- cScaledInv real) abs / expected real ulp < 3. + self assert: (expected imaginary - cScaledInv imaginary) abs / expected imaginary ulp < 3.!

3 2

← Newer
1
...
4
5
6
7
8
9
10
...
34
Older →

Jump to page: