Squeak-dev September 2021

squeak-dev@lists.squeakfoundation.org

23 participants
204 discussions

The Inbox: Monticello-ct.729.mcz
by commits＠source.squeak.org 03 Jan '22

03 Jan '22

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-ct.729.mcz ==================== Summary ==================== Name: Monticello-ct.729 Author: ct Time: 17 September 2020, 7:04:53.385813 pm UUID: 5eea47cc-405e-7841-9544-0f57a9b92fa0 Ancestors: Monticello-cmm.726 Proposal: Enhance truncation of "newer versions avaiable" warning (and make it multilingual-ready) =============== Diff against Monticello-cmm.726 =============== Item was changed: ----- Method: MCWorkingCopyBrowser>>checkForNewerVersions (in category 'actions') ----- checkForNewerVersions + "Answer true if there are no newer versions preventing us from saving a version." + | newer | newer := workingCopy possiblyNewerVersionsIn: self repository. + + newer ifEmpty: [^ true]. + + ^ self confirm: ('CAUTION!! {1}:\{2}\Do you really want to save this version?' withCRs translated format: { + newer size = 1 + ifTrue: ['This version in the repository may be newer' translated] + ifFalse: ['These {1} versions in the repository may be newer' translated format: {newer size}]. + (newer size > 3 + ifFalse: [newer] + ifTrue: [(newer first: 3) , {'...'} , {newer last}]) asCommaString withNoLineLongerThan: 150 + })! - ^ newer isEmpty or: [ - self confirm: 'CAUTION!! These versions in the repository may be newer:', - String cr, ((newer asCommaString withNoLineLongerThan: 150) truncateWithElipsisTo: 5 * 149), String cr, - 'Do you really want to save this version?'].!

4 4

False merge conflicts
by Thiede, Christoph 30 Dec '21

30 Dec '21

Hi all, this is not the first time I am receiving a merge conflict resolution window while updating my image even though there is not a real merge conflict: [cid:cdf93b35-01eb-4934-8ba1-bfc8bef8a86d] Did anyone else of you experience similar issues in the past? Is there something wrong with the detection of merge conflicts? Best, Christoph <http://www.hpi.de/>

7 9

(FSPath / 'foo.bar.zot') extension = 'bar.zot'
by Tony Garnock-Jones 29 Dec '21

29 Dec '21

Hi all, Currently: (FSPath / 'foo.bar.zot') extension = 'bar.zot' Should it be? I expected it to equal 'zot'. For reference, in python3: os.path.splitext('foo.bar.zot') == ('foo.bar', '.zot') and in racket (equal? (path-get-extension "foo.bar.zot") #".zot") Tony

8 15

The Inbox: SUnit-ct.125.mcz
by commits＠source.squeak.org 29 Dec '21

29 Dec '21

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.125.mcz ==================== Summary ==================== Name: SUnit-ct.125 Author: ct Time: 29 March 2020, 1:02:50.60056 pm UUID: 814e778e-04dc-954c-93e3-fb19e307d4c8 Ancestors: SUnit-mt.121 Proposal: Update debugging logic of TestCase. Instead of abusing #halt, open a debugger directly on the test selector. Deprecates #openDebuggerOnFailingTestMethod. Also slightly refactors internal behavior to avoid some duplication, and to get rid of unnecessary semaphores which should not add any value compared to #ensure: unless some really low-level things are broken. Please correct me if I am wrong here! =============== Diff against SUnit-mt.121 =============== Item was added: + ----- Method: TestCase>>assureResourcesDuring: (in category 'private') ----- + assureResourcesDuring: aBlock + + | resources | + resources := self resources. + resources do: [:resource | + resource isAvailable ifFalse: [ + ^ resource signalInitializationError]]. + ^ aBlock ensure: [ + resources do: [:resource | + resource reset]].! Item was changed: ----- Method: TestCase>>debug (in category 'running') ----- debug + "Run the receiver and open a debugger on the first failure or error." + + ^ self assureResourcesDuring: [self runCaseWithoutTimeout]! - self resources do: - [ : res | res isAvailable ifFalse: [ ^ res signalInitializationError ] ]. - [ self runCase ] ensure: - [ self resources do: - [ : each | each reset ] ]! Item was changed: ----- Method: TestCase>>debugAsFailure (in category 'running') ----- debugAsFailure + "Spawn a debugger that is ready to debug the receiver." + + (Process + forBlock: [self debug] + runUntil: [:context | context selector = testSelector]) + debug.! - | semaphore | - semaphore := Semaphore new. - self resources do: [:res | - res isAvailable ifFalse: [^res signalInitializationError]]. - [semaphore wait. self resources do: [:each | each reset]] fork. - (self class selector: testSelector) runCaseAsFailure: semaphore.! Item was changed: ----- Method: TestCase>>openDebuggerOnFailingTestMethod (in category 'running') ----- openDebuggerOnFailingTestMethod + + self deprecated: 'ct: Use #debugAsFailure'. + "SUnit has halted one step in front of the failing test method. Step over the 'self halt' and send into 'self perform: testSelector' to see the failure from the beginning" - self halt; performTest! Item was changed: ----- Method: TestCase>>runCaseAsFailure: (in category 'running') ----- runCaseAsFailure: aSemaphore + + self deprecated: 'ct: Use #runCaseWithoutTimeout and #ensure:'. + ^ [self runCaseWithoutTimeout] + ensure: [aSemaphore signal]! - [self setUp. - self openDebuggerOnFailingTestMethod] ensure: [ - self tearDown. - aSemaphore signal]! Item was added: + ----- Method: TestCase>>runCaseWithoutTimeout (in category 'running') ----- + runCaseWithoutTimeout + + [self setUp. + self performTest] + ensure: [self tearDown].!

4 4

The Trunk: System-cmm.1214.mcz
by commits＠source.squeak.org 26 Dec '21

26 Dec '21

Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.1214.mcz ==================== Summary ==================== Name: System-cmm.1214 Author: cmm Time: 5 February 2021, 10:09:05.179247 pm UUID: d6f968d9-a638-42ef-89ef-d37af0f31ffd Ancestors: System-mt.1213 Patch the patcher. Smalltalk run: permits the patching of a production system without having to resort to running a custom image, but when the patch.st file has read-only status in the OS, FileStream class>>#fileNamed:do: can't open it, because it tries to open for read/write. But rather htan signal an error, it silently does nothing (wow), leaving the system unpatched. Patch files can and should be read-only anyway, so use DirectoryEntryFile>>#readStreamDo:. =============== Diff against System-mt.1213 =============== Item was changed: ----- Method: SmalltalkImage>>patchSystem (in category 'command line') ----- patchSystem 'patch.st' asDirectoryEntry ifNotNil: [ : patchEntry | patchEntry modificationTime > Smalltalk imageName asDirectoryEntry modificationTime ifTrue: [ Notification signal: 'Patching system...'. + patchEntry readStreamDo: [ : stream | stream fileIn ] ] - FileStream - fileNamed: 'patch.st' - do: - [ : stream | stream fileIn ] ] ifFalse: [ self error: 'patch.st file is older than the image file. Aborting.' ] ]!

3 5

The semantics of halfway-executed unwind contexts during process termination
by Thiede, Christoph 17 Dec '21

17 Dec '21

Hi all, hi Jaromir, I'm raising a new question in this post that is related to the following threads, but I think that it deserves its own thread due to the fundamental criticism expressed: [1, 2] I just took a closer look at ProcessTest >> #testNestedUnwind and I have to say that I don't agree with it. I'm sorry that I did not mention this earlier, but somehow this aspect of Jaromir's large amount of recent work has escaped my attention before today. For reference, so that we all know what we are talking about, here is the test in question: testNestedUnwind "Test all nested unwind blocks are correctly unwound; all unwind blocks halfway through their execution should be completed or at least attempted to complete, not only the innermost one" | p x1 x2 x3 | x1 := x2 := x3 := false. p := [ [ [ ] ensure: [ "halfway through completion when suspended" [ ] ensure: [ "halfway through completion when suspended" Processor activeProcess suspend. x1 := true]. x2 := true] ] ensure: [ "not started yet when suspended" x3 := true] ] fork. Processor yield. p terminate. self assert: x1 & x2 & x3. I'm not convinced about the assertions in this test. :-) In fact, I would only expect x3 to be true but x1 and x2 to be false! IMHO, when terminating a process, halfway-executed unwinded contexts should not be continued. Only not-yet-activated unwind contexts should be triggered. Here are my arguments: * Regular unwinding and process termination should have exactly the same behavior. Assume we manipulated the example from the test like this: [ [ [ [ ] ensure: [ "halfway through completion when suspended" [ ] ensure: [ "halfway through completion when suspended" self error. x1 := true]. x2 := true] ] ensure: [ "not started yet when suspended" x3 := true] ] on: Error do: [] ] fork. I have highlighted the differences, so what I changed was i) to insert an error handler at the bottom of the process and ii) instead of terminating the process, to raise an error in the innermost block. In this example, only x3 will be set to true which is because the exceptional control flow explicitly discontinues the logic running inside the error handler. Only not-yet-activated unwind contexts will be triggered as part of the unwinding, which only applies to the outermost unwind context. In my view, process termination should have exactly the same semantics as using an exception to abort the control flow. If we would not catch the error in the above example but press Abandon in the appearing debugger instead, I see no reason why we would want to execute a different set of unwind contexts. * Last but not least, the fact that an error has been signaled means that the signalerContext is "infected" so under no circumstances, abandoning the process should resume the execution of this infected context! (The only exception is when you consciously do so via the "Proceed" button in a debugger.) This might become more vivid if I replace the innermost block with the following: x1 := (2 / 0 "error!") > 0. Actually, it is enough to run the following stand-alone: [] ensure: [ x1 := (2 / 0 "error!") > 0 ] If you debug the Abandon button, you can see that another error occurs while terminating the process, which is a MessageNotUnderstood for #> in ZeroDivision. The only reason why a second debugger does not appear is the current bug in Process >> #terminate which "absorbs" subsequent error in this situation and which is currently being discussed in [2]. Sorry for the long message! I hope that you agree with my arguments, and if not, I am very excited to hear your ones. :-) Unless contradicted, I would like to request to change #testNestedUnwind as described above and use the changed version as the general basis for the ongoing discussions in [1, 2]. But maybe I am also just committing a fatal case of false reasoning ... :-) Best, Christoph [1] http://forum.world.st/The-Inbox-Kernel-ct-1405-mcz-td5129706.html [2] http://forum.world.st/stepping-over-non-local-return-in-a-protected-block-t…

7 17

The Trunk: Morphic-mt.1777.mcz
by commits＠source.squeak.org 10 Dec '21

10 Dec '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1777.mcz ==================== Summary ==================== Name: Morphic-mt.1777 Author: mt Time: 21 July 2021, 10:52:27.461807 am UUID: 7889f198-c567-42b5-86b7-6ec550f79355 Ancestors: Morphic-mt.1776 Complements System-mt.1240 =============== Diff against Morphic-mt.1776 =============== Item was changed: ----- Method: SmalltalkEditor>>styleSelection (in category 'do-its') ----- styleSelection | styler | self lineSelectAndEmptyCheck: [^ '']. + styler := self styler ifNil: [(TextStyler for: #Smalltalk) new]. - styler := self styler ifNil: [(Smalltalk classNamed: #SHTextStylerST80) new]. ^ styler styledTextFor: self selection!

2 1

Changeset: fix-generic-inspectOne-with-truncation.cs
by Thiede, Christoph 08 Dec '21

08 Dec '21

Hi all! Jan Ehmueller and Fabio (fn) have discovered an Inspector bug with #inspectOne/"inspect element..." in the field list menu that hindered users from entering the index of a truncated element in the inspect element dialog. Possible ways to reproduce the issue include: * Inspector openOn: (Array new: 1024) -> … -> Click -> 90 -> Enter * (SmalltalkImage>>#snapshot:andQuit:withExitCode:embedded:) inspect -> right click self -> inspect element... -> 450 -> Enter (might depend on Sista) * TruffleSqueak was also affected: https://github.com/hpi-swa/trufflesqueak/issues/143 The attached changeset attempts to fix the bug. Changelog: Problem: The variant of Inspector >> #inspectOne, as it is now in the trunk, fails if the key is the value for a field that has been truncated. Because in this place, explicitly only the keys of self fields are passed to #inspectOneOf: which are already truncated. The bug does not affect CollectionInspectors which passes the elementIndices directly to #inspectOneOf: without the need of having fields. Solution: I have now essentially pushed this logic from CollectionInspector with #elementIndices up to Inspector. This should make it run again. Please review and merge if you don't have any further objections. :-) Best, Christoph

3 3

Changeset: MimeDocument>>url
by Thiede, Christoph 08 Dec '21

08 Dec '21

Hi all, this changeset is really (!) small, but it fixes an implicit reference from Network on MorphicExtras because WebUtils class >> #encodeMultipartForm:boundary: accesses the URL of every MIMEDocument. I only recategorized this one selector. Could someone with Trunk permissions please merge this into the Trunk? :-) Thanks in advance, Christoph

2 1

Changeset: Deprecate SyntaxErrorNotification >> #errorMessage
by Thiede, Christoph 08 Dec '21

08 Dec '21

Hi all, please have a look at the attached changeset. It deprecates the IMO redundant instance variable 'errorMessage' in SyntaxErrorNotification and uses super's 'messageText' instead. The two single senders in the Trunk image are patched as well. I wonder at all how the usage in DecompilerTests could have worked before, giving the prior implementation of #messageText in SyntaxErrorNotification ... Please review and merge if you like it. Best, Christoph

2 1

← Newer
1
2
3
4
5
6
7
8
9
...
21
Older →

Jump to page: