Squeak-dev July 2021

squeak-dev@lists.squeakfoundation.org

25 participants
179 discussions

(ReadWriteStream on: #(1)) next ... nil?
by Marcel Taeumel 05 Jul '21

05 Jul '21

Hi all! Does anybody know whether it would be dangerous to set the readLimit when initializing a ReadWriteStream? PositionableStream does this. WriteStream overrides this explicitely. ReadWriteStream is a WriteStream. Example: (ReadWriteStream on: #(1)) next I am asking because our most famous R/W stream is RWBinaryOrTextStream. :-) Best, Marcel

2 1

The Trunk: Chronology-Core-dtl.67.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

David T. Lewis uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-dtl.67.mcz ==================== Summary ==================== Name: Chronology-Core-dtl.67 Author: dtl Time: 3 July 2021, 5:38:37.488688 pm UUID: 142336d9-cfb5-476e-ba15-a8daf9aad710 Ancestors: Chronology-Core-dtl.66 Cruft removal. DateAndTime no longer needs to be in the startUp list. The canInitializeFromPrimitive workaround is no longer needed. Do not use the no-argument call to primitiveUtcWithOffset, which works fine but is easier to understand in the image if we always use a single primitive interface. =============== Diff against Chronology-Core-dtl.66 =============== Item was changed: Magnitude subclass: #DateAndTime instanceVariableNames: 'utcMicroseconds localOffsetSeconds' + classVariableNames: 'AutomaticTimezone ClockProvider LocalTimeZone PosixEpochJulianDays' - classVariableNames: 'AutomaticTimezone ClockProvider InitializeFromPrimitive LocalTimeZone PosixEpochJulianDays' poolDictionaries: 'ChronologyConstants' category: 'Chronology-Core'! !DateAndTime commentStamp: 'dtl 3/12/2016 10:32' prior: 0! I represent a point in UTC time as defined by ISO 8601. I have zero duration. My implementation uses variables utcMicroseconds and localOffsetSeconds. This represents time magnitude as elapsed microseconds since the Posix epoch, with localOffsetSeconds representing local offset from UTC. The magnitude is used for comparison and duration calculations, and the local offset is used for displaying this magnitude in the context of a local time zone. The implementation ignores leap seconds, which are adjustments made to maintain earth rotational clock time in synchronization with elapsed seconds. DateAndTime class>>now will use #primitiveUtcWithOffset to obtain current time in UTC microseconds with current local offset in seconds. The primitive provides an atomic query for UTC time and local offset as measured by the OS platform. If primitiveUtcWithOffset is not available, the traditional implementation is used, which relies on a primitive for microseconds in the local time zone and derives UTC based on the TimeZone setting. ! Item was removed: - ----- Method: DateAndTime class>>canInitializeFromPrimitive (in category 'system startup') ----- - canInitializeFromPrimitive - "Some implementations of primitiveUtcWithOffset do not support passing the - DateAndTime instance as a parameter to the primitive." - - ^self basicNew initializeFromPrimitive utcMicroseconds notNil! Item was changed: ----- Method: DateAndTime class>>initialize (in category 'initialize-release') ----- initialize ClockProvider := Time. + PosixEpochJulianDays := 2440588.! - PosixEpochJulianDays := 2440588. - InitializeFromPrimitive := self canInitializeFromPrimitive. - Smalltalk addToStartUpList: self. - self startUp: true - ! Item was changed: ----- Method: DateAndTime class>>now (in category 'ansi protocol') ----- now "Answer time now as reported by #primitiveUtcWithOffset. If the primitive is not available, answer the Posix epoch GMT." self automaticTimezone + ifTrue: [ ^ self basicNew initializeFromPrimitive ] - ifTrue: [ InitializeFromPrimitive - ifTrue: [ ^ self basicNew initializeFromPrimitive ] - ifFalse: [ | timeArray | - timeArray := Time posixMicrosecondClockWithOffset. - ^ self utcMicroseconds: timeArray first offset: timeArray second ] ] ifFalse: [ | timeArray | timeArray := Time posixMicrosecondClockWithOffset. ^ self utcMicroseconds: timeArray first offset: self localOffsetSeconds ] ! Item was removed: - ----- Method: DateAndTime class>>startUp: (in category 'system startup') ----- - startUp: startingAfresh - "Set local timezone" - startingAfresh - ifTrue: [InitializeFromPrimitive := self canInitializeFromPrimitive. - Time initialize. "set LastClockTick to 0". - self now]! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset (in category 'clock') ----- posixMicrosecondClockWithOffset "Answer an array with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." | array posixUtcValue | + array := self primPosixMicrosecondClockWithOffset: (Array new: 2). - array := self primPosixMicrosecondClockWithOffset. posixUtcValue := array at: 1. (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." self primPosixMicrosecondClockWithOffset: array. posixUtcValue := array at: 1 ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ array] . [#monotonicAllowDuplicates] -> [ posixUtcValue > LastClockTick ifTrue: [LastClockTick := posixUtcValue] ifFalse: [array at: 1 put: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ posixUtcValue > LastClockTick ifTrue: [LastClockTick := posixUtcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" array at: 1 put: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ posixUtcValue > LastClockTick ifTrue: [LastClockTick := posixUtcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" array at: 1 put: LastClockTick]] } otherwise: []. ^array! Item was removed: - ----- Method: Time class>>primPosixMicrosecondClockWithOffset (in category 'private') ----- - primPosixMicrosecondClockWithOffset - "Answer an array with UTC microseconds since the Posix epoch and the - current seconds offset from GMT in the local time zone. If the primitive is - not available, then answer the time and offset of Posix epoch GMT. This enables - the image to continue running in the absence of #primitiveUtcWithOffset, thus - avoiding the need to fallback code based on the earlier local microsecond clock - mechanism." - - <primitive: 'primitiveUtcWithOffset'> - ^{0. 0}! Item was changed: + ----- Method: Time class>>primPosixMicrosecondClockWithOffset: (in category 'clock') ----- - ----- Method: Time class>>primPosixMicrosecondClockWithOffset: (in category 'private') ----- primPosixMicrosecondClockWithOffset: arrayOrObjectWithTwoSlots "Answer an array with UTC microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone. If the primitive is not available, then answer the time and offset of Posix epoch GMT. This enables the image to continue running in the absence of #primitiveUtcWithOffset, thus avoiding the need to fallback code based on the earlier local microsecond clock mechanism. The parameter may be a two element array, or an object whose first two instance variables are expected to be UTC microseconds and seconds offset from GMT." <primitive: 'primitiveUtcWithOffset'> (arrayOrObjectWithTwoSlots instVarAt: 1) ifNil: [arrayOrObjectWithTwoSlots instVarAt: 1 put: 0]. (arrayOrObjectWithTwoSlots instVarAt: 2) ifNil: [arrayOrObjectWithTwoSlots instVarAt: 2 put: 0]! Item was changed: + (PackageInfo named: 'Chronology-Core') postscript: 'Smalltalk removeFromStartUpList: DateAndTime'! - (PackageInfo named: 'Chronology-Core') postscript: '"Make sure UpdateVMTimeZoneCacheAt of Time is initialized." - Time classPool at: #UpdateVMTimeZoneCacheAt put: 0. - "Separated Time''s startup duties from DateAndTime." - Smalltalk addToStartUpList: Time before: DateAndTime'!

4 4

The Trunk: Collections-mt.952.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.952.mcz ==================== Summary ==================== Name: Collections-mt.952 Author: mt Time: 5 July 2021, 11:33:42.546805 am UUID: f848913c-5ee8-e349-8b6d-3646fb60c7b0 Ancestors: Collections-ct.951 Now that the simple/faster version of #take: was pushed down to ReadStream, do the same for ReadWriteStream. Note that we still have to figure out whether we can set the readLimit from the beginning in those ReadWriteStreams. Also see: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-June/215910.html http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-July/215958.html =============== Diff against Collections-ct.951 =============== Item was added: + ----- Method: ReadWriteStream>>take: (in category 'collections - accessing') ----- + take: maxNumberOfElements + "Overridden for efficiency." + + ^ self next: maxNumberOfElements!

1 0

The Trunk: Morphic-ct.1632.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.1632.mcz ==================== Summary ==================== Name: Morphic-ct.1632 Author: ct Time: 29 February 2020, 11:29:22.475896 am UUID: 2d941b38-6604-cb43-bfbb-b7751aa2d55c Ancestors: Morphic-mt.1631 Proposal: In Morph>>#balloonText, also try to invoke balloonSelector on model. =============== Diff against Morphic-mt.1631 =============== Item was changed: ----- Method: Morph>>balloonText (in category 'accessing') ----- balloonText + "Answer balloon help text or nil, if no help is available." + "NB: subclasses may override such that they programatically construct the text, for economy's sake, such as model phrases in a Viewer." - "Answer balloon help text or nil, if no help is available. - NB: subclasses may override such that they programatically - construct the text, for economy's sake, such as model phrases in - a Viewer" + | balloonSelector | + extension ifNil: [^ nil]. - | result | - extension ifNil: [^nil]. extension balloonText + ifNotNil: [:balloonText | ^ balloonText]. + balloonSelector := extension balloonTextSelector + ifNil: [^ nil]. + (ScriptingSystem helpStringOrNilFor: balloonSelector) + ifNotNil: [:result | ^ result]. + balloonSelector == #methodComment + ifTrue: [^ self methodCommentAsBalloonHelp]. + balloonSelector isUnary + ifTrue: [ + (self respondsTo: balloonSelector) + ifTrue: [^ self perform: balloonSelector]. + (self model respondsTo: balloonSelector) + ifTrue: [^ self model perform: balloonSelector]]. + ^ nil! - ifNotNil: [:balloonText | result := balloonText] - ifNil: [extension balloonTextSelector - ifNotNil: [:balloonSelector | - result := ScriptingSystem helpStringOrNilFor: balloonSelector. - (result isNil and: [balloonSelector == #methodComment]) - ifTrue: [result := self methodCommentAsBalloonHelp]. - ((result isNil and: [balloonSelector numArgs = 0]) - and: [self respondsTo: balloonSelector]) - ifTrue: [result := self perform: balloonSelector]]]. - ^ result!

1 0

The Trunk: Morphic-mt.1776.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1776.mcz ==================== Summary ==================== Name: Morphic-mt.1776 Author: mt Time: 5 July 2021, 11:27:15.873805 am UUID: bd3f9f78-4d29-9c42-924f-b62ea426fa90 Ancestors: Morphic-mt.1775, Morphic-ct.1632 Merges Morphic-ct.1632. In Morph>>#balloonText, also try to invoke balloonSelector on model. =============== Diff against Morphic-mt.1775 =============== Item was changed: ----- Method: Morph>>balloonText (in category 'accessing') ----- balloonText + "Answer balloon help text or nil, if no help is available." + "NB: subclasses may override such that they programatically construct the text, for economy's sake, such as model phrases in a Viewer." - "Answer balloon help text or nil, if no help is available. - NB: subclasses may override such that they programatically - construct the text, for economy's sake, such as model phrases in - a Viewer" + | balloonSelector | + extension ifNil: [^ nil]. - | result | - extension ifNil: [^nil]. extension balloonText + ifNotNil: [:balloonText | ^ balloonText]. + balloonSelector := extension balloonTextSelector + ifNil: [^ nil]. + (ScriptingSystem helpStringOrNilFor: balloonSelector) + ifNotNil: [:result | ^ result]. + balloonSelector == #methodComment + ifTrue: [^ self methodCommentAsBalloonHelp]. + balloonSelector isUnary + ifTrue: [ + (self respondsTo: balloonSelector) + ifTrue: [^ self perform: balloonSelector]. + (self model respondsTo: balloonSelector) + ifTrue: [^ self model perform: balloonSelector]]. + ^ nil! - ifNotNil: [:balloonText | result := balloonText] - ifNil: [extension balloonTextSelector - ifNotNil: [:balloonSelector | - result := ScriptingSystem helpStringOrNilFor: balloonSelector. - (result isNil and: [balloonSelector == #methodComment]) - ifTrue: [result := self methodCommentAsBalloonHelp]. - ((result isNil and: [balloonSelector numArgs = 0]) - and: [self respondsTo: balloonSelector]) - ifTrue: [result := self perform: balloonSelector]]]. - ^ result!

1 0

The Trunk: Morphic-ct.1659.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.1659.mcz ==================== Summary ==================== Name: Morphic-ct.1659 Author: ct Time: 16 May 2020, 8:48:50.198708 pm UUID: 49bbe6f6-5242-1b41-9823-d21b50d6b438 Ancestors: Morphic-nice.1658 Proposal: Have windows' menu box act on mouseDown rather than on mouseUp like the other boxes. This saves you another click and is more consistent to the usual menu flow in Squeak. =============== Diff against Morphic-nice.1658 =============== Item was changed: ----- Method: SystemWindow>>createMenuBox (in category 'initialization') ----- createMenuBox ^ (self createBox: self class menuBoxImage) actionSelector: #offerWindowMenu; + setBalloonText: 'window menu' translated; + actWhen: #buttonDown; + yourself! - setBalloonText: 'window menu' translated!

1 0

The Trunk: CollectionsTests-ct.361.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ct.361.mcz ==================== Summary ==================== Name: CollectionsTests-ct.361 Author: ct Time: 30 June 2021, 1:06:31.83741 am UUID: b30fd619-d876-9f46-bfcf-d233d25b17ed Ancestors: CollectionsTests-nice.354 Tests Generator(Stream) >> #take: which currently returns superfluous nil values if the generator does not have enough elements. Will be fixed with Collections-ct.950! =============== Diff against CollectionsTests-nice.354 =============== Item was added: + ----- Method: GeneratorTest>>testTake (in category 'tests') ----- + testTake + + | generator | + generator := self numbersBetween: 1 and: 3. + self assert: #(1 2) equals: (generator take: 2) asArray. + self assert: #(3) equals: (generator take: 2) asArray!

1 0

The Trunk: Collections-ct.951.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.951.mcz ==================== Summary ==================== Name: Collections-ct.951 Author: ct Time: 30 June 2021, 11:28:40.378415 pm UUID: 20041ac2-26ea-5547-a7df-b98ad4b192d6 Ancestors: Collections-mt.945 Fixes Stream >> #take:. Unlike in #any:, we must not return nil values from #next here but the enumeration earlier. However, we can keep the fast behavior for ReadStreams in which #next: automatically stops the enumeration at the end of the receiver. See CollectionsTests-ct.361. Supersedes Collections-ct.950. Thanks to Marcel for the fast review! =============== Diff against Collections-mt.945 =============== Item was added: + ----- Method: ReadStream>>take: (in category 'collections - accessing') ----- + take: maxNumberOfElements + "Overridden for efficiency." + + ^ self next: maxNumberOfElements! Item was changed: ----- Method: Stream>>take: (in category 'collections - accessing') ----- take: maxNumberOfElements "See Collection protocol." + + | aCollection | + aCollection := OrderedCollection new. + maxNumberOfElements timesRepeat: [ + self atEnd ifTrue: [^ aCollection]. + aCollection addLast: self next]. + ^ aCollection! - - ^ self any: maxNumberOfElements!

1 0

The Trunk: Regex-Tests-Core-ct.12.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Regex-Tests-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Tests-Core-ct.12.mcz ==================== Summary ==================== Name: Regex-Tests-Core-ct.12 Author: ct Time: 2 July 2021, 12:26:34.898367 am UUID: 33dec413-cb00-b443-a1ed-58901ccd0742 Ancestors: Regex-Tests-Core-ct.11 Extends quantifier tests to reveal a bug that only occurs with min=3: 'aa' matchesRegex: 'a{3,}' true Fixed in Regex-Core-ct.59. =============== Diff against Regex-Tests-Core-ct.11 =============== Item was changed: ----- Method: RxParserTest>>testQuantifier (in category 'tests') ----- testQuantifier + self deny: ('' matchesRegex: 'a{3}'). + self deny: ('a' matchesRegex: 'a{3}'). + self deny: ('aa' matchesRegex: 'a{3}'). + self assert: ('aaa' matchesRegex: 'a{3}'). + self deny: ('aaaa' matchesRegex: 'a{3}'). - self deny: ('' matchesRegex: 'a{2}'). - self deny: ('a' matchesRegex: 'a{2}'). - self assert: ('aa' matchesRegex: 'a{2}'). - self deny: ('aaa' matchesRegex: 'a{2}'). + self deny: ('' matchesRegex: 'a{3,4}'). + self deny: ('a' matchesRegex: 'a{3,4}'). + self deny: ('aa' matchesRegex: 'a{3,4}'). + self assert: ('aaa' matchesRegex: 'a{3,4}'). + self assert: ('aaaa' matchesRegex: 'a{3,4}'). + self deny: ('aaaaa' matchesRegex: 'a{3,4}'). - self deny: ('' matchesRegex: 'a{2,3}'). - self deny: ('a' matchesRegex: 'a{2,3}'). - self assert: ('aa' matchesRegex: 'a{2,3}'). - self assert: ('aaa' matchesRegex: 'a{2,3}'). - self deny: ('aaaa' matchesRegex: 'a{2,3}'). + self deny: ('' matchesRegex: 'a{3,}'). + self deny: ('a' matchesRegex: 'a{3,}'). + self deny: ('aa' matchesRegex: 'a{3,}'). + self assert: ('aaa' matchesRegex: 'a{3,}'). + self assert: ('aaaa' matchesRegex: 'a{3,}'). + self assert: ('aaaaa' matchesRegex: 'a{3,}'). - self deny: ('' matchesRegex: 'a{2,}'). - self deny: ('a' matchesRegex: 'a{2,}'). - self assert: ('aa' matchesRegex: 'a{2,}'). - self assert: ('aaa' matchesRegex: 'a{2,}'). - self assert: ('aaaa' matchesRegex: 'a{2,}'). + self assert: ('' matchesRegex: 'a{,4}'). + self assert: ('a' matchesRegex: 'a{,4}'). + self assert: ('aa' matchesRegex: 'a{,4}'). + self assert: ('aaa' matchesRegex: 'a{,4}'). + self assert: ('aaaa' matchesRegex: 'a{,4}'). + self deny: ('aaaaa' matchesRegex: 'a{,4}').! - self assert: ('' matchesRegex: 'a{,3}'). - self assert: ('a' matchesRegex: 'a{,3}'). - self assert: ('aa' matchesRegex: 'a{,3}'). - self assert: ('aaa' matchesRegex: 'a{,3}'). - self deny: ('aaaa' matchesRegex: 'a{,3}').!

1 0

The Trunk: Regex-Core-ct.59.mcz
by commits＠source.squeak.org 05 Jul '21

05 Jul '21

Marcel Taeumel uploaded a new version of Regex-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Core-ct.59.mcz ==================== Summary ==================== Name: Regex-Core-ct.59 Author: ct Time: 2 July 2021, 12:26:24.018367 am UUID: 1a76f4fd-fa36-f44e-81e8-1bdc113bcfa3 Ancestors: Regex-Core-ct.58 Fixes a slip when parsing quantifiers of the form {<min>,}. This was a simple typo. See Regex-Tests-Core-ct.12 for regression tests. =============== Diff against Regex-Core-ct.58 =============== Item was changed: ----- Method: RxMatcher>>makeQuantified:min:max: (in category 'private') ----- makeQuantified: anRxmLink min: min max: max "Perform recursive poor-man's transformation of the {<min>,<max>} quantifiers." | aMatcher | "<atom>{,<max>} ==> (<atom>{1,<max>})?" min = 0 ifTrue: [ ^ self makeOptional: (self makeQuantified: anRxmLink min: 1 max: max) ]. "<atom>{<min>,} ==> <atom>{<min>-1, <min>-1}<atom>+" max ifNil: [ + ^ (self makeQuantified: anRxmLink min: min - 1 max: min - 1) pointTailTo: (self makePlus: anRxmLink copyChain) ]. - ^ (self makeQuantified: anRxmLink min: 1 max: min-1) pointTailTo: (self makePlus: anRxmLink copyChain) ]. "<atom>{<max>,<max>} ==> <atom><atom> ... <atom>" min = max ifTrue: [ aMatcher := anRxmLink copyChain. (min-1) timesRepeat: [ aMatcher pointTailTo: anRxmLink copyChain ]. ^ aMatcher ]. "<atom>{<min>,<max>} ==> <atom>{<min>,<min>}(<atom>{1,<max>-1})?" aMatcher := self makeOptional: anRxmLink copyChain. (max - min - 1) timesRepeat: [ aMatcher := self makeOptional: (anRxmLink copyChain pointTailTo: aMatcher) ]. ^ (self makeQuantified: anRxmLink min: min max: min) pointTailTo: aMatcher!

1 0

Jump to page: