Squeak-dev April 2021

squeak-dev@lists.squeakfoundation.org

33 participants
392 discussions

The Inbox: ShoutTests-ct.34.mcz
by commits＠source.squeak.org 25 Nov '21

25 Nov '21

A new version of ShoutTests was added to project The Inbox: http://source.squeak.org/inbox/ShoutTests-ct.34.mcz ==================== Summary ==================== Name: ShoutTests-ct.34 Author: ct Time: 7 April 2021, 5:20:15.847598 pm UUID: a7f39f26-a6fb-f44e-aabb-931714b56ed8 Ancestors: ShoutTests-mt.33 Document a present bug that occurs when styling a method that contains multiple unary selectors after a cascade. =============== Diff against ShoutTests-mt.33 =============== Item was added: + ----- Method: SHParserST80Test>>testChainAfterCascade (in category 'tests') ----- + testChainAfterCascade + + | types s | + s := 'x 1 positive; negative not'. + + types := self tokenTypesIn: s. + + self + assert: #(patternUnary number unary cascadeSeparator unary excessCode) + equals: types.!

3 2

stepping over non local return in a protected block
by Nicolas Cellier 20 Nov '21

20 Nov '21

When debugging things like this: [^2] ensure: [Transcript cr; show: 'done']. if we step into the protected block [^2], then step over ^2, we incorrectly get a BlockCannotReturn. In deeper stacks, I saw some weirder behaviour (when debugging test03EventHandler I put a halt into m on: #mouseDown send: #value: to:[:evt| self halt. evt redButtonPressed ifTrue:[m color: Color red]. evt yellowButtonPressed ifTrue:[m color: Color yellow]. evt blueButtonPressed ifTrue:[m color: Color blue]]. and stepped over such a [^...] ensure: - result is very hard to understand/trace) I'm pretty sure this has been thoroughly investigated and discussed during the last year or so (I remember of some infinite debugger thread and some hard work of Christoph). After the integration of many fixes in exception handling, process termination, unwinding, and simulation machinery, thanks to Jaromir, Marcel, Christoph, ... (apologies to whoever I forgot), maybe it's time to revisit this problem. Christoph, if you still have brain cells unburnt by this problem ;)

7 18

Merge Request: removeClass.cs
by Thiede, Christoph 18 Nov '21

18 Nov '21

This changeset refactors the #removeClass logic (which has been upgraded by Marcel recently) and extracts it to SystemNavigation, analogously to System-ct.1221. It also refines the dialog to search for senders and subclasses of the class to remove as we know it from #removeMessage. [cid:21b5558d-d73d-4d2c-bcc4-eeb40f7dee49] Please merge or give me feedback for improvements. :-) Best, Christoph

2 9

The Trunk: Kernel-mt.1391.mcz
by commits＠source.squeak.org 17 Nov '21

17 Nov '21

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1391.mcz ==================== Summary ==================== Name: Kernel-mt.1391 Author: mt Time: 25 April 2021, 8:25:06.787934 am UUID: 9ab61f3b-e0c8-c545-82fd-49bf4a28fbf4 Ancestors: Kernel-nice.1390 Changes keystroke mappings for better cross-platform compatibility. See http://forum.world.st/Please-try-it-out-Fixing-the-input-mapping-for-keystr… =============== Diff against Kernel-nice.1390 =============== Item was changed: Object subclass: #EventSensor instanceVariableNames: 'mouseButtons mousePosition mouseWheelDelta keyboardBuffer interruptKey interruptSemaphore eventQueue inputSemaphore lastEventPoll hasInputSemaphore lastEventTime' + classVariableNames: 'ButtonDecodeTable EventPollPeriod EventTicklerProcess InterruptWatcherProcess KeyDecodePreferences KeyDecodeTable' - classVariableNames: 'ButtonDecodeTable EventPollPeriod EventTicklerProcess InterruptWatcherProcess KeyDecodeTable' poolDictionaries: 'EventSensorConstants' category: 'Kernel-Processes'! !EventSensor commentStamp: 'mt 12/13/2019 14:38' prior: 0! An EventSensor is an interface to the user input devices. There is at least one instance of EventSensor named Sensor in the system. EventSensor is a replacement for the earlier InputSensor implementation based on a set of (optional) event primitives. An EventSensor updates its state when events are received so that all state based users of Sensor (e.g., Sensor keyboard, Sensor leftShiftDown, Sensor mouseButtons) will work exactly as before, by moving the current VM mechanisms into EventSensor itself. An optional input semaphore is part of the new design. For platforms that support true asynchronous event notification, the semaphore will be signaled to indicate pending events. On platforms that do not support asynchronous notifications about events, the UI will have to poll EventSensor periodically to read events from the VM. Instance variables: mouseButtons <Integer> - mouse button state as replacement for primMouseButtons mousePosition <Point> - mouse position as replacement for primMousePt keyboardBuffer <SharedQueue> - keyboard input buffer interruptKey <Integer> - currently defined interrupt key interruptSemaphore <Semaphore> - the semaphore signaled when the interruptKey is detected eventQueue <SharedQueue> - an optional event queue for event driven applications inputSemaphore <Semaphore>- the semaphore signaled by the VM if asynchronous event notification is supported lastEventPoll <Integer> - the last millisecondClockValue at which we called fetchMoreEvents hasInputSemaphore <Boolean> - true if my inputSemaphore has actually been signaled at least once. Class variables: ButtonDecodeTable <ByteArray> - maps mouse buttons as reported by the VM to ones reported in the events. KeyDecodeTable <Dictionary<SmallInteger->SmallInteger>> - maps some keys and their modifiers to other keys (used for instance to map Ctrl-X to Alt-X) InterruptSemaphore <Semaphore> - signalled by the the VM and/or the event loop upon receiving an interrupt keystroke. InterruptWatcherProcess <Process> - waits on the InterruptSemaphore and then responds as appropriate. EventPollPeriod <Integer> - the number of milliseconds to wait between polling for more events in the userInterruptHandler. EventTicklerProcess <Process> - the process that makes sure that events are polled for often enough (at least every EventPollPeriod milliseconds). Event format: The current event format is very simple. Each event is recorded into an 8 element array. All events must provide some SmallInteger ID (the first field in the event buffer) and a time stamp (the second field in the event buffer), so that the difference between the time stamp of an event and the current time can be reported. Currently, the following events are defined: Null event ============= The Null event is returned when the ST side asks for more events but no more events are available. Structure: [1] - event type 0 [2-8] - unused Mouse event structure ========================== Mouse events are generated when mouse input is detected. [1] - event type 1 [2] - time stamp [3] - mouse x position [4] - mouse y position [5] - button state; bitfield with the following entries: 1 - 2r001 yellow (e.g., right) button 2 - 2r010 blue (e.g., middle) button 4 - 2r100 red (e.g., left) button [all other bits are currently undefined] [6] - modifier keys; bitfield with the following entries: 1 - shift key 2 - ctrl key 4 - (Mac specific) option key 8 - Cmd/Alt key [all other bits are currently undefined] [7] - reserved. [8] - host window id. Keyboard events ==================== Keyboard events are generated when keyboard input is detected. [1] - event type 2 [2] - time stamp [3] - character code (Ascii) For now the character code is in Mac Roman encoding. See #macToSqueak. For key press/release (see [4]), character codes are normalized. [4] - press state; integer with the following meaning 0 - character (aka. key stroke or key still pressed) 1 - key press (aka. key down) 2 - key release (aka. key up) [5] - modifier keys (same as in mouse events) For key press/release (see [4]), modifier keys are still accessible. [6] - character code (Unicode UTF32) Manual decoding via KeyboardInputInterpreter possible. For key press/release (see [4]), character codes are normalized. [7] - reserved. [8] - host window id. Mouse-wheel event structure ========================== Mouse-wheel events are generated when mouse-wheel input is detected. [1] - event type 7 [2] - time stamp [3] - horizontal scroll delta [4] - vertical scroll delta [5] - button state (same as in mouse events) [6] - modifier keys (same as in mouse events) [7] - reserved. [8] - host window id. ! Item was removed: - ----- Method: EventSensor class>>defaultCrossPlatformKeys (in category 'class initialization') ----- - defaultCrossPlatformKeys - "Answer a list of key letters that are used for common editing operations - on different platforms." - ^{ $c . $x . $v . $a . $s . $f . $g . $z } - ! Item was removed: - ----- Method: EventSensor class>>duplicateAllControlAndAltKeysChanged (in category 'preference change notification') ----- - duplicateAllControlAndAltKeysChanged - "The Preference for duplicateAllControlAndAltKeys has changed; reset the other two." - "At some point the various exclusive CtrlAlt-key prefs should become a radio button set, then these methods wouldn't be needed." - (Preferences - valueOfFlag: #swapControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting swapControlAndAltKeys preference'. - (Preferences preferenceAt: #swapControlAndAltKeys) rawValue: false. - ]. - (Preferences - valueOfFlag: #duplicateControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateControlAndAltKeys) rawValue: false. - ]. - self installKeyDecodeTable. - ! Item was changed: ----- Method: EventSensor class>>duplicateControlAndAltKeys: (in category 'public') ----- duplicateControlAndAltKeys: aBoolean "EventSensor duplicateControlAndAltKeys: true" + self flag: #deprecated. + self + mapControlKeysToCommandKeys: aBoolean; + mapAltKeysToOptionKeys: false.! - Preferences setPreference: #duplicateControlAndAltKeys toValue: aBoolean. - self installKeyDecodeTable - ! Item was removed: - ----- Method: EventSensor class>>duplicateControlAndAltKeysChanged (in category 'preference change notification') ----- - duplicateControlAndAltKeysChanged - "The Preference for duplicateControlAndAltKeys has changed; reset the other two." - (Preferences - valueOfFlag: #swapControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting swapControlAndAltKeys preference'. - (Preferences preferenceAt: #swapControlAndAltKeys) rawValue: false. - ]. - (Preferences - valueOfFlag: #duplicateAllControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateAllControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateAllControlAndAltKeys) rawValue: false. - ]. - self installKeyDecodeTable. - ! Item was added: + ----- Method: EventSensor class>>fixControlCharacters (in category 'key decode table') ----- + fixControlCharacters + "Assure that all keyboard events that arrive with the CONTROL modifier actually have control characters set." + + 64 "$@" to: 95 "$_"do: [:upper | + KeyDecodeTable + at: { upper . 2 bitOr: 1 "ctrl+shift" } + put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }]. + 96 "$`" to: 126 "$~" do: [:lower | "Ignore 127" + KeyDecodeTable + at: { lower . 2 "ctrl" } + put: { lower bitAnd: 16r9F . 2 "ctrl" }]. + + self flag: #linuxOnly. "mt: For Linux VMs as of version 201911282316, no control characters will be sent from the VM. Avoid check for #platformName because the extra mapping will not affect others anyway." + self flag: #windowsOnly. "mt: CTRL+m would not arrive as CTRL+CR, which is rather inconsistent."! Item was changed: ----- Method: EventSensor class>>initialize (in category 'class initialization') ----- initialize + - Smalltalk addToStartUpList: self before: ProcessorScheduler. Smalltalk addToShutDownList: self. + KeyDecodePreferences := Dictionary new. + self installKeyDecodeTable. + self installMouseDecodeTable.! - self installMouseDecodeTable. - self install. - - ! Item was removed: - ----- Method: EventSensor class>>installDuplicateKeyEntryFor: (in category 'key decode table') ----- - installDuplicateKeyEntryFor: aPrintableCharacter - "Updates the key-decode table, which maps between pairs of {character code . modifier code}. - See the class comment for more information. - The purpose of this change is to let ctrl+key act like cmd+key (Mac) or alt+key (linux/windows). - It is especially usefull on windows VM where default feel is to use ctrl as shortcut (ctrl+C = copy, etc...). - Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert control characters to printable characters in this mapping table." - - | upper lower | - upper := aPrintableCharacter asUppercase asInteger. - lower := aPrintableCharacter asLowercase asInteger. - - KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. - KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl + shift" } put: { upper . 8 bitOr: 1 "cmd/alt + shift" }.! Item was changed: ----- Method: EventSensor class>>installKeyDecodeTable (in category 'class initialization') ----- installKeyDecodeTable "Create a decode table that swaps or duplicates some keys if the respective preference is set." KeyDecodeTable := Dictionary new. + self mapControlKeysToCommandKeys + ifTrue: [self installMappingToCommandKeys] + ifFalse: [self mapControlCharactersToPrintableCharacters + ifTrue: [self installMappingToPrintableCharacters] + ifFalse: [self fixControlCharacters "mt: Due to platform-specific VM behavior."]]. - Preferences swapControlAndAltKeys - ifTrue: [ (Character allByteCharacters select: [:ea | ea isAlphaNumeric]) do: - [ :c | self installSwappedKeyEntryFor: c ] ]. - Preferences duplicateAllControlAndAltKeys - ifTrue: [ (Character allByteCharacters select: [:ea | ea isAlphaNumeric]) do: - [ :c | self installDuplicateKeyEntryFor: c ] ]. + self mapAltKeysToOptionKeys + ifTrue: [self installMappingToOptionKeys].! - self flag: #toDeprecate. "mt: This mapping should be deprecated in the future." - Preferences duplicateControlAndAltKeys - ifTrue: [ self defaultCrossPlatformKeys do: - [ :c | self installDuplicateKeyEntryFor: c ] ]. - ! Item was added: + ----- Method: EventSensor class>>installMappingToCommandKeys (in category 'key decode table') ----- + installMappingToCommandKeys + "Maps all keyboard events that arrive with the CONTROL modifier to also have the COMMAND modifier set. This mapping also considers the preference #mapControlCharactersToPrintableCharacters." + + | controlMask | + 0 "NUL" to: 27 "ESC" do: [:control | + controlMask := self mapControlCharactersToPrintableCharacters + ifTrue: [16r60] ifFalse: [0]. + KeyDecodeTable + at: { control . 2r0010 "ctrl" } + put: { control bitOr: controlMask . 2r1010 "cmd+ctrl" }. + controlMask := self mapControlCharactersToPrintableCharacters + ifTrue: [16r40] ifFalse: [0]. + KeyDecodeTable + at: { control . 2r0011 "ctrl+shift" } + put: { control bitOr: controlMask . 2r1011 "cmd+ctrl+shift" }]. + + 28 "arrow keys" to: 126 "$~" do: [:arrowAndPrintable | + KeyDecodeTable + at: { arrowAndPrintable . 2r0010 "ctrl" } + put: { arrowAndPrintable . 2r1010 "cmd+ctrl" }. + KeyDecodeTable + at: { arrowAndPrintable . 2r0011 "ctrl + shift" } + put: { arrowAndPrintable . 2r1011 "cmd + shift" }].! Item was added: + ----- Method: EventSensor class>>installMappingToOptionKeys (in category 'key decode table') ----- + installMappingToOptionKeys + "Maps all keyboard events that arrive with the COMMAND modifier to also have the OPTION modifier set. See preference #mapAltKeysToOptionKeys." + + self flag: #windowsOnly. "mt: In Windows VMs version 202104182333, pressing the (physical) ALT key arrives as CMD modifier in the image. Should this ever change, this mapping MUST be adapted, too." + self flag: #linuxOnly. "mt: See #windowsOnly." + self flag: #macOSOnly. "mt: This mapping should be ignored to not overshadow events that have the actual OPTION modifier set." + + CharacterSet ascii do: [:character | + KeyDecodeTable + at: { character asInteger . 2r1000 "cmd" } + put: { character asInteger . 2r1100 "cmd+opt" }. + KeyDecodeTable + at: { character asInteger . 2r1001 "cmd + shift" } + put: { character asInteger . 2r1101 "cmd + opt + shift" }].! Item was added: + ----- Method: EventSensor class>>installMappingToPrintableCharacters (in category 'key decode table') ----- + installMappingToPrintableCharacters + "Only applies when the CONTROL modifier is present!! Control characters that can directly be triggered -- such as CR, ENTER, BS, DEL, POS1, END -- will not be mapped." + + self flag: #windowsOnly. "mt: The CONTROL modifier might directly change the control character. Examples: CTRL+CR(13) arrives as CTRL+LF(10), CTRL+BS(8) arrives as CTRL+DEL(127). If you have no other means to input LF(10) or DEL(127), you might have to disable this mapping to printable characters." + + 0 "NUL" to: 27 "ESC" do: [:control | + KeyDecodeTable + at: { control . 2r0010 "ctrl" } + put: { control bitOr: 16r60 "+96" . 2 "ctrl" }. + KeyDecodeTable + at: { control . 2r0011 "ctrl+shift" } + put: { control bitOr: 16r40 "+64" . 2r0011 "ctrl+shift" }].! Item was removed: - ----- Method: EventSensor class>>installSwappedKeyEntryFor: (in category 'key decode table') ----- - installSwappedKeyEntryFor: aPrintableCharacter - "Updates the key-decode table, which maps between pairs of {character code . modifier code}. See the class comment for more information. - Note that the bitmask 16r9F removes the high bits, which subtracts 64 from the key code for (upper) $A to $Z and 96 for (lower) $a to $z. The VM sends non-printable control characters for [ctrl]+[A-Za-Z] in ASCII < 32, but the given character is expected to be ASCII >= 32 and thus printable. So we have to convert printable characters to control characters in this mapping table." - - | upper lower | - upper := aPrintableCharacter asUppercase asInteger. - lower := aPrintableCharacter asLowercase asInteger. - - KeyDecodeTable at: { lower bitAnd: 16r9F . 2 "ctrl" } put: { lower . 8 "cmd/alt" }. - KeyDecodeTable at: { lower . 8 "cmd/alt" } put: { lower bitAnd: 16r9F . 2 "ctrl" }. - KeyDecodeTable at: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" } put: { upper . 8 bitOr: 1 "cmd/alt+shift" }. - KeyDecodeTable at: { upper . 8 bitOr: 1 "cmd/alt+shift" } put: { upper bitAnd: 16r9F . 2 bitOr: 1 "ctrl+shift" }.! Item was added: + ----- Method: EventSensor class>>mapAltKeysToOptionKeys (in category 'preferences') ----- + mapAltKeysToOptionKeys + <preference: 'Map ALT keys to OPTION keys' + categoryList: #(keyboard events input) + description: 'On platforms other than macOS, keystrokes involving the (physical) ALT modifier typically arrive as COMMAND modifier. If you now also map CONTROL keys to COMMAND keys, you disable potential input. If you enable this preference, you preserve the possibility of reacting to two different modifiers -- CMD and OPT -- in your code, on all platforms. (This preference replaces older duplicate/swap preferences.)' + type: #Boolean> + + ^ KeyDecodePreferences + at: #mapAltKeysToOptionKeys + ifAbsent: [false]! Item was added: + ----- Method: EventSensor class>>mapAltKeysToOptionKeys: (in category 'preferences') ----- + mapAltKeysToOptionKeys: aBooleanOrNil + + aBooleanOrNil = self mapAltKeysToOptionKeys + ifTrue: [^ self]. + + aBooleanOrNil + ifNil: [ + KeyDecodePreferences + removeKey: #mapAltKeysToOptionKeys] + ifNotNil: [ + KeyDecodePreferences + at: #mapAltKeysToOptionKeys + put: aBooleanOrNil]. + + self installKeyDecodeTable.! Item was added: + ----- Method: EventSensor class>>mapControlCharactersToPrintableCharacters (in category 'preferences') ----- + mapControlCharactersToPrintableCharacters + <preference: 'Map ASCII control characters to printable characters' + categoryList: #(keyboard events input) + description: 'Keystrokes involving the (physical) CONTROL modifier typically have characters codes from 00 to 31 when pressing the physical keys labeled A to Z (or actually ASCII 64 to 95). This means that, for example in CTRL+C, client code cannot check for "anEvent controlKeyPressed and: [anEvent keyCharacter = $C]" but has to resort to "anEvent controlKeyPressed and: [keyCharacter = 3]." If you enable this preference all control characters will be mapped to printable characters.' + type: #Boolean> + + ^ KeyDecodePreferences + at: #mapControlCharactersToPrintableCharacters + ifAbsent: [true]! Item was added: + ----- Method: EventSensor class>>mapControlCharactersToPrintableCharacters: (in category 'preferences') ----- + mapControlCharactersToPrintableCharacters: aBooleanOrNil + + aBooleanOrNil + ifNil: [ + KeyDecodePreferences + removeKey: #mapControlCharactersToPrintableCharacters] + ifNotNil: [ + KeyDecodePreferences + at: #mapControlCharactersToPrintableCharacters + put: aBooleanOrNil]. + + self installKeyDecodeTable.! Item was added: + ----- Method: EventSensor class>>mapControlKeysToCommandKeys (in category 'preferences') ----- + mapControlKeysToCommandKeys + <preference: 'Map CONTROL keys to COMMAND keys' + categoryList: #(keyboard events input) + description: 'On platforms other than macOS, users use the CONTROL modifier for many common shortcuts around text editing such as CTRL+C and CTRL+V for copy and paste. For the sake of cross-platform compatibility, however, many tools in this system will check for CMD+C and CMD+V instead. Note that on Linux and Windows platforms, keystrokes involving the (physical) ALT modifier typically arrive as COMMAND modifier. Thus, enable this preference if you still want to use CONTROL key instead of the ALT key for such shortcuts. (This preference replaces older duplicate/swap preferences.)' + type: #Boolean> + + ^ KeyDecodePreferences + at: #mapControlKeysToCommandKeys + ifAbsent: [true]! Item was added: + ----- Method: EventSensor class>>mapControlKeysToCommandKeys: (in category 'preferences') ----- + mapControlKeysToCommandKeys: aBooleanOrNil + + aBooleanOrNil + ifNil: [ + KeyDecodePreferences + removeKey: #mapControlKeysToCommandKeys] + ifNotNil: [ + KeyDecodePreferences + at: #mapControlKeysToCommandKeys + put: aBooleanOrNil]. + + self installKeyDecodeTable.! Item was changed: ----- Method: EventSensor class>>startUp (in category 'system startup') ----- startUp + Smalltalk platformName = 'Mac OS' + ifTrue: [ + self mapAltKeysToOptionKeys: false. + self mapControlKeysToCommandKeys: false] + ifFalse: [ + self mapAltKeysToOptionKeys: true. + self mapControlKeysToCommandKeys: true]. + + self default startUp.! - self installMouseDecodeTable. - self installKeyDecodeTable. - self default startUp! Item was changed: ----- Method: EventSensor class>>swapControlAndAltKeys: (in category 'public') ----- swapControlAndAltKeys: aBoolean - "EventSensor swapControlAndAltKeys: true" + self deprecated: 'You cannnot swap CONTROL and ALT modifiers anymore. Please use other key-mapping preferences to fit your needs.'.! - Preferences setPreference: #swapControlAndAltKeys toValue: aBoolean. - self installKeyDecodeTable! Item was removed: - ----- Method: EventSensor class>>swapControlAndAltKeysChanged (in category 'preference change notification') ----- - swapControlAndAltKeysChanged - "The Preference for swapControlAndAltKeys has changed; reset the other two." - (Preferences - valueOfFlag: #duplicateControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateControlAndAltKeys) rawValue: false. - ]. - (Preferences - valueOfFlag: #duplicateAllControlAndAltKeys - ifAbsent: [false]) ifTrue: [ - self inform: 'Resetting duplicateAllControlAndAltKeys preference'. - (Preferences preferenceAt: #duplicateAllControlAndAltKeys) rawValue: false. - ]. - self installKeyDecodeTable. - ! Item was changed: ----- Method: EventSensor>>anyModifierKeyPressed (in category 'modifier keys') ----- anyModifierKeyPressed + "ignore, however, the shift keys 'cause that's not REALLY a modifier key" - "ignore, however, the shift keys 'cause that's not REALLY a command key" + ^ self peekButtons anyMask: (2r1110 "cmd | opt | ctrl" bitShift: MouseEvent numButtons)! - ^ self peekButtons anyMask: 16r70 "cmd | opt | ctrl"! Item was changed: ----- Method: EventSensor>>commandKeyPressed (in category 'modifier keys') ----- commandKeyPressed "Answer whether the command key on the keyboard is being held down." + ^ self peekButtons anyMask: (2r1000 "cmd" bitShift: MouseEvent numButtons)! - ^ self peekButtons anyMask: (1 bitShift: MouseEvent numButtons + 3)! Item was changed: ----- Method: EventSensor>>controlKeyPressed (in category 'modifier keys') ----- controlKeyPressed "Answer whether the control key on the keyboard is being held down." + ^ self peekButtons anyMask: (2r0010 "ctrl" bitShift: MouseEvent numButtons)! - ^self peekButtons anyMask: (1 bitShift: MouseEvent numButtons + 1)! Item was added: + ----- Method: EventSensor>>optionKeyPressed (in category 'modifier keys') ----- + optionKeyPressed + "Answer whether the option key on the Macintosh keyboard is being held down. Macintosh specific. Clients are discouraged from calling this directly, since it circumvents bert's attempt to eradicate option-key checks" + + ^ self peekButtons anyMask: (2r0100 "opt" bitShift: MouseEvent numButtons)! Item was changed: ----- Method: EventSensor>>processEvent: (in category 'private-I/O') ----- processEvent: evt "Process a single event. This method is run at high priority." | type buttons window | type := evt at: 1. lastEventTime := evt at: 2. "Only process main window events, forward others to host window proxies" window := evt at: 8. (window isNil or: [window isZero]) ifTrue: [window := 1. evt at: 8 put: window]. window = 1 ifFalse: [ ^Smalltalk at: #HostWindowProxy ifPresent: [:w | w processEvent: evt]]. "Tackle mouse events and mouse wheel events first" (type = EventTypeMouse or: [type = EventTypeMouseWheel]) ifTrue: [buttons := (ButtonDecodeTable at: (evt at: 5) + 1). evt at: 5 put: (Smalltalk platformName = 'Mac OS' ifTrue: [ buttons ] ifFalse: [ self mapButtons: buttons modifiers: (evt at: 6) ]). self queueEvent: evt. type = EventTypeMouseWheel ifTrue: [^ self processMouseWheelEvent: evt]. type = EventTypeMouse ifTrue: [^ self processMouseEvent: evt]]. "Store the event in the queue if there's any" type = EventTypeKeyboard ifTrue: [ "Check if the event is a user interrupt" ((evt at: 4) = EventKeyChar and: [((evt at: 3) bitOr: (((evt at: 5) bitAnd: 8) bitShift: 8)) = interruptKey]) ifTrue: ["interrupt key is meta - not reported as event" ^ interruptSemaphore signal]. + "Decode keys for characters (e.g., map ctrl -> cmd)." - "Decode keys for characters (i.e., duplicate or swap, ctrl <-> alt/cmd)." (evt at: 4) = EventKeyChar ifTrue: [ | unicode ascii | "Copy lookup key first in case of key swap." unicode := {evt at: 6. evt at: 5}. ascii := {evt at: 3. evt at: 5}. KeyDecodeTable "Unicode character first" at: unicode ifPresent: [:a | evt at: 6 put: a first; at: 5 put: a second]. KeyDecodeTable "ASCII character second" at: ascii ifPresent: [:a | evt at: 3 put: a first; at: 5 put: a second]]. self queueEvent: evt. self processKeyboardEvent: evt . ^self ]. "Handle all events other than Keyboard or Mouse." self queueEvent: evt. ! Item was changed: ----- Method: EventSensor>>rawMacOptionKeyPressed (in category 'modifier keys') ----- rawMacOptionKeyPressed "Answer whether the option key on the Macintosh keyboard is being held down. Macintosh specific. Clients are discouraged from calling this directly, since it circumvents bert's attempt to eradicate option-key checks" + self deprecated: 'Use #optionKeyPressed instead.'. + ^ self optionKeyPressed! - ^ self peekButtons anyMask: 32! Item was changed: ----- Method: EventSensor>>shiftPressed (in category 'modifier keys') ----- shiftPressed "Answer whether the shift key on the keyboard is being held down." + ^ self peekButtons anyMask: (2r0001 "shift" bitShift: MouseEvent numButtons)! - ^ self peekButtons anyMask: (1 bitShift: MouseEvent numButtons)! Item was changed: + (PackageInfo named: 'Kernel') postscript: 'EventSensor initialize. + EventSensor startUp.'! - (PackageInfo named: 'Kernel') postscript: '"recompile all methods containing blocks with the wrong outerCode" - (self systemNavigation allMethodsSelect: [:m| m literals anySatisfy: [:l| l isCompiledCode and: [l isCompiledBlock and: [l outerCode ~~ m]]]]) do: - [:mr| mr actualClass recompile: mr selector]'!

4 4

BUG/REGRESSION while debugging Generator >> #nextPut:
by Thiede, Christoph 15 Nov '21

15 Nov '21

Hi all, I discovered a bug when stepping over a call to Generator >> #nextPut:. !! Save your image before trying the following !! Generator on: [:stream | stream nextPut: #foo] [cid:95952b5e-98f1-4447-bd09-29d396961281] 1. Due to multiprocessing implementation of the Generator, pressing over will hang up the current process forever, because the generator is never queried. 2. If I press cmd-dot, I get an infinite number of debugger windows that show Context >> #cannotReturn:. This will probably damage your image. The first is annoying for newcomers, but I see this behavior is reasonable and without the effect of the second, it wouldn't be a big problem. The second, however, looks like a bigger issue to me. Actually, I think the most serious aspect is that in Squeak 5.1, the same procedure does not crash your image, but you are forwarded to the emergency debugger and can terminate the process: [cid:c8eee8c3-d2de-49c0-b5d4-33bd340d6c98] [cid:6044ecf2-91ab-4f6e-b863-b980586868e9] Also, this is not the first scenario in the last time where I got an infinite debugger chain. See [BUG(s)] in Context control (#jump, #runUntilErrorOrReturnFrom:)<http://forum.world.st/BUG-s-in-Context-control-jump-runUntilErrorOrReturnFr…> for a similar issue. And there were even more situations which I could not yet reproduce exactly. I'm afraid that the recent changes to the debuggers might have weakened its ability to detect recursive errors. Can someone else tell about these problems? I suppose we ignore a large number of recursive errors as in MorphicDebugger >> #openOn:context:label:contents:fullView:, the uiBlock is often triggered as a separate UI message which will be executed after the recursion flag has been cleared by the base class. Would be great if someone could have a look at it or share more information :) Best, Christoph

8 25

The Trunk: Kernel-eem.1366.mcz
by commits＠source.squeak.org 02 Nov '21

02 Nov '21

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1366.mcz ==================== Summary ==================== Name: Kernel-eem.1366 Author: eem Time: 26 January 2021, 4:27:57.204259 pm UUID: 3a706d32-c2d6-416f-82c1-bbf735650385 Ancestors: Kernel-eem.1365 Slightly faster implementation of Context>>#isPrimFailToken:. Improve the comments in Context>>#isHandlerContext/#isUnwindContext. Nuke an obsolete method. =============== Diff against Kernel-eem.1365 =============== Item was changed: ----- Method: Context>>isHandlerContext (in category 'private-exceptions') ----- isHandlerContext + "Answer if the receiver is for a method that is marked as an exception handler. + BlockClosure>>#on:do: uses this primitive to identify itself to the VM + as an exception handler method, which the VM uses in primitive 197 + Context>>#findNextHandlerContextStarting, primitiveFindHandlerContext, + to accelerate the search for exception handlers." - "is this context for method that is marked?" ^method primitive = 199! Item was changed: ----- Method: Context>>isPrimFailToken: (in category 'private') ----- isPrimFailToken: anObject + ^(self objectClass: anObject) isArray - ^(self objectClass: anObject) == Array and: [anObject size = 2 + and: [(anObject at: 1) == PrimitiveFailToken]]! - and: [anObject first == PrimitiveFailToken]]! Item was changed: ----- Method: Context>>isUnwindContext (in category 'private-exceptions') ----- isUnwindContext + "Answer if the receiver is for a method that is marked as a non-local return/exception unwind protect. + BlockClosure>>#ensure: and BlockClosure>>#ifCurtailed: use this primitive to identify + themseves to the VM as unwind protect methods. The VM uses this in primitive 195 + Context>>#findNextUnwindContextUpTo:, primitiveFindNextUnwindContext, to + accelerate the search for unwind protects." - "is this context for method that is marked?" ^method primitive = 198! Item was removed: - ----- Method: Context>>tryPrimitiveFor:receiver:args: (in category 'private') ----- - tryPrimitiveFor: method receiver: receiver args: arguments - "If this method has a primitive index, then run the primitive and return its result. - Otherwise (and also if the primitive fails) return PrimitiveFailToken, - as an indication that the method should be activated and run as bytecodes." - | primIndex | - (primIndex := method primitive) = 0 ifTrue: [^{PrimitiveFailToken. nil}]. - ^ self doPrimitive: primIndex method: method receiver: receiver args: arguments!

7 21

The Trunk: Network-dtl.240.mcz
by commits＠source.squeak.org 21 Sep '21

21 Sep '21

David T. Lewis uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-dtl.240.mcz ==================== Summary ==================== Name: Network-dtl.240 Author: dtl Time: 6 April 2020, 10:33:07.751386 pm UUID: a8f00e08-7398-4d4a-8cd2-09cedcada729 Ancestors: Network-eem.239 This update enables the Squeak new networking and IPv6 support by default. The update is in the package postscript. IPv6 network support for the VM (SocketPlugin) and image were implemented by Ian Piumarta circa 2007. This included IPv6 support and a more general image-side representation of network addressing. In 2012, this work was merged into Squeak trunk, with a preference to switch between the old networking support or the new networking support with IPv6. At that time, there were concerns with performance of NetNameResolver on some Windows platforms, and for this reason the "Enable IPv6 and new network support" preference was left disabled for official Squeak distributions. It now 2020, and operating systems have improved over the years, so it is time to enable the new networking preference by default. =============== Diff against Network-eem.239 =============== Item was changed: + (PackageInfo named: 'Network') postscript: '"Enable IPv6 and new network support by default" + NetNameResolver enableIPv6: true + '! - (PackageInfo named: 'Network') postscript: '"Rebuild CSNonAtom." - MailAddressTokenizer cleanUp: false'!

8 14

The Trunk: Morphic-mt.1755.mcz
by commits＠source.squeak.org 20 Sep '21

20 Sep '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1755.mcz ==================== Summary ==================== Name: Morphic-mt.1755 Author: mt Time: 18 April 2021, 7:00:43.878254 pm UUID: e5705780-2988-a54e-b6c7-21b4194fcd5c Ancestors: Morphic-mt.1754, Morphic-ct.1659 Fix our two menu-invocating buttons to act on mouse-down and actually look like menus: (1) menu button in system window and (2) change-set button in world-main-docking-bar. Merges Morphic-ct.1659. Thanks Christoph (ct) for pointing out this issue about menu invocation through buttons. See http://forum.world.st/The-Inbox-Morphic-ct-1659-mcz-tp5116728.html By example, this commit also adds a menu to the change-set button in the docking bar. This menu lists the latest method and class changes. To make this work, the following things got addressed: - Fixes DockingBarUpdatingItemMorph, which missed several changes from DockingBarItemMorph. (Interesting specialization challenge...) - Let menus #rubberBandCells to allow for changing menu item's widths. - Adds query about latest changes to #listChangesOn:. (Feel free to improve this. Maybe add preference for number of elements?) Complements (and depends on) System-mt.1228 and Tools-mt.1042. =============== Diff against Morphic-mt.1754 =============== Item was changed: ----- Method: DockingBarMorph>>addUpdatingItem: (in category 'construction') ----- addUpdatingItem: aBlock | item | item := DockingBarUpdatingItemMorph new. aBlock value: item. + item subMenu ifNotNil: [:menu | + "Docking bar and protruding menu should appear visually merged." + menu morphicLayerNumber: self morphicLayerNumber + 1]. self addMorphBack: item! Item was changed: ----- Method: DockingBarMorph>>ensureSelectedItem: (in category 'events') ----- ensureSelectedItem: evt self selectedItem ifNil: [ self selectItem: ( self submorphs + detect: [ :each | each isMenuItemMorph ] - detect: [ :each | each isKindOf: DockingBarItemMorph ] ifNone: [ ^self ]) event: evt ]! Item was changed: ----- Method: DockingBarMorph>>filterEvent:for: (in category 'events-processing') ----- filterEvent: aKeyboardEvent for: anObject "Provide keyboard shortcuts." | index itemToSelect | aKeyboardEvent controlKeyPressed ifFalse: [^ aKeyboardEvent]. aKeyboardEvent isKeystroke ifFalse: [^ aKeyboardEvent]. "Search field." aKeyboardEvent keyCharacter = $0 ifTrue: [ self searchBarMorph ifNotNil: [ :morph | morph model activate: aKeyboardEvent in: morph ]. ^ aKeyboardEvent ignore "hit!!"]. "Select menu items." (aKeyboardEvent keyValue between: $1 asciiValue and: $9 asciiValue) ifFalse: [^ aKeyboardEvent]. index := aKeyboardEvent keyValue - $1 asciiValue + 1. itemToSelect := (self submorphs select: [ :each | + each isMenuItemMorph ]) - each isKindOf: DockingBarItemMorph ]) at: index ifAbsent: [^ aKeyboardEvent]. self activate: aKeyboardEvent. self selectItem: itemToSelect event: aKeyboardEvent. ^ aKeyboardEvent ignore "hit!!"! Item was changed: ----- Method: DockingBarMorph>>moveSelectionDown:event: (in category 'control') ----- moveSelectionDown: direction event: evt "Move the current selection up or down by one, presumably under keyboard control. direction = +/-1" | index | index := (submorphs indexOf: selectedItem ifAbsent: [1-direction]) + direction. submorphs do: "Ensure finite" [:unused | | m | m := submorphs atWrap: index. + (m isMenuItemMorph and: [m isEnabled]) ifTrue: - ((m isKindOf: DockingBarItemMorph) and: [m isEnabled]) ifTrue: [^ self selectItem: m event: evt]. "Keep looking for an enabled item" index := index + direction sign]. ^ self selectItem: nil event: evt! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>adjacentTo (in category 'selecting') ----- + adjacentTo + + | roundedCornersOffset verticalOffset | + roundedCornersOffset := MenuMorph roundedMenuCorners + ifTrue: [Morph preferredCornerRadius negated] + ifFalse: [0]. + verticalOffset := 2. + + owner isFloating + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToTop + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToLeft + ifTrue: [^ {self bounds topRight + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToBottom + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToRight + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ verticalOffset negated)}]. + ^ {self bounds bottomLeft + (roundedCornersOffset @ 5)}! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>createSubmenu (in category 'private') ----- + createSubmenu + + ^DockingBarMenuMorph new! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>createUpdatingSubmenu (in category 'private') ----- + createUpdatingSubmenu + + ^DockingBarUpdatingMenuMorph new! Item was changed: + ----- Method: DockingBarUpdatingItemMorph>>decorateOwner (in category 'world') ----- - ----- Method: DockingBarUpdatingItemMorph>>decorateOwner (in category 'as yet unclassified') ----- decorateOwner "Ignore."! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawIconOn: (in category 'drawing') ----- + drawIconOn: aCanvas + + | pos | + self hasIcon ifTrue: [ + | iconForm | + iconForm := self iconForm. + + pos := (contents + ifEmpty: [self left + (self width - iconForm width // 2)] + ifNotEmpty: [self left]) + @ (self top + (self height - iconForm height // 2)). + + aCanvas + translucentImage: iconForm + at: pos].! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawLabelOn: (in category 'drawing') ----- + drawLabelOn: aCanvas + + | stringBounds | + self contents ifEmpty: [^ self]. + + stringBounds := bounds. + + self hasIcon ifTrue: [ + stringBounds := stringBounds left: stringBounds left + self iconForm width + 2 ]. + + "Vertical centering." + stringBounds := stringBounds top: stringBounds top + stringBounds bottom - self fontToUse height // 2. + "Horizontal centering." + stringBounds := stringBounds left: stringBounds left + (stringBounds width - (self fontToUse widthOfString: contents) // 2) abs. + + aCanvas + drawString: contents + in: stringBounds + font: self fontToUse + color: self colorToUse.! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawSubMenuMarkerOn: (in category 'drawing') ----- + drawSubMenuMarkerOn: aCanvas + "Ignore."! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>mouseDown: (in category 'events') ----- + mouseDown: evt + "Handle a mouse down event. Menu items get activated when the mouse is over them." + + (evt shiftPressed and:[self wantsKeyboardFocusOnShiftClick]) ifTrue: [ ^super mouseDown: evt ]. "enable label editing" + isSelected + ifTrue: [ + owner selectItem: nil event: evt. ] + ifFalse: [ + owner activate: evt. "Redirect to menu for valid transitions" + owner selectItem: self event: evt. ] + ! Item was changed: + ----- Method: DockingBarUpdatingItemMorph>>mouseEnter: (in category 'events') ----- - ----- Method: DockingBarUpdatingItemMorph>>mouseEnter: (in category 'as yet unclassified') ----- mouseEnter: evt "Do not hover docking bar items directory. Mouse-down required. But if you already see a submenu, support hovering." owner selectedItem ifNotNil: [owner selectItem: self event: evt]! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>mouseUp: (in category 'events') ----- + mouseUp: evt + "Handle a mouse up event. Menu items get activated when the mouse is over them. Do nothing if we're not in a 'valid menu transition', meaning that the current hand focus must be aimed at the owning menu." + + evt hand mouseFocus == owner ifFalse: [ ^self ]. + self contentString ifNotNil: [ + self contents: self contentString withMarkers: true inverse: true. + self refreshWorld. + (Delay forMilliseconds: 200) wait ].! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>select: (in category 'selecting') ----- + select: evt + + super select: evt. + subMenu ifNotNil: [ + evt hand newKeyboardFocus: subMenu ]! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>wantsKeyboardFocusOnShiftClick (in category 'events') ----- + wantsKeyboardFocusOnShiftClick + "set this preference to false to prevent user editing of docking bar menu items" + ^Preferences valueOfPreference: #allowMenubarItemEditing ifAbsent: [false]! Item was added: + ----- Method: DockingBarUpdatingMenuMorph>>morphicLayerNumber: (in category 'update') ----- + morphicLayerNumber: n + + super morphicLayerNumber: n. + ! Item was changed: ----- Method: MenuMorph>>initialize (in category 'initialization') ----- initialize super initialize. self setDefaultParameters. self changeTableLayout. self listDirection: #topToBottom. self hResizing: #shrinkWrap. self vResizing: #shrinkWrap. + self rubberBandCells: true. self disableLayout: true. self morphicLayerNumber: self class menuLayer. defaultTarget := nil. selectedItem := nil. stayUp := false. popUpOwner := nil.! Item was changed: ----- Method: SystemWindow>>createMenuBox (in category 'initialization') ----- createMenuBox ^ (self createBox: self class menuBoxImage) actionSelector: #offerWindowMenu; + setBalloonText: 'window menu' translated; + actWhen: #buttonDown; + yourself! - setBalloonText: 'window menu' translated! Item was changed: + ----- Method: TheWorldMainDockingBar>>browseChanges (in category 'submenu - changes') ----- - ----- Method: TheWorldMainDockingBar>>browseChanges (in category 'right side') ----- browseChanges ChangeSorter open.! Item was changed: + ----- Method: TheWorldMainDockingBar>>browseChangesLabel (in category 'submenu - changes') ----- - ----- Method: TheWorldMainDockingBar>>browseChangesLabel (in category 'right side') ----- browseChangesLabel "The project name is the same as the current change set." ^ Project current name! Item was added: + ----- Method: TheWorldMainDockingBar>>changesMenuOn: (in category 'submenu - changes') ----- + changesMenuOn: aDockingBar + + aDockingBar addUpdatingItem: [:item | + item + help: 'Browse this project''s changes' translated; + wordingProvider: self + wordingSelector: #browseChangesLabel; + subMenuUpdater: self + selector: #listChangesOn:].! Item was changed: ----- Method: TheWorldMainDockingBar>>fillDockingBar: (in category 'construction') ----- fillDockingBar: aDockingBar "Private - fill the given docking bar" self menusOn: aDockingBar. aDockingBar addSpacer. + self changesMenuOn: aDockingBar. - self projectNameOn: aDockingBar. aDockingBar addSpacer. self rightSideOn: aDockingBar. aDockingBar setProperty: #mainDockingBarTimeStamp toValue: self class timeStamp.! Item was added: + ----- Method: TheWorldMainDockingBar>>listChangesOn: (in category 'submenu - changes') ----- + listChangesOn: menu + + | latestMethodChanges latestClassChanges| + latestMethodChanges := (Array streamContents: [:s | + ChangeSet current changedMethodsDo: [:method :changeType :dateAndTime :category | + s nextPut: { dateAndTime. method. changeType. category }]]) + sorted: [:a :b | a first >= b first]. + + 1 to: (10 min: latestMethodChanges size) do: [:index | | spec method | + spec := latestMethodChanges at: index. + method := spec second. + menu addItem: [:item | + item + contents: ('{1} {2} \{{3}\} \{{4}\}' format: {method methodClass. method selector. spec fourth. method methodClass category}) ; + target: ToolSet; + balloonText: spec third asString; + icon: ((#(remove addedThenRemoved) includes: spec third) ifTrue: [MenuIcons smallDeleteIcon] ifFalse: [ + spec third = #add ifTrue: [MenuIcons smallNewIcon] ifFalse: [MenuIcons blankIcon]]); + selector: (method isInstalled ifTrue: [#browseMethod:] ifFalse: [#browseMethodVersion:]); + arguments: {method}]]. + + latestClassChanges := (Array streamContents: [:s | + ChangeSet current changedClassesDo: [:class :changeTypes :dateAndTime :category | + "We are not interested in classes whose method's did only change." + changeTypes ifNotEmpty: [s nextPut: { dateAndTime. class. changeTypes. category }]]]) + sorted: [:a :b | a first >= b first]. + + latestClassChanges ifNotEmpty: [menu addLine]. + 1 to: (10 min: latestClassChanges size) do: [:index | | spec class | + spec := latestClassChanges at: index. + class := spec second. + menu addItem: [:item | + item + contents: ('{1} \{{2}\}' format: {class name. spec fourth }) ; + target: ToolSet; + balloonText: (spec third sorted joinSeparatedBy: Character space); + icon: ((spec third includesAnyOf: #(remove addedThenRemoved)) + ifTrue: [MenuIcons smallDeleteIcon] + ifFalse: [ + (spec third includes: #add) + ifTrue: [MenuIcons smallNewIcon] + ifFalse: [MenuIcons blankIcon]]); + selector: ((spec third includes: #remove) ifTrue: [#inspect:] ifFalse: [#browseClass:]); + arguments: {class}]]. + + menu addLine; addItem: [:item | + item + contents: 'Browse current change set...' translated; + target: self; + selector: #browseChanges].! Item was removed: - ----- Method: TheWorldMainDockingBar>>projectNameOn: (in category 'right side') ----- - projectNameOn: aDockingBar - - aDockingBar addUpdatingItem: [:item | - item - help: 'Browse this project''s changes'; - target: self; - selector: #browseChanges; - wordingProvider: self - wordingSelector: #browseChangesLabel].! Item was changed: + (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances.'! - (PackageInfo named: 'Morphic') postscript: 'Transcript showln: ''[NOTICE] There is a new preference called "Interactive print-it". Please check your preference browser to choose the preferred value.'''!

4 6

The Trunk: Chronology-Core-ul.55.mcz
by commits＠source.squeak.org 19 Sep '21

19 Sep '21

Levente Uzonyi uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-ul.55.mcz ==================== Summary ==================== Name: Chronology-Core-ul.55 Author: ul Time: 31 May 2020, 12:10:20.250221 am UUID: ea36b609-177c-405a-b64e-9988deb3d26e Ancestors: Chronology-Core-nice.52 Automatically update the time zone cached by the VM every 30 minutes: - copied and modified Eliot's accessor to primitive 243 to do the actual updating (Time class >> #primitiveUpdateTimeZone) - update happens when Time class >> #posixMicrosecondClockWithOffset or Time class >> #posixMicrosecondClockWithOffset: are sent. Other low-level accessors of the VM time zone are not updating the cached time zone value (e.g. Time class >> #localMicrosecondClockPrimitive) - actual update happens in Time class >> #updateTimeZoneCacheAt: - postscript activates the update mechanism which can be turned off by evaluating [ Time classPool at: #UpdateVMTimeZoneCacheAt put: nil ] Other changes: - do not send Time class >> #initialize from DateAndTime class >> #startUp:. Let Time have its own #startUp: method instead. Postscript adds Time to the startUpList before DateAndTime. - do not send super initialize from DateAndTime class >> #initialize - do not send #automaticTimezone to DateAndTime on startup, because that's just an accessor with no side effects - do not overwrite set variables in Time class >> #initialize - assert that the value passed to Time class >> #clockPolicy: is one of the known values =============== Diff against Chronology-Core-nice.52 =============== Item was changed: ----- Method: DateAndTime class>>initialize (in category 'initialize-release') ----- initialize - super initialize. - ClockProvider := Time. PosixEpochJulianDays := 2440588. InitializeFromPrimitive := self canInitializeFromPrimitive. Smalltalk addToStartUpList: self. self startUp: true ! Item was changed: ----- Method: DateAndTime class>>startUp: (in category 'system startup') ----- startUp: startingAfresh "Set local timezone" startingAfresh ifTrue: [InitializeFromPrimitive := self canInitializeFromPrimitive. Time initialize. "set LastClockTick to 0". + self now]! - self now. - self automaticTimezone]! Item was changed: Magnitude subclass: #Time instanceVariableNames: 'seconds nanos' + classVariableNames: 'ClockPolicy HighResClockTicksPerMillisecond LastClockTick UpdateVMTimeZoneCacheAt UseHighResClockForTiming' - classVariableNames: 'ClockPolicy HighResClockTicksPerMillisecond LastClockTick UseHighResClockForTiming' poolDictionaries: 'ChronologyConstants' category: 'Chronology-Core'! !Time commentStamp: 'dew 10/23/2004 17:58' prior: 0! This represents a particular point in time during any given day. For example, '5:19:45 pm'. If you need a point in time on a particular day, use DateAndTime. If you need a duration of time, use Duration. ! Item was changed: ----- Method: Time class>>clockPolicy: (in category 'class initialization') ----- clockPolicy: aSymbol "When sequencial calls are made to DateAndTime now, it may be desirable to force the system clock to be monotonic, and it may be desirable for the clock to appear to be strictly increasing with no repeat values. The ClockPolicy identifies which of several possible strategies to use. Allowable values are #acceptPlatformTime #monotonicAllowDuplicates #monotonicForceMicrosecondIncrement #monotonicForceNanosecondIncrement " + self assert: ( + #( + acceptPlatformTime + monotonicAllowDuplicates + monotonicForceMicrosecondIncrement + monotonicForceNanosecondIncrement) includes: aSymbol). ClockPolicy := aSymbol! Item was changed: ----- Method: Time class>>initialize (in category 'class initialization') ----- initialize + " self initialize " - "Time initialize" + LastClockTick ifNil: [ LastClockTick := 0 ]. - "Initialize at startup time to protect for the case of an image saved with bad LastClockTick" - LastClockTick := 0. + HighResClockTicksPerMillisecond ifNil: [ HighResClockTicksPerMillisecond := 0 ]. - HighResClockTicksPerMillisecond := 0. + ClockPolicy ifNil: [ + "self clockPolicy: #acceptPlatformTime." + self clockPolicy: #monotonicAllowDuplicates. + "self clockPolicy: #monotonicForceMicrosecondIncrement." + "self clockPolicy: #monotonicForceNanosecondIncrement." ]! - "self clockPolicy: #acceptPlatformTime." - self clockPolicy: #monotonicAllowDuplicates. - "self clockPolicy: #monotonicForceMicrosecondIncrement." - "self clockPolicy: #monotonicForceNanosecondIncrement." - ! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset (in category 'clock') ----- posixMicrosecondClockWithOffset "Answer an array with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." + | array posixUtcValue | - | array utcValue | array := self primPosixMicrosecondClockWithOffset. + posixUtcValue := array at: 1. + (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." + self primPosixMicrosecondClockWithOffset: array. + posixUtcValue := array at: 1 ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ array] . [#monotonicAllowDuplicates] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [array at: 1 put: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" array at: 1 put: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" array at: 1 put: LastClockTick]] } otherwise: []. + ^array! - ^array - - ! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset: (in category 'clock') ----- posixMicrosecondClockWithOffset: aDateAndTime "Initialize aDateAndTime initialized with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." + | posixUtcValue | - - | utcValue | self primPosixMicrosecondClockWithOffset: aDateAndTime. + posixUtcValue := aDateAndTime utcMicroseconds. + (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." + self primPosixMicrosecondClockWithOffset: aDateAndTime . + posixUtcValue := aDateAndTime utcMicroseconds ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ aDateAndTime] . [#monotonicAllowDuplicates] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" aDateAndTime utcMicroseconds: LastClockTick]] } otherwise: []. + ^aDateAndTime! - ^aDateAndTime - ! Item was added: + ----- Method: Time class>>primitiveUpdateTimeZone (in category 'clock') ----- + primitiveUpdateTimeZone + "Update the VMs notion of the current time zone. The VM sets its notion + of the time zone once at start-up. If one wants the VM to keep its notion + up-to-date arrange to invoke this primitive periodically." + + <primitive: 243> + ^nil "Return nil instead of self to indicate that the primitive failed."! Item was added: + ----- Method: Time class>>startUp: (in category 'system startup') ----- + startUp: resuming + + resuming ifTrue: [ + LastClockTick := 0 ]! Item was added: + ----- Method: Time class>>updateTimeZoneCacheAt: (in category 'clock') ----- + updateTimeZoneCacheAt: posixUtcMicrosecondClock + "Tell the VM to update its cached time zone value if the POSIX UTC time reached the valute stored in UpdateVMTimeZoneCacheAt has been reached. Assume that posixUtcMicrosecondClock is an integer with the current POSIX UTC microsecond clock value. Return true when the cache was updated to indicate that the time zone may have changed." + + | updateInterval | + UpdateVMTimeZoneCacheAt ifNil: [ + "Automatic update is disabled." + ^false ]. + posixUtcMicrosecondClock < UpdateVMTimeZoneCacheAt ifTrue: [ ^false ]. + self primitiveUpdateTimeZone ifNil: [ + "The primitive failed." + ^false ]. + updateInterval := 1800000000. "This could be a preference but 30 minutes matches all upcoming DST change times." + UpdateVMTimeZoneCacheAt := posixUtcMicrosecondClock // updateInterval + 1 * updateInterval "Round up posixUtcMicrosecondClock to the next multiple of updateInterval.". + ^true! Item was changed: + (PackageInfo named: 'Chronology-Core') postscript: '"Make sure UpdateVMTimeZoneCacheAt of Time is initialized." + Time classPool at: #UpdateVMTimeZoneCacheAt put: 0. + "Separated Time''s startup duties from DateAndTime." + Smalltalk addToStartUpList: Time before: DateAndTime'! - (PackageInfo named: 'Chronology-Core') postscript: 'DateAndTime startUp: true. - HashedCollection rehashAll. - '!

5 9

TTCFont >> flushCachedValues
by Tony Garnock-Jones 18 Sep '21

18 Sep '21

Hi all, I'm looking at the image-side DPI-change code, namely TextStyle >> pixelsPerInch:. The broadcast of the change is fine. But the handler in TTCFont is subtly wrong, I think. - I believe instance variables height, ascent, descent have to be nil'd as part of pixelsPerInchChanged. Is that right? Without nil'ing them, my TTCFonts don't resize properly. - This suggests flushCachedValues, which has NO SENDERS (!), should be folded into flushCache. Does that sound right? - Finally, if both the above hold, then pixelsPerInchChanged should be calling flushCache instead of recreateCache. Does that sound right? I'll be running for a few days with these changes in my image, to see if there are any obvious problems with them. But, before I push a commit out to Trunk, if I could get a thumbs-up from someone who knows a bit about the font subsystem, that'd be great! Regards, Tony

3 4

← Newer
1
...
4
5
6
7
8
9
10
...
40
Older →

Jump to page: