Squeak-dev April 2021

squeak-dev@lists.squeakfoundation.org

33 participants
392 discussions

The Trunk: MorphicTests-eem.74.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Eliot Miranda uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-eem.74.mcz ==================== Summary ==================== Name: MorphicTests-eem.74 Author: eem Time: 12 April 2021, 11:33:04.505845 am UUID: 90a13e5e-0e8c-4174-b9d3-15298b6c517c Ancestors: MorphicTests-mt.73 Fix some shadowed variable warning(s). =============== Diff against MorphicTests-mt.73 =============== Item was changed: ----- Method: MorphTest>>test10TransformKeepsLayer (in category 'tests - submorphs - layers') ----- test10TransformKeepsLayer + | aMorph transform | + aMorph := Morph new. - | morph transform | - morph := Morph new. transform := morph addFlexShell. + aMorph morphicLayerNumber: 50. - morph morphicLayerNumber: 50. self assert: 50 equals: transform morphicLayerNumber. transform morphicLayerNumber: 20. self assert: 20 equals: transform morphicLayerNumber. + transform removeMorph: aMorph. - transform removeMorph: morph. transform morphicLayerNumber: 50. self + assert: 20 equals: aMorph morphicLayerNumber; + assert: 50 equals: transform morphicLayerNumber! - assert: 20 equals: morph morphicLayerNumber; - assert: 50 equals: transform morphicLayerNumber.! Item was changed: ----- Method: MorphTest>>test12ResetLayerToDefault (in category 'tests - submorphs - layers') ----- test12ResetLayerToDefault + | aMorph default | + aMorph := Morph new. + default := aMorph morphicLayerNumber. - | morph default | - morph := Morph new. - default := morph morphicLayerNumber. + aMorph morphicLayerNumber: default * 2. + self deny: default equals: aMorph morphicLayerNumber. - morph morphicLayerNumber: default * 2. - self deny: default equals: morph morphicLayerNumber. morph morphicLayerNumber: nil. + self assert: default equals: aMorph morphicLayerNumber! - self assert: default equals: morph morphicLayerNumber.!

1 0

The Trunk: Monticello-eem.737.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Eliot Miranda uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-eem.737.mcz ==================== Summary ==================== Name: Monticello-eem.737 Author: eem Time: 12 April 2021, 11:31:38.465056 am UUID: 015970f1-92a9-4e6b-b0a2-9d6deba9d725 Ancestors: Monticello-mt.736 Eliminate shadowed variable warning(s). =============== Diff against Monticello-mt.736 =============== Item was changed: ----- Method: MCRepositoryInspector>>save (in category 'actions') ----- save self pickRepository ifNotNil: + [:repo | + (self repository = MCRepository inbox + and: [repo = MCRepository trunk or: [repo = MCRepository treated]]) ifTrue: + [self notify: 'Versions from the inbox should only be moved, not copied. Instead, use the web interface via source.squeak.org to manage inbox contributions.\\Do you want to proceed anyway?' translated withCRs]. + repo storeVersion: self version]! - [:repository | - (self repository = MCRepository inbox and: - [repository = MCRepository trunk or: [repository = MCRepository treated]]) ifTrue: - [self notify: 'Versions from the inbox should only be moved, not copied. Instead, use the web interface via source.squeak.org to manage inbox contributions.\\Do you want to proceed anyway?' translated withCRs]. - repository storeVersion: self version]!

1 0

The Trunk: MorphicExtras-eem.287.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Eliot Miranda uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-eem.287.mcz ==================== Summary ==================== Name: MorphicExtras-eem.287 Author: eem Time: 12 April 2021, 11:02:21.284327 am UUID: b74bcd77-a21f-4562-b441-5e2220720482 Ancestors: MorphicExtras-mt.286 Include the actual frame extent in the output of the CameraInterface test methods. =============== Diff against MorphicExtras-mt.286 =============== Item was changed: ----- Method: CameraInterface class>>interruptDrivenVideoTest: (in category 'test') ----- interruptDrivenVideoTest: camNum "A quick test of video input. Displays video on the screen until the mouse is pressed. Answer nil if the interrupt-driven interface is unavailable." "self interruptDrivenVideoTest: 1" "self interruptDrivenVideoTest: 2" "[self interruptDrivenVideoTest: 2] fork. self interruptDrivenVideoTest: 1" + | semaphore height frameExtent | - | semaphore height | height := 16. 1 to: camNum - 1 do: [:camIndex| "N.B. the of an unopened camera is 0@0" + height := height + (self frameExtent: camIndex) y + 16]. + (self cameraIsOpen: camNum) ifFalse: + [(self openCamera: camNum width: 352 height: 288) ifNil: - height := height + (CameraInterface frameExtent: camIndex) y + 16]. - (CameraInterface cameraIsOpen: camNum) ifFalse: - [(CameraInterface openCamera: camNum width: 352 height: 288) ifNil: [self inform: 'no camera'. ^nil]]. semaphore := Semaphore new. + [self camera: camNum setSemaphore: (Smalltalk registerExternalObject: semaphore)] - [CameraInterface camera: camNum setSemaphore: (Smalltalk registerExternalObject: semaphore)] on: Error do: [:err| Smalltalk unregisterExternalObject: semaphore. self inform: 'interrupt-driven camera interface unavailable: ', err messageText. ^nil]. [| f n startTime frameCount msecs fps | [semaphore wait. "N.B. the frame extent may not be known until the delivery of the first frame. So we have to delay initialization." startTime ifNil: + [(frameExtent := self frameExtent: camNum) x = 0 ifTrue: [self inform: 'no camera'. ^nil]. + f := Form extent: (self frameExtent: camNum) depth: 32. - [(self frameExtent: camNum) x = 0 ifTrue: [self inform: 'no camera'. ^nil]. - f := Form extent: (CameraInterface frameExtent: camNum) depth: 32. frameCount := 0. startTime := Time millisecondClockValue]. Sensor anyButtonPressed] whileFalse: + [n := self getFrameForCamera: camNum into: f bits. - [n := CameraInterface getFrameForCamera: camNum into: f bits. n > 0 ifTrue: [frameCount := frameCount + 1. f displayAt: 16 @ height]]. msecs := Time millisecondClockValue - startTime. fps := (frameCount * 1000) // msecs. + ^(self cameraName: camNum), ': ', frameExtent printString, ' ', frameCount printString, ' frames at ', fps printString, ' frames/sec'] - ^(CameraInterface cameraName: camNum), ': ', frameCount printString, ' frames at ', fps printString, ' frames/sec'] ensure: + [self closeCamera: camNum. - [CameraInterface closeCamera: camNum. Smalltalk unregisterExternalObject: semaphore. Sensor waitNoButton]! Item was changed: ----- Method: CameraInterface class>>videoTest: (in category 'test') ----- videoTest: camNum "A quick test of video input. Displays video on the screen until the mouse is pressed." "self videoTest: 1" "self videoTest: 2" + | frameExtent f n startTime frameCount msecs fps | + (self openCamera: camNum width: 320 height: 240) ifNil: [^ self inform: 'no camera']. - | f n startTime frameCount msecs fps | - (CameraInterface openCamera: camNum width: 320 height: 240) ifNil: [^ self inform: 'no camera']. self waitForCameraStart: camNum. + (frameExtent := self frameExtent: camNum) x = 0 ifTrue: [^ self inform: 'no camera']. + f := Form extent: (self frameExtent: camNum) depth: 32. - (self frameExtent: camNum) x = 0 ifTrue: [^ self inform: 'no camera']. - f := Form extent: (CameraInterface frameExtent: camNum) depth: 32. frameCount := 0. startTime := nil. + [Sensor anyButtonPressed] whileFalse: + [n := self getFrameForCamera: camNum into: f bits. + n > 0 ifTrue: + [startTime ifNil: [startTime := Time millisecondClockValue]. - [Sensor anyButtonPressed] whileFalse: [ - n := CameraInterface getFrameForCamera: camNum into: f bits. - n > 0 ifTrue: [ - startTime ifNil: [startTime := Time millisecondClockValue]. frameCount := frameCount + 1. f display]]. Sensor waitNoButton. msecs := Time millisecondClockValue - startTime. + self closeCamera: camNum. + fps := frameCount * 1000 // msecs. + ^frameExtent printString, ' ', frameCount printString, ' frames at ', fps printString, ' frames/sec'! - CameraInterface closeCamera: camNum. - fps := (frameCount * 1000) // msecs. - ^ frameCount printString, ' frames at ', fps printString, ' frames/sec'!

1 0

The Trunk: Tools-eem.1035.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.1035.mcz ==================== Summary ==================== Name: Tools-eem.1035 Author: eem Time: 12 April 2021, 10:50:12.075047 am UUID: 9f246bef-bed1-4852-8a0d-0ff3e243395f Ancestors: Tools-nice.1034 tempNames goes with namedTempAt: not tempAt: ; tempAt: merely being a more context-specific name (snuk snuk). =============== Diff against Tools-nice.1034 =============== Item was changed: ----- Method: Context>>tempsAndValuesLimitedTo:indent: (in category '*Tools-debugger access') ----- tempsAndValuesLimitedTo: sizeLimit indent: indent "Return a string of the temporary variabls and their current values" | aStream | aStream := WriteStream on: (String new: 100). self tempNames withIndexDo: [:title :index | indent timesRepeat: [aStream tab]. aStream nextPutAll: title; nextPut: $:; space; tab. aStream nextPutAll: + ((self namedTempAt: index) printStringLimitedTo: (sizeLimit - 3 - title size max: 1)). - ((self tempAt: index) printStringLimitedTo: (sizeLimit -3 -title size max: 1)). aStream cr]. ^aStream contents!

1 0

Revisiting the fix for nested exception handling
by Nicolas Cellier 12 Apr '21

12 Apr '21

Hi all, In order to purge the inbox, I've been in the process of reviewing brainfuck code (a very slow process). While at it, I decided to revisit the solution for nested exception handlers (see testHandlerFromAction). There are two similar and obsolete fixes in the inbox (due to ContextPart->Context transition), Kernel-nice.857 and Kernel-fbs.870 (backported from Cuis) that I moved to treated inbox for that reason. https://source.squeak.org/treated/Kernel-nice.857.diff https://source.squeak.org/treated/Kernel-fbs.870.diff Alas, those two solutions break the very peculiar expectations of testHandlerReentrancy. This is a pity, because to my knowledge, those expectations are essential for Tweak and Croquet. There was a previous attempt from Andreas which was more a simple hack in handleSignal:, that is to disable the handler by setting the temp variable handlerActive in on:do: to false (self tempAt: 3 put: false). I've generalized this solution. https://source.squeak.org/treated/Kernel-ar.540.diff However, there are several reasons why this does not work: the first one, objected by Julian Fitzell here http://lists.squeakfoundation.org/pipermail/squeak-dev/2011-January/156453.… is that the handler must be able to handle a secondary exception raised by the defaultAction. We can find similar expectations with other exception handling, like resignalAs (I will publish another test soon). However, there is some simple strategy: before resuming the exception, scan the context stack a second time so as to rearm the exception handlers that we disabled during handleSignal:. The major drawback, is that I have to spread a few self reactivateHandlers here and there, virtually before every send of #resumedUnchecked:. The second drawback is that scanning the stack a second time is not the most economical solution, but I don't care too much, we have to make it right first. If you find the courage to review, or more easily just to test it, find it in the inbox... Oups, I accidentally published in trunk... Well the review will be forced, if you don't like it, admin please remove or revert. Sorry.

3 3

The Trunk: Network-nice.246.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-nice.246.mcz ==================== Summary ==================== Name: Network-nice.246 Author: nice Time: 12 April 2021, 5:35:00.782058 pm UUID: 09001f79-2f03-bb46-be00-2b54f5b89d36 Ancestors: Network-mt.245 Redo the fix from Network-ct.242 with a slighlty different implementation: 1) use exception retry 2) avoid using in: aBlock where a temporary would do the job. Thanks to Christophe for original report and fix! (https://source.squeak.org/treated/Network-ct.242.diff) Original commit message below: Fixes two MNUs that can occur during connecting to an unavailable network resource. Bug #1 (stream>>>#timeout:) Steps to reproduce: 1. Start your image while an internet connection is available. Make any connection attempt (e.g. refresh a Monticello HTTP(s) repository) to ensure that the network is initialized (NetNameResolver initializeNetwork). 2. There are two alternative scenarios: 2.(i) Do it: WebClient httpGet: 'https://foo.bar'. 2.(ii) Turn off your internet connection (e.g. disable your WLAN adapter). Then make another connection attempt. In both scenarios, you will see the following error: MessageNotUnderstood: UndefinedObject>>timeout: (stream) WebClient>>connect WebClient>>sendRequest:contentBlock: ... This bug occurred because there was no check for the presence of any network socket for the request host/port. Bug #2 (#findNextHandlerContextStarting): Steps to reproduce: Do it: WebClient httpGet: 'https://'. Error: MessageNotUnderstood: UndefinedObject>>findNextHandlerContextStarting Context>>nextHandlerContext ConnectionRefused(Exception)>>pass ... =============== Diff against Network-mt.245 =============== Item was changed: ----- Method: SocketStream class>>openConnectionToHostNamed:port: (in category 'instance creation') ----- openConnectionToHostNamed: hostName port: portNumber + | addressInformations stream | NetNameResolver useOldNetwork ifTrue: [ | hostIP | hostIP := NetNameResolver addressForName: hostName timeout: 20. hostIP ifNil: [NetworkError signal: ('Cannot resolve {1}.' format: {hostName})]. + ^self openConnectionToHost: hostIP port: portNumber]. + addressInformations := SocketAddressInformation + forHost: hostName + service: portNumber asString + flags: 0 + addressFamily: 0 + socketType: SocketAddressInformation socketTypeStream + protocol: SocketAddressInformation protocolTCP. + addressInformations ifEmpty: [ + NoNetworkError signal: ('Could not find a network for {1} on port {2}' translated format: {hostName. portNumber})]. + stream := addressInformations readStream. + ^ [self on: stream next connect] on: NetworkError + do: [:exc | stream atEnd + ifTrue: + ["No more address to retry, pass the exception to upper level" + exc pass] + ifFalse: + ["retry with next address" + exc retry]].! - ^self openConnectionToHost: hostIP port: portNumber] - ifFalse: [| addressInformations lastError | - addressInformations := SocketAddressInformation - forHost: hostName - service: portNumber asString - flags: 0 - addressFamily: 0 - socketType: SocketAddressInformation socketTypeStream - protocol: SocketAddressInformation protocolTCP. - addressInformations do: [:addressInformation | - [^ self on: addressInformation connect] on: NetworkError do: [:e | lastError := e]]. - ^ lastError ifNotNil: [:e | e pass]]!

1 0

The Inbox: KernelTests-jar.397.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-jar.397.mcz ==================== Summary ==================== Name: KernelTests-jar.397 Author: jar Time: 12 April 2021, 9:43:54.742464 am UUID: 6cf87c25-8484-a144-aa35-761de4aa60c1 Ancestors: KernelTests-codefrau.395 Clean up: release all processes still waiting at the semaphore or in the active priority queue. ProcessTest>>#testProcessStateTests doesn't terminate processes it opened. =============== Diff against KernelTests-codefrau.395 =============== Item was changed: ----- Method: ProcessTest>>testProcessStateTests (in category 'tests') ----- testProcessStateTests | semaphore | self assert: Processor activeProcess isActiveProcess. self deny: Processor activeProcess isBlocked. self assert: Processor activeProcess isRunnable. self deny: Processor activeProcess isSuspended. self deny: Processor activeProcess isTerminated. semaphore := Semaphore new. "These processes are runnable but haven't got to the wait yet because the active process is running." self deny: ([semaphore wait] forkAt: Processor activePriority) isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) isBlocked. self assert: ([semaphore wait] forkAt: Processor activePriority) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority) isTerminated. self deny: ([semaphore wait] forkAt: Processor activePriority) suspendingList == semaphore. + "These processes do get to run because, being higher priority they preempt the active process until they wait on the semaphore." - "These processes do get to run because, being higher priority they preempt the active process until yhey wait on the semaphore." self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isActiveProcess. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isSuspended. self deny: ([semaphore wait] forkAt: Processor activePriority + 1) isTerminated. self assert: ([semaphore wait] forkAt: Processor activePriority + 1) suspendingList == semaphore. "These processes should be suspended, not terminated." self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isRunnable. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isSuspended. self deny: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess suspend] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be terminated, not suspended." self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isActiveProcess. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isBlocked. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isRunnable. self deny: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isSuspended. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) isTerminated. self assert: ([Processor activeProcess terminate] forkAt: Processor activePriority + 1) suspendingList isNil. "These processes should be suspended." self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isActiveProcess. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isBlocked. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isRunnable. self assert: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isSuspended. self deny: (([semaphore wait] forkAt: Processor activePriority) suspend; yourself) isTerminated. "These processes should be terminated." self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isActiveProcess. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isBlocked. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isRunnable. self deny: ([semaphore wait] forkAt: Processor activePriority) terminate isSuspended. + self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated. + + "Clean up: release all processes still waiting at the semaphore or in the active priority queue." + Processor yield. + [semaphore isEmpty] whileFalse: [semaphore signal] + ! - self assert: ([semaphore wait] forkAt: Processor activePriority) terminate isTerminated!

1 0

The Trunk: Tools-nice.1034.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Nicolas Cellier uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-nice.1034.mcz ==================== Summary ==================== Name: Tools-nice.1034 Author: nice Time: 10 April 2021, 10:41:23.083509 pm UUID: fe72aa70-5707-479b-a576-e2950cfcf6a3 Ancestors: Tools-mt.1033 Quick fix for enabling search of references to a number or other literal from within a message list Example: 86400 cmd+n $a cmd+n #(0) cmd+n Note: it won't necessarily highlight numbers formatted differently like 16rFF for 255... This would probably require AST based search. =============== Diff against Tools-mt.1033 =============== Item was changed: ----- Method: MessageTrace>>addParentMethodsSending: (in category 'building') ----- addParentMethodsSending: selectorSymbol | methodsList | (methodsList := self systemNavigation allCallsOn: selectorSymbol) isEmpty ifTrue: [ ^(PopUpMenu labels: ' OK ') startUpWithCaption: 'There are no methods that send ', selectorSymbol ] ifFalse: [ self addParentMessages: methodsList + autoSelectString: selectorSymbol asString]! - autoSelectString: selectorSymbol ] - !

2 1

The Trunk: SqueakSSL-Core-mt.34.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Marcel Taeumel uploaded a new version of SqueakSSL-Core to project The Trunk: http://source.squeak.org/trunk/SqueakSSL-Core-mt.34.mcz ==================== Summary ==================== Name: SqueakSSL-Core-mt.34 Author: mt Time: 12 April 2021, 9:14:25.544134 am UUID: 6814d7e9-d82d-5243-a25d-204a1d38dcd9 Ancestors: SqueakSSL-Core-topa.33 Complements Network-mt.245 (pre.244) =============== Diff against SqueakSSL-Core-topa.33 =============== Item was removed: - ----- Method: SecureSocketStream>>receiveDataIfAvailable (in category 'private-compat') ----- - receiveDataIfAvailable - "Pre Squeak 4.2 compatibility" - - ^self receiveAvailableData - !

1 0

The Trunk: Network-mt.245.mcz
by commits＠source.squeak.org 12 Apr '21

12 Apr '21

Marcel Taeumel uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-mt.245.mcz ==================== Summary ==================== Name: Network-mt.245 Author: mt Time: 12 April 2021, 9:12:16.314134 am UUID: b6adb21b-aa53-2341-9ef4-2220394f68d3 Ancestors: Network-ct.244, Network-pre.244 Merges ancestry. =============== Diff against Network-ct.244 =============== Item was removed: - ----- Method: SocketStream>>receiveDataIfAvailable (in category 'private-socket') ----- - receiveDataIfAvailable - "Deprecated. Use #receiveAvailableData instead" - - ^self receiveAvailableData!

1 0

Jump to page: