Squeak-dev March 2021

squeak-dev@lists.squeakfoundation.org

32 participants
257 discussions

The Inbox: System-ct.1156.mcz
by commits＠source.squeak.org 07 Dec '21

07 Dec '21

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1156.mcz ==================== Summary ==================== Name: System-ct.1156 Author: ct Time: 5 May 2020, 5:41:10.96399 pm UUID: 2ce2496e-92e9-f744-9a58-d9e9320adfab Ancestors: System-mt.1155 Fixes double prompt for handling a dropped file when the first dialog was cancelled. Cleans up duplication between ExternalDropHandler >> #lookupServiceBasedHandler: and DefaultExternalDropHandler by deprecating the first one. Maybe we can also remove this method? =============== Diff against System-mt.1155 =============== Item was changed: ----- Method: DefaultExternalDropHandler>>chooseServiceFrom: (in category 'private') ----- chooseServiceFrom: aCollection + "private - choose a service from aCollection asking the user if needed" + ^ aCollection size = 1 - "private - choose a service from aCollection asking the user if needed" - ^aCollection size = 1 ifTrue: [aCollection anyOne] + ifFalse: [UIManager default + chooseFrom: (aCollection collect: [:each | each label]) - ifFalse:[UIManager default - chooseFrom: (aCollection collect:[:each| each label]) values: aCollection title: 'You dropped a file. Please choose a service:' translated withCRs].! Item was changed: ----- Method: DefaultExternalDropHandler>>handle:in:dropEvent: (in category 'event handling') ----- handle: dropStream in: pasteUp dropEvent: anEvent "the file was just droped, let's do our job" | fileName services chosen | fileName := dropStream name. services := self servicesForFileNamed: fileName. + - "no service, default behavior" + services ifEmpty: [ + ^ UIManager default edit: dropStream contentsOfEntireFile]. + - services isEmpty - ifTrue: [^UIManager default edit: dropStream contentsOfEntireFile]. - chosen := self chooseServiceFrom: services. + chosen ifNotNil: [chosen performServiceFor: dropStream].! - chosen ifNotNil:[chosen performServiceFor: dropStream]! Item was changed: ----- Method: DefaultExternalDropHandler>>servicesForFileNamed: (in category 'private') ----- servicesForFileNamed: aString + "private - answer a collection of file-services for the file named aString" + + ^ (FileServices itemsForFile: aString) + copyWithoutAll: self unwantedSelectors! - "private - answer a collection of file-services for the file named - aString" - | allServices | - allServices := FileServices itemsForFile: aString. - ^ allServices - reject: [:svc | self unwantedSelectors includes: svc selector]! Item was changed: ----- Method: ExternalDropHandler class>>defaultHandler (in category 'accessing') ----- defaultHandler + + ^ DefaultHandler ifNil: [ + DefaultHandler := ExternalDropHandler + type: nil + extension: nil + action: #edit]! - DefaultHandler ifNil: [DefaultHandler := ExternalDropHandler type: nil extension: nil action: [:dropStream | dropStream edit]]. - ^DefaultHandler! Item was changed: ----- Method: ExternalDropHandler class>>lookupExternalDropHandler: (in category 'accessing') ----- lookupExternalDropHandler: stream | types extension serviceHandler | types := stream mimeTypes. types ifNotNil: [ + self registeredHandlers + detect: [:handler | handler matchesTypes: types] + ifFound: [:handler | ^ handler]]. - self registeredHandlers do: [:handler | - (handler matchesTypes: types) - ifTrue: [^handler]]]. extension := FileDirectory extensionFor: stream name. + self registeredHandlers + detect: [:handler | handler matchesExtension: extension] + ifFound: [:handler | ^ handler]. + + ^ serviceHandler ifNil: [self defaultHandler]! - self registeredHandlers do: [:handler | - (handler matchesExtension: extension) - ifTrue: [^handler]]. - serviceHandler := self lookupServiceBasedHandler: stream. - ^serviceHandler - ifNil: [self defaultHandler]! Item was changed: ----- Method: ExternalDropHandler class>>lookupServiceBasedHandler: (in category 'accessing') ----- lookupServiceBasedHandler: dropStream + - "The file was just dropped; let's do our job" | fileName services theOne | + self deprecated: 'ct: Use DefaultExternalDropHandler'. fileName := dropStream name. - services := (FileServices itemsForFile: fileName) reject: [:svc | self unwantedSelectors includes: svc selector]. + - "no service, default behavior" + services ifEmpty: [^ nil]. + - services isEmpty - ifTrue: [^nil]. - theOne := self chooseServiceFrom: services. + ^ theOne ifNotNil: [ + ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]! - ^theOne - ifNotNil: [ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]!

3 3

The Inbox: ShoutCore-ct.69.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

A new version of ShoutCore was added to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ct.69.mcz ==================== Summary ==================== Name: ShoutCore-ct.69 Author: ct Time: 14 August 2019, 10:43:04.7164 pm UUID: 7d165f4e-09bf-a445-a664-5e8edb9867b8 Ancestors: ShoutCore-ul.68 Fix bug in SHParserST80: Wrong styling after blocks with arguments without statements Thanks Jakob for the report! =============== Diff against ShoutCore-ul.68 =============== Item was changed: ----- Method: SHParserST80>>parseBlockArguments (in category 'parse') ----- parseBlockArguments currentTokenFirst == $: ifFalse: [ ^self ]. [ currentTokenFirst == $: ] whileTrue: [ self scanPast: #blockArgColon; parseArgument: #blockPatternArg ]. + ((self parseVerticalBarForTemporaries: #blockArgsBar) and: [ + currentTokenFirst ~= $] ]) + ifFalse: [ + self fail ": Missing block args bar" ]! - (self parseVerticalBarForTemporaries: #blockArgsBar) ifFalse: [ - self fail ": Missing block args bar" ]!

12 25

The Inbox: Tools-ct.937.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.937.mcz ==================== Summary ==================== Name: Tools-ct.937 Author: ct Time: 29 January 2020, 6:26:57.711894 pm UUID: 34af35bc-83e2-9b40-9aa3-8f6af607ac6e Ancestors: Tools-mt.929 Fixes a styling issue in the Workspace that missstyled class variables from Object as invalid (that is DependentsFields). This is a bug because you can access DependentsFields indeed. There is a subtle but important difference between the classOrMetaclass nil and the classOrMetaclass Object: The former does not respect any state for styling, but the latter respects class variables from Object (as well as, hypothetically, ProtoObject). Please note that it would be even more accurate to specify nil class instead of Object here, but I don't know whether we really want to emphasize the nuances of UndefinedObject. It feels rather like an implementation detail for me, at least in this context. (Just imagine UndefinedObject had a UniqueInstance class variable - would we really to access it from any Workspace?) Open for opinions. =============== Diff against Tools-mt.929 =============== Item was changed: ----- Method: Workspace>>aboutToStyle: (in category 'code pane') ----- aboutToStyle: aStyler self shouldStyle ifFalse: [ ^false ]. + aStyler + parseAMethod: false; + classOrMetaClass: Object; - aStyler - classOrMetaClass: nil; workspace: self. ^true!

4 3

Merge Request: #caseOf:otherwise: with arguments
by Thiede, Christoph 28 Nov '21

28 Nov '21

This changeset makes it possible to accept an argument in the otherwise block of a #caseOf:otherwise: call. Diff of the #caseOf:otherwise: implementation: caseOf: aBlockAssociationCollection otherwise: aBlock "The elements of aBlockAssociationCollection are associations between blocks. Answer the evaluated value of the first association in aBlockAssociationCollection whose evaluated key equals the receiver. If no match is found, answer the result of evaluating aBlock." aBlockAssociationCollection associationsDo: [:assoc | (assoc key value = self) ifTrue: [^assoc value value]]. - ^ aBlock value + ^ aBlock cull: self "| z | z := {[#a]->[1+1]. ['b' asSymbol]->[2+2]. [#c]->[3+3]}. #b caseOf: z otherwise: [0]" "| z | z := {[#a]->[1+1]. ['d' asSymbol]->[2+2]. [#c]->[3+3]}. #b caseOf: z otherwise: [0]" "The following are compiled in-line:" "#b caseOf: {[#a]->[1+1]. ['b' asSymbol]->[2+2]. [#c]->[3+3]} otherwise: [0]" "#b caseOf: {[#a]->[1+1]. ['d' asSymbol]->[2+2]. [#c]->[3+3]} otherwise: [0]" + "#b caseOf: {[#a]->[1+1]. ['d' asSymbol]->[2+2]. [#c]->[3+3]} otherwise: [:x | x halt]" Furthermore, the changeset includes a necessary modification of MessageNode >> #transformCase: so that the otherwise argument can be compiled in-line. Last but not least, I wrote some tests for #caseOf:[otherwise:]. Please review! (In a later change, it would be possible to allow arguments for the association key blocks as well. But I love short feedback loops, so let's assess this one first :-)) Best, Christoph

4 9

Merge Request: removeClass.cs
by Thiede, Christoph 18 Nov '21

18 Nov '21

This changeset refactors the #removeClass logic (which has been upgraded by Marcel recently) and extracts it to SystemNavigation, analogously to System-ct.1221. It also refines the dialog to search for senders and subclasses of the class to remove as we know it from #removeMessage. [cid:21b5558d-d73d-4d2c-bcc4-eeb40f7dee49] Please merge or give me feedback for improvements. :-) Best, Christoph

2 9

BUG/REGRESSION while debugging Generator >> #nextPut:
by Thiede, Christoph 15 Nov '21

15 Nov '21

Hi all, I discovered a bug when stepping over a call to Generator >> #nextPut:. !! Save your image before trying the following !! Generator on: [:stream | stream nextPut: #foo] [cid:95952b5e-98f1-4447-bd09-29d396961281] 1. Due to multiprocessing implementation of the Generator, pressing over will hang up the current process forever, because the generator is never queried. 2. If I press cmd-dot, I get an infinite number of debugger windows that show Context >> #cannotReturn:. This will probably damage your image. The first is annoying for newcomers, but I see this behavior is reasonable and without the effect of the second, it wouldn't be a big problem. The second, however, looks like a bigger issue to me. Actually, I think the most serious aspect is that in Squeak 5.1, the same procedure does not crash your image, but you are forwarded to the emergency debugger and can terminate the process: [cid:c8eee8c3-d2de-49c0-b5d4-33bd340d6c98] [cid:6044ecf2-91ab-4f6e-b863-b980586868e9] Also, this is not the first scenario in the last time where I got an infinite debugger chain. See [BUG(s)] in Context control (#jump, #runUntilErrorOrReturnFrom:)<http://forum.world.st/BUG-s-in-Context-control-jump-runUntilErrorOrReturnFr…> for a similar issue. And there were even more situations which I could not yet reproduce exactly. I'm afraid that the recent changes to the debuggers might have weakened its ability to detect recursive errors. Can someone else tell about these problems? I suppose we ignore a large number of recursive errors as in MorphicDebugger >> #openOn:context:label:contents:fullView:, the uiBlock is often triggered as a separate UI message which will be executed after the recursion flag has been cleared by the base class. Would be great if someone could have a look at it or share more information :) Best, Christoph

8 25

The Trunk: Kernel-eem.1366.mcz
by commits＠source.squeak.org 02 Nov '21

02 Nov '21

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1366.mcz ==================== Summary ==================== Name: Kernel-eem.1366 Author: eem Time: 26 January 2021, 4:27:57.204259 pm UUID: 3a706d32-c2d6-416f-82c1-bbf735650385 Ancestors: Kernel-eem.1365 Slightly faster implementation of Context>>#isPrimFailToken:. Improve the comments in Context>>#isHandlerContext/#isUnwindContext. Nuke an obsolete method. =============== Diff against Kernel-eem.1365 =============== Item was changed: ----- Method: Context>>isHandlerContext (in category 'private-exceptions') ----- isHandlerContext + "Answer if the receiver is for a method that is marked as an exception handler. + BlockClosure>>#on:do: uses this primitive to identify itself to the VM + as an exception handler method, which the VM uses in primitive 197 + Context>>#findNextHandlerContextStarting, primitiveFindHandlerContext, + to accelerate the search for exception handlers." - "is this context for method that is marked?" ^method primitive = 199! Item was changed: ----- Method: Context>>isPrimFailToken: (in category 'private') ----- isPrimFailToken: anObject + ^(self objectClass: anObject) isArray - ^(self objectClass: anObject) == Array and: [anObject size = 2 + and: [(anObject at: 1) == PrimitiveFailToken]]! - and: [anObject first == PrimitiveFailToken]]! Item was changed: ----- Method: Context>>isUnwindContext (in category 'private-exceptions') ----- isUnwindContext + "Answer if the receiver is for a method that is marked as a non-local return/exception unwind protect. + BlockClosure>>#ensure: and BlockClosure>>#ifCurtailed: use this primitive to identify + themseves to the VM as unwind protect methods. The VM uses this in primitive 195 + Context>>#findNextUnwindContextUpTo:, primitiveFindNextUnwindContext, to + accelerate the search for unwind protects." - "is this context for method that is marked?" ^method primitive = 198! Item was removed: - ----- Method: Context>>tryPrimitiveFor:receiver:args: (in category 'private') ----- - tryPrimitiveFor: method receiver: receiver args: arguments - "If this method has a primitive index, then run the primitive and return its result. - Otherwise (and also if the primitive fails) return PrimitiveFailToken, - as an indication that the method should be activated and run as bytecodes." - | primIndex | - (primIndex := method primitive) = 0 ifTrue: [^{PrimitiveFailToken. nil}]. - ^ self doPrimitive: primIndex method: method receiver: receiver args: arguments!

7 21

The Trunk: Network-dtl.240.mcz
by commits＠source.squeak.org 21 Sep '21

21 Sep '21

David T. Lewis uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-dtl.240.mcz ==================== Summary ==================== Name: Network-dtl.240 Author: dtl Time: 6 April 2020, 10:33:07.751386 pm UUID: a8f00e08-7398-4d4a-8cd2-09cedcada729 Ancestors: Network-eem.239 This update enables the Squeak new networking and IPv6 support by default. The update is in the package postscript. IPv6 network support for the VM (SocketPlugin) and image were implemented by Ian Piumarta circa 2007. This included IPv6 support and a more general image-side representation of network addressing. In 2012, this work was merged into Squeak trunk, with a preference to switch between the old networking support or the new networking support with IPv6. At that time, there were concerns with performance of NetNameResolver on some Windows platforms, and for this reason the "Enable IPv6 and new network support" preference was left disabled for official Squeak distributions. It now 2020, and operating systems have improved over the years, so it is time to enable the new networking preference by default. =============== Diff against Network-eem.239 =============== Item was changed: + (PackageInfo named: 'Network') postscript: '"Enable IPv6 and new network support by default" + NetNameResolver enableIPv6: true + '! - (PackageInfo named: 'Network') postscript: '"Rebuild CSNonAtom." - MailAddressTokenizer cleanUp: false'!

8 14

The Trunk: Chronology-Core-ul.55.mcz
by commits＠source.squeak.org 19 Sep '21

19 Sep '21

Levente Uzonyi uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-ul.55.mcz ==================== Summary ==================== Name: Chronology-Core-ul.55 Author: ul Time: 31 May 2020, 12:10:20.250221 am UUID: ea36b609-177c-405a-b64e-9988deb3d26e Ancestors: Chronology-Core-nice.52 Automatically update the time zone cached by the VM every 30 minutes: - copied and modified Eliot's accessor to primitive 243 to do the actual updating (Time class >> #primitiveUpdateTimeZone) - update happens when Time class >> #posixMicrosecondClockWithOffset or Time class >> #posixMicrosecondClockWithOffset: are sent. Other low-level accessors of the VM time zone are not updating the cached time zone value (e.g. Time class >> #localMicrosecondClockPrimitive) - actual update happens in Time class >> #updateTimeZoneCacheAt: - postscript activates the update mechanism which can be turned off by evaluating [ Time classPool at: #UpdateVMTimeZoneCacheAt put: nil ] Other changes: - do not send Time class >> #initialize from DateAndTime class >> #startUp:. Let Time have its own #startUp: method instead. Postscript adds Time to the startUpList before DateAndTime. - do not send super initialize from DateAndTime class >> #initialize - do not send #automaticTimezone to DateAndTime on startup, because that's just an accessor with no side effects - do not overwrite set variables in Time class >> #initialize - assert that the value passed to Time class >> #clockPolicy: is one of the known values =============== Diff against Chronology-Core-nice.52 =============== Item was changed: ----- Method: DateAndTime class>>initialize (in category 'initialize-release') ----- initialize - super initialize. - ClockProvider := Time. PosixEpochJulianDays := 2440588. InitializeFromPrimitive := self canInitializeFromPrimitive. Smalltalk addToStartUpList: self. self startUp: true ! Item was changed: ----- Method: DateAndTime class>>startUp: (in category 'system startup') ----- startUp: startingAfresh "Set local timezone" startingAfresh ifTrue: [InitializeFromPrimitive := self canInitializeFromPrimitive. Time initialize. "set LastClockTick to 0". + self now]! - self now. - self automaticTimezone]! Item was changed: Magnitude subclass: #Time instanceVariableNames: 'seconds nanos' + classVariableNames: 'ClockPolicy HighResClockTicksPerMillisecond LastClockTick UpdateVMTimeZoneCacheAt UseHighResClockForTiming' - classVariableNames: 'ClockPolicy HighResClockTicksPerMillisecond LastClockTick UseHighResClockForTiming' poolDictionaries: 'ChronologyConstants' category: 'Chronology-Core'! !Time commentStamp: 'dew 10/23/2004 17:58' prior: 0! This represents a particular point in time during any given day. For example, '5:19:45 pm'. If you need a point in time on a particular day, use DateAndTime. If you need a duration of time, use Duration. ! Item was changed: ----- Method: Time class>>clockPolicy: (in category 'class initialization') ----- clockPolicy: aSymbol "When sequencial calls are made to DateAndTime now, it may be desirable to force the system clock to be monotonic, and it may be desirable for the clock to appear to be strictly increasing with no repeat values. The ClockPolicy identifies which of several possible strategies to use. Allowable values are #acceptPlatformTime #monotonicAllowDuplicates #monotonicForceMicrosecondIncrement #monotonicForceNanosecondIncrement " + self assert: ( + #( + acceptPlatformTime + monotonicAllowDuplicates + monotonicForceMicrosecondIncrement + monotonicForceNanosecondIncrement) includes: aSymbol). ClockPolicy := aSymbol! Item was changed: ----- Method: Time class>>initialize (in category 'class initialization') ----- initialize + " self initialize " - "Time initialize" + LastClockTick ifNil: [ LastClockTick := 0 ]. - "Initialize at startup time to protect for the case of an image saved with bad LastClockTick" - LastClockTick := 0. + HighResClockTicksPerMillisecond ifNil: [ HighResClockTicksPerMillisecond := 0 ]. - HighResClockTicksPerMillisecond := 0. + ClockPolicy ifNil: [ + "self clockPolicy: #acceptPlatformTime." + self clockPolicy: #monotonicAllowDuplicates. + "self clockPolicy: #monotonicForceMicrosecondIncrement." + "self clockPolicy: #monotonicForceNanosecondIncrement." ]! - "self clockPolicy: #acceptPlatformTime." - self clockPolicy: #monotonicAllowDuplicates. - "self clockPolicy: #monotonicForceMicrosecondIncrement." - "self clockPolicy: #monotonicForceNanosecondIncrement." - ! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset (in category 'clock') ----- posixMicrosecondClockWithOffset "Answer an array with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." + | array posixUtcValue | - | array utcValue | array := self primPosixMicrosecondClockWithOffset. + posixUtcValue := array at: 1. + (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." + self primPosixMicrosecondClockWithOffset: array. + posixUtcValue := array at: 1 ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ array] . [#monotonicAllowDuplicates] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [array at: 1 put: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" array at: 1 put: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" array at: 1 put: LastClockTick]] } otherwise: []. + ^array! - ^array - - ! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset: (in category 'clock') ----- posixMicrosecondClockWithOffset: aDateAndTime "Initialize aDateAndTime initialized with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." + | posixUtcValue | - - | utcValue | self primPosixMicrosecondClockWithOffset: aDateAndTime. + posixUtcValue := aDateAndTime utcMicroseconds. + (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." + self primPosixMicrosecondClockWithOffset: aDateAndTime . + posixUtcValue := aDateAndTime utcMicroseconds ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ aDateAndTime] . [#monotonicAllowDuplicates] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" aDateAndTime utcMicroseconds: LastClockTick]] } otherwise: []. + ^aDateAndTime! - ^aDateAndTime - ! Item was added: + ----- Method: Time class>>primitiveUpdateTimeZone (in category 'clock') ----- + primitiveUpdateTimeZone + "Update the VMs notion of the current time zone. The VM sets its notion + of the time zone once at start-up. If one wants the VM to keep its notion + up-to-date arrange to invoke this primitive periodically." + + <primitive: 243> + ^nil "Return nil instead of self to indicate that the primitive failed."! Item was added: + ----- Method: Time class>>startUp: (in category 'system startup') ----- + startUp: resuming + + resuming ifTrue: [ + LastClockTick := 0 ]! Item was added: + ----- Method: Time class>>updateTimeZoneCacheAt: (in category 'clock') ----- + updateTimeZoneCacheAt: posixUtcMicrosecondClock + "Tell the VM to update its cached time zone value if the POSIX UTC time reached the valute stored in UpdateVMTimeZoneCacheAt has been reached. Assume that posixUtcMicrosecondClock is an integer with the current POSIX UTC microsecond clock value. Return true when the cache was updated to indicate that the time zone may have changed." + + | updateInterval | + UpdateVMTimeZoneCacheAt ifNil: [ + "Automatic update is disabled." + ^false ]. + posixUtcMicrosecondClock < UpdateVMTimeZoneCacheAt ifTrue: [ ^false ]. + self primitiveUpdateTimeZone ifNil: [ + "The primitive failed." + ^false ]. + updateInterval := 1800000000. "This could be a preference but 30 minutes matches all upcoming DST change times." + UpdateVMTimeZoneCacheAt := posixUtcMicrosecondClock // updateInterval + 1 * updateInterval "Round up posixUtcMicrosecondClock to the next multiple of updateInterval.". + ^true! Item was changed: + (PackageInfo named: 'Chronology-Core') postscript: '"Make sure UpdateVMTimeZoneCacheAt of Time is initialized." + Time classPool at: #UpdateVMTimeZoneCacheAt put: 0. + "Separated Time''s startup duties from DateAndTime." + Smalltalk addToStartUpList: Time before: DateAndTime'! - (PackageInfo named: 'Chronology-Core') postscript: 'DateAndTime startUp: true. - HashedCollection rehashAll. - '!

5 9

TTCFont >> flushCachedValues
by Tony Garnock-Jones 18 Sep '21

18 Sep '21

Hi all, I'm looking at the image-side DPI-change code, namely TextStyle >> pixelsPerInch:. The broadcast of the change is fine. But the handler in TTCFont is subtly wrong, I think. - I believe instance variables height, ascent, descent have to be nil'd as part of pixelsPerInchChanged. Is that right? Without nil'ing them, my TTCFonts don't resize properly. - This suggests flushCachedValues, which has NO SENDERS (!), should be folded into flushCache. Does that sound right? - Finally, if both the above hold, then pixelsPerInchChanged should be calling flushCache instead of recreateCache. Does that sound right? I'll be running for a few days with these changes in my image, to see if there are any obvious problems with them. But, before I push a commit out to Trunk, if I could get a thumbs-up from someone who knows a bit about the font subsystem, that'd be great! Regards, Tony

3 4

← Newer
1
2
3
4
5
6
7
8
9
...
26
Older →

Jump to page: