Squeak-dev December 2020

squeak-dev@lists.squeakfoundation.org

32 participants
173 discussions

The Trunk: Files-eem.184.mcz
by commits＠source.squeak.org 08 Jan '21

08 Jan '21

Eliot Miranda uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-eem.184.mcz ==================== Summary ==================== Name: Files-eem.184 Author: eem Time: 29 November 2020, 10:24:50.876717 am UUID: 453a229c-9b4d-4acb-b8ba-c0688fc17020 Ancestors: Files-pre.183 Add a guard to FileDirectory class>>requestDropDirectory:. Every time I connect my headphone buds I get an MNU because primDropRequestFileName: answers nil. This squashes the MNU. =============== Diff against Files-pre.183 =============== Item was changed: ----- Method: FileDirectory class>>requestDropDirectory: (in category 'dnd requests') ----- requestDropDirectory: dropIndex + ^(FileStream primDropRequestFileName: dropIndex) ifNotNil: + [:dropFileDirdectoryName| | potentialDirectory | + potentialDirectory := self on: dropFileDirdectoryName. + potentialDirectory exists ifTrue: [potentialDirectory]]! - | potentialDirectory | - potentialDirectory := self on: (FileStream primDropRequestFileName: dropIndex). - ^ potentialDirectory exists ifTrue: [potentialDirectory] - !

3 2

A discrepancy between bytecode execution and simulation
by Thiede, Christoph 07 Jan '21

07 Jan '21

Hi all, hi Eliot, I constructed the following code snippet which evaluates to true when running it using the production execution machinery: nil == thisContext pop I guess this is fine, because what alternatives would the execution machinery have? It could terminate the whole VM or we could introduce something like #cannotReturn: for invalid stack frame objects. Probably the current implementation is the best despite an invalid position in the context stack has been addressed. However, the simulation machinery treats the same snippet differently, and it throws: Error: subscript is out of bounds: 0 I wonder whether it is acceptable to have diverging behaviors for such an ill-defined edge case between simulation and production (btw did I choose the right terms for them? :)). Might it a better alternative to raise a Warning (#notify:) only and then return nil such as the VM appears to do? Best, Christoph

5 6

The Inbox: System-dtl.1209.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

David T. Lewis uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-dtl.1209.mcz ==================== Summary ==================== Name: System-dtl.1209 Author: dtl Time: 28 December 2020, 10:50:06.875257 am UUID: 25efba24-561f-4c53-97d9-95438edfce90 Ancestors: System-eem.1207 Provide vmParameterAt:default: to handle primitive failure on reading VM parameters. Supply default parameter values to mock possibly missing elements in the parameters array. Remove two unnecessary isRunningCog checks and an ifNotNil: Remove inappropriate halt in sendMouseWheelEvents: Let supportsMultipleBytecodeSets and supportsReadOnlyObjects work on any VM. =============== Diff against System-eem.1207 =============== Item was changed: ----- Method: SmalltalkImage>>isRunningCog (in category 'system attributes') ----- isRunningCog "Answers if we're running on a Cog VM (JIT or StackInterpreter)" + ^(self vmParameterAt: 42 default: nil) - ^(self vmParameterAt: 42) ifNil: [false] ifNotNil: [:numStackPages| numStackPages > 0]! Item was changed: ----- Method: SmalltalkImage>>isRunningCogit (in category 'system attributes') ----- isRunningCogit "Answers if we're running on the Cog JIT" + ^(self vmParameterAt: 46 default: nil) - ^(self vmParameterAt: 46) ifNil: [false] ifNotNil: [:machineCodeZoneSize| machineCodeZoneSize > 0]! Item was changed: ----- Method: SmalltalkImage>>lowSpaceThreshold (in category 'memory space') ----- lowSpaceThreshold "Answer the low space threshold. When the amount of free memory (after garbage collection) falls below this limit, the system is in serious danger of completely exhausting memory and crashing. This limit should be made high enough to allow the user open a debugger to diagnose a problem or to save the image. In a stack-based VM such as Cog contexts for activations in the stack zone will have to be created as the debugger opens, requiring additional headroom." | slotsForDebugger slotsForContextsOnStackPages | slotsForDebugger := 65536. "Arbitrary guess" slotsForContextsOnStackPages := + (self vmParameterAt: 42 default: nil) - (self vmParameterAt: 42) ifNil: [0] ifNotNil: [:numStackPages| | headerSize numActivationsPerPage maxContextSize | numActivationsPerPage := 40. "Design goal of the Cog & Stack VMs" headerSize := 8 / self wordSize. "64-bits for Spur" maxContextSize := thisContext class instSize + CompiledMethod fullFrameSize + headerSize. numStackPages * numActivationsPerPage * maxContextSize]. ^slotsForDebugger + slotsForContextsOnStackPages * self wordSize! Item was changed: ----- Method: SmalltalkImage>>maxExternalSemaphores (in category 'vm parameters') ----- maxExternalSemaphores + "The size of table where external semaphores are registered. Only in Cog, + other VMs are expected to answer nil if present in the parameters array." + ^self vmParameterAt: 49 default: nil! - "The size of table where external semaphores are registered. Only in Cog" - self isRunningCog ifFalse: [^nil]. - ^self vmParameterAt: 49! Item was changed: ----- Method: SmalltalkImage>>maxExternalSemaphores: (in category 'vm parameters') ----- maxExternalSemaphores: aSize "Changes the size of table where external semaphores are registered. The size can only grow, and will always be the next power of two larger than the parameter. Setting this at any time other than start-up can potentially lose requests. i.e. during the realloc new storage is allocated, the old contents are copied and then pointers are switched. Requests occurring during copying won't be seen if they occur to indices already copied. The intended use is to set the table to some adequate maximum at start-up" - self isRunningCog ifFalse: [^0]. "The vm-header field is a short, maximum 64k entries. Well, on most platforms anyways " (aSize < 0 or: [aSize > 16rFFFF]) ifTrue: [^self error: 'maxExternalSemaphores: is limited to 16rFFFF']. + ^[self vmParameterAt: 49 put: aSize] on: Error do: [0].! - ^self vmParameterAt: 49 put: aSize! Item was changed: ----- Method: SmalltalkImage>>processPreemptionYields (in category 'system attributes') ----- processPreemptionYields "Answer whether the VM causes a process to yield on process preemption, i.e. to put a preempted process at the back of its run queue. If the parameter is unavailable (non-Cog VMs) or bit 2 (4) is 0 then preemption yields." + ^((self vmParameterAt: 48 default: [^true]) allMask: 4) not + ! - ^(([self vmParameterAt: 48] - on: Error - do: [:ex| ^true]) allMask: 4) not! Item was changed: ----- Method: SmalltalkImage>>sendMouseWheelEvents (in category 'system attributes') ----- sendMouseWheelEvents "The Cog VM can be instructed to deliver mouse wheel events as mouse wheel events. By default mouse wheel events are mapped to arrow events. This flag persists across snapshots, stored in the image header." + ^(self vmParameterAt: 48 default: 0) anyMask: 32! - ^(self vmParameterAt: 48) anyMask: 32! Item was changed: ----- Method: SmalltalkImage>>supportsMultipleBytecodeSets (in category 'system attributes') ----- supportsMultipleBytecodeSets "Answer whether the VM supports multiple bytecodeSets." "SmalltalkImage current supportsMultipleBytecodeSets" + ^(self vmParameterAt: 65 default: nil) - ^(self vmParameterAt: 65) ifNil: [false] ifNotNil: [:param| "In older VMs this is a boolean answering the vm-internal MULTIPLE_BYTECODE_SETS define" param isInteger "In newer VMs it is a set of integer flags, bit 0 of which is the vm-internal MULTIPLE_BYTECODE_SETS define" ifTrue: [param anyMask: 1] ifFalse: [param]]! Item was changed: ----- Method: SmalltalkImage>>supportsQueueingFinalization (in category 'system attributes') ----- supportsQueueingFinalization "Answer whether the VM queues individual weak arrays for finalization, instead of signalling the finalization semaphore once for all arrays and having the WeakRegistry mechanism finalize all weak arrays, whether they need to or not." "SmalltalkImage current supportsQueueingFinalization" + ^(self vmParameterAt: 48 default: 0) anyMask: 16! - ^(self vmParameterAt: 48) anyMask: 16! Item was changed: ----- Method: SmalltalkImage>>supportsReadOnlyObjects (in category 'system attributes') ----- supportsReadOnlyObjects "Answer whether the VM observes the per-object read-only flag and consequently aborts writes to inst vars of, and fails primitives that attempt to modify, read-only objects." "SmalltalkImage current supportsReadOnlyObjects" + ^(self vmParameterAt: 65 default: nil) - ^(self vmParameterAt: 65) ifNil: [false] ifNotNil: [:param| "In older VMs this is a boolean answering the vm-internal MULTIPLE_BYTECODE_SETS define" param isInteger "In newer VMs it is a set of integer flags, bit 1 of which is the vm-internal IMMUTABILITY define" ifTrue: [param anyMask: 2] ifFalse: [false]]! Item was added: + ----- Method: SmalltalkImage>>vmParameterAt:default: (in category 'vm parameters') ----- + vmParameterAt: parameterIndex default: defaultValueOrBlock + "Answer a VM parameter or defaultValueOrBlock value if out of range." + <primitive: 254> + ^defaultValueOrBlock value! Item was changed: ----- Method: SmalltalkImage>>wordSize (in category 'image') ----- wordSize "Answer the size in bytes of an object pointer or word in the object memory. The value does not change for a given image, but may be modified by a SystemTracer when converting the image to another format. The value is cached in WordSize to avoid the performance overhead of repeatedly consulting the VM." "Smalltalk wordSize" + ^ WordSize ifNil: [WordSize := self vmParameterAt: 40 default: 4]! - ^ WordSize ifNil: [WordSize := [self vmParameterAt: 40] on: Error do: [4]]!

5 5

The Trunk: System-codefrau.1205.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

Vanessa Freudenberg uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-codefrau.1205.mcz ==================== Summary ==================== Name: System-codefrau.1205 Author: codefrau Time: 20 December 2020, 10:23:10.790782 pm UUID: f94486f3-3743-4300-a495-c2a89089e122 Ancestors: System-dtl.1204 Update platformName for SqueakJS 1.0 =============== Diff against System-dtl.1204 =============== Item was changed: ----- Method: SmalltalkImage>>isLowerPerformance (in category 'system attributes') ----- isLowerPerformance "Some operations - TestCases for example - need an idea of the typical performance of the system on which they are being performed. For now we will simply assert that running on an ARM cpu or as a SqueakJS instance is enough of a discriminator. Options for the future might also involve whether the vm is a full Cog or Sisata system, even actually measuring the performance at some point to be sure" ^ (self platformSubtype beginsWith: 'arm') "Raspberry PI for example" + or: [self platformName = 'JS'] "SqueakJS"! - or: [self platformName = 'Web'] "SqueakJS"!

8 24

cannot browse Monticello change from <working copy> to any of its ancestors
by Nicolas Cellier 05 Jan '21

05 Jan '21

Hi MC experts, when spawning history of a dirty package, then selecting the <working copy>, then trying to view changes from one of the ancestors via pop up menu, the operation ends up with a 'MessageNotUnderstood: UndefinedObject>>snapshot'. The problem is that: MCWorkingHistoryBrowser>>selectedSnapshot ^ self snapshotForInfo: self selectedInfo will use a MCWorkingCopyAncestry as the selectedInfo... But a MCWorkingCopyAncestry lacks essential messages of a regular MCVersionInfo, like versionName etc... This will cause an Error, caught at upper level, and result in nil (no repository holds the 'working copy', there is no point in searching...). I have no idea how to fix it, presumably we should catch early that we're dealing with 'working copy' and use appropriate snapshot for it... I do not know if it was broken recently or if it never worked, but this is a useful feature when there are several ancestors, so help would be appreciated.

2 1

The Inbox: Monticello-nice.734.mcz
by commits＠source.squeak.org 05 Jan '21

05 Jan '21

A new version of Monticello was added to project The Inbox: http://source.squeak.org/inbox/Monticello-nice.734.mcz ==================== Summary ==================== Name: Monticello-nice.734 Author: nice Time: 30 December 2020, 3:57:21.60758 pm UUID: 863f642a-7795-4eb6-aa6b-76a5af3a8504 Ancestors: Monticello-mt.733 Workaround version history browser bug when 'working copy' is selected. The snapshot is searched in repositoryGroup, and logically, none is found. Note that the self selectedInfo isKindOf: MCWorkingCopyAncestry, which does not behave as a regular MCVersionInfo, it does not even answer to versionName... This somehow accelerate the failure thru an ifError: [] handling, but at the end, the selectedSnapshot is still nil which makes the 'view changes from...' menu fail. The workaround is not very nice, it use implicit knowledge that 'working copy' will be at top of list (index = 1). If you can think of nicer fix, please raise voice. =============== Diff against Monticello-mt.733 =============== Item was changed: ----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') ----- selectedSnapshot + index = 1 ifTrue: [^package snapshot]. ^ self snapshotForInfo: self selectedInfo!

5 4

Sound mixing makes nasty noises
by tim Rowledge 04 Jan '21

04 Jan '21

I've discovered that playing two or more sounds simultaneously can make truly appalling noises. I'm hoping somebody has a good solution. The problem started with playing a sound and using the pianokeyboardmorph at the same time. Ouch! Also, swizzling the mouse across the keyboard causes occasional quite audible 'scratchy-clicks' somehow. There can also be a quite noticeable sound between notes, not easily describable but sort of a 'dull thump'. I thought it was some issue with how the sound was played, maybe the note-end process as each piano key was released and the next pressed, timing issues.. but none of that had very much effect. The AbstractSound>>#stopGracefully method does seem to have a small bug, in that the decayInMs value surely ought not be the sum of the attack & decay times from the envelope? But carefully fudging the note shutdown to be faster didn't help a lot. After too much messing around I discovered that at least some of the problem is the mixing of sounds. Now, I know we did a small change to MixedSound>>#add:pan:volume: since 5.3, and that we made a small change to the SampledSound>>#mixSampleCount:into:startingAt:leftVol:rightVol: primitive. However, I'm running on a VM that has the prim change, and I've ported across the add:pan... change, with no real difference. This is, of course, on a Pi, but the same issue is audible on my iMac as well. Eventually I cottoned on to the fact that I was mixing two sounds with volumes set to 100%. Changing to 50% for both actually results in a perfectly fine end result - Yay! This doesn't seem like a robust solution though. What if I have four sounds playing each set to 40%? Why does it seem to work perfectly well for AbstractSound>>#stereoBachFugue play, which uses four? To make life even more fun, it doesn't seem like there is any volume control once a sound is playing. The AbstractSound>>#adjustVolumeTo:overMSecs: method appears to be the one to use but it has no audible effect. There is also #loudness: which does work, but produces pretty much exactly the glitch I hear from glissandoing(?) the keyboard. So - some workspace code to illustrate "awful noise when mixing" |snd| snd := FMSound organ1. snd setPitch: 440 dur: 10 loudness: 0.9; play. 1 second wait. FMSound brass1 setPitch: 470 dur:2 loudness: 0.9; play. 1 second wait. snd stopGracefully "OK, because both sound defualt to quieter" |snd | snd := FMSound organ1. snd duration: 5; play. 1 second wait. FMSound brass1 play. 1 second wait. snd stopGracefully. "nasty glitch using #loudness: plus mixing graunch" |snd | snd := FMSound organ1. snd duration: 5; play. 1 second wait. snd loudness: 1.0 . 1 second wait. FMSound brass1 play. 1 second wait. snd stopGracefully. "no effect from adjustVol..." |snd | snd := FMSound organ1. snd duration: 5; play. 1 second wait. snd adjustVolumeTo: 1.0 overMSecs: 500. 1 second wait. FMSound brass1 play. 1 second wait. snd stopGracefully. Aargh! tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim A computer program does what you tell it to do, not what you want it to do.

8 57

FullBlockClosures and ignoreOuterContext?
by Fabio Niephaus 02 Jan '21

02 Jan '21

Hi all, While digging through the implementation of FullBlockClosure with Hernan, we were wondering about full closures that ignore their outerContext. We noticed that the following method has two senders: EncoderForSistaV1>>#genPushFullClosure:numCopied:receiverOnStack:ignoreOuterContext: One of them seems to be the only one in use, and it's passing in false as defaults for both receiverOnstack and ignoreOuterContext. The other sender (BytecodeEncoder>>#sizePushFullClosure:numCopied:receiverOnStack:ignoreOuterContext:), in turn, doesn't seem to have any further senders. Unless we missed something, it looks like the outerContext will never be ignored at the moment. Similarly, the receiver is never on the stack. Is this something only Scorch can do or is this just "not yet implemented"? When can the outerContext be ignored? When does it make sense to pop the receiver from the stack? And where can we find the latest version of Scorch. Is it still the one at [1]? Cheers, Fabio [1] https://github.com/clementbera/Scorch

3 5

Problem debugging a test with #should:raise:
by Hernan Wilkinson 30 Dec '20

30 Dec '20

Hi all, I'm sending this mail to the three lists because it is an error I found in the three Smalltalks (Squeak, Pharo and Cuis) and maybe we could share the effort to solve it and the solution. The problem can be reproduce with this test: test1 self should: [ self error: 'something' ] raise: Error withExceptionDo: [ :anError | self assert: 'something different' equals: anError messageText ] If you run that test, it will fail of course. So if you go with the debugger to the context that signals de error (self error: 'something') and press restart and then over you will find the error. In the case of Squeak and Cuis, a new debugger is opened and you can not do anything with the original one. In the case of Pharo, the debugger stops working (in another try it opened a new debugger also but I could not reproduce it). I think the problem is related to the execution simulation but it is not a simple problem... Any idea what it could be? Cheers! Hernan. -- *Hernán WilkinsonAgile Software Development, Teaching & Coaching* *Phone: +54-011*-4893-2057 *Twitter: @HernanWilkinson* *site: http://www.10Pines.com <http://www.10pines.com/>* Address: Alem 896, Floor 6, Buenos Aires, Argentina

2 1

The Trunk: Collections-nice.921.mcz
by commits＠source.squeak.org 30 Dec '20

30 Dec '20

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.921.mcz ==================== Summary ==================== Name: Collections-nice.921 Author: nice Time: 30 December 2020, 12:46:21.328377 am UUID: f66c5960-3b41-4815-ab2c-ce42061fb43e Ancestors: Collections-eem.920 Fix buggish float array 32<->64 conversions... Hell, how could I publish that? Il ne faut pas confondre vitesse et précipitation... =============== Diff against Collections-eem.920 =============== Item was changed: ----- Method: Float32Array class>>fromFloat64Array: (in category 'instance creation') ----- fromFloat64Array: aFloat64Array + ^(self new: aFloat64Array size) copyFromFloat64Array: aFloat64Array! - ^(self new: aFloat64Array) copyFromFloat64Array: aFloat64Array! Item was changed: ----- Method: Float32Array>>copyFromFloat64Array: (in category 'initialize-release') ----- copyFromFloat64Array: aFloat64Array "Destructively replace the elements of self with those of aFloat64Array" + <primitive: 'primitiveFromFloat64Array' module: 'FloatArrayPlugin'> - <primitive: 'primitiveFromFloat64Array' module: 'Float64ArrayPlugin'> self isOfSameSizeCheck: aFloat64Array. 1 to: self size do:[:i| self at: i put: (aFloat64Array at: i)].! Item was changed: ----- Method: Float64Array class>>fromFloatArray: (in category 'instance creation') ----- fromFloatArray: aFloatArray + ^(self new: aFloatArray size) copyFromFloatArray: aFloatArray! - ^(self new: aFloatArray) copyFromFloatArray: aFloatArray!

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
18
Older →

Jump to page: