Squeak-dev October 2020

squeak-dev@lists.squeakfoundation.org

51 participants
394 discussions

The Inbox: WebClient-Core-ct.127.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Christoph Thiede uploaded a new version of WebClient-Core to project The Inbox: http://source.squeak.org/inbox/WebClient-Core-ct.127.mcz ==================== Summary ==================== Name: WebClient-Core-ct.127 Author: ct Time: 2 October 2020, 5:32:32.7446 pm UUID: f078e024-2f40-5c4b-b608-e21114236743 Ancestors: WebClient-Core-mt.126 Moves WebClient utility methods to instance side (and forwards them on class-side). This allows to reuse them even when it is necessary to use #httpDo: for passing additional configuration to the WebClient instance, e.g. #timeout:. Also includes minor refactoring of #htmlSubmit:fields:method:encoding:. If the POST encoding is unknown, raise an error instead silently doing nothing. =============== Diff against WebClient-Core-mt.126 =============== Item was changed: ----- Method: WebClient class>>htmlSubmit:fields: (in category 'utilities') ----- htmlSubmit: urlString fields: fieldMap + "A utility method for html submit operations." - "A utility method for html submit operations. The fieldMap can be EITHER - an array of associations OR a Dictionary of key value pairs (the former is - useful for providing multiple fields and/or specifying the order of fields). + ^ self httpDo: [:client | + client htmlSubmit: urlString fields: fieldMap] - WebClient - htmlSubmit: 'http://www.google.com/search' - fields: { - 'hl' -> 'en'. - 'q' -> 'Squeak' - } - " - ^self htmlSubmit: urlString - fields: fieldMap - method: 'GET' ! Item was changed: ----- Method: WebClient class>>htmlSubmit:fields:method: (in category 'utilities') ----- htmlSubmit: urlString fields: fieldMap method: method + "A utility method for html submit operations." - "A utility method for html submit operations. The fieldMap can be EITHER - an array of associations OR a Dictionary of key value pairs (the former is - useful for providing multiple fields and/or specifying the order of fields). + ^ self httpDo: [:client | + client htmlSubmit: urlString fields: fieldMap method: method]! - WebClient - htmlSubmit: 'http://www.google.com/search' - fields: { - 'hl' -> 'en'. - 'q' -> 'Squeak' - } method: 'GET' - " - ^self htmlSubmit: urlString - fields: fieldMap - method: method - encoding: 'application/x-www-form-urlencoded' - ! Item was changed: ----- Method: WebClient class>>htmlSubmit:fields:method:encoding: (in category 'utilities') ----- htmlSubmit: urlString fields: fields method: method encoding: encoding + "A utility method for html submit operations." - "A utility method for html submit operations. The fieldMap can be EITHER - an array of associations OR a Dictionary of key value pairs (the former is - useful for providing multiple fields and/or specifying the order of fields). + ^ self httpDo: [:client | + client htmlSubmit: urlString fields: fields method: method encoding: encoding]! - WebClient - htmlSubmit: 'http://www.google.com/search' - fields: { - 'hl' -> 'en'. - 'q' -> 'Squeak' - } method: 'GET' - encoding: 'application/x-www-form-urlencoded' - " - - method = 'GET' ifTrue:[ - "GET only supports url encoded requests" - encoding = 'application/x-www-form-urlencoded' - ifFalse:[^self error: 'Unsupported encoding: ', encoding]. - ^self httpGet: urlString, '?', (WebUtils encodeUrlEncodedForm: fields). - ]. - - method = 'POST' ifTrue:[ - "Dispatch on encoding type" - encoding caseOf: { - [ 'application/x-www-form-urlencoded'] -> [ - ^self httpPost: urlString - content: (WebUtils encodeUrlEncodedForm: fields) - type: encoding. - ]. - ['multipart/form-data'] -> [ - ^self httpPost: urlString multipartFields: fields - ]. - } otherwise:[] - ]. - - self error: 'Unsupported method: ', method. - ! Item was changed: ----- Method: WebClient class>>httpPost:multipartFields: (in category 'utilities') ----- httpPost: url multipartFields: fieldMap + "Make a form submission using multipart/form-data POST. See comment on instance-side implementation." - "Make a form submission using multipart/form-data POST. + ^ self httpDo: [:client | + client httpPost: url multipartFields: fieldMap]! - The fieldMap may contain MIMEDocument instances to indicate the presence - of a file to upload to the server. If the MIMEDocument is present, its - content type and file name will be used for the upload. - - The fieldMap can be EITHER an array of associations OR a Dictionary of - key value pairs (the former is useful for providing multiple fields and/or - specifying the order of fields)." - - | boundary | - boundary := WebUtils multipartBoundary. - - ^self httpPost: url - content: (WebUtils encodeMultipartForm: fieldMap boundary: boundary) - type: 'multipart/form-data; boundary=', boundary! Item was added: + ----- Method: WebClient>>htmlSubmit:fields: (in category 'utilities') ----- + htmlSubmit: urlString fields: fieldMap + + ^ self + htmlSubmit: urlString + fields: fieldMap + method: 'GET'! Item was added: + ----- Method: WebClient>>htmlSubmit:fields:method: (in category 'utilities') ----- + htmlSubmit: urlString fields: fieldMap method: method + + ^ self + htmlSubmit: urlString + fields: fieldMap + method: method + encoding: 'application/x-www-form-urlencoded'! Item was added: + ----- Method: WebClient>>htmlSubmit:fields:method:encoding: (in category 'utilities') ----- + htmlSubmit: urlString fields: fields method: method encoding: encoding + "A utility method for html submit operations. The fieldMap can be EITHER an array of associations OR a Dictionary of key value pairs (the former is useful for providing multiple fields and/or specifying the order of fields). + + Usage: + WebClient + htmlSubmit: 'http://www.google.com/search' + fields: {'hl' -> 'en'. 'q' -> 'Squeak'} + method: 'GET' + encoding: 'application/x-www-form-urlencoded' + " + + ^ method + caseOf: { + ['GET'] -> [ + "GET only supports url encoded requests" + encoding = 'application/x-www-form-urlencoded' + ifFalse: [^self error: 'Unsupported encoding: ', encoding]. + self httpGet: urlString, '?', (WebUtils encodeUrlEncodedForm: fields)]. + ['POST'] -> [ + encoding caseOf: { + ['application/x-www-form-urlencoded'] -> [ + self + httpPost: urlString + content: (WebUtils encodeUrlEncodedForm: fields) + type: encoding]. + ['multipart/form-data'] -> [ + self httpPost: urlString multipartFields: fields] }] } + otherwise: [self error: 'Unsupported method: ', method]! Item was added: + ----- Method: WebClient>>httpPost:multipartFields: (in category 'utilities') ----- + httpPost: url multipartFields: fieldMap + "Make a form submission using multipart/form-data POST. + + The fieldMap may contain MIMEDocument instances to indicate the presence of a file to upload to the server. If the MIMEDocument is present, its content type and file name will be used for the upload. + + The fieldMap can be EITHER an array of associations OR a Dictionary of key value pairs (the former is useful for providing multiple fields and/or specifying the order of fields)." + + | boundary | + boundary := WebUtils multipartBoundary. + ^ self + httpPost: url + content: (WebUtils encodeMultipartForm: fieldMap boundary: boundary) + type: 'multipart/form-data; boundary=', boundary!

1 0

[CRON] Passed: squeak-smalltalk/squeak-app#1846 (squeak-trunk - 25ebaf1)
by Travis CI 02 Oct '20

02 Oct '20

Build Update for squeak-smalltalk/squeak-app ------------------------------------- Build: #1846 Status: Passed Duration: 18 mins and 55 secs Commit: 25ebaf1 (squeak-trunk) Author: Marcel Taeumel Message: Hi all! The project "squeak-app" is part of the continuous build infrastructure (short: CI) for Squeak's bundles, which you can download at https://files.squeak.org/, followed by the version tag you are looking for. All bundles are updated on a regular basis, which is daily for Trunk (i.e. the current alpha version) and monthly for release versions. Note that there won't be new bundles if Squeak's build number, which reflects in-image code updates, did not change between CI jobs. -- The Squeak Oversight Board [ci skip] View the changeset: https://github.com/squeak-smalltalk/squeak-app/compare/fb55517f583fe544f922… View the full build log and details: https://travis-ci.org/github/squeak-smalltalk/squeak-app/builds/732280827?u… -- You can unsubscribe from build emails from the squeak-smalltalk/squeak-app repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8901856&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

The Inbox: Tools-ct.991.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.991.mcz ==================== Summary ==================== Name: Tools-ct.991 Author: ct Time: 30 September 2020, 7:46:39.949807 pm UUID: 4d2f75ef-336d-cc4c-aa0d-dd4f7ff99fc7 Ancestors: Tools-mt.990 Fixes a bug in DebuggerMethodMap's rangeForPC lookup Steps to reproduce: c := Object newSubclass. c compile: 'foo: foo foo = #foo ifTrue: [^ true]. ^ (foo ifNil: [^ false]) = #bar'. c new foo: #bar. "Debug it. Step into #foo:, step over #=. Before this commit, the selection was '^ true'" The error was that #findNearbyBinaryIndex: uses to return the lower possible index if there is no exact match. For debugging, we cannot need this behavior, because we want to select the next operation to be executed. Furthermore, this commit refactors some duplication with DebuggerMethodMapForFullBlockCompiledMethod. Please review! Uploaded again due to totally broken ancestry. Replaces Tools-ct.956, which can be moved into the treated inbox. =============== Diff against Tools-mt.990 =============== Item was changed: ----- Method: DebuggerMethodMap>>rangeForPC:in:contextIsActiveContext: (in category 'source mapping') ----- rangeForPC: contextsConcretePC in: method contextIsActiveContext: contextIsActiveContext + "Answer the indices in the source code for the supplied pc. If the context is the active context (is at the hot end of the stack) then its pc is the current pc. But if the context isn't, because it is suspended sending a message, then its current pc is the previous pc." - "Answer the indices in the source code for the supplied pc. - If the context is the actve context (is at the hot end of the stack) - then its pc is the current pc. But if the context isn't, because it is - suspended sending a message, then its current pc is the previous pc." + | pc i end sortedMap | - | pc i end | pc := method abstractPCForConcretePC: (contextIsActiveContext + ifTrue: [contextsConcretePC] + ifFalse: [(method pcPreviousTo: contextsConcretePC) + ifNil: [contextsConcretePC]]). + (self abstractSourceMapForMethod: method) + at: pc + ifPresent: [:range | ^ range]. + sortedMap := self sortedSourceMapForMethod: method. + sortedMap ifEmpty: [^ 1 to: 0]. + i := sortedMap + findBinaryIndex: [:assoc | pc - assoc key] + ifNone: [:lower :upper | upper]. + i < 1 ifTrue: [^ 1 to: 0]. + i > sortedMap size ifTrue: [ + end := sortedMap inject: 0 into: [:prev :this | + prev max: this value last]. + ^ end + 1 to: end]. + ^ (sortedMap at: i) value! - ifTrue: [contextsConcretePC] - ifFalse: [(method pcPreviousTo: contextsConcretePC) - ifNotNil: [:prevpc| prevpc] - ifNil: [contextsConcretePC]]). - (self abstractSourceMap includesKey: pc) ifTrue: - [^self abstractSourceMap at: pc]. - sortedSourceMap ifNil: - [sortedSourceMap := self abstractSourceMap associations - replace: [ :each | each copy ]; - sort]. - sortedSourceMap isEmpty ifTrue: [^1 to: 0]. - i := sortedSourceMap findNearbyBinaryIndex: [:assoc| pc - assoc key]. - i < 1 ifTrue: [^1 to: 0]. - i > sortedSourceMap size ifTrue: - [end := sortedSourceMap inject: 0 into: - [:prev :this | prev max: this value last]. - ^end+1 to: end]. - ^(sortedSourceMap at: i) value - - "| method source scanner map | - method := DebuggerMethodMap compiledMethodAt: #rangeForPC:in:contextIsActiveContext:. - source := method getSourceFromFile asString. - scanner := InstructionStream on: method. - map := method debuggerMap. - Array streamContents: - [:ranges| - [scanner atEnd] whileFalse: - [| range | - range := map rangeForPC: scanner pc in: method contextIsActiveContext: true. - ((map abstractSourceMap includesKey: scanner abstractPC) - and: [range first ~= 0]) ifTrue: - [ranges nextPut: (source copyFrom: range first to: range last)]. - scanner interpretNextInstructionFor: InstructionClient new]]"! Item was added: + ----- Method: DebuggerMethodMap>>sortedSourceMap (in category 'private') ----- + sortedSourceMap + + ^ sortedSourceMap ifNil: [ + sortedSourceMap := self abstractSourceMap associations + replace: [:each | each copy]; + sort]! Item was added: + ----- Method: DebuggerMethodMap>>sortedSourceMapForMethod: (in category 'source mapping') ----- + sortedSourceMapForMethod: aCompiledMethod + + ^ self sortedSourceMap! Item was changed: ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>abstractSourceMap (in category 'source mapping') ----- abstractSourceMap + + ^ self shouldNotImplement! - self shouldNotImplement! Item was removed: - ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>rangeForPC:in:contextIsActiveContext: (in category 'source mapping') ----- - rangeForPC: contextsConcretePC in: method contextIsActiveContext: contextIsActiveContext - "Answer the indices in the source code for the supplied pc. - If the context is the actve context (is at the hot end of the stack) - then its pc is the current pc. But if the context isn't, because it is - suspended sending a message, then its current pc is the previous pc." - - | pc i end mapForMethod sortedMap | - pc := method abstractPCForConcretePC: (contextIsActiveContext - ifTrue: [contextsConcretePC] - ifFalse: [(method pcPreviousTo: contextsConcretePC) - ifNotNil: [:prevpc| prevpc] - ifNil: [contextsConcretePC]]). - ((mapForMethod := self abstractSourceMapForMethod: method) includesKey: pc) ifTrue: - [^mapForMethod at: pc]. - sortedSourceMap ifNil: - [sortedSourceMap := IdentityDictionary new]. - sortedMap := sortedSourceMap - at: method - ifAbsentPut: [mapForMethod associations - replace: [ :each | each copy ]; - sort]. - sortedMap isEmpty ifTrue: [^1 to: 0]. - i := sortedMap findNearbyBinaryIndex: [:assoc| pc - assoc key]. - i < 1 ifTrue: [^1 to: 0]. - i > sortedMap size ifTrue: - [end := sortedMap inject: 0 into: - [:prev :this | prev max: this value last]. - ^end+1 to: end]. - ^(sortedMap at: i) value - - "| method source scanner map | - method := DebuggerMethodMapForFullBlockCompiledMethods compiledMethodAt: #rangeForPC:in:contextIsActiveContext:. - source := method getSourceFromFile asString. - scanner := InstructionStream on: method. - map := method debuggerMap. - Array streamContents: - [:ranges| - [scanner atEnd] whileFalse: - [| range | - range := map rangeForPC: scanner pc in: method contextIsActiveContext: true. - ((map abstractSourceMap includesKey: scanner abstractPC) - and: [range first ~= 0]) ifTrue: - [ranges nextPut: (source copyFrom: range first to: range last)]. - scanner interpretNextInstructionFor: InstructionClient new]]"! Item was added: + ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>sortedSourceMap (in category 'source mapping') ----- + sortedSourceMap + + ^ self shouldNotImplement! Item was added: + ----- Method: DebuggerMethodMapForFullBlockCompiledMethods>>sortedSourceMapForMethod: (in category 'source mapping') ----- + sortedSourceMapForMethod: method + + sortedSourceMap ifNil: [ + sortedSourceMap := IdentityDictionary new]. + ^ sortedSourceMap + at: method + ifAbsentPut: [(self abstractSourceMapForMethod: method) associations + replace: [ :each | each copy ]; + sort]!

4 6

The Trunk: ToolBuilder-Morphic-ct.252.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.252.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.252 Author: ct Time: 20 January 2020, 8:57:46.404972 pm UUID: 2b311bcc-31ca-dc4d-8ebf-7a1cad07624e Ancestors: ToolBuilder-Morphic-mt.251 Implement "browse/debug button action" properly on PluggabeButtonMorphPlus =============== Diff against ToolBuilder-Morphic-mt.251 =============== Item was added: + ----- Method: PluggableButtonMorphPlus>>browseImplementationOfActionSelector (in category 'debug menu') ----- + browseImplementationOfActionSelector + + action ifNotNil: [ + ^ action outerContext method browse]. + ^ super browseImplementationOfActionSelector! Item was added: + ----- Method: PluggableButtonMorphPlus>>debugAction (in category 'debug menu') ----- + debugAction + + action ifNil: [^ super debugAction]. + (Process + forBlock: [self performAction] + runUntil: [:context | context closure = action]) + debugWithTitle: ('Debug button action "{1}" in model "{2}"' format: {self label. self target printString}).!

3 2

The Trunk: Tools-eem.991.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.991.mcz ==================== Summary ==================== Name: Tools-eem.991 Author: eem Time: 1 October 2020, 7:29:41.598058 pm UUID: 23455dc2-125f-4fab-8e33-75f63177cb63 Ancestors: Tools-mt.990 Simplify the horribly complex DebuggerMethodMap by removing DebuggerMethodMapForBlueBookMethods and moving opublic protocol up to DebuggerMethodMap from DebuggerMethodMapForClosureCompiledMethods =============== Diff against Tools-mt.990 =============== Item was changed: Object subclass: #DebuggerMethodMap instanceVariableNames: 'timestamp methodReference methodNode abstractSourceRanges sortedSourceMap' classVariableNames: 'AccessLock MapCache MapCacheEntries' poolDictionaries: '' category: 'Tools-Debugger'! + !DebuggerMethodMap commentStamp: 'eem 10/1/2020 19:08' prior: 0! + I am a place-holder for information needed by the Debugger to inspect method activations. I insulate the debugger from details of code generation such as exact bytecode offsets and temporary variable locations. I have two concrete subclasses, one for methods where block bytecodes are embedded in the home method and one for methods where blocks are separate objects (CompiledBlock). These classes deal with temporary variable access. My function is to abstract the source map away from actual bytecode pcs to abstract bytecode pcs. I used to have a subclass for "BlueBook" compiled methods, with non-closure blocks, but this was removed in October 2020 for simplicity's sake. - !DebuggerMethodMap commentStamp: '<historical>' prior: 0! - I am a place-holder for information needed by the Debugger to inspect method activations. I insulate the debugger from details of code generation such as exact bytecode offsets and temporary variable locations. I have two concreate subclasses, one for methods compiled using BlueBook blocks and one for methods compiled using Closures. These classes deal with temporary variable access. My function is to abstract the source map away from actual bytecode pcs to abstract bytecode pcs. To reduce compilation time I try and defer as much computation to access time as possible as instances of me will be created after each compilation. I maintain a WeakIdentityDictionary of method to DebuggerMethodMap to cache maps. I refer to my method through a WeakArray to keep the map cache functional. If the reference from a DebuggerMethodMap to its method were strong then the method would never be dropped from the cache because the reference from its map would keep it alive.! Item was changed: ----- Method: DebuggerMethodMap class>>forMethod:methodNode: (in category 'instance creation') ----- forMethod: aMethod "<CompiledCode>" methodNode: methodNode "<MethodNode>" "Uncached instance creation method for private use or for tests. Please consider using forMethod: instead." + ^(aMethod encoderClass supportsFullBlocks + ifTrue: [DebuggerMethodMapForFullBlockCompiledMethods] + ifFalse: [DebuggerMethodMapForClosureCompiledMethods]) new - ^(aMethod isBlueBookCompiled - ifTrue: [DebuggerMethodMapForBlueBookMethods] - ifFalse: - [aMethod encoderClass supportsFullBlocks - ifTrue: [DebuggerMethodMapForFullBlockCompiledMethods] - ifFalse: [DebuggerMethodMapForClosureCompiledMethods]]) new forMethod: aMethod homeMethod methodNode: methodNode! Item was changed: + ----- Method: DebuggerMethodMap>>markRecentlyUsed (in category 'private') ----- - ----- Method: DebuggerMethodMap>>markRecentlyUsed (in category 'accessing') ----- markRecentlyUsed timestamp := Time totalSeconds! Item was changed: ----- Method: DebuggerMethodMap>>namedTempAt:in: (in category 'accessing') ----- namedTempAt: index in: aContext "Answer the value of the temp at index in aContext where index is relative to the array of temp names answered by tempNamesForContext:" + ^self + privateTempAt: index + in: aContext + startKeysToBlockExtents: aContext method startKeysToBlockExtents! - self subclassResponsibility! Item was changed: ----- Method: DebuggerMethodMap>>namedTempAt:put:in: (in category 'accessing') ----- namedTempAt: index put: aValue in: aContext "Assign the value of the temp at index in aContext where index is relative + to the array of temp names answered by tempNamesForContext:. + If the value is a copied value we also need to set it along the lexical chain." + ^self + privateTempAt: index + in: aContext + put: aValue + startKeysToBlockExtents: aContext method startKeysToBlockExtents! - to the array of temp names answered by tempNamesForContext:" - self subclassResponsibility! Item was changed: ----- Method: DebuggerMethodMap>>tempNamesForContext: (in category 'accessing') ----- tempNamesForContext: aContext "Answer an Array of all the temp names in scope in aContext starting with the home's first local (the first argument or first temporary if no arguments)." + ^(self + privateTempRefsForContext: aContext + startKeysToBlockExtents: aContext method startKeysToBlockExtents) collect: + [:pair| pair first]! - self subclassResponsibility! Item was added: + ----- Method: DebuggerMethodMap>>tempNamesForMethod: (in category 'accessing') ----- + tempNamesForMethod: aMethod + "Answer an Array of all the temp names in scope in aMethod starting with + the home's first local (the first argument or first temporary if no arguments)." + ^(self + privateTempRefsForMethod: aMethod + startKeysToBlockExtents: aMethod startKeysToBlockExtents) collect: + [:pair| pair first]! Item was changed: ----- Method: DebuggerMethodMap>>tempsAndValuesForContext: (in category 'accessing') ----- tempsAndValuesForContext: aContext + "Return a string of the temporary variables and their current values" - "Return a string of the temporary variabls and their current values" | aStream | aStream := WriteStream on: (String new: 100). (self tempNamesForContext: aContext) doWithIndex: [:title :index | aStream nextPutAll: title; nextPut: $:; space; tab. aContext print: (self namedTempAt: index in: aContext) on: aStream. aStream cr]. ^aStream contents! Item was changed: + ----- Method: DebuggerMethodMap>>timestamp (in category 'private') ----- - ----- Method: DebuggerMethodMap>>timestamp (in category 'accessing') ----- timestamp ^timestamp! Item was removed: - DebuggerMethodMap subclass: #DebuggerMethodMapForBlueBookMethods - instanceVariableNames: 'tempNames' - classVariableNames: '' - poolDictionaries: '' - category: 'Tools-Debugger'! - - !DebuggerMethodMapForBlueBookMethods commentStamp: 'eem 1/6/2018 16:57' prior: 0! - I am a place-holder for information needed by the Debugger to inspect method activations. See my superclass's comment. I map methods compiled using BlueBook blocks.! Item was removed: - ----- Method: DebuggerMethodMapForBlueBookMethods>>forMethod:methodNode: (in category 'initialize-release') ----- - forMethod: aMethod "<CompiledMethod>" methodNode: aMethodNode "<MethodNode>" - super forMethod: aMethod methodNode: aMethodNode. - tempNames := methodNode encoder tempNames! Item was removed: - ----- Method: DebuggerMethodMapForBlueBookMethods>>namedTempAt:in: (in category 'accessing') ----- - namedTempAt: index in: aContext - "Answer the value of the temp at index in aContext where index is relative - to the array of temp names answered by tempNamesForContext:" - ^aContext tempAt: index! Item was removed: - ----- Method: DebuggerMethodMapForBlueBookMethods>>namedTempAt:put:in: (in category 'accessing') ----- - namedTempAt: index put: aValue in: aContext - "Assign the value of the temp at index in aContext where index is relative - to the array of temp names answered by tempNamesForContext:" - ^aContext tempAt: index put: aValue! Item was removed: - ----- Method: DebuggerMethodMapForBlueBookMethods>>tempNamesForContext: (in category 'accessing') ----- - tempNamesForContext: aContext - "Answer an Array of all the temp names in scope in aContext starting with - the home's first local (the first argument or first temporary if no arguments)." - ^tempNames! Item was changed: DebuggerMethodMap subclass: #DebuggerMethodMapForClosureCompiledMethods instanceVariableNames: 'blockExtentsToTempRefs startpcsToTempRefs startKeysToTempRefs' classVariableNames: 'FirstTime' poolDictionaries: '' category: 'Tools-Debugger'! + !DebuggerMethodMapForClosureCompiledMethods commentStamp: 'eem 10/1/2020 19:19' prior: 0! + I am a place-holder for information needed by the Debugger to inspect method activations. See my superclass's comment. I map methods compiled using closures whose bytecodes are embedded within the home CompiledMethod, as is the case for the V3PlusClosures bytecode set. - !DebuggerMethodMapForClosureCompiledMethods commentStamp: 'eem 1/8/2018 12:42' prior: 0! - I am a place-holder for information needed by the Debugger to inspect method activations. See my superclass's comment. I map methods compiled using closures. Instance variables blockExtentsToTempsRefs <Dictionary of: Interval -> Array of: (Array with: String with: (Integer | (Array with: Integer with: Integer)))> maps a block extent to an Array of temp references for that block/method. Each reference is a pair of temp name and index, where the index can itself be a pair for a remote temp. startKeysToTempRefs <Dictionary of: Integer startpc -> Array of: (Array with: String with: temp reference)> where temp reference ::= Integer | (Array with: Integer with: Integer) | (Array with: #outer with: temp reference)! Item was removed: - ----- Method: DebuggerMethodMapForClosureCompiledMethods>>namedTempAt:in: (in category 'accessing') ----- - namedTempAt: index in: aContext - "Answer the value of the temp at index in aContext where index is relative - to the array of temp names answered by tempNamesForContext:" - ^self - privateTempAt: index - in: aContext - startKeysToBlockExtents: aContext method startKeysToBlockExtents! Item was removed: - ----- Method: DebuggerMethodMapForClosureCompiledMethods>>namedTempAt:put:in: (in category 'accessing') ----- - namedTempAt: index put: aValue in: aContext - "Assign the value of the temp at index in aContext where index is relative - to the array of temp names answered by tempNamesForContext:. - If the value is a copied value we also need to set it along the lexical chain." - ^self - privateTempAt: index - in: aContext - put: aValue - startKeysToBlockExtents: aContext method startKeysToBlockExtents! Item was removed: - ----- Method: DebuggerMethodMapForClosureCompiledMethods>>tempNamesForContext: (in category 'accessing') ----- - tempNamesForContext: aContext - "Answer an Array of all the temp names in scope in aContext starting with - the home's first local (the first argument or first temporary if no arguments)." - ^(self - privateTempRefsForContext: aContext - startKeysToBlockExtents: aContext method startKeysToBlockExtents) collect: - [:pair| pair first]! Item was removed: - ----- Method: DebuggerMethodMapForClosureCompiledMethods>>tempNamesForMethod: (in category 'accessing') ----- - tempNamesForMethod: aMethod - "Answer an Array of all the temp names in scope in aMethod starting with - the home's first local (the first argument or first temporary if no arguments)." - ^(self - privateTempRefsForMethod: aMethod - startKeysToBlockExtents: aMethod startKeysToBlockExtents) collect: - [:pair| pair first]! Item was changed: DebuggerMethodMapForClosureCompiledMethods subclass: #DebuggerMethodMapForFullBlockCompiledMethods instanceVariableNames: 'sortedSourceMaps' classVariableNames: '' poolDictionaries: '' category: 'Tools-Debugger'! + !DebuggerMethodMapForFullBlockCompiledMethods commentStamp: 'eem 10/1/2020 19:20' prior: 0! + I am a place-holder for information needed by the Debugger to inspect method activations. See DebuggerMethodMap's comment. I map methods compiled using full block closures, where block methods are objects separate from the home mehtod, as is the case with the SistaV1 bytecode set. - !DebuggerMethodMapForFullBlockCompiledMethods commentStamp: 'eem 1/10/2018 16:28' prior: 0! - I am a place-holder for information needed by the Debugger to inspect method activations. See DebuggerMethodMap's comment. I map methods compiled using full block closures. Instance variables (inherited) abstractSourceRanges <Dictionary of: CompiledCode -> (Dictionary of: Integer-> Interval) startKeysToTempRefs <Dictionary of: CompiledCode -> Array of: (Array with: String with: temp reference)> where temp reference ::= Integer | (Array with: Integer with: Integer) | (Array with: #outer with: temp reference) (locally defined) sortedSourceMaps <Dictionary of: CompiledCode -> (Dictionary of: Integer-> Interval)!

1 0

The Trunk: Kernel-eem.1342.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1342.mcz ==================== Summary ==================== Name: Kernel-eem.1342 Author: eem Time: 1 October 2020, 4:23:04.242629 pm UUID: 3f8b16e1-4140-4127-8885-b8b3f8644411 Ancestors: Kernel-eem.1341 Oops! Forgot to commit isLinkedNamedPrimitive used by soundPluginActive. Have Class>>binding use a ClassBinding for metaclass mclass associations too. =============== Diff against Kernel-eem.1341 =============== Item was changed: ----- Method: Class>>binding (in category 'compiling') ----- binding "Answer a binding for the receiver, sharing if possible" + (self environment bindingOf: name ifAbsent: nil) ifNotNil: + [:bindingOrNil| + bindingOrNil value == self ifTrue: + [^bindingOrNil]]. + ^ClassBinding key: nil value: self! - | binding | - binding := self environment associationAt: name ifAbsent: [nil -> self]. - ^binding value == self ifTrue:[binding] ifFalse:[nil -> self].! Item was changed: ----- Method: CompiledMethod>>isLinkedNamedPrimitive (in category 'testing') ----- isLinkedNamedPrimitive "Answer if the receiver invokes a named primitive, and the method is linked to an actual primitive. + For example if the method hasn't yet been used in the current session, it won't be linked" - For example if the method hasn;t yet been used in the current session, it won't be linked" ^self isNamedPrimitive and: [(self literalAt: 1) fourth ~= 0] "self systemNavigation browseAllSelect: [:m| m isLinkedNamedPrimitive]"!

1 0

The Trunk: Collections-eem.913.mcz
by commits＠source.squeak.org 02 Oct '20

02 Oct '20

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.913.mcz ==================== Summary ==================== Name: Collections-eem.913 Author: eem Time: 1 October 2020, 4:19:52.930593 pm UUID: fb7fd4f9-a89f-4a71-8807-66b7d9861f06 Ancestors: Collections-eem.912 Move arrayType to the instance side where it matches associationClass, and where it is more convenient for everything except arguably OrderedCollection. Have OrderedCollection compensate very simply. =============== Diff against Collections-eem.912 =============== Item was removed: - ----- Method: FloatCollection class>>arrayType (in category 'private') ----- - arrayType - ^ Float32Array! Item was added: + ----- Method: FloatCollection>>arrayType (in category 'private') ----- + arrayType + ^ Float32Array! Item was removed: - ----- Method: HashedCollection class>>arrayType (in category 'private') ----- - arrayType - ^ Array! Item was added: + ----- Method: HashedCollection>>arrayType (in category 'private') ----- + arrayType + ^ Array! Item was changed: ----- Method: HashedCollection>>growTo: (in category 'private') ----- growTo: anInteger "Grow the elements array and reinsert the old elements" | oldElements | oldElements := array. + array := self arrayType new: anInteger. - array := self class arrayType new: anInteger. self noCheckNoGrowFillFrom: oldElements! Item was changed: ----- Method: HashedCollection>>initialize: (in category 'private') ----- initialize: n "Initialize array to an array size of n" + array := self arrayType new: n. - array := self class arrayType new: n. tally := 0! Item was removed: - ----- Method: NonPointersOrderedCollection class>>arrayType (in category 'private') ----- - arrayType - "This method must return a non-pointers array class." - - self subclassResponsibility! Item was added: + ----- Method: NonPointersOrderedCollection>>arrayType (in category 'private') ----- + arrayType + "This method must return a non-pointers array class." + + self subclassResponsibility! Item was removed: - ----- Method: OrderedCollection class>>arrayType (in category 'private') ----- - arrayType - ^ Array! Item was changed: ----- Method: OrderedCollection class>>new: (in category 'instance creation') ----- new: anInteger + | instance | + ^(instance := self basicNew) setCollection: (instance arrayType new: anInteger)! - ^ self basicNew setCollection: (self arrayType new: anInteger)! Item was changed: ----- Method: OrderedCollection class>>new:withAll: (in category 'instance creation') ----- new: anInteger withAll: anObject + | instance | + ^(instance := self basicNew) setContents: (instance arrayType new: anInteger withAll: anObject)! - ^ self basicNew setContents: (self arrayType new: anInteger withAll: anObject)! Item was added: + ----- Method: OrderedCollection>>arrayType (in category 'private') ----- + arrayType + ^ Array! Item was changed: ----- Method: OrderedCollection>>growAtFirst (in category 'private') ----- growAtFirst "Add new empty slots to the front of array, while keeping the empty slots at the end." | newArray newFirstIndex newLastIndex | + newArray := self arrayType new: (array size * 2 max: 1). - newArray := self class arrayType new: (array size * 2 max: 1). newFirstIndex := newArray size - array size + firstIndex. newLastIndex := newFirstIndex + lastIndex - firstIndex. newArray replaceFrom: newFirstIndex to: newLastIndex with: array startingAt: firstIndex. array := newArray. firstIndex := newFirstIndex. lastIndex := newLastIndex! Item was changed: ----- Method: OrderedCollection>>growAtLast (in category 'private') ----- growAtLast "Add new empty slots to the end of array, while keeping the empty slots at the front." | newArray | + newArray := self arrayType new: (array size * 2 max: 1). - newArray := self class arrayType new: (array size * 2 max: 1). newArray replaceFrom: firstIndex to: lastIndex with: array startingAt: firstIndex. array := newArray! Item was changed: ----- Method: OrderedCollection>>removeAll (in category 'removing') ----- removeAll "remove all the elements from this collection. Keep same amount of storage" + self setCollection: (self arrayType new: array size)! - self setCollection: (self class arrayType new: array size)! Item was changed: ----- Method: OrderedDictionary>>growTo: (in category 'private') ----- growTo: anInteger | oldOrder | super growTo: anInteger. oldOrder := order. "Grow only to 75%. See #atNewIndex:put: in HashedCollection." + order := self arrayType new: anInteger + 1 * 3 // 4. - order := self class arrayType new: anInteger + 1 * 3 // 4. order replaceFrom: 1 to: tally with: oldOrder startingAt: 1! Item was changed: ----- Method: OrderedDictionary>>initialize: (in category 'private') ----- initialize: n super initialize: n. + order := self arrayType new: n + 1 * 3 // 4! - order := self class arrayType new: n + 1 * 3 // 4! Item was changed: ----- Method: OrderedDictionary>>postCopyFrom:to: (in category 'copying') ----- postCopyFrom: startIndex to: endIndex "Adapted from SequenceableCollection and OrderedCollection." | oldOrder | oldOrder := order. + array := self arrayType - array := self class arrayType new: (self class goodPrimeAtLeast: endIndex - startIndex + 1 * 4 // 3). "fill 75% to 100%" + order := self arrayType - order := self class arrayType new: array size + 1 * 3 // 4. "remove 25%" startIndex to: endIndex do: [:index | | element | element := (oldOrder at: index) copy. order at: index - startIndex + 1 put: element. array at: (self scanFor: element key) put: element]. + tally := endIndex - startIndex + 1! - tally := endIndex - startIndex + 1.! Item was added: + ----- Method: ReadStream>>contentsFrom:to: (in category 'accessing') ----- + contentsFrom: startIndex to: stopIndex + "Answer with a copy of my collection from startIndex to stopIndex." + + ^collection copyFrom: (initialPositionOrNil ifNil: [1]) + startIndex - 1 to: ((initialPositionOrNil ifNil: [1]) + stopIndex - 1 min: readLimit)! Item was removed: - ----- Method: WeakIdentityDictionary class>>arrayType (in category 'private') ----- - arrayType - ^ WeakArray! Item was added: + ----- Method: WeakIdentityDictionary>>arrayType (in category 'private') ----- + arrayType + ^ WeakArray! Item was changed: ----- Method: WeakIdentityDictionary>>growTo: (in category 'private') ----- growTo: anInteger "Grow the elements array and reinsert the old elements" | oldElements | oldElements := array. + array := self arrayType new: anInteger withAll: vacuum. - array := self class arrayType new: anInteger withAll: vacuum. self noCheckNoGrowFillFrom: oldElements! Item was changed: ----- Method: WeakIdentityDictionary>>initialize: (in category 'private') ----- initialize: n vacuum := Object new. + array := self arrayType new: n withAll: vacuum. - array := self class arrayType new: n withAll: vacuum. tally := 0! Item was removed: - ----- Method: WeakOrderedCollection class>>arrayType (in category 'private') ----- - arrayType - ^ WeakArray! Item was added: + ----- Method: WeakOrderedCollection>>arrayType (in category 'private') ----- + arrayType + ^ WeakArray! Item was removed: - ----- Method: WeakSet class>>arrayType (in category 'private') ----- - arrayType - - ^WeakArray! Item was added: + ----- Method: WeakSet>>arrayType (in category 'private') ----- + arrayType + + ^WeakArray! Item was changed: ----- Method: WeakSet>>growTo: (in category 'private') ----- growTo: anInteger "Grow the elements array and reinsert the old elements" | oldElements | oldElements := array. + array := self arrayType new: anInteger withAll: flag. - array := self class arrayType new: anInteger withAll: flag. self noCheckNoGrowFillFrom: oldElements!

1 0

Ephemerons and Dictionaries
by Eliot Miranda 02 Oct '20

02 Oct '20

Hi All, to be able to ease EphemeronDicitonary into the system easily I'd like to clean up adding associations to Dictionary. It seems to me there's a partial implementation of choosing an association class appropriate for a dictionary in the implementors of associationClass: Dictionary>>#associationClass, WeakKeyDictionary>>#associationClass, WeakValueDictionary>>#associationClass, (& in my image STON class>>#associationClass). This seems workable; an EphemeronDictionary would simply add associationClass ^ Ephemeron and we're done, except not quite... First, HashedCollection does not use associationClass, but it implements atNewIndex:put: and it strikes me that atNewIndex:put: for Dictionary really should check for the thing being added at least includingBehavior: self associationClass. So that means Dictionary should override atNewIndex:put:. But what should happen in atNewIndex:put: if the object being added isn't appropriate? Do we - raise an error? (that's my preference, but I've got limited use cases in my head) - replace the association with one of assocationClass? (seems dangerous to me but maybe someone needs this or the existing system does this anyway) - ignore it and hope the user knows what they're doing? _,,,^..^,,,_ best, Eliot

3 6

The Inbox: ToolBuilder-Kernel-ct.135.mcz
by commits＠source.squeak.org 01 Oct '20

01 Oct '20

Christoph Thiede uploaded a new version of ToolBuilder-Kernel to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-ct.135.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-ct.135 Author: ct Time: 24 January 2020, 6:34:43.604574 pm UUID: 3ec2613e-56d3-2d41-b5c3-799a66a986e9 Ancestors: ToolBuilder-Kernel-mt.134 Provides fallback implementations for some UIManager messages =============== Diff against ToolBuilder-Kernel-mt.134 =============== Item was changed: ----- Method: UIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString + "Choose an item from the given list. Answer the corresponding value." + | result | + result := self chooseFrom: labelList lines: linesArray title: aString. + (result isNil or: [result isZero]) ifTrue: [^ nil]. + ^ valueList at: result! - "Choose an item from the given list. Answer the selected item." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock + "Put up a yes/no/cancel menu with caption aString. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString. Answer true if - the response is yes, false if no. If cancel is chosen, evaluate - cancelBlock. This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>confirm:orCancel:title: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock title: titleString + "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. This is a modal question--the user must respond yes or no." + ^ (self confirm: aString title: titleString) + ifFalse: [cancelBlock value]; + yourself! - "Put up a yes/no/cancel menu with caption aString, and titleString to label the dialog. - Answer true if the response is yes, false if no. If cancel is chosen, evaluate cancelBlock. - This is a modal question--the user must respond yes or no." - ^self subclassResponsibility! Item was changed: ----- Method: UIManager>>request:initialAnswer:centerAt: (in category 'ui requests - text') ----- request: queryString initialAnswer: defaultAnswer centerAt: aPoint + "Create an instance of me whose question is queryString with the given initial answer. Invoke it centered at the given point, and answer the string the user accepts. Answer the empty string if the user cancels." - "Create an instance of me whose question is queryString with the given - initial answer. Invoke it centered at the given point, and answer the - string the user accepts. Answer the empty string if the user cancels." + ^ self request: queryString initialAnswer: defaultAnswer! - ^self subclassResponsibility!

3 3

How to find unclosed file handles in Squeak?
by Thiede, Christoph 01 Oct '20

01 Oct '20

Simple question, probably we already have a helper method for it, but I did not found any yet: Often, way too often, I encounter some old code (or some stupid code written by myself) that uses #readStream to read a file and forgets to close it again. Apart from the fact that #readStream is a quite dangerous selector, I wish I could find these unclosed file streams and close them manually without restarting my entire image. Is there any quick way to do this? "Smalltalk snapshot: false andQuit: false" does not seem to do the trick, and I would prefer a less brutal approach. Something like "Utilities exploreUnclosedFileStreams" would be perfect ... Best, Christoph

3 3

Jump to page: