Squeak-dev October 2020

squeak-dev@lists.squeakfoundation.org

51 participants
394 discussions

PositionableStream >> #peekBack behavior
by Eric Gade 04 May '22

04 May '22

Hello, What is the expected behavior for a stream that is at position 1 when you send #peekBack? Intuitively I'd expect to get the first element of the underlying collection as a response. But instead I am getting nil. Here is an example that is failing: ``` elem := #(1 2 3 4). stream := ReadStream on: elem. first := stream next. first = 1. back := stream peekBack. back = first. ``` The last message is currently responding false. In Pharo this returns true, so there are differences. The currently implementation of PositionableStream >> #peekBack is: ``` peekBack "Return the element at the previous position, without changing position. Use indirect messages in case self is a StandardFileStream." | element | self position = 0 ifTrue: [self errorCantGoBack]. self position = 1 ifTrue: [self position: 0. ^ nil]. self skip: -2. element := self next. self skip: 1. ^ element ``` I can see the nil being returned there explicitly, so that's "where it's happening." Should this be the case though? Thanks -- Eric

5 7

The Inbox: Collections-ct.860.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.860.mcz ==================== Summary ==================== Name: Collections-ct.860 Author: ct Time: 15 November 2019, 1:58:56.418005 pm UUID: f6364e7f-08c8-694a-9060-21bc0a0c28d4 Ancestors: Collections-pre.857 Add convenience constructor for Dictionary Dictionary fromKeys: 'wasd' values: '8426' =============== Diff against Collections-pre.857 =============== Item was added: + ----- Method: Dictionary class>>fromKeys:values: (in category 'instance creation') ----- + fromKeys: keys values: values + + | dictionary | + self assert: [keys size = values size]. + dictionary := self new: keys size. + keys with: values do: [:key :value | + dictionary add: key -> value]. + ^ dictionary!

7 7

The Inbox: Collections-ct.875.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.875.mcz ==================== Summary ==================== Name: Collections-ct.875 Author: ct Time: 16 February 2020, 3:32:23.116 pm UUID: 61ea773b-1408-c040-a712-09238ee6fe2f Ancestors: Collections-topa.873 Extends and realigns version of #findFirst: and #findLast:. =============== Diff against Collections-topa.873 =============== Item was changed: ----- Method: SequenceableCollection>>findFirst: (in category 'enumerating') ----- findFirst: aBlock - "Return the index of my first element for which aBlock evaluates as true." + ^ self findFirst: aBlock startingAt: 1! - | index | - index := 0. - [(index := index + 1) <= self size] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findFirst:ifNone: (in category 'enumerating') ----- + findFirst: aBlock ifNone: anotherBlock + + ^ self findFirst: aBlock startingAt: 1 ifNone: anotherBlock! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex + + ^ self findFirst: aBlock startingAt: minIndex ifNone: [0]! Item was added: + ----- Method: SequenceableCollection>>findFirst:startingAt:ifNone: (in category 'enumerating') ----- + findFirst: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my first element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + index := minIndex - 1. + [(index := index + 1) <= self size] whileTrue: + [(aBlock value: (self at: index)) ifTrue: [^index]]. + ^ anotherBlock value! Item was changed: ----- Method: SequenceableCollection>>findLast: (in category 'enumerating') ----- findLast: aBlock - "Return the index of my last element for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: 1! - | index | - index := self size + 1. - [(index := index - 1) >= 1] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:ifNone: (in category 'enumerating') ----- + findLast: aBlock ifNone: anotherBlock + + ^ self findLast: aBlock startingAt: 1 ifNone: anotherBlock! Item was changed: ----- Method: SequenceableCollection>>findLast:startingAt: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex - findLast: aBlock startingAt: i - "Return the index of my last element with index >= i for which aBlock evaluates as true." + ^ self findLast: aBlock startingAt: minIndex ifNone: [0]! - | index | - index := self size + 1. - [(index := index - 1) >= i] whileTrue: - [(aBlock value: (self at: index)) ifTrue: [^index]]. - ^ 0! Item was added: + ----- Method: SequenceableCollection>>findLast:startingAt:ifNone: (in category 'enumerating') ----- + findLast: aBlock startingAt: minIndex ifNone: anotherBlock + "Return the index of my last element with index >= minIndex for which aBlock evaluates as true. If no element is found, return the value of anotherBlock." + + | index | + index := self size + 1. + [(index := index - 1) >= minIndex] whileTrue: + [(aBlock value: (self at: index)) ifTrue: [^index]]. + ^ anotherBlock value!

6 12

The Inbox: Collections-ct.871.mcz
by commits＠source.squeak.org 07 Apr '22

07 Apr '22

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ct.871.mcz ==================== Summary ==================== Name: Collections-ct.871 Author: ct Time: 30 December 2019, 3:06:02.364602 pm UUID: 235b9546-6ad3-b547-8661-38c5f2a98374 Ancestors: Collections-nice.868 Refactor CharacterClass >> #constantNames: Use reflection instead of hardcoding all names. With this change, further characters such as Character arrowLeft are printed legibly. =============== Diff against Collections-nice.868 =============== Item was changed: ----- Method: Character class>>constantNames (in category 'private') ----- constantNames + ^ self class methodsInCategory: #'accessing untypeable characters'! - ^ #( backspace cr delete escape lf null newPage space tab ).!

2 1

The Trunk: System-mt.1018.mcz
by commits＠source.squeak.org 19 Jan '22

19 Jan '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1018.mcz ==================== Summary ==================== Name: System-mt.1018 Author: mt Time: 16 April 2018, 10:31:28.239614 am UUID: e0350560-a5a5-5a40-b31b-d13f55162021 Ancestors: System-mt.1017 #setAuthorInitials: -> #authorInitials: =============== Diff against System-mt.1017 =============== Item was changed: ----- Method: SmalltalkImage>>openSourceFiles (in category 'sources, changes log') ----- openSourceFiles self imageName = LastImageName ifFalse: ["Reset the author initials to blank when the image gets moved" LastImageName := self imageName. + Utilities authorInitials: '']. - Utilities setAuthorInitials: '']. FileDirectory openSources: self sourcesName andChanges: self changesName forImage: LastImageName. SourceFileArray install!

4 4

The Inbox: SUnitTools-jr.5.mcz
by commits＠source.squeak.org 16 Jan '22

16 Jan '22

A new version of SUnitTools was added to project The Inbox: http://source.squeak.org/inbox/SUnitTools-jr.5.mcz ==================== Summary ==================== Name: SUnitTools-jr.5 Author: jr Time: 5 March 2020, 9:53:04.92876 pm UUID: 612a0a0e-43fa-de40-8370-f5e90d767232 Ancestors: SUnitTools-tcj.4 Allow to create a new test class immediately if none is found. =============== Diff against SUnitTools-tcj.4 =============== Item was added: + ----- Method: CodeHolder>>testAskToCreateNewTest: (in category '*SUnitTools-running') ----- + testAskToCreateNewTest: className + (self confirm: 'Test class not found. Create one?') ifFalse: [^ false]. + (ClassBuilder new) + name: className asSymbol + inEnvironment: self selectedClass environment + subclassOf: TestCase + type: #normal + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: + ((self selectedClass category includes: $-) + ifTrue: [((self selectedClass category copyUpToLast: $-), '-Tests')] + ifFalse: [(self selectedClass category, 'Tests')]) asSymbol. + ^ true! Item was changed: ----- Method: CodeHolder>>testBrowseClassNamed:possibleMessageNamed: (in category '*SUnitTools-running') ----- testBrowseClassNamed: aClassName possibleMessageNamed: aMessageName | cls selector | + (self class environment hasClassNamed: aClassName) ifFalse: + [(self testAskToCreateNewTest: aClassName) ifFalse: [^ self]]. - (self class environment hasClassNamed: aClassName) ifFalse: ["no dice" ^ self]. cls := self class environment classNamed: aClassName. (aMessageName notNil and: [cls includesLocalSelector: (selector := aMessageName asSymbol)]) ifTrue: [ToolSet browse: cls selector: selector] ifFalse: [ToolSet browseClass: cls].!

5 7

The Inbox: SUnit-ct.130.mcz
by commits＠source.squeak.org 16 Jan '22

16 Jan '22

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.130.mcz ==================== Summary ==================== Name: SUnit-ct.130 Author: ct Time: 24 September 2020, 11:28:31.626426 am UUID: 43df5072-3a69-634c-946a-ec59903c2519 Ancestors: SUnit-pre.122 Deprecates TestResult class >> #error and replaces sends to it with #exError. It is a bad and erroneous practice to override #error in a way that does not signal an error but returns a class object. =============== Diff against SUnit-pre.122 =============== Item was changed: ----- Method: SUnitTest>>testDialectLocalizedException (in category 'tests') ----- testDialectLocalizedException self should: [TestResult signalFailureWith: 'Foo'] raise: TestResult failure. self should: [TestResult signalErrorWith: 'Foo'] + raise: TestResult exError.! - raise: TestResult error. - - ! Item was changed: ----- Method: SUnitTest>>testException (in category 'tests') ----- testException self should: [self error: 'foo'] + raise: TestResult exError! - raise: TestResult error - ! Item was changed: ----- Method: SUnitTest>>testWithExceptionDo (in category 'tests') ----- testWithExceptionDo self should: [self error: 'foo'] + raise: TestResult exError - raise: TestResult error withExceptionDo: [:exception | self assert: (exception description includesSubstring: 'foo') + ]! - ] - ! Item was changed: ----- Method: TestResult class>>error (in category 'exceptions') ----- error + + self deprecated: 'ct: Send #exError to retrieve an exception class or #error: to signal an error, depending on what you need.'. + ^ self exError! - ^self exError - ! Item was changed: ----- Method: TestResult class>>signalErrorWith: (in category 'exceptions') ----- signalErrorWith: aString + ^ self exError signal: aString! - self error signal: aString - !

3 3

The Inbox: SUnit-ct.124.mcz
by commits＠source.squeak.org 16 Jan '22

16 Jan '22

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.124.mcz ==================== Summary ==================== Name: SUnit-ct.124 Author: ct Time: 20 March 2020, 8:01:47.398237 pm UUID: d936b6a0-e7c7-2742-a817-35fa6511a15a Ancestors: SUnit-mt.121 Proposal for discussion: Adds assertion message #should:raise:then: to allow for interactively working with expected exceptions. If you like, we could also talk about #should:raise:that: (however, I still like BlockClosure >> #handles:*). Examples: TestCase new in: [:test | test should: [ test should: [self error: #foo] raise: Error then: #pass] raise: UnhandledError. test should: [self error: #foo] raise: Error then: [:ex | test assert: #foo equals: ex messageText]. ] * See exception patterns: http://forum.world.st/The-Inbox-Kernel-ct-1292-mcz-tp5109282p5109284.html =============== Diff against SUnit-mt.121 =============== Item was added: + ----- Method: TestCase>>should:raise:then: (in category 'accessing') ----- + should: aBlock raise: anExceptionalEvent then: aHandlerBlock + + | raised result | + raised := false. + result := aBlock + on: anExceptionalEvent + do: [:ex | + raised := true. + aHandlerBlock cull: ex]. + self assert: raised. + ^ result!

2 1

The Inbox: SUnit-ct.129.mcz
by commits＠source.squeak.org 11 Jan '22

11 Jan '22

Christoph Thiede uploaded a new version of SUnit to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.129.mcz ==================== Summary ==================== Name: SUnit-ct.129 Author: ct Time: 24 September 2020, 10:42:52.868426 am UUID: 92e68d23-8472-5d48-96d3-8435bd56ac14 Ancestors: SUnit-pre.122 Proposal: Catch warnings and halts in test case execution as well as Errors. Catching (Error, Warning, Halt) is a common pattern to be (relatively) sure that no debugger will occur during an operation. For related usages, see Morph >> #fullBounds, WorldState >> #displayWorldSafely:, and many other places. IMO it is no desired behavior that the whole test execution, i.e. in a TestRunner, is interrupted because any method under test contains a halt or raises a DeprecationWarning, for example. Instead, the test should be listed as red. For a similar discussion, see https://github.com/hpi-swa/smalltalkCI/issues/470. I believe we already had talked about this on squeak-dev, but if I remember correctly, I cannot find the thread again. =============== Diff against SUnit-pre.122 =============== Item was changed: ----- Method: TestCase>>timeout:after: (in category 'private') ----- timeout: aBlock after: seconds "Evaluate the argument block. Time out if the evaluation is not complete after the given number of seconds. Handle the situation that a timeout may occur after a failure (during debug)" | theProcess delay watchdog | "the block will be executed in the current process" theProcess := Processor activeProcess. delay := Delay forSeconds: seconds. "make a watchdog process" watchdog := [ delay wait. "wait for timeout or completion" theProcess ifNotNil:[ theProcess signalException: (TestFailure new messageText: 'Test timed out') ] ] newProcess. "Watchdog needs to run at high priority to do its job (but not at timing priority)" watchdog priority: Processor timingPriority-1. "catch the timeout signal" watchdog resume. "start up the watchdog" + ^[aBlock on: TestFailure, (Error, Warning, Halt) do: [:ex| - ^[aBlock on: TestFailure, Error, Halt do:[:ex| theProcess := nil. ex pass. ]] ensure:[ "evaluate the receiver" theProcess := nil. "it has completed, so ..." delay delaySemaphore signal. "arrange for the watchdog to exit" ]! Item was added: + ----- Method: TestResult class>>exAllErrors (in category 'exceptions') ----- + exAllErrors + ^ self exError, Warning, Halt + ! Item was changed: ----- Method: TestResult>>runCase: (in category 'running') ----- runCase: aTestCase | testCasePassed timeToRun | testCasePassed := true. [timeToRun := [aTestCase runCase] timeToRunWithoutGC] on: self class failure do: [:signal | failures add: aTestCase. testCasePassed := false. signal return: false] + on: self class exAllErrors - on: self class error do: [:signal | errors add: aTestCase. testCasePassed := false. signal return: false]. testCasePassed ifTrue: [passed add: aTestCase]. self durations at: aTestCase put: timeToRun.!

5 4

The Inbox: SUnitTools-ct.5.mcz
by commits＠source.squeak.org 10 Jan '22

10 Jan '22

A new version of SUnitTools was added to project The Inbox: http://source.squeak.org/inbox/SUnitTools-ct.5.mcz ==================== Summary ==================== Name: SUnitTools-ct.5 Author: ct Time: 31 May 2019, 2:15:36.714053 pm UUID: 397d3b85-7ac5-3645-baa9-b9f848d90880 Ancestors: SUnitTools-tcj.4 Change CodeHolder>>testRunSuite: -- if multiple tests fail, instead of a UIManager dialog, open a TestRunner window that provides specific information. Depends on SUnitGUI-ct.70. =============== Diff against SUnitTools-tcj.4 =============== Item was changed: ----- Method: CodeHolder>>testRunSuite: (in category '*SUnitTools-running') ----- testRunSuite: suite + | runner result | + (suite isKindOf: TestCase) + ifFalse: [ + runner := TestRunner newForSuite: suite. + result := runner runAll; result] + ifTrue: [result := suite run]. - | result | - result := suite run. (result respondsTo: #dispatchResultsIntoHistory) ifTrue: [result dispatchResultsIntoHistory]. result hasPassed ifTrue: [^ self]. + result defects size = 1 + ifTrue: [result defects anyOne debug] + ifFalse: [runner open]! - (result defects size = 1 - ifTrue: [result defects anyOne] - ifFalse: [UIManager default - chooseFrom: (result defects collect: [:each | each class name , '>>' , each selector printString]) - values: result defects - title: ('{1} passes, {2} failures, {3} errors\\Debug a failure or error?' format: { - result runCount . result failureCount . result errorCount}) withCRs] - ) ifNotNil: [:defect | defect debug]. - !

4 3

Jump to page: