Squeak-dev January 2020

squeak-dev@lists.squeakfoundation.org

43 participants
227 discussions

28 Feb '20

Hi, -] I suppose the username/password for Squeakmap and Mantis are the same, is it so ? -] I would like to make a Squeakmap package for STON but I have issues logging into Squeakmap. I made a user, username "NMI", but I never received the confirmation email. All attempts I made to re-login or rewrite the password failed. I guess something is wrong. bye Nicola

4 6

The Inbox: Graphics-jr.425.mcz
by commits＠source.squeak.org 18 Feb '20

18 Feb '20

A new version of Graphics was added to project The Inbox: http://source.squeak.org/inbox/Graphics-jr.425.mcz ==================== Summary ==================== Name: Graphics-jr.425 Author: jr Time: 30 December 2019, 3:11:45.845402 am UUID: 465fa95d-6a50-a84d-8b73-7e90a2b9d2b5 Ancestors: Graphics-pre.424 Fix message not understood when the right or bottom fraction of a LayoutFrame is nil. =============== Diff against Graphics-pre.424 =============== Item was changed: ----- Method: LayoutFrame>>printOn: (in category 'printing') ----- printOn: aStream super printOn: aStream. aStream nextPutAll: '( '. { {'l'. self leftFraction. self leftOffset}. {'t'. self topFraction. self topOffset}. {'r'. self rightFraction. self rightOffset}. {'b'. self bottomFraction. self bottomOffset} } do: [:spec | aStream nextPutAll: spec first; space. + (spec second ifNil: [0]) printOn: aStream maxDecimalPlaces: 2. - spec second printOn: aStream maxDecimalPlaces: 2. aStream nextPutAll: ((spec third ifNil: [0]) >= 0 ifTrue: ['+'] ifFalse: ['-']). (spec third ifNil: [0]) abs printOn: aStream maxDecimalPlaces: 0] separatedBy: [aStream space]. aStream nextPutAll: ' )'.!

6 9

Changeset: requestCode.cs
by Thiede, Christoph 16 Feb '20

16 Feb '20

Hi all! :-) This changeset extends the UIManager protocol by a set of methods for requesting code. It provides FillInTheCodeBlankMorph, a subclass of FillInTheBlankMorph which supports convenient code input. Convenience includes syntax highlighting, and, if installed, support for Autocompletion. This is how it looks in action: [cid:2865a4e2-48fe-4d5f-ad76-d02203731d22] This is a typical call of the new method #requestCode:cue: (diffed to the current version): [cid:6b6885ae-7834-400d-b2ee-b39f9895f706] Or another one: [cid:00e50b6c-381f-47a4-8fa9-5148eaca123a] In addition to the UIManager protocol and FillInTheCodeBlankMorph, the changeset patches three Trunk methods that can benefit from the change (Debugger>>#runUntil, Debugger>>#returnValue and MessageSet>>#filterToMessagesThat). Also, there is a small number of convenience methods I added to Compiler and CompilationCue. As you may have noticed, I used CompilationCue to bundle all the compilation relevant data - i.e. receiver, environment, context -, because I did not like to define messages that take six or more arguments in the UIManager. However, I'm not sure whether CompilationCue is the right data class for this purpose? It also defines source and requestor which are not relevant here, and all its constructors require a source as well. However, we already have many places where receiver, environment and often also context are exchanged between objects: for Compiler, for SHStylerST80 and SHParser, and for Autocompletion. Would that be reasonable to introduce a separate data class for this purpose? Note: Before merging this, let's talk about the UserNotification proposal<http://forum.world.st/Discussion-Warning-vs-Halt-or-quot-Why-is-a-warning-a…> again. Provided that we decide to implement that in a visible future, I'd prefer not to define all these 5 versions of #requestCode:cue: on UIManager. Looking forward to your feedback! :-) Best, Christoph

3 5

The Inbox: Morphic-ct.1585.mcz
by commits＠source.squeak.org 16 Feb '20

16 Feb '20

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1585.mcz ==================== Summary ==================== Name: Morphic-ct.1585 Author: ct Time: 10 November 2019, 4:01:42.092559 pm UUID: 9564d2b2-4af1-044b-96fd-532e60252fd7 Ancestors: Morphic-mt.1584 TextEditor: Don't change the cursor position after a text action has been performed. This keeps a possible selection stable after you, for example, followed a link. =============== Diff against Morphic-mt.1584 =============== Item was changed: ----- Method: TextEditor>>mouseDown: (in category 'events') ----- mouseDown: evt "Either 1) handle text actions in the paragraph, 2) begin a text drag operation, or 3) modify the caret/selection." | clickPoint b | oldInterval := self selectionInterval. clickPoint := evt cursorPoint. b := paragraph characterBlockAtPoint: clickPoint. (paragraph clickAt: clickPoint for: model controller: self) ifTrue: [ - markBlock := b. - pointBlock := b. evt hand releaseKeyboardFocus: morph. evt hand releaseMouseFocus: morph. ^ self ]. (morph dragEnabled and: [self isEventInSelection: evt]) ifTrue: [ evt hand waitForClicksOrDrag: morph event: evt selectors: {#click:. nil. nil. #startDrag:} threshold: HandMorph dragThreshold. morph setProperty: #waitingForTextDrag toValue: true. ^ self]. evt shiftPressed ifFalse: [ self closeTypeIn. markBlock := b. pointBlock := b ] ifTrue: [ self closeTypeIn. self mouseMove: evt ]. self storeSelectionInParagraph!

3 2

Service Browser for 5.3 release
by tim Rowledge 16 Feb '20

16 Feb '20

If somebody that knows what the Services Browser is for, what it does, how to use it etc could add some Help Browser pages relating to it, I suspect it might become more useful. It seems to be a sort-of Preferences tool but even fewer of the entries have helpful help messages to provide any clues about what the intent is. How would we use the keyboard shortcuts? Are any of the items in it actually used - I've not done an exhaustive check but some sampling finds no actual usage. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: CLOUT: Call Long-distance On Unused Telephone

2 1

#shouldBeImplemented vs #notYetImplemented
by Thiede, Christoph 08 Feb '20

08 Feb '20

Hi all, what exactly is the intended difference between #shouldBeImplemented and #notYetImplemented? It feels a bit confusing. I have always used #shouldBeImplemented only because it is predefined by the Debugger. But today I met #notYetImplemented and now wonder which one I should use: <http://www.hpi.de/> * Both are detected by the debugger * But #notYetImplemented has its own subclass implementation of NotImplemented which handles #receiverClass and #selector. I like this, it has a bit more object-orientation appeal. * The names don't give me an indication to any semantical difference * They are not in the same message category of Object at all! * #shouldBeImplemented raises a specific error message, while that one of #notYetImplemented is generic and less precise * But why does the #shouldBeImpleemented message mention "or a superclass should implement"? Given the subclass Bar of the superclass Foo and I compile '#baz ^self shouldBeImplemented' on Bar. Why should this indicate that #baz might have to implemented on Foo instead? * Btw, we also have Object >> #required, which looks more Trait specific. Is it a problem that Tools-Debugger depends on Traits via this selector? However, I think we might have some heterogenic duplication here, or at least miss any documentation of the differences. Can you tell me more about the history of both selectors? Should we try to merge them? Best, Christoph

4 6

Monticello Bug? Preamble of removal is executed too late
by Thiede, Christoph 06 Feb '20

06 Feb '20

Hi all, I found a possible bug in Monticello scripts. Let me try to describe the issue: Steps to reproduce 1. In Monticello Browser, create a new package named #Foo 2. In the System Browser, create a new class named #FooClass in the system category #Foo 3. On its class side, add a method named #bar - just declare it. 4. In Monticello Browser, edit the preambleOfRemoval for our #Foo Package and set it to: FooClass bar 5. Save a version of our #Foo package 6. Still in Monticello Browser, unload the foo package via context menu. Expected behavior The package is unloaded without any errors. If Foo class >> bar has a real implementation, it will have run when the package is removed. Actual behavior In MCRemovalPreambleDefinition >> #evaluate: UndefinedObject does not understand #bar. Reason In MCPackageLoader >> #analyze, the MCDependencySorter for removals does not return the removal preamble definition as the last item, but the class definition of FooClass. This happens somewhere in #addExternalProvisions:, because FooClass depends on Object and thus is moved to the end (?). Questions Am I right that this is a bug? I think we really want to execute the removal preamble *before* unloading any code definitions? How could one solve this issue? Is it necessary to treat preambles/postambles separated so that they can't be messed up by dependencies? Or would know an easier way? I'm not familiar at all with this domain, so if we want a fast solution, maybe someone others could have a look at it. Otherwise, I'd be happy to hear your opinions. Best, Christoph

4 4

The Inbox: Collections-cmm.874.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

Chris Muller uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-cmm.874.mcz ==================== Summary ==================== Name: Collections-cmm.874 Author: cmm Time: 24 January 2020, 3:32:43.628249 pm UUID: 107f3a74-177c-4338-9ad3-648e427419a1 Ancestors: Collections-ul.871 - Optimize for system compactness by ensuring the default internal array size of any HashedCollection is not initialized larger than it may ever need to be. - Let #new: be used to define larger sizes than the minimum, and perform comparably with #new even if the minimum size is specified. =============== Diff against Collections-ul.871 =============== Item was changed: ----- Method: HashedCollection class>>new (in category 'instance creation') ----- new + ^ self basicNew initialize: 3! - ^ self basicNew initialize: 5!

10 23

The Inbox: Kernel-fn.1294.mcz
by commits＠source.squeak.org 06 Feb '20

06 Feb '20

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-fn.1294.mcz ==================== Summary ==================== Name: Kernel-fn.1294 Author: fn Time: 29 January 2020, 6:47:12.028071 pm UUID: 0b61cdfe-41e2-4aee-a5f0-80d8e7d45127 Ancestors: Kernel-tonyg.1293 Remove inputSemaphore and hasInputSemaphore from EventSensor (both are no longer in use). Also drop EventSensor>>primSetInputSemaphore:. =============== Diff against Kernel-tonyg.1293 =============== Item was changed: Object subclass: #EventSensor + instanceVariableNames: 'mouseButtons mousePosition mouseWheelDelta keyboardBuffer interruptKey interruptSemaphore eventQueue lastEventPoll' - instanceVariableNames: 'mouseButtons mousePosition mouseWheelDelta keyboardBuffer interruptKey interruptSemaphore eventQueue inputSemaphore lastEventPoll hasInputSemaphore' classVariableNames: 'ButtonDecodeTable EventPollPeriod EventTicklerProcess InterruptSemaphore InterruptWatcherProcess KeyDecodeTable' poolDictionaries: 'EventSensorConstants' category: 'Kernel-Processes'! !EventSensor commentStamp: 'mt 12/13/2019 14:38' prior: 0! An EventSensor is an interface to the user input devices. There is at least one instance of EventSensor named Sensor in the system. EventSensor is a replacement for the earlier InputSensor implementation based on a set of (optional) event primitives. An EventSensor updates its state when events are received so that all state based users of Sensor (e.g., Sensor keyboard, Sensor leftShiftDown, Sensor mouseButtons) will work exactly as before, by moving the current VM mechanisms into EventSensor itself. An optional input semaphore is part of the new design. For platforms that support true asynchronous event notification, the semaphore will be signaled to indicate pending events. On platforms that do not support asynchronous notifications about events, the UI will have to poll EventSensor periodically to read events from the VM. Instance variables: mouseButtons <Integer> - mouse button state as replacement for primMouseButtons mousePosition <Point> - mouse position as replacement for primMousePt keyboardBuffer <SharedQueue> - keyboard input buffer interruptKey <Integer> - currently defined interrupt key interruptSemaphore <Semaphore> - the semaphore signaled when the interruptKey is detected eventQueue <SharedQueue> - an optional event queue for event driven applications inputSemaphore <Semaphore>- the semaphore signaled by the VM if asynchronous event notification is supported lastEventPoll <Integer> - the last millisecondClockValue at which we called fetchMoreEvents hasInputSemaphore <Boolean> - true if my inputSemaphore has actually been signaled at least once. Class variables: ButtonDecodeTable <ByteArray> - maps mouse buttons as reported by the VM to ones reported in the events. KeyDecodeTable <Dictionary<SmallInteger->SmallInteger>> - maps some keys and their modifiers to other keys (used for instance to map Ctrl-X to Alt-X) InterruptSemaphore <Semaphore> - signalled by the the VM and/or the event loop upon receiving an interrupt keystroke. InterruptWatcherProcess <Process> - waits on the InterruptSemaphore and then responds as appropriate. EventPollPeriod <Integer> - the number of milliseconds to wait between polling for more events in the userInterruptHandler. EventTicklerProcess <Process> - the process that makes sure that events are polled for often enough (at least every EventPollPeriod milliseconds). Event format: The current event format is very simple. Each event is recorded into an 8 element array. All events must provide some SmallInteger ID (the first field in the event buffer) and a time stamp (the second field in the event buffer), so that the difference between the time stamp of an event and the current time can be reported. Currently, the following events are defined: Null event ============= The Null event is returned when the ST side asks for more events but no more events are available. Structure: [1] - event type 0 [2-8] - unused Mouse event structure ========================== Mouse events are generated when mouse input is detected. [1] - event type 1 [2] - time stamp [3] - mouse x position [4] - mouse y position [5] - button state; bitfield with the following entries: 1 - 2r001 yellow (e.g., right) button 2 - 2r010 blue (e.g., middle) button 4 - 2r100 red (e.g., left) button [all other bits are currently undefined] [6] - modifier keys; bitfield with the following entries: 1 - shift key 2 - ctrl key 4 - (Mac specific) option key 8 - Cmd/Alt key [all other bits are currently undefined] [7] - reserved. [8] - host window id. Keyboard events ==================== Keyboard events are generated when keyboard input is detected. [1] - event type 2 [2] - time stamp [3] - character code (Ascii) For now the character code is in Mac Roman encoding. See #macToSqueak. For key press/release (see [4]), character codes are normalized. [4] - press state; integer with the following meaning 0 - character (aka. key stroke or key still pressed) 1 - key press (aka. key down) 2 - key release (aka. key up) [5] - modifier keys (same as in mouse events) For key press/release (see [4]), modifier keys are still accessible. [6] - character code (Unicode UTF32) Manual decoding via KeyboardInputInterpreter possible. For key press/release (see [4]), character codes are normalized. [7] - reserved. [8] - host window id. Mouse-wheel event structure ========================== Mouse-wheel events are generated when mouse-wheel input is detected. [1] - event type 7 [2] - time stamp [3] - horizontal scroll delta [4] - vertical scroll delta [5] - button state (same as in mouse events) [6] - modifier keys (same as in mouse events) [7] - reserved. [8] - host window id. ! Item was changed: ----- Method: EventSensor>>fetchMoreEvents (in category 'private-I/O') ----- fetchMoreEvents "Fetch more events from the VM" | eventBuffer type | - "Reset input semaphore so clients can wait for the next events after this one." - inputSemaphore isSignaled - ifTrue: [ hasInputSemaphore := true. - inputSemaphore initSignals ]. - "Remember the last time that I checked for events." lastEventPoll := Time millisecondClockValue. eventBuffer := Array new: 8. [self primGetNextEvent: eventBuffer. type := eventBuffer at: 1. type = EventTypeNone] whileFalse: [self processEvent: eventBuffer]. ! Item was changed: ----- Method: EventSensor>>initialize (in category 'initialize') ----- initialize "Initialize the receiver" mouseButtons := 0. mousePosition := 0 @ 0. mouseWheelDelta := 0 @ 0. keyboardBuffer := SharedQueue new. self setInterruptKey: (interruptKey ifNil: [$. asciiValue bitOr: 16r0800 ]). "cmd-." interruptSemaphore := (Smalltalk specialObjectsArray at: 31) ifNil: [Semaphore new]. + self flushAllButDandDEvents.! - self flushAllButDandDEvents. - inputSemaphore := Semaphore new. - hasInputSemaphore := false.! Item was removed: - ----- Method: EventSensor>>primSetInputSemaphore: (in category 'private-I/O') ----- - primSetInputSemaphore: semaIndex - "Set the input semaphore the VM should use for asynchronously signaling the availability of events. Primitive. Optional." - <primitive: 93> - ^nil! Item was changed: ----- Method: EventSensor>>shutDown (in category 'initialize') ----- shutDown InterruptWatcherProcess ifNotNil: [ InterruptWatcherProcess terminate. InterruptWatcherProcess := nil ]. EventTicklerProcess ifNotNil: [ EventTicklerProcess terminate. + EventTicklerProcess := nil. ].! - EventTicklerProcess := nil. ]. - - inputSemaphore ifNotNil:[Smalltalk unregisterExternalObject: inputSemaphore].! Item was changed: ----- Method: EventSensor>>startUp (in category 'initialize') ----- startUp self initialize. - self primSetInputSemaphore: (Smalltalk registerExternalObject: inputSemaphore). self installInterruptWatcher. self installEventTickler. + Smalltalk isMorphic ifTrue: [self flushAllButDandDEvents].! - Smalltalk isMorphic ifTrue: [self flushAllButDandDEvents]. - - "Attempt to discover whether the input semaphore is actually being signaled." - hasInputSemaphore := false. - inputSemaphore initSignals.!

7 13

[BUG] Editor history working unreliably
by Thiede, Christoph 01 Feb '20

01 Feb '20

Steps to reproduce: Open a workspace. Type: foo Press: Home key Press: <cmd>z Expected behavior: The text in the workspace will abandon, and the textmorph will not have unaccepted changes. Actual behavior: The text in the workspace remains, but the textmorph does not indicate unaccepted changes. You cannot press <cmd>z again to revert the empty state of the textmorph. Not yet further investigated ... Best, Christoph

4 3

← Newer
1
2
3
4
5
6
7
8
...
23
Older →

Jump to page: