Squeak-dev July 2019

squeak-dev@lists.squeakfoundation.org

44 participants
160 discussions

The Trunk: ShoutTests-ul.29.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Levente Uzonyi uploaded a new version of ShoutTests to project The Trunk: http://source.squeak.org/trunk/ShoutTests-ul.29.mcz ==================== Summary ==================== Name: ShoutTests-ul.29 Author: ul Time: 19 July 2019, 12:12:23.29542 am UUID: 0a0cf788-d9f5-4089-838a-b32342d3b21d Ancestors: ShoutTests-ul.28 SHParserST80 >> #fail doesn't generate an empty range with type #excessCode anymore if the whole source was parsed. =============== Diff against ShoutTests-ul.28 =============== Item was changed: ----- Method: SHParserST80Test>>testNumbers (in category 'tests') ----- (excessive size, no diff calculated)

1 0

The Inbox: CollectionsTests-pre.314.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Patrick Rein uploaded a new version of CollectionsTests to project The Inbox: http://source.squeak.org/inbox/CollectionsTests-pre.314.mcz ==================== Summary ==================== Name: CollectionsTests-pre.314 Author: pre Time: 22 July 2019, 3:14:39.839761 pm UUID: e3cb9512-d24c-034b-9c4d-31dc6aa3c7e4 Ancestors: CollectionsTests-mt.313 Adds tests for collect:as: which has a suprising limitation for collecting a Set as a Dictionary. =============== Diff against CollectionsTests-mt.313 =============== Item was added: + ----- Method: CollectionTest>>testCollectAs (in category 'tests') ----- + testCollectAs + + | classes collection newCollection | + classes := {Array . OrderedCollection . Set . Bag}. + classes do: [:originClass | + classes do: [:targetClass | + collection := originClass with: 1 with: 2 with: 3. + newCollection := collection collect: [:v | v + 1] as: targetClass. + self + assert: collection size equals: newCollection size; + assert: (newCollection includesAllOf: { 2 . 3. 4})]]! Item was added: + ----- Method: DictionaryTest>>testCollectAs (in category 'tests - collection protocol') ----- + testCollectAs + + | classes collection dictionary | + classes := {Array . OrderedCollection . Set . Bag}. + classes do: [:originClass | + collection := originClass with: 1 with: 2 with: 3. + dictionary := collection collect: [:v | v -> (v + 1)] as: Dictionary. + self + assert: collection size equals: dictionary size; + assert: (dictionary associations includesAllOf: { 1 -> 2 . 2 -> 3. 3 -> 4})]!

1 0

The Trunk: Tools-mt.855.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.855.mcz ==================== Summary ==================== Name: Tools-mt.855 Author: mt Time: 22 July 2019, 11:50:35.866271 am UUID: cf7f6661-b022-4863-9fdb-5225000135af Ancestors: Tools-mt.854 Complements System-mt.1073. Not that this only works if SystemNavigation always uses its environment and not the incoming class' environment. See: Behavior >> #allCallsOn: Object >> #systemNavigation =============== Diff against Tools-mt.854 =============== Item was changed: ----- Method: ObjectExplorer>>browseClassRefs (in category 'menus - actions') ----- browseClassRefs self selectedClass ifNotNil: [:cls | + cls isTrait ifFalse: [self systemNavigation browseAllCallsOnClass: cls]]! - cls isTrait ifFalse: [ - self systemNavigation browseAllCallsOn: (self environment bindingOf: cls theNonMetaClass name)]]! Item was changed: ----- Method: StringHolder>>browseClassRefs (in category '*Tools-traits') ----- browseClassRefs self selectedClass ifNotNil: [:cls | + cls isTrait ifFalse: [self systemNavigation browseAllCallsOnClass: cls]] - cls isTrait ifFalse: [ - self systemNavigation browseAllCallsOn: (self environment bindingOf: cls theNonMetaClass name)]] !

1 0

The Trunk: System-mt.1074.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1074.mcz ==================== Summary ==================== Name: System-mt.1074 Author: mt Time: 22 July 2019, 11:47:50.192271 am UUID: 89214728-19f3-4883-8e1c-9a702ce0b968 Ancestors: System-mt.1073 Since class references can be compared against method references, make it that method references can be compared against class references, too. =============== Diff against System-mt.1073 =============== Item was changed: ----- Method: MethodReference>><= (in category 'comparing') ----- + <= anotherMethodOrClassReference - <= anotherMethodReference + classSymbol < anotherMethodOrClassReference classSymbol ifTrue: [^true]. + classSymbol > anotherMethodOrClassReference classSymbol ifTrue: [^false]. + classIsMeta = anotherMethodOrClassReference classIsMeta ifFalse: [^classIsMeta not]. + ^ self species = anotherMethodOrClassReference species + and: [methodSymbol <= anotherMethodOrClassReference methodSymbol] - classSymbol < anotherMethodReference classSymbol ifTrue: [^true]. - classSymbol > anotherMethodReference classSymbol ifTrue: [^false]. - classIsMeta = anotherMethodReference classIsMeta ifFalse: [^classIsMeta not]. - ^methodSymbol <= anotherMethodReference methodSymbol !

1 0

The Trunk: Morphic-mt.1494.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1494.mcz ==================== Summary ==================== Name: Morphic-mt.1494 Author: mt Time: 22 July 2019, 11:46:46.821271 am UUID: accf580c-8888-4787-9250-bc4518ebcfb5 Ancestors: Morphic-mt.1493 In text editors, [cmd]+[shift]+[N] now correctly includes references in pool dictionaries. =============== Diff against Morphic-mt.1493 =============== Item was changed: ----- Method: TextEditor>>referencesToIt (in category 'menu messages') ----- referencesToIt "Open a MessageSet with the references to the selected global or variable name." | selection environment binding | self selection isEmpty ifTrue: [ self selectWord ]. environment := (model respondsTo: #selectedClassOrMetaClass) ifTrue: [ model selectedClassOrMetaClass ifNil: [ model environment ] ] ifFalse: [ model environment ]. selection := self selectedSymbol ifNil: [ self selection asString ]. (environment isBehavior and: [ (environment instVarIndexFor: selection ifAbsent: [ 0 ]) ~= 0 ]) ifTrue: [ ^ self systemNavigation browseAllAccessesTo: selection from: environment ]. selection isSymbol ifFalse: [ ^ morph flash ]. binding := (environment bindingOf: selection) ifNil: [ ^ morph flash ]. + + self systemNavigation browseAllCallsOnClass: binding.! - self systemNavigation browseAllCallsOn: binding!

1 0

The Trunk: Tools-mt.854.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.854.mcz ==================== Summary ==================== Name: Tools-mt.854 Author: mt Time: 22 July 2019, 11:06:46.775271 am UUID: 9f30ae3b-a6ae-43f7-ae0b-3bf3e300b85c Ancestors: Tools-mt.853 For class-ref search, use the tool's environment to find the relevant class binding. Do not rely on the class's original environment. This shouldn't make any difference at the moment but maybe in the future if somebody decides to make the identity of class bindings important. See: Lookupkey >> #literalEqual: ClassBinding >> #literalEqual: Also see TextEditor >> #referencesToIt, which also uses the tool's (there: "model") environment. =============== Diff against Tools-mt.853 =============== Item was changed: ----- Method: ObjectExplorer>>browseClassRefs (in category 'menus - actions') ----- browseClassRefs + self selectedClass ifNotNil: [:cls | + cls isTrait ifFalse: [ + self systemNavigation browseAllCallsOn: (self environment bindingOf: cls theNonMetaClass name)]]! - (self selectedClass notNil and: [self selectedClass isTrait not]) - ifTrue: [self systemNavigation browseAllCallsOnClass: self selectedClass theNonMetaClass].! Item was changed: ----- Method: StringHolder>>browseClassRefs (in category '*Tools-traits') ----- browseClassRefs + self selectedClass ifNotNil: [:cls | + cls isTrait ifFalse: [ + self systemNavigation browseAllCallsOn: (self environment bindingOf: cls theNonMetaClass name)]] - | cls | - cls := self selectedClass. - (cls notNil and: [cls isTrait not]) - ifTrue: [self systemNavigation browseAllCallsOnClass: cls theNonMetaClass] !

1 0

The Trunk: System-mt.1072.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1072.mcz ==================== Summary ==================== Name: System-mt.1072 Author: mt Time: 22 July 2019, 11:01:13.380271 am UUID: da465e06-a24c-4ef2-9ecd-3c78c14fcd87 Ancestors: System-mt.1071 Fixes regression in class-ref search to not yield methods that send only symbols of class names. For class symbols, use regular senders search with a symbol (i.e., #allCallsOn:). =============== Diff against System-mt.1071 =============== Item was changed: ----- Method: SystemNavigation>>allCallsOnClass: (in category 'query') ----- allCallsOnClass: aBehavior "Answer a sorted collection of all the methods that refer to aBehavior." | theClass result | theClass := aBehavior theNonMetaClass. result := self + allCallsOn: (theClass environment bindingOf: theClass name) - allCallsOn: theClass name fromBehaviors: self allBehaviors sorted: false. theClass environment allClassesDo: [ :class | (class sharedPools includes: theClass) ifTrue: [ result add: (ClassReference class: class) ] ]. ^result sort!

1 0

Senders "too thorough"
by Levente Uzonyi 22 Jul '19

22 Jul '19

Hi All, With the recent changes of literal searching, I've found something unusual. If you evaluate the following snippet, there will be some false positives (e.g. Scanner >> #initialize) on the list. These methods do not reference the searched literal, but they reference a class variable (TypeTable), which happens to be an array containing the searched symbol: SystemNavigation default browseAllCallsOn: #xLitQuote. The reason why it appears is that CompiledCode >> #hasLiteral: will try Object >> #hasLiteral: first, which uses #allLiteralsDo:, which descends into the value of the binding of the TypeTable class variable and finds the symbol. Levente

2 2

The Trunk: Environments-mt.75.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-mt.75.mcz ==================== Summary ==================== Name: Environments-mt.75 Author: mt Time: 22 July 2019, 10:02:11.8399 am UUID: 3e91a5a9-61c6-426d-8797-ca99a2fe8422 Ancestors: Environments-mt.74 Addition to Collections-mt.845. =============== Diff against Environments-mt.74 =============== Item was removed: - ----- Method: Binding>>allLiteralsDo: (in category 'literals') ----- - allLiteralsDo: aBlock - - "I am a literal." - aBlock value: self. - - self key allLiteralsDo: aBlock. - self value allLiteralsDo: aBlock.! Item was removed: - ----- Method: Global>>literalEqual: (in category 'literals') ----- - literalEqual: other - "Globals are only equal to themselves, since another global with the same - name could have a different value in the future." - - ^ self == other!

1 0

The Trunk: Collections-mt.845.mcz
by commits＠source.squeak.org 22 Jul '19

22 Jul '19

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.845.mcz ==================== Summary ==================== Name: Collections-mt.845 Author: mt Time: 22 July 2019, 10:01:05.9849 am UUID: f3187206-088a-4183-ae97-52fdb06b88cf Ancestors: Collections-dtl.844 During all-literals enumeration, do not decend into association values. Users want to find the tokens they typed, not what the system generated or somehow stored. In particular, there is no need to look into class variables for literals. :-) =============== Diff against Collections-dtl.844 =============== Item was removed: - ----- Method: Association>>allLiteralsDo: (in category 'literals') ----- - allLiteralsDo: aBlock - "This strategy origins from a former implementation of CompiledMethod >> #hasLiteralThorough: as well as AdditionalMethodState >> #hasLiteralSuchThat:." - - "I am a literal." - aBlock value: self. - - "All my components are literals." - self key allLiteralsDo: aBlock. - self value allLiteralsDo: aBlock.! Item was removed: - ----- Method: Association>>literalEqual: (in category 'literals') ----- - literalEqual: otherLiteral - "Answer true if the receiver and otherLiteral represent the same literal. - Variable bindings are literally equals only if identical. - This is how variable sharing works, by preserving identity and changing only the value." - ^self == otherLiteral! Item was added: + ----- Method: LookupKey>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "Treat myself or my key as literal. Do not treat any value (i.e., in Association or Binding) as literal to avoid decending too thoroughly. As a consequence, for example, classes have to be resolved to their class bindings or class names before using them as input in this interface." + + aBlock value: self. + self key allLiteralsDo: aBlock.! Item was added: + ----- Method: LookupKey>>literalEqual: (in category 'literals') ----- + literalEqual: otherLiteral + "Answer true if the receiver and otherLiteral represent the same literal. + + By default, all lookup keys (such as variable bindings) are literally equal only if identical. This is how variable sharing works, by preserving identity and changing only the value. + + Override if you want to be more flexible such as in class bindings." + + ^ self == otherLiteral!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
16
Older →

Jump to page: