Squeak-dev April 2019

squeak-dev@lists.squeakfoundation.org

36 participants
122 discussions

The Inbox: ImageFormat-kks.35.mcz
by commits＠source.squeak.org 10 Apr '19

10 Apr '19

A new version of ImageFormat was added to project The Inbox: http://source.squeak.org/inbox/ImageFormat-kks.35.mcz ==================== Summary ==================== Name: ImageFormat-kks.35 Author: kks Time: 10 April 2019, 11:21:27.422478 pm UUID: 67c4b2d3-702b-447e-890c-1ba698a71b4f Ancestors: ImageFormat-kks.34 Removed tests for 68004, 68021 formats since 68004 is no longer a base version number. =============== Diff against ImageFormat-kks.34 =============== Item was changed: ----- Method: ImageFormatTest>>testIsValidVersionNumber (in category 'testing') ----- testIsValidVersionNumber self should: [ImageFormat fromInteger: 0] raise: Error. self should: [ImageFormat fromInteger: (6502 bitAnd: 16r80000000)] raise: Error. self should: [ImageFormat fromInteger: (6502 bitAt: 31 put: 1)] raise: Error. self should: [ImageFormat fromInteger: 6500] raise: Error. self should: [ImageFormat fromInteger: 6501] raise: Error. self should: [ImageFormat fromInteger: 6503] raise: Error. "Cog requires both capabilities" self should: [ImageFormat fromInteger: 68001] raise: Error. "Cog requires both capabilities" self assert: ImageFormat default isValidVersionNumber. self assert: (ImageFormat wordSize: 4 closures: false) isValidVersionNumber. self assert: (ImageFormat wordSize: 4 closures: true) isValidVersionNumber. self assert: (ImageFormat wordSize: 8 closures: false) isValidVersionNumber. self assert: (ImageFormat wordSize: 8 closures: true) isValidVersionNumber. self assert: (ImageFormat fromInteger: 6502) isValidVersionNumber. self assert: (ImageFormat fromInteger: (6502 bitAt: 31 put: 0)) isValidVersionNumber. self assert: (ImageFormat fromInteger: 6521) isValidVersionNumber. self assert: (ImageFormat fromInteger:68000) isValidVersionNumber. self assert: (ImageFormat fromInteger:68002) isValidVersionNumber. - self assert: (ImageFormat fromInteger:68004) isValidVersionNumber. self assert: (ImageFormat fromInteger:68003) isValidVersionNumber. "valid but unused, as with 68019" self assert: (ImageFormat fromInteger: 68019) isValidVersionNumber. - self assert: (ImageFormat fromInteger: 68021) isValidVersionNumber. !

1 0

unused method removal in Caffeine
by Craig Latta 09 Apr '19

09 Apr '19

Hi-- I got the unused-method-removal stuff from Spoon running in SqueakJS, and I wrote a blog post about it: https://thiscontext.com/2019/03/25/the-big-shake-out I'd love to hear of any use cases people are interested in pursuing. thanks, -C -- Craig Latta Black Page Digital Amsterdam :: San Francisco craig(a)blackpagedigital.com +31 6 2757 7177 + 1 415 287 3547

3 3

TR: High language to express low level code
by pierre misse 09 Apr '19

09 Apr '19

Thank you guys for your answers ! @Dave Thank you for the precisions. I actually had read this article, and -Extending the Squeak Virtual Machine by Andrew C. GreenBerg -Two decade of Smalltalk VM Development by Eliot Miranda , Clement Bera, Elisa Gonzalez Boix, and Dan Ingallls. But i didn't find much more on how it works. I was looking at it mostly from the transpilation point of vue. I'll have to take a closer look at TMethod/TparseNode/CCodeGenerator ! "The Smalltalk to C (or Javascript) capability is not intended to be a general purpose languange. The general purpose language in this case is of course Smalltalk itself, and the slang translator serves as an optimizer to translate the virtual machine (which is written primarily in Smalltalk) into C to produce a high performance runtime." Did you mean "which is written primarily in SLANG"? For now I'm taking it as "the slang translator translate Smalltalk code" which feels weird to me. @Eliot "That depends on the architecture you choose." I completely agree, and should have been more precise. I tend to think of a static approach so far. Taking my language, translating it to C, then letting C files be compiled in assembly by a random c compiler (probably GCC). I'd like to be able to express both stand alone program, and libraries. I actually read up on Sista on Clement's blog. I also read an article on LowCode. But as you just read, those approaches aren't really what I aim for ! 'I don't have time or resources to explore the inessential ;-)' True that ! But I meant more something that poped into your head, without having the time to follow up :p 'For me C is an implementation language; a portable assembler.' I get this point of vue. But I meant something like what you have to use, because it's important but is annoying. The usual example is memory management (at least in general) which is why we have so much garbage collectors ! In that feeling, Hiding memory management in the transpiler would result for example in garbage collection[...]. I was trying to ask what do you have to manage, but bothers you, to see if it's possible to hide it. For example, I think in Slang, you don't bother about memory management, but you do require types. I don't know if that's more understandable. Thanks you. Pierre Misse ________________________________ De : Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> de la part de Eliot Miranda <eliot.miranda(a)gmail.com> Envoyé : mardi 2 avril 2019 18:09 À : The general-purpose Squeak developers list Objet : Re: [squeak-dev] High language to express low level code Hi Pierre, On Mon, Apr 1, 2019 at 11:03 PM pierre misse <pierre_misse25(a)msn.com<mailto:pierre_misse25@msn.com>> wrote: Hello, I'm currently trying to create a "high" level language to that aims to express low level concepts through transpilation to C. I have a limited experience building such programs, and thought people who build virtual machines would be the right group of people to ask what they need in low level programing! I've also made some research, and stumbled Slang, on which i found little documentation (probably because i didn't find the right combination of words). So if you have a bit of time to share, i'd love to know: * What you kind of concepts you need That depends pn the architecture you choose. There are static and dynamic approaches, approaches centered around optimization and JIT com platoon and approaches centered around embedding a domain-specific language (DSL) in a high-level language to allow for specific low-level code to be generated. I would love for you to direct your attention to Ronie Salgado's work on Lowcode, and Clément Béra's and my work on Sista and Scorch. Ronie's work is a combination of providing a DSL for communicating with graphics renderers. This fairs within the extensions to the bytecode set Clément and I have designed for aggressive adaptive optimization in the context of a JIT. Note that Ronie's subset of bytecodes has also shown speedups in a pure interpreter. We have papers on both systems. * What's not required, but interesting I don't have time or resources to explore the inessential ;-) * What you'd wish to hide from C to be taken care of by the transpiler For me C is an implementation language; a portable assembler. There really isn't any need to hide anything from C. But the only time I pay attention to C is when I have to debug the system in the C world, which is thankfully rare, or shen the transpolar has a bug which manifests as a failure for the C to compiler. So it's not an issue of hiding or revealing things to C. It's an issue of C not being a useful context in which to get work done. It's effectively write-only. HTH Thank you in advance. Regards, Pierre Misse. -- _,,,^..^,,,_ best, Eliot

2 2

The Inbox: Installer-Core-cmm.429.mcz
by commits＠source.squeak.org 09 Apr '19

09 Apr '19

Chris Muller uploaded a new version of Installer-Core to project The Inbox: http://source.squeak.org/inbox/Installer-Core-cmm.429.mcz ==================== Summary ==================== Name: Installer-Core-cmm.429 Author: cmm Time: 8 April 2019, 2:01:23.400753 pm UUID: 12e11ef9-421b-4e4c-88b0-a4921fe4d4a8 Ancestors: Installer-Core-tcj.426 Allow installation of github projects via the scripts at the top of their readme files, without first having to manually ensure Metacello is installed. Metacello new baseline: 'NameOfTheProject'; repository: 'github://...'; load =============== Diff against Installer-Core-tcj.426 =============== Item was changed: ----- Method: Installer class>>ensureRecentMetacello (in category 'scripts') ----- ensureRecentMetacello "Copied and adapted from https://github.com/Metacello/metacello/blob/master/README.md" | metacello | ((Smalltalk classNamed: #WebClient) ifNil: [ false ] ifNotNil: [ :webClient | [ (webClient httpHead: 'https://github.com') isSuccess ] on: Error do: [ false ] ]) ifFalse: [ ^self inform: 'Could not connect to "https://github.com".\\You need an internet connection and SSL support\to install (or update) Metacello.\\Please fix those issues and try again.' translated withCRs ]. + "Squeak is shipped with the global #Metacello referring to lightweight MetacelloStub. After the first message is sent, the latest Metacello is installed, replacing the stub." + metacello := Smalltalk at: #Metacello. + metacello = MetacelloStub ifTrue: [ - metacello := (Smalltalk classNamed: #Metacello) ifNil: [ "Get the Metacello configuration (for Squeak users)" Installer gemsource project: 'metacello'; addPackage: 'ConfigurationOfMetacello'; install. "Bootstrap Metacello Preview, using mcz files (#'previewBootstrap' symbolic version" ((Smalltalk classNamed: #ConfigurationOfMetacello) project version: #'previewBootstrap') load. Smalltalk classNamed: #Metacello ]. "Now load latest version of Metacello" metacello new baseline: 'Metacello'; repository: 'github://Metacello/metacello:master/repository'; get. metacello new baseline: 'Metacello'; repository: 'github://Metacello/metacello:master/repository'; load: #('default' 'Metacello-Help'). ! Item was added: + Object subclass: #MetacelloStub + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Installer-Core'! + + !MetacelloStub commentStamp: 'cmm 4/8/2019 14:00' prior: 0! + MetacelloStub is a loose reference to the class Metacello in its host repository. It's kept at both its real name, #MetacelloStub, as well as the name #Metacello. This is done to allow Squeak to respond to messages sent to Metacello (e.g., as referenced in external installation scripts), without the need to ship with Metacello pre-installed.! Item was added: + ----- Method: MetacelloStub class>>doesNotUnderstand: (in category 'overriding') ----- + doesNotUnderstand: aMessage + (UIManager confirm: 'This action requires Metacello, but it''s not installed. Download and install it now?') ifTrue: + [ Installer ensureRecentMetacello. + ^ aMessage sentTo: (Smalltalk classNamed: #Metacello) ]! Item was added: + ----- Method: MetacelloStub class>>initialize (in category 'initialize-release') ----- + initialize + Smalltalk + at: #Metacello + ifAbsentPut: [ self ]!

4 3

The Inbox: Morphic-jr.1485.mcz
by commits＠source.squeak.org 09 Apr '19

09 Apr '19

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-jr.1485.mcz ==================== Summary ==================== Name: Morphic-jr.1485 Author: jr Time: 9 April 2019, 1:09:03.267095 am UUID: 53e4b5d8-74e3-984a-9bcb-46d1ab07cc9e Ancestors: Morphic-cmm.1484 Change Git Infrastructure item to Git Browser It will show Install Git Browser... when the latter is not installed. Requires Installer-Core-jr.430 =============== Diff against Morphic-cmm.1484 =============== Item was added: + ----- Method: TheWorldMainDockingBar>>gitBrowserInstallMenuItemOn: (in category 'submenu - tools') ----- + gitBrowserInstallMenuItemOn: menu + menu addItem: + [ :item | + item + contents: 'Install Git Browser...' translated; + help: 'Install tools for accessing Git repositories.' translated; + icon: (self colorIcon: Color lightGray); + target: Installer; + selector: #installAndOpenGitBrowser]! Item was added: + ----- Method: TheWorldMainDockingBar>>gitBrowserMenuItemOn: (in category 'submenu - tools') ----- + gitBrowserMenuItemOn: menu + "Check whether the Git Browser model class is loaded" + (Smalltalk includesKey: #SquitBrowser) + ifTrue: [self gitBrowserOpenMenuItemOn: menu] + ifFalse: [self gitBrowserInstallMenuItemOn: menu]! Item was added: + ----- Method: TheWorldMainDockingBar>>gitBrowserOpenMenuItemOn: (in category 'submenu - tools') ----- + gitBrowserOpenMenuItemOn: menu + menu addItem: + [ :item | + item + contents: 'Git Browser' translated; + help: 'Tool for accessing Git repositories.' translated; + icon: (self colorIcon: Color lightGray); + target: (self environment valueOf: #SquitBrowser); + selector: #open]! Item was removed: - ----- Method: TheWorldMainDockingBar>>gitInfrastructureMenuItemOn: (in category 'submenu - tools') ----- - gitInfrastructureMenuItemOn: menu - menu addItem: - [ : item | item - contents: 'Git Infrastructure' translated ; - help: 'Load tools for accessing github repositories.' translated ; - icon: (self colorIcon: Color lightGray) ; - target: Installer ; - selector: #installGitInfrastructure ]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; methodFinderMenuItemOn: menu; messageNamesMenuItemOn: menu. menu addLine. self simpleChangeSorterMenuItemOn: menu; dualChangeSorterMenuItemOn: menu; monticelloBrowserMenuItemOn: menu; monticelloConfigurationsMenuItemOn: menu ; metacelloMenuItemOn: menu ; + gitBrowserMenuItemOn: menu. - gitInfrastructureMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]!

1 0

The Inbox: System-cmm.1059.mcz
by commits＠source.squeak.org 09 Apr '19

09 Apr '19

Chris Muller uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-cmm.1059.mcz ==================== Summary ==================== Name: System-cmm.1059 Author: cmm Time: 1 April 2019, 6:08:54.797918 pm UUID: 6ab6befc-9fa5-4aa5-a1b6-3570ba2853b9 Ancestors: System-eem.1058 Organize configuration scripts in the "Extending The System" workspace or SqueakMap. =============== Diff against System-eem.1058 =============== Item was changed: ----- Method: Utilities class>>initializeCommonRequestStrings (in category 'common requests') ----- initializeCommonRequestStrings "Initialize the common request strings, a directly-editable list of expressions that can be evaluated from the 'do...' menu." CommonRequestStrings := StringHolder new contents: + 'Utilities emergencyCollapse. - 'Installer ensureRecentMetacello. - Installer installGitInfrastructure. - - - Utilities emergencyCollapse. Utilities closeAllDebuggers. - Sensor keyboard. ParagraphEditor abandonChangeText. Cursor normal show. - CommandHistory resetAllHistory. Project allInstancesDo: [:p | p displayDepth: 16]. ScriptingSystem inspectFormDictionary. Form fromUser bitEdit. Display border: (0@0 extent: 640@480) width: 2. - Undeclared inspect. Undeclared removeUnreferencedKeys; inspect. Transcript clear. Utilities grabScreenAndSaveOnDisk. FrameRateMorph new openInHand. - Utilities reconstructTextWindowsFromFileNamed: ''TW''. Utilities storeTextWindowContentsToFileNamed: ''TW''. ChangeSorter removeEmptyUnnamedChangeSets. ChangeSorter reorderChangeSets. - ActiveWorld installVectorVocabulary. ActiveWorld abandonVocabularyPreference. + Smalltalk saveAsNewVersion' - Smalltalk saveAsNewVersion.' "Utilities initializeCommonRequestStrings"!

12 30

Decimals as fractions
by K K Subbu 08 Apr '19

08 Apr '19

Hi, Squeak compiler compiles numbers like "3.4" into SmallFloat types. But Squeak can also handle number pairs like Point and Fractions. Has anyone considered decimals into fractions, instead? Like how we treat fractions in real life? $0.02 is really 2/100th of a dollar. I wouldn't want it to float ;-). Squeak could compile fix points like "3.4" into fractions like "34/10" and compile into float only if an explicit exponent is given like in "3.4e0". This would help us maintain accuracy as long as possible in fraction arithmetic we use in daily life. e.g. 3.41 - 3.40 0.010000000000000231 vs ((341/100) - (340/100)) asFloat 0.01 Regards .. Subbu

3 6

The Inbox: Installer-Core-cmm.428.mcz
by commits＠source.squeak.org 08 Apr '19

08 Apr '19

Chris Muller uploaded a new version of Installer-Core to project The Inbox: http://source.squeak.org/inbox/Installer-Core-cmm.428.mcz ==================== Summary ==================== Name: Installer-Core-cmm.428 Author: cmm Time: 8 April 2019, 12:28:03.307324 am UUID: 45c1899a-1b8e-42bf-9360-584797cf4a91 Ancestors: Installer-Core-cmm.427, Installer-Core-tcj.426 Allow installation of github projects via the scripts at the top in their readme files, without first having to manually ensure Metacello is installed. Metacello new baseline: 'NameOfTheProject'; repository: 'github://...'; load =============== Diff against Installer-Core-tcj.426 =============== Item was changed: ----- Method: Installer class>>ensureRecentMetacello (in category 'scripts') ----- ensureRecentMetacello "Copied and adapted from https://github.com/Metacello/metacello/blob/master/README.md" | metacello | ((Smalltalk classNamed: #WebClient) ifNil: [ false ] ifNotNil: [ :webClient | [ (webClient httpHead: 'https://github.com') isSuccess ] on: Error do: [ false ] ]) ifFalse: [ ^self inform: 'Could not connect to "https://github.com".\\You need an internet connection and SSL support\to install (or update) Metacello.\\Please fix those issues and try again.' translated withCRs ]. + metacello := Smalltalk classNamed: #Metacello. + (metacello name = #Metacello) ifFalse: [ - metacello := (Smalltalk classNamed: #Metacello) ifNil: [ "Get the Metacello configuration (for Squeak users)" Installer gemsource project: 'metacello'; addPackage: 'ConfigurationOfMetacello'; install. "Bootstrap Metacello Preview, using mcz files (#'previewBootstrap' symbolic version" ((Smalltalk classNamed: #ConfigurationOfMetacello) project version: #'previewBootstrap') load. Smalltalk classNamed: #Metacello ]. "Now load latest version of Metacello" metacello new baseline: 'Metacello'; repository: 'github://Metacello/metacello:master/repository'; get. metacello new baseline: 'Metacello'; repository: 'github://Metacello/metacello:master/repository'; load: #('default' 'Metacello-Help'). ! Item was added: + Object subclass: #MetacelloStub + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Installer-Core'! + + !MetacelloStub commentStamp: 'cmm 4/8/2019 00:27' prior: 0! + MetacelloStub is a loose reference to Metacello.! Item was added: + ----- Method: MetacelloStub class>>doesNotUnderstand: (in category 'overriding') ----- + doesNotUnderstand: aMessage + Installer ensureRecentMetacello. + Installer installGitInfrastructure. + ^ aMessage sendTo: (Smalltalk classNamed: #Metacello)! Item was added: + ----- Method: MetacelloStub class>>initialize (in category 'initialize-release') ----- + initialize + Smalltalk + at: #Metacello + ifAbsentPut: [ self ]!

5 5

The Trunk: Collections-nice.824.mcz
by commits＠source.squeak.org 07 Apr '19

07 Apr '19

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.824.mcz ==================== Summary ==================== Name: Collections-nice.824 Author: nice Time: 7 April 2019, 10:40:26.559826 pm UUID: e6d75dba-26a8-4945-a930-3d79f8cd4969 Ancestors: Collections-ul.823 Implement Collection>>#log2, since it already responds to #ln and #log... Correct a Pharoism in DefaultSortFunction comment, there is no #threeWayCompareTo: because we prefer the space-ship operator <=> Correct a slip in LazyCharacterSet comment. Let ({1. 3/2. 2} as: Interval) work as it should. Remove Interval>>#remove: since it duplicates unecessarily super remove:ifAbsent: (which shouldNotImplement already). Don't spend too much time sorting an Interval, it's already sorted. =============== Diff against Collections-ul.823 =============== Item was added: + ----- Method: Collection>>log2 (in category 'math functions') ----- + log2 + ^ self collect: [:each | each log2]! Item was changed: SortFunction subclass: #DefaultSortFunction instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Collections-SortFunctions'! + !DefaultSortFunction commentStamp: 'nice 4/6/2019 15:08' prior: 0! + A DefaultSortFunction is a collator using the default three way compare <=> operator. - !DefaultSortFunction commentStamp: 'nice 11/7/2017 23:43' prior: 0! - A DefaultSortFunction is a collator using the default <=> operator. It is known to work on String and Magnitude. It is generally not usefull to create a new instance, and the recommended pattern is to use the single instance available by sending the message SortFunction default . + For other objects that don't understand <=> it is necessary to use a custom SortFunction rather than the default one. - For other objects that don't understand threeWayCompareTo: it is necessary to use a custom SortFunction rather than the default one. ! Item was changed: ----- Method: Interval class>>newFrom: (in category 'instance creation') ----- newFrom: aCollection "Answer an instance of me containing the same elements as aCollection." | newInterval n | - (n := aCollection size) <= 1 ifTrue: [ n = 0 ifTrue: [^self from: 1 to: 0]. + ^self from: aCollection anyOne to: aCollection anyOne]. + newInterval := self + from: aCollection first + to: aCollection last + by: (aCollection last - aCollection first) / (n - 1). + (newInterval hasEqualElements: aCollection) + ifFalse: + [self error: 'The argument is not an arithmetic progression']. - ^self from: aCollection first to: aCollection last]. - newInterval := self from: aCollection first to: aCollection last - by: (aCollection last - aCollection first) // (n - 1). - aCollection ~= newInterval - ifTrue: [ - "Give a second chance, because progression might be arithmetic, but = answer false" - (newInterval hasEqualElements: aCollection) ifFalse: [ - self error: 'The argument is not an arithmetic progression']]. ^newInterval " Interval newFrom: {1. 2. 3} {33. 5. -23} as: Interval {33. 5. -22} as: Interval (an error) (-4 to: -12 by: -1) as: Interval #(2 4 6) asByteArray as: Interval. "! Item was removed: - ----- Method: Interval>>remove: (in category 'removing') ----- - remove: newObject - "Removing from an Interval is not allowed." - - self error: 'elements cannot be removed from an Interval'! Item was added: + ----- Method: Interval>>sorted (in category 'sorting') ----- + sorted + "an Interval is already sorted" + step < 0 ifTrue: [^self reversed]. + ^self! Item was changed: CharacterSet subclass: #LazyCharacterSet instanceVariableNames: 'block' classVariableNames: '' poolDictionaries: '' category: 'Collections-Support'! + !LazyCharacterSet commentStamp: 'nice 2/12/2019 22:36' prior: 0! - !LazyCharacterSet commentStamp: 'nice 11/30/2017 21:40' prior: 0! A LazyCharacterSet is a kind of CharacterSet which does not know in advance which Character it contains or not. If will lazily evaluate a block on demand if ever one ask whether it includes: a character. It is not feasible to enumerate a LazyCharacterSet, because there are way too many characters. Instance Variables block: <BlockContext | Symbol> byteArrayMapCache: <ByteArray | nil> block - a valuable, answering either true or false when sent the message value: - true means that this set includes the character passed as value: argument. byteArrayMapCache + - a cache holding 0 or 1 for the first 256 character codes - 0 meaning not included, 1 included. This is used in some primitives - - a cache holding 0 or 1 for the first 256 character codes - 0 meaning not included, 1 included. This is used in some priitives !

1 0

The Trunk: CollectionsTests-nice.305.mcz
by commits＠source.squeak.org 07 Apr '19

07 Apr '19

Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-nice.305.mcz ==================== Summary ==================== Name: CollectionsTests-nice.305 Author: nice Time: 7 April 2019, 10:28:19.324177 pm UUID: 62b39b3b-abb9-43d1-aa10-dbf15359c36b Ancestors: CollectionsTests-nice.304 More and Less Interval tests - Part 2 - cleanup the testEquals * remove redundant test vs Array: a single #testEqualsWithArray is enough * make an explicit testEqualsWhenEmpty for empty Interval equality. This is a feature required for Text selection support. An empty Interval is used for marking cursor position when Text selection is empty. - It should be possible to convert an Array with fractional arithmetic progression as Interval (#testAsIntervalWithFractionalProgression), though it's currently not the case at this time of writing - add a case of surprising fuzzy-inclusion behavior (copyWithout:) - document two additional weird behaviors of Interval of Float: * testIntervalOfFloatEqual denies the common sense, and thus currently does not fail. It could as well assert and be an expected failure, but we will probably not resolve it. * testIntervalOfFloatLast fails if last is not corrected. Unlike equal, it seems possible to resolve while preserving other Interval properties =============== Diff against CollectionsTests-nice.304 =============== Item was added: + ----- Method: IntervalTest>>testAsIntervalWithFractionalProgression (in category 'tests') ----- + testAsIntervalWithFractionalProgression + self assert: (1 to: 2 by: 1/2) equals: ({1. 3/2. 2} as: Interval). + self assert: (1 to: 2 by: 0.2s) equals: ({1. 1.2s. 1.4s. 1.6s. 1.8s. 2} as: Interval). + + self should: [#(0.1 0.2 0.3 0.4) as: Interval] + raise: Error + description: 'There is no guaranty that Interval of Float can be constructed from individual Float'. + "Even though, by chance there might be a Float Interval with same elements" + #(0.1 0.2 0.3 0.4) hasEqualElements: (0.1 to: 0.4 by: 0.1 predecessor)! Item was changed: ----- Method: IntervalTest>>testEquals (in category 'tests') ----- testEquals + self assert: (3 to: 5) = (3.0 to: 5.0). + self deny: (3 to: 5) = (3 to: 5 by: 2) description: 'Sharing bounds is not enough to make Interval equals'.! - self deny: (3 to: 5) = #(3 4 5). - self deny: (3 to: 5) = #(3 5). - self deny: (3 to: 5) = #(). - - self deny: #(3 4 5) = (3 to: 5). - self deny: #(3 5) = (3 to: 5). - self deny: #() = (3 to: 5).! Item was removed: - ----- Method: IntervalTest>>testEquals4 (in category 'tests') ----- - testEquals4 - - self deny: (3 to: 5 by: 2) = #(3 5). - self deny: (3 to: 5 by: 2) = #(3 4 5). - self deny: (3 to: 5 by: 2) = #(). - - self deny: #(3 5) = (3 to: 5 by: 2). - self deny: #(3 4 5) = (3 to: 5 by: 2). - self deny: #() = (3 to: 5 by: 2).! Item was added: + ----- Method: IntervalTest>>testEqualsWhenEmpty (in category 'tests') ----- + testEqualsWhenEmpty + self assert: (3 to: 2) = (3 to: 2) copy. + self deny: (3 to: 2) = (2 to: 1) + description: 'Empty intervals are considered different if their bound differs. Text selection rely on this feature'.! Item was added: + ----- Method: IntervalTest>>testEqualsWithArray (in category 'tests') ----- + testEqualsWithArray + "Intervals are not considered equal to Array, even if they share the same sequence of elements." + self deny: (3 to: 5) = #(3 4 5). + self deny: #(3 4 5) = (3 to: 5).! Item was added: + ----- Method: IntervalTest>>testIntervalOfFloatEqual (in category 'tests') ----- + testIntervalOfFloatEqual + "Interval with Float are weirdos" + + | interval1 interval2 interval3 interval4 | + interval1 := (0 to: 1 by: 1/10). + interval2 := (0.0 to: 1 by: 1/10). + self deny: (interval1 = interval2) ==> (interval1 hasEqualElements: interval2) + description: 'Interval of Float may have different elements from another Interval, even if they pretend to be equal.'. + + interval3 := (0.3 to: 0.6 by: 1/10). + interval4 := (0.3 to: 0.6 by: 0.1). + self deny: (interval3 hasEqualElements: interval4) ==> (interval3 = interval4) + description: 'Interval of Float may pretend they differ from another Interval even if they have same elements.'.! Item was added: + ----- Method: IntervalTest>>testIntervalOfFloatLast (in category 'tests') ----- + testIntervalOfFloatLast + "Some definition of last were problematic for Interval of Float" + + | increment upperBound interval | + self assert: (0.2 to: 0.9 by: 0.1) last = (0.2 to: 0.9 by: 0.1) asArray last + description: 'the last element cannot reasonably change when converting asArray'. + + upperBound := 1.7. + increment := 0.1. + self deny: (0 to: upperBound by: increment) last > upperBound + description: 'the last element cannot reasonably exceed upper bound'. + + interval := -0.9999999999999994 to: 1 by: 2. + self assert: interval last < interval first + ==> (interval isEmpty or: [interval increment < 0]) + description: 'the last element cannot reasonably deceed(*) lower bound (* be inferior to)'! Item was changed: ----- Method: IntervalTest>>testSurprisingFuzzyInclusionBehavior (in category 'tests') ----- testSurprisingFuzzyInclusionBehavior "If ever Interval implement fuzzy inclusion, then we can expect weird logic..." + self assert: ((0.1 to: 0.9 by: 0.1) includes: 0.3) - self assert: ((0.1 to: 0.9 by: 0.1) asArray includes: 0.3) ==> (((0.1 to: 0.9 by: 0.1) occurrencesOf: 0.3) > 0) description: 'A Collection that includes something has at least one occurrence of something'. self assert: ((0.1 to: 0.9 by: 0.1) lastIndexOf: 0.3) >= ((0.1 to: 0.9 by: 0.1) indexOf: 0.3) + description: 'The last index of an object in a SequenceableCollection should be greater than or equal to the first index'. + self assert: ((0.1 to: 0.9 by: 0.1) includes: 0.3) + ==> (((0.1 to: 0.9 by: 0.1) copyWithout: 0.3) size < (0.1 to: 0.9 by: 0.1) size) + description: 'A Collection should be able to shrink by stripping own elements'.! - description: 'If the last index of an object in a SequenceableCollection should be greater or equal to the first index'.!

1 0