Squeak-dev May 2018

squeak-dev@lists.squeakfoundation.org

44 participants
189 discussions

The Trunk: SUnit-ul.112.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

Levente Uzonyi uploaded a new version of SUnit to project The Trunk: http://source.squeak.org/trunk/SUnit-ul.112.mcz ==================== Summary ==================== Name: SUnit-ul.112 Author: ul Time: 28 May 2018, 9:56:22.231424 pm UUID: 8ece3c29-1858-4d1b-9869-12f882db4a3b Ancestors: SUnit-tpr.111 ClassFactoryForTestCase generates class names ending with random character sequences to significantly decrease the chance of name collisions among the generated classes. See this thread for further explanation: http://lists.squeakfoundation.org/pipermail/squeak-dev/2018-May/198941.html =============== Diff against SUnit-tpr.111 =============== Item was changed: ----- Method: ClassFactoryForTestCase>>newName (in category 'creating') ----- newName + + ^String new: 23 + 22 streamContents: [ :stream | + | random | + stream nextPutAll: 'ClassForTestToBeDeleted'. + random := ThreadSafeRandom value. + "62 possible values, 5.95 bits / iteration, 22 iterations => more than 128 bits" + 22 timesRepeat: [ + stream nextPut: ('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789' atRandom: random) ] ]! - | postFix | - postFix := (self createdClasses size + 1) printString. - ^#ClassForTestToBeDeleted, postFix!

1 0

The Trunk: ToolBuilder-Morphic-tpr.219.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

tim Rowledge uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-tpr.219.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-tpr.219 Author: tpr Time: 28 May 2018, 10:51:16.292529 am UUID: e9c527a5-216d-4d62-8020-0592a535118a Ancestors: ToolBuilder-Morphic-mt.218 Correct class comment for DirectoryChooserDialog. Add method to provide Project load/save directory choosing. =============== Diff against ToolBuilder-Morphic-mt.218 =============== Item was changed: FileAbstractSelectionDialog subclass: #DirectoryChooserDialog instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'ToolBuilder-Morphic-Tools'! + !DirectoryChooserDialog commentStamp: 'tpr 4/2/2018 09:52' prior: 0! + A DirectoryChooserDialog is a modal dialog to allow choosing a directory. The actual directory chosen is returned, or nil if no selection was made. - !DirectoryChooserDialog commentStamp: 'tpr 12/21/2017 11:32' prior: 0! - A DirectoryChooserDialog is a modal dialog to allow choosing a directory. The full directory name is returned, or nil if no selection was made. Normal usage would be + myDirectory := DirectoryChooserDialog openOn: myApplicationDefaultDirectory label: 'Choose the directory to use' - myDirname := DirectoryChooserDialog openOn: myApplicationDefaultDirectory label: 'Choose the directory to use' ! Item was added: + ----- Method: DirectoryChooserDialog class>>findAFolderForProject:label: (in category 'instance creation') ----- + findAFolderForProject: aProject label: labelString + "Select a directory for either saving or loading a project file" + "Temporary simple version without the 'interesting' blue ui stuff + See FileList2 class>>#modalFolderSelectorForProject: for the full horror" + ^self openOn: FileDirectory default label: labelString!

1 0

Re: [squeak-dev] Don't rely on weak reference cleanup for lookup of undeclared references
by Max Leske 28 May '18

28 May '18

Hi Levente, On 28 May 2018 at 13:06:46, squeak-dev-request(a)lists.squeakfoundation.org ( squeak-dev-request(a)lists.squeakfoundation.org) wrote: > Hi, > Once again, there's a situation in the Fuel test suite that uncovered an issue. Consider the following script: > > Object subclass: #Foo > instanceVariableNames: '' > classVariableNames: '' > poolDictionaries: '' > category: 'Kernel-Classes'. > 10 timesRepeat: [(Smalltalk at: #Foo) rename: #Bar. > (Smalltalk at: #Bar) rename: #Foo ] > > In 5.2-alpha this will open a warning dialog, as at some point one of the class names will be undeclared. Class>>rename: only checks for an entry in the undeclared dictionary without considering that the weak > references may not yet have been cleaned up. > > I understand that this is not really a realistic real world use-case but it's still annoying for tests. My current workaround is a forced GC after *every* test in the entire suite (I use > ClassFactoryForTestCase, so class names may be reused many times over). Luckily, the impact on runtime isn't too bad. Did you consider extending ClassFactoryForTestCase with an optional infix name part for the generated names? For example: initialize super initialize. infix := ''. self createdClasses: IdentitySet new infix: aString infix := aString newName ^'ClassForTestToBeDeleted{1}{2}' format: { infix. self createdClasses size + 1 } The you could specify a random infix, like UUID new asString36 to avoid collisions. Levente Yes, I did consider that. However, in my opinion it should not be the users concern. Using ClassFactoryForTestCase should in itself be sufficient to guarantee the independence of tests. I knew what I was looking for, but for someone with less experience this would just be a very annoying Heisenbug. Cheers, Max > > I'd appreciate it if this could be fixed. I'd be even more happy if I could be notified of the fix, so that I can remove the workaround again. > > > Cheers, > Max > >

1 0

[RELEASE] updating to 18026 report
by Edgar J. De Cleene 28 May '18

28 May '18

The crash of today foto http://squeakros.org/5dot2Crashes/Screen%20Shot%202018-05-28%20at%2006.17.10 .png Edgar @morplenauta

3 2

The Trunk: System-mt.1031.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1031.mcz ==================== Summary ==================== Name: System-mt.1031 Author: mt Time: 28 May 2018, 10:51:12.13037 am UUID: 3c6fdb2a-dba4-d140-8797-7ba73b412ba1 Ancestors: System-mt.1030 Removes hard-coded 'UserObjects' category via method call. =============== Diff against System-mt.1030 =============== Item was changed: ----- Method: SmalltalkImage>>shrink (in category 'shrinking') ----- shrink "Clean up everything we know how to clean up that can be restored." "Prepare unloading" self zapMVCprojects. Flaps disableGlobalFlaps: false. self unloadReloadablePackages. "Post-unload aggressive cleanup" Smalltalk cleanUp: true. + SystemOrganization removeSystemCategory: Object categoryForUniclasses. - SystemOrganization removeSystemCategory: 'UserObjects'. Smalltalk at: #ScheduledControllers ifPresent: [Smalltalk at: #ScheduledControllers put: nil]. Smalltalk garbageCollect!

1 0

[BUG] Browser removeClass PlayerXX
by karl ramberg 28 May '18

28 May '18

Hi, I ran across this bug trying to clean up spurious loaded Player classes. Removing a class in UserObjects in the Browser using menu option 'remove class(X)'. PlayerXX classes are replaced by AnObsoletePlayerXX instead in the list. If you click on the AnObsoletePlayerXX you get a DNU from the browser. Best, Karl

2 2

The Trunk: EToys-mt.331.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.331.mcz ==================== Summary ==================== Name: EToys-mt.331 Author: mt Time: 28 May 2018, 10:49:36.21837 am UUID: ed4a189e-f34e-4e4b-ad4e-e3b1bb678628 Ancestors: EToys-kfr.330 Appendix to Kernel-mt.1172 (uniclasses) =============== Diff against EToys-kfr.330 =============== Item was changed: ----- Method: Player class>>environment (in category 'organization') ----- environment + "If there are uniclasses of Player that do not have their custom environment set, create a new one on the fly. Can be removed in the future. See Class >> #newSubclass or the flag #uniclasses." + + ^ (self isUniClass and: [super environment == Environment default]) + ifTrue: [self newEnvironment] - - ^ self isUniClass - ifTrue: [(Environment withName: 'EtoysUserDefinedTempEnvironment') - at: self name asSymbol put: self; - importSelf; - yourself] ifFalse: [super environment]! Item was changed: ----- Method: ReleaseBuilderSqueakland class>>clearCaches (in category 'scripts') ----- clearCaches ObjectScanner new. "clear ObjectScanner's class pool" ExternalSettings registerClient: ServerDirectory. + #('Morphic-UserObjects' 'EToy-UserObjects' 'Morphic-Imported'), {Object categoryForUniclasses} - #('Morphic-UserObjects' 'EToy-UserObjects' 'Morphic-Imported' 'UserObjects') do: [:each | SystemOrganization removeSystemCategory: each]. super clearCaches.!

1 0

The Trunk: KernelTests-mt.340.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

Marcel Taeumel uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-mt.340.mcz ==================== Summary ==================== Name: KernelTests-mt.340 Author: mt Time: 28 May 2018, 10:48:39.54437 am UUID: f7b17ce4-7d8b-4a4d-9da9-da8b9046d970 Ancestors: KernelTests-eem.339 New test for uniclass creation. Appendix to Kernel-mt.1172 =============== Diff against KernelTests-eem.339 =============== Item was added: + ----- Method: ClassBuilderTest>>testNewUniclass (in category 'testing - uniclass') ----- + testNewUniclass + + baseClass := Object subclass: self baseClassName + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: self categoryNameForTemporaryClasses. + "Note that you have to denote a new base class to be capable of spawning uni classes. See Object class >> #isUniClass for more information." + baseClass class + compile: ('isUniClass\ ^ self ~~ {1}' withCRs format: {self baseClassName}) + classified: 'instance creation'. + + subClass := baseClass newSubclass. + + self + assert: subClass isUniClass; + assert: subClass environment ~~ baseClass environment; + assert: subClass category = Object categoryForUniclasses; + assert: (baseClass organization categoryOfElement: subClass name) isNil. + + self deny: subClass isObsolete. + subClass removeFromSystem. + self assert: subClass isObsolete.!

1 0

The Trunk: Kernel-mt.1172.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1172.mcz ==================== Summary ==================== Name: Kernel-mt.1172 Author: mt Time: 28 May 2018, 10:47:42.97237 am UUID: 814981fd-be88-c846-a898-9cef659baa2b Ancestors: Kernel-mt.1171 Fixes the bug where uniclasses appeared in the default environment and browser and organization. =============== Diff against Kernel-mt.1171 =============== Item was added: + ----- Method: Class>>newEnvironment (in category 'subclass creation') ----- + newEnvironment + + self flag: #uniclasses. + ^ (Environment withName: 'EnvironmentForUniClass') + at: self name asSymbol put: self; + importSelf; + yourself! Item was changed: ----- Method: Class>>newSubclass (in category 'subclass creation') ----- newSubclass + self flag: #uniclasses. ^ self newUniqueClassInstVars: '' classInstVars: '' "Point newSubclass new"! Item was changed: ----- Method: Object class>>newUniqueClassInstVars:classInstVars: (in category 'instance creation') ----- newUniqueClassInstVars: instVarString classInstVars: classInstVarString "Create a unique class for the receiver" | aName aClass | self isSystemDefined ifFalse: [^ superclass newUniqueClassInstVars: instVarString classInstVars: classInstVarString]. aName := self chooseUniqueClassName. aClass := self subclass: aName instanceVariableNames: instVarString classVariableNames: '' poolDictionaries: '' category: self categoryForUniclasses. classInstVarString size > 0 ifTrue: [aClass class instanceVariableNames: classInstVarString]. + self flag: #todo. self flag: #uniclasses. "Discuss if we really want to hide uniclasses again" + aClass environment: aClass newEnvironment. + aClass environment organization + classify: aClass name + under: (self environment organization categoryOfElement: aClass name). + self environment forgetClass: aClass logged: false. - aClass environment forgetClass: aClass logged: false. self removeSubclass: aClass. + ^ aClass!

1 0

The Trunk: ReleaseBuilder-mt.186.mcz
by commits＠source.squeak.org 28 May '18

28 May '18

Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-mt.186.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.186 Author: mt Time: 28 May 2018, 8:41:06.53437 am UUID: 96b49797-c0c1-bd41-adb7-eb3beb3a55b6 Ancestors: ReleaseBuilder-mt.185 Be more precise and only clean-up uni-class-hickups in environments. =============== Diff against ReleaseBuilder-mt.185 =============== Item was changed: ----- Method: ReleaseBuilder class>>discardUserObjects (in category 'scripts - support') ----- discardUserObjects "Remove the classes." Player removeUninstantiatedSubclassesSilently. MorphicModel removeUninstantiatedSubclassesSilently. "Clean-up environment hick-ups." Environment default allClassesDo: [:cls | + (cls isUniClass and: [cls environment ~~ Environment default]) - cls environment ~~ Environment default ifTrue: [Environment default forgetClass: cls logged: false]]. Environment default declarations + select: [:binding | (binding value isBehavior and: [binding value isUniClass]) and: [binding value isObsolete]] + thenDo: [:binding | + SystemOrganization removeElement: binding key. + Environment default removeKey: binding key]. - select: [:ea | (ea value isBehavior and: [ea value isUniClass]) and: [ea value isObsolete]] - thenDo: [:ea | - SystemOrganization removeElement: ea key. - Environment default removeKey: ea key]. "Remove empty categories for user objects." SystemOrganizer cleanUp: true.!

1 0

← Newer
1
2
3
4
5
6
7
8
...
19
Older →

Jump to page: