Squeak-dev February 2018

squeak-dev@lists.squeakfoundation.org

51 participants
149 discussions

The Inbox: Morphic-dtl.1360.mcz
by commits＠source.squeak.org 08 May '18

08 May '18

David T. Lewis uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-dtl.1360.mcz ==================== Summary ==================== Name: Morphic-dtl.1360 Author: dtl Time: 11 November 2017, 4:04:34.153784 pm UUID: 0e1f3870-5f57-4dc6-a1e7-5d8ce68b71b5 Ancestors: Morphic-dtl.1359 World global elimination. Once the current project has been entered, Project current world == World. Begin eliminating references to the global variable World in cases where it is not required. =============== Diff against Morphic-dtl.1359 =============== Item was changed: ----- Method: ComplexProgressIndicator>>backgroundWorldDisplay (in category 'as yet unclassified') ----- backgroundWorldDisplay self flag: #bob. "really need a better way to do this" "World displayWorldSafely." "ugliness to try to track down a possible error" + [Project current world displayWorld] ifError: [ :a :b | - [World displayWorld] ifError: [ :a :b | | f | stageCompleted := 999. f := FileDirectory default fileNamed: 'bob.errors'. f nextPutAll: a printString,' ',b printString; cr; cr. f nextPutAll: 'worlds equal ',(formerWorld == World) printString; cr; cr. f nextPutAll: thisContext longStack; cr; cr. f nextPutAll: formerProcess suspendedContext longStack; cr; cr. f close. Beeper beep. ]. ! Item was changed: ----- Method: Debugger class>>morphicOpenInterrupt:onProcess: (in category '*Morphic-opening') ----- morphicOpenInterrupt: aString onProcess: interruptedProcess "Open a notifier in response to an interrupt. An interrupt occurs when the user types the interrupt key (cmd-. on Macs, ctrl-c or alt-. on other systems) or when the low-space watcher detects that memory is low." | debugger | <primitive: 19> "Simulation guard" debugger := self new. debugger process: interruptedProcess controller: nil context: interruptedProcess suspendedContext. debugger externalInterrupt: true. Preferences logDebuggerStackToFile ifTrue: [(aString includesSubstring: 'Space') & (aString includesSubstring: 'low') ifTrue: [Smalltalk logError: aString inContext: debugger interruptedContext to: 'LowSpaceDebug.log'] "logging disabled for 4.3 release, see http://lists.squeak.org/pipermail/squeak-dev/2011-December/162503.html" "ifFalse: [Smalltalk logSqueakError: aString inContext: debugger interruptedContext]"]. + Preferences eToyFriendly ifTrue: [Project current world stopRunningAll]. - Preferences eToyFriendly ifTrue: [World stopRunningAll]. ^debugger openNotifierContents: nil label: aString; yourself ! Item was changed: ----- Method: Morph>>updateFromResource (in category 'fileIn/out') ----- updateFromResource | pathName newMorph f | (pathName := self valueOfProperty: #resourceFilePath) ifNil: [^self]. (pathName asLowercase endsWith: '.morph') ifTrue: [newMorph := (FileStream readOnlyFileNamed: pathName) fileInObjectAndCode. (newMorph isMorph) ifFalse: [^self error: 'Resource not a single morph']] ifFalse: [f := Form fromFileNamed: pathName. f ifNil: [^self error: 'unrecognized image file format']. + newMorph := Project current world drawingClass withForm: f]. - newMorph := World drawingClass withForm: f]. newMorph setProperty: #resourceFilePath toValue: pathName. self owner replaceSubmorph: self by: newMorph! Item was changed: ----- Method: MorphHierarchyListMorph>>createContainer (in category 'private') ----- createContainer "Private - Create a container" | container | container := BorderedMorph new. + container extent: (Project current world extent * (1 / 4 @ (2 / 3))) rounded. - container extent: (World extent * (1 / 4 @ (2 / 3))) rounded. container layoutPolicy: TableLayout new. container hResizing: #rigid. container vResizing: #rigid. container setColor: (Color gray: 0.9) borderWidth: 1 borderColor: Color gray. container layoutInset: 0. "container useRoundedCorners." "" container setProperty: #morphHierarchy toValue: true. container setNameTo: 'Objects Hierarchy' translated. "" ^ container! Item was changed: ----- Method: MorphicProject>>storeSegment (in category 'file in/out') ----- storeSegment "Store my project out on the disk as an ImageSegment. Keep the outPointers in memory. Name it <project name>.seg. *** Caller must be holding (Project alInstances) to keep subprojects from going out. ***" | is sizeHint | + (Project current world == world) ifTrue: [^ false]. - (World == world) ifTrue: [^ false]. "self inform: 'Can''t send the current world out'." world isInMemory ifFalse: [^ false]. "already done" world ifNil: [^ false]. world presenter ifNil: [^ false]. ScrapBook default emptyScrapBook. World checkCurrentHandForObjectToPaste. world releaseSqueakPages. sizeHint := self projectParameters at: #segmentSize ifAbsent: [0]. is := ImageSegment copyFromRootsLocalFileFor: {world presenter. world} "world, and all Players" sizeHint: sizeHint. is state = #tooBig ifTrue: [^ false]. is segment size < 2000 ifTrue: ["debugging" Transcript show: self name, ' only ', is segment size printString, 'bytes in Segment.'; cr]. self projectParameters at: #segmentSize put: is segment size. is extract; writeToFile: self name. ^ true! Item was changed: ----- Method: MorphicProject>>storeSegmentNoFile (in category 'file in/out') ----- storeSegmentNoFile "For testing. Make an ImageSegment. Keep the outPointers in memory. Also useful if you want to enumerate the objects in the segment afterwards (allObjectsDo:)" | is | + (Project current world == world) ifTrue: [^ self]. " inform: 'Can''t send the current world out'." - (World == world) ifTrue: [^ self]. " inform: 'Can''t send the current world out'." world isInMemory ifFalse: [^ self]. "already done" world ifNil: [^ self]. world presenter ifNil: [^ self]. "Do this on project enter" World flapTabs do: [:ft | ft referent adaptToWorld: World]. "Hack to keep the Menu flap from pointing at my project" "Preferences setPreference: #useGlobalFlaps toValue: false." "Utilities globalFlapTabsIfAny do: [:aFlapTab | Utilities removeFlapTab: aFlapTab keepInList: false]. Utilities clobberFlapTabList. " "project world deleteAllFlapArtifacts." "self currentWorld deleteAllFlapArtifacts. " ScrapBook default emptyScrapBook. World checkCurrentHandForObjectToPaste2. is := ImageSegment copyFromRootsLocalFileFor: {world presenter. world} "world, and all Players" sizeHint: 0. is segment size < 800 ifTrue: ["debugging" Transcript show: self name, ' did not get enough objects'; cr. ^ Beeper beep]. is extract. "is instVarAt: 2 put: is segment clone." "different memory"! Item was changed: ----- Method: TheWorldMainDockingBar>>startMessageTally (in category 'menu actions') ----- startMessageTally + | world | + world := Project current world. (self confirm: 'MessageTally will start now, and stop when the cursor goes to the top of the screen') ifTrue: [MessageTally spyOn: + [[Sensor peekPosition y > 0] whileTrue: [world doOneCycle]]]! - [[Sensor peekPosition y > 0] whileTrue: [World doOneCycle]]]! Item was changed: ----- Method: TheWorldMenu>>startMessageTally (in category 'commands') ----- startMessageTally + | world | + world := Project current world. - (self confirm: 'MessageTally will start now, and stop when the cursor goes to the top of the screen') ifTrue: [MessageTally spyOn: + [[Sensor peekPosition y > 0] whileTrue: [world doOneCycle]]]! - [[Sensor peekPosition y > 0] whileTrue: [World doOneCycle]]]!

11 38

ByteArray>>at:put:
by Bert Freudenberg 30 Apr '18

30 Apr '18

#[195 164] collect: [:c | c hex] => #[16 16] I think this should have raised an error. Tim? - Bert -

7 13

The Trunk: Files-tpr.177.mcz
by commits＠source.squeak.org 12 Apr '18

12 Apr '18

tim Rowledge uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-tpr.177.mcz ==================== Summary ==================== Name: Files-tpr.177 Author: tpr Time: 8 January 2018, 2:42:23.914232 pm UUID: c7c9aa30-635c-40a5-abff-1001a16e85ea Ancestors: Files-tpr.176 Remove a spurious use of #checkName:fixErrors: that wilfully mangled filenames - it wasn't even the right thing to do since the #newFileNamed: carefully uses it within each path segment. The writeSourceCode... method is still insane even after this. It looks like it is something left over from the partial i18n era. See also crazy things like #multiCs. See also the apparent complete nonsense of the supposed html flag; I can't find any places where actual html is generated and the only effect seems to be the file extension used ? =============== Diff against Files-tpr.176 =============== Item was changed: ----- Method: FileDirectory>>writeSourceCodeFrom:baseName:isSt:useHtml: (in category 'utilities') ----- writeSourceCodeFrom: aStream baseName: baseName isSt: stOrCsFlag useHtml: useHtml "Write the source code from aStream into a file." | extension converter f fileName | aStream contents isAsciiString ifTrue: [ stOrCsFlag ifTrue: [ extension := (FileDirectory dot, FileStream st). ] ifFalse: [ extension := (FileDirectory dot, FileStream cs). ]. converter := MacRomanTextConverter new. ] ifFalse: [ stOrCsFlag ifTrue: [ extension := (FileDirectory dot, FileStream st "multiSt"). ] ifFalse: [ extension := (FileDirectory dot, FileStream cs "multiCs"). ]. converter := UTF8TextConverter new. ]. fileName := useHtml ifTrue: [baseName, '.html'] ifFalse: [baseName, extension]. - fileName := self checkName: fileName fixErrors: true. f := self newFileNamed: fileName. f ifNil: [^ self error: 'Cannot open file']. (converter isMemberOf: UTF8TextConverter) ifTrue: [f binary. UTF8TextConverter writeBOMOn: f]. f text. f converter: converter. f nextPutAll: aStream contents. f close. !

4 3

WebClient httpGet: 'http://freegeoip.net/json/' works on windows not linux
by Chris Cunnington 28 Mar '18

28 Mar '18

You don’t have openssl installed. ldd told you that. libcrypto.so.1.0.0 => not found libssl.so.1.0.0 => not found You are using a 32-bit vm. Clearly you don’t have the related 32-bit libcrypto installed. chris@chris-Meerkat:~$ dpkg -l | grep libssl ii libssl1.0.0:amd64 1.0.2g-1ubuntu4.10 amd64 Secure Sockets Layer toolkit - shared libraries ii libssl1.0.0:i386 1.0.2g-1ubuntu4.10 i386 Secure Sockets Layer toolkit - shared libraries Maybe you need to do this[1]: sudo dpkg --add-architecture i386; sudo apt-get update; sudo apt-get install libssl1.0.0:i386 As an aside, it’d be cool if SqueakSSL plugin had primitives to access libcrypto. As is, I think, that library is only used in relation to sockets. Chris [1] https://askubuntu.com/questions/252168/can-i-install-libssl-devi386-on-x86-…

6 26

The Inbox: Kernel-fn.1151.mcz
by commits＠source.squeak.org 22 Mar '18

22 Mar '18

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-fn.1151.mcz ==================== Summary ==================== Name: Kernel-fn.1151 Author: fn Time: 9 February 2018, 12:32:25.516883 pm UUID: 9fb7df4b-6bf4-4af8-9c75-7496c2f0b517 Ancestors: Kernel-tonyg.1150 For consistency: allow blocks to be passed into #xor: (see #or: and #and:). =============== Diff against Kernel-tonyg.1150 =============== Item was changed: ----- Method: False>>xor: (in category 'logical operations') ----- + xor: alternativeBlock - xor: aBoolean "Posted by Eliot Miranda to squeak-dev on 3/24/2009" + ^alternativeBlock value! - ^aBoolean! Item was changed: ----- Method: True>>xor: (in category 'logical operations') ----- + xor: alternativeBlock - xor: aBoolean "Posted by Eliot Miranda to squeak-dev on 3/24/2009" + ^alternativeBlock value not! - ^aBoolean not!

11 25

Re: [squeak-dev] The Inbox: Collections-ul.564.mcz
by Chris Muller 12 Mar '18

12 Mar '18

I guess there's infinite recursion in Array's printing method too... An Array containing itself? Obviously that's a rare structure the system has never dealt with. Do you think there'll be any other traversing methods that might be affected? On Mon, Feb 3, 2014 at 7:48 AM, <commits(a)source.squeak.org> wrote: > A new version of Collections was added to project The Inbox: > http://source.squeak.org/inbox/Collections-ul.564.mcz > > ==================== Summary ==================== > > Name: Collections-ul.564 > Author: ul > Time: 3 February 2014, 2:35:36.802 pm > UUID: 4b9a37ef-df86-40a0-a0dd-8e8b2c04d4ed > Ancestors: Collections-ul.563 > > Make sure that Array >> #isLiteral won't get into an infinite recursion, even if the receiver has an recursive structure. > > =============== Diff against Collections-ul.563 =============== > > Item was changed: > ----- Method: Array>>isLiteral (in category 'testing') ----- > isLiteral > + > + ^self class == Array and: [ > + self isLiteralIfContainedBy: IdentitySet new ]! > - ^self class == Array and: [self allSatisfy: [:each | each isLiteral]]! > > Item was added: > + ----- Method: Array>>isLiteralIfContainedBy: (in category 'testing') ----- > + isLiteralIfContainedBy: parents > + " Answer whether the receiver has a literal text form recognized by the compiler. Precondition: the receiver is an instance of Array. " > + > + (parents includes: self) ifTrue: [ ^false ]. > + parents add: self. > + 1 to: self size do: [ :index | > + | element | > + element := self at: index. > + (element class == Array > + ifTrue: [ element isLiteralIfContainedBy: parents ] > + ifFalse: [ element isLiteral ]) ifFalse: [ ^false ] ]. > + parents remove: self. > + ^true! > >

4 4

[ANN] Open Croquet for Squeak 6.x (experimental)
by Nikolay Suslov 04 Mar '18

04 Mar '18

Hello, Anticipating the new Squeak release! and in the spirit of the "Survey: what do you do with Squeak, what do you *want* to do?" want to share the work on restoring the original Open Croquet onto Squeak 6.x (experimental). For a long time, the community available Open Croquet images exist only in bootstrap images for Squeak 3.8 and for Squeak 4.2. Actually, there is no any open solution to use the latest Squeak VM and Smalltalk language with Open Croquet architecture. So, that starting from the original version to OpenQwaq, anyone could load it from scratch onto the new Squeak. Below you could find install instructions, links and first steps in achiving this. Demo-video: https://vimeo.com/257578323 Comparing to the original Open Croquet for Squeak 3.8/4.2: * No Embedded Morphic apps (bugs) * No Tweak (yet) * Original TContactPoint (find master on network) broadcaster/listener is replaced with WebSocket broadcaster/listener using WebClient (switching from UDP) * Island snapshot/serializing/restoring needs deep review ========================= Instructions and Links: Preloaded Squeak image: - Squeak VM and image with preloaded Croquet and content: https://www.krestianstvo.org/sdk/croquet/CroquetForSqueak6-App-MacWin-32bit… - Only Squeak image with preloaded Croquet and content: https://www.krestianstvo.org/sdk/croquet/CroquetForSqueak6-Image-resources.… - Only content (Textures, Models, etc.): https://www.krestianstvo.org/sdk/croquet/Content.zip How To install manually: 1. Get the latest Squeak VM with included B3DAcceleratorPlugin(!) The preloaded app uses VM cog.spur 32 bit for Mac/Windows: https://bintray.com/opensmalltalk/vm/download_file?file_path=squeak.cog.spu… https://bintray.com/opensmalltalk/vm/download_file?file_path=squeak.cog.spu… 2. Get the latest Squeak 6.x image from http://files.squeak.org/6.0alpha/ The preloaded app uses http://files.squeak.org/6.0alpha/Squeak6.0alpha-17606-32bit/ 3. Run Squeak. 4. In Workspace DoIt: (Installer fromUrl: ' http://sdk.krestianstvo.org/sdk/croquet/croquet-sn.2.mcm') install This will load FFI, OpenGL and Croquet packages from the project's repository "Open Croquet for Squeak 6.x". MCHttpRepository location: 'http://sdk.krestianstvo.org/sdk/croquet' user: '' password: '' Or you could manually load FFI at first: (Installer repository: 'http://source.squeak.org/FFI') install: 'FFI-Pools'; install: 'FFI-Kernel'; install: 'FFI-Tests'. and then only OpenGL and Croquet packages: (Installer fromUrl: ' http://sdk.krestianstvo.org/sdk/croquet/croquet-sn.1.mcm') install 5. Open 'Objects' in Squeak and choose 'Croquet' category. Drag Croquet(Master) or Demo(Master) onto the empty space. ========================= Best regards, Nikolai [image: Inline image 3]

5 5

Updated instructions for trunk updating configurations
by Chris Cunningham 04 Mar '18

04 Mar '18

Based on feedback from last round of asking for feedback (and a few spelling fixes, too). I have removed discussion about the method movement, since it *should* just work; and I've put pointers in for new topic on renaming classes. Plus, we'll need to document what is happening in Congifurations and Monticello, maybe, to make it more reasonable to use these. ----- When and How to change the trunk update configuration: * First, only create a configuration when it is necessary. Extra configurations slow down the update process. BUT, missing a config that should be there BREAKS the update process. Ask when not sure * When you are adding a new package to trunk, update the configuration with the new package (just because a package is in the repository does not mean it is loaded) * When you are removing a package from trunk, update the configuration to remove the package (and follow instructions for removing the package) * When you need to ensure a preamble or postscript script is run for a package, include the version in a new configuration (otherwise it could be skipped - trunk only loads the latest version of a package if specific versions are not called out in the update configuration) * When you are renaming a class (follow the instructions for class renaming in trunk) * If you need to do very intricate, step by step surgery on the internals of Squeak itself, such as converting how contexts work, you should use a series of update configurations to ensure step by step applications of the packages so the trunk update is successful * When you are unsure - ask. If no response in a reasonable time (day(s), or sooner if it is to patch a broken trunk process, to wait for a response), then go ahead a build a config. To update the configuration: 1. Update from trunk to the latest 2. Open the trunk package 3. Select the 'update' package, find the last update commit, and "Browse" it (with the button) 4. In the MCConfigurationBrowser, press the "Update" button and choose "update all from image" 5. If you need to add a new package, press the "Add" button and chose the package to add (it needs to be in your image with the right version to add it) 6. If you need to remove a package, select the package and press "Remove" 7. If you packages are updating that have dependencies between each other (say, adding an abstract class to one package, and a subclass of that abstract class in another package), then you will need to make sure those packages are in the right order. In this case, find the package with the subclass, and make sure it is after the abstract classes package. Do this by selecting one package and pressing the "Up" and "Down" keys until the packages are in the right order 8. Finally, save the package back to Trunk, and test out the update stream to ensure it works. ----- Thanks, cbc

4 5

The Trunk: Kernel-eem.1154.mcz
by commits＠source.squeak.org 03 Mar '18

03 Mar '18

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1154.mcz ==================== Summary ==================== Name: Kernel-eem.1154 Author: eem Time: 27 February 2018, 10:50:39.300209 am UUID: f403de94-416e-4740-a83c-7b74e1d00810 Ancestors: Kernel-ul.1153 Fix CompiledCode>>allLiterals for the FullBlockClosure regime. Have CompiledBlock implement allSubLiterals for literals within a block and blocks nested within it. Have CompiledMethod>>hasLiteralSuchThat: recurse through compiled blocks to match its descent into arrays and method properties. Provide CompiledMethod>>scanForInstructionPattern: as a convenient wrapper for scanForInstructionSequence: =============== Diff against Kernel-ul.1153 =============== Item was added: + ----- Method: CompiledBlock>>allLiterals (in category 'literals') ----- + allLiterals + ^self homeMethod allLiterals! Item was added: + ----- Method: CompiledBlock>>allSubLiterals (in category 'literals') ----- + allSubLiterals + | literalsExceptOuter unfoldedSubLiterals | + literalsExceptOuter := self literals allButLast. + unfoldedSubLiterals := literalsExceptOuter + select: [:lit| lit isCompiledCode] + thenCollect: [:blockMethod| blockMethod allSubLiterals]. + unfoldedSubLiterals ifEmpty: + [^literalsExceptOuter]. + ^literalsExceptOuter, (unfoldedSubLiterals fold: [:a :b| a, b])! Item was added: + ----- Method: CompiledBlock>>hasLiteralSuchThat: (in category 'literals') ----- + hasLiteralSuchThat: litBlock + "Answer true if litBlock returns true for any literal in this method, even if embedded in array structure." + 2 to: self numLiterals do: + [:index | | lit | + lit := self objectAt: index. + ((litBlock value: lit) + or: [(lit isArray or: [lit isCompiledBlock]) and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: + [^true]]. + ^false! Item was added: + ----- Method: CompiledCode>>allLiterals (in category 'literals') ----- + allLiterals + self subclassResponsibility! Item was added: + ----- Method: CompiledCode>>literals (in category 'literals') ----- + literals + "Answer an Array of the literals referenced by the receiver." + | literals numberLiterals | + literals := Array new: (numberLiterals := self numLiterals). + 1 to: numberLiterals do: + [:index | + literals at: index put: (self objectAt: index + 1)]. + ^literals! Item was changed: ----- Method: CompiledMethod>>allLiterals (in category 'literals') ----- allLiterals + | literals unfoldedSubLiterals | + literals := self literals. + unfoldedSubLiterals := literals + select: [:lit| lit isCompiledCode] + thenCollect: [:blockMethod| blockMethod allSubLiterals]. + unfoldedSubLiterals ifEmpty: + [^literals]. + ^literals, (unfoldedSubLiterals fold: [:a :b| a, b])! - ^self literals! Item was changed: ----- Method: CompiledMethod>>hasLiteralSuchThat: (in category 'literals') ----- hasLiteralSuchThat: litBlock "Answer true if litBlock returns true for any literal in this method, even if embedded in array structure." (self penultimateLiteral isMethodProperties and: [self penultimateLiteral hasLiteralSuchThat: litBlock]) ifTrue: [^true]. 2 to: self numLiterals + 1 do: [:index | | lit | lit := self objectAt: index. ((litBlock value: lit) + or: [(lit isArray or: [lit isCompiledBlock]) and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: - or: [lit isArray and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: [^true]]. ^false! Item was removed: - ----- Method: CompiledMethod>>literals (in category 'literals') ----- - literals - "Answer an Array of the literals referenced by the receiver." - | literals numberLiterals | - literals := Array new: (numberLiterals := self numLiterals). - 1 to: numberLiterals do: - [:index | - literals at: index put: (self objectAt: index + 1)]. - ^literals! Item was added: + ----- Method: CompiledMethod>>scanForInstructionPattern: (in category 'scanning') ----- + scanForInstructionPattern: tuple + "Convenient use of scanForInstructionSequence: + e.g. self systemNavigation browseAllSelect: [:m| m scanForInstructionPattern: #((pushConstant: true) (send:super:numArgs: spilled: false 1))] + self systemNavigation browseAllSelect: [:m| m scanForInstructionPattern: #((send:super:numArgs: arguments false 0) (send:super:numArgs: = false 1))]" + | first firstArgs second secondArgs third thirdArgs | + ^(InstructionStream on: self) scanForInstructionSequence: + (tuple size caseOf: { + [1] -> [first := tuple first. + firstArgs := first allButFirst. + first := first first. + [:a| + a selector == first and: [a arguments = firstArgs]]]. + [2] -> [first := tuple first. + firstArgs := first allButFirst. + second := tuple second. + secondArgs := second allButFirst. + first := first first. + second := second first. + [:a :b| + a selector == first and: [a arguments = firstArgs + and: [b selector == second and: [b arguments = secondArgs]]]]]. + [3] -> [first := tuple first. + firstArgs := first allButFirst. + second := tuple second. + secondArgs := second allButFirst. + third := tuple third. + thirdArgs := third allButFirst. + first := first first. + second := second first. + third := third first. + [:a :b :c| + a selector == first and: [a arguments = firstArgs + and: [b selector == second and: [b arguments = secondArgs + and: [c selector == third and: [c arguments = thirdArgs]]]]]]] })!

2 1

PG3ShoutParser(SHParserST80)>>scanIdentifier
by gettimothy 02 Mar '18

02 Mar '18

Good morning. Asking advice on approach to fixing this the right way. End result is at minimum a functioning class and a test to catch this stuff going forward. On Squeak 5.1 16551 First, to recreate the issue.. PG3SchemaMirror subclass: #MyDBSchemaMirror (and get it talking to the db via instructions here: http://forum.world.st/Status-of-PostgresV3-td4780110.html) Then, via those same instructions, get a Postgres Function downloaded to Squeak or attempt to enter one by hand. Second, the symptoms The SHParserST80) attempts to parse the code and a "Proceed for Truth" errors start popping up. Debugging it, the culprit is in PG3ShoutParser(SHParserST80)>>scanIdentifier (c := self nextChar) isAlphaNumeric or: [ allowUnderscoreSelectors and: [ c == $_ ] ] ] whileTrue. Where allowUnderscoreSelectors is undefined. As a quick fix attempt, changing to Scanner allowUnderscoreAsAssignment makes that error go away. However, new ones start popping up, so I decided to dig into things a bit more. Scanner is the wrong approach, because it and SHParserST80 are not related via inheritence (although they do share a common instance variable named "allowUnderscoreSelectors" I wondering if SHParserST80 is superceded by Scanner and if so, I am wondering the best way to approach this bug. Should I fix it within the SHParserST80 paradigm or is migration to Scanner in order? Thx for your time.

2 4

Jump to page: