Squeak-dev May 2017

squeak-dev@lists.squeakfoundation.org

40 participants
111 discussions

Re: [squeak-dev] The Inbox: System-jr.948.mcz
by Jakob Reschke 19 May '17

19 May '17

2017-05-17 1:23 GMT+02:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > > Surely an Environment is installed in some other environment, much like a > class being installed in its superclass, and hence being present in its > superclass's subclasses array. A fresh Environment is completely isolated. It has no connection to the original Smalltalk globals environment (except via its own class, or when you put a class in it manually you may navigate to another environment via the superclass, but Environment does not know about that). It only gets connected with other environments when you import something in either direction. Accessing the upstream and downstream connected environments of a given Environment would currently involve poking around the 'observers' and 'policies' instance variables. No useful accessors for navigation yet, because these connections are designed to propagate the updates of bindings, not to navigate the system. > So if an Environment is always in relation to the root environment, and > environments refer to those that they contain, all installed environments > can be enumerated from the root, touching a small fraction of the entire > object graph, unlike allInstancesDo: which visits every object in the heap. There is no explicit hierarchy, but one could start from Smalltalk globals (or everything in the Instances class variable) and search the graph of observers (approximately: importers). However, this might not find strictly *all* implementors and senders in the object memory, contrary to what the message names #allImplementorsOf: and friends suggest, or what might be expected from the search box. Comments? Better ideas? I would not like to implement this if there are serious objections to the approach from the beginning.

4 4

MatrixTransformMorph appears to be as broken as a very broken thing
by tim Rowledge 18 May '17

18 May '17

In my (apparently quixotic) quest to draw nicer barometers I decided to try out MatrixTransformationMorph, since it purports to allow transforming morphs and display them via Balloon with anti-aliasing etc. Well, that didn’t go so well. It appears that MTM is really pretty badly broken. Mostly that isn’t going to worry anyone since it seems to only get used when making a flex shell for a TTSampleFontMorph, which is only ever used if someone tries out the truetype sample morph from the ‘objects’ catalogue morph - and then rotates it as well. I’m having a lot of trouble making any sense of what is going on because there is no documentation to explain what is supposed to happen. Which makes it hard to decide which of the many places where things go awry is the actual bug. It’s possible that this is so un-useful that we’d be better off removing the entire class. Leaving that aside for a moment, let’s list some of the problems - Attempting to make a new MTM and set its extent will make a completely ridiculous transform, because #extent: treats this as a grow from the default extent (which is 40@50) and scales the transform to scale that up to the new extent. Probably a good idea in many situations but a bit of an issue ab initio. When attempting any rotation (which is exacty what I wanted the $%^%^#% thing for) makes for real fun. Correct me if I’m wrong but the rotations are calculated about the referencePosition which is derived at least in part from the rotationCenter. Which appears to be expected to be a fractional point giving the relative proportion within the bounds - ie the center is 0.5(a)0.5. First problem is that the MTM code was treating 0.5(a)0.5 as an actual pixel offset. Sigh. I added a scale by the extent and that seems to improve some things. Then we have the converse issue with #rotationCenter: doing some scaling that resulted in the rotation center value being set to a pixel offset instead of a fractional one! Hacked that. At least part of the problem seems to be some confusing mixing of #rotationCenter: and #setRotationCenterFrom: (the latter actually taking a pixel offset and converting it to a fractional value). If we make a nice simple needle morph out of a PolygonMorph and stick it inside an MTM and display it, initially the MTM bounds are completely unrelated to the polygon. If we then send the MTM #rotateBy: 10, the rotation proceeds about an incorrect center because that point is calculated from those incorrect bounds - and then the bounds are recalculated to fit around the (mis)rotated polygon. So the next rotation has a *differently* wrong center! To add to the fun, the only live usage code (#asFlexOf:) carefully recalculates the bounds after adding the morph it is a flex-shell of. Though only *after* calculating the rotation center based on the bounds of the submorph and the incorrect bounds of the MTM. Which *really* screws things up. Maybe the lack of any sort of explanation of how this is supposed to behave is simply confusing me so much I’m "not holding it right". Maybe it used to work and got left out of being updated when something fairly low-level got changed. Does anyone know? Does anyone care much? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: CSF: Charge to NSF

2 1

Re: [squeak-dev] The Inbox: System-jr.948.mcz
by Jakob Reschke 17 May '17

17 May '17

Hi, I almost expected this feedback regarding allInstances ;-) If the change is still only in the Inbox, no harm should have been done, otherwise somebody else should revert it in trunk. An alternative would be to enumerate only the Environments registered in that class pool variable. It requires everyone to use the correct "constructor" though, when the Environment is set up. For the sake of learning some more: I have plenty of garbage environments in my image (due to test cases creating them and references I will have to track down at another time), but the allInstancesDo does not remarkably slow down the navigation features for me. Which cases do you have in mind when you say that it does not scale? Best, Jakob Am 16.05.2017 23:21 schrieb "Eliot Miranda" <eliot.miranda(a)gmail.com>: > Hi Jakob, > > > > On Tue, May 16, 2017 at 10:09 AM, <commits(a)source.squeak.org> wrote: > >> A new version of System was added to project The Inbox: >> http://source.squeak.org/inbox/System-jr.948.mcz >> >> ==================== Summary ==================== >> >> Name: System-jr.948 >> Author: jr >> Time: 5 May 2017, 12:08:58.857884 am >> UUID: 4a19b143-6a23-b549-ab15-0d548da859f4 >> Ancestors: System-ul.947 >> >> incorporate behaviors from other environments in allBehaviorsDo: >> >> This enables senders/implementors and method searches across environments. >> >> =============== Diff against System-ul.947 =============== >> >> Item was changed: >> ----- Method: SystemNavigation>>allBehaviorsDo: (in category 'query') >> ----- >> allBehaviorsDo: aBlock >> "Evaluate the argument, aBlock, for each kind of Behavior in the >> system >> (that is, Object and its subclasses and Traits). >> ar 7/15/1999: The code below will not enumerate any obsolete or >> anonymous >> behaviors for which the following should be executed: >> >> Smalltalk allObjectsDo:[:obj| obj isBehavior >> ifTrue:[aBlock value: obj]]. >> >> but what follows is way faster than enumerating all objects." >> >> + Environment allInstancesDo: [:environment | >> + environment allClassesAndTraitsDo: [ :class | >> + aBlock value: class. >> + class isTrait ifFalse: [ "class of a Trait is >> Trait, there are no MetaTraits" >> + aBlock value: class class ] ] ]! >> - self environment allClassesAndTraitsDo: [ :class | >> - aBlock value: class. >> - class isTrait ifFalse: [ "class of a Trait is Trait, >> there are no MetaTraits" >> - aBlock value: class class ] ]! >> > > Forgive me for being blunt but Environment allInstancesDo: is absurd and > unacceptable. Environments *must* build some kind of graph that can be > enumerated without recourse to a hammer like allInstancesDo:. This simply > doesn't scale. And it suffers the problem of enumerating environments that > are no longer in use but have yet to be garbage collected. Please roll > back this change and take a better approach. > > _,,,^..^,,,_ > best, Eliot >

2 2

Re: [squeak-dev] The Inbox: System-jr.948.mcz
by Jakob Reschke 17 May '17

17 May '17

Hi Levente, In my previous patches I gave each SystemNavigation an environment in order to get it working inside another environment at all, as a first step. It might not be the best solution however, but rather an initial workaround, as I find the navigation stuff more practical when it looks into all the available environments instead of only the one I am currently browsing. After all, it is still called SystemNavigation and not EnvironmentNavigation. More specific navigation scoping like ENVY provides it for its packages ("Senders in dependent Applications" etc.) might be nice, but more work. When I find the time, I can look if the environment specificness of SystemNavigation can and should be dropped again. Best, Jakob Am 16.05.2017 23:20 schrieb "Levente Uzonyi" <leves(a)caesar.elte.hu>: > On Tue, 16 May 2017, commits(a)source.squeak.org wrote: > > > A new version of System was added to project The Inbox: > > http://source.squeak.org/inbox/System-jr.948.mcz > > > > ==================== Summary ==================== > > > > Name: System-jr.948 > > Author: jr > > Time: 5 May 2017, 12:08:58.857884 am > > UUID: 4a19b143-6a23-b549-ab15-0d548da859f4 > > Ancestors: System-ul.947 > > > > incorporate behaviors from other environments in allBehaviorsDo: > > > > This enables senders/implementors and method searches across > environments. > > Wasn't the idea to have each environment its own SystemNavigation? > This change would break that. > > Levente > > > > > =============== Diff against System-ul.947 =============== > > > > Item was changed: > > ----- Method: SystemNavigation>>allBehaviorsDo: (in category 'query') > ----- > > allBehaviorsDo: aBlock > > "Evaluate the argument, aBlock, for each kind of Behavior in the > system > > (that is, Object and its subclasses and Traits). > > ar 7/15/1999: The code below will not enumerate any obsolete or > anonymous > > behaviors for which the following should be executed: > > > > Smalltalk allObjectsDo:[:obj| obj isBehavior > ifTrue:[aBlock value: obj]]. > > > > but what follows is way faster than enumerating all objects." > > > > + Environment allInstancesDo: [:environment | > > + environment allClassesAndTraitsDo: [ :class | > > + aBlock value: class. > > + class isTrait ifFalse: [ "class of a Trait is > Trait, there are no MetaTraits" > > + aBlock value: class class ] ] ]! > > - self environment allClassesAndTraitsDo: [ :class | > > - aBlock value: class. > > - class isTrait ifFalse: [ "class of a Trait is Trait, there > are no MetaTraits" > > - aBlock value: class class ] ]! > >

1 0

The Inbox: System-jr.948.mcz
by commits＠source.squeak.org 16 May '17

16 May '17

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-jr.948.mcz ==================== Summary ==================== Name: System-jr.948 Author: jr Time: 5 May 2017, 12:08:58.857884 am UUID: 4a19b143-6a23-b549-ab15-0d548da859f4 Ancestors: System-ul.947 incorporate behaviors from other environments in allBehaviorsDo: This enables senders/implementors and method searches across environments. =============== Diff against System-ul.947 =============== Item was changed: ----- Method: SystemNavigation>>allBehaviorsDo: (in category 'query') ----- allBehaviorsDo: aBlock "Evaluate the argument, aBlock, for each kind of Behavior in the system (that is, Object and its subclasses and Traits). ar 7/15/1999: The code below will not enumerate any obsolete or anonymous behaviors for which the following should be executed: Smalltalk allObjectsDo:[:obj| obj isBehavior ifTrue:[aBlock value: obj]]. but what follows is way faster than enumerating all objects." + Environment allInstancesDo: [:environment | + environment allClassesAndTraitsDo: [ :class | + aBlock value: class. + class isTrait ifFalse: [ "class of a Trait is Trait, there are no MetaTraits" + aBlock value: class class ] ] ]! - self environment allClassesAndTraitsDo: [ :class | - aBlock value: class. - class isTrait ifFalse: [ "class of a Trait is Trait, there are no MetaTraits" - aBlock value: class class ] ]!

3 2

Re: [squeak-dev] The Inbox: System-jr.948.mcz
by Jakob Reschke 16 May '17

16 May '17

2017-05-16 19:09 GMT+02:00 commits(a)source.squeak.org <commits(a)source.squeak.org>: > class isTrait ifFalse: [ "class of a Trait is Trait, there are no MetaTraits" Is this comment from a time before ClassTrait, or does it have something else im mind?

2 1

Re: [squeak-dev] The Inbox: ToolBuilder-Kernel-jr.110.mcz
by Jakob Reschke 16 May '17

16 May '17

This enables to use the search box to go to behaviors in other environments. The new method is structurally the same as #classOrTraitFrom:pattern:label:, but changed in various places to handle the fact that there is not a single source to collect behaviors from. Also it does not operate primarily on Strings, for obvious reasons, but with the behaviors themselves. 2017-05-16 19:02 GMT+02:00 commits(a)source.squeak.org <commits(a)source.squeak.org>: > A new version of ToolBuilder-Kernel was added to project The Inbox: > http://source.squeak.org/inbox/ToolBuilder-Kernel-jr.110.mcz > > ==================== Summary ==================== > > Name: ToolBuilder-Kernel-jr.110 > Author: jr > Time: 13 May 2017, 10:49:04.306891 pm > UUID: 41b8cbb2-c017-f84b-af5d-a6b52d1365cd > Ancestors: ToolBuilder-Kernel-jr.109 > > extend behavior search to all environments > > =============== Diff against ToolBuilder-Kernel-jr.109 =============== > > Item was added: > + ----- Method: ClassDescription>>labelForBehaviorsList (in category '*ToolBuilder-Kernel') ----- > + labelForBehaviorsList > + ^ self name, > + (self environment == Smalltalk globals > + ifTrue: [''] > + ifFalse: [' (', self environment name, ')'])! > > Item was changed: > ----- Method: UIManager>>classFromPattern:withCaption: (in category 'system introspecting') ----- > classFromPattern: pattern withCaption: aCaption > + ^self classOrTraitFromAny: (Environment allInstances) pattern: pattern label: aCaption > - ^self classFromPattern: pattern withCaption: aCaption in: Smalltalk environment > " > self classFromPattern: 'CharRecog' withCaption: '' > self classFromPattern: 'rRecog' withCaption: '' > self classFromPattern: 'znak' withCaption: '' > self classFromPattern: 'orph' withCaption: '' > self classFromPattern: 'TCompil' withCaption: '' > " > ! > > Item was added: > + ----- Method: UIManager>>classOrTraitFromAny:pattern:label: (in category 'system introspecting') ----- > + classOrTraitFromAny: environments pattern: pattern label: label > + "If only one class or trait in the given environments has a name that matches pattern, return it. > + Otherwise, put up a menu offering the names (and environments) of all matching behaviors, and return the chosen one, else nil if nothing chosen. > + This method ignores separator characters in the pattern" > + > + | toMatch allBehaviors matchingBehaviors exactMatches behaviorsWithReducedIdentifiers behaviorLabels | > + toMatch := pattern copyWithoutAll: Character separators. > + toMatch ifEmpty: [ ^nil ]. > + "If there are behaviors named exactly as pattern, choose only from them." > + Symbol hasInterned: pattern ifTrue: [ :symbol | | declaringEnvironments | > + declaringEnvironments := environments select: [:each | > + each at: symbol ifPresent: [:it | it isBehavior] ifAbsent: [false]]. > + declaringEnvironments size = 1 > + ifTrue: [^ declaringEnvironments anyOne at: symbol]. > + declaringEnvironments ifNotEmpty: [ | behaviors | > + behaviors := (declaringEnvironments collect: [:each | each at: symbol]) asOrderedCollection sort: [:a :b | a name <= b name]. > + behaviorLabels := behaviors collect: [:each | each labelForBehaviorsList]. > + ^ self chooseFrom: behaviorLabels values: behaviors title: label]]. > + "No exact match, look for potential matches." > + toMatch := pattern asLowercase copyWithout: $.. > + allBehaviors := environments gather: [:each | each allClassesAndTraits]. > + matchingBehaviors := (pattern last = $. "This is some old hack, using String>>#match: may be better." > + ifTrue: [ allBehaviors select: [ :each | each name asLowercase = toMatch ] ] > + ifFalse: [ > + allBehaviors select: [ :each | > + each name includesSubstring: toMatch caseSensitive: false ] ]) > + asOrderedCollection. > + exactMatches := matchingBehaviors select: [ :each | each name asLowercase = toMatch ]. > + "Also try some fuzzy matching." > + behaviorsWithReducedIdentifiers := pattern suggestedTypeNames gather: [:each | > + allBehaviors select: [:behavior | behavior name = each]]. > + behaviorsWithReducedIdentifiers ifNotEmpty: [ > + matchingBehaviors addAll: behaviorsWithReducedIdentifiers]. > + "Let the user select if there's more than one possible match. This may give surprising results." > + matchingBehaviors ifEmpty: [^ nil "nothing matches"]. > + matchingBehaviors size = 1 ifTrue: [^ matchingBehaviors anyOne]. > + exactMatches ifNotEmpty: [matchingBehaviors addAllFirst: exactMatches]. > + behaviorLabels := matchingBehaviors collect: [:each | each labelForBehaviorsList]. > + ^ self chooseFrom: behaviorLabels values: matchingBehaviors title: label! > >

1 0

The Inbox: ToolBuilder-Kernel-jr.110.mcz
by commits＠source.squeak.org 16 May '17

16 May '17

A new version of ToolBuilder-Kernel was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-jr.110.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-jr.110 Author: jr Time: 13 May 2017, 10:49:04.306891 pm UUID: 41b8cbb2-c017-f84b-af5d-a6b52d1365cd Ancestors: ToolBuilder-Kernel-jr.109 extend behavior search to all environments =============== Diff against ToolBuilder-Kernel-jr.109 =============== Item was added: + ----- Method: ClassDescription>>labelForBehaviorsList (in category '*ToolBuilder-Kernel') ----- + labelForBehaviorsList + ^ self name, + (self environment == Smalltalk globals + ifTrue: [''] + ifFalse: [' (', self environment name, ')'])! Item was changed: ----- Method: UIManager>>classFromPattern:withCaption: (in category 'system introspecting') ----- classFromPattern: pattern withCaption: aCaption + ^self classOrTraitFromAny: (Environment allInstances) pattern: pattern label: aCaption - ^self classFromPattern: pattern withCaption: aCaption in: Smalltalk environment " self classFromPattern: 'CharRecog' withCaption: '' self classFromPattern: 'rRecog' withCaption: '' self classFromPattern: 'znak' withCaption: '' self classFromPattern: 'orph' withCaption: '' self classFromPattern: 'TCompil' withCaption: '' " ! Item was added: + ----- Method: UIManager>>classOrTraitFromAny:pattern:label: (in category 'system introspecting') ----- + classOrTraitFromAny: environments pattern: pattern label: label + "If only one class or trait in the given environments has a name that matches pattern, return it. + Otherwise, put up a menu offering the names (and environments) of all matching behaviors, and return the chosen one, else nil if nothing chosen. + This method ignores separator characters in the pattern" + + | toMatch allBehaviors matchingBehaviors exactMatches behaviorsWithReducedIdentifiers behaviorLabels | + toMatch := pattern copyWithoutAll: Character separators. + toMatch ifEmpty: [ ^nil ]. + "If there are behaviors named exactly as pattern, choose only from them." + Symbol hasInterned: pattern ifTrue: [ :symbol | | declaringEnvironments | + declaringEnvironments := environments select: [:each | + each at: symbol ifPresent: [:it | it isBehavior] ifAbsent: [false]]. + declaringEnvironments size = 1 + ifTrue: [^ declaringEnvironments anyOne at: symbol]. + declaringEnvironments ifNotEmpty: [ | behaviors | + behaviors := (declaringEnvironments collect: [:each | each at: symbol]) asOrderedCollection sort: [:a :b | a name <= b name]. + behaviorLabels := behaviors collect: [:each | each labelForBehaviorsList]. + ^ self chooseFrom: behaviorLabels values: behaviors title: label]]. + "No exact match, look for potential matches." + toMatch := pattern asLowercase copyWithout: $.. + allBehaviors := environments gather: [:each | each allClassesAndTraits]. + matchingBehaviors := (pattern last = $. "This is some old hack, using String>>#match: may be better." + ifTrue: [ allBehaviors select: [ :each | each name asLowercase = toMatch ] ] + ifFalse: [ + allBehaviors select: [ :each | + each name includesSubstring: toMatch caseSensitive: false ] ]) + asOrderedCollection. + exactMatches := matchingBehaviors select: [ :each | each name asLowercase = toMatch ]. + "Also try some fuzzy matching." + behaviorsWithReducedIdentifiers := pattern suggestedTypeNames gather: [:each | + allBehaviors select: [:behavior | behavior name = each]]. + behaviorsWithReducedIdentifiers ifNotEmpty: [ + matchingBehaviors addAll: behaviorsWithReducedIdentifiers]. + "Let the user select if there's more than one possible match. This may give surprising results." + matchingBehaviors ifEmpty: [^ nil "nothing matches"]. + matchingBehaviors size = 1 ifTrue: [^ matchingBehaviors anyOne]. + exactMatches ifNotEmpty: [matchingBehaviors addAllFirst: exactMatches]. + behaviorLabels := matchingBehaviors collect: [:each | each labelForBehaviorsList]. + ^ self chooseFrom: behaviorLabels values: matchingBehaviors title: label!

1 0

The Trunk: Network-pre.197.mcz
by commits＠source.squeak.org 15 May '17

15 May '17

Patrick Rein uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-pre.197.mcz ==================== Summary ==================== Name: Network-pre.197 Author: pre Time: 15 May 2017, 10:16:50.494328 pm UUID: 31250966-3cc4-5842-a5da-b35dbdc1d8aa Ancestors: Network-pre.196 Minor fixes to comply with standard library protocol and adds a missing setter =============== Diff against Network-pre.196 =============== Item was changed: ----- Method: DateAndTime>>asMailMessageString (in category '*Network-Url') ----- asMailMessageString "According to RFC 822: https://tools.ietf.org/html/rfc822#section-5" | result | result := WriteStream on: (String new: 30). result nextPutAll: self dayOfWeekAbbreviation; nextPut: $,; space; nextPutAll: (self dayOfMonth asString padded: #left to: 2 with: $0); space; nextPutAll: self monthAbbreviation; space; nextPutAll: self year asString; space. self printHMSOn: result. result space. result + nextPutAll: (self offset negative ifTrue: ['-'] ifFalse: ['+']); - nextPutAll: (self offset isNegative ifTrue: ['-'] ifFalse: ['+']); nextPutAll: (self offset abs hours asString padded: #left to: 2 with: $0); nextPutAll: (self offset abs minutes asString padded: #left to: 2 with: $0). ^ result contents! Item was added: + ----- Method: MailMessage>>subject: (in category 'access') ----- + subject: aString + + ^ self setField: 'subject' toString: aString!

1 0

The Trunk: Tools-pre.761.mcz
by commits＠source.squeak.org 15 May '17

15 May '17

Patrick Rein uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-pre.761.mcz ==================== Summary ==================== Name: Tools-pre.761 Author: pre Time: 15 May 2017, 9:37:39.826328 pm UUID: 8c06fe98-86ae-7d4b-b4fa-47eb181ac234 Ancestors: Tools-eem.760 Adds drag and drop support to the object explorer to make it consistent with the inspector interactions =============== Diff against Tools-eem.760 =============== Item was changed: ----- Method: ObjectExplorer>>buildWith: (in category 'toolbuilder') ----- buildWith: builder | windowSpec treeSpec textSpec buttonSpec buttonOffset tool | windowSpec := builder pluggableWindowSpec new. windowSpec model: self; children: OrderedCollection new; label: #label; extent: self initialExtent. treeSpec := builder pluggableTreeSpec new. treeSpec model: self; nodeClass: self class nodeClass; roots: #getList; keyPress: #explorerKey:from:event:; getSelected: #currentSelection; setSelected: #currentSelection:; setSelectedParent: #currentParent:; menu: #genericMenu:; + dragItem: #getDragItem:; autoDeselect: false; columns: (ObjectExplorerWrapper showContentsInColumns ifTrue: [{ [:listMorph | (listMorph filteredItems collect: [:item | item preferredWidthOfColumn: 1]) max]. nil "take all the space"}]); frame: (0@0 corner: 1(a)0.71). windowSpec children add: treeSpec. buttonOffset := (Preferences standardButtonFont widthOfString: 'inspect') * 3/2. textSpec := builder pluggableCodePaneSpec new. textSpec model: self; getText: #expression; editText: #expression:; menu: #codePaneMenu:shifted:; help: 'Evaluate expressions for the current tree selection...' translated; frame: (LayoutFrame fractions: (0(a)0.71 corner: 1@1) offsets: (0@0 corner: buttonOffset negated@0)). windowSpec children add: textSpec. buttonSpec := builder pluggableButtonSpec new model: self; label: 'inspect'; action: #inspectObject; help: 'Switch to an inspector tool'; frame: (LayoutFrame fractions: (1(a)0.71 corner: 1@1) offsets: (buttonOffset negated@0 corner: 0 @ 0)). windowSpec children add: buttonSpec. tool := builder build: windowSpec. self changed: #expandRootsRequested. ^ tool! Item was added: + ----- Method: ObjectExplorer>>getDragItem: (in category 'user interface') ----- + getDragItem: binding + + ^ binding value!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
12
Older →