Squeak-dev May 2016

squeak-dev@lists.squeakfoundation.org

45 participants
258 discussions

New Window and Focus related preferences
by Chris Muller 01 Jun '16

01 Jun '16

HI all, with Morphic-mt.1154, Marcel did a great upgrade to the focus-related preferences introduced last October. He was able to reduce the number of preferences from four to three, while eliminating all semantic ambiguity between them AND keeping all of the existing functionality. The old preferences: mouseOverForKeyboardFocus Focus Follows Mouse Window Active On First Click Windows Raise On Click have been replaced with just these three: Windows' Contents Are Always Active Windows' Controls Are Always Active Windows Raise On Any Click and yet every combination of variability among the dimensions of z-ordering, widget focus, and window focus are still available, except now, unambiguously. Nice work!

3 3

Re: [squeak-dev] How do I debug the debugger?
by Jakob Reschke 01 Jun '16

01 Jun '16

You could start by putting a breakpoint in Debugger class>>morphicOpenOn:context:label:contents:fullView: or ToolBuilder>>openDebugger:label: Also save your image before you start your debugging attempt. The last time I tried to debug the Debugger, stepping out of the original context or, in general, pressing the wrong button at the wrong time gave me countless more debuggers or froze the image. However, if you only navigate through the ToolBuilder code, you might be better off. 2016-05-31 22:28 GMT+02:00 gettimothy <gettimothy(a)zoho.com>: > Hi all. > > I am trying to track down this bug: > > https://timmydosmalltalk.wordpress.com/2016/05/29/linux-64x64-squeak-cog-sp… > > > I need to debug how that debugger window gets built. > > ideas? > > thx > > >

4 4

Daily Commit Log
by commits＠source.squeak.org 31 May '16

31 May '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-May/068153.html Name: Morphic-ul.1151 Ancestors: Morphic-mt.1150 Make MorphicAlarmQueue not be a subclass of Heap. Use encapsulation instead. Part #1. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068154.html Name: Morphic-ul.1152 Ancestors: Morphic-ul.1151 Make MorphicAlarmQueue not be a subclass of Heap. Use encapsulation instead. Part #2. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068155.html Name: Morphic-ul.1153 Ancestors: Morphic-ul.1152 Make MorphicAlarmQueue not be a subclass of Heap. Use encapsulation instead. Part #3. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068156.html Name: Morphic-mt.1154 Ancestors: Morphic-ul.1153 Another refactoring of SystemWindow. Improves readability of window properties: Windows Raise on Any Click Windows' Contents Are Always Active Windows' Controls Are Always Active Thanks to Chris for pointing out several issues. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068157.html Name: Kernel-mt.1027 Ancestors: Kernel-pre.1026 Appendix to Morphic-mt.1154. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068158.html Name: ToolBuilder-Morphic-cmm.164 Ancestors: ToolBuilder-Morphic-mt.163 - Make #balloonText, like #printString, less disruptive to the user-interface when there's a problem. - Clarify the name of the preference which allows filtering hierarchical lists by only their labels. =============================================

1 0

The Trunk: ToolBuilder-Morphic-cmm.164.mcz
by commits＠source.squeak.org 31 May '16

31 May '16

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-cmm.164.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-cmm.164 Author: cmm Time: 31 May 2016, 4:26:42.939857 pm UUID: bd968a1e-4af0-4499-98b4-bd3fa99f7f14 Ancestors: ToolBuilder-Morphic-mt.163 - Make #balloonText, like #printString, less disruptive to the user-interface when there's a problem. - Clarify the name of the preference which allows filtering hierarchical lists by only their labels. =============== Diff against ToolBuilder-Morphic-mt.163 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>drawBalloonTextOn: (in category 'drawing') ----- + drawBalloonTextOn: aCanvas - drawBalloonTextOn: aCanvas "Show balloon text in the text morph if it has no contents." + textMorph contents ifNotEmpty: [ ^ self ]. + ([ self balloonText ] + on: Error + do: [ : err | 'error in balloonText' ]) ifNotNil: + [ : text | aCanvas - - textMorph contents ifNotEmpty: [^ self]. - - self balloonText ifNotNil: [:text | - aCanvas drawString: text + in: (self innerBounds insetBy: (5 @ 2 corner: 0 @ 0)) + font: textMorph textStyle defaultFont "I want italic here" + color: (Color gray: 0.7) ]! - in: (self innerBounds insetBy: (5@2 corner: 0@0)) - font: textMorph textStyle defaultFont - color: (Color gray: 0.7)].! Item was changed: ----- Method: PluggableTreeMorph class>>filterByLabelsOnly (in category 'preferences') ----- filterByLabelsOnly + <preference: 'Filterable Trees by labels only' - <preference: 'Filterable Lists by labels only' category: 'scrolling' description: 'When using the Filterable Lists option, set this to only match the labels, not the contents, of hierarchical lists. Otherwise, search both labels and contents will be matched.' type: #Boolean> ^ FilterByLabelsOnly ifNil: [ false ]!

1 0

How do I debug the debugger?
by gettimothy 31 May '16

31 May '16

Hi all. I am trying to track down this bug: https://timmydosmalltalk.wordpress.com/2016/05/29/linux-64x64-squeak-cog-sp… I need to debug how that debugger window gets built. ideas? thx

1 0

OSProcess tests crash the VM
by Tim Johnson 31 May '16

31 May '16

Hi all, I installed OSProcess into a 4.6 image via SqueakMap this morning and ran its tests. I am running OS X 10.6.8. Early into the list of tests to run, the VM crashes. What follows are the crash logs from Cocoa VM 5.7.4.1 (http://www.squeakvm.org/mac/ contains some broken links and may be quite out of date, FWIW), and Cog v3397. Here is the crash log from 5.7.4.1: Process: Squeak [803] Path: /Applications/Squeak/Squeak 5.7.4.1.app/Contents/MacOS/Squeak Identifier: Squeak Version: ??? (???) Code Type: X86 (Native) Parent Process: Squeak [790] Date/Time: 2016-05-28 08:41:56.560 -0700 OS Version: Mac OS X 10.6.8 (10K549) Report Version: 6 Exception Type: EXC_BAD_ACCESS (SIGABRT) Exception Codes: KERN_INVALID_ADDRESS at 0x000000006c1f6f3b Crashed Thread: 0 Dispatch queue: com.apple.main-thread Application Specific Information: abort() called *** multi-threaded process forked *** Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libSystem.B.dylib 0x94580c5a __kill + 10 1 libSystem.B.dylib 0x94580c4c kill$UNIX2003 + 32 2 libSystem.B.dylib 0x946135a5 raise + 26 3 libSystem.B.dylib 0x946296e4 abort + 93 4 org.squeak.Squeak 0x000a3ccc sigsegv + 44 5 ??? 0xffffffff 0 + 4294967295 Thread 0 crashed with X86 Thread State (32-bit): eax: 0x00000000 ebx: 0x94629693 ecx: 0xbfffe23c edx: 0x94580c5a edi: 0x1ff121a0 esi: 0xbfffe670 ebp: 0xbfffe258 esp: 0xbfffe23c ss: 0x0000001f efl: 0x00000282 eip: 0x94580c5a cs: 0x00000007 ds: 0x0000001f es: 0x0000001f fs: 0x00000000 gs: 0x00000037 cr2: 0x3f23c940 +++++ Cog VM v3397: +++++ Process: Squeak [685] Path: /Applications/Squeak/Cog 3397.app/Contents/MacOS/Squeak Identifier: com.squeak.Cog Version: Squeak Cog 4.0.3397 (4.0.3397) Code Type: X86 (Native) Parent Process: launchd [339] Date/Time: 2016-05-28 08:30:21.513 -0700 OS Version: Mac OS X 10.6.8 (10K549) Report Version: 6 Anonymous UUID: E643DB34-DCF4-46E5-B8DF-93CDE79B01CE Exception Type: EXC_BAD_ACCESS (SIGABRT) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000104 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Application Specific Information: abort() called Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libSystem.B.dylib 0x94580c5a __kill + 10 1 libSystem.B.dylib 0x94580c4c kill$UNIX2003 + 32 2 libSystem.B.dylib 0x946135a5 raise + 26 3 libSystem.B.dylib 0x946296e4 abort + 93 4 com.squeak.Cog 0x00071564 sigsegv + 404 5 libSystem.B.dylib 0x9458605b _sigtramp + 43 6 ??? 0xffffffff 0 + 4294967295 7 com.squeak.Cog 0x000c97a3 scanForCleanBlocks + 83 8 com.squeak.Cog 0x000cbd03 compileCogMethod + 403 9 com.squeak.Cog 0x000cbe37 cogselector + 103 10 com.squeak.Cog 0x000f2f72 makeBaseFrameFor + 546 11 com.squeak.Cog 0x000f427d transferTofrom + 413 12 com.squeak.Cog 0x000f4706 synchronousSignal + 262 13 com.squeak.Cog 0x000f7fb1 checkForEventsMayContextSwitch + 625 14 com.squeak.Cog 0x000f82b0 ceCheckForInterrupts + 16 15 ??? 0x181106e3 0 + 403769059 16 com.squeak.Cog 0x00104976 interpret + 3174 17 com.squeak.Cog 0x0005f7a0 EventLoopEventHandler + 144 18 com.apple.HIToolbox 0x910f9c2f DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 1567 19 com.apple.HIToolbox 0x910f8ef6 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 411 20 com.apple.HIToolbox 0x910f8d55 SendEventToEventTargetWithOptions + 58 21 com.apple.HIToolbox 0x9112da24 ToolboxEventDispatcherHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 3006 22 com.apple.HIToolbox 0x910fa080 DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 2672 23 com.apple.HIToolbox 0x910f8ef6 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 411 24 com.apple.HIToolbox 0x9111b7f3 SendEventToEventTarget + 52 25 com.apple.HIToolbox 0x912a4c17 ToolboxEventDispatcher + 86 26 com.apple.HIToolbox 0x912a4d4f RunApplicationEventLoop + 243 27 com.squeak.Cog 0x0005efba RunApplicationEventLoopWithSqueak + 218 28 com.squeak.Cog 0x000711b2 main + 690 29 com.squeak.Cog 0x00002b56 start + 54

2 3

Problems updating, canvas being nil
by karl ramberg 31 May '16

31 May '16

I was updating and had to change this method to use 'self assuredCanvas' because canvas instance variable was nil WorldState>>displayWorld: aWorld submorphs: submorphs "Update this world's display." | deferredUpdateMode handsToDraw allDamage handDamageRects worldDamageRects | submorphs do: [:m | m fullBounds]. "force re-layout if needed" self checkIfUpdateNeeded ifFalse: [^ self]. "display is already up-to-date" deferredUpdateMode := self doDeferredUpdatingFor: aWorld. deferredUpdateMode ifFalse: [self assuredCanvas]. worldDamageRects := self drawWorld: aWorld submorphs: submorphs invalidAreasOn: *self assuredCanvas*. "repair world's damage on canvas" "self handsDo:[:h| h noticeDamageRects: worldDamageRects]." handsToDraw := self selectHandsToDrawForDamage: worldDamageRects. handDamageRects := handsToDraw collect: [:h | h savePatchFrom: canvas]. allDamage := worldDamageRects, handDamageRects. handsToDraw reverseDo: [:h | canvas fullDrawMorph: h]. "draw hands onto world canvas" "*make this true to flash damaged areas for testing*" Preferences debugShowDamage ifTrue: [aWorld flashRects: allDamage color: Color black]. canvas finish: allDamage. "quickly copy altered rects of canvas to Display:" deferredUpdateMode ifTrue: [self forceDamageToScreen: allDamage] ifFalse: [canvas showAt: aWorld viewBox origin invalidRects: allDamage]. handsToDraw do: [:h | h restoreSavedPatchOn: canvas]. "restore world canvas under hands" Display deferUpdates: false; forceDisplayUpdate. Best, Karl

2 10

The Trunk: Kernel-mt.1027.mcz
by commits＠source.squeak.org 31 May '16

31 May '16

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1027.mcz ==================== Summary ==================== Name: Kernel-mt.1027 Author: mt Time: 31 May 2016, 10:43:24.59966 am UUID: a9379948-081f-fb4f-a55d-5f72c6d674e5 Ancestors: Kernel-pre.1026 Appendix to Morphic-mt.1154. =============== Diff against Kernel-pre.1026 =============== Item was changed: ----- Method: Model class>>windowActiveOnFirstClick (in category 'preferences') ----- windowActiveOnFirstClick + <preference: 'Windows'' Contents Are Always Active' - <preference: 'Windows Active On First Click' category: 'windows' + description: 'When enabled, the widgets of background windows are sensitive to mouse input. When disabled, clicking background window will only make it the active window, without changing, for example, selections in lists or text fields.' - description: 'When enabled, the widgets of background (inactive) windows are sensitive to mouse input. When disabled, clicking background window will only make it the active window, without changing, for example, selections in lists or text fields.' type: #Boolean> ^ WindowActiveOnFirstClick ifNil: [ false ]! Item was changed: ----- Method: Model class>>windowActiveOnFirstClick: (in category 'preferences') ----- windowActiveOnFirstClick: aBoolean + WindowActiveOnFirstClick := aBoolean. + (Smalltalk classNamed: #SystemWindow) ifNotNil: [:c | c reconfigureWindowsForFocus].! - WindowActiveOnFirstClick := aBoolean.!

1 0

The Trunk: Morphic-mt.1154.mcz
by commits＠source.squeak.org 31 May '16

31 May '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1154.mcz ==================== Summary ==================== Name: Morphic-mt.1154 Author: mt Time: 31 May 2016, 10:41:59.45866 am UUID: 37fee264-be7d-a442-8ea5-cf72d229cab3 Ancestors: Morphic-ul.1153 Another refactoring of SystemWindow. Improves readability of window properties: Windows Raise on Any Click Windows' Contents Are Always Active Windows' Controls Are Always Active Thanks to Chris for pointing out several issues. =============== Diff against Morphic-ul.1153 =============== Item was added: + ----- Method: CornerGripMorph>>mouseDown: (in category 'as yet unclassified') ----- + mouseDown: anEvent + "Disable drop shadow to improve performance." + + super mouseDown: anEvent. + + target ifNil: [^ self]. + target fastFramingOn ifFalse: [ + self setProperty: #targetHadDropShadow toValue: target hasDropShadow. + target hasDropShadow: false].! Item was changed: ----- Method: CornerGripMorph>>mouseMove: (in category 'as yet unclassified') ----- mouseMove: anEvent | delta | target ifNil: [^ self]. target fastFramingOn ifTrue: [delta := target doFastWindowReframe: self ptName] ifFalse: [ - target hasDropShadow: false. delta := lastMouse ifNil: [0@0] ifNotNil: [anEvent cursorPoint - lastMouse]. lastMouse := anEvent cursorPoint. self apply: delta. self bounds: (self bounds origin + delta extent: self bounds extent)].! Item was changed: ----- Method: CornerGripMorph>>mouseUp: (in category 'as yet unclassified') ----- mouseUp: anEvent target ifNil: [^ self]. target fastFramingOn ifFalse: [ + (self valueOfProperty: #targetHadDropShadow ifAbsent: [false]) ifTrue: [target hasDropShadow: true]. + self removeProperty: #targetHadDropShadow].! - target hasDropShadow: Preferences menuAppearance3d].! Item was changed: MorphicModel subclass: #SystemWindow instanceVariableNames: 'labelString stripes label closeBox collapseBox paneMorphs paneRects collapsedFrame fullFrame isCollapsed isActive menuBox mustNotClose labelWidgetAllowance updatablePanes allowReframeHandles labelArea expandBox' + classVariableNames: 'ClickOnLabelToEdit CloseBoxFrame CloseBoxImageFlat CloseBoxImageGradient CollapseBoxImageFlat CollapseBoxImageGradient DoubleClickOnLabelToExpand ExpandBoxFrame ExpandBoxImageFlat ExpandBoxImageGradient FocusFollowsMouse GradientWindow HideExpandButton MenuBoxFrame MenuBoxImageFlat MenuBoxImageGradient ResizeAlongEdges ReuseWindows TopWindow WindowTitleActiveOnFirstClick WindowsRaiseOnClick' - classVariableNames: 'ClickOnLabelToEdit CloseBoxFrame CloseBoxImageFlat CloseBoxImageGradient CollapseBoxImageFlat CollapseBoxImageGradient DoubleClickOnLabelToExpand ExpandBoxFrame ExpandBoxImageFlat ExpandBoxImageGradient FocusFollowsMouse GradientWindow HideExpandButton MenuBoxFrame MenuBoxImageFlat MenuBoxImageGradient ResizeAlongEdges ReuseWindows TopWindow WindowsActiveOnlyOnTop' poolDictionaries: '' category: 'Morphic-Windows'! !SystemWindow commentStamp: '<historical>' prior: 0! SystemWindow is the Morphic equivalent of StandardSystemView -- a labelled container for rectangular views, with iconic facilities for close, collapse/expand, and resizing. The attribute onlyActiveOnTop, if set to true (and any call to activate will set this), determines that only the top member of a collection of such windows on the screen shall be active. To be not active means that a mouse click in any region will only result in bringing the window to the top and then making it active.! Item was added: + ----- Method: SystemWindow class>>windowTitleActiveOnFirstClick (in category 'preferences') ----- + windowTitleActiveOnFirstClick + <preference: 'Windows'' Controls Are Always Active' + category: 'windows' + description: '... except for grips and splitters. Those remain always active and an option to bring the window to the front.' + type: #Boolean> + ^ WindowTitleActiveOnFirstClick ifNil: [ true ]! Item was added: + ----- Method: SystemWindow class>>windowTitleActiveOnFirstClick: (in category 'preferences') ----- + windowTitleActiveOnFirstClick: boolean + WindowTitleActiveOnFirstClick := boolean. + self reconfigureWindowsForFocus.! Item was removed: - ----- Method: SystemWindow class>>windowsActiveOnlyOnTop (in category 'preferences') ----- - windowsActiveOnlyOnTop - <preference: 'Windows Active Only On Top' - category: 'windows' - description: 'If true, a click anywhere within a background window will raise it above all other windows to become the active window. If false, all windows remain active and occluded windows will only raise when clicking in the title bar, splitters, or grips.' - type: #Boolean> - ^ WindowsActiveOnlyOnTop ifNil: [ true ]! Item was removed: - ----- Method: SystemWindow class>>windowsActiveOnlyOnTop: (in category 'preferences') ----- - windowsActiveOnlyOnTop: aBoolean - - aBoolean = WindowsActiveOnlyOnTop ifTrue: [^ self]. - WindowsActiveOnlyOnTop := aBoolean. - self reconfigureWindowsForFocus.! Item was added: + ----- Method: SystemWindow class>>windowsRaiseOnClick (in category 'preferences') ----- + windowsRaiseOnClick + <preference: 'Windows Raise On Any Click' + category: 'windows' + description: 'If false, windows only raise when clicking on window decorations.' + type: #Boolean> + ^ WindowsRaiseOnClick ifNil: [ true ]! Item was added: + ----- Method: SystemWindow class>>windowsRaiseOnClick: (in category 'preferences') ----- + windowsRaiseOnClick: boolean + WindowsRaiseOnClick := boolean.! Item was changed: ----- Method: SystemWindow>>activate (in category 'focus') ----- activate "Bring the receiver to the top. If I am modal, bring along my modal owning window and my model child as well." self isActive ifTrue: [self lookFocused. ^ self]. self topRendererOrSelf owner ifNil: [^ self "avoid spurious activate when drop in trash"]. self isActive: true. "Special handling for expanded windows." self isCollapsed ifFalse: [ model modelWakeUpIn: self. self positionSubmorphs]. self submorphsDo: [:each | each unlock]. + self lookFocused.! - self - lookFocused; - updateFocusLookAtHand.! Item was changed: ----- Method: SystemWindow>>beKeyWindow (in category 'top window') ----- beKeyWindow "Let me be the most important window on the screen. I am at the top and I can have a shadow to get more attention by the user. I am the window that is responsible for window keyboard shortcuts." | oldKeyWindow | self isKeyWindow ifTrue: [^ self]. oldKeyWindow := TopWindow. TopWindow := self. PasteUpMorph globalCommandKeysEnabled ifTrue: [ self activeHand addKeyboardListener: self ]. self unlockWindowDecorations; "here, because all windows might be active anyway" activate; "if not already active, activate now" comeToFront. "key windows are on top" "Change appearance to get noticed." self hasDropShadow: Preferences menuAppearance3d. (self valueOfProperty: #borderWidthWhenActive) ifNotNil: [:bw | self acquireBorderWidth: bw]. oldKeyWindow ifNotNil: [:wnd | wnd passivateIfNeeded. self activeHand removeKeyboardListener: oldKeyWindow. "Change appearance to not look prettier than the new key window." wnd hasDropShadow: false. (wnd valueOfProperty: #borderWidthWhenInactive) + ifNotNil: [:bw | wnd acquireBorderWidth: bw]]. + + "Synchronize focus look with position of current hand because any call could have made this window the new key window." + self updateFocusLookAtHand.! - ifNotNil: [:bw | wnd acquireBorderWidth: bw]].! Item was added: + ----- Method: SystemWindow>>handleMouseDown: (in category 'events') ----- + handleMouseDown: evt + + "If my submorphs handled the events, we still need to use this hook to raise." + (self isKeyWindow not + and: [self class windowsRaiseOnClick + or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) + ifTrue: [self beKeyWindow]. + + ^ super handleMouseDown: evt! Item was changed: ----- Method: SystemWindow>>justDroppedInto:event: (in category 'geometry') ----- justDroppedInto: aMorph event: anEvent + isCollapsed + ifTrue: [self position: ((self position max: 0@0) grid: 8@8). + collapsedFrame := self bounds] + ifFalse: [fullFrame := self bounds]. + + self beKeyWindow. + self hasDropShadow: true. "See #startDragFromLabel:." + + aMorph == self world ifTrue: [self assureLabelAreaVisible]. + (ToolBuilder openToolsAttachedToMouseCursor and: (self hasProperty: #initialDrop)) ifTrue: [ self removeProperty: #initialDrop. (self submorphs detect: [:m | m isKindOf: BottomRightGripMorph] ifNone: []) ifNotNil: [:grip | + grip + referencePoint: anEvent position; + setProperty: #targetHadDropShadow toValue: true "See MorphicToolBuilder >> #open:". + self hasDropShadow: false. - grip referencePoint: anEvent position. anEvent hand newMouseFocus: grip]]. - - self hasDropShadow: (self isKeyWindow and: [Preferences menuAppearance3d]). - - isCollapsed - ifTrue: [self position: ((self position max: 0@0) grid: 8@8). - collapsedFrame := self bounds] - ifFalse: [fullFrame := self bounds. - self beKeyWindow]. - aMorph == self world ifTrue: [self assureLabelAreaVisible]. - ^super justDroppedInto: aMorph event: anEvent! Item was changed: ----- Method: SystemWindow>>lockWindowDecorations (in category 'focus') ----- lockWindowDecorations "Lock all window decrations, that is grips, splitters, and title bar." + self windowDecorations do: [:m | m lock].! - self submorphsDo: [:m | - (self paneMorphs includes: m) - ifFalse: [m lock]].! Item was added: + ----- Method: SystemWindow>>lockWindowTitle (in category 'focus') ----- + lockWindowTitle + + labelArea ifNotNil: [:m | m lock].! Item was changed: ----- Method: SystemWindow>>lookFocused (in category 'focus') ----- lookFocused label ifNotNil: [ label color: Color black ]. + + (self isKeyWindow or: [self class windowTitleActiveOnFirstClick]) - - (self isKeyWindow or: [model windowActiveOnFirstClick]) ifTrue: [self undimWindowButtons]. + - self paneColorToUse in: [ : col | self setStripeColorsFrom: col ; adoptPaneColor: col].! Item was changed: ----- Method: SystemWindow>>mouseDown: (in category 'events') ----- mouseDown: evt - | wasKeyWindow | - (wasKeyWindow := self isKeyWindow) ifFalse: [ - evt hand releaseKeyboardFocus. - self beKeyWindow]. - - "If the window was locked, we did unlock it by now. If the user does not want to invest an additional click to interact with an actual widget, re-process the event." - (wasKeyWindow not and: [model windowActiveOnFirstClick]) - ifTrue: [ - evt wasHandled: false. - ^ self processEvent: evt]. - evt hand waitForClicksOrDrag: self event: evt selectors: { nil. nil. nil. #startDragFromLabel: } threshold: HandMorph dragThreshold.! Item was changed: ----- Method: SystemWindow>>mouseEnter: (in category 'events') ----- mouseEnter: anEvent "Handle a mouseEnter event, meaning the mouse just entered my bounds with no button pressed. The default response is to let my eventHandler, if any, handle it." super mouseEnter: anEvent. + self isActive ifTrue: [self lookFocused].! - self isActive - ifTrue: [self lookFocused] - ifFalse: [model windowActiveOnFirstClick - ifTrue: [self undimWindowButtons]].! Item was changed: ----- Method: SystemWindow>>mouseEnterDragging: (in category 'events') ----- mouseEnterDragging: evt "unlock children for drop operations" self flag: #performance. "mt: There may be no need to change appearance if no widget wants the drop." + self isActive ifTrue: [self lookFocused]. - self isActive - ifTrue: [self lookFocused] - ifFalse: [model windowActiveOnFirstClick - ifTrue: [self undimWindowButtons]]. (self isActive not and: [evt hand hasSubmorphs]) ifTrue: [ self activate. "unlock contents for drop" evt hand addMouseListener: self. "for drop completion on submorph" ].! Item was changed: ----- Method: SystemWindow>>mouseLeave: (in category 'events') ----- mouseLeave: anEvent "Handle a mouseEnter event, meaning the mouse just entered my bounds with no button pressed. The default response is to let my eventHandler, if any, handle it." super mouseLeave: anEvent. + model windowActiveOnFirstClick ifTrue: [self lookUnfocused].! - (self isActive and: [self class windowsActiveOnlyOnTop not]) - ifTrue: [self lookUnfocused] - ifFalse: [self isKeyWindow - ifFalse: [self dimWindowButtons]].! Item was changed: ----- Method: SystemWindow>>mouseLeaveDragging: (in category 'events') ----- mouseLeaveDragging: evt "Passivate after drop operations if needed." + model windowActiveOnFirstClick ifTrue: [self lookUnfocused]. - (self isActive and: [self class windowsActiveOnlyOnTop not]) - ifTrue: [self lookUnfocused] - ifFalse: [self isKeyWindow - ifFalse: [self dimWindowButtons]]. (self isKeyWindow not and: [evt hand hasSubmorphs]) ifTrue:[ self passivateIfNeeded. evt hand removeMouseListener: self. "no more drop completion possible on submorph" ].! Item was changed: ----- Method: SystemWindow>>passivateIfNeeded (in category 'focus') ----- passivateIfNeeded + model windowActiveOnFirstClick + ifFalse: [self passivate] + ifTrue: [self lookUnfocused]. + + self unlockWindowDecorations. + + self class windowTitleActiveOnFirstClick + ifFalse: [self lockWindowTitle] + ifTrue: [self unlockWindowTitle].! - self class windowsActiveOnlyOnTop - ifTrue: [self passivate] - ifFalse: [self lockWindowDecorations; lookUnfocused].! Item was changed: ----- Method: SystemWindow>>unlockWindowDecorations (in category 'focus') ----- unlockWindowDecorations "Unlock all window decrations, that is grips, splitters, and title bar." + self windowDecorations do: [:m | m unlock]. - self submorphsDo: [:m | - (self paneMorphs includes: m) - ifFalse: [m unlock]]. - + "Migrate old window instances. Can be removed in the future." - "Migrate old window instances." labelArea ifNotNil: [:m | m submorphsDo: [:sm | sm unlock]].! Item was added: + ----- Method: SystemWindow>>unlockWindowTitle (in category 'focus') ----- + unlockWindowTitle + + labelArea ifNotNil: [:m | m unlock].! Item was changed: ----- Method: SystemWindow>>updateFocusLookAtHand (in category 'focus') ----- updateFocusLookAtHand "If there is more than one active window, look for the mouse cursor and update the window focus look accordingly. This method is not on the class-side because we need our world and some active hand." + model windowActiveOnFirstClick ifFalse: [^ self]. - self class windowsActiveOnlyOnTop ifTrue: [^ self]. ((self class windowsIn: self world) do: [:window | window lookUnfocused]; select: [:window | window bounds containsPoint: self activeHand position]) + ifNotEmpty: [:windowsPointed | windowsPointed first lookFocused "only to foremost window"].! - ifNotEmpty: [:windowsPointed | windowsPointed first lookFocused "only to foremost window"]. - - self class keyWindow lookFocused.! Item was added: + ----- Method: SystemWindow>>windowDecorations (in category 'focus') ----- + windowDecorations + + ^ self submorphs copyWithoutAll: self paneMorphs! Item was changed: + (PackageInfo named: 'Morphic') postscript: 'SystemWindow reconfigureWindowsForFocus.'! - (PackageInfo named: 'Morphic') postscript: 'MorphicAlarmQueue allInstancesDo: #migrate'!

1 0

Re: The Trunk: Morphic-ul.1153.mcz
by marcel.taeumel 31 May '16

31 May '16

Hi Levente, very nice! :) +1 Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-Morphic-ul-1153-mcz-tp4898220p4898243.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

Jump to page: