Squeak-dev April 2016

squeak-dev@lists.squeakfoundation.org

39 participants
244 discussions

set equality has changed :-(
by Eliot Miranda 19 Apr '16

19 Apr '16

Hi All, this used to work: (Set with: #module) = (IdentitySet with: #module) when did this change and why? _,,,^..^,,,_ best, Eliot

5 9

Re: The Trunk: Morphic-cmm.1120.mcz
by marcel.taeumel 19 Apr '16

19 Apr '16

Sorry, I will re-think that. Can you elaborate what broke and what not? I do not understand your explanation. - "toggle between two selections"? --- this seems to be a bug you got used to - "navigation by filtering"? --- ??? - "interact with model selections"? --- It already destroys the selection to 1. Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-Morphic-cmm-1120-mcz-tp4890853p4890868.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

The Trunk: Morphic-cmm.1120.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.1120.mcz ==================== Summary ==================== Name: Morphic-cmm.1120 Author: cmm Time: 19 April 2016, 10:33:09.002758 am UUID: b0dd74f2-189a-4b77-baed-280740462474 Ancestors: Morphic-mt.1119 Undo Morphic-mt.1119 because it totally broke the filtering function. - It broke navigation by filtering. - It broke toggling between two selections with the backspace key. Filtering is its own isolated feature that works on texts of lists, it was never meant to interact with the model or user selections made outside the filtering feature. =============== Diff against Morphic-mt.1119 =============== Item was changed: ----- Method: PluggableListMorph>>basicKeyPressed: (in category 'model access') ----- basicKeyPressed: aChar + | milliseconds slowKeyStroke listSize newSelectionIndex oldSelectionIndex startIndex | - | milliseconds slowKeyStroke listSize newSelectionIndex oldSelectionIndex startIndex newPriorSelection | oldSelectionIndex := newSelectionIndex := self getCurrentSelectionIndex. - - "keep across matches that do not have current selection" - newPriorSelection := priorSelection ifNil: [oldSelectionIndex] ifNotNil: [oldSelectionIndex = 0 ifTrue: [priorSelection] ifFalse: [oldSelectionIndex]]. - listSize := self getListSize. listSize = 0 ifTrue: [ ^self flash ]. milliseconds := Time millisecondClockValue. slowKeyStroke := (Time milliseconds: milliseconds since: lastKeystrokeTime) > (self class filterableLists ifTrue: [500] ifFalse: [ 300 ]). lastKeystrokeTime := milliseconds. slowKeyStroke ifTrue: + [ self class filterableLists ifTrue: [ self hasFilter ifFalse: [ priorSelection := self modelIndexFor: self selectionIndex] ]. - [ self class filterableLists ifTrue: [ self hasFilter ifFalse: [ priorSelection := newPriorSelection ] ]. "forget previous keystrokes and search in following elements" lastKeystrokes := aChar asLowercase asString. newSelectionIndex := newSelectionIndex \\ listSize + 1. self class filterableLists ifTrue: [ list := self getFullList ] ] ifFalse: [ "append quick keystrokes but don't move selection if it still matches" lastKeystrokes := lastKeystrokes , aChar asLowercase asString. newSelectionIndex := newSelectionIndex max: 1 ]. "No change if model is locked" model okToChange ifFalse: [ ^ self ]. self class filterableLists ifTrue: [ self filterList ; updateList. + newSelectionIndex := self modelIndexFor: 1 ] - newSelectionIndex := ((self uiIndexFor: newPriorSelection) > 0) - ifTrue: [newPriorSelection] - ifFalse: [0] ] ifFalse: [ startIndex := newSelectionIndex. listSize := self getListSize. [ (self getListItem: newSelectionIndex) asString withBlanksTrimmed asLowercase beginsWith: lastKeystrokes ] whileFalse: [ (newSelectionIndex := newSelectionIndex \\ listSize + 1) = startIndex ifTrue: [ ^ self flash"Not in list." ] ]. newSelectionIndex = oldSelectionIndex ifTrue: [ ^ self flash ] ]. (self hasFilter and: [(self getCurrentSelectionIndex = newSelectionIndex) not]) ifTrue: + [self changeModelSelection: newSelectionIndex]! - [self changeModelSelection: newSelectionIndex. priorSelection := newPriorSelection "Probably 0 for filterable lists. Preserve old selection."]! Item was changed: ----- Method: PluggableListMorph>>changeModelSelection: (in category 'model access') ----- changeModelSelection: anInteger " Change the model's selected item index to be anInteger. Enable the pre selection highlight. Step the World forward to let the pre selection highlight take effect. " self rowAboutToBecomeSelected: (self uiIndexFor: anInteger). self refreshWorld. setIndexSelector ifNotNil: [ + model perform: setIndexSelector with: anInteger ].! - model perform: setIndexSelector with: anInteger ]. - priorSelection := anInteger. "Preserve new selection when clearing the filter now."!

1 0

The Trunk: Morphic-mt.1119.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1119.mcz ==================== Summary ==================== Name: Morphic-mt.1119 Author: mt Time: 19 April 2016, 4:03:07.333016 pm UUID: 920dd0b6-e2ab-da4d-81d3-530e1d7ff81b Ancestors: Morphic-mt.1118 Improves stability of filter in lists: 1) Restore prior selection on filter clear 2) Restore prior selection if there are matches (again) 3) Update prior selection of you make a new selection in a filtered list Note that this will still not be propagated between connected lists in, for example, the code browser. While you now will enjoy more stability when filtering the list of methods, filtering the list of system categories might still update/clear all other lists. =============== Diff against Morphic-mt.1118 =============== Item was changed: ----- Method: PluggableListMorph>>basicKeyPressed: (in category 'model access') ----- basicKeyPressed: aChar + | milliseconds slowKeyStroke listSize newSelectionIndex oldSelectionIndex startIndex newPriorSelection | - | milliseconds slowKeyStroke listSize newSelectionIndex oldSelectionIndex startIndex | oldSelectionIndex := newSelectionIndex := self getCurrentSelectionIndex. + + "keep across matches that do not have current selection" + newPriorSelection := priorSelection ifNil: [oldSelectionIndex] ifNotNil: [oldSelectionIndex = 0 ifTrue: [priorSelection] ifFalse: [oldSelectionIndex]]. + listSize := self getListSize. listSize = 0 ifTrue: [ ^self flash ]. milliseconds := Time millisecondClockValue. slowKeyStroke := (Time milliseconds: milliseconds since: lastKeystrokeTime) > (self class filterableLists ifTrue: [500] ifFalse: [ 300 ]). lastKeystrokeTime := milliseconds. slowKeyStroke ifTrue: + [ self class filterableLists ifTrue: [ self hasFilter ifFalse: [ priorSelection := newPriorSelection ] ]. - [ self class filterableLists ifTrue: [ self hasFilter ifFalse: [ priorSelection := self modelIndexFor: self selectionIndex] ]. "forget previous keystrokes and search in following elements" lastKeystrokes := aChar asLowercase asString. newSelectionIndex := newSelectionIndex \\ listSize + 1. self class filterableLists ifTrue: [ list := self getFullList ] ] ifFalse: [ "append quick keystrokes but don't move selection if it still matches" lastKeystrokes := lastKeystrokes , aChar asLowercase asString. newSelectionIndex := newSelectionIndex max: 1 ]. "No change if model is locked" model okToChange ifFalse: [ ^ self ]. self class filterableLists ifTrue: [ self filterList ; updateList. + newSelectionIndex := ((self uiIndexFor: newPriorSelection) > 0) + ifTrue: [newPriorSelection] + ifFalse: [0] ] - newSelectionIndex := self modelIndexFor: 1 ] ifFalse: [ startIndex := newSelectionIndex. listSize := self getListSize. [ (self getListItem: newSelectionIndex) asString withBlanksTrimmed asLowercase beginsWith: lastKeystrokes ] whileFalse: [ (newSelectionIndex := newSelectionIndex \\ listSize + 1) = startIndex ifTrue: [ ^ self flash"Not in list." ] ]. newSelectionIndex = oldSelectionIndex ifTrue: [ ^ self flash ] ]. (self hasFilter and: [(self getCurrentSelectionIndex = newSelectionIndex) not]) ifTrue: + [self changeModelSelection: newSelectionIndex. priorSelection := newPriorSelection "Probably 0 for filterable lists. Preserve old selection."]! - [self changeModelSelection: newSelectionIndex]! Item was changed: ----- Method: PluggableListMorph>>changeModelSelection: (in category 'model access') ----- changeModelSelection: anInteger " Change the model's selected item index to be anInteger. Enable the pre selection highlight. Step the World forward to let the pre selection highlight take effect. " self rowAboutToBecomeSelected: (self uiIndexFor: anInteger). self refreshWorld. setIndexSelector ifNotNil: [ + model perform: setIndexSelector with: anInteger ]. + priorSelection := anInteger. "Preserve new selection when clearing the filter now."! - model perform: setIndexSelector with: anInteger ].!

1 0

The Trunk: MorphicExtras-mt.171.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-mt.171.mcz ==================== Summary ==================== Name: MorphicExtras-mt.171 Author: mt Time: 19 April 2016, 1:06:17.613134 pm UUID: 5f029570-c24b-9f4b-b371-0f70d4f9fcbb Ancestors: MorphicExtras-mt.170 Improves usage of #refreshWorld to avoid direct calls to #displayWorldSafely, which requires a check whether the morph in in a world or not. =============== Diff against MorphicExtras-mt.170 =============== Item was changed: ----- Method: PaintBoxMorph>>eyedropper:action:cursor:evt: (in category 'actions') ----- eyedropper: aButton action: aSelector cursor: aCursor evt: evt "Take total control and pick up a color!!!!" | pt feedbackColor delay | delay := Delay forMilliseconds: 10. aButton state: #on. tool ifNotNil: [tool state: #off]. currentCursor := aCursor. evt hand showTemporaryCursor: currentCursor hotSpotOffset: 6 negated @ 4 negated. "<<<< the form was changed a bit??" feedbackColor := Display colorAt: Sensor cursorPoint. colorMemory align: colorMemory bounds topRight with: colorMemoryThin bounds topRight. self addMorphFront: colorMemory. "Full color picker" [Sensor anyButtonPressed] whileFalse: [pt := Sensor cursorPoint. "deal with the fact that 32 bit displays may have garbage in the alpha bits" feedbackColor := Display depth = 32 ifTrue: [Color colorFromPixelValue: ((Display pixelValueAt: pt) bitOr: 16rFF000000) depth: 32] ifFalse: [Display colorAt: pt]. "the hand needs to be drawn" evt hand position: pt. currentColor ~= feedbackColor ifTrue: [ currentColor := feedbackColor. self showColor ]. + self refreshWorld. - self world displayWorldSafely. delay wait]. "Now wait for the button to be released." [Sensor anyButtonPressed] whileTrue: [ pt := Sensor cursorPoint. "the hand needs to be drawn" evt hand position: pt. + self refreshWorld. - self world displayWorldSafely. delay wait]. evt hand showTemporaryCursor: nil hotSpotOffset: 0 @ 0. self currentColor: feedbackColor evt: evt. colorMemory delete. tool ifNotNil: [tool state: #on. currentCursor := tool arguments third]. aButton state: #off !

1 0

The Trunk: MorphicExtras-mt.170.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-mt.170.mcz ==================== Summary ==================== Name: MorphicExtras-mt.170 Author: mt Time: 19 April 2016, 12:24:14.689049 pm UUID: bca00572-fc6d-074f-8275-88d0c221c2d1 Ancestors: MorphicExtras-cmm.169 Improves usage of #refreshWorld to avoid direct calls to #displayWorldSafely, which requires a check whether the morph in in a world or not. =============== Diff against MorphicExtras-cmm.169 =============== Item was changed: ----- Method: GrabPatchMorph>>justDroppedInto:event: (in category 'dropping') ----- justDroppedInto: aPasteUpMorph event: anEvent "This message is sent to a dropped morph after it has been dropped on--and been accepted by--a drop-sensitive morph" + super justDroppedInto: aPasteUpMorph event: anEvent. + + aPasteUpMorph isPartsBin ifFalse: [ + "Do not show this morph in the screenshot." + self hide. + anEvent hand hide. + self refreshWorld. + + [aPasteUpMorph grabDrawingFromScreen: anEvent] + ensure: [anEvent hand show]]. + + "Just needed for this operation. Remove." + self delete.! - aPasteUpMorph isPartsBin ifFalse: - [self delete. - ActiveWorld displayWorldSafely; runStepMethods. "But the HW cursor stays up still ???" - ^ aPasteUpMorph grabDrawingFromScreen: anEvent]. - ^ super justDroppedInto: aPasteUpMorph event: anEvent! Item was changed: ----- Method: LassoPatchMorph>>justDroppedInto:event: (in category 'dropping') ----- justDroppedInto: aPasteUpMorph event: anEvent "This message is sent to a dropped morph after it has been dropped on--and been accepted by--a drop-sensitive morph" + super justDroppedInto: aPasteUpMorph event: anEvent. + + aPasteUpMorph isPartsBin ifFalse: [ + "Do not show this morph in the screenshot." + self hide. + anEvent hand hide. + self refreshWorld. + + [aPasteUpMorph grabLassoFromScreen: anEvent] + ensure: [anEvent hand show]]. + + "Just needed for this operation. Remove." + self delete.! - aPasteUpMorph isPartsBin ifFalse: - [self delete. - ActiveWorld displayWorldSafely; runStepMethods. - ^ aPasteUpMorph grabLassoFromScreen: anEvent]. - ^ super justDroppedInto: aPasteUpMorph event: anEvent!

1 0

The Trunk: EToys-mt.134.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.134.mcz ==================== Summary ==================== Name: EToys-mt.134 Author: mt Time: 19 April 2016, 12:22:02.288049 pm UUID: e2ced620-3a65-1f48-a57d-65709f3e2656 Ancestors: EToys-mt.133 Improves usage of #refreshWorld to avoid direct calls to #displayWorldSafely, which requires a check whether the morph in in a world or not. =============== Diff against EToys-mt.133 =============== Item was changed: ----- Method: EToyCommunicatorMorph>>resetIndicator: (in category 'as yet unclassified') ----- resetIndicator: aSymbol | indicator firstColor | indicator := fields at: aSymbol ifAbsent: [^self]. firstColor := indicator valueOfProperty: #firstColor ifAbsent: [^self]. indicator color: firstColor. + self refreshWorld. - self world displayWorldSafely. ! Item was changed: ----- Method: EToyCommunicatorMorph>>trulyFlashIndicator: (in category 'as yet unclassified') ----- trulyFlashIndicator: aSymbol | indicator firstColor | indicator := fields at: aSymbol ifAbsent: [^self]. firstColor := indicator valueOfProperty: #firstColor ifAbsent: [ indicator setProperty: #firstColor toValue: indicator color. indicator color ]. indicator color: (indicator color = firstColor ifTrue: [Color white] ifFalse: [firstColor]). + self refreshWorld. - self world displayWorldSafely. ! Item was changed: ----- Method: EToyProjectHistoryMorph>>closeMyFlapIfAny (in category 'as yet unclassified') ----- closeMyFlapIfAny | myFlap allTabs myTab myWorld | myWorld := self world. myFlap := self nearestOwnerThat: [ :each | each isFlap]. myFlap ifNil: [^self]. allTabs := myWorld submorphs select: [ :each | each isFlapTab]. myTab := allTabs detect: [ :each | each referent == myFlap] ifNone: [^self]. myTab hideFlap. + self refreshWorld. - myWorld displayWorldSafely. !

1 0

The Trunk: Morphic-mt.1118.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1118.mcz ==================== Summary ==================== Name: Morphic-mt.1118 Author: mt Time: 19 April 2016, 12:19:58.032049 pm UUID: 1b5b0494-89bc-aa46-a621-403a2aaf6cd3 Ancestors: Morphic-mt.1117 Improves documentation and usage of #refreshWorld to avoid direct calls to #displayWorldSafely, which requires a check whether the morph in in a world or not. =============== Diff against Morphic-mt.1117 =============== Item was changed: ----- Method: Morph>>flash (in category 'macpal') ----- flash | originalColor | originalColor := self color. [ self color: (originalColor ifNil: [ Color black ] ifNotNil: [( (originalColor alpha: 1) adjustSaturation: 0.8 brightness: 0) negated ]) ] ensure: + [ self refreshWorld. - [ self world ifNotNil: [ : w | w displayWorldSafely ]. self color: originalColor ]! Item was changed: ----- Method: Morph>>refreshWorld (in category 'drawing') ----- refreshWorld + "If this morph is in a world, refresh the world. This can be used to immediately redraw a morph after it changed. Note that you should use this call rather sparsely because it bypasses Morphics damage recording mechanism." + + self world ifNotNil: [:w | w displayWorldSafely].! - | aWorld | - (aWorld := self world) ifNotNil: [aWorld displayWorldSafely] - ! Item was changed: ----- Method: PluggableListMorph>>changeModelSelection: (in category 'model access') ----- changeModelSelection: anInteger " Change the model's selected item index to be anInteger. Enable the pre selection highlight. Step the World forward to let the pre selection highlight take effect. " self rowAboutToBecomeSelected: (self uiIndexFor: anInteger). + self refreshWorld. - World displayWorldSafely. setIndexSelector ifNotNil: [ model perform: setIndexSelector with: anInteger ].! Item was changed: ----- Method: SVColorSelectorMorph>>hideLocation (in category 'as yet unclassified') ----- hideLocation "Hide the location morph and update the display." self locationMorph visible: false. + self refreshWorld.! - World displayWorldSafely.! Item was changed: ----- Method: SVColorSelectorMorph>>showLocation (in category 'as yet unclassified') ----- showLocation "Show the location morph and update the display." self locationMorph visible: true. + self refreshWorld.! - World displayWorldSafely.!

1 0

The Trunk: Morphic-mt.1117.mcz
by commits＠source.squeak.org 19 Apr '16

19 Apr '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1117.mcz ==================== Summary ==================== Name: Morphic-mt.1117 Author: mt Time: 19 April 2016, 11:43:17.879049 am UUID: dfe3d794-df51-2f47-abef-00885c576f46 Ancestors: Morphic-mt.1116 Fixes return values of enclose feature. Only return true if you perfomed an edit operation. =============== Diff against Morphic-mt.1116 =============== Item was changed: ----- Method: TextEditor>>enclose: (in category 'editing keys') ----- enclose: aKeyboardEvent "Insert or remove bracket characters around the current selection." | character left right startIndex stopIndex oldSelection which t | character := aKeyboardEvent shiftPressed ifTrue: ['{}|"<>' at: ('[]\'',.' indexOf: aKeyboardEvent keyCharacter) ifAbsent: [aKeyboardEvent keyCharacter]] ifFalse: [aKeyboardEvent keyCharacter]. self closeTypeIn. startIndex := self startIndex. stopIndex := self stopIndex. oldSelection := self selection. + which := '([<{|"''9' indexOf: character ifAbsent: [ ^ false ]. - which := '([<{|"''9' indexOf: character ifAbsent: [ ^false ]. "Allow Control key in lieu of Alt+Shift for (, {, and double-quote." left := ((Preferences cmdKeysInText and: [ aKeyboardEvent controlKeyPressed ]) ifTrue: [ '({<{|""(' ] ifFalse: ['([<{|"''(']) at: which. right := ((Preferences cmdKeysInText and: [ aKeyboardEvent controlKeyPressed ]) ifTrue: [ ')}>}|"")' ] ifFalse: [')]>}|"'')']) at: which. t := self text. ((startIndex > 1 and: [stopIndex <= t size]) and: [ (t at: startIndex-1) = left and: [(t at: stopIndex) = right]]) ifTrue: [ "already enclosed; strip off brackets" self selectFrom: startIndex-1 to: stopIndex. + self replaceSelectionWith: oldSelection. + ^ true] - self replaceSelectionWith: oldSelection] ifFalse: [ "not enclosed; enclose by matching brackets" self replaceSelectionWith: (Text string: (String with: left), oldSelection string, (String with: right) attributes: emphasisHere). + self selectFrom: startIndex+1 to: stopIndex. + ^ true]. + ^ false! - self selectFrom: startIndex+1 to: stopIndex]. - ^true!

1 0

Re: [squeak-dev] The Trunk: Tools-mt.690.mcz
by Chris Muller 19 Apr '16

19 Apr '16

I'm sorry Marcel, but I developed the behaviors of TracingMessagesBrowser with great deliberation and care. If you wish to make alteratiuons, would you please collaborate with me? As it stands, this change to my code from Y2002 is very unwelcome and I've rolled it back. Let's talk. traceMessages is not something the user is going to be flipping on and off, so there is no need for a _constant_ indication reminder of which "mode' they're in. I don't know what you're trying to fix, but I cannot stand this new clutter. Sorry. Maybe a different color window is what you want? Even that seems unnecessary, as the system simply responds appropriately to all requests for senders and implementors by doing what the user wants for each scenario. the user doesn't need to "read", in advance, what the system will do, just not surprise them. Nothing about traceMessages does. On Sun, Apr 17, 2016 at 5:00 AM, <commits(a)source.squeak.org> wrote: > Marcel Taeumel uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-mt.690.mcz > > ==================== Summary ==================== > > Name: Tools-mt.690 > Author: mt > Time: 17 April 2016, 12:00:40.266542 pm > UUID: d4a2a77e-d3cf-7c49-8685-096e8f7ff578 > Ancestors: Tools-cmm.689 > > Make the message trace tools more obvious to avoid applying a wrong user model. Regular message set and traced message set behave differently considering mouse clicks, keyboard shortcuts, etc. > There is a preference traceMessage to switch between traditional senders/implementors and the traced versions. > > =============== Diff against Tools-cmm.689 =============== > > Item was changed: > ----- Method: MessageTrace>>windowLabelAt: (in category 'private accessing') ----- > windowLabelAt: anInteger > > | str | > ^(str := autoSelectStrings at: anInteger) > ifNil: > + [ 'Traced Implementors of ', > - [ 'Implementors of ', > (self class > parse: self selection > toClassAndSelector: [ :class :selector | selector ]) ] > ifNotNil: > + [ 'Traced Senders of ', str ] > - [ 'Senders of ', str ] > ! > > Item was changed: > ----- Method: StandardToolSet class>>browseMessageSet:name:autoSelect: (in category 'browsing') ----- > browseMessageSet: messageList name: title autoSelect: autoSelectString > "Open a message set or message-trace browser, depending on the #traceMessages setting." > ^ Preferences traceMessages > ifTrue: > [ MessageTrace > openMessageList: messageList > + name: 'Traced ', title > - name: title > autoSelect: autoSelectString ] > ifFalse: > [ MessageSet > openMessageList: messageList > name: title > autoSelect: autoSelectString ]! > >

6 10

← Newer
1
...
4
5
6
7
8
9
10
...
25
Older →

Jump to page: