Squeak-dev March 2016

squeak-dev@lists.squeakfoundation.org

31 participants
150 discussions

Start a nNew thread

The Trunk: Kernel-eem.1005.mcz
by commits＠source.squeak.org 09 Mar '16

09 Mar '16

1 0

Re: [Pharo-dev] strange array instance
by Eliot Miranda 09 Mar '16

09 Mar '16

Hi Pavel, On Tue, Mar 8, 2016 at 1:40 AM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > Hi, > > there is a strange array of size 1024 in the Pharo image that is not eaten > by garbage collector even if no object points to it. I guess it is related > to Spur. > > ((Array allInstances select: [ :i | i size = 1024 ]) > select: [ :a | a second = SmallInteger ]) pointersTo > > What is it and is it accessible somehow? > It is indeed the first class table page. It looks like an old bug. The oldest Spur image I can start up has the problem. The way that class table pages are hidden is that they have a class index which is not that of Array. Array is at index 52 in the class table (51 zero-relative, Array identityHash = 51), but it is also at index 17 (16 zero-relative). Array allInstances looks for objects whose class index is 51, hence not seeing the class table pages, which all (but the first) have class index 16. Luckily we can fix the problem easily, and we can fix another problem at the same time, which is that SmallFloat64 has the wrong hash. The class table is two-level; a (hidden) array of Arrays. Classes are in the class table at their identityHashes (so that to instantiate a class one copies the class's identity hash into the classIndex of the new instance instead of having to search the class table). But when SmallFloat64 was created in the 32-bit image I forgot to give it the right hash and store it in the class table. (there are no SmallFloat64 instances in a 32-bit image, only in 64-bits). So we can first change SmallFloat64's hash to 3, which is what the Spur 64-bit VM and image require, and enter it into the first class table page, and then we can make the first class table page disappear. | firstClassTablePage clone | "The first class table page is the first Array instance. Of course this is a bug." firstClassTablePage := Array someInstance. "It should contain only nil and classes." self assert: (firstClassTablePage allSatisfy: [:e| e == nil or: [e isBehavior]]). "And its first 17 elements should only be the immediate classes and Array, since Array is used as the class pun for class table pages, with index 17 (16 zero-relative)" self assert: (firstClassTablePage first: 17) asSet = {nil. SmallInteger. Character. Array} asSet. "It just so happens that the second Array is the specialSelectors" self assert: Array someInstance nextInstance == Smalltalk specialSelectors. "Store SmallFloat64 in the first class table page at index 4 (3 zero-relative)." firstClassTablePage at: 4 put: SmallFloat64. "Use the secret set identity hash primitive to set SmallFloat64's identityHash to 3." SmallFloat64 tryPrimitive: 161 withArgs: #(3). "Now create an object that looks like Array class, but has identityHash 16." "Take a shallow copy of Array class." clone := Array shallowCopy. "Change it into an Array." Array adoptInstance: clone. "Set its identityHash to 16." clone tryPrimitive: 161 withArgs: #(16). "Use the adoptInstance: primitive to ``set the class of the firstClassTablePage to the cone''. or, more accurately, to set the firstClassTablePage's class index to 16." clone tryPrimitive: 160 withArgs: {firstClassTablePage} With the above done, we can check that everything is ok." self assert: SmallFloat64 identityHash = 3. self assert: Array someInstance == Smalltalk specialSelectors. "A class table page is 1024 slots, contains only nil or behaviours, and contains at least one behaviour (is not all nils). There shouldn't be any that we can find." self assert: (self systemNavigation allObjects select: [:o| o isArray and: [o size = 1024 and: [(o allSatisfy: [:e| e == nil or: [e isBehavior]]) and: [o anySatisfy: [:e| e isBehavior]]]]]) size = 0 I recommend you create an update map. Then create a version of kernel with a post-load action, written something like this: (Array someInstance size = 1014 and: [(Array someInstance allSatisfy: [:e| e == nil or: [e isBehavior]]) and: [(firstClassTablePage first: 17) asSet = {nil. SmallInteger. Character. Array} asSet]]) ifTrue: [| firstClassTablePage clone | firstClassTablePage := Array someInstance. self assert: (firstClassTablePage allSatisfy: [:e| e == nil or: [e isBehavior]]). self assert: (firstClassTablePage first: 17) asSet = {nil. SmallInteger. Character. Array} asSet. firstClassTablePage at: 4 put: SmallFloat64. SmallFloat64 tryPrimitive: 161 withArgs: #(3). clone := Array shallowCopy. Array adoptInstance: clone. clone tryPrimitive: 161 withArgs: #(16). clone tryPrimitive: 160 withArgs: {Array someInstance} self assert: SmallFloat64 identityHash = 3. self assert: (Array someInstance first: 4) = {nil. SmallInteger. Character. SmallFloat64}] Then create a second update map to ensure that that version of Kernel is loaded. I will do this for Squeak immediately. Apologies. P.S. Interestingly enough, it shows what a horrible security hole the debugger primitives tryPrimitive:withArgs: and tryNamedPrimitive:withArgs: are. Cheers, > -- Pavel > _,,,^..^,,,_ best, Eliot

2 4

Preferences revamp?
by Chris Muller 09 Mar '16

09 Mar '16

The discussion of Preferences came up in our board meeting last week. Clearly, Preferences is something that serves Squeak and our community, due to the amazing range of system configurability they provide, allowing the system to be tailored to any user-style and purpose. However, I feel that the Preferences framework itself does not do everything I want it to do. These are the minimum requirements I think our Preferences system should be able to do: 1) it must have a first-class model (which it already does) Preferences and Preference. All of the following requirements must be able to be satisfied by talking strictly to this model, (no required browsers or sends to outside classes) with uniform API usage regardless whether the underlying implementation (Pragma or otherwise). 2) Answer a collection of all Preference objects representing the current system settings. 3) Ability to access any single Preference object by its Symbolic name. (We want to maintain the standard Smalltalk "senders" being able to easily find users of preferences by their name). 4) Ability to ask any Preference its default value, without resetting its current value. 5) Ability to reset any Preference to its default value, another fixed value, or cycle from its current value to its next value. 6) Answer a collection of Preference objects representing the default system settings, without changing any current Preference settings. 7) Answer a collection of the diff between (2) and (6), above, without changing the current value of any preferences. 7.5) Ability for a Preference to answer literal structure (key->value) that can be used as input for requirement 7.6. 7.6) Ability to construct or set a particular Preference to value from a libteral specification. NOTE: 7.5 and 7.6 are to support ReleaseBuilder defaultValueTableForCurrentRelease. 8) Ability to Save / Load entire sets of preferences. But it must be a _Logical_ representation of the value so it will work for all future Squeaks. 9) (Nice-to-have --->) Ability to Save / Load partial sets of preferences, leaving remaining preferences unchanged. 10) Last but not least: External applications must be able to seamlessly and dynamically extend the system with their own Preference objects and have all the above requirements satisfied for them. Maybe its just because I'm an old-school Smalltalker who prefers to do everything in objects; but I just have this feeling that the Pragma implementation we have been using, in spite of its complexity, is really limiting us, certainly in terms of my above requirements wishlist, right? Like, #7, for example... OTOH, one thing that became very clear from working on the Theme ideas with Karl and Marcel, is that that is very related to Preferences, and behaves very much like a preferences system. I believe it could be used for the non-visual preferences, too..

5 6

Re: [squeak-dev] The Trunk: Kernel-eem.1005.mcz
by Eliot Miranda 09 Mar '16

09 Mar '16

Hi All, a grovelling apology. I have committed a serious blunder in Kernel-eem.1005.mcz. Rather than potentially corrupt images (although this is unlikely) I have chosen to delete Kernel-eem.1005.mcz. This will break updates until I commit a corrected version. But it's too late at night here for me to fix it now. I'll fix it asap tomorrow am. I could do with a good nights sleep ;-) _,,,^..^,,,_ (phone) > On Mar 8, 2016, at 7:19 PM, commits(a)source.squeak.org wrote: > > Eliot Miranda uploaded a new version of Kernel to project The Trunk: > http://source.squeak.org/trunk/Kernel-eem.1005.mcz > > ==================== Summary ==================== > > Name: Kernel-eem.1005 > Author: eem > Time: 8 March 2016, 1:16:26.313983 pm > UUID: e11ad532-fefb-4f2e-836a-dc40b7d93447 > Ancestors: Kernel-bf.1004 > > Add a script to make sure that > a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and > b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun. > > =============== Diff against Kernel-bf.1004 =============== > > Item was removed: > - (PackageInfo named: 'Kernel') preamble: '((Mutex allInstances allSatisfy: [:m| (m instVarNamed: ''owner'') isNil]) > - and: [Monitor allInstances allSatisfy: [:m| (m instVarNamed: ''ownerProcess'') isNil]]) ifFalse: > - [self error: ''Some Mutexes and/or Monitors are owned. Cannot safely mutate. ABort load and resolve this before loading for safety.'']'! > > Item was changed: > + (PackageInfo named: 'Kernel') postscript: '"below, add code to be run after the loading of this package" > + > + "Make sure that > + a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and > + b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun." > + (Array someInstance size = 1024 > + and: [(Array someInstance allSatisfy: [:e| e == nil or: [e isBehavior]]) > + and: [(Array someInstance first: 17) asSet = {nil. SmallInteger. Character. Array} asSet]]) ifTrue: > + [| firstClassTablePage clone | > + firstClassTablePage := Array someInstance. > + self assert: (firstClassTablePage allSatisfy: [:e| e == nil or: [e isBehavior]]). > + self assert: (firstClassTablePage first: 17) asSet = {nil. SmallInteger. Character. Array} asSet. > + firstClassTablePage at: 4 put: SmallFloat64. > + SmallFloat64 tryPrimitive: 161 withArgs: #(3). > + clone := Array shallowCopy. > + Array adoptInstance: clone. > + clone tryPrimitive: 161 withArgs: #(16). > + clone tryPrimitive: 160 withArgs: {firstClassTablePage}. > + self assert: SmallFloat64 identityHash = 3. > + self assert: (firstClassTablePage first: 4) = {nil. SmallInteger. Character. SmallFloat64}]'! > - (PackageInfo named: 'Kernel') postscript: 'Smalltalk removeFromStartUpList: DateAndTime.'! > >

3 2

[BUG] Commented out do it's don't work from context menu
by karl ramberg 09 Mar '16

09 Mar '16

Bug with a commented out 'do it' like "Preferences inspectPreferences" If you select and select do it from context menu the screen blinks. Ctrl+d works fine. Best, Karl

2 2

Daily Commit Log
by commits＠source.squeak.org 08 Mar '16

08 Mar '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-March/009482.html Name: Collections-ul.679 Ancestors: Collections-eem.678 #occurrencesOf: revamp: - optimized Bag's implementation - added optimized versions to ArrayedCollection, String and ByteArray ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-March/009483.html Name: Kernel-eem.1005 Ancestors: Kernel-bf.1004 Add a preamble script to make sure that a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun. Check the above has happened in the postscript. ==== ERROR === Error: Unrecognized class definition 8 March 2016 8:54:15.015 pm VM: unix - a SmalltalkImage Image: Squeak3.11alpha [latest update: #8824] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /home/squeaksource Trusted Dir /home/squeaksource/secure Untrusted Dir /home/squeaksource/My Squeak MCStReader(Object)>>error: Receiver: a MCStReader Arguments and temporary variables: aString: 'Unrecognized class definition' Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... MCStReader>>typeOfSubclass: Receiver: a MCStReader Arguments and temporary variables: aSymbol: #immediateSubclass: Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... MCStReader>>classDefinitionFrom: Receiver: a MCStReader Arguments and temporary variables: aPseudoClass: a PseudoClass(#SmallFloat64) tokens: #(#Float #immediateSubclass: #SmallFloat64 #instanceVariableNames: '' #...etc... traitCompositionString: '{}' lastIndex: 11 classTraitCompositionString: '{}' Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... [] in MCStReader>>loadDefinitions Receiver: a MCStReader Arguments and temporary variables: filePackage: a PseudoClass(#SmallFloat64) pseudoClass: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... --- The full stack --- MCStReader(Object)>>error: MCStReader>>typeOfSubclass: MCStReader>>classDefinitionFrom: [] in MCStReader>>loadDefinitions - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - [] in Dictionary>>valuesDo: Dictionary>>associationsDo: Dictionary>>valuesDo: Dictionary>>do: MCStReader>>loadDefinitions MCStReader(MCSnapshotReader)>>definitions [] in MCMczReader>>extractDefinitionsFrom: MCStReader class(Object)>>ifNotNilDo: MCMczReader>>extractDefinitionsFrom: [] in MCMczReader>>loadDefinitions OrderedCollection>>do: MCMczReader>>loadDefinitions MCMczReader(MCVersionReader)>>definitions MCMczReader(MCVersionReader)>>snapshot [] in SSDiffyTextWriter>>writeVersion:for: BlockClosure>>on:do: SSDiffyTextWriter>>writeVersion:for: [] in SSEMailSubscription>>versionAdded:to: BlockClosure>>on:do: SSEMailSubscription>>versionAdded:to: [] in [] in SSProject>>versionAdded: [] in BlockClosure>>newProcess Previous message: [Pkg] The Trunk: Collections-ul.679.mcz Next message: [Pkg] The Trunk: Kernel-eem.1005.mcz Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] More information about the Packages mailing list ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-March/009484.html Name: Kernel-eem.1005 Ancestors: Kernel-bf.1004 Add a script to make sure that a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun. =============================================

1 0

The Trunk: Kernel-eem.1005.mcz
by commits＠source.squeak.org 08 Mar '16

08 Mar '16

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1005.mcz ==================== Summary ==================== Name: Kernel-eem.1005 Author: eem Time: 8 March 2016, 1:16:26.313983 pm UUID: e11ad532-fefb-4f2e-836a-dc40b7d93447 Ancestors: Kernel-bf.1004 Add a script to make sure that a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun. =============== Diff against Kernel-bf.1004 =============== Item was removed: - (PackageInfo named: 'Kernel') preamble: '((Mutex allInstances allSatisfy: [:m| (m instVarNamed: ''owner'') isNil]) - and: [Monitor allInstances allSatisfy: [:m| (m instVarNamed: ''ownerProcess'') isNil]]) ifFalse: - [self error: ''Some Mutexes and/or Monitors are owned. Cannot safely mutate. ABort load and resolve this before loading for safety.'']'! Item was changed: + (PackageInfo named: 'Kernel') postscript: '"below, add code to be run after the loading of this package" + + "Make sure that + a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and + b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun." + (Array someInstance size = 1024 + and: [(Array someInstance allSatisfy: [:e| e == nil or: [e isBehavior]]) + and: [(Array someInstance first: 17) asSet = {nil. SmallInteger. Character. Array} asSet]]) ifTrue: + [| firstClassTablePage clone | + firstClassTablePage := Array someInstance. + self assert: (firstClassTablePage allSatisfy: [:e| e == nil or: [e isBehavior]]). + self assert: (firstClassTablePage first: 17) asSet = {nil. SmallInteger. Character. Array} asSet. + firstClassTablePage at: 4 put: SmallFloat64. + SmallFloat64 tryPrimitive: 161 withArgs: #(3). + clone := Array shallowCopy. + Array adoptInstance: clone. + clone tryPrimitive: 161 withArgs: #(16). + clone tryPrimitive: 160 withArgs: {firstClassTablePage}. + self assert: SmallFloat64 identityHash = 3. + self assert: (firstClassTablePage first: 4) = {nil. SmallInteger. Character. SmallFloat64}]'! - (PackageInfo named: 'Kernel') postscript: 'Smalltalk removeFromStartUpList: DateAndTime.'!

1 0

Re: [squeak-dev] The Trunk: Kernel-eem.1005.mcz
by Eliot Miranda 08 Mar '16

08 Mar '16

F**k. I have broken things. I realise now that the preamble script is run before loading, but is /not/ run when simply updating. So the scrupt that does the surgery needs to be in the postload. I'll fix this asap. On Tue, Mar 8, 2016 at 12:53 PM, <commits(a)source.squeak.org> wrote: > Eliot Miranda uploaded a new version of Kernel to project The Trunk: > http://source.squeak.org/trunk/Kernel-eem.1005.mcz > > ==================== Summary ==================== > > Name: Kernel-eem.1005 > Author: eem > Time: 8 March 2016, 12:52:58.152073 pm > UUID: b570ba5a-517f-4ac1-8bae-f328843a7cff > Ancestors: Kernel-bf.1004 > > Add a preamble script to make sure that > a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, > zero-relative) slot of the first class table page, and > b) that the first class table page is hidden by ensuring its class index > is 16, the Array class index pun. > > Check the above has happened in the postscript. > > ==== ERROR === > > Error: Unrecognized class definition > > 8 March 2016 8:54:15.015 pm > > VM: unix - a SmalltalkImage > Image: Squeak3.11alpha [latest update: #8824] > > SecurityManager state: > Restricted: false > FileAccess: true > SocketAccess: true > Working Dir /home/squeaksource > Trusted Dir /home/squeaksource/secure > Untrusted Dir /home/squeaksource/My Squeak > > MCStReader(Object)>>error: > Receiver: a MCStReader > Arguments and temporary variables: > aString: 'Unrecognized class definition' > Receiver's instance variables: > stream: a ReadStream > definitions: an OrderedCollection(a > MCClassDefinition(Integer) a MCMethodDefini...etc... > > MCStReader>>typeOfSubclass: > Receiver: a MCStReader > Arguments and temporary variables: > aSymbol: #immediateSubclass: > Receiver's instance variables: > stream: a ReadStream > definitions: an OrderedCollection(a > MCClassDefinition(Integer) a MCMethodDefini...etc... > > MCStReader>>classDefinitionFrom: > Receiver: a MCStReader > Arguments and temporary variables: > aPseudoClass: a PseudoClass(#SmallFloat64) > tokens: #(#Float #immediateSubclass: #SmallFloat64 > #instanceVariableNames: '' #...etc... > traitCompositionString: '{}' > lastIndex: 11 > classTraitCompositionString: '{}' > Receiver's instance variables: > stream: a ReadStream > definitions: an OrderedCollection(a > MCClassDefinition(Integer) a MCMethodDefini...etc... > > [] in MCStReader>>loadDefinitions > Receiver: a MCStReader > Arguments and temporary variables: > filePackage: a PseudoClass(#SmallFloat64) > pseudoClass: an OrderedCollection(a > MCClassDefinition(Integer) a MCMethodDefini...etc... > Receiver's instance variables: > stream: a ReadStream > definitions: an OrderedCollection(a > MCClassDefinition(Integer) a MCMethodDefini...etc... > > > --- The full stack --- > MCStReader(Object)>>error: > MCStReader>>typeOfSubclass: > MCStReader>>classDefinitionFrom: > [] in MCStReader>>loadDefinitions > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > [] in Dictionary>>valuesDo: > Dictionary>>associationsDo: > Dictionary>>valuesDo: > Dictionary>>do: > MCStReader>>loadDefinitions > MCStReader(MCSnapshotReader)>>definitions > [] in MCMczReader>>extractDefinitionsFrom: > MCStReader class(Object)>>ifNotNilDo: > MCMczReader>>extractDefinitionsFrom: > [] in MCMczReader>>loadDefinitions > OrderedCollection>>do: > MCMczReader>>loadDefinitions > MCMczReader(MCVersionReader)>>definitions > MCMczReader(MCVersionReader)>>snapshot > [] in SSDiffyTextWriter>>writeVersion:for: > BlockClosure>>on:do: > SSDiffyTextWriter>>writeVersion:for: > [] in SSEMailSubscription>>versionAdded:to: > BlockClosure>>on:do: > SSEMailSubscription>>versionAdded:to: > [] in [] in SSProject>>versionAdded: > [] in BlockClosure>>newProcess > > -- _,,,^..^,,,_ best, Eliot

1 0

The Trunk: Kernel-eem.1005.mcz
by commits＠source.squeak.org 08 Mar '16

08 Mar '16

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1005.mcz ==================== Summary ==================== Name: Kernel-eem.1005 Author: eem Time: 8 March 2016, 12:52:58.152073 pm UUID: b570ba5a-517f-4ac1-8bae-f328843a7cff Ancestors: Kernel-bf.1004 Add a preamble script to make sure that a) SmallFloat64 has identityHash 3 and occupies the 4th (3rd, zero-relative) slot of the first class table page, and b) that the first class table page is hidden by ensuring its class index is 16, the Array class index pun. Check the above has happened in the postscript. ==== ERROR === Error: Unrecognized class definition 8 March 2016 8:54:15.015 pm VM: unix - a SmalltalkImage Image: Squeak3.11alpha [latest update: #8824] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /home/squeaksource Trusted Dir /home/squeaksource/secure Untrusted Dir /home/squeaksource/My Squeak MCStReader(Object)>>error: Receiver: a MCStReader Arguments and temporary variables: aString: 'Unrecognized class definition' Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... MCStReader>>typeOfSubclass: Receiver: a MCStReader Arguments and temporary variables: aSymbol: #immediateSubclass: Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... MCStReader>>classDefinitionFrom: Receiver: a MCStReader Arguments and temporary variables: aPseudoClass: a PseudoClass(#SmallFloat64) tokens: #(#Float #immediateSubclass: #SmallFloat64 #instanceVariableNames: '' #...etc... traitCompositionString: '{}' lastIndex: 11 classTraitCompositionString: '{}' Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... [] in MCStReader>>loadDefinitions Receiver: a MCStReader Arguments and temporary variables: filePackage: a PseudoClass(#SmallFloat64) pseudoClass: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... Receiver's instance variables: stream: a ReadStream definitions: an OrderedCollection(a MCClassDefinition(Integer) a MCMethodDefini...etc... --- The full stack --- MCStReader(Object)>>error: MCStReader>>typeOfSubclass: MCStReader>>classDefinitionFrom: [] in MCStReader>>loadDefinitions - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - [] in Dictionary>>valuesDo: Dictionary>>associationsDo: Dictionary>>valuesDo: Dictionary>>do: MCStReader>>loadDefinitions MCStReader(MCSnapshotReader)>>definitions [] in MCMczReader>>extractDefinitionsFrom: MCStReader class(Object)>>ifNotNilDo: MCMczReader>>extractDefinitionsFrom: [] in MCMczReader>>loadDefinitions OrderedCollection>>do: MCMczReader>>loadDefinitions MCMczReader(MCVersionReader)>>definitions MCMczReader(MCVersionReader)>>snapshot [] in SSDiffyTextWriter>>writeVersion:for: BlockClosure>>on:do: SSDiffyTextWriter>>writeVersion:for: [] in SSEMailSubscription>>versionAdded:to: BlockClosure>>on:do: SSEMailSubscription>>versionAdded:to: [] in [] in SSProject>>versionAdded: [] in BlockClosure>>newProcess

1 0

The Trunk: Collections-ul.679.mcz
by commits＠source.squeak.org 08 Mar '16

08 Mar '16

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.679.mcz ==================== Summary ==================== Name: Collections-ul.679 Author: ul Time: 8 March 2016, 5:24:30.010047 pm UUID: 9f4b6193-4632-48c7-a99f-ee37923bf28b Ancestors: Collections-eem.678 #occurrencesOf: revamp: - optimized Bag's implementation - added optimized versions to ArrayedCollection, String and ByteArray =============== Diff against Collections-eem.678 =============== Item was added: + ----- Method: ArrayedCollection>>occurrencesOf: (in category 'testing') ----- + occurrencesOf: anObject + "Answer how many of the receiver's elements are equal to anObject. Optimized version." + + | tally | + tally := 0. + 1 to: self size do: [ :index | + (self at: index) = anObject ifTrue: [ tally := tally + 1 ] ]. + ^tally! Item was changed: ----- Method: Bag>>occurrencesOf: (in category 'testing') ----- + occurrencesOf: anObject + "Answer how many of the receiver's elements are equal to anObject. Optimized version." - occurrencesOf: anObject - "Refer to the comment in Collection|occurrencesOf:." + ^contents at: anObject ifAbsent: 0! - (self includes: anObject) - ifTrue: [^contents at: anObject] - ifFalse: [^0]! Item was added: + ----- Method: ByteArray>>occurrencesOf: (in category 'as yet unclassified') ----- + occurrencesOf: anObject + "Answer how many of the receiver's elements are equal to anObject. Optimized version." + + | tally | + anObject isInteger ifFalse: [ ^0 ]. + anObject negative ifTrue: [ ^0 ]. + anObject > 255 ifTrue: [ ^0 ]. + tally := 0. + 1 to: self size do: [ :index | + (self at: index) = anObject ifTrue: [ tally := tally + 1 ] ]. + ^tally! Item was added: + ----- Method: String>>occurrencesOf: (in category 'testing') ----- + occurrencesOf: anObject + "Answer how many of the receiver's elements are equal to anObject. Optimized version." + + | tally | + anObject isCharacter ifFalse: [ ^0 ]. + tally := 0. + 1 to: self size do: [ :index | + (self at: index) == anObject ifTrue: [ tally := tally + 1 ] ]. + ^tally!

1 0

← Newer
1
...
9
10
11
12
13
14
15
Older →

Jump to page: