Squeak-dev February 2016

squeak-dev@lists.squeakfoundation.org

28 participants
207 discussions

And another thing; updating broken by recent time fetching upheaval
by tim Rowledge 23 Feb '16

23 Feb '16

Whilst trying to update as part of seeing if my prior ‘Rather important bug’ mail had been fixed recently, I find that it breaks after loading 51Deprecated-bf.18 and during loading Graphics-tfel.326 because "MessageNotUnderstood: Time class>>localMicrosecondClockWithOffset”. And even if was understood, it turns out that DateAndTime class>now:offset: doesn’t exist yet either. So I’m guessing something might possibly be wonrg. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: CDC: Clear Disks and Crash

5 13

Rather important bug: corrected source is not saved
by tim Rowledge 23 Feb '16

23 Feb '16

Using recent 5.0 images - including one updated a day or two ago to 15632 - if I attempt to save a method with a typo the compiler catches it and provides the usual menu of likely options etc. Choosing one, as expected, lets the compile proceed and all seems well. Except that the code saved to the changes is still wrong! Which means you have code that runs and may pass your tests, but when you save it to pass around it is *wrong*. This is a *really bad thing*. It means you can be confident that code is working and still end up distributing fatal errors! An original 5.0-15133 image manages to get it right, so who has been mangling the compiler stuff recently? I have a 15566 update image where it goes wrong. And I have a 15603 where it fails, but that’s as precise as I can get now. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful random insult:- Suffers from Clue Deficit Disorder.

2 6

The Trunk: ToolBuilder-Morphic-kfr.159.mcz
by commits＠source.squeak.org 23 Feb '16

23 Feb '16

Karl Ramberg uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-kfr.159.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-kfr.159 Author: kfr Time: 23 February 2016, 7:26:26.083047 am UUID: 002ef0f2-6e60-4571-a4c2-eb465843582b Ancestors: ToolBuilder-Morphic-mt.158 Caused a issue with saving sources Reverting to old version =============== Diff against ToolBuilder-Morphic-mt.158 =============== Item was changed: ----- Method: PluggableTextMorphPlus>>okToStyle (in category 'testing') ----- okToStyle + ^ styler - ^ styler ifNil:[false] + ifNotNil: [:s | model aboutToStyle: s]! - ifNotNil: [:s | s class syntaxHighlightingAsYouType - ifTrue:[model aboutToStyle: s] - ifFalse:[false]]!

1 0

The Trunk: 51Deprecated-bf.19.mcz
by commits＠source.squeak.org 23 Feb '16

23 Feb '16

Bert Freudenberg uploaded a new version of 51Deprecated to project The Trunk: http://source.squeak.org/trunk/51Deprecated-bf.19.mcz ==================== Summary ==================== Name: 51Deprecated-bf.19 Author: bf Time: 22 February 2016, 3:15:42.896692 pm UUID: 1e6194ef-cd0d-4c13-beef-208cf40f190b Ancestors: 51Deprecated-bf.18 Use actual old version for deprecation =============== Diff against 51Deprecated-bf.18 =============== Item was changed: ----- Method: DateAndTime class>>nowWithOffset: (in category '*51deprecated') ----- nowWithOffset: aDuration + + | clockValue nanos | self deprecated: 'use (... now offset: ...) instead'. + clockValue := Time utcMicrosecondClock. + "Ensure that consecutive sends of this method return increasing values, by adding small values to the nanosecond part of the created object. The next few lines are assumed to be executed atomically - having no suspension points." + ((LastClockValue ifNil: [ 0 ]) digitCompare: clockValue) = 0 + ifTrue: [ NanoOffset := NanoOffset + 1 ] + ifFalse: [ NanoOffset := 0 ]. + LastClockValue := clockValue. + nanos := clockValue \\ 1000000 * 1000 + NanoOffset. + clockValue := clockValue // 1000000. + ^self basicNew + setJdn: clockValue // SecondsInDay + SqueakEpoch + seconds: clockValue \\ SecondsInDay + nano: nanos - ^ self - now: self clock localMicrosecondClockWithOffset first offset: aDuration!

1 0

Daily Commit Log
by commits＠source.squeak.org 22 Feb '16

22 Feb '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-February/009449.h… Name: Collections-eem.678 Ancestors: Collections-ul.677 Make ByteArray>>unsignedLong[64]At:bigEndian: 64-bit aware. =============================================

1 0

Re: [squeak-dev] The Trunk: System-eem.801.mcz
by Tobias Pape 22 Feb '16

22 Feb '16

On 21.02.2016, at 07:40, commits(a)source.squeak.org wrote: > Eliot Miranda uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-eem.801.mcz > > ==================== Summary ==================== > > Name: System-eem.801 > Author: eem > Time: 20 February 2016, 11:40:02.089874 pm > UUID: cb00963a-1c90-40c0-9539-04c88c0afa5f > Ancestors: System-mt.800 > > In Spur calcEndianness can be a lot simpler. > > =============== Diff against System-mt.800 =============== > > Item was changed: > ----- Method: SmalltalkImage>>calcEndianness (in category 'system attributes') ----- > calcEndianness > - | bytes word blt | > "What endian-ness is the current hardware? The String '1234' will be stored into a machine word. On BigEndian machines (the Mac), $1 will be the high byte if the word. On LittleEndian machines (the PC), $4 will be the high byte." > "Smalltalk endianness" > + | wordThenBytes | > + wordThenBytes := WordArray with: 16r01020304. > + ByteArray adoptInstance: wordThenBytes. > + wordThenBytes first = 1 ifTrue: [^#big]. > + wordThenBytes first = 4 ifTrue: [^#little]. > + self error: 'The author is confused'! Well, If we had Squeak on a PDP-11, we would have also middle endian: https://en.wikipedia.org/wiki/Endianness#Middle-endian ;) Best regards -Tobias > - > - bytes := ByteArray withAll: #(0 0 0 0). "(1 2 3 4) or (4 3 2 1)" > - word := WordArray with: 16r01020304. > - blt := (BitBlt toForm: (Form new hackBits: bytes)) > - sourceForm: (Form new hackBits: word). > - blt combinationRule: Form over. "store" > - blt sourceY: 0; destY: 0; height: 1; width: 4. > - blt sourceX: 0; destX: 0. > - blt copyBits. "paste the word into the bytes" > - bytes first = 1 ifTrue: [^ #big]. > - bytes first = 4 ifTrue: [^ #little]. > - self error: 'Ted is confused'.! > >

3 2

The Trunk: Collections-eem.678.mcz
by commits＠source.squeak.org 22 Feb '16

22 Feb '16

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.678.mcz ==================== Summary ==================== Name: Collections-eem.678 Author: eem Time: 22 February 2016, 9:39:42.620109 am UUID: 5f42102e-7dd0-4fc7-b437-5ba06a88240d Ancestors: Collections-ul.677 Make ByteArray>>unsignedLong[64]At:bigEndian: 64-bit aware. =============== Diff against Collections-ul.677 =============== Item was changed: ----- Method: ByteArray>>unsignedLong64At:bigEndian: (in category 'platform independent access') ----- unsignedLong64At: index bigEndian: bigEndian "Return a 64-bit unsigned integer quantity starting from the given byte index. Use #normalize where necessary to ensure compatibility with non-30-bit SmallIntegers." + | byte | + SmallInteger maxVal > 1073741823 ifTrue: + [bigEndian + ifTrue: "64-bit SmallIntegers have a 3 bit tag and a sign bit, so the most positive value has 16rF as its top byte." + [(byte := self at: index) <= 16rF ifTrue: + [^((((((((byte bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 3)) bitShift: 8) + + (self at: index + 4) bitShift: 8) + (self at: index + 5) bitShift: 8) + (self at: index + 6) bitShift: 8) + (self at: index + 7)]] + ifFalse: + [(byte := self at: index + 7) <= 16rF ifTrue: + [^((((((((byte bitShift: 8) + (self at: index + 6) bitShift: 8) + (self at: index + 5) bitShift: 8) + (self at: index + 4)) bitShift: 8) + + (self at: index + 3) bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index)]]]. - | v | bigEndian ifFalse: [ + (byte := self at: index + 7) = 0 ifFalse: [ - (v := self at: index + 7) = 0 ifFalse: [ ^(LargePositiveInteger new: 8) + replaceFrom: 1 to: 8 with: self startingAt: index; - replaceFrom: 1 - to: 8 - with: self - startingAt: index; normalize ]. + (byte := self at: index + 6) = 0 ifFalse: [ - (v := self at: index + 6) = 0 ifFalse: [ ^(LargePositiveInteger new: 7) + replaceFrom: 1 to: 7 with: self startingAt: index; - replaceFrom: 1 - to: 7 - with: self - startingAt: index; normalize ]. + (byte := self at: index + 5) = 0 ifFalse: [ - (v := self at: index + 5) = 0 ifFalse: [ ^(LargePositiveInteger new: 6) + replaceFrom: 1 to: 6 with: self startingAt: index; - replaceFrom: 1 - to: 6 - with: self - startingAt: index; normalize ]. + (byte := self at: index + 4) = 0 ifFalse: [ - (v := self at: index + 4) = 0 ifFalse: [ ^(LargePositiveInteger new: 5) + replaceFrom: 1 to: 5 with: self startingAt: index; - replaceFrom: 1 - to: 5 - with: self - startingAt: index; normalize ]. + (byte := self at: index + 3) <= 16r3F ifFalse: [ - (v := self at: index + 3) <= 16r3F ifFalse: [ ^(LargePositiveInteger new: 4) + replaceFrom: 1 to: 4 with: self startingAt: index; - replaceFrom: 1 - to: 4 - with: self - startingAt: index; normalize ]. + ^(((byte bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index) ]. + (byte := self at: index) = 0 ifFalse: [ - ^(((v bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index) ]. - (v := self at: index) = 0 ifFalse: [ ^(LargePositiveInteger new: 8) digitAt: 1 put: (self at: index + 7); digitAt: 2 put: (self at: index + 6); digitAt: 3 put: (self at: index + 5); digitAt: 4 put: (self at: index + 4); digitAt: 5 put: (self at: index + 3); digitAt: 6 put: (self at: index + 2); digitAt: 7 put: (self at: index + 1); + digitAt: 8 put: byte; - digitAt: 8 put: v; normalize ]. + (byte := self at: index + 1) = 0 ifFalse: [ - (v := self at: index + 1) = 0 ifFalse: [ ^(LargePositiveInteger new: 7) digitAt: 1 put: (self at: index + 7); digitAt: 2 put: (self at: index + 6); digitAt: 3 put: (self at: index + 5); digitAt: 4 put: (self at: index + 4); digitAt: 5 put: (self at: index + 3); digitAt: 6 put: (self at: index + 2); + digitAt: 7 put: byte; - digitAt: 7 put: v; normalize ]. + (byte := self at: index + 2) = 0 ifFalse: [ - (v := self at: index + 2) = 0 ifFalse: [ ^(LargePositiveInteger new: 6) digitAt: 1 put: (self at: index + 7); digitAt: 2 put: (self at: index + 6); digitAt: 3 put: (self at: index + 5); digitAt: 4 put: (self at: index + 4); digitAt: 5 put: (self at: index + 3); + digitAt: 6 put: byte; - digitAt: 6 put: v; normalize ]. + (byte := self at: index + 3) = 0 ifFalse: [ - (v := self at: index + 3) = 0 ifFalse: [ ^(LargePositiveInteger new: 5) digitAt: 1 put: (self at: index + 7); digitAt: 2 put: (self at: index + 6); digitAt: 3 put: (self at: index + 5); digitAt: 4 put: (self at: index + 4); + digitAt: 5 put: byte; - digitAt: 5 put: v; normalize ]. + (byte := self at: index + 4) <= 16r3F ifFalse: [ - (v := self at: index + 4) <= 16r3F ifFalse: [ ^(LargePositiveInteger new: 4) digitAt: 1 put: (self at: index + 7); digitAt: 2 put: (self at: index + 6); digitAt: 3 put: (self at: index + 5); + digitAt: 4 put: byte; - digitAt: 4 put: v; normalize ]. + ^(((byte bitShift: 8) + (self at: index + 5) bitShift: 8) + (self at: index + 6) bitShift: 8) + (self at: index + 7)! - ^(((v bitShift: 8) + (self at: index + 5) bitShift: 8) + (self at: index + 6) bitShift: 8) + (self at: index + 7)! Item was changed: ----- Method: ByteArray>>unsignedLongAt:bigEndian: (in category 'platform independent access') ----- unsignedLongAt: index bigEndian: bigEndian "Return a 32-bit unsigned integer quantity starting from the given byte index. Use #normalize where necessary to ensure compatibility with non-30-bit SmallIntegers." - | byte | + bigEndian ifTrue: + [((byte := self at: index) <= 16r3F + or: [SmallInteger maxVal > 1073741823]) ifTrue: + [^(((byte bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 3)]. - bigEndian ifTrue: [ - (byte := self at: index) <= 16r3F ifTrue: [ - ^(((byte bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 3) ]. ^(LargePositiveInteger new: 4) digitAt: 1 put: (self at: index + 3); digitAt: 2 put: (self at: index + 2); digitAt: 3 put: (self at: index + 1); digitAt: 4 put: byte; + normalize]. + ((byte := self at: index + 3) <= 16r3F + or: [SmallInteger maxVal > 1073741823]) ifTrue: + [^(((byte bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index)]. - normalize ]. - (byte := self at: index + 3) <= 16r3F ifTrue: [ - ^(((byte bitShift: 8) + (self at: index + 2) bitShift: 8) + (self at: index + 1) bitShift: 8) + (self at: index) ]. ^(LargePositiveInteger new: 4) + replaceFrom: 1 to: 4 with: self startingAt: index; + normalize! - replaceFrom: 1 - to: 4 - with: self - startingAt: index; - normalize - !

1 0

no implementors of #primitiveEnterCriticalSectionOnBehalfOf:
by Chris Muller 22 Feb '16

22 Feb '16

When trying to debug Through a simple call to #at:ifAbsentPut:, my image locks, stuck in a DNU loop trying to send this message. Its sent from ContextPart>>#doPrimitive:method:receiver:args:, but not implemented anywhere.

1 0

An issue with Collections-ul.667
by Eliot Miranda 22 Feb '16

22 Feb '16

Hi Levente, I just wanted to note a potential problem with Collections-ul.667 Name: Collections-ul.667 Author: ul Time: 10 October 2015, 3:40:46.732 pm UUID: 7cd785ff-1839-4075-ac56-4b71054529d8 Ancestors: Collections-topa.666 Added the missing methods of ByteArray's platform independent access category: #signedByteAt: #signedByteAt:put: #long64At:put:bigEndian: and #long64At:bigEndian:. The 64-bit methods are not optimized. In this version you provided ByteArray>>#signedByteAt:[put:] which conflicts with FFI-Kernel's methods of the same name. There's a difference in semantics. If you look at ExternalStructure's class comment it points out that "This class provides an abstract base for all structures that can be used by external functions. ExternalStructures have two possible handle types: - ExternalAddress If the handle is an external address then the object described does not reside in the Smalltalk object memory. - ByteArray If the handle is a byte array then the object described resides in Smalltalk memory. Useful methods should be implemented by subclasses of ExternalStructure using the common ByteArray/ExternalAddress platform dependent access protocol which will transparently access the correct memory location." i.e. the primitives used automatically differentiate between an ExternalAddress holding a pointer to external memory, in which case the datum is accessed via that location, or a ByteArray, in which case the datum is accessed in the ByteArray. Your versions only do the latter and would hence misinterpret data in ExternalAdderss instances. Here's the FFI code: ByteArray>>signedByteAt: byteOffset "Return a 8bit signed integer starting at the given byte offset" ^self integerAt: byteOffset size: 1 signed: true ByteArray>>integerAt: byteOffset size: nBytes signed: aBoolean "Primitive. Return an integer of nBytes size from the receiver. Note: This primitive will access memory in the outer space if invoked from ExternalAddress." <primitive: 'primitiveFFIIntegerAt' module:'SqueakFFIPrims'> ^self primitiveFailed And here's yours: ByteArray>>signedByteAt: index "Return an 8-bit signed integer quantity from the given byte index." | byte | (byte := self at: index) <= 16r7F ifTrue: [ ^byte ]. ^byte - 16r100 Now of course this isn't an issue in builds that load the FFI after Collections, but it does affect images in which FFI-Kernel was loaded and then the image was updated to instal Collections-ul.667. I'm not sure what the right fix is, but I thought I'd better mention it. One obvious one is to implement the FFI methods in ExternalAddress>>#signedByteAt:[put:], and if folks agree I can do this. Let me know. Pharoers, if I do this, you'll need to make sure that the Pharo base includes ByteArray>>#signedByteAt:[put:]. _,,,^..^,,,_ best, Eliot

3 2

Daily Commit Log
by commits＠source.squeak.org 21 Feb '16

21 Feb '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-February/009447.h… Name: Help-Squeak-Project-tpr.35 Ancestors: Help-Squeak-Project-cmm.34 Some improvements to the commandkey help text; correct meaning of cmd-shift-l/r, add tab/shift-tav etc ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-February/009448.h… Name: System-eem.801 Ancestors: System-mt.800 In Spur calcEndianness can be a lot simpler. =============================================

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
21
Older →

Jump to page: