Squeak-dev December 2016

squeak-dev@lists.squeakfoundation.org

39 participants
137 discussions

The Trunk: Collections-ul.727.mcz
by commits＠source.squeak.org 06 Dec '16

06 Dec '16

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.727.mcz ==================== Summary ==================== Name: Collections-ul.727 Author: ul Time: 6 December 2016, 7:01:42.838977 pm UUID: 08250fa9-de61-4316-a96e-c2e4d3e53d1a Ancestors: Collections-topa.726 - micro-optimized OrderedCollection's #first, #last, #removeFirst and #removeLlast =============== Diff against Collections-topa.726 =============== Item was added: + ----- Method: OrderedCollection>>first (in category 'accessing') ----- + first + + firstIndex > lastIndex ifTrue: [ self errorNoSuchElement ]. + ^array at: firstIndex! Item was added: + ----- Method: OrderedCollection>>last (in category 'accessing') ----- + last + + firstIndex > lastIndex ifTrue: [ self errorNoSuchElement ]. + ^array at: lastIndex! Item was changed: ----- Method: OrderedCollection>>removeFirst (in category 'removing') ----- removeFirst "Remove the first element of the receiver and answer it. If the receiver is empty, create an error notification." + | firstObject | + firstIndex > lastIndex ifTrue: [ self errorEmptyCollection ]. - self emptyCheck. firstObject := array at: firstIndex. array at: firstIndex put: nil. firstIndex := firstIndex + 1. + ^firstObject! - ^ firstObject! Item was changed: ----- Method: OrderedCollection>>removeLast (in category 'removing') ----- removeLast "Remove the last element of the receiver and answer it. If the receiver is empty, create an error notification." + | lastObject | + firstIndex > lastIndex ifTrue: [ self errorEmptyCollection ]. - self emptyCheck. lastObject := array at: lastIndex. array at: lastIndex put: nil. lastIndex := lastIndex - 1. ^ lastObject!

1 0

Squeaksource.com is down
by David T. Lewis 06 Dec '16

06 Dec '16

The squeaksource.com service is down due to a failure in the squeaksource image. Cause of failure and estimated time to fix are not yet known. Recovery may require rebuilding from a backup image from 5 October 2016, so additional downtime and possible loss of account data are likely. All actual files are intact on the server and no data loss is anticipated. Dave

5 8

The Trunk: Collections-topa.725.mcz
by commits＠source.squeak.org 05 Dec '16

05 Dec '16

Tobias Pape uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-topa.725.mcz ==================== Summary ==================== Name: Collections-topa.725 Author: topa Time: 5 December 2016, 8:58:22.49114 pm UUID: d521fd18-86b5-42ce-8c74-475031b54934 Ancestors: Collections-eem.724 Fix a few comments =============== Diff against Collections-eem.724 =============== Item was changed: ----- Method: ArrayedCollection class>>with:with:with:with: (in category 'instance creation') ----- with: firstObject with: secondObject with: thirdObject with: fourthObject + "Answer a new instance of me, containing only the four arguments as - "Answer a new instance of me, containing only the three arguments as elements." | newCollection | newCollection := self new: 4. newCollection at: 1 put: firstObject. newCollection at: 2 put: secondObject. newCollection at: 3 put: thirdObject. newCollection at: 4 put: fourthObject. ^newCollection! Item was changed: ----- Method: SequenceableCollection>>combinationsAt:in:after:do: (in category 'private') ----- combinationsAt: jj in: aCollection after: nn do: aBlock "Choose k of N items and put in aCollection. jj-1 already chosen. Indexes of items are in numerical order, to avoid the same combo being used twice. In this slot, we are allowed to use items in self indexed by nn+1 to self size. nn is the index used for position jj-1." + "(1 to: 6) combinations: 3 atATimeDo: [:each | Transcript cr; show: each printString]" - "(1 to: 6) combinationsSize: 3 do: [:each | Transcript cr; show: each printString]" nn+1 to: self size do: [:index | aCollection at: jj put: (self at: index). jj = aCollection size ifTrue: [aBlock value: aCollection] ifFalse: [self combinationsAt: jj + 1 in: aCollection after: index do: aBlock]].!

1 0

The Trunk: Collections-eem.724.mcz
by commits＠source.squeak.org 05 Dec '16

05 Dec '16

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.724.mcz ==================== Summary ==================== Name: Collections-eem.724 Author: eem Time: 3 December 2016, 9:30:36.13835 am UUID: 83cb6b85-2b47-4c92-a953-e3787a19d53b Ancestors: Collections-eem.723 The various scanFor: and scanForEmptySlotFor: implementations only need to access the size of their array once. Fix protocol for an #= =============== Diff against Collections-eem.723 =============== Item was changed: ----- Method: Dictionary>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject hash \\ (size := array size) + 1. - | index start | - index := start := anObject hash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ anObject = element key ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: HashedCollection>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject hash \\ (size := array size) + 1. - | index start | - index := start := anObject hash \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: IdentityDictionary>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ element key == anObject ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: IdentityDictionary>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: IdentitySet>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ element enclosedSetElement == anObject ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: IdentitySet>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: KeyedIdentitySet>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ (keyBlock value: element enclosedSetElement) == anObject ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: KeyedIdentitySet>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: KeyedSet>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject hash \\ (size := array size) + 1. - | index start | - index := start := anObject hash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ (keyBlock value: element enclosedSetElement) = anObject ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: PluggableDictionary>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | - | index start | index := start := (hashBlock ifNil: [ anObject hash ] + ifNotNil: [ hashBlock value: anObject ]) \\ (size := array size) + 1. - ifNotNil: [ hashBlock value: anObject ]) \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ equalBlock ifNil: [ element key = anObject ] ifNotNil: [ equalBlock value: element key value: anObject ] ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: PluggableDictionary>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | - | index start | index := start := (hashBlock ifNil: [ anObject hash ] + ifNotNil: [ hashBlock value: anObject ]) \\ (size := array size) + 1. - ifNotNil: [ hashBlock value: anObject ]) \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: + ----- Method: PluggableSet>>= (in category 'comparing') ----- - ----- Method: PluggableSet>>= (in category 'as yet unclassified') ----- = anObject "Two sets are equal if (a) they are the same 'kind' of thing. (b) they have the same set of keys. (c) for each (common) key, they have the same value" self == anObject ifTrue: [ ^true ]. self species == anObject species ifFalse: [ ^false ]. hashBlock = anObject hashBlock ifFalse: [ ^false ]. equalBlock = anObject equalBlock ifFalse: [ ^false ]. self size = anObject size ifFalse: [ ^false ]. ^self allSatisfy: [ :each | anObject includes: each ]! Item was changed: ----- Method: PluggableSet>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | - | index start | index := start := (hashBlock ifNil: [ anObject hash ] + ifNotNil: [ hashBlock value: anObject ]) \\ (size := array size) + 1. - ifNotNil: [ hashBlock value: anObject ]) \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ equalBlock ifNil: [ element enclosedSetElement = anObject ] ifNotNil: [ equalBlock value: element enclosedSetElement value: anObject ] ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: PluggableSet>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | - | index start | index := start := (hashBlock ifNil: [ anObject hash ] + ifNotNil: [ hashBlock value: anObject ]) \\ (size := array size) + 1. - ifNotNil: [ hashBlock value: anObject ]) \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: Set>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject hash \\ (size := array size) + 1. - | index start | - index := start := anObject hash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ anObject = element enclosedSetElement ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: WeakIdentityKeyDictionary>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ | element | ((element := array at: index) == nil or: [ element key == anObject ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: WeakIdentityKeyDictionary>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject scaledIdentityHash \\ (size := array size) + 1. - | index start | - index := start := anObject scaledIdentityHash \\ array size + 1. [ (array at: index) ifNil: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: WeakSet>>scanFor: (in category 'private') ----- scanFor: anObject "Scan the key array for the first slot containing either flag (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject hash \\ (size := array size) + 1. - | index start | - index := start := anObject hash \\ array size + 1. [ | element | ((element := array at: index) == flag or: [ element enclosedSetElement = anObject ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace! Item was changed: ----- Method: WeakSet>>scanForEmptySlotFor: (in category 'private') ----- scanForEmptySlotFor: anObject "Scan the key array for the first slot containing an empty slot (indicated by flag or a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements." + | index start size | + index := start := anObject hash \\ (size := array size) + 1. - | index start | - index := start := anObject hash \\ array size + 1. [ | element | ((element := array at: index) == flag or: [ element == nil ]) ifTrue: [ ^index ]. + (index := index \\ size + 1) = start ] whileFalse. - (index := index \\ array size + 1) = start ] whileFalse. self errorNoFreeSpace!

3 2

The Inbox: Chronology-Tests-dtl.8.mcz
by commits＠source.squeak.org 04 Dec '16

04 Dec '16

David T. Lewis uploaded a new version of Chronology-Tests to project The Inbox: http://source.squeak.org/inbox/Chronology-Tests-dtl.8.mcz ==================== Summary ==================== Name: Chronology-Tests-dtl.8 Author: dtl Time: 4 December 2016, 12:39:59.762389 pm UUID: 778d4c7e-448d-41f9-8aa2-18bfc6d6c3ce Ancestors: Chronology-Tests-dtl.7 DateAndTime asSeconds should refer to seconds since the Smalltalk epoch. =============== Diff against Chronology-Tests-dtl.7 =============== Item was added: + ----- Method: DateAndTimeTest>>testAsSeconds (in category 'Tests') ----- + testAsSeconds + "Verify seconds elapsed from the Smalltalk epoch until a specified DateAndTime 2004-02-29T13:33:00+02:00" + + | aDateAndTime first28DaysOfFebruary2004 firstElevenHoursOfFebruary29 monthOfJanuary2004 posixEpochUntilJanuary2004 smalltalkEpochUntilPosixEpoch thirtyThreeMinutesOfTheEleventhHour totalElapsedSeconds | + + aDateAndTime := (DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0 offset: 2 hours). + smalltalkEpochUntilPosixEpoch := 24 * 60 * 60 * ((52*365) + (17*366)). + posixEpochUntilJanuary2004 := 24 * 60 * 60 * ((26*365) + (8*366)). + monthOfJanuary2004 := 31 * 24 * 60 * 60. + first28DaysOfFebruary2004 := 28 * 24 * 60 * 60. + firstElevenHoursOfFebruary29 := 11 * 60 * 60. + thirtyThreeMinutesOfTheEleventhHour := 33 * 60. + totalElapsedSeconds := smalltalkEpochUntilPosixEpoch + posixEpochUntilJanuary2004 + monthOfJanuary2004 + first28DaysOfFebruary2004 + firstElevenHoursOfFebruary29 + thirtyThreeMinutesOfTheEleventhHour. + self assert: totalElapsedSeconds equals: aDateAndTime asSeconds. "3255507180" + !

2 1

The Trunk: Chronology-Tests-dtl.7.mcz
by commits＠source.squeak.org 04 Dec '16

04 Dec '16

David T. Lewis uploaded a new version of Chronology-Tests to project The Trunk: http://source.squeak.org/trunk/Chronology-Tests-dtl.7.mcz ==================== Summary ==================== Name: Chronology-Tests-dtl.7 Author: dtl Time: 4 December 2016, 12:27:31.985405 pm UUID: c395f2d9-7c78-4a8a-a682-ba738829f8da Ancestors: Chronology-Tests-dtl.6 Tests that send DateAndTime class>>localTimeZone: will set the automaticTimeZone preference as an unintended side effect. Save and restore the preference when running these tests. =============== Diff against Chronology-Tests-dtl.6 =============== Item was changed: TestCase subclass: #DateAndTimeEpochTest + instanceVariableNames: 'aDateAndTime aDuration aTimeZone localTimeZoneToRestore localTimeZonePreferenceToRestore' - instanceVariableNames: 'aDateAndTime aDuration aTimeZone localTimeZoneToRestore' classVariableNames: '' poolDictionaries: '' category: 'Chronology-Tests'! !DateAndTimeEpochTest commentStamp: 'tlk 1/6/2004 18:27' prior: 0! I represent one of several Sunit test Cases intentended to provide complete coverage for the Chronology set of classes as part of the external testing. The other Chronology sunit test cases are: DateTestCase DateAndTimeLeapTestCase, DurationTestCase, ScheduleTestCase TimeStampTestCase TimespanDoTestCase, TimespanDoSpanAYearTestCase, TimespanTestCase, YearMonthWeekTestCase. These tests attempt to exercise all public and private methods. Except, they do not explicitly depreciated methods. tlk My fixtures are: aDateAndTime = January 01, 1901 midnight (the start of the Squeak epoch) with localTimeZone = Grenwhich Meridian (local offset = 0 hours) aDuration = 1 day, 2 hours, 3, minutes, 4 seconds and 5 nano seconds. aTimeZone = 'Epoch Test Time Zone', 'ETZ' , offset: 12 hours, 15 minutes. ! Item was changed: ----- Method: DateAndTimeEpochTest>>setUp (in category 'running') ----- setUp + localTimeZoneToRestore := DateAndTime localTimeZone. + localTimeZonePreferenceToRestore := DateAndTime automaticTimezone. - localTimeZoneToRestore := DateAndTime localTimeZone. aDateAndTime := DateAndTime localTimeZone: TimeZone default; epoch. aTimeZone := TimeZone offset: (Duration minutes: 135) name: 'Epoch Test Time Zone' abbreviation: 'ETZ'. aDuration := Duration days: 1 hours: 2 minutes: 3 seconds: 4 nanoSeconds: 5 ! Item was changed: ----- Method: DateAndTimeEpochTest>>tearDown (in category 'running') ----- tearDown + DateAndTime localTimeZone: localTimeZoneToRestore. + DateAndTime automaticTimezone: localTimeZonePreferenceToRestore. - DateAndTime localTimeZone: localTimeZoneToRestore. "wish I could remove the time zones I added earlier, tut there is no method for that" ! Item was changed: TestCase subclass: #DateAndTimeLeapTest + instanceVariableNames: 'aDateAndTime aDuration aTimeZone localTimeZoneToRestore localTimeZonePreferenceToRestore' - instanceVariableNames: 'aDateAndTime aDuration aTimeZone localTimeZoneToRestore' classVariableNames: '' poolDictionaries: '' category: 'Chronology-Tests'! !DateAndTimeLeapTest commentStamp: 'tlk 1/6/2004 17:54' prior: 0! I represent one of several Sunit test Cases intentended to provide complete coverage for the Chronology set of classes as part of the external testing. tlk. My fixtures are: aDateAndTime = February 29, 2004 1:33 PM with offset: 2 hours aDuration = 15 days, 14 hours, 13 minutes, 12 seconds and 11 nano seconds. aTimeZone = Grenwhich Meridian (local offset = 0 hours) ! Item was changed: ----- Method: DateAndTimeLeapTest>>setUp (in category 'running') ----- setUp localTimeZoneToRestore := DateAndTime localTimeZone. + localTimeZonePreferenceToRestore := DateAndTime automaticTimezone. DateAndTime localTimeZone: TimeZone default. aDateAndTime := (DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0 offset: 2 hours). aTimeZone := TimeZone default. aDuration := Duration days: 0 hours: 13 minutes: 33 seconds: 0 nanoSeconds: 0 ! Item was changed: ----- Method: DateAndTimeLeapTest>>tearDown (in category 'running') ----- tearDown DateAndTime localTimeZone: localTimeZoneToRestore. + DateAndTime automaticTimezone: localTimeZonePreferenceToRestore. "wish I could remove the time zones I added earlier, tut there is no method for that" ! Item was changed: ----- Method: DateTest>>testMakeUTC (in category 'testing') ----- testMakeUTC "Equal dates should compare equal regardless of which TimeZone they are created in." + | priorTz priorPreference march31stLocal march31stOcean | - | priorTz march31stLocal march31stOcean | priorTz := DateAndTime localTimeZone. + priorPreference := DateAndTime automaticTimezone. [DateAndTime localTimeZone: (TimeZone offset: 9 hours name: 'Early Test Countries' abbreviation: 'Test Ocean Early'). march31stLocal := Date year: 2016 month: 3 day: 31. march31stLocal start: (march31stLocal start offset: DateAndTime localTimeZone offset). DateAndTime localTimeZone: (TimeZone offset: -9 hours name: 'Late Test Countries' abbreviation: 'Test Ocean Late'). march31stOcean := Date year: 2016 month: 3 day: 31. march31stOcean start: (march31stOcean start offset: DateAndTime localTimeZone offset).] + ensure: [DateAndTime localTimeZone: priorTz. + DateAndTime automaticTimezone: priorPreference]. - ensure: [DateAndTime localTimeZone: priorTz]. self deny: march31stLocal = march31stOcean; assert: march31stOcean > march31stLocal. self assert: march31stLocal makeUTC = march31stOcean makeUTC; deny: march31stOcean makeUTC > march31stLocal makeUTC; deny: march31stOcean makeUTC < march31stLocal makeUTC.! Item was changed: ClassTestCase subclass: #ScheduleTest + instanceVariableNames: 'firstEvent aSchedule restoredTimeZone localTimeZonePreferenceToRestore' - instanceVariableNames: 'firstEvent aSchedule restoredTimeZone' classVariableNames: '' poolDictionaries: '' category: 'Chronology-Tests'! Item was changed: ----- Method: ScheduleTest>>setUp (in category 'running') ----- setUp "Schedule is a type of Timespan representing repeated occurences of the same event. The beginning of the schedule is the first occurrence of the event. A schedule maintains an array of Durations. Each durations specify the offset to the next scheduled each. The duration of each occurence of the event is not specified. Nor are any other attributes such as name" restoredTimeZone := DateAndTime localTimeZone. + localTimeZonePreferenceToRestore := DateAndTime automaticTimezone. DateAndTime localTimeZone: (TimeZone timeZones detect: [:tz | tz abbreviation = 'GMT']). "Create aSchedule with an event scheduled for 8:30pm every Saturday and Sunday for the year 2003. " "Create the first event occurring on the first Saturday at 8:30 pm: 1/4/03" firstEvent := DateAndTime year: 2003 month: 1 day: 4 hour: 20 minute: 30. "Create a schedule for one year starting with the first event" aSchedule := Schedule starting: firstEvent duration: 52 weeks. "Schedule the recurring events by scheduling the time in between each one. One day for Sat-Sun. 6 days for Sun-Sat" aSchedule schedule: { Duration days: 1. Duration days: 6 }. ! Item was changed: ----- Method: ScheduleTest>>tearDown (in category 'running') ----- tearDown DateAndTime localTimeZone: restoredTimeZone. + DateAndTime automaticTimezone: localTimeZonePreferenceToRestore. + ! - ! Item was changed: ClassTestCase subclass: #TimeTest + instanceVariableNames: 'time aTime localTimeZoneToRestore timeWithNanos localTimeZonePreferenceToRestore' - instanceVariableNames: 'time aTime localTimeZoneToRestore timeWithNanos' classVariableNames: '' poolDictionaries: '' category: 'Chronology-Tests'! !TimeTest commentStamp: '<historical>' prior: 0! This is the unit test for the class Time. ! Item was changed: ----- Method: TimeTest>>setUp (in category 'Running') ----- setUp localTimeZoneToRestore := DateAndTime localTimeZone. + localTimeZonePreferenceToRestore := DateAndTime automaticTimezone. DateAndTime localTimeZone: TimeZone default. time := self timeClass fromSeconds: 14567. "4:02:47 am" aTime := self timeClass readFrom: '12:34:56 pm' readStream. timeWithNanos := self timeClass fromSeconds: 14567.42. ! Item was changed: ----- Method: TimeTest>>tearDown (in category 'Running') ----- tearDown DateAndTime localTimeZone: localTimeZoneToRestore. + DateAndTime automaticTimezone: localTimeZonePreferenceToRestore. + ! - ! Item was changed: ClassTestCase subclass: #TimespanTest + instanceVariableNames: 'timespan aTimespan anOverlappingTimespan anIncludedTimespan aDisjointTimespan aDay aWeek dec31 jan01 jan08 localTimeZoneToRestore anEqualTimeSpan localTimeZonePreferenceToRestore' - instanceVariableNames: 'timespan aTimespan anOverlappingTimespan anIncludedTimespan aDisjointTimespan aDay aWeek dec31 jan01 jan08 localTimeZoneToRestore anEqualTimeSpan' classVariableNames: '' poolDictionaries: '' category: 'Chronology-Tests'! Item was changed: ----- Method: TimespanTest>>setUp (in category 'Running') ----- setUp | jan01HereSomeWhereElseOnEarth | localTimeZoneToRestore := DateAndTime localTimeZone. + localTimeZonePreferenceToRestore := DateAndTime automaticTimezone. DateAndTime localTimeZone: TimeZone default. "100 hours starting noon 22 March 2003" timespan := Timespan starting: (DateAndTime year: 2003 month: 03 day: 22 hour: 12 minute: 0 second: 0) duration: (Duration hours: 100). dec31 := (DateAndTime year: 2004 month: 12 day: 31 hour: 0 minute: 0 second: 0). jan01 := (DateAndTime year: 2005 month: 1 day: 1 hour: 0 minute: 0 second: 0). jan08 := (DateAndTime year: 2005 month: 1 day: 8 hour: 0 minute: 0 second:0). aDay := Duration days: 1 hours: 0 minutes: 0 seconds: 0 nanoSeconds: 0. aWeek := Duration days: 7 hours: 0 minutes: 0 seconds: 0 nanoSeconds: 0. aTimespan := Timespan starting: jan01 duration: aWeek. jan01HereSomeWhereElseOnEarth := DateAndTime new ticks: (jan01 + 3 hours) ticks offset: jan01 offset + 3 hours. anEqualTimeSpan := Timespan starting: jan01HereSomeWhereElseOnEarth asUTC duration: aWeek. anOverlappingTimespan := Timespan starting: dec31 duration: aWeek. anIncludedTimespan := Timespan starting: jan01 duration: aDay. aDisjointTimespan := Timespan starting: jan08 duration: aWeek. ! Item was changed: ----- Method: TimespanTest>>tearDown (in category 'Running') ----- tearDown DateAndTime localTimeZone: localTimeZoneToRestore. + DateAndTime automaticTimezone: localTimeZonePreferenceToRestore. + timespan := nil - timespan := nil ! Item was changed: TestCase subclass: #YearMonthWeekTest + instanceVariableNames: 'restoredStartDay restoredTimeZone localTimeZonePreferenceToRestore' - instanceVariableNames: 'restoredStartDay restoredTimeZone' classVariableNames: '' poolDictionaries: '' category: 'Chronology-Tests'! !YearMonthWeekTest commentStamp: 'tlk 1/6/2004 17:55' prior: 0! I am one of several Sunit test Cases intentended to provide complete coverage for the Chronology set of classes as part of the external testing. See DateAndEpochTestCase for a complete list. tlk. I have no fixtures but do make sure to restore anything I change.! Item was changed: ----- Method: YearMonthWeekTest>>setUp (in category 'running') ----- setUp restoredStartDay := Week startDay. restoredTimeZone := DateAndTime localTimeZone. Week startDay: #Sunday. + DateAndTime localTimeZone: (TimeZone timeZones detect: [:tz | tz abbreviation = 'GMT']). + localTimeZonePreferenceToRestore := DateAndTime automaticTimezone.! - DateAndTime localTimeZone: (TimeZone timeZones detect: [:tz | tz abbreviation = 'GMT']).! Item was changed: ----- Method: YearMonthWeekTest>>tearDown (in category 'running') ----- tearDown Week startDay: restoredStartDay. + DateAndTime localTimeZone: restoredTimeZone. + DateAndTime automaticTimezone: localTimeZonePreferenceToRestore.! - DateAndTime localTimeZone: restoredTimeZone.!

1 0

The Trunk: Chronology-Tests-dtl.6.mcz
by commits＠source.squeak.org 04 Dec '16

04 Dec '16

David T. Lewis uploaded a new version of Chronology-Tests to project The Trunk: http://source.squeak.org/trunk/Chronology-Tests-dtl.6.mcz ==================== Summary ==================== Name: Chronology-Tests-dtl.6 Author: dtl Time: 4 December 2016, 11:48:31.846968 am UUID: ec13423f-cc05-4d51-a5be-675cb70c8d7f Ancestors: Chronology-Tests-dtl.5 Three new tests to verify that #asSeconds is symmetric with #fromSeconds: with various offset values. The tests pass. =============== Diff against Chronology-Tests-dtl.5 =============== Item was added: + ----- Method: DateAndTimeTest>>testAsSecondsMatchesFromSecondsUsingAnyOffset (in category 'Tests') ----- + testAsSecondsMatchesFromSecondsUsingAnyOffset + "Verify that #asSeconds is symmetric with #fromSeconds: for an instance with + offset that does not match the current local time zone offset." + + | aDateAndTime seconds newDateAndTime | + aDateAndTime := DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0 offset: 2 hours. + seconds := aDateAndTime asSeconds. + newDateAndTime := DateAndTime fromSeconds: seconds. + self assert: seconds equals: newDateAndTime asSeconds. + + "Repeat with another offset to ensure coverage" + aDateAndTime := DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0 offset: -11 hours. + seconds := aDateAndTime asSeconds. + newDateAndTime := DateAndTime fromSeconds: seconds. + self assert: seconds equals: newDateAndTime asSeconds. + ! Item was added: + ----- Method: DateAndTimeTest>>testAsSecondsMatchesFromSecondsUsingCurrentLocalOffset (in category 'Tests') ----- + testAsSecondsMatchesFromSecondsUsingCurrentLocalOffset + "Verify that #asSeconds is symmetric with #fromSeconds: for an instance with + offset that matches the current local time zone offset." + + | seconds newDateAndTime now | + now := DateAndTime now. + seconds := now asSeconds. + newDateAndTime := DateAndTime fromSeconds: seconds. + self assert: seconds equals: newDateAndTime asSeconds. + ! Item was added: + ----- Method: DateAndTimeTest>>testAsSecondsMatchesFromSecondsUsingZeroOffset (in category 'Tests') ----- + testAsSecondsMatchesFromSecondsUsingZeroOffset + "Verify that #asSeconds is symmetric with #fromSeconds: for an instance with + zero offset as in UTC time." + + | aDateAndTime seconds newDateAndTime | + aDateAndTime := DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0 offset: 0 hours. + seconds := aDateAndTime asSeconds. + newDateAndTime := DateAndTime fromSeconds: seconds. + self assert: seconds equals: newDateAndTime asSeconds. + !

1 0

The Trunk: Chronology-Tests-dtl.5.mcz
by commits＠source.squeak.org 04 Dec '16

04 Dec '16

David T. Lewis uploaded a new version of Chronology-Tests to project The Trunk: http://source.squeak.org/trunk/Chronology-Tests-dtl.5.mcz ==================== Summary ==================== Name: Chronology-Tests-dtl.5 Author: dtl Time: 4 December 2016, 10:38:28.08545 am UUID: 4f5040e9-e8f0-4937-b978-db3e0ae7ce24 Ancestors: Chronology-Tests-pre.4 The correct number of elapsed seconds from the Smalltalk epoch to 2004-02-29T13:33:00+02:00 is 3255507180. Change DateAndTime>>testAsSeconds to assert this value. =============== Diff against Chronology-Tests-pre.4 =============== Item was changed: ----- Method: DateAndTimeLeapTest>>testAsSeconds (in category 'testing') ----- testAsSeconds self assert: aDuration asSeconds = 48780. + self assert: aDateAndTime asSeconds = 3255507180! - self assert: aDateAndTime asSeconds = 3255514380!

1 0

DateAndTimeLeapTest>>testAsSeconds is broken
by David T. Lewis 04 Dec '16

04 Dec '16

DateAndTimeLeapTest>>testAsSeconds is broken. The test passes incorrectly as a result of a false assertion: self assert: aDateAndTime asSeconds = 3255514380. Where aDateAndTime is specified in #setUp aDateAndTime := (DateAndTime year: 2004 month: 2 day: 29 hour: 13 minute: 33 second: 0 offset: 2 hours). This time is 2004-02-29T13:33:00+02:00, which in UTC is 2004-02-29T11:33:00+00:00. The #asSeconds tests should test for elapsed seconds from the Smalltalk epoch until 2004-02-29T11:33:00+00:00. The correct number of seconds for this duration is 3255507180, not 3255514380 as asserted in the unit test. By definition, #asSeconds is the seconds elapsed since the Smalltalk epoch (see its method comment). By common agreement, the Smalltalk epoch was defined relative to Greenwich Mean Time (UTC). If these two statements are both true, then the test is broken. If there is no disagreement, I will fix the test and allow it to show the failure. Dave

5 20

curiousity, logo shown from google search
by Ben Coman 04 Dec '16

04 Dec '16

Just a curiousity, the RSqueak logo shows up by default for "Squeak" google searches. I guess since there is no plain large Squeak logo on the page squeak.org. cheers -ben

2 1

Jump to page: