Squeak-dev October 2016

squeak-dev@lists.squeakfoundation.org

40 participants
114 discussions

obsolete code version re-imported thru squeakland (overrides?)
by Nicolas Cellier 30 Oct '16

30 Oct '16

After seeing the post of Bert about ldexp http://croquetweak.blogspot.fr/2014/08/deconstructing-floats-frexp-and-ldex… I wanted to check what's in image. But I realized that current Squeak fallback code for Float>>timesTwoPower: is not OK. It's the version from Etoys-Squeakland corresponding to old squeak implementation The correct one should be that of Kernel-nice.900.mcz http://lists.squeakfoundation.org/pipermail/packages/2015-February/007538.h… Fortunately it has been moved (duplicated) in-between in both subclasses, thus maybe the Squeakland one is not an override? I can't really trace what happened because it's hidden in the spur transition. But IMO it would be preferable to implement the Smalltalk one in Float only once, and rely on ^super timesTwoPower: in case of primitive failure. I saw some other instances of code that was fixed but reintroduced (like all the character scanner duplication). What's the strategy about it, can we touch Squeakland, or shall we refrain?

2 1

Re: The defaullt implementation of isEmpty might do too much work
by monty 28 Oct '16

28 Oct '16

All non-trivial collections implement #size or inherit a custom implementation, usually just as a return of an inst var. Your #do:-based one is 3x as slow in my tests, so you've now made #isEmpty slower for every collection that implements #size just to benefit ones whose careless authors didn't and so the implementors of lazy collections have one fewer message to override. Do not do this. People already avoid #ifEmpty: and related messages where performance matters and shouldn't have to avoid #isEmpty too.

13 33

Re: [squeak-dev] The Trunk: ST80-nice.220.mcz
by karl ramberg 27 Oct '16

27 Oct '16

Should the comment be changed here? Or is it still a hack ? Best, Karl On Thu, Oct 27, 2016 at 2:43 AM, <commits(a)source.squeak.org> wrote: > Nicolas Cellier uploaded a new version of ST80 to project The Trunk: > http://source.squeak.org/trunk/ST80-nice.220.mcz > > ==================== Summary ==================== > > Name: ST80-nice.220 > Author: nice > Time: 27 October 2016, 2:43:25.251747 am > UUID: e617501e-764e-4c9c-8c0c-a2a559e84940 > Ancestors: ST80-tfel.219 > > Remove an old Transcript show: remnant from horrorful text selection debug > session. > > =============== Diff against ST80-tfel.219 =============== > > Item was changed: > ----- Method: CharacterBlockScannerForMVC>>crossedX (in category 'stop > conditions') ----- > crossedX > characterIndex == nil ifFalse: [ > "If the last character of the last line is a space, > and it crosses the right margin, then locating > the character block after it is impossible without this > hack." > + characterIndex > text size ifTrue: [ > - characterIndex > text size ifTrue: [Transcript cr; > show:'here'. > lastIndex := characterIndex. > characterPoint := (nextLeftMargin ifNil: > [leftMargin]) @ (destY + line lineHeight). > ^true]]. > ^super crossedX! > > >

3 3

Re: [squeak-dev] The Inbox: Tools-nice.731.mcz
by Nicolas Cellier 27 Oct '16

27 Oct '16

Hi Tobias, Marcel Does it sound OK? 2016-10-27 22:23 GMT+02:00 <commits(a)source.squeak.org>: > Nicolas Cellier uploaded a new version of Tools to project The Inbox: > http://source.squeak.org/inbox/Tools-nice.731.mcz > > ==================== Summary ==================== > > Name: Tools-nice.731 > Author: nice > Time: 27 October 2016, 10:23:11.706603 pm > UUID: 31a047c7-9937-46f9-8710-1c38882f2a77 > Ancestors: Tools-eem.730 > > Fix the field menu of Set inspector. > > It's sent to a MenuMorph which DNU labels:. > Anyway, implementors of labels: do not expect alternate (selector action > selector acton ...) > > =============== Diff against Tools-eem.730 =============== > > Item was changed: > ----- Method: SetInspector>>mainFieldListMenu: (in category 'menu') > ----- > mainFieldListMenu: aMenu > > + ^ aMenu addList: #( > - ^ aMenu labels: #( > ('inspect' > inspectSelection) > ('copy name' > copyName) > ('objects pointing to this value' > objectReferencesToSelection) > ('refresh view' > update) > ('remove' > removeSelection) > - > ('basic inspect' > inspectBasic)); > yourself > ! > > >

2 1

Announce: whisper updated
by Robert Withers 27 Oct '16

27 Oct '16

Folks, I have updated whisper or SecureSession to provide Java/Squeak/Pharo interoperability. I am no longer able to access the Cryptography repo so I cannot push code, but the squeak/pharo code is in the squeak-pharo directory in the whisper github project. Here is the GitPages link: https://robertwithers.github.io/whisper, with all other links. whisper is osi Layer 5 SecureSession with modern crypto: Java/Squeak/Pharo interoperability. * flips normative osi layer 5 and 6 on its head: now, 5 is crypto and 6 is session state resumption * 3-way DH-2048/RSA-2048/RSAPublicKey ASN1DER encoding * 256-bit AES/CBC/PKCS7Padding, 128-bit IV, 160-bit SHA1 E&M * PBEEncryptorAES-256 with PBKDF2WithHmacSHA1 Rob

1 2

New protocols dialog
by Eliot Miranda 27 Oct '16

27 Oct '16

Hats off to whoever (Marcel?) implemented the new protocol selection dialog such that one no longer as to select "new..." and interact with a second dialog and can merely type the new protocol right there. This has been bugging me for years. Thank you! _,,,^..^,,,_ best, Eliot

1 1

missed commit mails
by Tobias Pape 27 Oct '16

27 Oct '16

Begin forwarded message: > From: commits(a)source.squeak.org > To: squeak-dev(a)lists.squeakfoundation.org, packages(a)lists.squeakfoundation.org > Reply-To: squeak-dev(a)lists.squeakfoundation.org > Subject: The Trunk: EToys-tfel.268.mcz > Message-Id: <E1byx8g-0003mP-Bs@andreas> > > Tim Felgentreff uploaded a new version of EToys to project The Trunk: > http://source.squeak.org/trunk/EToys-tfel.268.mcz > > ==================== Summary ==================== > > Name: EToys-tfel.268 > Author: tfel > Time: 24 October 2016, 11:33:16.574614 am > UUID: ea95b449-4d49-994b-a6b1-0b9d17104ab0 > Ancestors: EToys-eem.267 > > - refactor addInstVarNames: to go through Player class>>addInstVarName: > - small cleanups > > =============== Diff against EToys-eem.267 =============== > > Item was changed: > ----- Method: Class>>addInstVarNames: (in category '*Etoys-Squeakland-instance variables') ----- > addInstVarNames: aCollection > > | newInstVarString | > newInstVarString := self instanceVariablesString. > aCollection do: > [:varName | (self instVarNames includes: varName) ifFalse: [newInstVarString := newInstVarString , ' ' , varName]]. > + ^ self addInstVarName: newInstVarString > - ^(ClassBuilder new) > - name: self name > - inEnvironment: self environment > - subclassOf: superclass > - type: self typeOfClass > - instanceVariableNames: newInstVarString > - classVariableNames: self classVariablesString > - poolDictionaries: self sharedPoolsString > - category: self category > ! > > Item was added: > + ----- Method: Player class>>addInstVarName: (in category 'organization') ----- > + addInstVarName: aString > + > + ^(ClassBuilder new) > + name: self name > + inEnvironment: (self environment import: Smalltalk globals) > + subclassOf: self superclass > + type: self typeOfClass > + instanceVariableNames: self instanceVariablesString, ' ', aString > + classVariableNames: self classVariablesString > + poolDictionaries: self sharedPoolsString > + category: self category > + ! > > Item was changed: > ----- Method: Player class>>environment (in category 'organization') ----- > environment > > ^ self isUniClass > ifTrue: [(Environment withName: 'EtoysUserDefinedTempEnvironment') > + at: self name asSymbol put: self; > + importSelf; > - at: self name put: self; > yourself] > ifFalse: [super environment]! > > Item was changed: > ----- Method: Preferences class>>cambridge (in category '*Etoys-Squeakland-themes') ----- > cambridge > "A theme for Squeakland and OLPC project" > "Preferences cambridge" > "This method has three parts. Don't forget to look at the stuff at the bottom." > > self setPreferencesFrom: #( > (allowCelesteTell false) > (alternativeScrollbarLook true) > (alternativeWindowLook true) > (annotationPanes true) > (automaticKeyGeneration true) > (biggerHandles true) > (blinkParen false) > (browseWithDragNDrop true) > (canRecordWhilePlaying true) > (classicNavigatorEnabled false) > (compactViewerFlaps true) > (enableLocalSave false) > (escapeKeyProducesMenu false) > (eToyFriendly true) > (eToyLoginEnabled true) > (extraDebuggerButtons false) > (gradientMenu false) > (haloTransitions false) > (honorDesktopCmdKeys true) > (includeSoundControlInNavigator true) > (magicHalos false) > (menuAppearance3d false) > (menuKeyboardControl false) > (modalColorPickers true) > (mouseOverHalos false) > (mvcProjectsAllowed false) > (preserveTrash true) > (projectViewsInWindows false) > (promptForUpdateServer false) > (propertySheetFromHalo false) > (roundedMenuCorners false) > (roundedWindowCorners false) > (securityChecksEnabled true) > + (standaloneSecurityChecksEnabled true) > + (duplicateControlAndAltKeys true) > (showDirectionHandles false) > (showDirectionForSketches true) > (showProjectNavigator false) > (showSecurityStatus false) > (soundQuickStart true) "see setPlatformPreferences" > (soundReverb false) > (soundStopWhenDone true) "see setPlatformPreferences" > (startInUntrustedDirectory true) > (sugarAutoSave false) > (swapControlAndAltKeys false) "see setPlatformPreferences" > (uniqueNamesInHalos true) > (unlimitedPaintArea false) > (useArtificialSweetenerBar true) > (useBiggerPaintingBox true) > (useFormsInPaintBox false) > (useLocale true) > (usePangoRenderer false) > (usePlatformFonts false) > (usePopUpArrows true) > (warnAboutInsecureContent false) > > "The following is to make sure the default is set properly." > > (abbreviatedBrowserButtons false) > (allowEtoyUserCustomEvents false) > (alphabeticalProjectMenu false) > (alternativeBrowseIt false) > (alternativeButtonsInScrollBars false) > (alternativeWindowBoxesLook true) > (alwaysHideHScrollbar false) > (alwaysShowConnectionVocabulary false) > (alwaysShowHScrollbar false) > (alwaysShowVScrollbar true) > (ansiAssignmentOperatorWhenPrettyPrinting true) > (areaFillsAreTolerant false) > (areaFillsAreVeryTolerant false) > (autoAccessors false) > (automaticFlapLayout true) > (automaticPlatformSettings true) "enables setPlatformPreferences" > (automaticViewerPlacement true) > (balloonHelpEnabled true) > (balloonHelpInMessageLists false) > (batchPenTrails false) > (biggerCursors true) > (browserNagIfNoClassComment true) > (browserShowsPackagePane false) > (browseWithPrettyPrint false) > (capitalizedReferences true) > (caseSensitiveFinds false) > (cautionBeforeClosing false) > (celesteHasStatusPane false) > (celesteShowsAttachmentsFlag false) > (changeSetVersionNumbers true) > (checkForSlips true) > (checkForUnsavedProjects true) > (classicNewMorphMenu false) > (clickOnLabelToEdit false) > (cmdDotEnabled true) > (collapseWindowsInPlace false) > (colorWhenPrettyPrinting false) > (compressFlashImages false) > (confirmFirstUseOfStyle true) > (conversionMethodsAtFileOut false) > (cpuWatcherEnabled false) > (debugHaloHandle false) > (debugPrintSpaceLog false) > (debugShowDamage false) > (decorateBrowserButtons true) > (defaultFileOutFormatMacRoman false) > (diffsInChangeList true) > (diffsWithPrettyPrint false) > (dismissAllOnOptionClose false) > (dismissEventTheatreUponPublish true) > (dragNDropWithAnimation false) > (dropProducesWatcher true) > (duplicateControlAndAltKeys false) > (easySelection false) > (enableInternetConfig false) > (enablePortraitMode false) > (enableVirtualOLPCDisplay false) > (expandedPublishing true) > (extractFlashInHighestQuality false) > (extractFlashInHighQuality true) > (fastDragWindowForMorphic true) > (fenceEnabled true) > (fenceSoundEnabled false) > (fullScreenLeavesDeskMargins true) > (gradientScrollBars true) > (haloEnclosesFullBounds false) > (higherPerformance false) > (ignoreStyleIfOnlyBold true) > (implicitSelfInTiles false) > (inboardScrollbars true) > (infiniteUndo false) > (keepTickingWhilePainting false) > (logDebuggerStackToFile true) > (menuButtonInToolPane false) > (menuColorFromWorld false) > (menuWithIcons true) > (morphicProgressStyle true) > (mouseOverForKeyboardFocus false) > (navigatorOnLeftEdge true) > (noviceMode false) > (okToReinitializeFlaps true) > (oliveHandleForScriptedObjects false) > (optionalButtons true) > (passwordsOnPublish false) > (personalizedWorldMenu true) > (postscriptStoredAsEPS false) > (printAlternateSyntax false) > (projectsSentToDisk false) > (projectZoom true) > (readDocumentAtStartup true) > (restartAlsoProceeds false) > (reverseWindowStagger true) > (rotationAndScaleHandlesInPaintBox false) > (scrollBarsNarrow false) > (scrollBarsOnRight true) > (scrollBarsWithoutMenuButton false) > (selectionsMayShrink true) > (selectiveHalos true) > (showAdvancedNavigatorButtons false) > (showBoundsInHalo false) > (showDeprecationWarnings false) > (showFlapsWhenPublishing false) > (showLinesInHierarchyViews true) > (showSharedFlaps true) > (signProjectFiles true) > (simpleMenus false) > (slideDismissalsToTrash true) > (smartUpdating true) > (soundsEnabled true) > (swapMouseButtons false) > (systemWindowEmbedOK false) > (tabAmongFields true) > (testRunnerShowAbstractClasses false) > (thoroughSenders true) > (tileTranslucentDrag true) > (timeStampsInMenuTitles true) > (translationWithBabel false) > (turnOffPowerManager false) > (twentyFourHourFileStamps true) > (twoSidedPoohTextures true) > (typeCheckingInTileScripting true) > (unifyNestedProgressBars true) > (uniTilesClassic true) > (universalTiles false) > (updateFromServerAtStartup false) > (updateSavesFile false) > (useButtonPropertiesToFire false) > (useFileList2 true) > (useSmartLabels false) > (useUndo true) > (useVectorVocabulary false) > (viewersInFlaps true) > (warnIfNoChangesFile false) > (warnIfNoSourcesFile false) > (warningForMacOSFileNameLength false) > (wordStyleCursorMovement true) > > ). > > Preferences setPreference: #haloTheme toValue: #iconicHaloSpecifications. > ! > > Item was changed: > ----- Method: Project class>>cleanUpEtoysGarbage (in category '*Etoys-Squeakland-utilities') ----- > cleanUpEtoysGarbage > "Project cleanUpEtoysGarbage" > "All these should eventuall go away and be fixed, but for now we have this here." > Smalltalk garbageCollect. > "Clear weak message sends to remove modal windows from worlds that are closing." > (WeakMessageSend allInstances select: [:wm | > (wm receiver isKindOf: PasteUpMorph) and: [wm selector = #removeModalWindow]]) do: [:wm | wm receiver: nil]. > "Clear the weak dictionary on the class side that keeps node state around in the rewriter" > KedamaEvaluatorNodeState initialize. > "Clear the KedamaEvaluator that holds on to the last Kedama world" > ScriptEditorMorph setDefaultEvaluator. > "Clear the hard references to player classes, " > (Smalltalk organization listAtCategoryNamed: 'UserObjects') do: [:name | > Smalltalk forgetClass: (Smalltalk classNamed: name) logged: false]. > Player withAllSubclasses > select: [:c | c isSystemDefined not] > + thenDo: [:c | > + c theNonMetaClass superclass removeSubclass: c theNonMetaClass. > + c theMetaClass superclass removeSubclass: c theMetaClass]. > - thenDo: [:c | c superclass removeSubclass: c]. > "Clear the paste buffer" > HandMorph initialize. > "Clear the reference to the project tree in SkObject" > + (Smalltalk classNamed: 'SkObject') ifNotNil: [:c | c initialize]. > - Smalltalk at: #SkObject ifPresent: [:cls| cls initialize]. > PasteUpMorph allInstancesDo: [:m | m presenter ifNotNil: [:p | p flushPlayerListCache]]. > Smalltalk garbageCollect! > > Item was added: > + ----- Method: ReleaseBuilderSqueakland class>>intermediatePrepareForUsers (in category 'scripts') ----- > + intermediatePrepareForUsers > + "self intermediatePrepareForUsers" > + Project cleanUpEtoysGarbage. > + Smalltalk zapAllOtherProjects. > + Project cleanUpEtoysGarbage. > + ReleaseBuilder clearCaches. > + ObjectScanner new. "clear ObjectScanner's class pool" > + ExternalSettings registerClient: ServerDirectory. > + Project cleanUpEtoysGarbage. > + ReleaseBuilderSqueakland configureDesktop. > + ReleaseBuilderSqueakland setPreferences. > + Model useColorfulWindows: true.! >

2 1

Re: [squeak-dev] The Trunk: Morphic-nice.1313.mcz
by Chris Muller 27 Oct '16

27 Oct '16

Yaay, we've got mail! Thank you, Tobias. On Wed, Oct 26, 2016 at 7:35 PM, <commits(a)source.squeak.org> wrote: > Nicolas Cellier uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-nice.1313.mcz > > ==================== Summary ==================== > > Name: Morphic-nice.1313 > Author: nice > Time: 27 October 2016, 2:34:24.410239 am > UUID: b6649d12-cd6a-4957-94c0-ddc37d0f253a > Ancestors: Morphic-tpr.1312 > > Correct the text selection when extending down over a long word that was rejected on next line. > > The scenario is when a long word following a space does not fit on the end of line: it is displayed on next line. > If user click right after the space and extend the selection by dragging down on next line, then the selection from left of next line to right of space is not displayed. > > This is because the start CharacterBlock has its topLeft = space topRight (+ eventual kern). > Fortunately, a simple <= test instead of < solves the problem. > > =============== Diff against Morphic-tpr.1312 =============== > > Item was changed: > ----- Method: NewParagraph>>displaySelectionInLine:on: (in category 'display') ----- > displaySelectionInLine: line on: aCanvas > | leftX rightX w | > selectionStart ifNil: [^self]. "No selection" > aCanvas isShadowDrawing ifTrue: [ ^self ]. "don't draw selection with shadow" > selectionStart = selectionStop > ifTrue: > ["Only show caret on line where clicked" > > selectionStart textLine ~= line ifTrue: [^self]] > ifFalse: > ["Test entire selection before or after here" > > (selectionStop stringIndex < line first > or: [selectionStart stringIndex > (line last + 1)]) ifTrue: [^self]. "No selection on this line" > (selectionStop stringIndex = line first > and: [selectionStop textLine ~= line]) ifTrue: [^self]. "Selection ends on line above" > (selectionStart stringIndex = (line last + 1) > and: [selectionStop textLine ~= line]) ifTrue: [^self]]. "Selection begins on line below" > + leftX := (selectionStart stringIndex <= line first > - leftX := (selectionStart stringIndex < line first > ifTrue: [line ] > ifFalse: [selectionStart ])left. > rightX := (selectionStop stringIndex > (line last + 1) or: > [selectionStop stringIndex = (line last + 1) > and: [selectionStop textLine ~= line]]) > ifTrue: [line right] > ifFalse: [selectionStop left]. > selectionStart = selectionStop > ifTrue: [ > rightX := rightX + 1. > caretRect := (leftX-2) @ line top corner: (rightX+2)@ line bottom. "sigh..." > self showCaret ifFalse: [^self]. > w := (Editor dumbbellCursor > ifTrue: [self displayDumbbellCursorOn: aCanvas at: leftX in: line] > ifFalse: [self displaySimpleCursorOn: aCanvas at: leftX in: line]). > caretRect := (leftX-w) @ line top corner: (rightX+w)@ line bottom] > ifFalse: [ > caretRect := nil. > aCanvas fillRectangle: (leftX @ line top corner: rightX @ line bottom) > color: (self focused ifTrue: [self selectionColor] ifFalse: [self unfocusedSelectionColor])]! > >

1 0

Re: [squeak-dev] The Trunk: Morphic-nice.1313.mcz
by Nicolas Cellier 27 Oct '16

27 Oct '16

Not sure if it's OK for anything else than leftFlush, but this one was upsetting me for a while (inspector panes are often narrow in debuggers) And +1000 thanks for restoring the review-by-mail feature while now providing full MC history 2016-10-27 2:35 GMT+02:00 <commits(a)source.squeak.org>: > Nicolas Cellier uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-nice.1313.mcz > > ==================== Summary ==================== > > Name: Morphic-nice.1313 > Author: nice > Time: 27 October 2016, 2:34:24.410239 am > UUID: b6649d12-cd6a-4957-94c0-ddc37d0f253a > Ancestors: Morphic-tpr.1312 > > Correct the text selection when extending down over a long word that was > rejected on next line. > > The scenario is when a long word following a space does not fit on the end > of line: it is displayed on next line. > If user click right after the space and extend the selection by dragging > down on next line, then the selection from left of next line to right of > space is not displayed. > > This is because the start CharacterBlock has its topLeft = space topRight > (+ eventual kern). > Fortunately, a simple <= test instead of < solves the problem. > > =============== Diff against Morphic-tpr.1312 =============== > > Item was changed: > ----- Method: NewParagraph>>displaySelectionInLine:on: (in category > 'display') ----- > displaySelectionInLine: line on: aCanvas > | leftX rightX w | > selectionStart ifNil: [^self]. "No selection" > aCanvas isShadowDrawing ifTrue: [ ^self ]. "don't draw > selection with shadow" > selectionStart = selectionStop > ifTrue: > ["Only show caret on line where clicked" > > selectionStart textLine ~= line ifTrue: [^self]] > ifFalse: > ["Test entire selection before or after here" > > (selectionStop stringIndex < line first > or: [selectionStart stringIndex > (line > last + 1)]) ifTrue: [^self]. "No selection on this line" > (selectionStop stringIndex = line first > and: [selectionStop textLine ~= line]) > ifTrue: [^self]. "Selection ends on line above" > (selectionStart stringIndex = (line last + 1) > and: [selectionStop textLine ~= line]) > ifTrue: [^self]]. "Selection begins on line below" > + leftX := (selectionStart stringIndex <= line first > - leftX := (selectionStart stringIndex < line first > ifTrue: [line ] > ifFalse: [selectionStart ])left. > rightX := (selectionStop stringIndex > (line last + 1) or: > [selectionStop stringIndex = (line > last + 1) > and: [selectionStop > textLine ~= line]]) > ifTrue: [line right] > ifFalse: [selectionStop left]. > selectionStart = selectionStop > ifTrue: [ > rightX := rightX + 1. > caretRect := (leftX-2) @ line top corner: > (rightX+2)@ line bottom. "sigh..." > self showCaret ifFalse: [^self]. > w := (Editor dumbbellCursor > ifTrue: [self displayDumbbellCursorOn: > aCanvas at: leftX in: line] > ifFalse: [self displaySimpleCursorOn: > aCanvas at: leftX in: line]). > caretRect := (leftX-w) @ line top corner: > (rightX+w)@ line bottom] > ifFalse: [ > caretRect := nil. > aCanvas fillRectangle: (leftX @ line top corner: > rightX @ line bottom) > color: (self focused ifTrue: [self > selectionColor] ifFalse: [self unfocusedSelectionColor])]! > > >

1 0

source.squeak.org down [EOM]
by Fabio Niephaus 26 Oct '16

26 Oct '16

4 6