Squeak-dev June 2015

squeak-dev@lists.squeakfoundation.org

35 participants
162 discussions

Is this a bug with Step "Over"?
by Chris Muller 26 Jun '15

26 Jun '15

3 timesRepeat: [Warning signal]. 10 factorial Select the above in a workspace, select "debug it" then, in the debugger, click the "Over" button just once. 3 Warning pre-debuggers appear instantly and then the execution moves to the "factorial". Warnings have the opportunity to resume or cancel? IOW, shouldn't it work more like as if it were a halt? 3 timesRepeat: [ self halt ]. 10 factorial

8 31

Looking for a volunteer to help with DataStream on Spur
by Eliot Miranda 26 Jun '15

26 Jun '15

Hi All, Spur adds two new immediate classes, Character and SmallFloat64. It also adds 61-bit SmallIntegers in 64-bits. DataStream/ReferenceStream/SmartRefStream are all affected by this. e.g. ReferenceStream testWith: $a fails on 32-bit and 64-bit Spur. ReferenceStream testWith: SmallInteger maxVal fails (silently, to be fixed soon) on 64-bit Spur. Is anyone kind enough and motivated enough to give this code some love and at least make it work for 32-bit Spur => 32-bit Spur 64-bit Spur => 64-bit Spur but also hopefully for 32-bit Spur <=> 64-bit Spur 32-bit V3 => 32-bit Spur 32-bit V3 => 64-bit Spur ? On Tue, Feb 3, 2015 at 8:59 AM, Stéphane Rollandin <lecteur(a)zogotounga.net> wrote: > Yes. Can you send me a pair of doits for me to test this, one I can run >> in v3 and one I can run in Spur? >> > > I'm trying to set-up a faulty expression, but it is not so easy. > > Meanwhile I stumbled upon a similar bug: > > $a asReferenceStream reset fileInObjectAndCode > > The above succeeds in V3 and raises an error in Spur. Same reason: > basicNew being sent to Character. > > > But I'n curious, why codePoint: rather than >> >> createFrom: aSmartRefStream size: varsOnDisk version: instVarList >> >> ^ self value: instVarList first >> >> ? >> > > Well I got used to codePoint: ... Also value: has a lot more implementors > and senders and does not mean much by itself. Actually I never thought > about this. > > > > -- best, Eliot

2 5

Daily Commit Log
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-June/008749.html Name: System-topa.741 Ancestors: System-eem.740 Ensure characters read and write on Data/Ref streams todo: SmartRef ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-June/008750.html Name: Tests-topa.320 Ancestors: Tests-ul.319 Sanity tests for Data/Ref/Smart Streams Works on V3 images, not yet on V5/Spur ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-June/008751.html Name: System-topa.742 Ancestors: System-topa.741 Shortcut float types for DataStream. This is messy but the alternatives aren't better. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-June/008752.html Name: System-topa.743 Ancestors: System-topa.742 Character special-casing: as for DataStream as for SmartRefStream ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-June/008753.html Name: Tests-topa.321 Ancestors: Tests-topa.320 Serializing sanity test should work now. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-June/008754.html Name: Tests-topa.322 Ancestors: Tests-topa.321 More sanity tests =============================================

1 0

The Trunk: Tests-topa.322.mcz
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Tobias Pape uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-topa.322.mcz ==================== Summary ==================== Name: Tests-topa.322 Author: topa Time: 25 June 2015, 10:48:51.189 am UUID: 316824e1-862e-45bc-9eac-efb092c6d6ae Ancestors: Tests-topa.321 More sanity tests =============== Diff against Tests-topa.321 =============== Item was added: + ----- Method: DataStreamTest>>testLargeIntergers (in category 'tests') ----- + testLargeIntergers + | i | + i := 123456789012345678901234567890. + self assert: i equals: (self testObject: i) description: 'A large positive integer should be serializable'. + + i := -123456789012345678901234567890. + self assert: i equals: (self testObject: i) description: 'A large negative integer should be serializable'! Item was added: + ----- Method: DataStreamTest>>testNotTooLargeIntergers (in category 'tests') ----- + testNotTooLargeIntergers + | i | + i := 1234567890123. + self assert: i equals: (self testObject: i) description: 'A larger, but not too large positive integer should be serializable'. + + i := -1234567890123. + self assert: i equals: (self testObject: i) description: 'A larger, but not too large negative integer should be serializable'!

1 0

The Trunk: Tests-topa.321.mcz
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Tobias Pape uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-topa.321.mcz ==================== Summary ==================== Name: Tests-topa.321 Author: topa Time: 25 June 2015, 10:30:21.225 am UUID: 3ff0bd61-7798-45fb-8d60-37fc2036bc8c Ancestors: Tests-topa.320 Serializing sanity test should work now. =============== Diff against Tests-topa.320 =============== Item was removed: - ----- Method: SmartRefStreamTest>>expectedFailures (in category 'as yet unclassified') ----- - expectedFailures - - ^ Character instSize = 0 - ifTrue: [#( testCharacter )] - ifFalse: [#()]!

1 0

The Trunk: System-topa.743.mcz
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Tobias Pape uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-topa.743.mcz ==================== Summary ==================== Name: System-topa.743 Author: topa Time: 25 June 2015, 10:28:42.468 am UUID: c215550f-71ae-4d36-859e-c11709db1363 Ancestors: System-topa.742 Character special-casing: as for DataStream as for SmartRefStream =============== Diff against System-topa.742 =============== Item was changed: ----- Method: SmartRefStream>>readInstanceSize:clsname:refPosn: (in category 'read write') ----- readInstanceSize: instSize clsname: className refPosn: refPosn "The common code to read the contents of an arbitrary instance. ASSUMES: readDataFrom:size: sends me beginReference: after it instantiates the new object but before reading nested objects. NOTE: We must restore the current reference position after recursive calls to next. Three cases for files from older versions of the system: 1) Class has not changed shape, read it straight. 2) Class has changed instance variables (or needs fixup). Call a particular method to do it. 3) There is a new class instead. Find it, call a particular method to read. All classes used to construct the structures dictionary *itself* need to be in 'steady' and they must not change!! See setStream:" | anObject newName newClass dict oldInstVars isMultiSymbol | self flag: #bobconv. self setCurrentReference: refPosn. "remember pos before readDataFrom:size:" newName := renamed at: className ifAbsent: [className]. + newName == #Character + ifTrue: [^ self readCharacterOfSize: instSize]. isMultiSymbol := newName = #MultiSymbol or: [newName = #WideSymbol]. "isMultiSymbol ifTrue: [self halt]." newClass := Smalltalk at: newName asSymbol. (steady includes: newClass) & (newName == className) ifTrue: [ anObject := newClass isVariable "Create it here" ifFalse: [newClass basicNew] ifTrue: [newClass basicNew: instSize - (newClass instSize)]. anObject := anObject readDataFrom: self size: instSize. self setCurrentReference: refPosn. "before returning to next" isMultiSymbol ifTrue: [^ Symbol intern: anObject asString]. ^ anObject]. oldInstVars := structures at: className ifAbsent: [ self error: 'class is not in structures list']. "Missing in object file" anObject := newClass createFrom: self size: instSize version: oldInstVars. "only create the instance" self beginReference: anObject. dict := self catalogValues: oldInstVars size: instSize. "indexed vars as (1 -> val) etc." dict at: #ClassName put: className. "so conversion method can know it" "Give each superclass a chance to make its changes" self storeInstVarsIn: anObject from: dict. "ones with the same names" anObject := self applyConversionMethodsTo: anObject className: className varMap: dict. self setCurrentReference: refPosn. "before returning to next" isMultiSymbol ifTrue: [^ Symbol intern: anObject asString]. ^ anObject!

1 0

The Trunk: System-topa.742.mcz
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Tobias Pape uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-topa.742.mcz ==================== Summary ==================== Name: System-topa.742 Author: topa Time: 25 June 2015, 10:25:17.963 am UUID: fb848387-2569-4297-bcbe-3b292a38b654 Ancestors: System-topa.741 Shortcut float types for DataStream. This is messy but the alternatives aren't better. =============== Diff against System-topa.741 =============== Item was changed: ----- Method: DataStream>>typeIDFor: (in category 'write and read') ----- typeIDFor: anObject "Return the typeID for anObject's class. This is where the tangle of objects is clipped to stop everything from going out. Classes can control their instance variables by defining objectToStoreOnDataStream. Any object in blockers is not written out. See ReferenceStream.objectIfBlocked: and DataStream nextPut:. Morphs do not write their owners. See Morph.storeDataOn: Each morph tells itself to 'prepareToBeSaved' before writing out." + + + anObject isFloat ifTrue: [^14]. "shortcut floats of any representation." - ^ TypeMap at: anObject class ifAbsent: [9 "instance of any normal class"] "See DataStream initialize. nil=1. true=2. false=3. a SmallInteger=4. (a String was 5). a Symbol=6. a ByteArray=7. an Array=8. other = 9. a Bitmap=11. a Metaclass=12. a Float=14. a Rectangle=15. any instance that can have a short header=16. a String=17 (new format). a WordArray=18."!

1 0

The Trunk: Tests-topa.320.mcz
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Tobias Pape uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-topa.320.mcz ==================== Summary ==================== Name: Tests-topa.320 Author: topa Time: 25 June 2015, 10:17:43.498 am UUID: b92ca80d-36da-49c7-90b5-4cc7e29faa8c Ancestors: Tests-ul.319 Sanity tests for Data/Ref/Smart Streams Works on V3 images, not yet on V5/Spur =============== Diff against Tests-ul.319 =============== Item was added: + TestCase subclass: #DataStreamTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-System-Object Storage'! Item was added: + ----- Method: DataStreamTest>>get: (in category 'helper') ----- + get: aSerialized + + ^ self streamClass unStream: aSerialized! Item was added: + ----- Method: DataStreamTest>>put: (in category 'helper') ----- + put: anObject + + ^ self streamClass streamedRepresentationOf: anObject.! Item was added: + ----- Method: DataStreamTest>>streamClass (in category 'constants') ----- + streamClass + ^ DataStream! Item was added: + ----- Method: DataStreamTest>>testCharacter (in category 'tests') ----- + testCharacter + | c | + c := Character value: 16r271D. + self assert: c equals: (self testObject: c) description: 'Characters should be serializable'! Item was added: + ----- Method: DataStreamTest>>testFloat (in category 'tests') ----- + testFloat + | f | + f := Float pi. + self assert: f equals: (self testObject: f) description: 'Floats should be serializable'. + ! Item was added: + ----- Method: DataStreamTest>>testObject: (in category 'helper') ----- + testObject: anObject + + | serialized | + serialized := self put: anObject. + ^ self get: serialized! Item was added: + ----- Method: DataStreamTest>>testSmallInteger (in category 'tests') ----- + testSmallInteger + | i | + i := SmallInteger maxVal. + self assert: i equals: (self testObject: i) description: 'The maximum small integer should be serializable'. + + i := SmallInteger minVal. + self assert: i equals: (self testObject: i) description: 'The minimum small integer should be serializable'! Item was added: + DataStreamTest subclass: #ReferenceStreamTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-System-Object Storage'! Item was added: + ----- Method: ReferenceStreamTest>>streamClass (in category 'constants') ----- + streamClass + ^ ReferenceStream! Item was added: + ReferenceStreamTest subclass: #SmartRefStreamTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Tests-System-Object Storage'! Item was added: + ----- Method: SmartRefStreamTest>>expectedFailures (in category 'as yet unclassified') ----- + expectedFailures + + ^ Character instSize = 0 + ifTrue: [#( testCharacter )] + ifFalse: [#()]! Item was added: + ----- Method: SmartRefStreamTest>>put: (in category 'helper') ----- + put: anObject + + | s | + s := RWBinaryOrTextStream on: (ByteArray new: 500). + (self streamClass on: s) + nextPutObjOnly: anObject; + close. + ^ s contents! Item was added: + ----- Method: SmartRefStreamTest>>streamClass (in category 'constants') ----- + streamClass + ^ SmartRefStream!

1 0

The Trunk: System-topa.741.mcz
by commits＠source.squeak.org 25 Jun '15

25 Jun '15

Tobias Pape uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-topa.741.mcz ==================== Summary ==================== Name: System-topa.741 Author: topa Time: 25 June 2015, 10:14:29.118 am UUID: c6c42b80-9c1d-4abd-acf8-3b1b8bfce809 Ancestors: System-eem.740 Ensure characters read and write on Data/Ref streams todo: SmartRef =============== Diff against System-eem.740 =============== Item was changed: ----- Method: DataStream class>>example (in category 'as yet unclassified') ----- example "An example and test of DataStream/ReferenceStream. 11/19/92 jhm: Use self testWith:." "DataStream example" "ReferenceStream example" | input sharedPoint | "Construct the test data." + input := Array new: 10. - input := Array new: 9. input at: 1 put: nil. input at: 2 put: true. input at: 3 put: (Form extent: 63 @ 50 depth: 8). (input at: 3) fillWithColor: Color lightBlue. input at: 4 put: #(3 3.0 'three'). input at: 5 put: false. input at: 6 put: 1024 @ -2048. input at: 7 put: #x. input at: 8 put: (Array with: (sharedPoint := 0 @ -30000)). input at: 9 put: sharedPoint. + input at: 10 put: (Character value: 16r200d). "Write it out, read it back, and return it for inspection." ^ self testWith: input! Item was added: + ----- Method: DataStream>>readCharacterOfSize: (in category 'write and read') ----- + readCharacterOfSize: instSize + | refPosn val | + self assert: instSize = 1. + refPosn := self getCurrentReference. + self setCurrentReference: refPosn. + val := self next. + ^ Character value: val. + ! Item was changed: ----- Method: DataStream>>readInstance (in category 'write and read') ----- readInstance "PRIVATE -- Read the contents of an arbitrary instance. ASSUMES: readDataFrom:size: sends me beginReference: after it instantiates the new object but before reading nested objects. NOTE: We must restore the current reference position after recursive calls to next. Let the instance, not the class read the data. " | instSize aSymbol refPosn anObject newClass | instSize := (byteStream nextNumber: 4) - 1. refPosn := self getCurrentReference. aSymbol := self next. + aSymbol == #Character + ifTrue: [^ self readCharacterOfSize: instSize]. newClass := Smalltalk at: aSymbol asSymbol. anObject := newClass isVariable "Create object here" ifFalse: [newClass basicNew] ifTrue: [newClass basicNew: instSize - (newClass instSize)]. self setCurrentReference: refPosn. "before readDataFrom:size:" anObject := anObject readDataFrom: self size: instSize. self setCurrentReference: refPosn. "before returning to next" ^ anObject!

1 0

able to resume non-resumable Errors in the Debugger
by Chris Muller 25 Jun '15

25 Jun '15

Error signal. 3 "Error, but then press Proceed ----> 3" [Error signal] on: Error do: [ : err | err resume: 3 ] "IllegalResumeAttempt, but then press Proceed -----> 3" This is not a regression from 4.5, but something to be aware of when using the debugger, because Error signalers assume the code that follows will not be run.

3 2

← Newer
1
2
3
4
5
6
7
8
9
...
17
Older →

Jump to page: