Squeak-dev April 2015

squeak-dev@lists.squeakfoundation.org

38 participants
642 discussions

Re: The Trunk: ToolBuilder-Morphic-cmm.109.mcz
by Marcel Taeumel 01 Apr '15

01 Apr '15

Hey Chris, yay, we need to strive for more consistency in the tools. This is a step in the right direction. :-) Here are some minor remarks: #setSelectedMorph: - Calling #selection: from within that is against the rules. This is only called as a reaction to model change. See #update:. #filterTree - Maybe we should not filter the children of the current selection but start with the siblings? Best, Marcel -- View this message in context: http://forum.world.st/The-Trunk-ToolBuilder-Morphic-cmm-109-mcz-tp4816694p4… Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

ObjectExplorer broken (was: Re: [squeak-dev] The Trunk: Tools-cmm.570.mcz)
by Levente Uzonyi 01 Apr '15

01 Apr '15

ObjectExplorer>>buildWith: sends #filteredItems, but there are no implementors in my Trunk image. It breaks ObjectExplorer. To reproduce it evaluate [1 explore]. Levente On Wed, 1 Apr 2015, commits(a)source.squeak.org wrote: > Chris Muller uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-cmm.570.mcz > > ==================== Summary ==================== > > Name: Tools-cmm.570 > Author: cmm > Time: 1 April 2015, 11:09:22.929 am > UUID: 7827a351-1a4d-4e83-bbef-7e900993ee62 > Ancestors: Tools-mt.569 > > - SimpleHierarchicalListMorph's now honor preferences: > mouseOverForKeyboardFocus > Vertical Smart Splitters > Filterable Lists Clear Automatically > - After filtering Tree, refit the column-widths to the filtered results. > > =============== Diff against Tools-mt.569 =============== > > Item was changed: > ----- Method: ObjectExplorer>>buildWith: (in category 'toolbuilder') ----- > buildWith: builder > > | windowSpec treeSpec textSpec | > windowSpec := builder pluggableWindowSpec new. > windowSpec > model: self; > children: OrderedCollection new; > label: #label. > > treeSpec := builder pluggableTreeSpec new. > treeSpec > model: self; > nodeClass: self class nodeClass; > roots: #getList; > keyPress: #explorerKey:from:event:; > getSelected: #currentSelection; > setSelected: #currentSelection:; > setSelectedParent: #currentParent:; > menu: #genericMenu:; > autoDeselect: false; > columns: (ObjectExplorerWrapper showContentsInColumns > ifTrue: [{ > + [:listMorph | (listMorph filteredItems collect: [:item | > - [:listMorph | (listMorph scroller submorphs collect: [:item | > item preferredWidthOfColumn: 1]) max]. > + nil "take all the space"}]); > - nil "take all the space"}] > - ifFalse: []); > frame: (0@0 corner: 1(a)0.85). > windowSpec children add: treeSpec. > > textSpec := builder pluggableTextSpec new. > textSpec > model: self; > menu: #codePaneMenu:shifted:; > help: 'Evaluate expressions for the current tree selection...' translated; > frame: (0(a)0.85 corner: 1@1). > windowSpec children add: textSpec. > > ^ builder build: windowSpec! > > >

2 2

Re: [squeak-dev] The Trunk: Morphic-cmm.798.mcz
by Levente Uzonyi 01 Apr '15

01 Apr '15

The version number of this package is less than its ancestor's. The same is true for ToolBuilder-Morphic-cmm.109, and Tools-cmm.569.mcz. I don't think all tools - including the update mechanism - are prepared for this. Is it intentional? Levente On Wed, 1 Apr 2015, commits(a)source.squeak.org wrote: > Chris Muller uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-cmm.798.mcz > > ==================== Summary ==================== > > Name: Morphic-cmm.798 > Author: cmm > Time: 1 April 2015, 11:12:43.922 am > UUID: b125e333-58b0-4a00-985f-846891e8e046 > Ancestors: Morphic-cmm.805 > > - SimpleHierarchicalListMorph's now honor preferences: > mouseOverForKeyboardFocus > Vertical Smart Splitters > - Don't let splitter bars be dragged further than their PluggableListMorphs want them to go. > - PluggableTextMorph's now honor Vertical Smart Splitters to avoid wrapped lines, if possible. > > =============== Diff against Morphic-cmm.805 =============== > > Item was added: > + ----- Method: ScrollPane>>hasScrollBar (in category 'testing') ----- > + hasScrollBar > + ^ scrollBar isInWorld! > > >

1 0

The Trunk: Morphic-cmm.798.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.798.mcz ==================== Summary ==================== Name: Morphic-cmm.798 Author: cmm Time: 1 April 2015, 11:12:43.922 am UUID: b125e333-58b0-4a00-985f-846891e8e046 Ancestors: Morphic-cmm.805 - SimpleHierarchicalListMorph's now honor preferences: mouseOverForKeyboardFocus Vertical Smart Splitters - Don't let splitter bars be dragged further than their PluggableListMorphs want them to go. - PluggableTextMorph's now honor Vertical Smart Splitters to avoid wrapped lines, if possible. =============== Diff against Morphic-cmm.805 =============== Item was added: + ----- Method: ScrollPane>>hasScrollBar (in category 'testing') ----- + hasScrollBar + ^ scrollBar isInWorld!

1 0

The Trunk: Tools-cmm.569.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Chris Muller uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-cmm.569.mcz ==================== Summary ==================== Name: Tools-cmm.569 Author: cmm Time: 1 April 2015, 11:13:09.646 am UUID: 71088346-ff2c-4086-8042-bf3407e20986 Ancestors: Tools-cmm.570 - SimpleHierarchicalListMorph's now honor preferences: mouseOverForKeyboardFocus Vertical Smart Splitters Filterable Lists Clear Automatically - After filtering Tree, refit the column-widths to the filtered results. =============== Diff against Tools-cmm.570 ===============

1 0

The Trunk: ToolBuilder-Morphic-cmm.109.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-cmm.109.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-cmm.109 Author: cmm Time: 1 April 2015, 11:12:32.023 am UUID: 109fa949-8213-4e07-855c-90ad83b6ab07 Ancestors: ToolBuilder-Morphic-mt.111 - PluggableTreeMorph support for Vertical Smart Splitters. - Let single-level filtering also be a navigation gesture. - After filtering a Tree, refit the column-widths to the filtered results. - SimpleHierarchicalListMorph support mouseOverForKeyboardFocus. - Fix selection rendering in PluggableTreeMorph (FileList and SqueakMap). =============== Diff against ToolBuilder-Morphic-mt.111 =============== Item was added: + ----- Method: PluggableTreeMorph>>bottomVisibleRowIndex (in category 'geometry') ----- + bottomVisibleRowIndex + | itemAtBottom | + itemAtBottom := self itemFromPoint: self bottomLeft + (3 @ -3). + ^ itemAtBottom + ifNil: [ scroller submorphs size ] + ifNotNil: + [ : item | scroller submorphs indexOf: item ]! Item was added: + ----- Method: PluggableTreeMorph>>charactersOccluded (in category 'geometry') ----- + charactersOccluded + ^ self visibleItems + inject: 0 + into: + [ : sum : each | sum + each charactersOccluded ]! Item was changed: ----- Method: PluggableTreeMorph>>filterTree (in category 'filtering') ----- filterTree + self hasFilter ifFalse: + [ self removeFilter. + ^ self ]. - - self hasFilter ifFalse: [ - self removeFilter. - ^ self]. - self indicateFiltered. - "Clean up the tree." (self selectedMorph + ifNil: [ self roots ] + ifNotNil: + [ : m | {m} ]) do: + [ : item | | filteredItems | + item applyFilter: lastKeystrokes. + item visible ifFalse: + [ "Do not hide the item where the filter is based on." + item show. + item isExpanded ifFalse: [ item toggleExpandedState ] ]. + filteredItems := self filteredItems. + "If configured as a navigation tool, advance the selection." + (PluggableTreeMorph maximumSearchDepth = 1 and: [ PluggableTreeMorph filterByLabelsOnly not ]) ifTrue: + [ (filteredItems notEmpty and: [ selectedMorph ~= filteredItems last ]) ifTrue: + [ self setSelectedMorph: (filteredItems after: selectedMorph). + selectedMorph isExpanded ifFalse: [ selectedMorph toggleExpandedState ] ] ] ]. + self adjustSubmorphPositions! - ifNil: [self roots] - ifNotNil: [:m | {m}]) do: [:item | - item applyFilter: lastKeystrokes. - item visible ifFalse: [ - "Do not hide the item where the filter is based on." - item show. - item isExpanded ifTrue: [item toggleExpandedState]]]. - - self adjustSubmorphPositions.! Item was added: + ----- Method: PluggableTreeMorph>>filteredItems (in category 'filtering') ----- + filteredItems + "Answer the items which visible because they matched the current filters." + ^ self items select: [ : each | each visible ]! Item was added: + ----- Method: PluggableTreeMorph>>items (in category 'accessing') ----- + items + ^ scroller submorphs! Item was added: + ----- Method: PluggableTreeMorph>>keyboardFocusChange: (in category 'event handling') ----- + keyboardFocusChange: aBoolean + aBoolean ifFalse: + [ PluggableListMorph clearFilterAutomatically ifTrue: + [ self hasFilter ifTrue: [ self removeFilter ] ] ]! Item was changed: ----- Method: PluggableTreeMorph>>selectPath:in: (in category 'selection') ----- selectPath: path in: listItem path isEmpty ifTrue: [^self setSelectedMorph: nil]. listItem withSiblingsDo: [:each | (each complexContents item = path first) ifTrue: [ each isExpanded ifFalse: [ each toggleExpandedState. self adjustSubmorphPositions. ]. each changed. path size = 1 ifTrue: [ ^self setSelectedMorph: each ]. each firstChild ifNil: [^self setSelectedMorph: nil]. ^self selectPath: path allButFirst in: each firstChild ]. ]. ^self setSelectedMorph: nil ! Item was changed: ----- Method: PluggableTreeMorph>>setSelectedMorph: (in category 'selection') ----- setSelectedMorph: aMorph selectedWrapper := aMorph complexContents. + self selection: selectedWrapper. - "Let the model now about the selected object, not wrapper." setSelectionSelector ifNotNil: [:symbol | model perform: symbol + with: (selectedWrapper ifNotNil: [ selectedWrapper item ])]. - with: (selectedWrapper ifNotNil: [:w | w item])]. "The model may not have access to the parent object in terms of this tree structure." setSelectedParentSelector ifNotNil: [:symbol | model perform: symbol + with: (selectedWrapper ifNotNil: [selectedWrapper parent ifNotNil: [: parentWrapper | parentWrapper item]])].! - with: (selectedWrapper ifNotNil: [:w | w parent ifNotNil: [:pw | pw item]])].! Item was added: + ----- Method: PluggableTreeMorph>>topVisibleRowIndex (in category 'geometry') ----- + topVisibleRowIndex + ^ scroller submorphs indexOf: (self itemFromPoint: self topLeft+(3@3))! Item was added: + ----- Method: PluggableTreeMorph>>visibleItems (in category 'geometry') ----- + visibleItems + ^ self items + copyFrom: self topVisibleRowIndex + to: self bottomVisibleRowIndex!

1 0

The Trunk: Morphic-cmm.805.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.805.mcz ==================== Summary ==================== Name: Morphic-cmm.805 Author: cmm Time: 1 April 2015, 11:11:23.537 am UUID: 2667ac2e-7e09-4a67-8efe-2da1a499f090 Ancestors: Morphic-mt.804 - SimpleHierarchicalListMorph's now honor preferences: mouseOverForKeyboardFocus Vertical Smart Splitters - Don't let splitter bars be dragged further than their PluggableListMorphs want them to go. - PluggableTextMorph's now honor Vertical Smart Splitters to avoid wrapped lines, if possible. =============== Diff against Morphic-mt.804 =============== Item was added: + ----- Method: MorphicModel>>charactersOccluded (in category 'geometry') ----- + charactersOccluded + "Subclasses override as necessary to keep smart-splitters balanced." + ^ 0! Item was changed: + ----- Method: MorphicModel>>model (in category 'accessing') ----- - ----- Method: MorphicModel>>model (in category 'access') ----- model ^ model! Item was changed: + ----- Method: MorphicModel>>slotName (in category 'accessing') ----- - ----- Method: MorphicModel>>slotName (in category 'access') ----- slotName ^ slotName! Item was changed: + ----- Method: MorphicModel>>wantsSlot (in category 'accessing') ----- - ----- Method: MorphicModel>>wantsSlot (in category 'access') ----- wantsSlot "Override this default for models that want to be installed in theri model" ^ false! Item was changed: + ----- Method: PluggableListMorph>>charactersOccluded (in category 'geometry') ----- - ----- Method: PluggableListMorph>>charactersOccluded (in category 'accessing') ----- charactersOccluded "Answer the number of characters occluded in my #visibleList by my right edge." | listIndex | listIndex:=0. ^ self visibleList inject: 0 into: [ : sum : each | | eachString totalWidth indexOfLastVisible iconWidth | totalWidth:=0. eachString := each asString "withBlanksTrimmed". iconWidth := (self iconAt: (listIndex := listIndex+1)) ifNil:[0] ifNotNil: [ : icon | icon width+2 ]. indexOfLastVisible := ((1 to: eachString size) detect: [ : stringIndex | (totalWidth:=totalWidth+(self font widthOf: (eachString at: stringIndex))) > (self width - (scrollBar ifNil: [ 0 ] ifNotNil: [ scrollBar width ]) - iconWidth) ] ifNone: [ eachString size + 1 ]) - 1. sum + (eachString size - indexOfLastVisible) ]! Item was changed: ----- Method: PluggableListMorph>>iconAt: (in category 'model access') ----- iconAt: anInteger | index | index := (self hasFilter and: [list notNil]) + ifTrue: [self getFullList indexOf: (list at: anInteger ifAbsent: [^nil])] - ifTrue: [self getFullList indexOf: (list at: anInteger)] ifFalse: [anInteger]. ^ getIconSelector ifNotNil: [model perform: getIconSelector with: index]! Item was added: + ----- Method: PluggableListMorph>>initialize (in category 'geometry') ----- + initialize + super initialize. + self minWidth: 38! Item was added: + ----- Method: PluggableTextMorph>>charactersOccluded (in category 'geometry') ----- + charactersOccluded + "Let the receiver suggest to its neighboring vertical Splitter(s) that they try to optimize their position such that none of the receivers lines need to wrap." + | numberOfLogicalLines numberOfPhysicalLines | + numberOfLogicalLines := self text lineCount. + numberOfPhysicalLines:= textMorph paragraph numberOfLines. + ^ numberOfPhysicalLines - numberOfLogicalLines! Item was changed: ----- Method: ProportionalSplitterMorph>>charactersOccludedIn: (in category 'layout') ----- charactersOccludedIn: aCollection ^ aCollection inject: 0 into: [ : max : each | max max: + (each isMorphicModel - (each isPluggableListMorph ifTrue: [ each charactersOccluded ] ifFalse: [ 0 ]) ]! Item was added: + ----- Method: ScrollPane>>scrollBar (in category 'testing') ----- + scrollBar + ^ scrollBar! Item was added: + ----- Method: SimpleHierarchicalListMorph>>mouseLeave: (in category 'event handling') ----- + mouseLeave: aMouseEvent + super mouseLeave: aMouseEvent. + Preferences mouseOverForKeyboardFocus ifTrue: [ aMouseEvent hand releaseKeyboardFocus: self ]!

1 0

The Trunk: Tools-cmm.570.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Chris Muller uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-cmm.570.mcz ==================== Summary ==================== Name: Tools-cmm.570 Author: cmm Time: 1 April 2015, 11:09:22.929 am UUID: 7827a351-1a4d-4e83-bbef-7e900993ee62 Ancestors: Tools-mt.569 - SimpleHierarchicalListMorph's now honor preferences: mouseOverForKeyboardFocus Vertical Smart Splitters Filterable Lists Clear Automatically - After filtering Tree, refit the column-widths to the filtered results. =============== Diff against Tools-mt.569 =============== Item was added: + ----- Method: IndentingListItemMorph>>charactersOccluded (in category 'private') ----- + charactersOccluded + "Answer the number of characters occluded in my #visibleList by my right edge." + | listIndex leftEdgeOfRightmostColumn eachString indexOfLastVisible iconWidth totalWidth | + listIndex := 0. + leftEdgeOfRightmostColumn := container columns + ifNil: [ 0 ] + ifNotNil: + [ : cols | (1 to: cols size - 1) + inject: 0 + into: + [ : sum : each | sum + (self widthOfColumn: each) ] ]. + eachString := container columns + ifNil: [ self complexContents asString ] + ifNotNil: + [ : cols | self contentsAtColumn: container columns size ]. + iconWidth := self icon + ifNil: [ 0 ] + ifNotNil: + [ : icon | icon width + 2 ]. + totalWidth := self toggleBounds right. + indexOfLastVisible := ((1 to: eachString size) + detect: + [ : stringIndex | (totalWidth:=totalWidth+(self fontToUse widthOf: (eachString at: stringIndex))) > + (container width - + (container scrollBar + ifNil: [ 0 ] + ifNotNil: [ container scrollBar width ]) - iconWidth - leftEdgeOfRightmostColumn) ] + ifNone: [ eachString size + 1 ]) - 1. + ^ eachString size - indexOfLastVisible! Item was changed: ----- Method: IndentingListItemMorph>>drawOn: (in category 'drawing') ----- drawOn: aCanvas | tRect sRect columnScanner columnLeft | self backgroundColor ifNotNil: [:c | aCanvas fillRectangle: self innerBounds color: c]. tRect := self toggleRectangle. self drawToggleOn: aCanvas in: tRect. sRect := bounds withLeft: tRect right + 4. sRect := sRect top: sRect top + sRect bottom - self fontToUse height // 2. (container columns isNil or: [(contents asString indexOf: Character tab) = 0]) ifTrue: [ icon ifNotNil: [ aCanvas translucentImage: icon at: sRect left @ (self top + (self height - icon height // 2)). sRect := sRect left: sRect left + icon width + 2. ]. aCanvas drawString: contents asString in: sRect font: self fontToUse color: color. ] ifFalse: [ columnLeft := sRect left. columnScanner := ReadStream on: contents asString. container columns withIndexDo: [ :widthSpec :column | | columnRect columnData columnWidth | "Draw icon." column = self class iconColumnIndex ifTrue: [ icon ifNotNil: [ aCanvas translucentImage: icon at: columnLeft @ (self top + (self height - icon height // 2)). columnLeft := columnLeft + icon width + 2]]. + columnWidth := self widthOfColumn: column. - columnWidth := widthSpec isNumber - ifTrue: [widthSpec] - ifFalse: [widthSpec isBlock - ifTrue: [widthSpec cull: container cull: self] - ifFalse: [widthSpec ifNil: [self width] ifNotNil: [50 "Fall back"]]]. columnRect := columnLeft @ sRect top extent: columnWidth @ sRect height. columnData := columnScanner upTo: Character tab. "Draw string." columnData ifNotEmpty: [ aCanvas drawString: columnData in: columnRect font: self fontToUse color: color]. "Compute next column offset." columnLeft := columnRect right + 5. column = 1 ifTrue: [columnLeft := columnLeft - tRect right + self left]. ]. ]! Item was added: + ----- Method: IndentingListItemMorph>>widthOfColumn: (in category 'accessing - columns') ----- + widthOfColumn: columnIndex + | widthOrSpec | + container columns ifNil: [ ^ self width ]. + widthOrSpec := container columns at: columnIndex. + ^ widthOrSpec isNumber + ifTrue: [ widthOrSpec ] + ifFalse: + [ widthOrSpec isBlock + ifTrue: + [ widthOrSpec + cull: container + cull: self ] + ifFalse: + [ widthOrSpec + ifNil: [ self width ] + ifNotNil: [ "Fall back" + 50 ] ] ]! Item was changed: ----- Method: ObjectExplorer>>buildWith: (in category 'toolbuilder') ----- buildWith: builder | windowSpec treeSpec textSpec | windowSpec := builder pluggableWindowSpec new. windowSpec model: self; children: OrderedCollection new; label: #label. treeSpec := builder pluggableTreeSpec new. treeSpec model: self; nodeClass: self class nodeClass; roots: #getList; keyPress: #explorerKey:from:event:; getSelected: #currentSelection; setSelected: #currentSelection:; setSelectedParent: #currentParent:; menu: #genericMenu:; autoDeselect: false; columns: (ObjectExplorerWrapper showContentsInColumns ifTrue: [{ + [:listMorph | (listMorph filteredItems collect: [:item | - [:listMorph | (listMorph scroller submorphs collect: [:item | item preferredWidthOfColumn: 1]) max]. + nil "take all the space"}]); - nil "take all the space"}] - ifFalse: []); frame: (0@0 corner: 1(a)0.85). windowSpec children add: treeSpec. textSpec := builder pluggableTextSpec new. textSpec model: self; menu: #codePaneMenu:shifted:; help: 'Evaluate expressions for the current tree selection...' translated; frame: (0(a)0.85 corner: 1@1). windowSpec children add: textSpec. ^ builder build: windowSpec!

1 0

The Trunk: Morphic-mt.804.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.804.mcz ==================== Summary ==================== Name: Morphic-mt.804 Author: mt Time: 1 April 2015, 4:44:05.045 pm UUID: bbe870c0-cd4a-4f4d-b12a-7da72c2e797e Ancestors: Morphic-mt.803 Another fix for horizontal scroll bars in scroll panes, which affects layouting and scrolling. =============== Diff against Morphic-mt.803 =============== Item was changed: ----- Method: ScrollPane>>hLeftoverScrollRange (in category 'geometry') ----- hLeftoverScrollRange "Return the entire scrolling range minus the currently viewed area." | w | scroller hasSubmorphs ifFalse:[^0]. w := bounds width. self vIsScrollbarShowing ifTrue:[ w := w - self scrollBarThickness ]. + ^ (self hTotalScrollRange - w roundTo: self scrollDeltaWidth) max: 0 - ^ (self hTotalScrollRange - w roundTo: self scrollDeltaHeight) max: 0 ! Item was changed: ----- Method: ScrollPane>>hResizeScrollBar (in category 'geometry') ----- hResizeScrollBar | topLeft h border offset | "TEMPORARY: IF OLD SCROLLPANES LYING AROUND THAT DON'T HAVE A hScrollBar, INIT THEM" hScrollBar ifNil: [ self hInitScrollBarTEMPORARY]. (self valueOfProperty: #noHScrollBarPlease ifAbsent: [false]) ifTrue: [^self]. bounds ifNil: [ self fullBounds ]. h := self scrollBarThickness. border := borderWidth. + offset := (scrollBarOnLeft and: [self vIsScrollbarShowing]) + ifTrue: [h] + ifFalse: [0]. - offset := scrollBarOnLeft ifTrue: [h] ifFalse: [0]. topLeft := retractableScrollBar ifTrue: [bounds bottomLeft + (border + offset @ border negated)] ifFalse: [bounds bottomLeft + (border + offset @ (h + border) negated)]. hScrollBar bounds: (topLeft + (-1@1) extent: self hScrollBarWidth@ h) !

1 0

The Trunk: Morphic-mt.803.mcz
by commits＠source.squeak.org 01 Apr '15

01 Apr '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.803.mcz ==================== Summary ==================== Name: Morphic-mt.803 Author: mt Time: 1 April 2015, 4:41:58.498 pm UUID: 2b489690-f83f-5e41-82a7-cfba13ce7e54 Ancestors: Morphic-mt.802 Recompose the paragraph if text or runs changed after keyboard input. We did not notice this bug because Shout/Tools did this in #stylerStyled:. Only some jerky scrolling behavior occured from time to time because the first text morph update (while Shout was background-styling) was without paragraph recomposition. =============== Diff against Morphic-mt.802 =============== Item was changed: ----- Method: TextMorph>>handleInteraction:fromEvent: (in category 'editing') ----- handleInteraction: interactionBlock fromEvent: evt "Perform the changes in interactionBlock, noting any change in selection and possibly a change in the size of the paragraph (ar 9/22/2001 - added for TextPrintIts)" | oldEditor oldParagraph oldText | oldEditor := editor. oldParagraph := paragraph. oldText := oldParagraph text copy. self selectionChanged. "Note old selection" interactionBlock value. (oldParagraph == paragraph) ifTrue:[ "this will not work if the paragraph changed" editor := oldEditor. "since it may have been changed while in block" ]. self selectionChanged. "Note new selection" (oldText = paragraph text and: [ oldText runs = paragraph text runs ]) + ifFalse:[ + self paragraph composeAll. + self updateFromParagraph ]. - ifFalse:[ self updateFromParagraph ]. self setCompositionWindow.!

1 0

Jump to page: