A new version of Collections was added to project The Inbox:
http://source.squeak.org/inbox/Collections-fbs.558.mcz
==================== Summary ====================
Name: Collections-fbs.558
Author: fbs
Time: 3 January 2014, 7:56:38.153 pm
UUID: 2f723673-4596-e64c-9f28-bd90c02bab4d
Ancestors: Collections-fbs.557
No #confirmFirstUseOfStyle means we can remove this.
=============== Diff against Collections-fbs.557 ===============
Item was removed:
- ----- Method: String>>askIfAddStyle:req: (in category 'converting') -----
- askIfAddStyle: priorMethod req: requestor
- ^ self "we are a string with no text style"!
Item was removed:
- ----- Method: Text>>askIfAddStyle:req: (in category 'attributes') -----
- askIfAddStyle: priorMethod req: requestor
- "Ask the user if we have a complex style (i.e. bold) for the first time"
- | tell answ old |
- (SystemBrowser browseWithPrettyPrint)
- ifTrue: [self couldDeriveFromPrettyPrinting ifTrue: [^ self asString]].
- self runs coalesce.
- self unembellished ifTrue: [^ self asString].
- priorMethod ifNotNil: [old := priorMethod getSourceFromFile].
- (old == nil or: [old unembellished])
- ifTrue:
- [tell := 'This method contains style for the first time (e.g. bold or colored text).
- Do you really want to save the style info?'.
- answ := (UIManager default
- chooseFrom: #('Save method with style' 'Save method simply')
- title: tell).
- answ = 2 ifTrue: [^ self asString]]!
Frank Shearar uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-fbs.656.mcz
==================== Summary ====================
Name: System-fbs.656
Author: fbs
Time: 3 January 2014, 5:32:33.537 pm
UUID: cdc17088-36bd-2d48-b2b5-245d9a817e6e
Ancestors: System-fbs.655
Cleanup after #showDeprecationWarnings move.
=============== Diff against System-fbs.655 ===============
Item was removed:
- ----- Method: Preferences class>>showDeprecationWarnings (in category 'standard queries') -----
- showDeprecationWarnings
- ^ self
- valueOfFlag: #showDeprecationWarnings
- ifAbsent: [ false ]!
Frank Shearar uploaded a new version of Kernel to project The Trunk:
http://source.squeak.org/trunk/Kernel-fbs.829.mcz
==================== Summary ====================
Name: Kernel-fbs.829
Author: fbs
Time: 3 January 2014, 5:31:08.701 pm
UUID: 7385dbaa-8f76-6942-97a9-21b0f60037a4
Ancestors: Kernel-fbs.828
Move #showDeprecationWarnings preference to Deprecation.
=============== Diff against Kernel-fbs.828 ===============
Item was changed:
Warning subclass: #Deprecation
instanceVariableNames: ''
+ classVariableNames: 'ShowDeprecationWarnings'
- classVariableNames: ''
poolDictionaries: ''
category: 'Kernel-Exceptions'!
!Deprecation commentStamp: 'dew 5/21/2003 17:46' prior: 0!
This Warning is signalled by methods which are deprecated.
The use of Object>>#deprecatedExplanation: aString and Object>>#deprecated: aBlock explanation: aString is recommended.
Idiom: Imagine I want to deprecate the message #foo.
foo
^ 'foo'
I can replace it with:
foo
self deprecatedExplanation: 'The method #foo was not good. Use Bar>>newFoo instead.'
^ 'foo'
Or, for certain cases such as when #foo implements a primitive, #foo can be renamed to #fooDeprecated.
fooDeprecated
^ <primitive>
foo
^ self deprecated: [self fooDeprecated] explanation: 'The method #foo was not good. Use Bar>>newFoo instead.'
!
Item was added:
+ ----- Method: Deprecation class>>showDeprecationWarnings (in category 'preferences') -----
+ showDeprecationWarnings
+ <preference: 'Show deprecation warnings' category: 'debug' description: 'Warn the user when a deprecated method is used.' type: #Boolean>
+ ^ ShowDeprecationWarnings ifNil: [false]!
Item was added:
+ ----- Method: Deprecation class>>showDeprecationWarnings: (in category 'preferences') -----
+ showDeprecationWarnings: aBoolean
+ ShowDeprecationWarnings := aBoolean.!
Item was changed:
+ (PackageInfo named: 'Kernel') postscript: 'Deprecation showDeprecationWarnings: Preferences showDeprecationWarnings.
+ Preferences removePreference: #showDeprecationWarnings.'!
- (PackageInfo named: 'Kernel') postscript: 'DateAndTime classPool at: #OffsetsAreValid put: true.
- Timespan withAllSubclassesDo: [ : each | each initialize ].
- HashedCollection rehashAll.
- "add this comment for forcing a change detection and a rehashAll..."'!
Frank Shearar uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-fbs.557.mcz
==================== Summary ====================
Name: Collections-fbs.557
Author: fbs
Time: 3 January 2014, 5:04:30.796 pm
UUID: caf5cc51-09ce-5543-be33-9f426e6c6871
Ancestors: Collections-fbs.556
OK, so I can't help but fix this typo.
=============== Diff against Collections-fbs.556 ===============
Item was changed:
----- Method: Text class>>ignoreStyleIfOnlyBold (in category 'preferences') -----
ignoreStyleIfOnlyBold
+ <preference: 'Ignore style if only bold' category: 'browsing' description: 'If true, then any method submission in which the only style change is for bolding will be treated as a method with no style specifications.' type: #Boolean>
- <preference: 'Ignore style if only bold' category: 'browsing' description: 'If true, then any method submission in which the only style change is for bolding will be trated as a method with no style specifications.' type: #Boolean>
^ IgnoreStyleIfOnlyBold ifNil: [true].!
Frank Shearar uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.516.mcz
==================== Summary ====================
Name: Tools-fbs.516
Author: fbs
Time: 3 January 2014, 5:00:22.255 pm
UUID: 77f04881-a0af-cf46-9cd2-9327d1ef7754
Ancestors: Tools-fbs.515
Remove NumberOfRecentSubmissionsToStore. Again.
=============== Diff against Tools-fbs.515 ===============
Item was changed:
MessageSet subclass: #RecentMessageSet
instanceVariableNames: ''
+ classVariableNames: ''
- classVariableNames: 'NumberOfRecentSubmissionsToStore'
poolDictionaries: ''
category: 'Tools-Browser'!
!RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0!
RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.!
Some questions.
Moving out the inspect / explore stuff to Tools seems reasonable, but
why ContextPart>>errorReportOn: moved out of Kernel?
Because one of the responsibilities of Kernel is to do reasonable
reporting in case of an error isn't it? Is there any error-handling
left in Kernel?
Also, why putting back unused NumberOfRecentSubmissionsToStore var
into RecentMessages?
On Fri, Jan 3, 2014 at 5:36 AM, <commits(a)source.squeak.org> wrote:
> Frank Shearar uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-fbs.515.mcz
>
> ==================== Summary ====================
>
> Name: Tools-fbs.515
> Author: fbs
> Time: 3 January 2014, 11:36:39.703 am
> UUID: eb2eb7de-3e2e-bb44-95a0-0f945bb74023
> Ancestors: Tools-tpr.514
>
> Move some Tools functionality out of Kernel to Tools.
>
> =============== Diff against Tools-tpr.514 ===============
>
> Item was added:
> + ----- Method: Behavior>>inspectAllInstances (in category '*Tools-accessing instances and variables') -----
> + inspectAllInstances
> + "Inpsect all instances of the receiver. 1/26/96 sw"
> +
> + | all allSize prefix |
> + all := self allInstances.
> + (allSize := all size) = 0 ifTrue: [^ self inform: 'There are no
> + instances of ', self name].
> + prefix := allSize = 1
> + ifTrue: ['The lone instance']
> + ifFalse: ['The ', allSize printString, ' instances'].
> +
> + all asArray inspectWithLabel: (prefix, ' of ', self name)!
>
> Item was added:
> + ----- Method: Behavior>>inspectSubInstances (in category '*Tools-accessing instances and variables') -----
> + inspectSubInstances
> + "Inspect all instances of the receiver and all its subclasses. CAUTION - don't do this for something as generic as Object!! 1/26/96 sw"
> +
> + | all allSize prefix |
> + all := self allSubInstances.
> + (allSize := all size) = 0 ifTrue: [^ self inform: 'There are no
> + instances of ', self name, '
> + or any of its subclasses'].
> + prefix := allSize = 1
> + ifTrue: ['The lone instance']
> + ifFalse: ['The ', allSize printString, ' instances'].
> +
> + all asArray inspectWithLabel: (prefix, ' of ', self name, ' & its subclasses')!
>
> Item was added:
> + ----- Method: ContextPart>>errorReportOn: (in category '*Tools-debugger access') -----
> + errorReportOn: strm
> + "Write a detailed error report on the stack (above me) on a stream. For both the error file, and emailing a bug report. Suppress any errors while getting printStrings. Limit the length."
> +
> + | cnt aContext startPos |
> + strm print: Date today; space; print: Time now; cr.
> + strm cr.
> + strm nextPutAll: 'VM: ';
> + nextPutAll: Smalltalk platformName asString;
> + nextPutAll: ' - ';
> + nextPutAll: Smalltalk asString;
> + cr.
> + strm nextPutAll: 'Image: ';
> + nextPutAll: SystemVersion current version asString;
> + nextPutAll: ' [';
> + nextPutAll: Smalltalk lastUpdateString asString;
> + nextPutAll: ']';
> + cr.
> + strm cr.
> + SecurityManager default printStateOn: strm.
> +
> + "Note: The following is an open-coded version of ContextPart>>stackOfSize: since this method may be called during a low space condition and we might run out of space for allocating the full stack."
> + cnt := 0. startPos := strm position.
> + aContext := self.
> + [aContext notNil and: [(cnt := cnt + 1) < 20]] whileTrue:
> + [aContext printDetails: strm. "variable values"
> + strm cr.
> + aContext := aContext sender].
> +
> + strm cr; nextPutAll: '--- The full stack ---'; cr.
> + aContext := self.
> + cnt := 0.
> + [aContext == nil] whileFalse:
> + [cnt := cnt + 1.
> + cnt = 20 ifTrue: [strm nextPutAll: ' - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -'; cr].
> + strm print: aContext; cr. "just class>>selector"
> +
> + "exit early if too long..."
> + strm position > (startPos+ self class maxLengthForASingleDebugLogReport) ifTrue: [strm nextPutAll: '...etc...'. ^ self]. cnt > self class maxStackDepthForASingleDebugLogReport ifTrue: [strm nextPutAll: '-- and more not shown --'. ^ self].
> + aContext := aContext sender].
> + !
>
> Item was added:
> + ----- Method: Object>>explore (in category '*Tools-Explorer') -----
> + explore
> + ^ToolSet explore: self!
>
> Item was added:
> + ----- Method: Object>>inspectWithLabel: (in category '*Tools-inspecting') -----
> + inspectWithLabel: aLabel
> + "Create and schedule an Inspector in which the user can examine the receiver's variables."
> + ^ToolSet inspect: self label: aLabel!
>
> Item was added:
> + ----- Method: Object>>notifyWithLabel: (in category '*Tools-error handling') -----
> + notifyWithLabel: aString
> + "Create and schedule a Notifier with aString as the window label as well as the contents of the window, in order to request confirmation before a process can proceed."
> +
> + ToolSet
> + debugContext: thisContext
> + label: aString
> + contents: aString
> +
> + "nil notifyWithLabel: 'let us see if this works'"!
>
> Item was changed:
> MessageSet subclass: #RecentMessageSet
> instanceVariableNames: ''
> + classVariableNames: 'NumberOfRecentSubmissionsToStore'
> - classVariableNames: ''
> poolDictionaries: ''
> category: 'Tools-Browser'!
>
> !RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0!
> RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.!
>
>
On 3 January 2014 16:29, <commits(a)source.squeak.org> wrote:
> Frank Shearar uploaded a new version of Collections to project The Trunk:
> http://source.squeak.org/trunk/Collections-fbs.556.mcz
>
> ==================== Summary ====================
>
> Name: Collections-fbs.556
> Author: fbs
> Time: 3 January 2014, 4:28:00.204 pm
> UUID: 80422ba6-f9b2-fc4f-acb2-27a911950eb9
> Ancestors: Collections-fbs.555
>
> While we debate whether we should even have an #ignoreStyleIfOnlyBold preference, make it a pragma preference.
>
> =============== Diff against Collections-fbs.555 ===============
> Item was added:
> + ----- Method: Text class>>ignoreStyleIfOnlyBold (in category 'preferences') -----
> + ignoreStyleIfOnlyBold
> + <preference: 'Ignore style if only bold' category: 'browsing' description: 'If true, then any method submission in which the only style change is for bolding will be trated as a method with no style specifications.' type: #Boolean>
> + ^ IgnoreStyleIfOnlyBold ifNil: [true].!
Gah! What does "trated" mean?! So if we decide to remove
#askIfAddStyle:req: really soon, I'll fold fixing this into that
removal.
frank
Frank Shearar uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-fbs.655.mcz
==================== Summary ====================
Name: System-fbs.655
Author: fbs
Time: 3 January 2014, 4:24:13.222 pm
UUID: 919c6d51-5500-0f4b-9895-f47eed03b2c2
Ancestors: System-tpr.654
Cleanup after making #ignoreStyleIfOnlyBold a pragma preference.
=============== Diff against System-tpr.654 ===============
Item was removed:
- ----- Method: Preferences class>>ignoreStyleIfOnlyBold (in category 'standard queries') -----
- ignoreStyleIfOnlyBold
- ^ self
- valueOfFlag: #ignoreStyleIfOnlyBold
- ifAbsent: [ true ]!