Squeak-dev October 2013

squeak-dev@lists.squeakfoundation.org

35 participants
262 discussions

The Trunk: MultilingualTests-nice.17.mcz
by commits＠source.squeak.org 31 Oct '13

31 Oct '13

Nicolas Cellier uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-nice.17.mcz ==================== Summary ==================== Name: MultilingualTests-nice.17 Author: nice Time: 31 October 2013, 11:54:33.464 pm UUID: 6de55950-5fff-43d1-9ce0-8b661515f618 Ancestors: MultilingualTests-tpr.16 Add a test showing that MultiByteFileStream>>nextChunk fails to honour its own lineEndConvention. =============== Diff against MultilingualTests-tpr.16 =============== Item was added: + ----- Method: MultiByteFileStreamTest>>testLineEndingChunk (in category 'testing') ----- + testLineEndingChunk + + fileName := 'foolinend.txt'. + MultiByteFileStream forceNewFileNamed: fileName do: [ :file | + file + wantsLineEndConversion: false; + nextPutAll: 'line 1'; cr; + nextPutAll: 'line 2'; crlf; + nextPutAll: 'line 3'; lf; + nextPutAll: 'line 4'; nextPut: $!! ]. + { + {#cr. 'line 1' , String cr , 'line 2' , String cr , 'line 3' , String cr , 'line 4'}. + {#lf. 'line 1' , String cr , 'line 2' , String cr , 'line 3' , String cr , 'line 4'}. + {#crlf. 'line 1' , String cr , 'line 2' , String cr , 'line 3' , String cr , 'line 4'}. + {nil. 'line 1' , String cr , 'line 2' , String crlf , 'line 3' , String lf , 'line 4'} + } do: [:lineEndingResult | + MultiByteFileStream oldFileNamed: fileName do: [ :file | + file lineEndConvention: lineEndingResult first. + self assert: lineEndingResult last equals: file nextChunk ] ]!

1 0

The Trunk: CommandLine-fbs.1.mcz
by commits＠source.squeak.org 31 Oct '13

31 Oct '13

Frank Shearar uploaded a new version of CommandLine to project The Trunk: http://source.squeak.org/trunk/CommandLine-fbs.1.mcz ==================== Summary ==================== Name: CommandLine-fbs.1 Author: fbs Time: 31 October 2013, 10:32:52.821 pm UUID: dc871e85-bd16-d742-acbf-4d2b838113d1 Ancestors: CommandLineToolSet does little more than dump errors to stderr. DummyUIManager comes from Pharo via Pavel Krivanek's minimising script. ==================== Snapshot ==================== SystemOrganization addCategory: #'CommandLine-Tools'! SystemOrganization addCategory: #'CommandLine-UIManager'! UIManager subclass: #DummyUIManager instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'CommandLine-UIManager'! !DummyUIManager commentStamp: 'fbs 10/31/2013 07:36' prior: 0! I'm an alternative UIManager used to run an the image without GUI. I redefine methods which require user input as these requests are irrelevant in a headless environment. ! ----- Method: DummyUIManager>>checkForNewDisplaySize (in category 'display') ----- checkForNewDisplaySize Display extent = DisplayScreen actualScreenSize ifTrue: [^ self]. DisplayScreen startUp. ! ----- Method: DummyUIManager>>chooseDirectory:from: (in category 'ui requests') ----- chooseDirectory: label from: dir ^ nil! ----- Method: DummyUIManager>>chooseFrom:lines:title: (in category 'ui requests') ----- chooseFrom: aList lines: linesArray title: aString ^ aList first! ----- Method: DummyUIManager>>chooseFrom:values:lines:title: (in category 'ui requests') ----- chooseFrom: labelList values: valueList lines: linesArray title: aString ^ valueList first! ----- Method: DummyUIManager>>confirm: (in category 'ui requests') ----- confirm: queryString (ProvideAnswerNotification signal: queryString) ifNotNil: [:answer|^answer]. self error: 'No user response possible'! ----- Method: DummyUIManager>>confirm:orCancel: (in category 'ui requests') ----- confirm: aString orCancel: cancelBlock (ProvideAnswerNotification signal: aString) ifNotNil: [:answer | ^answer == #cancel ifTrue: [cancelBlock value] ifFalse: [answer]]. self error: 'No user response possible'! ----- Method: DummyUIManager>>displayProgress:at:from:to:during: (in category 'ui requests') ----- displayProgress: titleString at: aPoint from: minVal to: maxVal during: workBlock ^ workBlock value: Association new! ----- Method: DummyUIManager>>edit:label:accept: (in category 'ui requests') ----- edit: aText label: labelString accept: anAction ^ nil! ----- Method: DummyUIManager>>fontFromUser: (in category 'ui requests') ----- fontFromUser: priorFont self error: 'No user response possible'! ----- Method: DummyUIManager>>inform: (in category 'ui requests') ----- inform: aString "Nothing to be done here"! ----- Method: DummyUIManager>>informUserDuring: (in category 'ui requests') ----- informUserDuring: aBlock aBlock value: nil! ----- Method: DummyUIManager>>newDisplayDepthNoRestore: (in category 'display') ----- newDisplayDepthNoRestore: pixelSize "Change depths. Check if there is enough space!! , di" | area need | pixelSize = Display depth ifTrue: [^ self "no change"]. pixelSize abs < Display depth ifFalse: ["Make sure there is enough space" area := Display boundingBox area. "pixels" need := (area * (pixelSize abs - Display depth) // 8) "new bytes needed" + Smalltalk lowSpaceThreshold. (Smalltalk garbageCollectMost <= need and: [Smalltalk garbageCollect <= need]) ifTrue: [self error: 'Insufficient free space']]. Display setExtent: Display extent depth: pixelSize. DisplayScreen startUp! ----- Method: DummyUIManager>>request:initialAnswer: (in category 'ui requests') ----- request: queryString initialAnswer: defaultAnswer (ProvideAnswerNotification signal: queryString) ifNotNil: [:answer | ^ answer == #default ifTrue: [defaultAnswer] ifFalse: [answer]]. self error: 'No user response possible'! ----- Method: DummyUIManager>>requestPassword: (in category 'ui requests') ----- requestPassword: queryString ^ self request: queryString initialAnswer: ''! ----- Method: DummyUIManager>>restoreDisplay (in category 'display') ----- restoreDisplay! ----- Method: DummyUIManager>>restoreDisplayAfter: (in category 'display') ----- restoreDisplayAfter: aBlock aBlock value. Sensor waitButton.! StandardToolSet subclass: #CommandLineToolSet instanceVariableNames: '' classVariableNames: 'SaveSnapshotOnError' poolDictionaries: '' category: 'CommandLine-Tools'! ----- Method: CommandLineToolSet class>>debugError: (in category 'debugging') ----- debugError: anError "Print out a sensible stack trace and bail" | problemPlace s | self saveSnapshotOnError ifTrue: [Smalltalk saveAs: 'Debug-' , (Smalltalk imageName subStrings: '/') last]. problemPlace := anError signalerContext. s := FileStream stderr. (anError isKindOf: MessageNotUnderstood) ifTrue: [ s nextPutAll: anError messageText; cr; nextPutAll: problemPlace sender methodNode printString; cr]. (problemPlace stackOfSize: 20) do: [:ctx | s cr. ctx printOn: s]. s flush. SmalltalkImage current snapshot: false andQuit: true! ----- Method: CommandLineToolSet class>>debugSyntaxError: (in category 'debugging') ----- debugSyntaxError: anError | s | s := FileStream stderr. s nextPutAll: '----- Syntax error -----'; cr. s nextPutAll: anError errorCode; cr. s nextPutAll: '----- Syntax error -----'; cr. self debugError: anError! ----- Method: CommandLineToolSet class>>saveSnapshotOnError (in category 'preferences') ----- saveSnapshotOnError <preference: 'Save snapshot of image on failure' category: 'debug' description: 'If true, saves a snapshot of the failing image to the current directory.' type: #Boolean> ^ SaveSnapshotOnError ifNil: [SaveSnapshotOnError := false].! ----- Method: CommandLineToolSet class>>saveSnapshotOnError: (in category 'preferences') ----- saveSnapshotOnError: aBoolean SaveSnapshotOnError := aBoolean.! ----- Method: CommandLineToolSet class>>unload (in category 'class initialization') ----- unload ToolSet unregister: self.!

1 0

The Trunk: Morphic-fbs.697.mcz
by commits＠source.squeak.org 31 Oct '13

31 Oct '13

Frank Shearar uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-fbs.697.mcz ==================== Summary ==================== Name: Morphic-fbs.697 Author: fbs Time: 31 October 2013, 10:22:06.367 pm UUID: 45275a98-c848-ce41-95b6-94a3b626a4c8 Ancestors: Morphic-cmm.696 Step 1 of moving control over display depth to the UIManagers. =============== Diff against Morphic-cmm.696 =============== Item was added: + ----- Method: MorphicUIManager>>newDisplayDepthNoRestore: (in category 'display') ----- + newDisplayDepthNoRestore: pixelSize + "Change depths. Check if there is enough space!! , di" + | area need | + pixelSize = Display depth ifTrue: [^ self "no change"]. + pixelSize abs < Display depth ifFalse: + ["Make sure there is enough space" + area := Display boundingBox area. "pixels" + + need := (area * (pixelSize abs - Display depth) // 8) "new bytes needed" + + Smalltalk lowSpaceThreshold. + (Smalltalk garbageCollectMost <= need + and: [Smalltalk garbageCollect <= need]) + ifTrue: [self error: 'Insufficient free space']]. + Display setExtent: Display extent depth: pixelSize. + + DisplayScreen startUp! Item was added: + ----- Method: MorphicUIManager>>restoreDisplay (in category 'display') ----- + restoreDisplay + "Restore the bits on Display" + Project current ifNotNil:[:p| p invalidate; restore].! Item was added: + ----- Method: MorphicUIManager>>restoreDisplayAfter: (in category 'display') ----- + restoreDisplayAfter: aBlock + "Evaluate the block, wait for a mouse click, and then restore the screen." + + aBlock value. + Sensor waitButton. + self restore.!

1 0

The Trunk: ST80-fbs.164.mcz
by commits＠source.squeak.org 31 Oct '13

31 Oct '13

Frank Shearar uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-fbs.164.mcz ==================== Summary ==================== Name: ST80-fbs.164 Author: fbs Time: 31 October 2013, 10:20:44.812 pm UUID: fc042d8e-f1d5-8a4e-b76d-0b9b448c8566 Ancestors: ST80-nice.163 Step 1 of moving control over display depth to the UIManagers. =============== Diff against ST80-nice.163 =============== Item was added: + ----- Method: MVCUIManager>>newDisplayDepthNoRestore: (in category 'display') ----- + newDisplayDepthNoRestore: pixelSize + "Change depths. Check if there is enough space!! , di" + | area need | + pixelSize = Display depth ifTrue: [^ self "no change"]. + pixelSize abs < Display depth ifFalse: + ["Make sure there is enough space" + area := Display boundingBox area. "pixels" + ScheduledControllers scheduledWindowControllers do: + [:aController | "This should be refined..." + aController view cacheBitsAsTwoTone ifFalse: + [area := area + aController view windowBox area]]. + need := (area * (pixelSize abs - Display depth) // 8) "new bytes needed" + + Smalltalk lowSpaceThreshold. + (Smalltalk garbageCollectMost <= need + and: [Smalltalk garbageCollect <= need]) + ifTrue: [self error: 'Insufficient free space']]. + Display setExtent: Display extent depth: pixelSize. + ScheduledControllers updateGray. + DisplayScreen startUp! Item was added: + ----- Method: MVCUIManager>>restoreDisplay (in category 'display') ----- + restoreDisplay + "Restore the bits on Display" + Project current ifNotNil:[:p| p invalidate; restore].! Item was added: + ----- Method: MVCUIManager>>restoreDisplayAfter: (in category 'display') ----- + restoreDisplayAfter: aBlock + "Evaluate the block, wait for a mouse click, and then restore the screen." + + aBlock value. + Sensor waitButton. + self restore.!

1 0

The Trunk: ToolBuilder-Kernel-fbs.58.mcz
by commits＠source.squeak.org 31 Oct '13

31 Oct '13

Frank Shearar uploaded a new version of ToolBuilder-Kernel to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-fbs.58 Author: fbs Time: 31 October 2013, 10:18:57.495 pm UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb Ancestors: ToolBuilder-Kernel-dtl.57 Step 1 of moving control over display depth to the UIManagers. =============== Diff against ToolBuilder-Kernel-dtl.57 =============== Item was added: + ----- Method: UIManager>>newDisplayDepthNoRestore: (in category 'display') ----- + newDisplayDepthNoRestore: pixelSize + self subclassResponsibility.! Item was added: + ----- Method: UIManager>>restoreDisplay (in category 'display') ----- + restoreDisplay + self subclassResponsibility.! Item was added: + ----- Method: UIManager>>restoreDisplayAfter: (in category 'display') ----- + restoreDisplayAfter: aBlock + self subclassResponsibility.!

1 0

Re: [squeak-dev] The Trunk: System-cmm.610.mcz
by Frank Shearar 31 Oct '13

31 Oct '13

On 26 October 2013 20:17, <commits(a)source.squeak.org> wrote: > Chris Muller uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-cmm.610.mcz > > ==================== Summary ==================== > > Name: System-cmm.610 > Author: cmm > Time: 26 October 2013, 2:17:09.114 pm > UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 > Ancestors: System-dtl.609 > > Consider valueWithAllPossibleArguments: special enough to inline, for now. > > =============== Diff against System-dtl.609 =============== Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract. frank

4 6

Tests blocked on CI
by Frank Shearar 31 Oct '13

31 Oct '13

http://build.squeak.org/job/SqueakTrunk/574/console shows a typical failure in CI at the moment. The relevant output is: 2013-10-30T22:17:00.132+01:00: Running tests for Tests... !!! Killed command 0 for exceeding allotted time: nice /home/jenkins/workspace/SqueakTrunk/target/cog.r2776/coglinux/bin/squeak -vm-sound-null -vm-display-null "/home/jenkins/workspace/SqueakTrunk/target/PostTestTrunkImage.image" ../tests.st. /home/jenkins/workspace/SqueakTrunk/benchmarks.st spawning command 1 with timeout 600 seconds: nice /home/jenkins/workspace/SqueakTrunk/target/cog.r2776/coglinux/bin/squeak -vm-sound-null -vm-display-null "/home/jenkins/workspace/SqueakTrunk/target/PostTestTrunkImage.image" ../benchmarks.st 2013-10-30T23:01:41.404+01:00: Running tests for ToolBuilder-Kernel... Note that the "!!!" line happens because the running of the full test suite took OVER 40 MINUTES. My crummy little laptop chewed through the test suite in 10 minutes. So: on Windows 8 I cannot reproduce the problem. Would someone with a Linux machine please try run the full suite of tests? I strongly suspect we have a dialog popping up, but only on Linux. (I'm busy working through Pavel's DummyUIManager. I suspect that I'll be copying most of it into my CommandLineUIManager, for submission to trunk. Hopefully I'll get to it in the very near future.) frank

2 5

more archaeology
by Bob Arning 31 Oct '13

31 Oct '13

http://69.251.218.6:9116/time now allows clicking on a cell to see all the changes therein. Cheers, Bob

6 7

Changing display depth
by Frank Shearar 31 Oct '13

31 Oct '13

So once again I find myself catching up with Pavel's work. He said a while back that: DisplayScreen>>newDepthNoRestore: - delegation to UIManager, MorphicUIManager implementation should be added What I think that means is this: * moving DisplayScreen >> #newDepth: to UIManager >> #newDepth: * changing "Display newDepth: foo" to "UIManager default newDepth: foo" * adding UIManager >> newDepthNoRestore: as a self subclassResponsibility * changing any "Display newDepthNoRestore: foo" occurrences * moving DisplayScreen >> #newDepthNoRestore to MorphicUIManager >> #newDepthNoRestore: * copying most of MorphicUIManager >> #newDepthNoRestore: to MVCUIManager or whatever it's called ("most" means "everything outside a Smalltalk isMorphic ifTrue: []") This * delegates setting screen depth to the UIManager, and * avoids making Graphics depend on ToolBuilder-Kernel (because TBK already depends on Graphics (because of a probably removable test case thing)) The assumption here is that Graphics is lower level/more fundamental than TBK. Thoughts? frank

4 3

Daily Commit Log
by commits＠source.squeak.org 31 Oct '13

31 Oct '13

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2013-October/006574.ht… Name: TrueType-nice.28 Ancestors: TrueType-nice.27 Remove MultiTTCFont>>isTTCFont because same as super ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006575.ht… Name: Sound-fbs.37 Ancestors: Sound-fbs.36 Make SoundPlayer responsible for platform-specific sound things. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2013-October/006576.ht… Name: System-fbs.611 Ancestors: System-cmm.610 Make SoundPlayer responsible for platform-specific sound things. =============================================

1 0

Jump to page: