Squeak-dev August 2012

squeak-dev@lists.squeakfoundation.org

43 participants
179 discussions

The Trunk: CollectionsTests-ul.188.mcz
by commits＠source.squeak.org 19 Aug '12

19 Aug '12

Levente Uzonyi uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-ul.188.mcz ==================== Summary ==================== Name: CollectionsTests-ul.188 Author: ul Time: 19 August 2012, 3:19:50.449 pm UUID: 85f1372a-70ab-ef44-8b53-31c67f7cae63 Ancestors: CollectionsTests-ael.187 - simplified StringTest >> #testUnescapePercents and added a few more cases which failed with the previous implementation =============== Diff against CollectionsTests-ael.187 =============== Item was changed: ----- Method: StringTest>>testUnescapePercents (in category 'tests - converting') ----- testUnescapePercents - self assert: '' unescapePercents = ''. - self assert: 'x' unescapePercents = 'x'. + #( + '' '' + 'x' 'x' + '+' ' ' + 'x+' 'x ' + '+x' ' x' + 'x+x' 'x x' + '%' '%' + '%3' '%3' + '%3C' '<' + '%3C%' '%3C%' + '%3C%3' '%3C%3' + '%3C%3C' '<<' + '%3Cx%3E4%3C%2Fx%3E' '<x>4</x>' + '!!@#$%25%5E&*()%7B%7D%5B%5D=:/;?+''%22' '!!@#$%^&*(){}[]=:/;? ''"' + '!!%40%23%24%25%5E%26*()%7B%7D%5B%5D%3D%3A%2F%3B%3F%2B''%22' '!!@#$%^&*(){}[]=:/;?+''"' + '%21@%23%24%25%5E%26*%28%29%7B%7D%5B%5D%3D%3A/%3B%3F+%27%22' '!!@#$%^&*(){}[]=:/;? ''"' + ) pairsDo: [ :from :to | + self assert: to equals: from unescapePercents ]! - self assert: '+' unescapePercents = ' '. - self assert: 'x+' unescapePercents = 'x '. - self assert: '+x' unescapePercents = ' x'. - self assert: 'x+x' unescapePercents = 'x x'. - - self assert: '%' unescapePercents = '%'. - self assert: '%3' unescapePercents = '%3'. - self assert: '%3C' unescapePercents = '<'. - - self assert: '%3Cx%3E4%3C%2Fx%3E' unescapePercents = '<x>4</x>'. - - self assert: '!!@#$%25%5E&*()%7B%7D%5B%5D=:/;?+''%22' unescapePercents = '!!@#$%^&*(){}[]=:/;? ''"'. - self assert: '!!%40%23%24%25%5E%26*()%7B%7D%5B%5D%3D%3A%2F%3B%3F%2B''%22' unescapePercents = '!!@#$%^&*(){}[]=:/;?+''"'. - self assert: '%21@%23%24%25%5E%26*%28%29%7B%7D%5B%5D%3D%3A/%3B%3F+%27%22' unescapePercents = '!!@#$%^&*(){}[]=:/;? ''"'!

1 0

The Trunk: Collections-ul.488.mcz
by commits＠source.squeak.org 19 Aug '12

19 Aug '12

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.488.mcz ==================== Summary ==================== Name: Collections-ul.488 Author: ul Time: 19 August 2012, 11:26:54.909 am UUID: a2927620-f372-1f4e-8e29-b6a5ff77fa9f Ancestors: Collections-cwp.487 Updated String >> #unescapePercentsRaw - it always returns the receiver if it is not percent-encoded - the implementation is simpler and slightly faster =============== Diff against Collections-cwp.487 =============== Item was changed: ----- Method: String>>unescapePercentsRaw (in category 'converting') ----- unescapePercentsRaw + "Decode myself if I'm percent-encoded, also replace + with space. Return self if the encoding is not valid." - "decode string including %XX form" + ^String new: self size streamContents: [ :stream | + | value1 value2 specialChars startIndex endIndex | + specialChars := '+%' asCharacterSet. + startIndex := 1. + [ (endIndex := self indexOfAnyOf: specialChars startingAt: startIndex) > 0 ] whileTrue: [ + stream next: endIndex - startIndex putAll: self startingAt: startIndex. + (self at: endIndex) == $% + ifTrue: [ + endIndex + 2 <= self size ifFalse: [ ^self ]. + value1 := (self at: endIndex + 1) asUppercase digitValue. + (value1 < 0 or: [ value1 > 15 ]) ifTrue: [ ^self ]. + value2 := (self at: endIndex + 2) asUppercase digitValue. + (value2 < 0 or: [ value2 > 15 ]) ifTrue: [ ^self ]. + stream nextPut: (Character value: value1 * 16 + value2). + startIndex := endIndex + 3 ] + ifFalse: [ "$+" + stream nextPut: Character space. + startIndex := endIndex + 1 ] ]. + startIndex <= self size ifTrue: [ + stream next: self size + 1 - startIndex putAll: self startingAt: startIndex ] ]! - | unescaped char asciiVal specialChars oldPos pos | - unescaped := ReadWriteStream on: String new. - specialChars := '+%' asCharacterSet. - oldPos := 1. - [pos := self indexOfAnyOf: specialChars startingAt: oldPos. - pos > 0] - whileTrue: [unescaped - nextPutAll: (self copyFrom: oldPos to: pos - 1). - char := self at: pos. - (char = $% - and: [pos + 2 <= self size]) - ifTrue: [asciiVal := (self at: pos + 1) asUppercase digitValue * 16 + (self at: pos + 2) asUppercase digitValue. - asciiVal > 255 - ifTrue: [^ self]. - unescaped - nextPut: (Character value: asciiVal). - pos := pos + 3. - pos <= self size - ifFalse: [char := nil]. - oldPos := pos] - ifFalse: [char = $+ - ifTrue: [unescaped nextPut: Character space] - ifFalse: [unescaped nextPut: char]. - oldPos := pos + 1]]. - oldPos <= self size - ifTrue: [unescaped - nextPutAll: (self copyFrom: oldPos to: self size)]. - ^unescaped contents!

1 0

The Trunk: System-ul.493.mcz
by commits＠source.squeak.org 19 Aug '12

19 Aug '12

Levente Uzonyi uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ul.493.mcz ==================== Summary ==================== Name: System-ul.493 Author: ul Time: 16 August 2012, 4:07:05.302 pm UUID: 9b43acfa-a8e6-6442-a8cb-34aa8ca2370a Ancestors: System-cmm.492 - enh: Clipboard instances send notifications (triggerEvent) to their subscribers when their content changes. =============== Diff against System-cmm.492 =============== Item was changed: Object subclass: #Clipboard instanceVariableNames: 'contents recent interpreter' classVariableNames: 'Default' poolDictionaries: '' category: 'System-Support'! + !Clipboard commentStamp: 'ul 8/16/2012 15:26' prior: 0! + The Clipboard class implements a basic buffering scheme for text. The currently selected text is also exported to the OS so that text can be copied from and to other applications. Commonly only a single instance is used (the default clipboard) but applications are free to use other than the default clipboard if necessary. + + If you'd like to be notified of the changes of the clipboard, you can subscribe to it's #contentChanged event. For example: + + | subscriber | + subscriber := [ :newClipboardText :updateSource | + Transcript show: ('Clipboard was updated by {1}, the new content is: {2}' + format: { + updateSource. + newClipboardText }); cr ]. + Clipboard default + when: #contentChanged + send: #value:value: + to: subscriber. + + To unsubscribe from the clipboard changes, just evaluate: + + Clipboard default removeActionsWithReceiver: subscriber! - !Clipboard commentStamp: '<historical>' prior: 0! - The Clipboard class implements a basic buffering scheme for text. The currently selected text is also exported to the OS so that text can be copied from and to other applications. Commonly only a single instance is used (the default clipboard) but applications are free to use other than the default clipboard if necessary.! Item was changed: ----- Method: Clipboard>>clipboardText: (in category 'accessing') ----- clipboardText: text + self clipboardText: text notifyWith: nil! - | string | - string := text asString. - self noteRecentClipping: text asText. - contents := text asText. - string := self interpreter toSystemClipboard: string. - self primitiveClipboardText: string. - ! Item was added: + ----- Method: Clipboard>>clipboardText:notifyWith: (in category 'accessing') ----- + clipboardText: text notifyWith: anObject + "Set the contents of the clipboard to text. anObject can be used as a marker for the source of the clipboard change, the default value is nil." + + | string | + string := text asString. + self noteRecentClipping: text asText. + contents := text asText. + string := self interpreter toSystemClipboard: string. + self primitiveClipboardText: string. + self triggerEvent: #contentChanged withArguments: { text. anObject }!

1 0

Strange Behavior Variance between Form and Cursor
by JohnReed Maffeo 19 Aug '12

19 Aug '12

Cursor is a subclass of Form but their extent:fromArray:offset methods produce significantly different results. In a workspace, I inspect two instances Cursor extent: 16@16 fromArray: #(65535 2047 30975 32575 32735 32751 32759 32759 32763 32763 32763 32765 32765 32765 32765 1) offset: 0@0 Form extent: 16@16 fromArray: #(65535 2047 30975 32575 32735 32751 32759 32759 32763 32763 32763 32765 32765 32765 32765 1) offset: 0@0 In the inspector browser in each, I do "self displayOn: Display" The cursor instance displays an Arc icon in the upper left hand corner of the Display. The cursor instance displays a white box icon in the upper left hand corner of the Display. The difference appears to be the fact the the Cursor method applies a bitShift: 16 to the elements of the input array. I have observed these results in the Squeak4.2-10966 and the minimal-MVC (nee Squeak3.8.18beta3u ?). It seems to violate the principle of least astonishment. Is it a bug, a feature or an interesting artifact? This was discovered while I was doing some work trying to port and old Smalltalk-80 graphics application as part of my self study process. I can get the results I am looking for by doing this: Form extent: 16@16 fromArray: (#(65535 2047 30975 32575 32735 32751 32759 32759 32763 32763 32763 32765 32765 32765 32765 1) collect: [ :each | each bitShift: 16]) offset: 0@0 Regards, John-Reed

2 1

Windows CogVM stdOut?
by Douglas McPherson 18 Aug '12

18 Aug '12

I'm using FFI to call an external C function which performs a printf. On the Mac such output conveniently displays in Console.app. Anyone know how I can see these printfs on Windows ? I tried starting the image with Cog's CroquetConsole.exe but nothing gets displayed in the console. Ideas? Thanks, Doug

2 2

Daily Commit Log
by commits＠source.squeak.org 18 Aug '12

18 Aug '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-August/005475.html Name: Tests-eem.158 Ancestors: Tests-cwp.157 Add a test that tests outer in the contex of an enclosing handler, unlike testResumableOuter which tests outer in the absence of an enclosing handler. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-August/005476.html Name: Tests-cwp.159 Ancestors: Tests-cwp.158 Infix selectors can't include underscores, so remove those tests, and add one that ensures that a single underscore is considered a unary message. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-August/005477.html Name: Tests-cwp.160 Ancestors: Tests-cwp.159, Tests-eem.158 merge Tests-eem.158: Add a test that tests outer in the contex of an enclosing handler, unlike testResumableOuter which tests outer in the absence of an enclosing handler. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-August/005478.html Name: Multilingual-ul.156 Ancestors: Multilingual-edc.155 - fix an indexing bug in TextConverter >> #next:putAll:startingAt:toStream: =============================================

1 0

The Trunk: Multilingual-ul.156.mcz
by commits＠source.squeak.org 18 Aug '12

18 Aug '12

Levente Uzonyi uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-ul.156.mcz ==================== Summary ==================== Name: Multilingual-ul.156 Author: ul Time: 17 August 2012, 11:46:39.54 pm UUID: f231c73f-47cf-a740-9ba6-c5580464cc7a Ancestors: Multilingual-edc.155 - fix an indexing bug in TextConverter >> #next:putAll:startingAt:toStream: =============== Diff against Multilingual-edc.155 =============== Item was changed: ----- Method: TextConverter>>next:putAll:startingAt:toStream: (in category 'conversion') ----- next: anInteger putAll: aString startingAt: startIndex toStream: aStream "Handle fast conversion if ByteString" | lastIndex nextIndex | aString class == ByteString ifFalse: [ startIndex to: startIndex + anInteger - 1 do: [ :index | self nextPut: (aString at: index) toStream: aStream ]. ^aString ]. aStream isBinary ifTrue: [ aStream basicNext: anInteger putAll: aString startingAt: startIndex. ^aString ]. lastIndex := startIndex. [ (nextIndex := ByteString findFirstInString: aString inSet: latin1Map + startingAt: lastIndex) = 0 or: [ anInteger + startIndex <= nextIndex ] ] whileFalse: [ - startingAt: lastIndex) = 0 or: [ nextIndex > anInteger ] ] whileFalse: [ aStream basicNext: nextIndex - lastIndex putAll: aString startingAt: lastIndex; basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex) + 1). lastIndex := nextIndex + 1 ]. aStream basicNext: anInteger - lastIndex + startIndex putAll: aString startingAt: lastIndex. ^aString!

1 0

Re: [squeak-dev] The Inbox: Tests-cwp.158.mcz
by Frank Shearar 17 Aug '12

17 Aug '12

On 14 August 2012 07:27, <commits(a)source.squeak.org> wrote: > A new version of Tests was added to project The Inbox: > http://source.squeak.org/inbox/Tests-cwp.158.mcz > > ==================== Summary ==================== > > Name: Tests-cwp.158 > Author: cwp > Time: 13 August 2012, 11:27:52.385 pm > UUID: 815626bc-7a56-4869-961d-f81880b4a668 > Ancestors: Tests-cwp.157 > > Renamed the existing tokenish tests, and added tests for selector precedence in the presence of underscores. > > =============== Diff against Tests-cwp.157 =============== > Item was removed: > - ----- Method: UnderscoreSelectorsTest>>testPrefFalse (in category 'as yet unclassified') ----- > - testPrefFalse > - self pref: false during: [self deny: $_ tokenish].! > > Item was removed: > - ----- Method: UnderscoreSelectorsTest>>testPrefTrue (in category 'as yet unclassified') ----- > - testPrefTrue > - self pref: true during: [self assert: $_ tokenish].! > > Item was added: > + ----- Method: UnderscoreSelectorsTest>>testTokenishFalse (in category 'tests') ----- > + testTokenishFalse > + self pref: false during: [self deny: $_ tokenish].! > > Item was added: > + ----- Method: UnderscoreSelectorsTest>>testTokenishTrue (in category 'tests') ----- > + testTokenishTrue > + self pref: true during: [self assert: $_ tokenish].! Why both testPrefFalse and testTokenishFalse (and both testPrefTrue and testTokenishTrue) if they both do the same thing? (testPref(True|False) are in the image now, so unless there's good reason, I don't see why we can't just remove testTokenish(True|False) from the above. Nit: I'd like testPref(True|False) categorised. Otherwise, +1 from me. frank

4 12

The Trunk: Tests-cwp.160.mcz
by commits＠source.squeak.org 17 Aug '12

17 Aug '12

Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.160.mcz ==================== Summary ==================== Name: Tests-cwp.160 Author: cwp Time: 17 August 2012, 2:02:48.348 pm UUID: 7f94a1f9-3176-43aa-aef1-05ce3b437125 Ancestors: Tests-cwp.159, Tests-eem.158 merge Tests-eem.158: Add a test that tests outer in the contex of an enclosing handler, unlike testResumableOuter which tests outer in the absence of an enclosing handler. =============== Diff against Tests-cwp.159 =============== Item was added: + ----- Method: ExceptionTests>>testOuter (in category 'testing-outer') ----- + testOuter + | result | + result := [[Notification signal. #signal] + on: Notification + do: [:ex| ex outer. #inner]] + on: Notification + do: [:ex| #outer]. + self assert: result = #outer!

1 0

The Trunk: Tests-cwp.159.mcz
by commits＠source.squeak.org 17 Aug '12

17 Aug '12

Colin Putney uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cwp.159.mcz ==================== Summary ==================== Name: Tests-cwp.159 Author: cwp Time: 14 August 2012, 10:33:15.982 am UUID: b081e01e-3063-4d7f-9804-eda9b599c6a8 Ancestors: Tests-cwp.158 Infix selectors can't include underscores, so remove those tests, and add one that ensures that a single underscore is considered a unary message. =============== Diff against Tests-cwp.157 =============== Item was added: + ----- Method: UnderscoreSelectorsTest>>assertSelector:hasPrecedence: (in category 'support') ----- + assertSelector: aSymbol hasPrecedence: expected + | actual | + actual := aSymbol precedence. + self assert: actual = expected! Item was changed: + ----- Method: UnderscoreSelectorsTest>>pref:during: (in category 'support') ----- - ----- Method: UnderscoreSelectorsTest>>pref:during: (in category 'as yet unclassified') ----- pref: aBoolean during: aBlock | tmp | tmp := Scanner prefAllowUnderscoreSelectors. [Scanner prefAllowUnderscoreSelectors: aBoolean. aBlock value] ensure: [Scanner prefAllowUnderscoreSelectors: tmp].! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP1InternalUnderscore (in category 'tests') ----- + testP1InternalUnderscore + + self + assertSelector: #'is_symbol' + hasPrecedence: 1. + ! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP1LeadingUnderscore (in category 'tests') ----- + testP1LeadingUnderscore + self + assertSelector: #'_isSymbol' + hasPrecedence: 1. + ! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP1SingleUnderscore (in category 'tests') ----- + testP1SingleUnderscore + self + assertSelector: #'_' + hasPrecedence: 1! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP1Traditional (in category 'tests') ----- + testP1Traditional + self + assertSelector: #isSymbol + hasPrecedence: 1! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP1TrailingUnderscore (in category 'tests') ----- + testP1TrailingUnderscore + self + assertSelector: #'isSymbol_' + hasPrecedence: 1! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP2Traditional (in category 'tests') ----- + testP2Traditional + self + assertSelector: #+ + hasPrecedence: 2! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP3InternalUnderscore (in category 'tests') ----- + testP3InternalUnderscore + self + assertSelector: #'with_value:' + hasPrecedence: 3! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP3LeadingUnderscore (in category 'tests') ----- + testP3LeadingUnderscore + self + assertSelector: #'_value:' + hasPrecedence: 3! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP3Traditional (in category 'tests') ----- + testP3Traditional + self + assertSelector: #value: + hasPrecedence: 3! Item was added: + ----- Method: UnderscoreSelectorsTest>>testP3TrailingUnderscore (in category 'tests') ----- + testP3TrailingUnderscore + self + assertSelector: #'value_:' + hasPrecedence: 3! Item was removed: - ----- Method: UnderscoreSelectorsTest>>testPrefFalse (in category 'as yet unclassified') ----- - testPrefFalse - self pref: false during: [self deny: $_ tokenish].! Item was removed: - ----- Method: UnderscoreSelectorsTest>>testPrefTrue (in category 'as yet unclassified') ----- - testPrefTrue - self pref: true during: [self assert: $_ tokenish].! Item was added: + ----- Method: UnderscoreSelectorsTest>>testTokenishFalse (in category 'tests') ----- + testTokenishFalse + self pref: false during: [self deny: $_ tokenish].! Item was added: + ----- Method: UnderscoreSelectorsTest>>testTokenishTrue (in category 'tests') ----- + testTokenishTrue + self pref: true during: [self assert: $_ tokenish].!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
18
Older →

Jump to page: