Squeak-dev July 2012

squeak-dev@lists.squeakfoundation.org

55 participants
189 discussions

Re: [squeak-dev] The Inbox: Kernel-ael.700.mcz
by Balázs Kósi 11 Jul '12

11 Jul '12

Hi, > Deliver 'objects pointing to this value' collection as an Array, to avoid the indirection of an OrderedCollection. What's the benefit of this? Cheers, Balázs

1 0

ss3.gemstone.com MAINTENANCE downtime Friday July 13 from 1-2pm PDT
by Dale Henrichs 11 Jul '12

11 Jul '12

We will be adding more disk space to the ss3.gemstone.com site on Friday July 13 at 1pm PDT. The site is expected to be down for an hour while the new drives are being added. Dale

1 0

Daily Commit Log
by commits＠source.squeak.org 11 Jul '12

11 Jul '12

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2012-July/005417.html Name: KernelTests-dtl.227 Ancestors: KernelTests-nice.226 Patch by JohnReed Maffeo for Mantis 7693: DateAndTime readFrom: does not recognize $Z as a valid timezone designator. http://bugs.squeak.org/view.php?id=7693 Change Set: DateAndTime Date: 9 July 2012 Method readFrom: in Class DateAndTime modified to interpret $Z as a valid time zone designator. Associated test modified to verify the new behavior. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2012-July/005418.html Name: Kernel-dtl.705 Ancestors: Kernel-ul.704 Patch by JohnReed Maffeo for Mantis 7693: DateAndTime readFrom: does not recognize $Z as a valid timezone designator. http://bugs.squeak.org/view.php?id=7693 Change Set: DateAndTime Date: 9 July 2012 Method readFrom: in Class DateAndTime modified to interpret $Z as a valid time zone designator. Associated test modified to verify the new behavior. =============================================

1 0

The Inbox: System-ael.488.mcz
by Aran Lunzer 10 Jul '12

10 Jul '12

This is a proposal for fixing a small bug in the "Profile messages" command on a Process Browser. To recreate the problem: - select a process - invoke "Profile messages" - give a number of seconds - wait for the profile to complete - again invoke "Profile messages" and supply a number of seconds => walkback: 'it seems a tally is already running' Aran -- Aran Lunzer Viewpoints Research Institute

1 0

The Inbox: Kernel-ael.700.mcz
by commits＠source.squeak.org 10 Jul '12

10 Jul '12

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ael.700.mcz ==================== Summary ==================== Name: Kernel-ael.700 Author: ael Time: 10 July 2012, 2:35:54.223 pm UUID: 8fff56ba-e690-46f1-aef9-d9b5fe3c9ed8 Ancestors: Kernel-fbs.699 Deliver 'objects pointing to this value' collection as an Array, to avoid the indirection of an OrderedCollection. =============== Diff against Kernel-fbs.699 =============== Item was changed: ----- Method: Object>>inboundPointersExcluding: (in category 'tracing') ----- inboundPointersExcluding: objectsToExclude "Answer a list of all objects in the system that point to me, excluding those in the collection of objectsToExclude. I do my best to avoid creating any temporary objects that point to myself, especially method and block contexts. Adapted from PointerFinder class >> #pointersTo:except:" | anObj pointers objectsToAlwaysExclude | Smalltalk garbageCollect. "big collection shouldn't grow, so it's contents array is always the same" pointers := OrderedCollection new: 1000. "#allObjectsDo: and #pointsTo: are expanded inline to keep spurious method and block contexts out of the results" anObj := self someObject. [0 == anObj] whileFalse: [ "We must use #== here, to avoid leaving the loop when anObj is another number that's equal to 0 (e.g. 0.0)." anObj isInMemory ifTrue: [((anObj instVarsInclude: self) or: [anObj class == self]) ifTrue: [pointers add: anObj]]. anObj := anObj nextObject]. objectsToAlwaysExclude := { pointers collector. thisContext. thisContext sender. thisContext sender sender. objectsToExclude. }. + ^ (pointers removeAllSuchThat: [:ea | - ^ pointers removeAllSuchThat: [:ea | (objectsToAlwaysExclude identityIncludes: ea) + or: [objectsToExclude identityIncludes: ea]]) asArray! - or: [objectsToExclude identityIncludes: ea]]!

1 0

The Inbox: System-ael.488.mcz
by commits＠source.squeak.org 10 Jul '12

10 Jul '12

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ael.488.mcz ==================== Summary ==================== Name: System-ael.488 Author: ael Time: 10 July 2012, 1:56:20.102 pm UUID: 18e76459-4ed0-478c-b2b3-9d587d1f6b3d Ancestors: System-eem.487 Tentative fix for 'tally is already running' error when profiling from ProcessBrowser. =============== Diff against System-eem.487 =============== Item was changed: ----- Method: MessageTally>>spyEvery:onProcess:forMilliseconds: (in category 'initialize-release') ----- spyEvery: millisecs onProcess: aProcess forMilliseconds: msecDuration "Create a spy and spy on the given process at the specified rate." | myDelay time0 endTime observedProcess sem | (aProcess isKindOf: Process) ifFalse: [self error: 'spy needs a Process here']. self class: aProcess suspendedContext receiver class method: aProcess suspendedContext method. "set up the probe" observedProcess := aProcess. myDelay := Delay forMilliseconds: millisecs. time0 := Time millisecondClockValue. endTime := time0 + msecDuration. sem := Semaphore new. gcStats := SmalltalkImage current getVMParameters. Timer ifNotNil: [ self error: 'it seems a tally is already running' ]. Timer := [ [ | startTime | startTime := Time millisecondClockValue. myDelay wait. self tally: Processor preemptedProcess suspendedContext in: (observedProcess == Processor preemptedProcess ifTrue: [ observedProcess ] ifFalse: [ nil ]) "tally can be > 1 if ran a long primitive" by: (Time millisecondClockValue - startTime) // millisecs. startTime < endTime ] whileTrue. sem signal. ] newProcess. Timer priority: Processor timingPriority-1. "activate the probe and evaluate the block" Timer resume. "activate the probe and wait for it to finish" sem wait. + Timer ifNotNil: [ + Timer terminate. + Timer := nil ]. "Collect gc statistics" SmalltalkImage current getVMParameters keysAndValuesDo: [ :idx :gcVal | gcVal ifNotNil: [ gcStats at: idx put: (gcVal - (gcStats at: idx)) ] ]. time := Time millisecondClockValue - time0!

1 0

Bug Fix and a Question concerning DateAndTime in Kernal-Chronology
by JohnReed Maffeo 10 Jul '12

10 Jul '12

For the first time in many years I am de-lurking to submit a change to Squeak. My report and suggested fix is at http://bugs.squeak.org/view.php?id=7693. The change is a modification of the behavior of fromString: to interpret $Z as a valid time zone designator. I am only posting this to the list for confirmation that I did the right thing using Mantis, and to ask a question about the name/behavior of the method asUTC in class DateAndTime. The name asUTC makes me think that the parameter provided will be converted to the equivalent value at the zero time zone. Instead the method just converts the time zone offset to zero. I am not sure what the intention revealing method name should be for the current behavior, but since asUTC and asLocal are already taken, I would like to suggest a set of methods to convert a given DateAndTime toUTC and toLocal. I think I could code them up with the appropriate tests and would welcome the challenge if there is any support for the suggestion. Regards, JohnReed

4 3

Re: [squeak-dev] The Trunk: System-bf.488.mcz
by Chris Muller 10 Jul '12

10 Jul '12

Beat me to it but you forgot to update the sends to #asStringWithCommasSigned. It was deprecated because this is the only sender and it's an exceptional case to want to print "+" in front. We should use #asStringWithCommasSigned: true. On Mon, Jul 9, 2012 at 7:55 AM, <commits(a)source.squeak.org> wrote: > Bert Freudenberg uploaded a new version of System to project The Trunk: > http://source.squeak.org/trunk/System-bf.488.mcz > > ==================== Summary ==================== > > Name: System-bf.488 > Author: bf > Time: 9 July 2012, 2:55:32.107 pm > UUID: 1f332f03-ee04-4f81-8e73-c2e3b203a85d > Ancestors: System-eem.487 > > Format floats using print:maxDecimalPlaces: instead of roundTo:. > > =============== Diff against System-eem.487 =============== > > Item was changed: > ----- Method: MessageTally>>reportGCStatsOn: (in category 'reporting') ----- > reportGCStatsOn: str > | oldSpaceEnd youngSpaceEnd memoryEnd fullGCs fullGCTime incrGCs incrGCTime tenureCount upTime rootOverflows | > upTime := time. > oldSpaceEnd := gcStats at: 1. > youngSpaceEnd := gcStats at: 2. > memoryEnd := gcStats at: 3. > fullGCs := gcStats at: 7. > fullGCTime := gcStats at: 8. > incrGCs := gcStats at: 9. > incrGCTime := gcStats at: 10. > tenureCount := gcStats at: 11. > rootOverflows := gcStats at: 22. > > str cr. > str nextPutAll: '**Memory**'; cr. > str nextPutAll: ' old '; > nextPutAll: oldSpaceEnd asStringWithCommasSigned; nextPutAll: ' bytes'; cr. > str nextPutAll: ' young '; > nextPutAll: (youngSpaceEnd - oldSpaceEnd) asStringWithCommasSigned; nextPutAll: ' bytes'; cr. > str nextPutAll: ' used '; > nextPutAll: youngSpaceEnd asStringWithCommasSigned; nextPutAll: ' bytes'; cr. > str nextPutAll: ' free '; > nextPutAll: (memoryEnd - youngSpaceEnd) asStringWithCommasSigned; nextPutAll: ' bytes'; cr. > > str cr. > str nextPutAll: '**GCs**'; cr. > str nextPutAll: ' full '; > + print: fullGCs; nextPutAll: ' totalling '; nextPutAll: fullGCTime asStringWithCommas; nextPutAll: ' ms ('; > + print: (fullGCTime / upTime * 100) maxDecimalPlaces: 2; > - print: fullGCs; nextPutAll: ' totalling '; nextPutAll: fullGCTime asStringWithCommas; nextPutAll: 'ms ('; > - print: ((fullGCTime / upTime * 100) roundTo: 1.0); > nextPutAll: '% uptime)'. > fullGCs = 0 ifFalse: > + [str nextPutAll: ', avg '; print: (fullGCTime / fullGCs) maxDecimalPlaces: 1; nextPutAll: ' ms']. > - [str nextPutAll: ', avg '; print: ((fullGCTime / fullGCs) roundTo: 1.0); nextPutAll: 'ms']. > str cr. > + str nextPutAll: ' incr '; > + print: incrGCs; nextPutAll: ' totalling '; nextPutAll: incrGCTime asStringWithCommas; nextPutAll: ' ms ('; > + print: (incrGCTime / upTime * 100) maxDecimalPlaces: 1; > - str nextPutAll: ' incr '; > - print: incrGCs; nextPutAll: ' totalling '; nextPutAll: incrGCTime asStringWithCommas; nextPutAll: 'ms ('; > - print: ((incrGCTime / upTime * 100) roundTo: 1.0); > nextPutAll: '% uptime)'. > incrGCs = 0 ifFalse: > + [str nextPutAll: ', avg '; print: (incrGCTime / incrGCs) maxDecimalPlaces: 1; nextPutAll: ' ms']. > - [str nextPutAll:', avg '; print: ((incrGCTime / incrGCs) roundTo: 1.0); nextPutAll: 'ms']. > str cr. > str nextPutAll: ' tenures '; > nextPutAll: tenureCount asStringWithCommas. > tenureCount = 0 ifFalse: > + [str nextPutAll: ' (avg '; print: incrGCs // tenureCount; nextPutAll: ' GCs/tenure)']. > - [str nextPutAll: ' (avg '; print: (incrGCs / tenureCount) asInteger; nextPutAll: ' GCs/tenure)']. > str cr. > str nextPutAll: ' root table '; > + nextPutAll: rootOverflows asStringWithCommas; nextPutAll: ' overflows'. > - nextPutAll: rootOverflows asStringWithCommas; nextPutAll:' overflows'. > str cr. > ! > > Item was changed: > ----- Method: SmalltalkImage>>vmStatisticsReportString (in category 'vm statistics') ----- > vmStatisticsReportString > "StringHolderView open: (StringHolder new contents: > SmalltalkImage current vmStatisticsReportString) label: 'VM Statistics'" > > | params oldSpaceEnd youngSpaceEnd memoryEnd fullGCs fullGCTime incrGCs incrGCTime tenureCount upTime upTime2 fullGCs2 fullGCTime2 incrGCs2 incrGCTime2 tenureCount2 str | > params := self getVMParameters. > oldSpaceEnd := params at: 1. > youngSpaceEnd := params at: 2. > memoryEnd := params at: 3. > fullGCs := params at: 7. > fullGCTime := params at: 8. > incrGCs := params at: 9. > incrGCTime := params at: 10. > tenureCount := params at: 11. > upTime := Time millisecondClockValue. > > str := WriteStream on: (String new: 1000). > str nextPutAll: 'uptime '; > print: (upTime / 1000 / 60 // 60); nextPut: $h; > print: (upTime / 1000 / 60 \\ 60) asInteger; nextPut: $m; > print: (upTime / 1000 \\ 60) asInteger; nextPut: $s; cr. > > + str nextPutAll: 'memory '; > - str nextPutAll: 'memory '; > nextPutAll: memoryEnd asStringWithCommas; nextPutAll: ' bytes'; cr. > str nextPutAll: ' old '; > nextPutAll: oldSpaceEnd asStringWithCommas; nextPutAll: ' bytes ('; > + print: (oldSpaceEnd / memoryEnd * 100) maxDecimalPlaces: 1; nextPutAll: '%)'; cr. > - print: ((oldSpaceEnd / memoryEnd * 100) roundTo: 0.1); nextPutAll: '%)'; cr. > str nextPutAll: ' young '; > nextPutAll: (youngSpaceEnd - oldSpaceEnd) asStringWithCommas; nextPutAll: ' bytes ('; > + print: (youngSpaceEnd - oldSpaceEnd / memoryEnd * 100) maxDecimalPlaces: 1; nextPutAll: '%)'; cr. > - print: ((youngSpaceEnd - oldSpaceEnd / memoryEnd * 100) roundTo: 0.1); nextPutAll: '%)'; cr. > str nextPutAll: ' used '; > nextPutAll: youngSpaceEnd asStringWithCommas; nextPutAll: ' bytes ('; > + print: (youngSpaceEnd / memoryEnd * 100) maxDecimalPlaces: 1; nextPutAll: '%)'; cr. > - print: ((youngSpaceEnd / memoryEnd * 100) roundTo: 0.1); nextPutAll: '%)'; cr. > str nextPutAll: ' free '; > nextPutAll: (memoryEnd - youngSpaceEnd) asStringWithCommas; nextPutAll: ' bytes ('; > + print: (memoryEnd - youngSpaceEnd / memoryEnd * 100) maxDecimalPlaces: 1; nextPutAll: '%)'; cr. > - print: ((memoryEnd - youngSpaceEnd / memoryEnd * 100) roundTo: 0.1); nextPutAll: '%)'; cr. > > + str nextPutAll: 'GCs '; > - str nextPutAll: 'GCs '; > nextPutAll: (fullGCs + incrGCs) asStringWithCommas. > fullGCs + incrGCs > 0 ifTrue: [ > str > nextPutAll: ' ('; > + print: (upTime / (fullGCs + incrGCs)) maxDecimalPlaces: 1; > + nextPutAll: ' ms between GCs)' > - print: ((upTime / (fullGCs + incrGCs)) roundTo: 1); > - nextPutAll: 'ms between GCs)' > ]. > str cr. > str nextPutAll: ' full '; > + nextPutAll: fullGCs asStringWithCommas; nextPutAll: ' totalling '; nextPutAll: fullGCTime asStringWithCommas; nextPutAll: ' ms ('; > + print: (fullGCTime / upTime * 100) maxDecimalPlaces: 1; > - print: fullGCs; nextPutAll: ' totalling '; nextPutAll: fullGCTime asStringWithCommas; nextPutAll: 'ms ('; > - print: ((fullGCTime / upTime * 100) roundTo: 1.0); > nextPutAll: '% uptime)'. > fullGCs = 0 ifFalse: > + [str nextPutAll: ', avg '; print: (fullGCTime / fullGCs) maxDecimalPlaces: 1; nextPutAll: ' ms']. > - [str nextPutAll: ', avg '; print: ((fullGCTime / fullGCs) roundTo: 1.0); nextPutAll: 'ms']. > str cr. > + str nextPutAll: ' incr '; > + nextPutAll: incrGCs asStringWithCommas; nextPutAll: ' totalling '; nextPutAll: incrGCTime asStringWithCommas; nextPutAll: ' ms ('; > + print: (incrGCTime / upTime * 100) maxDecimalPlaces: 1; > + nextPutAll: '% uptime), avg '; print: (incrGCTime / incrGCs) maxDecimalPlaces: 1; nextPutAll: ' ms'; cr. > - str nextPutAll: ' incr '; > - print: incrGCs; nextPutAll: ' totalling '; nextPutAll: incrGCTime asStringWithCommas; nextPutAll: 'ms ('; > - print: ((incrGCTime / upTime * 100) roundTo: 1.0); > - nextPutAll: '% uptime), avg '; print: ((incrGCTime / incrGCs) roundTo: 1.0); nextPutAll: 'ms'; cr. > str nextPutAll: ' tenures '; > nextPutAll: tenureCount asStringWithCommas. > tenureCount = 0 ifFalse: > + [str nextPutAll: ' (avg '; print: incrGCs // tenureCount; nextPutAll: ' GCs/tenure)']. > - [str nextPutAll: ' (avg '; print: (incrGCs / tenureCount) asInteger; nextPutAll: ' GCs/tenure)']. > str cr. > > LastStats ifNil: [LastStats := Array new: 6] > ifNotNil: [ > upTime2 := upTime - (LastStats at: 1). > fullGCs2 := fullGCs - (LastStats at: 2). > fullGCTime2 := fullGCTime - (LastStats at: 3). > incrGCs2 := incrGCs - (LastStats at: 4). > incrGCTime2 := incrGCTime - (LastStats at: 5). > tenureCount2 := tenureCount - (LastStats at: 6). > > str nextPutAll: self textMarkerForShortReport ; > nextPutAll: (fullGCs2 + incrGCs2) asStringWithCommas. > fullGCs2 + incrGCs2 > 0 ifTrue: [ > str > nextPutAll: ' ('; > + print: upTime2 // (fullGCs2 + incrGCs2); > + nextPutAll: ' ms between GCs)'. > - print: ((upTime2 / (fullGCs2 + incrGCs2)) roundTo: 1); > - nextPutAll: 'ms between GCs)'. > ]. > str cr. > + str nextPutAll: ' uptime '; print: (upTime2 / 1000.0) maxDecimalPlaces: 1; nextPutAll: ' s'; cr. > - str nextPutAll: ' uptime '; print: ((upTime2 / 1000.0) roundTo: 0.1); nextPutAll: 's'; cr. > str nextPutAll: ' full '; > + nextPutAll: fullGCs2 asStringWithCommas; nextPutAll: ' totalling '; nextPutAll: fullGCTime2 asStringWithCommas; nextPutAll: ' ms ('; > + print: (fullGCTime2 / upTime2 * 100) maxDecimalPlaces: 1; > - print: fullGCs2; nextPutAll: ' totalling '; nextPutAll: fullGCTime2 asStringWithCommas; nextPutAll: 'ms ('; > - print: ((fullGCTime2 / upTime2 * 100) roundTo: 1.0); > nextPutAll: '% uptime)'. > fullGCs2 = 0 ifFalse: > + [str nextPutAll: ', avg '; print: (fullGCTime2 / fullGCs2) maxDecimalPlaces: 1; nextPutAll: ' ms']. > - [str nextPutAll: ', avg '; print: ((fullGCTime2 / fullGCs2) roundTo: 1.0); nextPutAll: 'ms']. > str cr. > + str nextPutAll: ' incr '; > + nextPutAll: incrGCs2 asStringWithCommas; nextPutAll: ' totalling '; nextPutAll: incrGCTime2 asStringWithCommas; nextPutAll: ' ms ('; > + print: (incrGCTime2 / upTime2 * 100) maxDecimalPlaces: 1; > - str nextPutAll: ' incr '; > - print: incrGCs2; nextPutAll: ' totalling '; nextPutAll: incrGCTime2 asStringWithCommas; nextPutAll: 'ms ('; > - print: ((incrGCTime2 / upTime2 * 100) roundTo: 1.0); > nextPutAll: '% uptime), avg '. > incrGCs2 > 0 ifTrue: [ > + str print: (incrGCTime2 / incrGCs2) maxDecimalPlaces: 1; nextPutAll: ' ms' > - str print: ((incrGCTime2 / incrGCs2) roundTo: 1.0); nextPutAll: 'ms' > ]. > str cr. > str nextPutAll: ' tenures '; > nextPutAll: tenureCount2 asStringWithCommas. > tenureCount2 = 0 ifFalse: > + [str nextPutAll: ' (avg '; print: incrGCs2 // tenureCount2; nextPutAll: ' GCs/tenure)']. > - [str nextPutAll: ' (avg '; print: (incrGCs2 / tenureCount2) asInteger; nextPutAll: ' GCs/tenure)']. > str cr. > ]. > LastStats at: 1 put: upTime. > LastStats at: 2 put: fullGCs. > LastStats at: 3 put: fullGCTime. > LastStats at: 4 put: incrGCs. > LastStats at: 5 put: incrGCTime. > LastStats at: 6 put: tenureCount. > > ^ str contents > ! > >

3 5

The Trunk: Kernel-dtl.705.mcz
by commits＠source.squeak.org 10 Jul '12

10 Jul '12

David T. Lewis uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-dtl.705.mcz ==================== Summary ==================== Name: Kernel-dtl.705 Author: dtl Time: 9 July 2012, 10:38:16.262 pm UUID: b52aa671-18a1-43f6-b389-4430bfc0fe9a Ancestors: Kernel-ul.704 Patch by JohnReed Maffeo for Mantis 7693: DateAndTime readFrom: does not recognize $Z as a valid timezone designator. http://bugs.squeak.org/view.php?id=7693 Change Set: DateAndTime Date: 9 July 2012 Author: jrm Method readFrom: in Class DateAndTime modified to interpret $Z as a valid time zone designator. Associated test modified to verify the new behavior. =============== Diff against Kernel-ul.704 =============== Item was changed: ----- Method: DateAndTime class>>readFrom: (in category 'squeak protocol') ----- readFrom: aStream | offset date time ch | date := Date readFrom: aStream. [aStream peek isDigit] whileFalse: [aStream next]. time := Time readFrom: aStream. aStream atEnd + ifTrue: [ (aStream last = $Z) ifTrue: [offset := Duration zero] ifFalse: [ offset := self localOffset ]] - ifTrue: [ offset := self localOffset ] ifFalse: [ ch := aStream next. ch = $+ ifTrue: [ch := Character space]. offset := Duration fromString: ch asString, '0:', aStream upToEnd, ':0']. ^ self year: date year month: date monthIndex day: date dayOfMonth hour: time hour minute: time minute second: time second nanoSecond: time nanoSecond offset: offset " '-1199-01-05T20:33:14.321-05:00' asDateAndTime ' 2002-05-16T17:20:45.1+01:01' asDateAndTime ' 2002-05-16T17:20:45.02+01:01' asDateAndTime ' 2002-05-16T17:20:45.003+01:01' asDateAndTime ' 2002-05-16T17:20:45.0004+01:01' asDateAndTime ' 2002-05-16T17:20:45.00005' asDateAndTime ' 2002-05-16T17:20:45.000006+01:01' asDateAndTime ' 2002-05-16T17:20:45.0000007+01:01' asDateAndTime ' 2002-05-16T17:20:45.00000008-01:01' asDateAndTime ' 2002-05-16T17:20:45.000000009+01:01' asDateAndTime ' 2002-05-16T17:20:45.0000000001+01:01' asDateAndTime ' 2002-05-16T17:20' asDateAndTime ' 2002-05-16T17:20:45' asDateAndTime ' 2002-05-16T17:20:45+01:57' asDateAndTime ' 2002-05-16T17:20:45-02:34' asDateAndTime ' 2002-05-16T17:20:45+00:00' asDateAndTime ' 1997-04-26T01:02:03+01:02:3' asDateAndTime "!

1 0

The Trunk: KernelTests-dtl.227.mcz
by commits＠source.squeak.org 10 Jul '12

10 Jul '12

David T. Lewis uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-dtl.227.mcz ==================== Summary ==================== Name: KernelTests-dtl.227 Author: dtl Time: 9 July 2012, 10:36:20.756 pm UUID: 24287063-d5f2-4af5-ba04-c23fb2c4f5c5 Ancestors: KernelTests-nice.226 Patch by JohnReed Maffeo for Mantis 7693: DateAndTime readFrom: does not recognize $Z as a valid timezone designator. http://bugs.squeak.org/view.php?id=7693 Change Set: DateAndTime Date: 9 July 2012 Author: jrm Method readFrom: in Class DateAndTime modified to interpret $Z as a valid time zone designator. Associated test modified to verify the new behavior. =============== Diff against KernelTests-nice.226 =============== Item was changed: ----- Method: DateAndTimeTest>>testFromString (in category 'Tests') ----- testFromString + | fromString fromStringNoOffset fromStringUTC | - | fromString fromStringNoOffset | fromString := DateAndTime fromString: '-1199-01-05T20:33:14.321-05:00'. self assert: (fromString printString = '-1199-01-05T20:33:14.321-05:00'). "if no offset is provided, the local offset should be used" fromStringNoOffset := DateAndTime fromString: '-1199-01-05T20:33:14.321'. + self assert: (fromStringNoOffset offset = DateAndTime localOffset). + + "if a string contains the UTC designator Z, the local offset should not be used" + fromStringUTC := DateAndTime fromString: '2011-08-26T18:00:03Z'. + self assert: (fromStringUTC printString = '2011-08-26T18:00:03+00:00').! - self assert: (fromStringNoOffset offset = DateAndTime localOffset).!

1 0

Jump to page: