Squeak-dev July 2011

squeak-dev@lists.squeakfoundation.org

61 participants
145 discussions

Squeak Oversight Board minutes – 7/19/11
by Chris Cunnington 20 Jul '11

20 Jul '11

Squeak Oversight Board minutes – 7/19/11 Attending: Chris Muller, Bert Freudenberg, Colin Putney, Randal Schwartz, Levente Uzonyi, Jecel Assumpacao Jr., Chris Cunnington; and Craig Latta -Special guess speaker at this meeting Craig Latta discussing Spoon -Spoon looks like this: You have an open 4.2 image with a browser called the Remote Browser. It looks into the miniature image that exists outside the 4.2 image. You can perform changes on the miniature image from within the 4.2 image. -Adding code from the 4.2 image to the miniature image is called “imprinting”. Methods are sent over from the 4.2 ObjectMemory a method at a time. They are given an identifier before being sent to the remote image. Some additional information such as “Class” is added to the method before transport. A client in the 4.2 image sends the method to the server in the other image. -The native state of a Spoon method can be passed between any dialect of Smalltalk as a pure piece of ObjectMemory called a module -The inter-image communication is accomplished using a socket package called Flow, which does not seem to appear on SqueakSource, and yet is a project over a decade old -Spoon “imprinting” is accomplished, because some changes are made to the virtual machine with the client. -The process of images talking to each other is called remote messaging and it allows both images to know what methods are present in each image -Spoon has modifications made in the garbage collector. Each method in the micro image has a bit that gets flipped if that method is actually used. The GC can then delete any method that was not used in an execution. This turns 99% of unwanted ObjectMemory to dust. -The question of Spoon arose at the SOB last meeting when the issue of Cog becoming the official vm for Squeak was raised. This would be an important transition, as older images may not run on the new virtual machine. This issue attracted an older idea previously discussed of making a Squeak based on Spoon. -It looks as though the work on Spoon could be adopted incrementally. Support for the possibilities raised by Spoon in the SOB is high. -An Agenda Item For The Next Meeting: Software Freedom Conservancy; first impressions playing with the Spoon release

1 0

The Trunk: Kernel-nice.610.mcz
by commits＠source.squeak.org 20 Jul '11

20 Jul '11

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.610.mcz ==================== Summary ==================== Name: Kernel-nice.610 Author: nice Time: 20 July 2011, 12:54:38.514 pm UUID: b6b7d674-a3ce-4967-876a-b041c32d03a8 Ancestors: Kernel-nice.609 Pulizie. You shall not decently ask any object if it hasLiteralThorough: =============== Diff against Kernel-nice.609 =============== Item was removed: - ----- Method: Object>>hasLiteralThorough: (in category 'testing') ----- - hasLiteralThorough: literal - "Answer true if literal is identical to any literal in this array, even if imbedded in further structures. This is the end of the imbedded structure path so return false." - - ^ false!

1 0

The Trunk: Collections-nice.448.mcz
by commits＠source.squeak.org 20 Jul '11

20 Jul '11

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.448.mcz ==================== Summary ==================== Name: Collections-nice.448 Author: nice Time: 20 July 2011, 12:47:46.869 pm UUID: e486c811-3c45-4a6a-ad16-aba32db79745 Ancestors: Collections-nice.447 Don't deprecate #hasLiteralThorough: remove it, because the - in the change report are so cute. =============== Diff against Collections-nice.447 =============== Item was removed: - ----- Method: Array>>hasLiteralThorough: (in category 'private') ----- - hasLiteralThorough: literal - "Answer true if literal is identical to any literal in this array, even if imbedded in further array structures or closure methods" - - self deprecated: 'Never send #hasLiteralThorough: to an Array, just use #hasLiteral:'. - ^self hasLiteral: literal!

1 0

The Trunk: Kernel-nice.609.mcz
by commits＠source.squeak.org 20 Jul '11

20 Jul '11

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.609.mcz ==================== Summary ==================== Name: Kernel-nice.609 Author: nice Time: 20 July 2011, 9:29:30.183 am UUID: 50b9cca2-c2a0-47c3-a367-2eae2ed530de Ancestors: Kernel-eem.608 Use literalEqual: in hasLiteral: and hasLiteralThorough: Remove hasLiteralThorough:from: because it is suspect: - it is not sent - it checks whether aLiteral == aBlock which cannot happen in Squeak implementation - it send hasLiteralThorough: to literals which was weired and is now deprecated =============== Diff against Kernel-eem.608 =============== Item was changed: ----- Method: CompiledMethod>>hasLiteral: (in category 'literals') ----- hasLiteral: literal - | litClass lit | "Answer whether the receiver references the argument, literal." - litClass := literal class. 2 to: self numLiterals - 1 do: "exclude superclass + selector/properties" [:index | + ((self objectAt: index) literalEqual: literal) ifTrue: [^true]]. - lit := self objectAt: index. - (litClass == lit class and: [literal = lit]) ifTrue: [^true]]. ^false! Item was changed: ----- Method: CompiledMethod>>hasLiteralThorough: (in category 'literals') ----- hasLiteralThorough: literal "Answer true if any literal in this method is literal, even if embedded in array structure." (self penultimateLiteral isMethodProperties and: [self penultimateLiteral hasLiteralThorough: literal]) ifTrue:[^true]. 2 to: self numLiterals - 1 "exclude superclass + selector/properties" do:[:index | | lit | + (((lit := self objectAt: index) literalEqual: literal) - ((lit := self objectAt: index) == literal or: [(lit isVariableBinding and: [lit key == literal]) or: [lit isArray and: [lit hasLiteral: literal]]]) ifTrue: [^ true]]. ^ false ! Item was removed: - ----- Method: CompiledMethod>>hasLiteralThorough:from: (in category 'literals') ----- - hasLiteralThorough: aLiteral from: aBlock - "Answer true if any literal in this method is literal, even if embedded in array structure or within its pragmas." - - | literal | - self pragmas do: [ :pragma | - (pragma hasLiteral: aLiteral) ifTrue: [ ^ true ] ]. - 2 to: self numLiterals + 1 do: [ :index | - literal := self objectAt: index. - literal == aLiteral ifTrue: [ ^ true ]. - literal == aBlock ifFalse:[ (literal hasLiteralThorough: aLiteral) ifTrue: [ ^ true ]] ]. - ^ false.!

1 0

The Trunk: Collections-nice.447.mcz
by commits＠source.squeak.org 20 Jul '11

20 Jul '11

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.447.mcz ==================== Summary ==================== Name: Collections-nice.447 Author: nice Time: 20 July 2011, 9:22:39.538 am UUID: d4b8e2f5-d54f-49a0-a8af-d31df8268adc Ancestors: Collections-eem.446 Refine Association>>literalEqual: to correctly handle variable binding identity. Use literalEqual: in hasLiteral: Deprecate use of Array>>#hasLiteralThorough: =============== Diff against Collections-eem.446 =============== Item was changed: ----- Method: Array>>hasLiteral: (in category 'private') ----- hasLiteral: literal "Answer true if literal is identical to any literal in this array, even if imbedded in further array structure. This method is only intended for private use by CompiledMethod hasLiteralSymbol:" + | lit | - | litClass lit | - litClass := literal class. 1 to: self size do: [:index | + ((lit := self at: index) literalEqual: literal) ifTrue: [^true]. + (Array == lit class and: [lit hasLiteral: literal]) ifTrue: [^true]]. - (litClass == (lit := self at: index) class - and: [literal = lit]) ifTrue: [^true]. - (Array == lit class - and: [lit hasLiteral: literal]) ifTrue: [^true]]. ^false! Item was changed: ----- Method: Array>>hasLiteralThorough: (in category 'private') ----- hasLiteralThorough: literal "Answer true if literal is identical to any literal in this array, even if imbedded in further array structures or closure methods" + self deprecated: 'Never send #hasLiteralThorough: to an Array, just use #hasLiteral:'. + ^self hasLiteral: literal! - | lit | - 1 to: self size do: [:index | - (lit := self at: index) == literal ifTrue: [^ true]. - (lit hasLiteralThorough: literal) ifTrue: [^ true]]. - ^ false! Item was added: + ----- Method: Association>>literalEqual: (in category 'testing') ----- + literalEqual: otherLiteral + "Answer true if the receiver and otherLiteral represent the same literal. + Variable bindings are literally equals only if identical. + This is how variable sharing works, by preserving identity and changing only the value." + ^self == otherLiteral!

1 0

Daily Commit Log
by commits＠source.squeak.org 20 Jul '11

20 Jul '11

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2011-July/004868.html Name: Kernel-eem.608 Ancestors: Kernel-ul.607 Fix CompiledMethod>>hasLiteral: to not look for ==, but literal equal (class == & value =) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-July/004869.html Name: Collections-eem.446 Ancestors: Collections-ul.445 Fix Array>>hasLiteral: to not look for ==, but literal equal (class == & value =). Accompanies Kernel-ul.607 =============================================

1 0

Re: [Pharo-project] Why does CompiledMethod>>hasLiteral: use ==
by Eliot Miranda 19 Jul '11

19 Jul '11

On Mon, Jul 18, 2011 at 2:40 PM, Sean P. DeNigris <sean(a)clipperadams.com>wrote: > I tried: > > aMethod hasLiteral: #DateAndTime->DateAndTime > > and got false, even though an "=" literal is indeed there. > > Why doesn't #hasLiteral: use #=? > Well, the tricky thing with literals is that 0.0 = 0 and 'one' = #one but these are all different literals. That said, it looks like a bug to me. It should surely be !CompiledMethod methodsFor: 'literals' stamp: 'eem 7/19/2011 09:19'! hasLiteral: literal | litClass lit | "Answer whether the receiver references the argument, literal." litClass := literal class. 2 to: self numLiterals - 1 do: "exclude superclass + selector/properties" [:index | lit := self objectAt: index. (litClass == lit class and: [literal = lit]) ifTrue: [^true]]. ^false! ! !Array methodsFor: 'private' stamp: 'eem 7/19/2011 09:20'! hasLiteral: literal "Answer true if literal is identical to any literal in this array, even if imbedded in further array structure. This method is only intended for private use by CompiledMethod hasLiteralSymbol:" | litClass lit | litClass := literal class. 1 to: self size do: [:index | (litClass == (lit := self at: index) class and: [literal = lit]) ifTrue: [^true]. (Array == lit class and: [lit hasLiteral: literal]) ifTrue: [^true]]. ^false! ! I've run all the tests in a trunk 4.2 before and after and making the above change makes no difference. So I think I'll go ahead and commit the change to Squeak trunk. I'll leave the Pharo folks to apply it there-in. Files attached. > Thanks. > Sean > > -- > View this message in context: > http://forum.world.st/Why-does-CompiledMethod-hasLiteral-use-tp3676573p3676… > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > > -- best, Eliot

3 7

The Trunk: Collections-eem.446.mcz
by commits＠source.squeak.org 19 Jul '11

19 Jul '11

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.446.mcz ==================== Summary ==================== Name: Collections-eem.446 Author: eem Time: 19 July 2011, 9:48:30.436 am UUID: 7adb8007-2e80-415a-9d53-b145ba76dcce Ancestors: Collections-ul.445 Fix Array>>hasLiteral: to not look for ==, but literal equal (class == & value =). Accompanies Kernel-ul.607 =============== Diff against Collections-ul.445 =============== Item was changed: ----- Method: Array>>hasLiteral: (in category 'private') ----- hasLiteral: literal "Answer true if literal is identical to any literal in this array, even if imbedded in further array structure. This method is only intended for private use by CompiledMethod hasLiteralSymbol:" + | litClass lit | + litClass := literal class. - | lit | 1 to: self size do: [:index | + (litClass == (lit := self at: index) class + and: [literal = lit]) ifTrue: [^true]. + (Array == lit class + and: [lit hasLiteral: literal]) ifTrue: [^true]]. + ^false! - (lit := self at: index) == literal ifTrue: [^ true]. - (lit class == Array and: [lit hasLiteral: literal]) ifTrue: [^ true]]. - ^ false!

1 0

The Trunk: Kernel-eem.608.mcz
by commits＠source.squeak.org 19 Jul '11

19 Jul '11

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.608.mcz ==================== Summary ==================== Name: Kernel-eem.608 Author: eem Time: 19 July 2011, 9:46:25.127 am UUID: 0c48ee9d-2fdf-4ad9-9f55-5187010b71f7 Ancestors: Kernel-ul.607 Fix CompiledMethod>>hasLiteral: to not look for ==, but literal equal (class == & value =) =============== Diff against Kernel-ul.607 =============== Item was changed: ----- Method: CompiledMethod>>hasLiteral: (in category 'literals') ----- hasLiteral: literal + | litClass lit | "Answer whether the receiver references the argument, literal." + litClass := literal class. + 2 to: self numLiterals - 1 do: "exclude superclass + selector/properties" + [:index | + lit := self objectAt: index. + (litClass == lit class and: [literal = lit]) ifTrue: [^true]]. - 2 to: self numLiterals - 1 "exclude superclass + selector/properties" - do:[:index | - literal == (self objectAt: index) ifTrue: [^true]]. ^false!

1 0

Daily Commit Log
by commits＠source.squeak.org 19 Jul '11

19 Jul '11

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2011-July/004862.html Name: System-ul.449 Ancestors: System-ul.448 SystemNavigation refactoring part 2. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-July/004863.html Name: Kernel-ul.606 Ancestors: Kernel-nice.605 Copy the lowBit per byte table from SmallInteger >> #lowBit to a class variable in Integer, so it can also be used from other methods without duplication. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-July/004864.html Name: Collections-ul.445 Ancestors: Collections-ul.444 Use #allSelectorsAndMethodsDo: instead of #allSelect:. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-July/004865.html Name: Kernel-ul.607 Ancestors: Kernel-ul.606 - Behavior >> #allLocalCallsOn: was moved to the System package. - use LowBitPerByteTable from #lowBit implementations - enhanced Integer >> #lowBit ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-July/004866.html Name: Multilingual-ul.153 Ancestors: Multilingual-ul.152 Use #allSelectorsAndMethodsDo: instead of #allSelect:. Avoid duplication of #numberOfTimesStringIsUsed:. Don't flush the Transcript so eagerly. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2011-July/004867.html Name: Multilingual-ul.154 Ancestors: Multilingual-ul.153 SystemNavigation >> #allSelect: was moved to the System package. =============================================

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
15
Older →

Jump to page: