Squeak-dev May 2011

squeak-dev@lists.squeakfoundation.org

84 participants
303 discussions

The Trunk: Kernel-cmm.578.mcz
by commits＠source.squeak.org 03 May '11

03 May '11

Chris Muller uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-cmm.578.mcz ==================== Summary ==================== Name: Kernel-cmm.578 Author: cmm Time: 2 May 2011, 6:46:17.696 pm UUID: 913d762f-e361-4f5e-814f-0b0692ffa4d9 Ancestors: Kernel-ul.577 - Support for streamlined variable reference / assignment browsing. - Fix for Month class>>#readFrom:. =============== Diff against Kernel-ul.577 =============== Item was added: + ----- Method: Behavior>>whichMethodsStoreInto: (in category 'testing method dictionary') ----- + whichMethodsStoreInto: instVarName + "Answer a collection of selectors whose methods access the argument, + instVarName, as a named instance variable." + "Point whichMethodsStoreInto: 'x'." + | instVarIndex | + instVarIndex := self allInstVarNames + indexOf: instVarName + ifAbsent: [ ^ IdentitySet new ]. + ^ Array streamContents: + [ : stream | self methodDict keysAndValuesDo: + [ : eachSelector : eachMethod | (eachMethod writesField: instVarIndex) ifTrue: [ stream nextPut: eachMethod ] ] ]! Item was removed: - ----- Method: Behavior>>whichSelectorsAssign: (in category 'queries') ----- - whichSelectorsAssign: instVarName - "Answer a Set of selectors whose methods store into the argument, - instVarName, as a named instance variable." - ^self whichSelectorsStoreInto: instVarName! Item was changed: ----- Method: Class>>allClassVarNames (in category 'class variables') ----- allClassVarNames + "Answer a Set of the names of the receiver's class variables, including those defined in the superclasses of the receiver." - "Answer a Set of the names of the receiver's class variables, including those - defined in the superclasses of the receiver." - | aSet | + ^ self superclass == nil - self superclass == nil ifTrue: + [self classVarNames asSet] "This is the keys so it is a new Set." - [^self classVarNames asSet] "This is the keys so it is a new Set." ifFalse: [aSet := self superclass allClassVarNames. aSet addAll: self classVarNames. + aSet]! - ^aSet]! Item was added: + ----- Method: Class>>whichMethodsStoreInto: (in category 'testing') ----- + whichMethodsStoreInto: varName + "Answer a collection of selectors whose methods access the argument, varName, as a named class variable." + | ref | + ref := self classPool + associationAt: varName + ifAbsent: [ ^ super whichMethodsStoreInto: varName ]. + ^ Array streamContents: + [ : stream | self class methodDict keysAndValuesDo: + [ : eachSelector : eachMethod | (eachMethod writesRef: ref) ifTrue: [ stream nextPut: eachMethod ] ] ]! Item was removed: - ----- Method: ClassDescription>>chooseInstVarThenDo: (in category 'instance variables') ----- - chooseInstVarThenDo: aBlock - "Put up a menu of all the instance variables in the receiver, and when - the user chooses one, evaluate aBlock with the chosen variable as its - parameter. If the list is 6 or larger, then offer an alphabetical - formulation as an alternative. triggered by a 'show alphabetically' item - at the top of the list." - - | lines labelStream allVars index count offerAlpha | - (count := self allInstVarNames size) = 0 ifTrue: - [^ self inform: 'There are no - instance variables.']. - - allVars := OrderedCollection new. - lines := OrderedCollection new. - labelStream := WriteStream on: (String new: 200). - (offerAlpha := count > 5) - ifTrue: - [lines add: 1. - allVars add: 'show alphabetically'. - labelStream nextPutAll: allVars first; cr]. - self withAllSuperclasses reverseDo: - [:class | | vars | - vars := class instVarNames. - vars do: - [:var | - labelStream nextPutAll: var; cr. - allVars add: var]. - vars isEmpty ifFalse: [lines add: allVars size]]. - labelStream skip: -1 "cut last CR". - (lines size > 0 and: [lines last = allVars size]) ifTrue: - [lines removeLast]. "dispense with inelegant line beneath last item" - index := (UIManager default chooseFrom: (labelStream contents subStrings: {Character cr}) lines: lines - title: 'Instance variables in', self name). - index = 0 ifTrue: [^ self]. - (index = 1 and: [offerAlpha]) ifTrue: [^ self - chooseInstVarAlphabeticallyThenDo: aBlock]. - aBlock value: (allVars at: index)! Item was added: + ----- Method: ClassDescription>>chooseVarThenDo: (in category 'instance variables') ----- + chooseVarThenDo: aBlock + "Put up a menu of all the instance variables in the receiver, and when + the user chooses one, evaluate aBlock with the chosen variable as its + parameter." + | lines labelStream allVars index | + (self allInstVarNames size + self allClassVarNames size) = 0 ifTrue: [ ^ self inform: 'There are no variables.' ]. + allVars := OrderedCollection new. + lines := OrderedCollection new. + labelStream := WriteStream on: (String new: 200). + self withAllSuperclasses reverseDo: + [ : class | | vars | + vars := class instVarNames , class classVarNames. + vars do: + [ : var | labelStream + nextPutAll: var ; + cr. + allVars add: var ]. + vars isEmpty ifFalse: [ lines add: allVars size ] ]. + labelStream skip: -1. + "cut last CR" + (lines size > 0 and: [ lines last = allVars size ]) ifTrue: [ lines removeLast ]. + "dispense with inelegant line beneath last item" + index := UIManager default + chooseFrom: (labelStream contents subStrings: {Character cr}) + lines: lines + title: 'Variables in' , self name. + index = 0 ifTrue: [ ^ self ]. + aBlock value: (allVars at: index)! Item was changed: ----- Method: MethodFinder>>initialize (in category 'initialize') ----- (excessive size, no diff calculated) Item was changed: ----- Method: Month class>>readFrom: (in category 'squeak protocol') ----- readFrom: aStream | m y c | m := (ReadWriteStream with: '') reset. [(c := aStream next) isSeparator] whileFalse: [m nextPut: c]. [(c := aStream next) isSeparator] whileTrue. y := (ReadWriteStream with: '') reset. y nextPut: c. [aStream atEnd] whileFalse: [y nextPut: aStream next]. ^ self month: m contents + year: y contents asInteger - year: y contents "Month readFrom: 'July 1998' readStream"!

1 0

The Trunk: KernelTests-cmm.188.mcz
by commits＠source.squeak.org 03 May '11

03 May '11

Chris Muller uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-cmm.188.mcz ==================== Summary ==================== Name: KernelTests-cmm.188 Author: cmm Time: 2 May 2011, 6:42:39.78 pm UUID: d7daceab-6d04-4e66-872c-028a4b1c9b21 Ancestors: KernelTests-nice.187 Demonstrate bug with Month class>>readFrom: when used with February. =============== Diff against KernelTests-nice.187 =============== Item was added: + ----- Method: DateAndTimeLeapTest>>testMonthParsing (in category 'testing') ----- + testMonthParsing + self assert: + (Month readFrom: 'Feb 2011' readStream) = + (Month + month: 2 + year: 2011)!

1 0

The Trunk: Protocols-cmm.36.mcz
by commits＠source.squeak.org 03 May '11

03 May '11

Chris Muller uploaded a new version of Protocols to project The Trunk: http://source.squeak.org/trunk/Protocols-cmm.36.mcz ==================== Summary ==================== Name: Protocols-cmm.36 Author: cmm Time: 2 May 2011, 6:41:34.38 pm UUID: acac21f7-1203-4553-bbf5-e87e57159e98 Ancestors: Protocols-nice.35 - Use new streamlined variable-reference / assignment browsing. =============== Diff against Protocols-nice.35 =============== Item was changed: ----- Method: InstanceBrowser>>offerMenu (in category 'menu commands') ----- offerMenu "Offer a menu to the user, in response to the hitting of the menu button on the tool pane" | aMenu | aMenu := MenuMorph new defaultTarget: self. aMenu title: 'Messages of ', objectViewed nameForViewer. aMenu addStayUpItem. aMenu addList: #( ('vocabulary...' chooseVocabulary) ('what to show...' offerWhatToShowMenu) - ('inst var refs (here)' setLocalInstVarRefs) ('inst var defs (here)' setLocalInstVarDefs) ('class var refs (here)' setLocalClassVarRefs) - ('navigate to a sender...' navigateToASender) ('recent...' navigateToRecentMethod) ('show methods in current change set' showMethodsInCurrentChangeSet) ('show methods with initials...' showMethodsWithInitials) - "('toggle search pane' toggleSearch)" - - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' classHierarchy) ('browse method (O)' openSingleMessageBrowser) ('browse protocol (p)' browseFullProtocol) - ('fileOut' fileOutMessage) ('printOut' printOutMessage) - ('senders of... (n)' browseSendersOfMessages) ('implementors of... (m)' browseMessages) ('versions (v)' browseVersions) ('inheritance (i)' methodHierarchy) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs' browseInstVarRefs) - ('inst var defs' browseInstVarDefs) - ('class var refs' browseClassVarRefs) - ('viewer on me' viewViewee) ('inspector on me' inspectViewee) - ('more...' shiftedYellowButtonActivity)). aMenu popUpInWorld: ActiveWorld! Item was removed: - ----- Method: Lexicon>>browseClassVarRefs (in category 'new-window queries') ----- - browseClassVarRefs - "Let the search pertain to the target class regardless of selection" - - self systemNavigation browseClassVarRefs: targetClass theNonMetaClass ! Item was removed: - ----- Method: Lexicon>>browseInstVarDefs (in category 'new-window queries') ----- - browseInstVarDefs - "Let the search pertain to the target class regardless of selection" - - self systemNavigation browseInstVarDefs: targetClass! Item was removed: - ----- Method: Lexicon>>browseInstVarRefs (in category 'new-window queries') ----- - browseInstVarRefs - "Let the search pertain to the target class regardless of selection" - self systemNavigation browseInstVarRefs: targetClass! Item was added: + ----- Method: Lexicon>>browseVariableAssignments (in category 'new-window queries') ----- + browseVariableAssignments + "Let the search pertain to the target class regardless of selection." + self systemNavigation browseVariableAssignments: targetClass! Item was added: + ----- Method: Lexicon>>browseVariableReferences (in category 'new-window queries') ----- + browseVariableReferences + "Let the search pertain to the target class regardless of selection" + self systemNavigation browseVariableReferences: targetClass! Item was changed: ----- Method: Lexicon>>offerMenu (in category 'menu commands') ----- offerMenu "Offer a menu to the user, in response to the hitting of the menu button on the tool pane" | aMenu | aMenu := MenuMorph new defaultTarget: self. aMenu addTitle: 'Lexicon'. aMenu addStayUpItem. aMenu addList: #( ('vocabulary...' chooseVocabulary) ('what to show...' offerWhatToShowMenu) - ('inst var refs (here)' setLocalInstVarRefs) + ('inst var assignments (here)' setLocalInstVarDefs) - ('inst var defs (here)' setLocalInstVarDefs) ('class var refs (here)' setLocalClassVarRefs) - ('navigate to a sender...' navigateToASender) ('recent...' navigateToRecentMethod) ('show methods in current change set' showMethodsInCurrentChangeSet) ('show methods with initials...' showMethodsWithInitials) - "('toggle search pane' toggleSearch)" - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' classHierarchy) ('browse method (O)' openSingleMessageBrowser) ('browse protocol (p)' browseFullProtocol) - ('fileOut' fileOutMessage) ('printOut' printOutMessage) - ('senders of... (n)' browseSendersOfMessages) ('implementors of... (m)' browseMessages) ('versions (v)' browseVersions) ('inheritance (i)' methodHierarchy) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs' browseInstVarRefs) - ('inst var defs' browseInstVarDefs) - ('class var refs' browseClassVarRefs) - ('more...' shiftedYellowButtonActivity)). aMenu popUpInWorld: ActiveWorld! Item was changed: ----- Method: Lexicon>>selectorsDefiningInstVar (in category 'within-tool queries') ----- selectorsDefiningInstVar "Return a list of methods that define a given inst var that are in the protocol of this object" | aList | aList := OrderedCollection new. targetClass withAllSuperclassesDo: [:aClass | + (aClass whichMethodsAssign: currentQueryParameter asString) do: + [ : cm | cm selector isDoIt ifFalse: [aList add: cm selector] - (aClass whichSelectorsStoreInto: currentQueryParameter asString) do: - [:sel | sel isDoIt ifFalse: [aList add: sel] ] ]. ^ aList! Item was changed: ----- Method: Lexicon>>setLocalInstVarDefs (in category 'within-tool queries') ----- setLocalInstVarDefs "Put up a list of the instance variables in the viewed object, and when the user seletcts one, let the query results category show all the references to that instance variable." | instVarToProbe | + targetClass chooseVarThenDo: - targetClass chooseInstVarThenDo: [:aName | instVarToProbe := aName]. instVarToProbe isEmptyOrNil ifTrue: [^ self]. currentQuery := #instVarDefs. currentQueryParameter := instVarToProbe. self showQueryResultsCategory! Item was changed: ----- Method: Lexicon>>setLocalInstVarRefs (in category 'within-tool queries') ----- setLocalInstVarRefs "Put up a list of the instance variables in the viewed object, and when the user seletcts one, let the query results category show all the references to that instance variable." | instVarToProbe | + targetClass chooseVarThenDo: - targetClass chooseInstVarThenDo: [:aName | instVarToProbe := aName]. instVarToProbe isEmptyOrNil ifTrue: [^ self]. currentQuery := #instVarRefs. currentQueryParameter := instVarToProbe. self showQueryResultsCategory!

1 0

The Trunk: Tests-cmm.126.mcz
by commits＠source.squeak.org 03 May '11

03 May '11

Chris Muller uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-cmm.126.mcz ==================== Summary ==================== Name: Tests-cmm.126 Author: cmm Time: 2 May 2011, 6:39:55.068 pm UUID: 11bf0878-1ee7-4c50-b637-c31c080714b6 Ancestors: Tests-ul.125 Updated test to use new MCDirectoryRepository constructor. =============== Diff against Tests-ul.125 =============== Item was changed: ----- Method: MCDirectoryRepositoryTest>>setUp (in category 'as yet unclassified') ----- setUp + repository := MCDirectoryRepository directory: self directory! - repository := MCDirectoryRepository new directory: self directory!

1 0

The Trunk: System-cmm.433.mcz
by commits＠source.squeak.org 03 May '11

03 May '11

Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.433.mcz ==================== Summary ==================== Name: System-cmm.433 Author: cmm Time: 2 May 2011, 6:38:44.996 pm UUID: 89627de9-ab75-419e-a876-2399387987dd Ancestors: System-mtf.432 - Updates to SystemNavigation to support streamlined variable-reference / assignment browsing. =============== Diff against System-mtf.432 =============== Item was changed: ----- Method: SystemNavigation>>browseAllStoresInto:from: (in category 'browse') ----- + browseAllStoresInto: varName from: aClass - browseAllStoresInto: instVarName from: aClass "Create and schedule a Message Set browser for all the receiver's methods or any methods of a subclass/superclass that refer to the instance variable name." - "self new browseAllStoresInto: 'contents' from: Collection." - | coll | coll := OrderedCollection new. + Cursor wait showWhile: + [ aClass withAllSubAndSuperclassesDo: + [ : class | (class whichMethodsStoreInto: varName) do: + [ : eachMethod | eachMethod selector isDoIt ifFalse: [ coll add: eachMethod methodReference ] ] ] ]. - Cursor wait showWhile: [ - aClass withAllSubAndSuperclassesDo: [:class | - (class whichSelectorsStoreInto: instVarName) do: [:sel | - sel isDoIt ifFalse: [ - coll add: ( - MethodReference new - setStandardClass: class - methodSymbol: sel - ) - ] - ] - ]. - ]. ^ self + browseMessageList: coll + name: 'Stores into ' , varName + autoSelect: varName! - browseMessageList: coll - name: 'Stores into ' , instVarName - autoSelect: instVarName! Item was removed: - ----- Method: SystemNavigation>>browseClassVarRefs: (in category 'browse') ----- - browseClassVarRefs: aClass - "Put up a menu offering all class variable names; if the user chooses one, open up a message-list browser on all methods - that refer to the selected class variable" - - | lines labelStream allVars index owningClasses | - lines := OrderedCollection new. - allVars := OrderedCollection new. - owningClasses := OrderedCollection new. - labelStream := WriteStream on: (String new: 200). - aClass withAllSuperclasses reverseDo: - [:class | | vars | - vars := class classVarNames. - vars do: - [:var | - labelStream nextPutAll: var; cr. - allVars add: var. - owningClasses add: class]. - vars isEmpty ifFalse: [lines add: allVars size]]. - labelStream contents isEmpty ifTrue: [^Beeper beep]. "handle nil superclass better" - labelStream skip: -1 "cut last CR". - index := (UIManager default chooseFrom: (labelStream contents substrings) lines: lines). - index = 0 ifTrue: [^ self]. - self browseAllCallsOn: - ((owningClasses at: index) classPool associationAt: (allVars at: index))! Item was removed: - ----- Method: SystemNavigation>>browseClassVariables: (in category 'browse') ----- - browseClassVariables: aClass - aClass classPool inspectWithLabel: 'Class Variables in ' , aClass name! Item was removed: - ----- Method: SystemNavigation>>browseInstVarDefs: (in category 'browse') ----- - browseInstVarDefs: aClass - "Copied from browseInstVarRefs. Should be consolidated some day. 7/29/96 di - 7/30/96 sw: did the consolidation" - "Change to use SystemNavigation 27 March 2003 sd" - - aClass chooseInstVarThenDo: - [:aVar | self browseAllStoresInto: aVar from: aClass]! Item was removed: - ----- Method: SystemNavigation>>browseInstVarRefs: (in category 'browse') ----- - browseInstVarRefs: aClass - "1/16/96 sw: moved here from Browser so that it could be used from a variety of places. - 7/30/96 sw: call chooseInstVarThenDo: to get the inst var choice" - - aClass chooseInstVarThenDo: - [:aVar | self browseAllAccessesTo: aVar from: aClass]! Item was added: + ----- Method: SystemNavigation>>browseVariableAssignments: (in category 'browse') ----- + browseVariableAssignments: aClass + aClass chooseVarThenDo: + [ : aVar | self + browseAllStoresInto: aVar + from: aClass ]! Item was added: + ----- Method: SystemNavigation>>browseVariableReferences: (in category 'browse') ----- + browseVariableReferences: aClass + aClass chooseVarThenDo: + [ : aVar | (aClass allInstVarNames includes: aVar) + ifTrue: + [ self + browseAllAccessesTo: aVar + from: aClass ] + ifFalse: [ self browseAllCallsOn: aVar ] ]! Item was changed: ----- Method: SystemNavigation>>headingAndAutoselectForLiteral:do: (in category 'private') ----- + headingAndAutoselectForLiteral: aLiteral do: binaryBlock + "Evaluate binaryBlock with either Users of ... or Senders of ... plus the auto-select string for the given literal. aLiteral can be a Symbol, a VariableBinding or an arbitrary object." - headingAndAutoselectForLiteral: aLiteral do: binaryBlock - "Evaluate aBlock with either Users of ... or Senders of ... plus the auto-select string - for the given literal. aLiteral can be a Symbol, a VariableBinding or an arbitrary object." - | autoSelect | + ^ aLiteral isSymbol + ifTrue: + [ binaryBlock + value: 'Senders of ' , aLiteral + value: aLiteral keywords first ] - ^aLiteral isSymbol - ifTrue: [binaryBlock value: 'Senders of ', aLiteral value: aLiteral keywords first] ifFalse: + [ autoSelect := aLiteral isVariableBinding + ifTrue: [ aLiteral key ] + ifFalse: [ aLiteral printString ]. + binaryBlock + value: 'Users of ' , autoSelect + value: autoSelect ]! - [autoSelect := aLiteral isVariableBinding - ifTrue: [aLiteral key] - ifFalse: [aLiteral printString]. - binaryBlock value: 'Users of ', autoSelect value: autoSelect]!

1 0

The Trunk: Tools-cmm.347.mcz
by commits＠source.squeak.org 03 May '11

03 May '11

Chris Muller uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-cmm.347.mcz ==================== Summary ==================== Name: Tools-cmm.347 Author: cmm Time: 2 May 2011, 6:36:40.244 pm UUID: 977c180b-7c15-4200-9ceb-319d2e850364 Ancestors: Tools-fbs.346, Tools-fbs.345 - Update menu "inst var defs" to "assignments..." and "inst var refs" to "references...". Each option now includes a selection of the available class-variables, enabling "class var refs" to be removed. Each option also has an appropriate hot-key assignment. - Removed "class vars" because one could simply explore the class' classPool. =============== Diff against Tools-fbs.346 =============== Item was changed: ----- Method: Browser>>classListMenu:shifted: (in category 'class functions') ----- classListMenu: aMenu shifted: shifted "Set up the menu to apply to the receiver's class list, honoring the #shifted boolean" self menuHook: aMenu named: #classListMenu shifted: shifted. Preferences useOnlyServicesInMenu ifTrue:[^aMenu]. shifted ifTrue:[^ self shiftedClassListMenu: aMenu]. aMenu addList: #( - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' spawnHierarchy) ('browse protocol (p)' browseFullProtocol) - ('printOut' printOutClass) ('fileOut' fileOutClass) - ('show hierarchy' hierarchy) ('show definition' editClass) ('show comment' editComment) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs...' browseInstVarRefs) - ('inst var defs...' browseInstVarDefs) - - - ('class var refs...' browseClassVarRefs) - ('class vars' browseClassVariables) ('class refs (N)' browseClassRefs) - ('rename class ...' renameClass) ('copy class' copyClass) ('remove class (x)' removeClass) - ('find method...' findMethod) - ('more...' offerShiftedClassListMenu)). ^ aMenu ! Item was changed: ----- Method: Browser>>messageListMenu:shifted: (in category 'message functions') ----- messageListMenu: aMenu shifted: shifted "Answer the message-list menu" self menuHook: aMenu named: #messageListMenu shifted: shifted. Preferences useOnlyServicesInMenu ifTrue:[^aMenu]. shifted ifTrue: [^ self shiftedMessageListMenu: aMenu]. aMenu addList: #( ('what to show...' offerWhatToShowMenu) ('toggle break on entry' toggleBreakOnEntry) - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' classHierarchy) ('browse method (O)' openSingleMessageBrowser) ('browse protocol (p)' browseFullProtocol) - ('fileOut' fileOutMessage) ('printOut' printOutMessage) ('copy selector (c)' copySelector) ('copy reference' copyReference) - ('senders of... (n)' browseSendersOfMessages) ('implementors of... (m)' browseMessages) ('inheritance (i)' methodHierarchy) ('versions (v)' browseVersions) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs...' browseInstVarRefs) - ('inst var defs...' browseInstVarDefs) - ('class var refs...' browseClassVarRefs) - ('class variables' browseClassVariables) ('class refs (N)' browseClassRefs) - ('remove method (x)' removeMessage) ('explore method' exploreMethod) ('inspect method' inspectMethod) - ('more...' shiftedYellowButtonActivity)). ^ aMenu! Item was changed: ----- Method: Browser>>reformulateList (in category 'message list') ----- reformulateList "If the receiver has a way of reformulating its message list, here is a chance for it to do so" super reformulateList. (self messageList includes: self selectedMessageName) + ifFalse: [ self messageList + ifEmpty: [ self selectMessageNamed: nil ] + ifNotEmpty: [ self selectMessageNamed: self lastMessageName ]].! - ifFalse: [ self selectMessageNamed: self lastMessageName ].! Item was changed: ----- Method: ChangeSorter>>classListMenu:shifted: (in category 'class list') ----- classListMenu: aMenu shifted: shifted "Fill aMenu with items appropriate for the class list" aMenu title: 'class list'. aMenu addStayUpItemSpecial. (parent notNil and: [shifted not]) ifTrue: [aMenu addList: #( "These two only apply to dual change sorters" ('copy class chgs to other side' copyClassToOther) ('move class chgs to other side' moveClassToOther))]. aMenu addList: (shifted ifFalse: [#( - ('delete class from change set (d)' forgetClass) ('remove class from system (x)' removeClass) - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' spawnHierarchy) ('browse protocol (p)' browseFullProtocol) - ('printOut' printOutClass) ('fileOut' fileOutClass) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs...' browseInstVarRefs) - ('inst var defs...' browseInstVarDefs) - ('class var refs...' browseClassVarRefs) - ('class vars' browseClassVariables) ('class refs (N)' browseClassRefs) - ('more...' offerShiftedClassListMenu))] ifTrue: [#( - ('unsent methods' browseUnusedMethods) ('unreferenced inst vars' showUnreferencedInstVars) ('unreferenced class vars' showUnreferencedClassVars) - ('sample instance' makeSampleInstance) ('inspect instances' inspectInstances) ('inspect subinstances' inspectSubInstances) - ('more...' offerUnshiftedClassListMenu ))]). ^ aMenu! Item was changed: ----- Method: CodeHolder>>abbreviatedWordingFor: (in category 'commands') ----- abbreviatedWordingFor: aButtonSelector + "Answer the abbreviated form of wording, from a static table. Answer nil if there is no entry -- in which case the long form will be used on the corresponding browser button." - "Answer the abbreviated form of wording, from a static table which you're welcome to edit. Answer nil if there is no entry -- in which case the long firm will be used on the corresponding browser button." #( (browseMethodFull 'browse') (browseSendersOfMessages 'senders') (browseMessages 'impl') (browseVersions 'vers') (methodHierarchy 'inher') (classHierarchy 'hier') + (browseVariableReferences 'refs') - (browseInstVarRefs 'iVar') - (browseClassVarRefs 'cVar') (offerMenu 'menu')) do: [:pair | pair first == aButtonSelector ifTrue: [^ pair second]]. ^ nil! Item was changed: ----- Method: CodeHolder>>messageListKey:from: (in category 'message list menu') ----- messageListKey: aChar from: view "Respond to a Command key. I am a model with a code pane, and I also have a listView that has a list of methods. The view knows how to get the list and selection." | sel class | aChar == $D ifTrue: [^ self toggleDiffing]. sel := self selectedMessageName. aChar == $m ifTrue: "These next two put up a type in if no message selected" [^ self useSelector: sel orGetSelectorAndSendQuery: #browseAllImplementorsOf: to: self ]. aChar == $n ifTrue: [^ self useSelector: sel orGetSelectorAndSendQuery: #browseAllCallsOn: to: self ]. "The following require a class selection" (class := self selectedClassOrMetaClass) ifNil: [^ self arrowKey: aChar from: view]. aChar == $b ifTrue: [^ Browser fullOnClass: class selector: sel]. aChar == $N ifTrue: [^ self browseClassRefs]. aChar == $i ifTrue: [^ self methodHierarchy]. aChar == $h ifTrue: [^ self classHierarchy]. aChar == $p ifTrue: [^ self browseFullProtocol]. + aChar == $r ifTrue: [^ self browseVariableReferences]. + aChar == $a ifTrue: [^ self browseVariableAssignments]. + "The following require a method selection" sel ifNotNil: [aChar == $o ifTrue: [^ self fileOutMessage]. aChar == $c ifTrue: [^ self copySelector]. aChar == $v ifTrue: [^ self browseVersions]. aChar == $O ifTrue: [^ self openSingleMessageBrowser]. aChar == $x ifTrue: [^ self removeMessage]. aChar == $d ifTrue: [^ self removeMessageFromBrowser]. (aChar == $C and: [self canShowMultipleMessageCategories]) ifTrue: [^ self showHomeCategory]]. ^ self arrowKey: aChar from: view! Item was changed: ----- Method: CodeHolder>>optionalButtonPairs (in category 'controls') ----- optionalButtonPairs "Answer a tuple (formerly pairs) defining buttons, in the format: button label selector to send help message" | aList | aList := #( ('browse' browseMethodFull 'view this method in a browser') ('senders' browseSendersOfMessages 'browse senders of...') ('implementors' browseMessages 'browse implementors of...') ('versions' browseVersions 'browse versions')), (Preferences decorateBrowserButtons ifTrue: [{#('inheritance' methodHierarchy 'browse method inheritance green: sends to super tan: has override(s) mauve: both of the above pink: is an override but doesn''t call super pinkish tan: has override(s), also is an override but doesn''t call super' )}] ifFalse: [{#('inheritance' methodHierarchy 'browse method inheritance')}]), #( ('hierarchy' classHierarchy 'browse class hierarchy') + ('vars' browseVariableReferences 'references...')). - ('inst vars' browseInstVarRefs 'inst var refs...') - ('class vars' browseClassVarRefs 'class var refs...')). ^ aList! Item was added: + ----- Method: CodeHolder>>receiverClass (in category 'toolbuilder') ----- + receiverClass + ^ self selectedClassOrMetaClass ! Item was added: + ----- Method: Debugger>>classHierarchy (in category 'toolbuilder') ----- + classHierarchy + "Create and schedule a class list browser on the receiver's hierarchy." + (self selectedMessageName = #doesNotUnderstand: and: [ self selectedClassOrMetaClass = Object ]) + ifTrue: + [ self systemNavigation + spawnHierarchyForClass: self receiverClass + selector: self selectedMessageName ] + ifFalse: [ super classHierarchy ]! Item was changed: ----- Method: Debugger>>contextStackMenu:shifted: (in category 'context stack menu') ----- contextStackMenu: aMenu shifted: shifted "Set up the menu appropriately for the context-stack-list, either shifted or unshifted as per the parameter provided" ^ shifted ifFalse:[ aMenu addList: { {'fullStack (f)'. #fullStack}. {'restart (r)'. #restart}. {'proceed (p)'. #proceed}. {'step (t)'. #doStep}. {'step through (T)'. #stepIntoBlock}. {'send (e)'. #send}. {'where (w)'. #where}. {'peel to first like this'. #peelToFirst}. #-. {'return entered value'. #returnValue}. #-. {'toggle break on entry'. #toggleBreakOnEntry}. {'senders of... (n)'. #browseSendersOfMessages}. {'implementors of... (m)'. #browseMessages}. {'inheritance (i)'. #methodHierarchy}. #-. {'versions (v)'. #browseVersions}. - {'inst var refs...'. #browseInstVarRefs}. #-. + {'references... (r)'. #browseVariableReferences}. + {'assignments... (a)'. #browseVariableAssignments}. - {'inst var defs...'. #browseInstVarDefs}. - {'class var refs...'. #browseClassVarRefs}. - {'class variables'. #browseClassVariables}. #-. {'class refs (N)'. #browseClassRefs}. {'browse full (b)'. #browseMethodFull}. {'file out '. #fileOutMessage}. #-. {'mail out bug report'. #mailOutBugReport}. {'more...'. #shiftedYellowButtonActivity}. }. ] ifTrue: [ aMenu addList: { {'browse class hierarchy'. #classHierarchy}. {'browse class'. #browseClass}. {'browse method (O)'. #openSingleMessageBrowser}. {'implementors of sent messages'. #browseAllMessages}. {'change sets with this method'. #findMethodInChangeSets}. #-. {'inspect instances'. #inspectInstances}. {'inspect subinstances'. #inspectSubInstances}. #-. {'revert to previous version'. #revertToPreviousVersion}. {'remove from current change set'. #removeFromCurrentChanges}. {'revert & remove from changes'. #revertAndForget}. #-. {'more...'. #unshiftedYellowButtonActivity}. } ].! Item was added: + ----- Method: Debugger>>receiverClass (in category 'toolbuilder') ----- + receiverClass + ^ self selectedContext receiver class! Item was removed: - ----- Method: Inspector>>classVarRefs (in category 'menu commands') ----- - classVarRefs - "Request a browser of methods that store into a chosen instance variable" - - | aClass | - (aClass := self classOfSelection) ifNotNil: - [self systemNavigation browseClassVarRefs: aClass]. - ! Item was changed: ----- Method: Inspector>>fieldListMenu: (in category 'menu commands') ----- fieldListMenu: aMenu "Arm the supplied menu with items for the field-list of the receiver" aMenu addStayUpItemSpecial. aMenu addList: #( ('inspect (i)' inspectSelection) ('explore (I)' exploreSelection)). self addCollectionItemsTo: aMenu. aMenu addList: #( - ('method refs to this inst var' referencesToSelection) ('methods storing into this inst var' defsOfSelection) ('objects pointing to this value' objectReferencesToSelection) ('chase pointers' chasePointers) ('explore pointers' explorePointers) - ('browse full (b)' browseMethodFull) ('browse class' browseClass) ('browse hierarchy (h)' classHierarchy) ('browse protocol (p)' browseFullProtocol) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs...' browseInstVarRefs) - ('inst var defs...' browseInstVarDefs) - ('class var refs...' classVarRefs) - ('class variables' browseClassVariables) ('class refs (N)' browseClassRefs) - ('copy name (c)' copyName) ('basic inspect' inspectBasic)). Smalltalk isMorphic ifTrue: [aMenu addList: #( - ('tile for this value (t)' tearOffTile) ('viewer for this value (v)' viewerForValue))]. ^ aMenu " - ('alias for this value' aliasForValue) ('watcher for this slot' watcherForSlot)" ! Item was changed: ----- Method: RecentMessageSet>>messageListMenu:shifted: (in category 'message functions') ----- messageListMenu: aMenu shifted: shifted "Answer the message-list menu" shifted ifTrue: [^ self shiftedMessageListMenu: aMenu]. aMenu addList:#( ('what to show...' offerWhatToShowMenu) - ('browse full (b)' browseMethodFull) ('browse hierarchy (h)' classHierarchy) ('browse method (O)' openSingleMessageBrowser) ('browse protocol (p)' browseFullProtocol) - ('fileOut (o)' fileOutMessage) ('printOut' printOutMessage) ('copy selector (c)' copySelector) ('copy reference' copyReference) - ('senders of... (n)' browseSendersOfMessages) ('implementors of... (m)' browseMessages) ('inheritance (i)' methodHierarchy) ('versions (v)' browseVersions) - + ('references... (r)' browseVariableReferences) + ('assignments... (a)' browseVariableAssignments) - ('inst var refs...' browseInstVarRefs) - ('inst var defs...' browseInstVarDefs) - ('class var refs...' browseClassVarRefs) - ('class variables' browseClassVariables) ('class refs (N)' browseClassRefs) - ('remove method (x)' removeMessage) ('remove from RecentSubmissions' removeFromRecentSubmissions) - ('more...' shiftedYellowButtonActivity)). ^ aMenu! Item was removed: - ----- Method: StringHolder>>browseClassVarRefs (in category '*Tools-traits') ----- - browseClassVarRefs - "1/17/96 sw: devolve responsibility to the class, so that the code that does the real work can be shared" - - | cls | - cls := self selectedClass. - (cls notNil and: [cls isTrait not]) - ifTrue: [self systemNavigation browseClassVarRefs: cls]! Item was removed: - ----- Method: StringHolder>>browseClassVariables (in category '*Tools-traits') ----- - browseClassVariables - "Browse the class variables of the selected class. 2/5/96 sw" - | cls | - cls := self selectedClass. - (cls notNil and: [cls isTrait not]) - ifTrue: [self systemNavigation browseClassVariables: cls] - ! Item was removed: - ----- Method: StringHolder>>browseInstVarDefs (in category '*Tools-traits') ----- - browseInstVarDefs - - | cls | - cls := self selectedClassOrMetaClass. - (cls notNil and: [cls isTrait not]) - ifTrue: [self systemNavigation browseInstVarDefs: cls]! Item was removed: - ----- Method: StringHolder>>browseInstVarRefs (in category '*Tools-traits') ----- - browseInstVarRefs - "1/26/96 sw: real work moved to class, so it can be shared" - | cls | - cls := self selectedClassOrMetaClass. - (cls notNil and: [cls isTrait not]) - ifTrue: [self systemNavigation browseInstVarRefs: cls]! Item was added: + ----- Method: StringHolder>>browseVariableAssignments (in category '*Tools-traits') ----- + browseVariableAssignments + | cls | + cls := self selectedClassOrMetaClass. + (cls notNil and: [ cls isTrait not ]) ifTrue: [ self systemNavigation browseVariableAssignments: cls ]! Item was added: + ----- Method: StringHolder>>browseVariableReferences (in category '*Tools-traits') ----- + browseVariableReferences + | cls | + cls := self selectedClassOrMetaClass. + (cls notNil and: [cls isTrait not]) + ifTrue: [self systemNavigation browseVariableReferences: cls]! Item was changed: ----- Method: StringHolder>>classListKey:from: (in category '*Tools') ----- classListKey: aChar from: view "Respond to a Command key. I am a model with a list of classes and a code pane, and I also have a listView that has a list of methods. The view knows how to get the list and selection." aChar == $f ifTrue: [^ self findMethod]. + aChar == $r ifTrue: [^ self browseVariableReferences]. + aChar == $a ifTrue: [^ self browseVariableAssignments]. - aChar == $r ifTrue: [^ self browseInstVarRefs]. - aChar == $d ifTrue: [^ self browseInstVarDefs]. aChar == $h ifTrue: [^ self spawnHierarchy]. aChar == $x ifTrue: [^ self removeClass]. ^ self messageListKey: aChar from: view!

1 0

Sanity check - changeTextFont
by Gary Dunn 03 May '11

03 May '11

Looking into why yellowButtonMenu set font does not work while CTRL-K does. Have gotten as far as discovering that the value of paragraph var is wrong when changeTextFont is called from yellowButtonMenu. Appears to be old, deleted text, some sort of undo buffer gone bad. Just discovered that changeTextFont is being called from two different directions. For the yellowButtonMenu -- the broken one -- it comes via ScrollableField (yes, this is a scrolling text morph). For CTRL-K it is called from SmalltalkEditor. I'm going for a run. I won't get back to this for a couple hours. I would appreciate any insights, suggestions, warnings or wave-offs anyone cares to make during that time. The code seems terribly convoluted. Is it just me? -- Gary Dunn Honolulu

1 0

Number>>day buggy? Try: 0.5 day
by Enrico Spinielli 02 May '11

02 May '11

Hi, I evaluated the following and got surprised: 0.5 days. "prints: 0:12:00:00; ok for me" 0.5 day. "prints: 1:00:00:00; _not ok_ IMHO" (1/2) day. "prints: 1:00:00:00;_not ok_ IMHO" the implementation says: Number>>day ^ self sign days Number>>days ^ Duration days: self but should probably be: Number>>day ^ self days Similarly for Number>>hour Number>>milliSecond Number>>minute Number>>nanoSecond Number>>second Number>>week Any thought about this? -- Enrico Spinielli "Do Androids dream of electric sheep?"— Philip K. Dick "Hear and forget; see and remember;do and understand."—Mitchel Resnick

2 1

The Trunk: Tools-fbs.346.mcz
by commits＠source.squeak.org 02 May '11

02 May '11

Levente Uzonyi uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-fbs.346.mcz ==================== Summary ==================== Name: Tools-fbs.346 Author: fbs Time: 1 May 2011, 9:06:39.414 am UUID: ef81c913-2138-874f-aa5a-8d8182d32298 Ancestors: Tools-cmm.345 Maintain the currently selected message category and method when resorting the message categories (http://bugs.squeak.org/view.php?id=7626). =============== Diff against Tools-cmm.345 =============== Item was changed: ----- Method: Browser>>alphabetizeMessageCategories (in category 'message category functions') ----- alphabetizeMessageCategories + | oldMessageCategory oldMethod | + oldMessageCategory := selectedMessageCategoryName. + oldMethod := selectedMessageName. self hasClassSelected ifFalse: [^ false]. self okToChange ifFalse: [^ false]. self classOrMetaClassOrganizer sortCategories. self clearUserEditFlag. self editClass. self selectClassNamed: selectedClassName. + self selectMessageCategoryNamed: oldMessageCategory. + self selectMessageNamed: oldMethod. ^ true!

1 0

The Trunk: Tools-fbs.345.mcz
by commits＠source.squeak.org 02 May '11

02 May '11

Levente Uzonyi uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-fbs.345.mcz ==================== Summary ==================== Name: Tools-fbs.345 Author: fbs Time: 26 April 2011, 8:44:19.26 am UUID: 52e2c842-2c27-0247-8b93-05056b5ab133 Ancestors: Tools-fbs.344 Levente Uzonyi found that deleting the last message in a MessageSet raised an error. This fixes the error by checking the list of messages: if there are no messages in the Browser (or subclass) instance, then explicitly select "no method selected". =============== Diff against Tools-fbs.344 =============== Item was changed: ----- Method: Browser>>reformulateList (in category 'message list') ----- reformulateList "If the receiver has a way of reformulating its message list, here is a chance for it to do so" super reformulateList. (self messageList includes: self selectedMessageName) + ifFalse: [ self messageList + ifEmpty: [ self selectMessageNamed: nil ] + ifNotEmpty: [ self selectMessageNamed: self lastMessageName ]].! - ifFalse: [ self selectMessageNamed: self lastMessageName ].!

1 0

Jump to page: