Squeak-dev September 2009

squeak-dev@lists.squeakfoundation.org

119 participants
370 discussions

The Trunk: Morphic-ml.194.mcz
by commits＠source.squeak.org 27 Sep '09

27 Sep '09

Andreas Raab uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ml.194.mcz ==================== Summary ==================== Name: Morphic-ml.194 Author: ml Time: 26 September 2009, 4:04:53 am UUID: d462d0e2-95f2-498d-83bb-5cb571578d52 Ancestors: Morphic-ml.193 Enhancements to ProportionalSplitterMorph behaviour. The splitters in tool builder windows now determine the range of movement by looking at the minimum extent of adjecent morphs. For deterministic results the ScrollPane minExtent assumes that eventually both scrollbars will be displayed. Fixed LayoutFrame>>minExtentFrom: to calculate min extent based on the fraction occupied by the frame. =============== Diff against Morphic-nice.191 =============== Item was changed: ----- Method: LayoutFrame>>minExtentFrom: (in category 'layout') ----- minExtentFrom: minExtent "Return the minimal extent the given bounds can be represented in" + | widthFraction heightFraction width height left right top bottom | + left := leftFraction ifNil: [0.0]. + right := rightFraction ifNil: [1.0]. + widthFraction := 1.0 / (right - left). + top := topFraction ifNil: [0.0]. + bottom := bottomFraction ifNil: [1.0]. + heightFraction := 1.0 / (bottom - top). - | widthFraction heightFraction width height | - widthFraction := 1.0. - leftFraction ifNotNil:[widthFraction := widthFraction + leftFraction]. - rightFraction ifNotNil:[widthFraction := widthFraction + rightFraction]. - heightFraction := 1.0. - topFraction ifNotNil:[heightFraction := heightFraction + topFraction]. - bottomFraction ifNotNil:[heightFraction := heightFraction + bottomFraction]. width := minExtent x * widthFraction. height := minExtent y * heightFraction. leftOffset ifNotNil:[width := width + leftOffset]. rightOffset ifNotNil:[width := width + rightOffset]. topOffset ifNotNil:[height := height + topOffset]. bottomOffset ifNotNil:[height := height + bottomOffset]. ^width truncated @ height truncated! Item was added: + ----- Method: ScrollPane>>minExtent (in category 'geometry') ----- + minExtent + "Answer the calculated minimum size of the receiver." + + ^ super minExtent max: self minScrollbarExtent! Item was changed: ----- Method: ProportionalSplitterMorph>>bottomBoundary (in category 'as yet unclassified') ----- bottomBoundary + "Answert the bottommost x position the receiver could be moved." + | splitter morphs | + splitter := self splitterBelow. + morphs := self commonNeighbours: rightOrBottom with: splitter. + ^ (splitter + ifNil: [self containingWindow panelRect bottom] + ifNotNil: [splitter top]) + - (self minimumHeightOf: morphs)! - ^ (self splitterBelow ifNil: [self containingWindow panelRect bottom] ifNotNil: [self splitterBelow top]) - 75! Item was added: + ----- Method: ProportionalSplitterMorph>>commonNeighbours:with: (in category 'as yet unclassified') ----- + commonNeighbours: morphs with: aProportionalSplitterMorphOrNil + "Answer the subset of morphs which is also confined by aProportionalSplitterMorphOrNil." + + ^ aProportionalSplitterMorphOrNil isNil + ifTrue: [morphs] + ifFalse: [morphs select: [ :which | + aProportionalSplitterMorphOrNil bordersOn: which]]! Item was added: + ----- Method: ProportionalSplitterMorph>>minimumWidthOf: (in category 'as yet unclassified') ----- + minimumWidthOf: aCollection + "Answer the minimum width needed to display any of the morphs in aCollection." + + ^ aCollection inject: 0 into: [ :width :morph | + morph minExtent x max: width]! Item was changed: ----- Method: ProportionalSplitterMorph>>leftBoundary (in category 'as yet unclassified') ----- leftBoundary + "Answer the leftmost y position the receiver could be moved." + | splitter morphs | + splitter := self splitterLeft. + morphs := self commonNeighbours: leftOrTop with: splitter. + ^ (splitter + ifNil: [self containingWindow panelRect left] + ifNotNil: [splitter right]) + + (self minimumWidthOf: morphs)! - ^ (self splitterLeft ifNil: [self containingWindow panelRect left] ifNotNil: [self splitterLeft right]) + 50! Item was added: + ----- Method: ScrollBar>>minExtent (in category 'geometry') ----- + minExtent + "The minimum extent is that of 2 or 3 buttons in a row or column, + the 'up' and 'down' button and optionally the 'menu' button." + + | btns cnt | + btns := 2. + menuButton ifNotNil: [ + btns := btns + 1]. + cnt := 1@btns. "assume vertical layout" + self bounds isWide + ifTrue: [cnt := cnt transposed]. + ^ upButton minExtent * cnt! Item was changed: SystemOrganization addCategory: #'Morphic-Balloon'! SystemOrganization addCategory: #'Morphic-Basic'! SystemOrganization addCategory: #'Morphic-Basic-NewCurve'! SystemOrganization addCategory: #'Morphic-Borders'! SystemOrganization addCategory: #'Morphic-Collections-Arrayed'! SystemOrganization addCategory: #'Morphic-Components'! SystemOrganization addCategory: #'Morphic-Demo'! SystemOrganization addCategory: #'Morphic-Events'! SystemOrganization addCategory: #'Morphic-Explorer'! SystemOrganization addCategory: #'Morphic-FileList'! SystemOrganization addCategory: #'Morphic-Kernel'! SystemOrganization addCategory: #'Morphic-Layouts'! SystemOrganization addCategory: #'Morphic-Menus'! + SystemOrganization addCategory: #'Morphic-Models'! SystemOrganization addCategory: #'Morphic-Pluggable Widgets'! SystemOrganization addCategory: #'Morphic-Refactoring Candidates'! SystemOrganization addCategory: #'Morphic-Scripting'! SystemOrganization addCategory: #'Morphic-Support'! SystemOrganization addCategory: #'Morphic-Text Support'! SystemOrganization addCategory: #'Morphic-TrueType'! SystemOrganization addCategory: #'Morphic-Widgets'! SystemOrganization addCategory: #'Morphic-Windows'! SystemOrganization addCategory: #'Morphic-Worlds'! Item was changed: ----- Method: ProportionalSplitterMorph>>rightBoundary (in category 'as yet unclassified') ----- rightBoundary + "Answer the rightmost x position the receiver could be moved to." + | splitter morphs | + splitter := self splitterRight. + morphs := self commonNeighbours: rightOrBottom with: splitter. + ^ (splitter + ifNil: [self containingWindow panelRect right] + ifNotNil: [splitter left]) + - (self minimumWidthOf: morphs)! - ^ (self splitterRight ifNil: [self containingWindow panelRect right] ifNotNil: [self splitterRight left]) - 50! Item was added: + MorphicModel subclass: #MorphicModel2 + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Morphic-Models'! Item was added: + MorphicModel subclass: #MorphicModel1 + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'Morphic-Models'! Item was added: + ----- Method: ProportionalSplitterMorph>>bordersOn: (in category 'as yet unclassified') ----- + bordersOn: aMorph + "Answer true if the aMorph is one of my neighbours." + + ^ (leftOrTop includes: aMorph) or: [rightOrBottom includes: aMorph]! Item was added: + ----- Method: ProportionalSplitterMorph>>minimumHeightOf: (in category 'as yet unclassified') ----- + minimumHeightOf: aCollection + "Answer the minimum height needed to display any of the morphs in aCollection." + + ^ aCollection inject: 0 into: [ :height :morph | + morph minExtent y max: height]! Item was changed: ----- Method: ProportionalSplitterMorph>>topBoundary (in category 'as yet unclassified') ----- topBoundary + "Answer the topmost x position the receiver could be moved to." + | splitter morphs | + splitter := self splitterAbove. + morphs := self commonNeighbours: leftOrTop with: splitter. + ^ (splitter + ifNil: [self containingWindow panelRect top] + ifNotNil: [splitter bottom]) + + (self minimumHeightOf: morphs)! - ^ (self splitterAbove ifNil: [self containingWindow panelRect top] ifNotNil: [self splitterAbove bottom]) + 75! Item was added: + ----- Method: ScrollPane>>minScrollbarExtent (in category 'geometry') ----- + minScrollbarExtent + "Answer the minimum extent occupied by the receiver.. + It is assumed the if the receiver is sized to its minimum both scrollbars will be used (and visible). + This makes the behaviour also more predictable." + + ^ scrollBar minExtent + hScrollBar minExtent!

1 0

find in pane of TabbedPalette (BookMorph)
by Ralph Boland 27 Sep '09

27 Sep '09

The GUI for SmaCC is a TabbedPalette in which 3 of its four pages are editable (the scanner definition page, the grammar page, and the test page). I want to be able to use editing features on these 3 pages such as find/replace. But find doesn't work because when invoked (when find is invoked) and the method TextMorphEditor>>againOrSame: boolean is invoked (see method code below) the line: (bk := morph ownerThatIsA: BookMorph) ifNotNil: sets bk to a TabbedPalette object. (If bk is set to nil the the find operation is invoked and works). This results in the line: [bk findText: keys. being invoked. The first line of findText: is: allText := self valueOfProperty: #allText ifAbsent: [#()]. This sets allText to #() which turn prevents any search from being carried out. :-( TextMorphEditor>>againOrSame: bool | bk keys | (bk := morph ownerThatIsA: BookMorph) ifNotNil: [(keys := bk valueOfProperty: #tempSearchKey ifAbsent: [nil]) ifNil: ["Cmd-f" keys := bk valueOfProperty: #searchKey ifAbsent: [nil] "Cmd-g"] ifNotNil: [bk removeProperty: #tempSearchKey]. keys ifNotNil: [keys notEmpty ifTrue: [bk findText: keys. ^(morph respondsTo: #editView) ifTrue: [morph editView selectionInterval: self selectionInterval]]]]. super againOrSame: bool. (morph respondsTo: #editView) ifTrue: [morph editView selectionInterval: self selectionInterval] Now my question is: What is the best way to modify code so that find does what I want it to do (apply find to the text in the text morph containing the cursor)? My best solution so far is to subclass TextMorphEditor and use it so that a version of againOrSame: is invoked that does not set bk (and avoids the use of super). I could instead subclass TabbedPalette and use it to deny that it is a kind of BookMorph but that is very ugly. I don't understand in any case why findText: is being invoked for TabbedPalette in the first place. Isn't what I am trying to do what most developers expect to happen? That is: Why does the code as it exists make sense? Regards, Ralph Boland -- Quantum Theory cannot save us from the tyranny of a deterministic universe. But it does give God something to do.

1 0

Dependency graphs
by Ronald Spengler 26 Sep '09

26 Sep '09

I know I've seen this question asked before, so I must apologize, but what's the best way to get a dependency graph in Squeak? -- Ron

1 0

LGPL considered crippling license :)
by Igor Stasenko 26 Sep '09

26 Sep '09

I haven't visited the Orge site long ago, i found an interesting news, that they switching license to MIT! The motivation & conclusions why they decided to switch are very interesting: --- citation --- Won’t this mean people can ‘rip off’ OGRE in proprietary software? The LGPL already allowed OGRE to be used in proprietary software, and this is something we’ve always encouraged. The main difference between the LGPL and the MIT License is that there is no requirement to release modified source code; only to include our copyright and the MIT license text in the final product. While not requiring modified source to be released might initially seem like giving up an important motivator to contribute code back to the community, we’ve noticed something in recent years: 99% of useful code contributions come from people who are motivated to participate in the project regardless of what the license tells them they have to do. It’s our experience that a certain percentage of the user community will always participate and contribute back, and therefore encouraging adoption via simpler licensing is likely to result in more contributions overall than coersion via complex and restrictive licensing does. In addition, people who are internally motivated to participate tend to provide much higher quality and more usable contributions than those who only do it because they are forced to. --- citation --- you can read the full article here: http://www.ogre3d.org/2009/09/15/ogre-will-switch-to-the-mit-license-from-1… P.S. i found it a very good sign, that more and more open-source communities gradually moving towards more permissive license, as MIT is. -- Best regards, Igor Stasenko AKA sig.

2 1

Squeak Etoys interface with Arduino (first version available)
by Ricardo Moran 26 Sep '09

26 Sep '09

We're proud to announce the first public version of the Squeak Etoys interface with Arduino. You can download it from here: http://tecnodacta.com.ar/gira/Arduino.3.rar It works in Windows and Linux (you will need to make a symlink in Linux to make it work with Squeak though, see README.txt for more information about the installation and usage). I must warn you it's not really finished and it still contains a lot of bugs I haven't been able to fix. The one that I find most annoying occurs when you first connect the board (in Linux it happens every time, actually). If you leave a transcript open, a few seconds after you click "connect", you'll see the following error (which I really don't know how to handle so I just copied it to the Transcript): a Firmata(xxxx): Error: subscript is out of bounds: 34 After that, the input pins no longer work and you need to "reactivate" them by reseting the slot "is reading digital pins". Once you've done that, it works ok. Anyway, thanks for the interest you've shown in this project, I hope you'll find it useful. Any comments, critics, bug fixes, are greatly appreciated. Cheers.

3 4

saving debugger
by Ralph Boland 26 Sep '09

26 Sep '09

I am developing a parser generator tool in Squeak (It should eventually replace SmaCC among others). My method for dealing with parsing errors is the same as for SmaCC. That is an error is generated and caught and then an error message is inserted into the text being parsed at the point of the error. This works but is not entirely satisfactory especially when debugging grammars; messages like "unexpected token -->" at the point of error don't tell you much when you have a problem with your grammar or computer program. Better in such situations is to perform some other action such as simply bringing up the debugger at the point of the error or starting up some utility to help explain the problem. I wish to be able to do both but I also want the error message inserted into the program text as SmaCC does now. So what I want to happen is have my parser generator tool generate the error message as SmaCC does. If at this point the programmer needs more help he makes one of two selections from a menu: 1) Start up my bug finding utility. 2) Bring up the Smalltalk debugger as would happen if the error signal had not been caught. My question now is how do I do 2). In essence I need to be able to catch the error signal and then reissue it under user control (if requested) so that the debugger is brought up. I expect that the solution here is complicated but the more advice I can be given the better. It seems to me that I need to do some kind of process fork (copy) in order to have two identical processes. This sounds expensive (and I don't know much about processes/forks) given that the user may not choose to bring up the debugger so the fork may not have been necessary. Thus if a fork is needed I want to be able to avoid generating it until it is known that it is actually required (if this is possible). The solution will have relevance to 1) as well since if the user selects 1) It will be necesary to know where the bug occurred. I don't yet know how I will extract this information but it may involve analyzing the call stack. I appreciate that what I am trying to do is probably difficult and am going to have to do most of the work in solving it but the more pointers I get the less time I will spend on poor solutions. At least this is the kind of problem that can be solved in Smalltalk. Eventually I intend to port (parts of) my parser generator tool to other languages such as Java and C. Making user selections 1) and 2) work in other languages is going to be difficult. Thanks in advance for any and all pointers. Ralph Boland -- Quantum Theory cannot save us from the tyranny of a deterministic universe. But it does give God something to do.

1 0

The Trunk: KernelTests-nice.96.mcz
by commits＠source.squeak.org 26 Sep '09

26 Sep '09

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.96.mcz ==================== Summary ==================== Name: KernelTests-nice.96 Author: nice Time: 25 September 2009, 10:51:15 am UUID: b5940d3a-85f7-3f46-9fd1-5c1a4fb86206 Ancestors: KernelTests-ar.95 Tests for nan comparison from http://bugs.squeak.org/view.php?id=6719 =============== Diff against KernelTests-ar.95 =============== Item was added: + ----- Method: FloatTest>>testNaNCompare (in category 'NaN behavior') ----- + testNaNCompare + "IEEE 754 states that NaN cannot be ordered. + As a consequence, every arithmetic comparison involving a NaN SHOULD return false. + Except the is different test (~=). + This test does verify this rule" + + | compareSelectors theNaN anotherNaN comparand brokenMethods warningMessage | + compareSelectors := #(#< #<= #> #>= #=). + theNaN := Float nan. + anotherNaN := Float infinity - Float infinity. + comparand := {1. 2.3. Float infinity. 2/3. 1.25s2. 2 raisedTo: 50}. + comparand := comparand , (comparand collect: [:e | e negated]). + comparand := comparand , {theNaN. anotherNaN}. + + "do a first pass to collect all broken methods" + brokenMethods := Set new. + comparand do: [:comp | + compareSelectors do: [:op | + (theNaN perform: op with: comp) ifTrue: [brokenMethods add: (theNaN class lookupSelector: op)]. + (comp perform: op with: theNaN) ifTrue: [brokenMethods add: (comp class lookupSelector: op)]]. + (theNaN ~= comp) ifFalse: [brokenMethods add: (theNaN class lookupSelector: #~=)]. + (comp ~= theNaN) ifFalse: [brokenMethods add: (comp class lookupSelector: #~=)]]. + + "build a warning message to tell about all broken methods at once" + warningMessage := String streamContents: [:s | + s nextPutAll: 'According to IEEE 754 comparing with a NaN should always return false, except ~= that should return true.'; cr. + s nextPutAll: 'All these methods failed to do so. They are either broken or call a broken one'. + brokenMethods do: [:e | s cr; print: e methodClass; nextPutAll: '>>'; print: e selector]]. + + "Redo the tests so as to eventually open a debugger on one of the failures" + brokenMethods := Set new. + comparand do: [:comp2 | + compareSelectors do: [:op2 | + self deny: (theNaN perform: op2 with: comp2) description: warningMessage. + self deny: (comp2 perform: op2 with: theNaN) description: warningMessage]. + self assert: (theNaN ~= comp2) description: warningMessage. + self assert: (comp2 ~= theNaN) description: warningMessage].!

1 0

The Trunk: Kernel-nice.250.mcz
by commits＠source.squeak.org 26 Sep '09

26 Sep '09

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.250.mcz ==================== Summary ==================== Name: Kernel-nice.250 Author: nice Time: 25 September 2009, 10:47:10 am UUID: ae2ecb83-4bd9-fd4d-abf8-2b02d30ba0a9 Ancestors: Kernel-ar.249 Fix nan comparison from http://bugs.squeak.org/view.php?id=6719 Note: the fix does use adpatToXXX:andSend: instead of proposed adpatToXXX:andCompare: This way, it is independant of http://bugs.squeak.org/view.php?id=3374 (I don't want to fight now with lengthy argumentation) =============== Diff against Kernel-ar.249 =============== Item was added: + ----- Method: Fraction>>>= (in category 'comparing') ----- + >= aNumber + aNumber isFraction ifTrue: + [^ numerator * aNumber denominator >= (aNumber numerator * denominator)]. + ^ aNumber adaptToFraction: self andSend: #>=! Item was added: + ----- Method: Fraction>><= (in category 'comparing') ----- + <= aNumber + aNumber isFraction ifTrue: + [^ numerator * aNumber denominator <= (aNumber numerator * denominator)]. + ^ aNumber adaptToFraction: self andSend: #<=! Item was added: + ----- Method: ScaledDecimal>>> (in category 'comparing') ----- + > operand + "Implementation of Number 'comparing' method." + (operand isKindOf: ScaledDecimal) ifTrue: [^ fraction > operand asFraction]. + ^ operand adaptToScaledDecimal: self andSend: #>! Item was added: + ----- Method: Fraction>>> (in category 'comparing') ----- + > aNumber + aNumber isFraction ifTrue: + [^ numerator * aNumber denominator > (aNumber numerator * denominator)]. + ^ aNumber adaptToFraction: self andSend: #>! Item was added: + ----- Method: Integer>><= (in category 'comparing') ----- + <= aNumber + aNumber isInteger ifTrue: + [self negative == aNumber negative + ifTrue: [self negative + ifTrue: [^ (self digitCompare: aNumber) >= 0] + ifFalse: [^ (self digitCompare: aNumber) <= 0]] + ifFalse: [^ self negative]]. + ^ aNumber adaptToInteger: self andSend: #<=! Item was changed: ----- Method: Magnitude>>>= (in category 'comparing') ----- >= aMagnitude "Answer whether the receiver is greater than or equal to the argument." + ^aMagnitude <= self! - ^(self < aMagnitude) not! Item was added: + ----- Method: ScaledDecimal>>>= (in category 'comparing') ----- + >= operand + "Implementation of Number 'comparing' method." + (operand isKindOf: ScaledDecimal) ifTrue: [^ fraction >= operand asFraction]. + ^ operand adaptToScaledDecimal: self andSend: #>=! Item was added: + ----- Method: Integer>>>= (in category 'comparing') ----- + >= aNumber + aNumber isInteger ifTrue: + [self negative == aNumber negative + ifTrue: [self negative + ifTrue: [^(self digitCompare: aNumber) <= 0] + ifFalse: [^(self digitCompare: aNumber) >= 0]] + ifFalse: [^ aNumber negative]]. + ^ aNumber adaptToInteger: self andSend: #>=! Item was added: + ----- Method: ScaledDecimal>><= (in category 'comparing') ----- + <= operand + "Implementation of Number 'comparing' method." + (operand isKindOf: ScaledDecimal) ifTrue: [^ fraction <= operand asFraction]. + ^ operand adaptToScaledDecimal: self andSend: #<=!

1 0

The Trunk: CollectionsTests-nice.97.mcz
by commits＠source.squeak.org 25 Sep '09

25 Sep '09

Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-nice.97.mcz ==================== Summary ==================== Name: CollectionsTests-nice.97 Author: nice Time: 25 September 2009, 8:31:56 am UUID: 4faed0c6-ac60-e145-b88d-be50d2569c01 Ancestors: CollectionsTests-ar.96 Test from http://bugs.squeak.org/view.php?id=7095 Assert this feature: Dictionary>>#collect: should preserve the keys =============== Diff against CollectionsTests-ar.96 =============== Item was added: + ----- Method: DictionaryTest>>testCollect (in category 'testing') ----- + testCollect + "Ensure that Dictionary>>collect: answers a dictionary not something else" + | dict expected result | + dict := Dictionary newFromPairs:{ + #first. 1. + #second. 2. + #third. 3. + #fourth. 4. + #fifth. 5. + }. + result := dict collect:[:each| each asWords]. + expected := Dictionary newFromPairs:{ + #first. 'one'. + #second. 'two'. + #third. 'three'. + #fourth. 'four'. + #fifth. 'five'. + }. + self assert: result = expected.! Item was added: + ----- Method: DictionaryTest>>testSelect (in category 'testing') ----- + testSelect + "Ensure that Dictionary>>select: answers a dictionary not something else" + | dict expected result | + dict := Dictionary newFromPairs:{ + #first. 1. + #second. 2. + #third. 3. + #fourth. 4. + #fifth. 5. + }. + result := dict select:[:each| each odd]. + expected := Dictionary newFromPairs:{ + #first. 1. + #third. 3. + #fifth. 5. + }. + self assert: result = expected.! Item was added: + ----- Method: DictionaryTest>>testReject (in category 'testing') ----- + testReject + "Ensure that Dictionary>>reject: answers a dictionary not something else" + | dict expected result | + dict := Dictionary newFromPairs:{ + #first. 1. + #second. 2. + #third. 3. + #fourth. 4. + #fifth. 5. + }. + result := dict reject:[:each| each odd]. + expected := Dictionary newFromPairs:{ + #second. 2. + #fourth. 4. + }. + self assert: result = expected.!

1 0

The Trunk: Collections-nice.136.mcz
by commits＠source.squeak.org 25 Sep '09

25 Sep '09

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.136.mcz ==================== Summary ==================== Name: Collections-nice.136 Author: nice Time: 25 September 2009, 8:28:33 am UUID: 814571f9-fe2a-4547-ae41-f0733a647794 Ancestors: Collections-nice.135 Fix from http://bugs.squeak.org/view.php?id=7095 RATIONALE: Dictionary>>#collect: should preserve the keys 1) This is the ANSI specification 2) This is very logical A Dictionary is a Bag of values indexed by unique, arbitrary keys. OLD BEHAVIOUR CRITIC: The old behaviour consisting in returning an OrderedCollection is wrong, at least for these reasons: a Dictionary is unordered, and there is no reason to reassign keys (1 to: self size) with a random order... BACKWARD COMPATIBILITY ISSUE: Those relying on old behaviour should replace their code with something like: aDictionary values asOrderedCollection collect: aBlock. or: (OrderedCollection newFrom: aDictionary) collect: aBlock. =============== Diff against Collections-nice.135 =============== Item was added: + ----- Method: Dictionary class>>newFromPairs: (in category 'instance creation') ----- + newFromPairs: anArray + + "Answer an instance of me associating (anArray at:i) to (anArray at: i+i) + for each odd i. anArray must have an even number of entries." + + | newDictionary | + + newDictionary := self new: (anArray size/2). + 1 to: (anArray size-1) by: 2 do: [ :i| + newDictionary at: (anArray at: i) put: (anArray at: i+1). + ]. + ^ newDictionary + + " Dictionary newFromPairs: {'Red' . Color red . 'Blue' . Color blue . 'Green' . Color green}. "! Item was changed: ----- Method: Dictionary>>collect: (in category 'enumerating') ----- collect: aBlock "Evaluate aBlock with each of my values as the argument. Collect the resulting values into a collection that is like me. Answer with the new collection." | newCollection | + newCollection := self species new. + self associationsDo:[:each | + newCollection at: each key put: (aBlock value: each value). + ]. + ^newCollection! - newCollection := OrderedCollection new: self size. - self do: [:each | newCollection add: (aBlock value: each)]. - ^ newCollection!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
37
Older →

Jump to page: